Squeak-dev July 2014

squeak-dev@lists.squeakfoundation.org

31 participants
223 discussions

The Trunk: Collections.spur-eem.578.mcz
by commits＠source.squeak.org 29 Jul '14

29 Jul '14

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections.spur-eem.578.mcz ==================== Summary ==================== Name: Collections.spur-eem.578 Author: eem Time: 28 July 2014, 6:39:28.596 pm UUID: b5458afc-6ef5-45d7-8cb0-0f0dfb402aa1 Ancestors: Collections-eem.578 Collections-eem.578 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.174 Implement peekLast in TranscriptStream. Implement WriteStream>>ensureEndsWith: in terms of peekLast. =============== Diff against Collections-eem.578 =============== Item was changed: ==== ERROR === Error: Unrecognized class type 29 July 2014 4:42:49.33 am VM: unix - a SmalltalkImage Image: Squeak3.11alpha [latest update: #8824] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /home/squeaksource Trusted Dir /home/squeaksource/secure Untrusted Dir /home/squeaksource/My Squeak MCClassDefinition(Object)>>error: Receiver: a MCClassDefinition(Character) Arguments and temporary variables: aString: 'Unrecognized class type' Receiver's instance variables: name: #Character superclassName: #Magnitude variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc... category: #'Collections-Strings' type: #immediate comment: 'I represent a character by storing its associated Unicode. The first ...etc... commentStamp: 'ar 4/9/2005 22:35' traitComposition: nil classTraitComposition: nil MCClassDefinition>>kindOfSubclass Receiver: a MCClassDefinition(Character) Arguments and temporary variables: Receiver's instance variables: name: #Character superclassName: #Magnitude variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc... category: #'Collections-Strings' type: #immediate comment: 'I represent a character by storing its associated Unicode. The first ...etc... commentStamp: 'ar 4/9/2005 22:35' traitComposition: nil classTraitComposition: nil MCClassDefinition>>printDefinitionOn: Receiver: a MCClassDefinition(Character) Arguments and temporary variables: stream: a WriteStream Receiver's instance variables: name: #Character superclassName: #Magnitude variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc... category: #'Collections-Strings' type: #immediate comment: 'I represent a character by storing its associated Unicode. The first ...etc... commentStamp: 'ar 4/9/2005 22:35' traitComposition: nil classTraitComposition: nil [] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition: Receiver: a MCDiffyTextWriter Arguments and temporary variables: definition: a WriteStream s: a MCClassDefinition(Character) Receiver's instance variables: stream: a WriteStream initStream: nil --- The full stack --- MCClassDefinition(Object)>>error: MCClassDefinition>>kindOfSubclass MCClassDefinition>>printDefinitionOn: [] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - String class(SequenceableCollection class)>>new:streamContents: String class(SequenceableCollection class)>>streamContents: MCDiffyTextWriter(MCTextWriter)>>chunkContents: MCDiffyTextWriter(MCStWriter)>>writeClassDefinition: MCDiffyTextWriter(MCStWriter)>>visitClassDefinition: MCClassDefinition>>accept: [] in MCDiffyTextWriter(MCTextWriter)>>visitInFork: String class(SequenceableCollection class)>>new:streamContents: String class(SequenceableCollection class)>>streamContents: MCDiffyTextWriter(MCTextWriter)>>visitInFork: MCDiffyTextWriter>>writePatchFrom:to: MCDiffyTextWriter>>writeModification: [] in MCDiffyTextWriter>>writePatch: SortedCollection(OrderedCollection)>>do: MCDiffyTextWriter>>writePatch: SSDiffyTextWriter>>writePatch: [] in SSDiffyTextWriter>>writeVersion:for: BlockClosure>>on:do: SSDiffyTextWriter>>writeVersion:for: [] in SSEMailSubscription>>versionAdded:to: BlockClosure>>on:do: SSEMailSubscription>>versionAdded:to: [] in [] in SSProject>>versionAdded: [] in BlockClosure>>newProcess

1 0

The Trunk: Collections.spur-nice.577.mcz
by commits＠source.squeak.org 29 Jul '14

29 Jul '14

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections.spur-nice.577.mcz ==================== Summary ==================== Name: Collections.spur-nice.577 Author: eem Time: 28 July 2014, 6:39:29.586 pm UUID: 8d4ae901-a0a9-472b-82e9-d805ab3357bc Ancestors: Collections-nice.577 Collections-nice.577 patched for Spur by SpurBootstrapMonticelloPackagePatcher Cog-eem.174 Convert Base64MimeConverter implementation from ReadWriteStream to alternate WriteStream/ReadStream. Beware, the main class messages now answer a ReadStream, not a ReadWriteStream. =============== Diff against Collections-nice.577 =============== Item was changed: ==== ERROR === Error: Unrecognized class type 29 July 2014 4:41:42.701 am VM: unix - a SmalltalkImage Image: Squeak3.11alpha [latest update: #8824] SecurityManager state: Restricted: false FileAccess: true SocketAccess: true Working Dir /home/squeaksource Trusted Dir /home/squeaksource/secure Untrusted Dir /home/squeaksource/My Squeak MCClassDefinition(Object)>>error: Receiver: a MCClassDefinition(Character) Arguments and temporary variables: aString: 'Unrecognized class type' Receiver's instance variables: name: #Character superclassName: #Magnitude variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc... category: #'Collections-Strings' type: #immediate comment: 'I represent a character by storing its associated Unicode. The first ...etc... commentStamp: 'ar 4/9/2005 22:35' traitComposition: nil classTraitComposition: nil MCClassDefinition>>kindOfSubclass Receiver: a MCClassDefinition(Character) Arguments and temporary variables: Receiver's instance variables: name: #Character superclassName: #Magnitude variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc... category: #'Collections-Strings' type: #immediate comment: 'I represent a character by storing its associated Unicode. The first ...etc... commentStamp: 'ar 4/9/2005 22:35' traitComposition: nil classTraitComposition: nil MCClassDefinition>>printDefinitionOn: Receiver: a MCClassDefinition(Character) Arguments and temporary variables: stream: a WriteStream Receiver's instance variables: name: #Character superclassName: #Magnitude variables: an OrderedCollection(a MCClassVariableDefinition(CharacterTable) a M...etc... category: #'Collections-Strings' type: #immediate comment: 'I represent a character by storing its associated Unicode. The first ...etc... commentStamp: 'ar 4/9/2005 22:35' traitComposition: nil classTraitComposition: nil [] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition: Receiver: a MCDiffyTextWriter Arguments and temporary variables: definition: a WriteStream s: a MCClassDefinition(Character) Receiver's instance variables: stream: a WriteStream initStream: nil --- The full stack --- MCClassDefinition(Object)>>error: MCClassDefinition>>kindOfSubclass MCClassDefinition>>printDefinitionOn: [] in MCDiffyTextWriter(MCStWriter)>>writeClassDefinition: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - String class(SequenceableCollection class)>>new:streamContents: String class(SequenceableCollection class)>>streamContents: MCDiffyTextWriter(MCTextWriter)>>chunkContents: MCDiffyTextWriter(MCStWriter)>>writeClassDefinition: MCDiffyTextWriter(MCStWriter)>>visitClassDefinition: MCClassDefinition>>accept: [] in MCDiffyTextWriter(MCTextWriter)>>visitInFork: String class(SequenceableCollection class)>>new:streamContents: String class(SequenceableCollection class)>>streamContents: MCDiffyTextWriter(MCTextWriter)>>visitInFork: MCDiffyTextWriter>>writePatchFrom:to: MCDiffyTextWriter>>writeModification: [] in MCDiffyTextWriter>>writePatch: SortedCollection(OrderedCollection)>>do: MCDiffyTextWriter>>writePatch: SSDiffyTextWriter>>writePatch: [] in SSDiffyTextWriter>>writeVersion:for: BlockClosure>>on:do: SSDiffyTextWriter>>writeVersion:for: [] in SSEMailSubscription>>versionAdded:to: BlockClosure>>on:do: SSEMailSubscription>>versionAdded:to: [] in [] in SSProject>>versionAdded: [] in BlockClosure>>newProcess

1 0

Daily Commit Log
by commits＠source.squeak.org 29 Jul '14

29 Jul '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-July/007210.html Name: Graphics-nice.299 Ancestors: Graphics-nice.298 Continue cleaning of RWBinaryOrTextStream reset uggliness: - don't reset the stream in ImageReadWriter initialization (>>on:) - reset the stream after sending #understandsImageFormat: - make sure the stream is still binary after the reset in JPEGReadWriter class>>understandsImageFormat: - NOTE: from what I understand, RWBinaryOrTextStream and it's Multi alternative are those loosing the binary property, not FileStream... These swiss knife streams are really a next of undue complexity. This workaround should go away when we finally get rid of them. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007211.html Name: Collections-eem.578 Ancestors: Collections-nice.577 Implement peekLast in TranscriptStream. Implement WriteStream>>ensureEndsWith: in terms of peekLast. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007212.html Name: Collections-nice.579 Ancestors: Collections-eem.578 Implement #peekLast in RWBinaryOrTextStream because it has to care whether isBinary or not. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007213.html Name: Collections-nice.580 Ancestors: Collections-nice.579 peekLast commit and try again... ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007214.html Name: CollectionsTests-nice.222 Ancestors: CollectionsTests-nice.221 Document how peekLast and peekBack should work when sent to a RWBinaryOrTextStream. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007215.html Name: System-nice.682 Ancestors: System-nice.681 Use peekLast in ReferenceStream rather than skip: -1; next. This is now going to work on a simple WriteStream (no ReadWriteStream requirement). Note: I don't understand what was a uggly workaround, the fact to peekLast, or (byteStream skip: 0)? If it's (byteStream skip: 0), I don't know what it works around, and I just cross fingers... The sole reference google got me was too far and too light http://st-www.cs.illinois.edu/squeak/Squeak2.0/updates/152hide&show-LG-… ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-July/007216.html Name: System-nice.683 Ancestors: System-nice.682 Let a WriteStream be smart by moving the capability to fileOutClass:andObject: up from ReadWriteStream. Note: I really don't believe that any of these messages belongs to a Stream hierarchy. But disentangling the stream mess means loosen more than one knot, and I don't want the operation to look like conjuring, we need a careful trace for understanding, dissecting and reverting the potentially lost features, so one change at a time. =============================================

1 0

The Trunk: System-nice.683.mcz
by commits＠source.squeak.org 29 Jul '14

29 Jul '14

Nicolas Cellier uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-nice.683.mcz ==================== Summary ==================== Name: System-nice.683 Author: nice Time: 29 July 2014, 12:07:06.101 am UUID: fd9d9bb4-8ac8-4c13-a4dc-db69df7b35ed Ancestors: System-nice.682 Let a WriteStream be smart by moving the capability to fileOutClass:andObject: up from ReadWriteStream. Note: I really don't believe that any of these messages belongs to a Stream hierarchy. But disentangling the stream mess means loosen more than one knot, and I don't want the operation to look like conjuring, we need a careful trace for understanding, dissecting and reverting the potentially lost features, so one change at a time. =============== Diff against System-nice.682 =============== Item was removed: - ----- Method: ReadWriteStream>>fileOutChangeSet:andObject: (in category '*System-Object Storage-fileIn/Out') ----- - fileOutChangeSet: aChangeSetOrNil andObject: theObject - "Write a file that has both the source code for the named class and an object as bits. Any instance-specific object will get its class written automatically." - - "An experimental version to fileout a changeSet first so that a project can contain its own classes" - - - self setFileTypeToObject. - "Type and Creator not to be text, so can attach correctly to an email msg" - self header; timeStamp. - - aChangeSetOrNil ifNotNil: [ - aChangeSetOrNil fileOutPreambleOn: self. - aChangeSetOrNil fileOutOn: self. - aChangeSetOrNil fileOutPostscriptOn: self. - ]. - self trailer. "Does nothing for normal files. HTML streams will have trouble with object data" - - "Append the object's raw data" - (SmartRefStream on: self) - nextPut: theObject; "and all subobjects" - close. "also closes me" - ! Item was removed: - ----- Method: ReadWriteStream>>fileOutChanges (in category '*System-Object Storage-fileIn/Out') ----- - fileOutChanges - "Append to the receiver a description of all class changes." - Cursor write showWhile: - [self header; timeStamp. - ChangeSet current fileOutOn: self. - self trailer; close]! Item was removed: - ----- Method: ReadWriteStream>>fileOutClass:andObject: (in category '*System-Object Storage-fileIn/Out') ----- - fileOutClass: extraClass andObject: theObject - "Write a file that has both the source code for the named class and an object as bits. Any instance-specific object will get its class written automatically." - - | class srefStream | - self setFileTypeToObject. - "Type and Creator not to be text, so can attach correctly to an email msg" - self text. - self header; timeStamp. - - extraClass ifNotNil: [ - class := extraClass. "A specific class the user wants written" - class sharedPools size > 0 ifTrue: - [class shouldFileOutPools - ifTrue: [class fileOutSharedPoolsOn: self]]. - class fileOutOn: self moveSource: false toFile: 0]. - self trailer. "Does nothing for normal files. HTML streams will have trouble with object data" - self binary. - - "Append the object's raw data" - srefStream := SmartRefStream on: self. - srefStream nextPut: theObject. "and all subobjects" - srefStream close. "also closes me" - ! Item was removed: - ----- Method: ReadWriteStream>>fileOutClass:andObject:blocking: (in category '*System-Object Storage-fileIn/Out') ----- - fileOutClass: extraClass andObject: theObject blocking: anIdentDict - "Write a file that has both the source code for the named class and an object as bits. Any instance-specific object will get its class written automatically. Accept a list of objects to map to nil or some other object (blockers). In addition to teh choices in each class's objectToStoreOnDataStream" - - | class srefStream | - self setFileTypeToObject. - "Type and Creator not to be text, so can attach correctly to an email msg" - self header; timeStamp. - - extraClass ifNotNil: [ - class := extraClass. "A specific class the user wants written" - class sharedPools size > 0 ifTrue: - [class shouldFileOutPools - ifTrue: [class fileOutSharedPoolsOn: self]]. - class fileOutOn: self moveSource: false toFile: 0]. - self trailer. "Does nothing for normal files. HTML streams will have trouble with object data" - - "Append the object's raw data" - srefStream := SmartRefStream on: self. - srefStream blockers: anIdentDict. - srefStream nextPut: theObject. "and all subobjects" - srefStream close. "also closes me" - ! Item was added: + ----- Method: WriteStream>>fileOutChangeSet:andObject: (in category '*System-Object Storage-fileIn/Out') ----- + fileOutChangeSet: aChangeSetOrNil andObject: theObject + "Write a file that has both the source code for the named class and an object as bits. Any instance-specific object will get its class written automatically." + + "An experimental version to fileout a changeSet first so that a project can contain its own classes" + + + self setFileTypeToObject. + "Type and Creator not to be text, so can attach correctly to an email msg" + self header; timeStamp. + + aChangeSetOrNil ifNotNil: [ + aChangeSetOrNil fileOutPreambleOn: self. + aChangeSetOrNil fileOutOn: self. + aChangeSetOrNil fileOutPostscriptOn: self. + ]. + self trailer. "Does nothing for normal files. HTML streams will have trouble with object data" + + "Append the object's raw data" + (SmartRefStream on: self) + nextPut: theObject; "and all subobjects" + close. "also closes me" + ! Item was added: + ----- Method: WriteStream>>fileOutChanges (in category '*System-Object Storage-fileIn/Out') ----- + fileOutChanges + "Append to the receiver a description of all class changes." + Cursor write showWhile: + [self header; timeStamp. + ChangeSet current fileOutOn: self. + self trailer; close]! Item was added: + ----- Method: WriteStream>>fileOutClass:andObject: (in category '*System-Object Storage-fileIn/Out') ----- + fileOutClass: extraClass andObject: theObject + "Write a file that has both the source code for the named class and an object as bits. Any instance-specific object will get its class written automatically." + + | class srefStream | + self setFileTypeToObject. + "Type and Creator not to be text, so can attach correctly to an email msg" + self text. + self header; timeStamp. + + extraClass ifNotNil: [ + class := extraClass. "A specific class the user wants written" + class sharedPools size > 0 ifTrue: + [class shouldFileOutPools + ifTrue: [class fileOutSharedPoolsOn: self]]. + class fileOutOn: self moveSource: false toFile: 0]. + self trailer. "Does nothing for normal files. HTML streams will have trouble with object data" + self binary. + + "Append the object's raw data" + srefStream := SmartRefStream on: self. + srefStream nextPut: theObject. "and all subobjects" + srefStream close. "also closes me" + ! Item was added: + ----- Method: WriteStream>>fileOutClass:andObject:blocking: (in category '*System-Object Storage-fileIn/Out') ----- + fileOutClass: extraClass andObject: theObject blocking: anIdentDict + "Write a file that has both the source code for the named class and an object as bits. Any instance-specific object will get its class written automatically. Accept a list of objects to map to nil or some other object (blockers). In addition to teh choices in each class's objectToStoreOnDataStream" + + | class srefStream | + self setFileTypeToObject. + "Type and Creator not to be text, so can attach correctly to an email msg" + self header; timeStamp. + + extraClass ifNotNil: [ + class := extraClass. "A specific class the user wants written" + class sharedPools size > 0 ifTrue: + [class shouldFileOutPools + ifTrue: [class fileOutSharedPoolsOn: self]]. + class fileOutOn: self moveSource: false toFile: 0]. + self trailer. "Does nothing for normal files. HTML streams will have trouble with object data" + + "Append the object's raw data" + srefStream := SmartRefStream on: self. + srefStream blockers: anIdentDict. + srefStream nextPut: theObject. "and all subobjects" + srefStream close. "also closes me" + ! Item was added: + ----- Method: WriteStream>>padToEndWith: (in category '*System-Object Storage-fileIn/Out') ----- + padToEndWith: aChar + "We don't have pages, so we are at the end, and don't need to pad."! Item was added: + ----- Method: WriteStream>>setFileTypeToObject (in category '*System-Object Storage-fileIn/Out') ----- + setFileTypeToObject + + "ignore"!

1 0

The Trunk: System-nice.682.mcz
by commits＠source.squeak.org 28 Jul '14

28 Jul '14

Nicolas Cellier uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-nice.682.mcz ==================== Summary ==================== Name: System-nice.682 Author: nice Time: 28 July 2014, 11:38:58.476 pm UUID: f38c414b-25fc-4c7c-ab24-c2d05b1699cf Ancestors: System-nice.681 Use peekLast in ReferenceStream rather than skip: -1; next. This is now going to work on a simple WriteStream (no ReadWriteStream requirement). Note: I don't understand what was a uggly workaround, the fact to peekLast, or (byteStream skip: 0)? If it's (byteStream skip: 0), I don't know what it works around, and I just cross fingers... The sole reference google got me was too far and too light http://st-www.cs.illinois.edu/squeak/Squeak2.0/updates/152hide&show-LG-tk.cs =============== Diff against System-nice.681 =============== Item was changed: ----- Method: ReferenceStream>>beginInstance:size: (in category 'writing') ----- beginInstance: aClass size: anInteger "This is for use by storeDataOn: methods. Cf. Object>>storeDataOn:." "Addition of 1 seems to make extra work, since readInstance has to compensate. Here for historical reasons dating back to Kent Beck's original implementation in late 1988. In ReferenceStream, class is just 5 bytes for shared symbol. SmartRefStream puts out the names and number of class's instances variables for checking. 6/10/97 16:09 tk: See if we can put on a short header. Type = 16. " | short ref | short := true. "All tests for object header that can be written in 4 bytes" anInteger <= 254 ifFalse: [short := false]. "one byte size" ref := references at: aClass name ifAbsent: [short := false. nil]. ref isInteger ifFalse: [short := false]. short ifTrue: [short := (ref < 65536) & (ref > 0) "& (ref ~= self vacantRef)"]. "vacantRef is big" + short ifTrue: [short := byteStream peekLast = 9]. "ugly workaround" - short ifTrue: [ - byteStream skip: -1. - short := byteStream next = 9. - byteStream skip: 0]. "ugly workaround" short ifTrue: ["passed all the tests!!" byteStream skip: -1; nextPut: 16; "type = short header" nextPut: anInteger + 1; "size is short" nextNumber: 2 put: ref] ifFalse: [ "default to normal longer object header" byteStream nextNumber: 4 put: anInteger + 1. self nextPut: aClass name]. insideASegment ifTrue: [ aClass isSystemDefined ifFalse: [self nextPut: aClass]]. "just record it to put it into roots"!

1 0

The Trunk: CollectionsTests-nice.222.mcz
by commits＠source.squeak.org 28 Jul '14

28 Jul '14

Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-nice.222.mcz ==================== Summary ==================== Name: CollectionsTests-nice.222 Author: nice Time: 28 July 2014, 10:43:39.917 pm UUID: 1e0d0129-d0ea-44d0-9dc1-684240a6a12e Ancestors: CollectionsTests-nice.221 Document how peekLast and peekBack should work when sent to a RWBinaryOrTextStream. =============== Diff against CollectionsTests-nice.221 =============== Item was added: + ----- Method: RWBinaryOrTextStreamTest>>testPeekBack (in category 'tests') ----- + testPeekBack + + | stream | + stream := RWBinaryOrTextStream on: String new. + stream nextPutAll: 'world'. + self assert: $l equals: stream peekBack. + stream binary. + stream nextPutAll: #[98 105 110 97 114 121].. + self assert: 114 equals: stream peekBack.! Item was added: + ----- Method: RWBinaryOrTextStreamTest>>testPeekLast (in category 'tests') ----- + testPeekLast + + | stream | + stream := RWBinaryOrTextStream on: String new. + stream nextPutAll: 'world'. + self assert: $d equals: stream peekLast. + stream binary. + stream nextPutAll: #[98 105 110 97 114 121]. + self assert: 121 equals: stream peekLast. + stream reset. + self assert: nil equals: stream peekLast.!

1 0

The Trunk: Collections-nice.580.mcz
by commits＠source.squeak.org 28 Jul '14

28 Jul '14

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.580.mcz ==================== Summary ==================== Name: Collections-nice.580 Author: nice Time: 28 July 2014, 10:42:04.046 pm UUID: 5f8aabc7-d706-48e6-8d68-e591c6d00176 Ancestors: Collections-nice.579 peekLast commit and try again... =============== Diff against Collections-nice.579 =============== Item was changed: ----- Method: RWBinaryOrTextStream>>peekLast (in category 'accessing') ----- peekLast "Return that item just put at the end of the stream" ^ position > 0 ifTrue: [self isBinary + ifTrue: [(collection at: position) asInteger] + ifFalse: [(collection at: position) asCharacter]] - ifTrue: [(collection at: position) asCharacter] - ifFalse: [(collection at: position) asInteger]] ifFalse: [nil]!

1 0

The Trunk: Collections-nice.579.mcz
by commits＠source.squeak.org 28 Jul '14

28 Jul '14

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.579.mcz ==================== Summary ==================== Name: Collections-nice.579 Author: nice Time: 28 July 2014, 10:32:31.105 pm UUID: ef7ba0ca-4d01-4aac-9236-a968a13d7eae Ancestors: Collections-eem.578 Implement #peekLast in RWBinaryOrTextStream because it has to care whether isBinary or not. =============== Diff against Collections-eem.578 =============== Item was added: + ----- Method: RWBinaryOrTextStream>>peekLast (in category 'accessing') ----- + peekLast + "Return that item just put at the end of the stream" + + ^ position > 0 + ifTrue: [self isBinary + ifTrue: [(collection at: position) asCharacter] + ifFalse: [(collection at: position) asInteger]] + ifFalse: [nil]!

1 0

Can we change the meaning of peekBack?
by Nicolas Cellier 28 Jul '14

28 Jul '14

Hi, I need to retrieve the last object put on a Stream (well SmartRefStream does). This is very much like #ensureEndsWith: There is back, but back leave the stream positionned before the last object. ((ReadWriteStream on: String new) nextPutAll: 'abc'; back) -> $c ((ReadWriteStream on: String new) nextPutAll: 'abc'; back; position) -> 2. There is peekBack, but peekBack answers the last but one... ((ReadWriteStream on: String new) nextPutAll: 'abc'; peekBack) -> $b. ((ReadWriteStream on: String new) nextPutAll: 'abc'; peekBack; position) -> 3. Note that neither back nor peekBack is understood by a WriteStream. It requires a ReadWriteStream. Since peekBack is the sole sender of oldBack in trunk, I wonder who is using it? I ask because I'd like to change the meaning of peekBack to that of back instead of oldBack. Unless you have a better selector to propose?

2 3

The Trunk: Collections-eem.578.mcz
by commits＠source.squeak.org 28 Jul '14

28 Jul '14

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.578.mcz ==================== Summary ==================== Name: Collections-eem.578 Author: eem Time: 28 July 2014, 9:59:54.044 am UUID: 5ecf4e5c-8071-4cba-b887-144271ecfa61 Ancestors: Collections-nice.577 Implement peekLast in TranscriptStream. Implement WriteStream>>ensureEndsWith: in terms of peekLast. =============== Diff against Collections-nice.577 =============== Item was removed: - ----- Method: TranscriptStream>>ensureEndsWith: (in category 'accessing') ----- - ensureEndsWith: anObject - "Append anObject to the receiver IFF there is not one on the end." - - lastChar = anObject ifTrue: [^self]. - super ensureEndsWith: anObject! Item was added: + ----- Method: TranscriptStream>>peekLast (in category 'character writing') ----- + peekLast + "Return that item just put at the end of the stream" + + ^ position > 0 + ifTrue: [collection at: position] + ifFalse: [lastChar]! Item was changed: ----- Method: WriteStream>>ensureEndsWith: (in category 'accessing') ----- ensureEndsWith: anObject "Append anObject to the receiver IFF there is not one on the end." + self peekLast = anObject ifFalse: + [self nextPut: anObject]! - (position > 0 and: [(collection at: position) = anObject]) ifTrue: [^self]. - self nextPut: anObject!

1 0

← Newer
1
2
3
4
5
6
7
8
...
23
Older →

Jump to page: