Squeak-dev September 2014

squeak-dev@lists.squeakfoundation.org

49 participants
162 discussions

Start a nNew thread

Bad value for Random seed ?
by Stéphane Rollandin 21 Sep '14

21 Sep '14

Hello, (Random seed: 16457315536128) nextInt: 11 gives -1853 Am I missing something ? Stef

4 8

Re: [squeak-dev] The Trunk: Collections-nice.582.mcz
by Levente Uzonyi 21 Sep '14

21 Sep '14

Cool. I think the spaceship operator for strings should use #compare:with:collated: to save a comparison in the most common case. The performance of symbols would be close to dyadic blocks, if it were cheap and easy to create a block on the fly. Levente On Fri, 19 Sep 2014, commits(a)source.squeak.org wrote: > Nicolas Cellier uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-nice.582.mcz > > ==================== Summary ==================== > > Name: Collections-nice.582 > Author: nice > Time: 19 September 2014, 10:22:13.338 pm > UUID: 52a598f1-224e-4649-a95f-4e78547b5ed5 > Ancestors: Collections-nice.581 > > Port TAG-SortFunctions of Travis Griggs from Cincom public store - version (11,tgriggs) > > Note that no collation policy were used for String. > The spaceship operator <=> is also required in Kernel-Numbers. > > See also the blog http://objology.blogspot.fr/2010/11/tag-sortfunctions.html > and http://objology.blogspot.fr/2010/11/tag-sortfunctions-redux.html > > Note about the cost of these sort functions: > as shown by this mini-bench on cog, using a Symbol costs a bit more (perform:) than a block activation, and monadic block a bit more than dyadic one because activated twice more, but it seems acceptable to me with regard to the great simplification and expressiveness of code : > > | collec1 collec2 collec3 | > collec1 := (1 to: 200000) collect: [:i | 1000000 atRandom-500000]. > collec2 := collec1 copy. > collec3 := collec1 copy. > { > [collec1 sort: [:a :b | a abs < b abs]] timeToRun. > [collec2 sort: [:e | e abs] ascending] timeToRun. > [collec3 sort: #abs ascending] timeToRun. > } > #(345 532 912) >

2 3

The Inbox: Kernel-ul.874.mcz
by commits＠source.squeak.org 21 Sep '14

21 Sep '14

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.874.mcz ==================== Summary ==================== Name: Kernel-ul.874 Author: ul Time: 21 September 2014, 7:24:24.087 pm UUID: b39db5fc-8e25-4059-98d5-5ffbdd608e76 Ancestors: Kernel-nice.873 Random changes: - fixed off-by-one error in #next - seed is always a Float - added #hashSeed: which can be used to produce a better initial seed. Small seeds will result in less random first value. - seed is forced between 0 and 2^31-1 if it's out of range using #hashSeed: - simplified #initialize. 0 is not a bad seed value - fixed #nextValue's comment and simplified the implementation a bit - added clarification to #nextInt:'s comment - sped up #bucketTest: on the class side =============== Diff against Kernel-nice.873 =============== Item was changed: ----- Method: Random class>>bucketTest: (in category 'testing') ----- bucketTest: randy "Execute this: Random bucketTest: Random new" " A quick-and-dirty bucket test. Prints nbuckets values on the Transcript. Each should be 'near' the value of ntries. Any run with any value 'far' from ntries indicates something is very wrong. Each run generates different values. For a slightly better test, try values of nbuckets of 200-1000 or more; go get coffee. This is a poor test; see Knuth. Some 'OK' runs: 1000 1023 998 969 997 1018 1030 1019 1054 985 1003 1011 987 982 980 982 974 968 1044 976 1029 1011 1025 1016 997 1019 991 954 968 999 991 978 1035 995 988 1038 1009 988 993 976 " | nbuckets buckets ntrys | nbuckets := 200. buckets := Array new: nbuckets. buckets atAllPut: 0. ntrys := 1000. ntrys*nbuckets timesRepeat: [ | slot | slot := (randy next * nbuckets) floor + 1. buckets at: slot put: (buckets at: slot) + 1 ]. Transcript cr. 1 to: nbuckets do: [ :nb | + Transcript print: (buckets at: nb); space ]. + Transcript flush! - Transcript show: (buckets at: nb) printString, ' ' ]! Item was added: + ----- Method: Random>>hashSeed: (in category 'initialization') ----- + hashSeed: anInteger + " Use the 32-bit version of the FNV-1a algorithm to hash the seed. Keep only 31 bits during the calculation. " + + | fnvPrime hash | + fnvPrime := 16777619 " 32-bit FVN prime ". + hash := anInteger negative + ifTrue: [ 1342966192 " mix in the sign as (2166136261 bitXor: 2r1010101) * 16777619 bitAnd: 16r7FFFFFFF "] + ifFalse: [ 2166136261 " 32-bit FVN offset basis "]. + 1 to: anInteger digitLength do: [ :index | + hash := (hash bitXor: (anInteger digitAt: index)) * fnvPrime bitAnd: 16r7FFFFFFF ]. + seed := hash asFloat! Item was changed: ----- Method: Random>>initialize (in category 'initialization') ----- initialize + " Set a reasonable Park-Miller starting seed " + | hash newSeed | + hash := self hash hashMultiply. + newSeed := Time primUTCMicrosecondClock. + newSeed isZero ifTrue: [ " microsecond clock not available " + newSeed := Time millisecondClockValue ]. + seed := ((newSeed bitAnd: 16r7FFFFFFF) bitXor: hash) asFloat! - | hash | - hash := self hash. - "Set a reasonable Park-Miller starting seed" - seed := Time primUTCMicrosecondClock. - seed = 0 ifFalse: [ "Use the microsecond clock if possible." - seed := (seed bitAnd: 16r3FFFFFFF) bitXor: hash ]. - [ seed = 0 ] whileTrue: [ "Try again if ever get a seed = 0, or there's no microsecond clock." - seed := (Time millisecondClockValue bitAnd: 16r3FFFFFFF) bitXor: hash ]! Item was changed: ----- Method: Random>>next (in category 'accessing') ----- next "Answer a random Float in the interval [0 to 1)." + ^ (seed := self nextValue) - 1.0 / M! - ^ (seed := self nextValue) / M! Item was changed: ----- Method: Random>>nextInt: (in category 'accessing') ----- nextInt: anInteger + " Answer a random integer in the interval [1, anInteger]. anInteger should be less than 16r80000000. " - "Answer a random integer in the interval [1, anInteger]." anInteger strictlyPositive ifFalse: [ self error: 'Range must be positive' ]. ^ (self next * anInteger) truncated + 1! Item was changed: ----- Method: Random>>nextValue (in category 'private') ----- nextValue + "This method generates random instances of Integer in the interval 1 to 16r7FFFFFFF. This method does NOT update the seed; repeated sends answer the same value. - "This method generates random instances of Integer in the interval - 0 to 16r7FFFFFFF. This method does NOT update the seed; repeated sends - answer the same value. The algorithm is described in detail in 'Random Number Generators: Good Ones Are Hard to Find' by Stephen K. Park and Keith W. Miller (Comm. Asso. Comp. Mach., 31(10):1192--1201, 1988)." + | lo hi aLoRHi | + hi := seed quo: Q. + lo := seed - (Q * hi). " = seed rem: q" - | lo hi aLoRHi answer | - hi := (seed quo: Q) asFloat. - lo := seed - (hi * Q). " = seed rem: q" aLoRHi := (A * lo) - (R * hi). + aLoRHi > 0.0 ifTrue: [ ^aLoRHi ]. + ^aLoRHi + M! - answer := (aLoRHi > 0.0) - ifTrue: [aLoRHi] - ifFalse: [aLoRHi + M]. - ^ answer! Item was changed: ----- Method: Random>>seed: (in category 'initialization') ----- + seed: anInteger + " Use this 31-bit nonnegative integer as seed. Generate a valid seed using a hash function if it's out of range. " + + (anInteger between: 0 and: 16r7FFFFFFF) + ifTrue: [ seed := anInteger asFloat ] + ifFalse: [ self hashSeed: anInteger ]! - seed: anInteger - seed := anInteger!

1 0

Re: [squeak-dev] The Trunk: Collections-nice.582.mcz
by Bernhard Pieber 20 Sep '14

20 Sep '14

This is API is really cool. Thanks Travis and Nicolas! Cheers, Bernhard Am 19.09.2014 um 20:24 schrieb commits(a)source.squeak.org: > Nicolas Cellier uploaded a new version of Collections to project The Trunk: > http://source.squeak.org/trunk/Collections-nice.582.mcz > > ==================== Summary ==================== > > Name: Collections-nice.582 > Author: nice > Time: 19 September 2014, 10:22:13.338 pm > UUID: 52a598f1-224e-4649-a95f-4e78547b5ed5 > Ancestors: Collections-nice.581 > > Port TAG-SortFunctions of Travis Griggs from Cincom public store - version (11,tgriggs) > > Note that no collation policy were used for String. > The spaceship operator <=> is also required in Kernel-Numbers. > > See also the blog http://objology.blogspot.fr/2010/11/tag-sortfunctions.html > and http://objology.blogspot.fr/2010/11/tag-sortfunctions-redux.html > > Note about the cost of these sort functions: > as shown by this mini-bench on cog, using a Symbol costs a bit more (perform:) than a block activation, and monadic block a bit more than dyadic one because activated twice more, but it seems acceptable to me with regard to the great simplification and expressiveness of code : > > | collec1 collec2 collec3 | > collec1 := (1 to: 200000) collect: [:i | 1000000 atRandom-500000]. > collec2 := collec1 copy. > collec3 := collec1 copy. > { > [collec1 sort: [:a :b | a abs < b abs]] timeToRun. > [collec2 sort: [:e | e abs] ascending] timeToRun. > [collec3 sort: #abs ascending] timeToRun. > } > #(345 532 912) > > =============== Diff against Collections-nice.581 =============== > > Item was added: > + SortFunction subclass: #ChainedSortFunction > + instanceVariableNames: 'next' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'Collections-Support'! > + > + !ChainedSortFunction commentStamp: 'nice 3/13/2014 22:25' prior: 0! > + I add to my parent the idea of a "next" function to use when two objects are equal by my particular collator. > + > + Usage > + > + SortFunctions can be chained together in primary, secondary, tertiary, etc order using the comma method. Consider a sequence of customer objects, where each customer object responds to the messages firstName, lastName, and age. If we want to sort them lastName first, then firstName, and finally oldest first, we would use an expression like: > + > + customers sort: #lastName ascending, #firstName ascending, #age descending > + > + As noted in my super's comment, unary symbols or single arg blocks can be used. One can omit the the ascending methods on arguments (not the receiver), it will default blocks or symbols to be ascending if none is specified. In other words, the above expression could be simplified slightly as > + > + customers sort: #lastName ascending, #firstName, #age descending > + > + (note the missing ascending on the #firstName argument) > + > + Instance Variables > + next <SortFunction> the next SortFunction to evaluate in the event my evaluator results in equal values. > + > + ! > > Item was added: > + ----- Method: ChainedSortFunction>>, (in category 'converting') ----- > + , aSortFunction > + > + self next: next , aSortFunction! > > Item was added: > + ----- Method: ChainedSortFunction>>next: (in category 'initialize-release') ----- > + next: anObject > + > + next := anObject! > > Item was added: > + ----- Method: ChainedSortFunction>>value:value: (in category 'evaluating') ----- > + value: anObject value: bObject > + "Refinement of the parent behavior. If the result of my collator is 0, then pass on to the next variable to work it out." > + > + | result | > + result := (collator value: anObject value: bObject) * direction. > + ^result isZero > + ifTrue: [next value: anObject value: bObject] > + ifFalse: [result < 0]! > > Item was added: > + Object subclass: #SortFunction > + instanceVariableNames: 'direction collator' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'Collections-Support'! > + > + !SortFunction commentStamp: 'nice 3/13/2014 22:24' prior: 0! > + I am intended to be used in place of two arg sort blocks. > + > + Usage > + > + In the following example, an ascending SortFunction is created based on the result of the #first message send to each object. > + #(#(1 2) #(2 3) #(0 0)) sorted: #first ascending. > + > + To sort by the #last element, but descending, the following would be used: > + #(#(1 2) #(2 3) #(0 0)) sorted: #last descending. > + > + One can use blocks as well. The following sorts in descending order, the sub elements based on the sum of their values. > + | sumBlock | > + sumBlock := [:sequence | sequence inject: 0 into: [:sum :each | sum + each]]. > + #(#(1 2) #(2 3) #(0 0)) sorted: sumBlock descending. > + > + One can even use 2 arg blocks, for those cases where the function isn't expressible with objects that respond to < and =. The only catch, is that such a function has to return not true and false, but instead a collation order, values of -1 (for before), 0 (the same) or 1 (to follow). For example: > + > + | oddBlock | > + oddBlock := > + [:a :b | > + a odd = b odd ifTrue: [0] ifFalse: [a odd ifTrue: [-1] ifFalse: [1]]]. > + #(1 5 1 3 2 7 9 4 6) asSortedCollection: oddBlock descending > + > + Instance Variables > + collator <BlockClosure> This is the collation function that must return a -1, 0, or 1. It is usually composed by an initialization method such as sendMessage: or monadicBlock:, but may be set directly. > + direction <SmallInteger> 1 for ascending, -1 for descending > + > + ! > > Item was added: > + ----- Method: SortFunction class>>ascend (in category 'instance creation') ----- > + ascend > + > + ^self new ascend! > > Item was added: > + ----- Method: SortFunction class>>descend (in category 'instance creation') ----- > + descend > + > + ^self new descend! > > Item was added: > + ----- Method: SortFunction>>, (in category 'converting') ----- > + , aSortFunction > + "Return a new SortFunction which is the concatenation of aSortFunction to me, I will be the primary sort, but if I compare equal, I will defer to the argument." > + > + ^(ChainedSortFunction new) > + collator: collator; > + direction: direction; > + next: aSortFunction asSortFunction! > > Item was added: > + ----- Method: SortFunction>>asSortFunction (in category 'converting') ----- > + asSortFunction > + > + ^self! > > Item was added: > + ----- Method: SortFunction>>ascend (in category 'initailize-release') ----- > + ascend > + > + direction := 1! > > Item was added: > + ----- Method: SortFunction>>collator: (in category 'initailize-release') ----- > + collator: a2ArgBlock > + "a2ArgBlock MUST return the collation order, -1, 0, or 1" > + > + collator := a2ArgBlock! > > Item was added: > + ----- Method: SortFunction>>descend (in category 'initailize-release') ----- > + descend > + > + direction := -1! > > Item was added: > + ----- Method: SortFunction>>direction: (in category 'initailize-release') ----- > + direction: anInteger > + > + direction := anInteger! > > Item was added: > + ----- Method: SortFunction>>isAscending (in category 'testing') ----- > + isAscending > + > + ^direction = 1! > > Item was added: > + ----- Method: SortFunction>>isDescending (in category 'testing') ----- > + isDescending > + > + ^direction = -1! > > Item was added: > + ----- Method: SortFunction>>monadicBlock: (in category 'initailize-release') ----- > + monadicBlock: aSingleArgBlock > + "Initialze the receiver's collation block to compare the results of evaluating aSingleArgBlock with each argument, and then collate the return values with the <=> method." > + > + collator := [:a :b | (aSingleArgBlock value: a) <=> (aSingleArgBlock value: b)]! > > Item was added: > + ----- Method: SortFunction>>sendMessage: (in category 'initailize-release') ----- > + sendMessage: aUnarySymbol > + "Initialze the receiver's collation block to compare the results of sending aUnarySymbol to each argument, and then collate them with the <=> method." > + > + collator := [:a :b | (a perform: aUnarySymbol) <=> (b perform: aUnarySymbol)]! > > Item was added: > + ----- Method: SortFunction>>toggleDirection (in category 'converting') ----- > + toggleDirection > + "Invert my current direction, if I'm currently ascending, this will cause me to be descending now, and vice-versa." > + > + direction := direction * -1! > > Item was added: > + ----- Method: SortFunction>>value:value: (in category 'evaluating') ----- > + value: anObject value: bObject > + "Masquerade as a two argument block, used by many of the sorting APIs, by returning whether anObject should be placed before bObject or not." > + > + | result | > + result := (collator value: anObject value: bObject) * direction. > + ^result <= 0! > > Item was added: > + ----- Method: String>><=> (in category 'sorting') ----- > + <=> aCharacterArray > + "Return a collation order of -1, 0, or 1, indicating whether I should be collated before the receiver, am equal, or after. > + See also: http://en.wikipedia.org/wiki/Spaceship_operator" > + > + ^self = aCharacterArray > + ifTrue: [ 0 ] > + ifFalse: [self < aCharacterArray > + ifTrue: [ -1 ] > + ifFalse: [ 1 ]]! > > Item was added: > + ----- Method: Symbol>>asSortFunction (in category 'sorting') ----- > + asSortFunction > + > + ^self ascending! > > Item was added: > + ----- Method: Symbol>>ascending (in category 'sorting') ----- > + ascending > + "Return a SortFunction around the receiver, where the receiver will be used as a unary message to send to both a and b during sorting, and then the result of said send will be collated in ascending order using the <=> method." > + "Example: #('abc' 'de' 'fghi') sorted: #size asscending" > + > + ^SortFunction ascend sendMessage: self! > > Item was added: > + ----- Method: Symbol>>descending (in category 'sorting') ----- > + descending > + "Return a SortFunction around the receiver, where the receiver will be used as a unary message to send to both a and b during sorting, and then the result of said send will be collated in descending order using the <=> method." > + "Example: #('abc' 'de' 'fghi') sorted: #size descending" > + > + ^SortFunction descend sendMessage: self! > > Item was added: > + ----- Method: Text>><=> (in category 'sorting') ----- > + <=> aCharacterArray > + "Return a collation order of -1, 0, or 1, indicating whether I should be collated before the receiver, am equal, or after. > + See also: http://en.wikipedia.org/wiki/Spaceship_operator" > + > + ^string = aCharacterArray > + ifTrue: [ 0 ] > + ifFalse: [string < aCharacterArray asString > + ifTrue: [ -1 ] > + ifFalse: [ 1 ]]! > >

1 0

Recompile of Mac VM 4.2.5beta
by Javier Diaz-Reinoso 20 Sep '14

20 Sep '14

I tested the VM with the '0 tinyBenchmarks' and the results are similar to the original, so I am sending a link to the zip file with the results, the files contains: - Squeak 4.2.5beta2U.zip, the VM recompiled, I copied the external plugins from the original. - SqueakVMUNIXPATHS.xcodeproj.zip, an updated xcodeproj for Xcode, this add links to InternetConfigPlugin.c and MacMenubarPlugin.c, this are not present in the trunk for Mac OS, I copied from the platforms/iOS/vm/src/vm/intplugins, I think the VMMaker of Mac OS needs to be modified, I copied the files to the corresponding directories in Mac OS/plugins/, also there are links to AsynchFilePlugin, SerialPlugin and SocketPlugin in the platforms/unix/. - Squeak VM Universal-Info.plist, an updated version, the only modification is the version, I updated to 4.2.5beta2 to distinguish from the original, I think is important if any problem is detected. I also try to compile the CameraPlugin and ScratchPlugin, but there are problems: the CameraPlugin access functions called CameraName, OpenCamera, etc.. not present in the Mac, ScratchPlugin have some functions similar to the UnixSerialPlugin, but at the moment neither are ready to be added to the VM. Link: > http://squeakvm.org/~lewis/MacOS-test-Javier/

2 1

Inefficiencies
by Bert Freudenberg 20 Sep '14

20 Sep '14

While working on my SqueakJS VM (which now can run a current 4.5 image) I'm discovering a lot of gross inefficiencies. I have no time (or much desire) to fix these, but would anybody think it's valuable if I post them here? For example: ScrollBar>>initializeSlider ScrollBar>>sliderColor: ScrollBar>>updateSliderColor: Color class>>gray: Color>>setRed:green:blue: Float>>rounded Float>>sign Float>>> Number>>adaptToFloat:andCompare: Float>>asTrueFraction Integer>>bitOr: ctx[5]=rcvr: 3436915608L ctx[6]=tmp0: 16r10000000000000L ctx[7]=tmp1: nil Converting a Float to an exact Fraction just to find out its sign seems very much unnecessary. And without the LargeInteger primitive support it also is really really slow. My VM-level debugger makes it easy to stop at any time and look what's taking so long, so that's how I come across these. - Bert -

6 7

Daily Commit Log
by commits＠source.squeak.org 20 Sep '14

20 Sep '14

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2014-September/007277.… Name: Collections-nice.582 Ancestors: Collections-nice.581 Port TAG-SortFunctions of Travis Griggs from Cincom public store - version (11,tgriggs) Note that no collation policy were used for String. The spaceship operator <=> is also required in Kernel-Numbers. See also the blog http://objology.blogspot.fr/2010/11/tag-sortfunctions.html and http://objology.blogspot.fr/2010/11/tag-sortfunctions-redux.html Note about the cost of these sort functions: as shown by this mini-bench on cog, using a Symbol costs a bit more (perform:) than a block activation, and monadic block a bit more than dyadic one because activated twice more, but it seems acceptable to me with regard to the great simplification and expressiveness of code : | collec1 collec2 collec3 | collec1 := (1 to: 200000) collect: [:i | 1000000 atRandom-500000]. collec2 := collec1 copy. collec3 := collec1 copy. { [collec1 sort: [:a :b | a abs < b abs]] timeToRun. [collec2 sort: [:e | e abs] ascending] timeToRun. [collec3 sort: #abs ascending] timeToRun. } #(345 532 912) ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-September/007278.… Name: Kernel-nice.873 Ancestors: Kernel-eem.872 Add spaceship operator support <=> usefull for sort functions. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-September/007279.… Name: Collections-nice.583 Ancestors: Collections-nice.582 Also classify these SortFunction support in *Collections rather than *Kernel ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-September/007280.… Name: CollectionsTests-nice.223 Ancestors: CollectionsTests-nice.222 Add some tests for sort functions support ============================================= http://lists.squeakfoundation.org/pipermail/packages/2014-September/007281.… Name: CollectionsTests-nice.223 Ancestors: CollectionsTests-nice.222 Add some tests for sort functions support =============================================

1 0

Re: [squeak-dev] The Trunk: CollectionsTests-nice.223.mcz
by Nicolas Cellier 19 Sep '14

19 Sep '14

Never mind, I've got an error about a connection timeout, thus retried, but it seems like it was superfluous... 2014-09-19 23:18 GMT+02:00 <commits(a)source.squeak.org>: > Nicolas Cellier uploaded a new version of CollectionsTests to project The > Trunk: > http://source.squeak.org/trunk/CollectionsTests-nice.223.mcz > > ==================== Summary ==================== > > Name: CollectionsTests-nice.223 > Author: nice > Time: 19 September 2014, 11:15:20.772 pm > UUID: f1a61e56-790b-457a-95fe-b3e149a460fb > Ancestors: CollectionsTests-nice.222 > > Add some tests for sort functions support > > =============== Diff against CollectionsTests-nice.222 =============== > > Item was added: > + TestCase subclass: #ChainedSortFunctionTest > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'CollectionsTests-Support'! > > Item was added: > + ----- Method: ChainedSortFunctionTest>>testEvaluation (in category > 'tests') ----- > + testEvaluation > + > + | function | > + function := #first ascending , [:a | a at: 2] descending , #last > ascending. > + "first different" > + self assert: (function value: #(1 2 3) value: #(2 2 3)). > + self deny: (function value: #(3 2 3) value: #(2 2 3)). > + "first the same" > + self assert: (function value: #(1 2 3) value: #(1 1 3)). > + self assert: (function value: #(1 2 2) value: #(1 1 3)). > + self assert: (function value: #(1 2 3) value: #(1 1 2)). > + self deny: (function value: #(1 2 3) value: #(1 3 3)). > + self deny: (function value: #(1 2 2) value: #(1 3 3)). > + self deny: (function value: #(1 2 3) value: #(1 3 2)). > + "first and second the same" > + self assert: (function value: #(1 2 3) value: #(1 2 3)). > + self assert: (function value: #(1 2 2) value: #(1 2 3)). > + self deny: (function value: #(1 2 4) value: #(1 2 3))! > > Item was added: > + TestCase subclass: #SortFunctionTest > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'CollectionsTests-Support'! > > Item was added: > + ----- Method: SortFunctionTest>>testDirectionToggling (in category > 'tests') ----- > + testDirectionToggling > + > + | function | > + function := #x ascending. > + self assert: (function value: 0 @ 2 value: 1 @ 1). > + self assert: (function value: 1 @ 2 value: 1 @ 1). > + self deny: (function value: 2 @ 2 value: 1 @ 1). > + function toggleDirection. > + self deny: (function value: 1 @ 2 value: 2 @ 1). > + self assert: (function value: 1 @ 2 value: 1 @ 1). > + self assert: (function value: 2 @ 2 value: 1 @ 1). > + function toggleDirection. > + self assert: (function value: 0 @ 2 value: 1 @ 1). > + self assert: (function value: 1 @ 2 value: 1 @ 1). > + self deny: (function value: 2 @ 2 value: 1 @ 1)! > > Item was added: > + ----- Method: SortFunctionTest>>testSingleArgBlock (in category 'tests') > ----- > + testSingleArgBlock > + > + | function block | > + block := [:point | point x / point y]. > + function := block ascending. > + self assert: (function value: 0 @ 2 value: 1 @ 1). > + self assert: (function value: 1 @ 2 value: 2 @ 4). > + self deny: (function value: 2 @ 2 value: 1 @ 2). > + function := block descending. > + self deny: (function value: 1 @ 2 value: 2 @ 1). > + self assert: (function value: 2 @ 2 value: 1 @ 1). > + self assert: (function value: 3 @ 2 value: 1 @ 1)! > > Item was added: > + ----- Method: SortFunctionTest>>testTwoArgBlock (in category 'tests') > ----- > + testTwoArgBlock > + > + | function block | > + block := > + [:a :b | > + a odd = b odd ifTrue: [0] ifFalse: [a odd ifTrue: > [-1] ifFalse: [1]]]. > + function := block ascending. > + self assert: (function value: 2 value: 4). > + self assert: (function value: 1 value: 3). > + self assert: (function value: 1 value: 4). > + self deny: (function value: -2 value: 1). > + function := block descending. > + self assert: (function value: 2 value: 4). > + self assert: (function value: 1 value: 3). > + self deny: (function value: 1 value: 4). > + self assert: (function value: -2 value: 1)! > > Item was added: > + ----- Method: SortFunctionTest>>testUnarySymbol (in category 'tests') > ----- > + testUnarySymbol > + > + | function | > + function := #x ascending. > + self assert: (function value: 0 @ 2 value: 1 @ 1). > + self assert: (function value: 1 @ 2 value: 1 @ 1). > + self deny: (function value: 2 @ 2 value: 1 @ 1). > + function := #x descending. > + self deny: (function value: 1 @ 2 value: 2 @ 1). > + self assert: (function value: 1 @ 2 value: 1 @ 1). > + self assert: (function value: 2 @ 2 value: 1 @ 1)! > > Item was added: > + TestCase subclass: #TestSpaceshipOperator > + instanceVariableNames: '' > + classVariableNames: '' > + poolDictionaries: '' > + category: 'CollectionsTests-Support'! > > Item was added: > + ----- Method: TestSpaceshipOperator>>testFloats (in category 'tests') > ----- > + testFloats > + > + | a b c d | > + a := 13.1. > + b := 18.9. > + c := 18.9. > + d := -7.2. > + self assert: (b <=> c) isZero. > + self assert: a <=> b = -1. > + self assert: b <=> a = 1. > + self assert: a <=> d = 1. > + self assert: d <=> a = -1! > > Item was added: > + ----- Method: TestSpaceshipOperator>>testStrings (in category 'tests') > ----- > + testStrings > + > + | a b c d | > + a := 'xc'. > + b := 'xd'. > + c := 'xd'. > + d := 'xa'. > + self assert: (b <=> c) isZero. > + self assert: a <=> b = -1. > + self assert: b <=> a = 1. > + self assert: a <=> d = 1. > + self assert: d <=> a = -1! > > >

1 0

The Trunk: CollectionsTests-nice.223.mcz
by commits＠source.squeak.org 19 Sep '14

19 Sep '14

Nicolas Cellier uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-nice.223.mcz ==================== Summary ==================== Name: CollectionsTests-nice.223 Author: nice Time: 19 September 2014, 11:15:20.772 pm UUID: f1a61e56-790b-457a-95fe-b3e149a460fb Ancestors: CollectionsTests-nice.222 Add some tests for sort functions support =============== Diff against CollectionsTests-nice.222 =============== Item was added: + TestCase subclass: #ChainedSortFunctionTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CollectionsTests-Support'! Item was added: + ----- Method: ChainedSortFunctionTest>>testEvaluation (in category 'tests') ----- + testEvaluation + + | function | + function := #first ascending , [:a | a at: 2] descending , #last ascending. + "first different" + self assert: (function value: #(1 2 3) value: #(2 2 3)). + self deny: (function value: #(3 2 3) value: #(2 2 3)). + "first the same" + self assert: (function value: #(1 2 3) value: #(1 1 3)). + self assert: (function value: #(1 2 2) value: #(1 1 3)). + self assert: (function value: #(1 2 3) value: #(1 1 2)). + self deny: (function value: #(1 2 3) value: #(1 3 3)). + self deny: (function value: #(1 2 2) value: #(1 3 3)). + self deny: (function value: #(1 2 3) value: #(1 3 2)). + "first and second the same" + self assert: (function value: #(1 2 3) value: #(1 2 3)). + self assert: (function value: #(1 2 2) value: #(1 2 3)). + self deny: (function value: #(1 2 4) value: #(1 2 3))! Item was added: + TestCase subclass: #SortFunctionTest + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CollectionsTests-Support'! Item was added: + ----- Method: SortFunctionTest>>testDirectionToggling (in category 'tests') ----- + testDirectionToggling + + | function | + function := #x ascending. + self assert: (function value: 0 @ 2 value: 1 @ 1). + self assert: (function value: 1 @ 2 value: 1 @ 1). + self deny: (function value: 2 @ 2 value: 1 @ 1). + function toggleDirection. + self deny: (function value: 1 @ 2 value: 2 @ 1). + self assert: (function value: 1 @ 2 value: 1 @ 1). + self assert: (function value: 2 @ 2 value: 1 @ 1). + function toggleDirection. + self assert: (function value: 0 @ 2 value: 1 @ 1). + self assert: (function value: 1 @ 2 value: 1 @ 1). + self deny: (function value: 2 @ 2 value: 1 @ 1)! Item was added: + ----- Method: SortFunctionTest>>testSingleArgBlock (in category 'tests') ----- + testSingleArgBlock + + | function block | + block := [:point | point x / point y]. + function := block ascending. + self assert: (function value: 0 @ 2 value: 1 @ 1). + self assert: (function value: 1 @ 2 value: 2 @ 4). + self deny: (function value: 2 @ 2 value: 1 @ 2). + function := block descending. + self deny: (function value: 1 @ 2 value: 2 @ 1). + self assert: (function value: 2 @ 2 value: 1 @ 1). + self assert: (function value: 3 @ 2 value: 1 @ 1)! Item was added: + ----- Method: SortFunctionTest>>testTwoArgBlock (in category 'tests') ----- + testTwoArgBlock + + | function block | + block := + [:a :b | + a odd = b odd ifTrue: [0] ifFalse: [a odd ifTrue: [-1] ifFalse: [1]]]. + function := block ascending. + self assert: (function value: 2 value: 4). + self assert: (function value: 1 value: 3). + self assert: (function value: 1 value: 4). + self deny: (function value: -2 value: 1). + function := block descending. + self assert: (function value: 2 value: 4). + self assert: (function value: 1 value: 3). + self deny: (function value: 1 value: 4). + self assert: (function value: -2 value: 1)! Item was added: + ----- Method: SortFunctionTest>>testUnarySymbol (in category 'tests') ----- + testUnarySymbol + + | function | + function := #x ascending. + self assert: (function value: 0 @ 2 value: 1 @ 1). + self assert: (function value: 1 @ 2 value: 1 @ 1). + self deny: (function value: 2 @ 2 value: 1 @ 1). + function := #x descending. + self deny: (function value: 1 @ 2 value: 2 @ 1). + self assert: (function value: 1 @ 2 value: 1 @ 1). + self assert: (function value: 2 @ 2 value: 1 @ 1)! Item was added: + TestCase subclass: #TestSpaceshipOperator + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: 'CollectionsTests-Support'! Item was added: + ----- Method: TestSpaceshipOperator>>testFloats (in category 'tests') ----- + testFloats + + | a b c d | + a := 13.1. + b := 18.9. + c := 18.9. + d := -7.2. + self assert: (b <=> c) isZero. + self assert: a <=> b = -1. + self assert: b <=> a = 1. + self assert: a <=> d = 1. + self assert: d <=> a = -1! Item was added: + ----- Method: TestSpaceshipOperator>>testStrings (in category 'tests') ----- + testStrings + + | a b c d | + a := 'xc'. + b := 'xd'. + c := 'xd'. + d := 'xa'. + self assert: (b <=> c) isZero. + self assert: a <=> b = -1. + self assert: b <=> a = 1. + self assert: a <=> d = 1. + self assert: d <=> a = -1!

1 0

The Trunk: CollectionsTests-nice.223.mcz
by commits＠source.squeak.org 19 Sep '14

19 Sep '14

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
17
Older →

Jump to page: