Squeak-dev February 2015

squeak-dev@lists.squeakfoundation.org

45 participants
152 discussions

The Trunk: System-mt.707.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.707.mcz ==================== Summary ==================== Name: System-mt.707 Author: mt Time: 27 February 2015, 2:09:13.348 pm UUID: 9d9412df-10ac-ec4d-b063-fd05ab91f576 Ancestors: System-mt.706 Old-style preference #roundedMenuCorners removed. See Morphic-mt.766 postload-script. =============== Diff against System-mt.706 =============== Item was removed: - ----- Method: Preferences class>>roundedMenuCorners (in category 'standard queries') ----- - roundedMenuCorners - ^ self - valueOfFlag: #roundedMenuCorners - ifAbsent: [ true ]!

1 0

The Trunk: ReleaseBuilder-mt.117.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of ReleaseBuilder to project The Trunk: http://source.squeak.org/trunk/ReleaseBuilder-mt.117.mcz ==================== Summary ==================== Name: ReleaseBuilder-mt.117 Author: mt Time: 27 February 2015, 2:07:56.803 pm UUID: 265cd4bc-1038-6149-8fb2-b7cb10991622 Ancestors: ReleaseBuilder-topa.116 Updated to use pragma-style preference for #roundedMenuCorners. =============== Diff against ReleaseBuilder-topa.116 =============== Item was changed: ----- Method: ReleaseBuilder class>>setPreferences (in category 'private') ----- setPreferences Workspace shouldStyle: false. SystemWindow reuseWindows: true. TextEditor autoEnclose: true ; autoIndent: false ; destructiveBackWord: false ; blinkingCursor: false ; dumbbellCursor: false. BalloonMorph setBalloonColorTo: (TranslucentColor r: 0.92 g: 0.92 b: 0.706 alpha: 0.75). Preferences installBrightWindowColors ; insertionPointColor: Color red ; enable: #scrollBarsWithoutMenuButton ; enable: #gradientScrollBars ; enable: #swapMouseButtons ; enable: #annotationPanes ; disable: #showSplitterHandles ; enable: #showBoundsInHalo ; disable: #alternateHandlesLook ; - disable: #roundedMenuCorners ; disable: #roundedWindowCorners ; enable: #traceMessages ; enable: #thoroughSenders ; enable: #diffsWithPrettyPrint ; disable: #alwaysShowVScrollbar ; enable: #alternativeBrowseIt. ProportionalSplitterMorph smartHorizontalSplitters: false ; smartVerticalSplitters: false. PluggableButtonMorph roundedButtonCorners: false. FillInTheBlankMorph roundedDialogCorners: false. Workspace shouldStyle: false. NetNameResolver enableIPv6: false. + Browser listClassesHierarchically: true. + MenuMorph roundedMenuCorners: false.! - Browser listClassesHierarchically: true!

1 0

The Trunk: Morphic-mt.766.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.766.mcz ==================== Summary ==================== Name: Morphic-mt.766 Author: mt Time: 27 February 2015, 2:05:26.066 pm UUID: 1c861e43-3cbf-2649-bd3e-22d1d3d88803 Ancestors: Morphic-mt.765 Several cosmetic fixes considering dockingbar morphs and menu morphs. #roundedMenuCorners is now a pragma-style preference. Several magic numbers could be removed. =============== Diff against Morphic-mt.765 =============== Item was changed: ----- Method: DockingBarItemMorph>>adjacentTo (in category 'selecting') ----- adjacentTo + + | roundedCornersOffset | + roundedCornersOffset := MenuMorph roundedMenuCorners + ifTrue: [Morph preferredCornerRadius negated] + ifFalse: [0]. + - owner isFloating + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ 4)}]. - ifTrue: [^ {self bounds bottomLeft + (4 @ 4)}]. owner isAdheringToTop + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ 4)}]. - ifTrue: [^ {self bounds bottomLeft + (4 @ 4)}]. owner isAdheringToLeft + ifTrue: [^ {self bounds topRight + (roundedCornersOffset @ 4)}]. - ifTrue: [^ {self bounds topRight + (4 @ 4)}]. owner isAdheringToBottom + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ 4)}]. - ifTrue: [^ {self bounds topLeft + (4 @ 4)}]. owner isAdheringToRight + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ -4)}]. + ^ {self bounds bottomLeft + (roundedCornersOffset @ 5)}! - ifTrue: [^ {self bounds topLeft + (4 @ -4)}]. - ^ {self bounds bottomLeft + (3 @ 5)}! Item was changed: ----- Method: DockingBarMorph>>activeSubmenu: (in category 'control') ----- activeSubmenu: aSubmenu activeSubMenu isNil ifFalse: [activeSubMenu delete]. activeSubMenu := aSubmenu. aSubmenu isNil ifTrue: [^ self]. activeSubMenu updateMenu. activeSubMenu selectItem: nil event: nil. MenuIcons decorateMenu: activeSubMenu. activeSubMenu activatedFromDockingBar: self; - borderColor: self borderColor; beSticky; resistsRemoval: true; removeMatchString! Item was changed: ----- Method: DockingBarMorph>>updateColor (in category 'private - layout') ----- updateColor "private - update the receiver's color" | fill | + self autoGradient ifFalse: [ + self color ~= originalColor ifTrue: [self color: originalColor]. + ^ self]. - self autoGradient - ifFalse: [^ self]. "" fill := GradientFillStyle ramp: self gradientRamp. "" fill origin: self topLeft. self isVertical ifTrue: [fill direction: self width @ 0] ifFalse: [fill direction: 0 @ self height]. "" self fillStyle: fill! Item was changed: ----- Method: MenuItemMorph>>adjacentTo (in category 'selecting') ----- adjacentTo + ^{ self outerBounds topRight. self bounds topLeft }! - ^{ self bounds topRight + (10 @ 0). self bounds topLeft }! Item was changed: AlignmentMorph subclass: #MenuMorph instanceVariableNames: 'defaultTarget selectedItem stayUp popUpOwner activeSubMenu' + classVariableNames: 'CloseBoxImage GradientMenu PushPinImage RoundedMenuCorners' - classVariableNames: 'CloseBoxImage GradientMenu PushPinImage' poolDictionaries: '' category: 'Morphic-Menus'! !MenuMorph commentStamp: '<historical>' prior: 0! Instance variables: defaultTarget <Object> The default target for creating menu items selectedItem <MenuItemMorph> The currently selected item in the receiver stayUp <Boolean> True if the receiver should stay up after clicks popUpOwner <MenuItemMorph> The menu item that automatically invoked the receiver, if any. activeSubMenu <MenuMorph> The currently active submenu.! Item was changed: ----- Method: MenuMorph class>>gradientMenu: (in category 'preferences') ----- gradientMenu: aBoolean GradientMenu := aBoolean. + SystemProgressMorph reset. + + "Update docking bars and their sub-menus." + ActiveWorld mainDockingBars do: [:bar | + bar + autoGradient: aBoolean; + updateColor]. + TheWorldMainDockingBar updateInstances.! - SystemProgressMorph reset.! Item was added: + ----- Method: MenuMorph class>>roundedMenuCorners (in category 'preferences') ----- + roundedMenuCorners + + <preference: 'roundedMenuCorners' + category: #menus + description: 'Whether morphic menus should have rounded corners.' + type: #Boolean> + ^ RoundedMenuCorners ifNil: [true]! Item was added: + ----- Method: MenuMorph class>>roundedMenuCorners: (in category 'preferences') ----- + roundedMenuCorners: aBoolean + + RoundedMenuCorners := aBoolean. + SystemProgressMorph reset. + TheWorldMainDockingBar updateInstances.! Item was changed: ----- Method: MenuMorph>>addStayUpIcons (in category 'construction') ----- addStayUpIcons | title closeBox pinBox titleBarArea titleString | title := submorphs detect: [:ea | ea hasProperty: #titleString] ifNone: [self setProperty: #needsTitlebarWidgets toValue: true. ^ self]. closeBox := SystemWindowButton new target: self; actionSelector: #delete; labelGraphic: self class closeBoxImage; color: Color transparent; extent: 14 @ 16; borderWidth: 0. pinBox := SystemWindowButton new target: self; actionSelector: #stayUp:; arguments: {true}; labelGraphic: self class pushPinImage; color: Color transparent; extent: 16 @ 16; borderWidth: 0. Preferences noviceMode ifTrue: [closeBox setBalloonText: 'close this menu'. pinBox setBalloonText: 'keep this menu up']. titleBarArea := AlignmentMorph newRow vResizing: #shrinkWrap; layoutInset: 3; color: Preferences menuTitleColor; addMorphBack: closeBox; addMorphBack: title; addMorphBack: pinBox. title color: Color transparent. titleString := title findDeepSubmorphThat: [:each | each respondsTo: #font: ] ifAbsent: [StringMorph contents: String empty]. titleString font: Preferences windowTitleFont. + self wantsRoundedCorners - Preferences roundedMenuCorners ifTrue: [titleBarArea useRoundedCorners]. self addMorphFront: titleBarArea. titleBarArea setProperty: #titleString toValue: (title valueOfProperty: #titleString). title removeProperty: #titleString. self setProperty: #hasTitlebarWidgets toValue: true. self removeProperty: #needsTitlebarWidgets. self removeStayUpItems! Item was changed: ----- Method: MenuMorph>>initialize (in category 'initialization') ----- initialize super initialize. bounds := 0 @ 0 corner: 40 @ 10. self setDefaultParameters. self listDirection: #topToBottom. self hResizing: #shrinkWrap. self vResizing: #shrinkWrap. defaultTarget := nil. selectedItem := nil. stayUp := false. + popUpOwner := nil.! - popUpOwner := nil. - - Preferences roundedMenuCorners - ifTrue: [self useRoundedCorners]. - ! Item was changed: ----- Method: MenuMorph>>popUpAdjacentTo:forHand:from: (in category 'control') ----- popUpAdjacentTo: rightOrLeftPoint forHand: hand from: sourceItem + "Present this menu at the given point under control of the given hand." + + | tryToPlace selectedOffset rightPoint leftPoint | - "Present this menu at the given point under control of the given - hand." - | tryToPlace selectedOffset | hand world startSteppingSubmorphsOf: self. popUpOwner := sourceItem. + self fullBounds. + self updateColor. + - self updateColor. "ensure layout is current" selectedOffset := (selectedItem ifNil: [self items first]) position - self position. tryToPlace := [:where :mustFit | | delta | self position: where - selectedOffset. delta := self fullBoundsInWorld amountToTranslateWithin: sourceItem worldBounds. (delta x = 0 or: [mustFit]) ifTrue: [delta = (0 @ 0) ifFalse: [self position: self position + delta]. sourceItem owner owner addMorphFront: self. ^ self]]. + rightPoint := rightOrLeftPoint first + ((self layoutInset + self borderWidth) @ 0). + leftPoint := rightOrLeftPoint last - ((self layoutInset + self borderWidth + self width) @ 0). + tryToPlace + value: rightPoint value: false; + value: leftPoint value: false; + value: rightPoint value: true.! - tryToPlace value: rightOrLeftPoint first value: false; - value: rightOrLeftPoint last - (self width @ 0) value: false; - value: rightOrLeftPoint first value: true! Item was changed: ----- Method: MenuMorph>>setTitleParametersFor: (in category 'initialization') ----- setTitleParametersFor: aMenuTitle | menuTitleColor menuTitleBorderColor | + self wantsRoundedCorners - Preferences roundedMenuCorners ifTrue: [aMenuTitle useRoundedCorners]. menuTitleColor := Preferences menuColorFromWorld ifTrue: [self color darker] ifFalse: [Preferences menuTitleColor]. menuTitleBorderColor := Preferences menuAppearance3d ifTrue: [#inset] ifFalse: [Preferences menuColorFromWorld ifTrue: [self color darker muchDarker] ifFalse: [Preferences menuTitleBorderColor]]. aMenuTitle setColor: menuTitleColor borderWidth: Preferences menuTitleBorderWidth borderColor: menuTitleBorderColor; vResizing: #shrinkWrap; wrapCentering: #center; cellPositioning: #topCenter; layoutInset: 0. ! Item was added: + ----- Method: MenuMorph>>wantsRoundedCorners (in category 'rounding') ----- + wantsRoundedCorners + + ^ self class roundedMenuCorners or: [super wantsRoundedCorners]! Item was changed: ----- Method: SystemProgressMorph>>setDefaultParameters (in category 'initialization') ----- setDefaultParameters "change the receiver's appareance parameters" | colorFromMenu worldColor menuColor | colorFromMenu := Preferences menuColorFromWorld and: [Display depth > 4 and: [(worldColor := self currentWorld color) isColor]]. menuColor := colorFromMenu ifTrue: [worldColor luminance > 0.7 ifTrue: [worldColor mixed: 0.85 with: Color black] ifFalse: [worldColor mixed: 0.4 with: Color white]] ifFalse: [Preferences menuColor]. self color: menuColor. + MenuMorph roundedMenuCorners - Preferences roundedMenuCorners ifTrue: [self useRoundedCorners]. self borderWidth: Preferences menuBorderWidth. Preferences menuAppearance3d ifTrue: [ self borderStyle: BorderStyle thinGray. self addDropShadow; shadowColor: (TranslucentColor r: 0.0 g: 0.0 b: 0.0 alpha: 0.666); shadowOffset: 1 @ 1 ] ifFalse: [ | menuBorderColor | menuBorderColor := colorFromMenu ifTrue: [worldColor muchDarker] ifFalse: [Preferences menuBorderColor]. self borderColor: menuBorderColor. ]. self updateColor: self color: self color intensity: 1.! Item was changed: ----- Method: SystemWindow class>>updatePreferences (in category 'initializing') ----- updatePreferences "Temporary method to update system-wide preferences" Preferences setPreference: #defaultWindowColor toValue: (Color veryVeryLightGray muchLighter). (Preferences preferenceAt: #defaultWindowColor) defaultValue: (Color veryVeryLightGray muchLighter). Preferences setPreference: #menuAppearance3d toValue: true. (Preferences preferenceAt: #menuAppearance3d) defaultValue: true. Preferences setPreference: #menuColorFromWorld toValue: false. (Preferences preferenceAt: #menuColorFromWorld) defaultValue: false. + MenuMorph roundedMenuCorners: false. - Preferences setPreference: #roundedMenuCorners toValue: false. - (Preferences preferenceAt: #roundedMenuCorners) defaultValue: false. Preferences setParameter: #menuColor to: (Color gray: 0.9). Preferences setParameter: #menuTitleColor to: (Color transparent). Preferences setParameter: #menuTitleBorderWidth to: 0. Preferences setParameter: #defaultWorldColor to: (Color gray: 0.25). Preferences setPreference: #showSplitterHandles toValue: false. (Preferences preferenceAt: #showSplitterHandles) defaultValue: true. Preferences setPreference: #showSharedFlaps toValue: false. (Preferences preferenceAt: #showSharedFlaps) defaultValue: false. Preferences installBrightWindowColors. CornerGripMorph drawCornerResizeHandles: false. FillInTheBlankMorph roundedDialogCorners: true. LazyListMorph listSelectionColor: LazyListMorph listSelectionColor; listSelectionTextColor: Color black. PluggableButtonMorph roundedButtonCorners: true. SystemWindow clickOnLabelToEdit: false; doubleClickOnLabelToExpand: true; moveMenuButtonRight: true; hideExpandButton: false. ! Item was changed: ----- Method: TheWorldMainDockingBar>>createDockingBar (in category 'construction') ----- createDockingBar "Create a docking bar from the receiver's representation" | dockingBar | dockingBar := DockingBarMorph new adhereToTop; color: Preferences menuColor; gradientRamp: self gradientRamp; + autoGradient: MenuMorph gradientMenu; - autoGradient: ColorTheme current dockingBarAutoGradient; borderWidth: 0. self fillDockingBar: dockingBar. self labelIfNeeded: dockingBar. ^ dockingBar! Item was changed: (PackageInfo named: 'Morphic') postscript: '(Preferences dictionaryOfPreferences at: #alternativeWindowBoxesLook) defaultValue: false. "Force SystemProgressMorph to be reset" SystemProgressMorph initialize; reset. "Initialize the key bindings and menus" Editor initialize. "Retain scrollBar look now that the pref actually does something" Preferences enable: #gradientScrollBars. "apply the new icons" MenuIcons initializeIcons. TheWorldMainDockingBar updateInstances. "Cleanup old-style preferences here. Remove before new release." + Preferences removePreference: #gradientMenu. "Now in MenuMorph." + Preferences removePreference: #roundedMenuCorners. "Now in MenuMorph."'! - Preferences removePreference: #gradientMenu. "Now in MenuMorph."'!

1 0

The Trunk: Morphic-mt.765.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.765.mcz ==================== Summary ==================== Name: Morphic-mt.765 Author: mt Time: 27 February 2015, 11:49:50.36 am UUID: 448910f8-5f74-3549-9403-acf6b6acd9a3 Ancestors: Morphic-mt.764 Recategorized #preferredCornerRadius into all affected preference categories. =============== Diff against Morphic-mt.764 =============== Item was changed: ----- Method: Morph class>>preferredCornerRadius (in category 'preferences') ----- preferredCornerRadius <preference: 'Preferred Corner Radius' + categoryList: #(Morphic windows menus) - category: 'Morphic' description: 'If a morph wants rounded corners, use this radius. May be overwritten in subclasses.' type: #Number> ^ PreferredCornerRadius ifNil: [6]!

1 0

The Trunk: System-mt.706.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.706.mcz ==================== Summary ==================== Name: System-mt.706 Author: mt Time: 27 February 2015, 11:45:09.18 am UUID: 3175d70c-e137-1b40-91aa-4df3c1228235 Ancestors: System-mt.705 Re-activated possibility to have multiple categories for a single preference. Worked for old-style preferences, now works again for pragma-style preferences. Use #categoryList: instead of #category: in the pragma and provide an array of strings (or symbols). =============== Diff against System-mt.705 =============== Item was changed: ----- Method: Preferences class>>prefEvent: (in category 'dynamic preferences') ----- prefEvent: anEvent "Check if this system event defines or removes a preference. TODO: Queue the event and handle in background process. There is zero reason to be so eager here." | aClass aSelector prefSymbol method | (anEvent itemKind = SystemChangeNotifier classKind and: [anEvent isRemoved]) ifTrue:[self removePreferencesFor: anEvent item]. anEvent itemKind = SystemChangeNotifier methodKind ifTrue:[ aClass := anEvent itemClass. aClass isMeta ifFalse:[^self]. "ignore instance methods" aClass := aClass theNonMetaClass. aSelector := anEvent itemSelector. (anEvent isRemoved or:[anEvent isModified]) ifTrue:[ prefSymbol := (aClass name,'>>', aSelector) asSymbol. self accessDictionaryOfPreferencesIn: [ :dictionaryOfPreferences | dictionaryOfPreferences removeKey: prefSymbol ifAbsent:[] ] ]. (anEvent isAdded or:[anEvent isModified]) ifTrue:[ method := anEvent item. method pragmas do:[:pragma| | aPreference aPrefSymbol | + ((pragma keyword == #preference:category:description:type:) + or: [pragma keyword == #preference:categoryList:description:type:]) ifTrue:[ + aPrefSymbol := (aClass name,'>>', method selector) asSymbol. + aPreference := self + preference: pragma arguments first + category: pragma arguments second + description: pragma arguments third + type: pragma arguments fourth. + aPreference + provider: aClass + getter: method selector + setter: method selector asMutator. + self accessDictionaryOfPreferencesIn: [ :dictionaryOfPreferences | + dictionaryOfPreferences at: aPrefSymbol put: aPreference ] ] ] ] ]. - pragma keyword == #preference:category:description:type: ifTrue:[ - aPrefSymbol := (aClass name,'>>', method selector) asSymbol. - aPreference := self - preference: pragma arguments first - category: pragma arguments second - description: pragma arguments third - type: pragma arguments fourth. - aPreference - provider: aClass - getter: method selector - setter: method selector asMutator. - self accessDictionaryOfPreferencesIn: [ :dictionaryOfPreferences | - dictionaryOfPreferences at: aPrefSymbol put: aPreference ] ] ] ] ]. !

1 0

The Trunk: System-mt.705.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.705.mcz ==================== Summary ==================== Name: System-mt.705 Author: mt Time: 27 February 2015, 11:36:43.752 am UUID: faa11c89-248a-8348-a7be-2d40e6441ee2 Ancestors: System-topa.704 Auto-generated method for #gradientMenu removed because of postload-script in Morphic-mt.764. =============== Diff against System-topa.704 =============== Item was removed: - ----- Method: Preferences class>>gradientMenu (in category 'standard queries') ----- - gradientMenu - ^ self - valueOfFlag: #gradientMenu - ifAbsent: [ true ]!

1 0

The Trunk: Morphic-mt.764.mcz
by commits＠source.squeak.org 27 Feb '15

27 Feb '15

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.764.mcz ==================== Summary ==================== Name: Morphic-mt.764 Author: mt Time: 27 February 2015, 11:33:22.268 am UUID: 2ca4e315-b777-2847-830e-366884514d22 Ancestors: Morphic-ul.763 New pragma-preference for #gradientMenu to update SystemProgressbar instance accordingly. Postload-script will remove the old-style preference. =============== Diff against Morphic-ul.763 =============== Item was changed: ----- Method: DockingBarMorph>>initialize (in category 'initialize-release') ----- initialize "initialize the receiver" super initialize. selectedItem := nil. activeSubMenu := nil. fillsOwner := true. avoidVisibleBordersAtEdge := true. + autoGradient := MenuMorph gradientMenu. - autoGradient := Preferences gradientMenu. self setDefaultParameters ; beFloating ; beSticky ; layoutInset: 0 ; dropEnabled: true. Project current world activeHand addKeyboardListener: self! Item was changed: ----- Method: FillInTheBlankMorph>>updateColor:color:intensity: (in category 'initialization') ----- updateColor: aMorph color: aColor intensity: anInteger "update the apareance of aMorph" | fill | + MenuMorph gradientMenu - Preferences gradientMenu ifFalse: [^ self]. fill := GradientFillStyle ramp: {0.0 -> Color white. 1 -> aColor}. fill radial: false; origin: aMorph topLeft; direction: 0 @ aMorph height. aMorph fillStyle: fill! Item was changed: ----- Method: MenuItemMorph>>selectionFillStyle (in category 'private') ----- selectionFillStyle " Answer the fill style to use with the receiver is the selected element " | fill baseColor preferenced | Display depth <= 2 ifTrue: [ ^Color gray ]. preferenced := Preferences menuSelectionColor. preferenced notNil ifTrue: [ ^preferenced ]. baseColor := owner color negated. + MenuMorph gradientMenu ifFalse: [ ^baseColor ]. - Preferences gradientMenu ifFalse: [ ^baseColor ]. fill := GradientFillStyle ramp: { 0.0 -> baseColor twiceLighter. 1 -> baseColor twiceDarker }. fill origin: self topLeft. ^ fill! Item was changed: AlignmentMorph subclass: #MenuMorph instanceVariableNames: 'defaultTarget selectedItem stayUp popUpOwner activeSubMenu' + classVariableNames: 'CloseBoxImage GradientMenu PushPinImage' - classVariableNames: 'CloseBoxImage PushPinImage' poolDictionaries: '' category: 'Morphic-Menus'! !MenuMorph commentStamp: '<historical>' prior: 0! Instance variables: defaultTarget <Object> The default target for creating menu items selectedItem <MenuItemMorph> The currently selected item in the receiver stayUp <Boolean> True if the receiver should stay up after clicks popUpOwner <MenuItemMorph> The menu item that automatically invoked the receiver, if any. activeSubMenu <MenuMorph> The currently active submenu.! Item was added: + ----- Method: MenuMorph class>>gradientMenu (in category 'preferences') ----- + gradientMenu + + <preference: 'gradientMenu' + category: #menus + description: 'If true, the menus will have a gradient look.' + type: #Boolean> + ^ GradientMenu ifNil: [true]! Item was added: + ----- Method: MenuMorph class>>gradientMenu: (in category 'preferences') ----- + gradientMenu: aBoolean + + GradientMenu := aBoolean. + SystemProgressMorph reset.! Item was changed: ----- Method: MenuMorph>>updateColor (in category 'control') ----- updateColor | fill title | + self class gradientMenu - Preferences gradientMenu ifFalse: [^ self]. (self fillStyle == self color) not ifTrue: [^ self]. "Don't apply the gradient more than once" "" fill := GradientFillStyle ramp: {0.0 -> Color white. 1 -> self color}. "" fill radial: false; origin: self topLeft; direction: 0 @ self height. "" self fillStyle: fill. " update the title color" title := self allMorphs detect: [:each | each hasProperty: #titleString] ifNone: [^ self]. "" fill := GradientFillStyle ramp: {0.0 -> title color twiceLighter. 1 -> title color twiceDarker}. "" fill origin: title topLeft; direction: title width @ 0. "" title fillStyle: fill! Item was changed: ----- Method: SystemProgressMorph>>updateColor:color:intensity: (in category 'initialization') ----- updateColor: aMorph color: aColor intensity: anInteger "update the apareance of aMorph" | fill | + MenuMorph gradientMenu - Preferences gradientMenu ifFalse: [^ self]. fill := GradientFillStyle ramp: {0.0 -> Color white. 1 ->aColor}. fill radial: false; origin: aMorph topLeft; direction: 0 @ aMorph height. aMorph fillStyle: fill! Item was changed: (PackageInfo named: 'Morphic') postscript: '(Preferences dictionaryOfPreferences at: #alternativeWindowBoxesLook) defaultValue: false. "Force SystemProgressMorph to be reset" SystemProgressMorph initialize; reset. "Initialize the key bindings and menus" Editor initialize. "Retain scrollBar look now that the pref actually does something" Preferences enable: #gradientScrollBars. "apply the new icons" MenuIcons initializeIcons. TheWorldMainDockingBar updateInstances. + + "Cleanup old-style preferences here. Remove before new release." + Preferences removePreference: #gradientMenu. "Now in MenuMorph."'! - '!

1 0

Re: [squeak-dev] Re: Is there a preference setting to block automatic parentheses?
by Jakob Reschke 27 Feb '15

27 Feb '15

Hello, 2015-02-26 18:11 GMT+01:00 Chris Muller <asqueaker(a)gmail.com>: >> and how should I type Command+(? like, Command-Shift-9? Ok. > > Yes. > >> Why not '(' at that point. > > Because that is used to /replace/ the currently selected expression > with a new expression. Selection replace is how all editors work, and > we agreed we wish to minimize surprises and violations of typing > behavior invariants. > > 8< > > I think the problem of 2nd line > above becomes understandable to the user, and, if it is happening > "constantly" that they will like to learn and use the better way; of > selecting the expression and pressing Command+(.. I doubt that Command+( is a widely known or sufficiently advertised feature. In fact, before you mentioned it in this discussion I believed only OCompletion would provide this desirable feature (without Command) and I have used Squeak for 2.5 years. The keyboard shortcut list does mention it (and some more which I will happily use from now on) but the list starts out rather unhelpfully sorted if you want to discover "power-user" features and currently also contains some errors (or some shortcuts do not function correctly), but that is a different problem. Therefore, I would prefer when ( with selected text would surround that text with brackets instead of replacing it or at least Command+( etc. be advertised somehow. Personally, I am also fine with skipping brackets in the |))) --> )|)) case because I am used to it from Eclipse and might want to reach a place in between those brackets to add further arguments... but I would, like Bert if I understood him correctly, also prefer this behavior to stop and an additional parenthesis be inserted if the cursor has been moved with the arrow keys, by mouse click etc. And for the statistics, I also dislike "|foo" --> "(|)foo" (like most of us) and generally reaching for the navigation keys to write new code. Pharo's behavior as described by Martin seems like a good compromise to me. I also wonder how many people actually write or edit text with expressions first in mind, like you do, Chris. I figure it is a good idea for writing formulas (e. g. using a workspace as a calculator), but at least it did not come to my mind as such for coding (in languages where you "write in words" and parentheses are mostly written for the machine). Best regards, Jakob

1 0

Re: Is there a preference setting to block automatic parentheses?
by Bert Freudenberg 26 Feb '15

26 Feb '15

(moving to squeak-dev) > On 22.02.2015, at 14:40, Chris Muller <asqueaker(a)gmail.com> wrote: > >>>> Some people like this preference a lot. Others think it is horrible. >>> >>> This implmenentation is not the best. The one in E/OCompletion is better. >> >> I love the feature (in other editors), but hate its current behavior. If that one is better, why don't we use that? > > This preference is part of the low-level interface which affects the > overall fidelity of the Squeak user-experience. If we are going to > make any changes to this, may we please start it out in the Inbox The onus is actually on whoever enabled this feature by default before it was mature, IMNSHO. Until we fix it properly (see below) we need to turn it off. > where we can all try it and discuss it in more objective terms than > "love", "hate", "better" and "horrible"? "Horrible" is a technically accurate description in this case ;) Because it interferes with the user's wishes. It gets in the way unless you consciously anticipate how it's going to mess with what you type. And it doesn't have to, as other editors clearly demonstrate. If I am blindly typing (foo) I expect to end up with (foo) In current Squeak I end up with (foo)) which is clearly wrong and extremely annoying and makes me hate the feature. For an editor that gets it right, try ACE online ( http://ace.c9.io/ ). If an editor does auto-insertion, it *must* keep track of that and anticipate the user typing the corresponding characters. E.g. in ACE I can type [('foo and get [('foo')] but then I can proceed to type ')] end it will just skip over the auto-inserted part. Similarly in Squeak when typing [(2)+(3)] it results in [(2)+(3)]))] but in ACE it gets me [(2)+(3)] which is so obviously right I'm not even sure how anyone could argue Squeak's is not horribly broken. So, as others have pointed out, it's not that we don't want the editor to be helpful, it is a very useful feature, but it must be mindful of what the user wants. - Bert -

11 33

The Trunk: Morphic-ul.754.mcz
by commits＠source.squeak.org 26 Feb '15

26 Feb '15

Levente Uzonyi uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ul.754.mcz ==================== Summary ==================== Name: Morphic-ul.754 Author: ul Time: 18 January 2015, 8:33:51.264 pm UUID: 2e6f7fa2-e377-4374-99db-5be8fbad0013 Ancestors: Morphic-bf.753 Simplified and improved WorldState >> #interCyclePause: - don't create a new Delay (along with a new Semaphore) every 20 (or 50) milliseconds - use #millisecondsSince: to avoid the effects of the clock rollover - separated the code of time calculation and actual waiting Depends on Kernel-ul.893 =============== Diff against Morphic-bf.753 =============== Item was changed: Object subclass: #WorldState + instanceVariableNames: 'hands activeHand viewBox canvas damageRecorder stepList lastStepTime lastStepMessage lastCycleTime commandHistory alarms lastAlarmTime remoteServer multiCanvas interCycleDelay' - instanceVariableNames: 'hands activeHand viewBox canvas damageRecorder stepList lastStepTime lastStepMessage lastCycleTime commandHistory alarms lastAlarmTime remoteServer multiCanvas' classVariableNames: 'CanSurrenderToOS DeferredUIMessages DisableDeferredUpdates LastCycleTime MinCycleLapse' poolDictionaries: '' category: 'Morphic-Worlds'! !WorldState commentStamp: 'ls 7/10/2003 19:30' prior: 0! The state of a Morphic world. (This needs some serious commenting!!!!) The MinCycleLapse variable holds the minimum amount of time that a morphic cycle is allowed to take. If a cycle takes less than this, then interCyclePause: will wait until the full time has been used up.! Item was changed: ----- Method: WorldState>>interCyclePause: (in category 'update cycle') ----- interCyclePause: milliSecs "delay enough that the previous cycle plus the amount of delay will equal milliSecs. If the cycle is already expensive, then no delay occurs. However, if the system is idly waiting for interaction from the user, the method will delay for a proportionally long time and cause the overall CPU usage of Squeak to be low. If the preference #serverMode is enabled, always do a complete delay of 50ms, independant of my argument. This prevents the freezing problem described in Mantis #6581" + | millisecondsToWait | + millisecondsToWait := Preferences serverMode + ifTrue: [ 50 ] - | currentTime wait | - Preferences serverMode ifFalse: [ + (lastCycleTime notNil and: [CanSurrenderToOS ~~ false]) + ifTrue: [ milliSecs - (Time millisecondsSince: lastCycleTime) ] + ifFalse: [ 0 ] ]. + millisecondsToWait > 0 ifTrue: [ + interCycleDelay + ifNil: [ interCycleDelay := Delay forMilliseconds: millisecondsToWait ] + ifNotNil: [ interCycleDelay delayDuration: millisecondsToWait ]. + interCycleDelay wait ]. - (lastCycleTime notNil and: [CanSurrenderToOS ~~ false]) ifTrue: [ - currentTime := Time millisecondClockValue. - wait := lastCycleTime + milliSecs - currentTime. - (wait > 0 and: [ wait <= milliSecs ] ) ifTrue: [ - (Delay forMilliseconds: wait) wait ] ] ] - ifTrue: [ (Delay forMilliseconds: 50) wait ]. - lastCycleTime := Time millisecondClockValue. CanSurrenderToOS := true.!

1 0

← Newer
1
2
3
4
5
6
7
...
16
Older →

Jump to page: