Squeak-dev March 2015

squeak-dev@lists.squeakfoundation.org

40 participants
315 discussions

Daily Commit Log
by commits＠source.squeak.org 28 Mar '15

28 Mar '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-March/007697.html Name: System-eem.712 Ancestors: System-cmm.711 Fix allStoresInto: for pool variables. Shared pools are inherited and don't have to be declared in each subclass. =============================================

1 0

Squeak News Team
by Ron Teitelbaum 28 Mar '15

28 Mar '15

HI All, Hope everyone is doing well. Would anyone like to join the Squeak News Team to post articles on news.squeak.org. Please contact me if you are interested in helping out. I haven't had much time lately. I could use the help. All the best, Ron Teitelbaum

1 0

The Trunk: System-eem.712.mcz
by commits＠source.squeak.org 28 Mar '15

28 Mar '15

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.712.mcz ==================== Summary ==================== Name: System-eem.712 Author: eem Time: 27 March 2015, 5:04:05.02 pm UUID: a8efc46a-90e7-449f-bfae-88a53ef28257 Ancestors: System-cmm.711 Fix allStoresInto: for pool variables. Shared pools are inherited and don't have to be declared in each subclass. =============== Diff against System-cmm.711 =============== Item was changed: ----- Method: SystemNavigation>>allStoresInto:from: (in category 'query') ----- allStoresInto: varName from: aClass "Answer a sequence of MewthodReferences for all the receiver's methods or any methods of a subclass/superclass that assign to the instance variable name." "self new allStoresInto: 'contents' from: Collection." + | result roots | - | result | result := OrderedCollection new. (aClass theNonMetaClass inheritsFrom: SharedPool) ifTrue: + [roots := self allClasses select: [:class| class sharedPools includes: aClass theNonMetaClass]. + roots do: + [:root| + root withAllSubclassesDo: + [:class| + (class whichMethodsStoreInto: varName), + (class class whichMethodsStoreInto: varName) do: - [self allBehaviorsDo: - [:class| - (class theNonMetaClass sharedPools includes: aClass theNonMetaClass) ifTrue: - [(class whichMethodsStoreInto: varName) do: [:eachMethod| + result add: eachMethod methodReference]]]]. - result add: eachMethod methodReference]]]]. aClass withAllSubAndSuperclassesDo: [ : class | + (class whichMethodsStoreInto: varName), + (class class whichMethodsStoreInto: varName) do: - (class whichMethodsStoreInto: varName) do: [ : eachMethod | result add: eachMethod methodReference ] ]. ^result!

1 0

Daily Commit Log
by commits＠source.squeak.org 27 Mar '15

27 Mar '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-March/007694.html Name: Tools-topa.563 Ancestors: Tools-topa.562 Fix menu entry sort to actually match (intended) description ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-March/007695.html Name: Tools-topa.564 Ancestors: Tools-topa.563 Amend to: Fix menu entry sort to actually match (intended) description ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-March/007696.html Name: SUnitTools-topa.1 Ancestors: Provide browser integration for SUnit. - Indicate test status via tool icons - Run tests from context menu - Debug tests from context menu - Switch between tested and testing code via context menu (heursitically) This is featurewise modeled after the OmniBrowser SUnit-Integration. =============================================

1 0

Re: [squeak-dev] The Trunk: Tools-topa.562.mcz
by Chris Muller 27 Mar '15

27 Mar '15

What's a reportable slip? On Thu, Mar 26, 2015 at 4:34 PM, <commits(a)source.squeak.org> wrote: > Tobias Pape uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-topa.562.mcz > > ==================== Summary ==================== > > Name: Tools-topa.562 > Author: topa > Time: 26 March 2015, 10:34:40.589 pm > UUID: c1e03f1f-b7f2-46a1-b27d-5c2f42e19ef1 > Ancestors: Tools-topa.561 > > Tool icons: See if a method identifies itself as having a breakpoint or a 'reportable slip' > > =============== Diff against Tools-topa.561 =============== > > Item was changed: > ----- Method: Behavior>>toolIconSelector: (in category '*Tools-icons') ----- > toolIconSelector: aSymbol > "Tools can annotate the method identified by aSymbol with an icon identified by the symbol this method returns. > We customize this for, eg, overriden methods or methods with breaks. > Defaults to no icon" > > self methodDictionary at: aSymbol ifPresent: [ :method | > + method hasBreakpoint ifTrue: [^ #breakpoint]. > + method literalsDo: [:literal | > + (#(halt halt: haltIfNil haltIf: haltOnce haltOnce: haltOnCount: halt:onCount: break) includes: literal) > - method literalsDo: [ :literal | > - (#(halt halt: haltIfNil haltIf: haltOnce haltOnce: haltOnCount: halt:onCount:) includes: literal) > ifTrue: [^ #breakpoint]. > (#(flag: needsWork notYetImplemented) includes: literal) > ifTrue: [^ #flag]. > (#(shouldBeImplemented subclassResponsibility) includes: literal) > ifTrue: [ > (self isSelectorOverridden: aSymbol) > ifTrue: [^ #abstract] > ifFalse: [^ #notOverridden]]. > literal == #shouldNotImplement > + ifTrue: [^ #no]]. > + method hasReportableSlip ifTrue: [^ #breakpoint]]. > - ifTrue: [^ #no]]]. > > (self isSelectorOverride: aSymbol) > ifTrue: [ > (self isSelectorOverridden: aSymbol) > ifTrue: [ ^ #arrowUpAndDown ] > ifFalse: [ ^ #arrowUp ] ] > ifFalse: [ > (self isSelectorOverridden: aSymbol) > ifTrue: [^ #arrowDown ]]. > > self methodDictionary at: aSymbol ifPresent: [ :method | > (method primitive ~= 0 and: [method isQuick not]) > ifTrue: [^ #primitive]]. > > > ^ #blank! > >

2 2

The Trunk: SUnitTools-topa.1.mcz
by commits＠source.squeak.org 27 Mar '15

27 Mar '15

Tobias Pape uploaded a new version of SUnitTools to project The Trunk: http://source.squeak.org/trunk/SUnitTools-topa.1.mcz ==================== Summary ==================== Name: SUnitTools-topa.1 Author: topa Time: 27 March 2015, 11:36:27.849 am UUID: f60dd685-e19c-481a-9634-83d439b37e67 Ancestors: Provide browser integration for SUnit. - Indicate test status via tool icons - Run tests from context menu - Debug tests from context menu - Switch between tested and testing code via context menu (heursitically) This is featurewise modeled after the OmniBrowser SUnit-Integration. ==================== Snapshot ==================== ----- Method: TestCase class>>isTestClass (in category '*SUnitTools-testing') ----- isTestClass ^ true! ----- Method: TestCase class>>toolIcon (in category '*SUnitTools-icons') ----- toolIcon | classHistory | self isAbstract ifTrue: [^ super toolIcon]. classHistory := TestResult historyFor: self. (classHistory at: #errors) ifNotEmpty: [^ #testRed]. (classHistory at: #failures) ifNotEmpty: [^ #testOrange]. (classHistory at: #passed) ifNotEmpty: [ ^ #testGreen]. ^ #testGray! ----- Method: TestCase class>>toolIconSelector: (in category '*SUnitTools-icons') ----- toolIconSelector: aSelector (self isMeta or: [self isAbstract or: [ (self allTestSelectors includes: aSelector) not]]) ifTrue: [^ super toolIconSelector: aSelector]. (self methodRaisedError: aSelector) ifTrue: [^ #testRed]. (self methodFailed: aSelector) ifTrue: [^ #testOrange]. (self methodPassed: aSelector) ifTrue: [^ #testGreen]. ^ #testGray! ----- Method: Browser>>hasClassWithTestsSelected (in category '*SUnitTools-class list functions') ----- hasClassWithTestsSelected ^ (self selectedClass isTestClass and: [self selectedClass isAbstract not])! ----- Method: Browser>>hasSystemCategoryWithTestsSelected (in category '*SUnitTools-system category functions') ----- hasSystemCategoryWithTestsSelected (systemOrganizer listAtCategoryNamed: (self selectedSystemCategory ifNil: [^ false])) detect: [:name | self class environment at: name ifPresent: [:cls | cls isTestClass and: [cls isAbstract not]] ifAbsent: [false]] ifNone: [^ false]. ^ true ! ----- Method: Browser>>testRunTests (in category '*SUnitTools-class list functions') ----- testRunTests self testRunSuite: self selectedClass suite. self changed: #classList. self changed: #messageList.! ----- Method: Browser>>testRunTestsCategory (in category '*SUnitTools-system category functions') ----- testRunTestsCategory | suite | suite :=TestSuite new. ((systemOrganizer listAtCategoryNamed: self selectedSystemCategory) collect: [:each | self class environment at: each]) select: [:each | each isTestClass and: [each isAbstract not]] thenDo: [:each | each addToSuiteFromSelectors: suite]. self testRunSuite: suite. self changed: #classList. self changed: #messageList.! ----- Method: Browser>>testsClassListMenu: (in category '*SUnitTools-menus') ----- testsClassListMenu: aMenu <classListMenu> self hasClassWithTestsSelected ifFalse: [^ aMenu]. ^ aMenu addList: #( - ('run all tests' testRunTests)); yourself! ----- Method: Browser>>testsSystemCategoryMenu: (in category '*SUnitTools-menus') ----- testsSystemCategoryMenu: aMenu <systemCategoryMenu> self hasSystemCategoryWithTestsSelected ifFalse: [^ aMenu]. ^ aMenu addList: #( - ('run all tests' testRunTestsCategory)); yourself! ----- Method: CodeHolder>>testBinarySelectorNames (in category '*SUnitTools-running') ----- testBinarySelectorNames ^ IdentityDictionary newFromPairs: #( #& 'conjunction' #| 'disjunction' #==> 'implication' #* 'multiply' #+ 'add' #- 'subtract' #/ 'divide' #// 'remainder' #\\ 'modulo' #<< 'shiftLeft' #>> 'shiftRight' #= 'equality' #== 'identity' #~= 'difference' #~~ 'mismatch' #< 'lessThan' #<= 'lessOrEqualThan' #> 'greaterThan' #>= 'greaterOrEqualThan' #<=> 'spaceshipOperator' #@ 'at' #, 'concatenation' #-> 'association' #=> 'binding' ) ! ----- Method: CodeHolder>>testBrowseClassNamed:possibleMessageNamed: (in category '*SUnitTools-running') ----- testBrowseClassNamed: aClassName possibleMessageNamed: aMessageName | cls selector | (self class environment hasClassNamed: aClassName) ifFalse: ["no dice" ^ self]. cls := self class environment classNamed: aClassName. (aMessageName notNil and: [cls includesLocalSelector: (selector := aMessageName asSymbol)]) ifTrue: [ToolSet browse: cls selector: selector] ifFalse: [ToolSet browseClass: cls].! ----- Method: CodeHolder>>testDebugTest (in category '*SUnitTools-message list functions') ----- testDebugTest | case selector cls | cls := self selectedClass ifNil: [^ self]. selector := self selectedMessageName ifNil: [^ self]. case := cls selector: selector. case debugAsFailure.! ----- Method: CodeHolder>>testFindTest (in category '*SUnitTools-running') ----- testFindTest | cls destClassName destMessage | cls := self selectedClass ifNil: [^ self]. cls isTestClass ifTrue: [" already there " ^ self]. destClassName := cls name asString, 'Test'. destMessage := self selectedMessageName ifNotNil: [:name | self testSelectorFrom: name]. self testBrowseClassNamed: destClassName possibleMessageNamed: destMessage ! ----- Method: CodeHolder>>testFindTested (in category '*SUnitTools-running') ----- testFindTested | cls destClassName destMessage | cls := self selectedClass ifNil: [^ self]. cls isTestClass ifFalse: [" already there " ^ self]. destClassName := (cls name asString endsWith: 'Test') ifTrue: [cls name asString allButLast: 4] ifFalse: [^ self]. destMessage := self selectedMessageName ifNotNil: [:selector | | messageName | messageName := selector asString. (messageName beginsWith: 'test') "operate on test methods only" ifTrue: [ (self class environment classNamed: destClassName) ifNotNil: [:destClass | destClass selectors detect: [:destSelector | (self testSelectorFrom: destSelector) = messageName] ifNone: [nil]]] ifFalse: [nil]]. self testBrowseClassNamed: destClassName possibleMessageNamed: destMessage ! ----- Method: CodeHolder>>testRunSuite: (in category '*SUnitTools-running') ----- testRunSuite: suite | result | result := suite run. (result respondsTo: #dispatchResultsIntoHistory) ifTrue: [result dispatchResultsIntoHistory]. result hasPassed ifTrue: [^ self]. (result defects size = 1 ifTrue: [result defects anyOne] ifFalse: [UIManager default chooseFrom: (result defects collect: [:each | each class name , '>>' , each selector printString]) values: result defects title: ('{1} passes, {2} failures, {3} errors\\Debug a failure or error?' format: { result runCount . result failureCount . result errorCount}) withCRs] ) ifNotNil: [:defect | defect debug]. ! ----- Method: CodeHolder>>testRunTest (in category '*SUnitTools-message list functions') ----- testRunTest | suite | suite := self selectedClass selector: self selectedMessageName. self testRunSuite: suite. self changed: #messageList.! ----- Method: CodeHolder>>testSelectorFrom: (in category '*SUnitTools-running') ----- testSelectorFrom: aSelector | name | name := aSelector isBinary ifTrue: [self testBinarySelectorNames at: aSelector ifAbsent: [^ nil]] ifFalse: [aSelector asString]. ^ String streamContents: [:stream | stream nextPutAll: 'test'. (name findTokens: $:) do: [:each | stream nextPutAll: (each capitalized select: [:char | char isAlphaNumeric])]]! ----- Method: CodeHolder>>testsMessageListMenu: (in category '*SUnitTools-menus') ----- testsMessageListMenu: aMenu <messageListMenu> (self selectedClass isTestClass and: [self selectedClass isAbstract not and: [self selectedClass allTestSelectors includes: self selectedMessageName]]) ifFalse: [^ aMenu]. ^ aMenu addList: #( - ('run test' testRunTest) ('debug test' testDebugTest)); yourself! ----- Method: CodeHolder>>testsTestFindingMenu: (in category '*SUnitTools-menus') ----- testsTestFindingMenu: aMenu <classListMenu> <messageListMenu> ^ self hasClassWithTestsSelected ifTrue: [aMenu add: 'find tested item' action: #testFindTested; yourself] ifFalse: [aMenu add: 'find test case' action: #testFindTest; yourself] ! ----- Method: Object>>isTestClass (in category '*SUnitTools-testing') ----- isTestClass ^ false! ----- Method: ToolIcons class>>testGray (in category '*SUnitTools-icons') ----- testGray ^ Form extent: 12@12 depth: 32 fromArray: #( 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4294177779 4291217094 4288585374 4288453788 4290953922 4294111986 0 0 0 0 0 0 4291217094 4291151301 4292796126 4292532954 4290690750 4290624957 0 0 0 0 0 0 4288585374 4292730333 4290953922 4290427578 4291414473 4287466893 0 0 0 0 0 0 4288387995 4292203989 4290493371 4290164406 4291019715 4287072135 0 0 0 0 0 0 4290822336 4290624957 4291414473 4291019715 4290230199 4289835441 0 0 0 0 0 0 4294111986 4290493371 4287269514 4286940549 4289769648 4293848814 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0) offset: 0@0! ----- Method: ToolIcons class>>testGreen (in category '*SUnitTools-icons') ----- testGreen ^ Form extent: 12@12 depth: 32 fromArray: #( 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4293720299 4288666780 4284466010 4284465241 4288599706 4293654250 0 0 0 0 0 0 4288666780 4288403095 4290962113 4290502586 4288007314 4288401048 0 0 0 0 0 0 4284465754 4290830784 4288008853 4287220872 4288992418 4283999824 0 0 0 0 0 0 4284398936 4290108596 4287351946 4286958211 4288532634 4283800910 0 0 0 0 0 0 4288533401 4288007057 4288926881 4288401561 4287677068 4288133778 0 0 0 0 0 0 4293653994 4288400279 4283867471 4283734348 4288067729 4293521384 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0) offset: 0@0! ----- Method: ToolIcons class>>testOrange (in category '*SUnitTools-icons') ----- testOrange ^ Form extent: 12@12 depth: 32 fromArray: #( 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4294964456 4294953101 4294943038 4294942778 4294951813 4294963941 0 0 0 0 0 0 4294953101 4294952588 4294959549 4294958774 4294951038 4294688127 0 0 0 0 0 0 4294943293 4294959548 4294953862 4294951029 4294954132 4293888298 0 0 0 0 0 0 4294941751 4294957228 4294951287 4294949998 4294952328 4293165354 0 0 0 0 0 0 4294951298 4294950267 4294954131 4294952583 4294948207 4293110399 0 0 0 0 0 0 4294898405 4294424959 4293559850 4292902442 4292979327 4294438117 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0) offset: 0@0! ----- Method: ToolIcons class>>testRed (in category '*SUnitTools-icons') ----- testRed ^ Form extent: 12@12 depth: 32 fromArray: #( 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 4294960869 4294935167 4294716714 4294389034 4294344831 4294764005 0 0 0 0 0 0 4294935167 4294803840 4294687929 4294620593 4293950845 4293623680 0 0 0 0 0 0 4294585642 4294687928 4294477438 4294276206 4294284433 4292028973 0 0 0 0 0 0 4294061098 4294487209 4294276976 4294208615 4294150278 4291242543 0 0 0 0 0 0 4294082687 4293819516 4294284176 4294150277 4293163129 4291854213 0 0 0 0 0 0 4294698469 4293296000 4291635758 4290914863 4291657605 4294174183 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0) offset: 0@0!

1 0

Re: [squeak-dev] The Trunk: Tools-topa.563.mcz
by Nicolas Cellier 27 Mar '15

27 Mar '15

2015-03-27 0:27 GMT+01:00 <commits(a)source.squeak.org>: > Tobias Pape uploaded a new version of Tools to project The Trunk: > http://source.squeak.org/trunk/Tools-topa.563.mcz > > ==================== Summary ==================== > > Name: Tools-topa.563 > Author: topa > Time: 27 March 2015, 12:27:31.114 am > UUID: 7fb2f85e-8ba3-4ec4-be83-3c9275f7f80b > Ancestors: Tools-topa.562 > > Fix menu entry sort to actually match (intended) description > > =============== Diff against Tools-topa.562 =============== > > Item was changed: > ----- Method: StringHolder>>menuBuildersFor:in: (in category > '*Tools-pluggable menus') ----- > menuBuildersFor: someMenus in: aClass > "Find all builders and sort them by > 1. Priority (default 500) > 2. selector name > 3. inheritance > " > ^ (self menuPragmasFor: someMenus in: aClass) sorted: [:a :b | > |ma mb pa pb| > ma := a method. > mb := b method. > pa := self methodMenuPriority: ma. > pb := self methodMenuPriority: mb. > + pa <= pb or: [ > - pa < pb or: [ > I don't understand this. pa <= pb = false ==> (pa = pb = false) so the whole or: block becomes dead code no? > pa = pb and: [ > ma selector <= mb selector and: [ > mb methodClass inheritsFrom: ma > methodClass]]]] > ! > > >

2 2

The Trunk: Tools-topa.564.mcz
by commits＠source.squeak.org 27 Mar '15

27 Mar '15

Tobias Pape uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-topa.564.mcz ==================== Summary ==================== Name: Tools-topa.564 Author: topa Time: 27 March 2015, 1:24:02.733 am UUID: 8c4d15ea-663a-4c4e-b3c3-a31f6ac20214 Ancestors: Tools-topa.563 Amend to: Fix menu entry sort to actually match (intended) description =============== Diff against Tools-topa.563 =============== Item was changed: ----- Method: Browser>>classListMenuHook:shifted: (in category 'pluggable menus - hooks') ----- classListMenuHook: aMenu shifted: aBoolean <classListMenu> + <menuPriority: 400> ^ self menuHook: aMenu named: #classListMenu shifted: aBoolean. ! Item was changed: ----- Method: Browser>>messageCategoryMenuHook:shifted: (in category 'pluggable menus - hooks') ----- messageCategoryMenuHook: aMenu shifted: aBoolean <messageCategoryMenu> + <menuPriority: 400> ^ self menuHook: aMenu named: #messageCategoryMenu shifted: aBoolean. ! Item was changed: ----- Method: Browser>>messageListMenuHook:shifted: (in category 'pluggable menus - hooks') ----- messageListMenuHook: aMenu shifted: aBoolean <messageListMenu> + <menuPriority: 400> ^ self menuHook: aMenu named: #messageListMenu shifted: aBoolean. ! Item was changed: ----- Method: Browser>>systemCategoryMenuHook:shifted: (in category 'pluggable menus - hooks') ----- systemCategoryMenuHook: aMenu shifted: aBoolean <systemCategoryMenu> + <menuPriority: 400> ^ self menuHook: aMenu named: #systemCategoryMenu shifted: aBoolean. ! Item was changed: ----- Method: StringHolder>>buildMenu:withBuilders:shifted: (in category '*Tools-pluggable menus') ----- buildMenu: aMenu withBuilders: builders shifted: aBoolean " We let every builder modify the menu. The builder should indicate whether to abort by returning nil." | menu | menu := aMenu. builders do: [:builder | + menu := self perform: builder method selector withEnoughArguments: { menu . aBoolean }. - menu := self perform: builder method selector withEnoughArguments: { aMenu . aBoolean }. menu ifNil: [^ aMenu]]. ^ menu ! Item was changed: ----- Method: StringHolder>>codePaneMenuHook:shifted: (in category '*Tools-pluggable menus - hooks') ----- codePaneMenuHook: aMenu shifted: aBoolean <codePaneMenu> + <menuPriority: 400> ^ self menuHook: aMenu named: #codePaneMenu shifted: aBoolean. ! Item was changed: ----- Method: StringHolder>>menu:for:shifted: (in category '*Tools-pluggable menus') ----- menu: aMenu for: aMenuSymbolOrCollection shifted: aBoolean | builders | + builders := self menuBuildersFor: aMenuSymbolOrCollection in: self class shifted: aBoolean. + builders := self sortMenuBuilders: builders. - builders := self menuBuildersFor: aMenuSymbolOrCollection in: self class. - builders := aBoolean - ifTrue: [builders reject: [:builder | builder arguments = #(false)]] - ifFalse: [builders reject: [:builder | builder arguments = #(true)]]. - ^ self buildMenu: aMenu withBuilders: builders shifted: aBoolean ! Item was removed: - ----- Method: StringHolder>>menuBuildersFor:in: (in category '*Tools-pluggable menus') ----- - menuBuildersFor: someMenus in: aClass - "Find all builders and sort them by - 1. Priority (default 500) - 2. selector name - 3. inheritance - " - ^ (self menuPragmasFor: someMenus in: aClass) sorted: [:a :b | - |ma mb pa pb| - ma := a method. - mb := b method. - pa := self methodMenuPriority: ma. - pb := self methodMenuPriority: mb. - pa <= pb or: [ - pa = pb and: [ - ma selector <= mb selector and: [ - mb methodClass inheritsFrom: ma methodClass]]]] - ! Item was added: + ----- Method: StringHolder>>menuBuildersFor:in:shifted: (in category '*Tools-pluggable menus') ----- + menuBuildersFor: someMenus in: aClass shifted: aBoolean + "Find all builders but reject the ones not matching the shift state " + | pragmas | + pragmas := (self menuPragmasFor: someMenus in: aClass) . + ^ aBoolean + ifTrue: [pragmas reject: [:builder | builder arguments = #(false)]] + ifFalse: [pragmas reject: [:builder | builder arguments = #(true)]]. + ! Item was added: + ----- Method: StringHolder>>sortMenuBuilders: (in category '*Tools-pluggable menus') ----- + sortMenuBuilders: builders + " Sort them by + 1. Priority (default 500) + 2. selector name + " + ^ builders sorted: [:a :b | + | ma mb pa pb | + ma := a method. + mb := b method. + pa := self methodMenuPriority: ma. + pb := self methodMenuPriority: mb. + pa < pb or: [pa = pb and: [ma selector <= mb selector]]] + !

1 0

The Trunk: Tools-topa.563.mcz
by commits＠source.squeak.org 27 Mar '15

27 Mar '15

Tobias Pape uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-topa.563.mcz ==================== Summary ==================== Name: Tools-topa.563 Author: topa Time: 27 March 2015, 12:27:31.114 am UUID: 7fb2f85e-8ba3-4ec4-be83-3c9275f7f80b Ancestors: Tools-topa.562 Fix menu entry sort to actually match (intended) description =============== Diff against Tools-topa.562 =============== Item was changed: ----- Method: StringHolder>>menuBuildersFor:in: (in category '*Tools-pluggable menus') ----- menuBuildersFor: someMenus in: aClass "Find all builders and sort them by 1. Priority (default 500) 2. selector name 3. inheritance " ^ (self menuPragmasFor: someMenus in: aClass) sorted: [:a :b | |ma mb pa pb| ma := a method. mb := b method. pa := self methodMenuPriority: ma. pb := self methodMenuPriority: mb. + pa <= pb or: [ - pa < pb or: [ pa = pb and: [ ma selector <= mb selector and: [ mb methodClass inheritsFrom: ma methodClass]]]] !

1 0

Re: [squeak-dev] The Trunk: TrueType-cmm.35.mcz
by Tobias Pape 27 Mar '15

27 Mar '15

Thanks, these slipped when ported from Etoys… Best -Tobias On 26.03.2015, at 22:27, commits(a)source.squeak.org wrote: > Chris Muller uploaded a new version of TrueType to project The Trunk: > http://source.squeak.org/trunk/TrueType-cmm.35.mcz > > ==================== Summary ==================== > > Name: TrueType-cmm.35 > Author: cmm > Time: 26 March 2015, 5:27:01.756 pm > UUID: 93cf2b3b-dd5a-477f-b8d2-e2b3de539016 > Ancestors: TrueType-topa.34 > > Ran FixUnderscores on this package. > > =============== Diff against TrueType-topa.34 =============== > > Item was changed:

1 0

← Newer
1
...
6
7
8
9
10
11
12
...
32
Older →

Jump to page: