Squeak-dev August 2015

squeak-dev@lists.squeakfoundation.org

50 participants
218 discussions

The Trunk: System-mt.765.mcz
by commits＠source.squeak.org 28 Aug '15

28 Aug '15

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.765.mcz ==================== Summary ==================== Name: System-mt.765 Author: mt Time: 28 August 2015, 10:02:11.682 am UUID: b40396ff-9c0f-bb46-9317-779e2ccb6448 Ancestors: System-topa.764 For consistency, also support setting and restoring regular preference within the scope of a block. Like flags (i.e. boolean preferences) support it. =============== Diff against System-topa.764 =============== Item was added: + ----- Method: Preferences class>>setPreference:toValue:during: (in category 'get/set') ----- + setPreference: prefSymbol toValue: anObject during: aBlock + + (self valueOfPreference: prefSymbol) in: [:previous | + self setPreference: prefSymbol toValue: anObject. + aBlock ensure: [self setPreference: prefSymbol toValue: previous]].!

1 0

Re: [Pharo-dev] [squeak-dev] #instSize in Squeak 5 seems to be broken for Traits
by Max Leske 28 Aug '15

28 Aug '15

> On 22 Aug 2015, at 19:21, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > Hi Max, > > On Fri, Aug 21, 2015 at 2:11 PM, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: > >> On 21 Aug 2015, at 19:31, Eliot Miranda <eliot.miranda(a)gmail.com <mailto:eliot.miranda@gmail.com>> wrote: >> >> Hi Max, >> >> On Fri, Aug 21, 2015 at 8:57 AM, Max Leske <maxleske(a)gmail.com <mailto:maxleske@gmail.com>> wrote: >> Hi folks >> >> I’ve been trying to load Fuel into Squeak 5 but can’t because I get errors when loading Traits (they have not instance variables). The reason for this error seems to be that #instSize answers 2 for Traits when it should answer 0. >> >> The current implementation is: >> >> ^format bitAnd: 16rFFFF >> >> The comment in the 4.6 version says: >> >> " >> NOTE: This code supports the backward-compatible extension to 8 bits of instSize. >> When we revise the image format, it should become... >> ^ ((format bitShift: -1) bitAnd: 16rFF) - 1 >> Note also that every other method in this category will require >> 2 bits more of right shift after the change. >> “ >> >> When I use that version in TraitBehaviour>>instSize in Squeak 5 I get 0 as expected and I can load Fuel without problems. >> >> So Spur has a different layout for format than V3. The above implementation (format bitAnd: 16rFFFF) is correct for Spur. In loading classes or traits via Fuel from 4.6 to 5.0 you're going to have to convert the format inst var to reflect its usage in Spur. So we need to be clear here. >> >> Is the issue that you're trying to load classes and/or traits from a Fuel file written by 4.6 or is it that as part of the Fuel load a new Trait gets created which has a format of 2? > > The latter. This is reproducible by simply creating a new Trait: > > Trait named: #NewTrait > uses: #() > category: ‘new cat’. > NewTrait instSize “—> 2” > > I just took a look at this and it doesn't reproduce. I'm using a trunk Squeak 5 image and I get 0 and required. ? Thanks Eliot. You’re right. The problem is not with #instSize, I don’t know how I managed to get the above… The problem is actually, that TApplyingOnClassSide (which is already present) has a format of 2: TApplyingOnClassSide instSize “—> 2” Also, all Traits in the image have format 2, while new Traits have format 0: format2 := Smalltalk allTraits select: [ :e | e format = 2 ]. Smalltalk allTraits size = format2 size “—> true" Trait named: #NewTrait uses: #() category: 'new cat’. NewTrait instSize “—> 0" format2 := Smalltalk allTraits select: [ :e | e format = 2 ]. Smalltalk allTraits size = format2 size “—> false” This is with build 15113 (which is trunk I suppose). Cheers, Max > > Cheers, > Max > >> >> >> Cheers, >> Max >> >> >> >> -- >> _,,,^..^,,,_ >> best, Eliot > > > > > -- > _,,,^..^,,,_ > best, Eliot

2 1

The Trunk: Monticello-eem.617.mcz
by commits＠source.squeak.org 28 Aug '15

28 Aug '15

Eliot Miranda uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-eem.617.mcz ==================== Summary ==================== Name: Monticello-eem.617 Author: eem Time: 27 August 2015, 5:09:02.395 pm UUID: 4330481f-87ae-4d7b-b2aa-0969f0611256 Ancestors: Monticello-cmm.616 Add a menu item to nuke Monticello load change sets. This is more involved than it should be but we're getting there. Needs Morphic-eem.1002 =============== Diff against Monticello-cmm.616 =============== Item was added: + ----- Method: ChangeSet>>isForPackageLoad (in category '*Monticello-testing') ----- + isForPackageLoad + | packageName | + ^(name includes: $-) + and: [name last isDigit + and: [packageName := name first: ((name indexOf: $. ifAbsent: [name size]) + min: (name lastIndexOf: $-)) - 1. + MCWorkingCopy allManagers anySatisfy: [:wc| wc packageName = packageName]]]! Item was added: + ----- Method: ChangeSorter>>deleteMonticelloChangeSets (in category '*Monticello-changeSet menu') ----- + deleteMonticelloChangeSets + "Destroy all change sets from Monticello loads, provided the currently selected change set is not one of those, and the user really wants to do this." + + myChangeSet isForPackageLoad ifTrue: "forms current changes for current project" + [^self inform: 'current change set is a Monticello load change set.\Please select some other change set before deleting Monticello load change sets.' withCRs]. + (self confirm: 'Are you sure you want to delete all change sets due to Monticello package loads?') ifFalse: + [^self]. + + (ChangesOrganizer allChangeSets select: [:cs| cs isForPackageLoad]) do: + [:cs| ChangesOrganizer removeChangeSet: cs]. + + self changed: #changeSetList. + self showChangeSet: ChangeSet current! Item was added: + ----- Method: ChangeSorter>>monticelloChangeSetMenu: (in category '*Monticello-changeSet menu') ----- + monticelloChangeSetMenu: aMenu + <changeSetMenuShifted: false> + <menuPriority: 600> + "Sigh, when implementing menu pragmas this is not what I had in mind..." + aMenu add: 'delete Monticello load change sets' action: #deleteMonticelloChangeSets. + (aMenu submorphs + detect: [:m| m isMenuItemMorph and: [m contents beginsWith: 'destroy change set']] + ifNone: []) ifNotNil: + [:destroyItem| | item | + aMenu removeMorph: (item := aMenu submorphs last). + aMenu addMorph: item after: destroyItem]. + ^aMenu!

1 0

The Trunk: Morphic-eem.1002.mcz
by commits＠source.squeak.org 28 Aug '15

28 Aug '15

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1002.mcz ==================== Summary ==================== Name: Morphic-eem.1002 Author: eem Time: 27 August 2015, 5:03:26.429 pm UUID: d94fff6d-5fef-4500-9144-4dc8bfa1510e Ancestors: Morphic-mt.1001 It's really convenient to be able to identify MenuItemMorphs easily. =============== Diff against Morphic-mt.1001 =============== Item was added: + ----- Method: MenuItemMorph>>isMenuItemMorph (in category 'testing') ----- + isMenuItemMorph + ^true! Item was added: + ----- Method: Morph>>isMenuItemMorph (in category 'testing') ----- + isMenuItemMorph + ^false!

1 0

Re: The Trunk: Traits-eem.306.mcz
by Paul DeBruicker 28 Aug '15

28 Aug '15

Thanks. I'll try again with Fuel soon. commits-2 wrote > Eliot Miranda uploaded a new version of Traits to project The Trunk: > http://source.squeak.org/trunk/Traits-eem.306.mcz > > ==================== Summary ==================== > > Name: Traits-eem.306 > Author: eem > Time: 27 August 2015, 3:56:23.871 pm > UUID: 17370ed0-0211-4deb-a99b-4678a8eddea1 > Ancestors: Traits-ul.305 > > Save a version of Traits that resets the format of existing traits if they > were wrong. The Spur bootstrap failed to reset Trait formats so they were > left at the V3 value for a zero inst sized pointer class, or 2. > > =============== Diff against Traits-ul.305 =============== > > Item was added: > + (PackageInfo named: 'Traits') preamble: '"Update traits to have zero > inst size. the Spur bootstrap failed to reset Trait formats so they were > left at the V3 value for a zero inst sized pointer class, or 2" > + Smalltalk allTraits do: > + [:t| > + t instSize > 0 ifTrue: > + [t setFormat: 0]]'! -- View this message in context: http://forum.world.st/The-Trunk-Traits-eem-306-mcz-tp4846451p4846452.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

1 0

The Trunk: Traits-eem.306.mcz
by commits＠source.squeak.org 28 Aug '15

28 Aug '15

Eliot Miranda uploaded a new version of Traits to project The Trunk: http://source.squeak.org/trunk/Traits-eem.306.mcz ==================== Summary ==================== Name: Traits-eem.306 Author: eem Time: 27 August 2015, 3:56:23.871 pm UUID: 17370ed0-0211-4deb-a99b-4678a8eddea1 Ancestors: Traits-ul.305 Save a version of Traits that resets the format of existing traits if they were wrong. The Spur bootstrap failed to reset Trait formats so they were left at the V3 value for a zero inst sized pointer class, or 2. =============== Diff against Traits-ul.305 =============== Item was added: + (PackageInfo named: 'Traits') preamble: '"Update traits to have zero inst size. the Spur bootstrap failed to reset Trait formats so they were left at the V3 value for a zero inst sized pointer class, or 2" + Smalltalk allTraits do: + [:t| + t instSize > 0 ifTrue: + [t setFormat: 0]]'!

1 0

Daily Commit Log
by commits＠source.squeak.org 27 Aug '15

27 Aug '15

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2015-August/008910.html Name: System-mt.761 Ancestors: System-eem.760 Clean-up of preferences interface. Includes some bugfixes for updating pragma preferences after a class is renamed. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008911.html Name: Tests-mt.328 Ancestors: Tests-eem.327 New tests for preferences. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008912.html Name: Services-Base-mt.57 Ancestors: Services-Base-eem.56 Some adjustments for cleaned-up preferences interface. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008913.html Name: ST80-mt.185 Ancestors: ST80-mt.184 Some adjustments for cleaned-up preferences interface. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008914.html Name: PreferenceBrowser-mt.54 Ancestors: PreferenceBrowser-mt.53 Some adjustments for cleaned-up preferences interface. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008915.html Name: Network-mt.162 Ancestors: Network-cmm.161 Some adjustments for cleaned-up preferences interface. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008916.html Name: Morphic-mt.1000 Ancestors: Morphic-mt.999 Some adjustments for cleaned-up preferences interface. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008917.html Name: MorphicExtras-mt.166 Ancestors: MorphicExtras-ul.165 Some adjustments for cleaned-up preferences interface. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008918.html Name: System-mt.762 Ancestors: System-mt.761 Restores #togglePreference: for backwards compatibility. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008919.html Name: Tests-mt.329 Ancestors: Tests-mt.328 Fixes initialization problem with test preferences. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008920.html Name: Morphic-mt.1001 Ancestors: Morphic-mt.1000 Fixes a regression where scroll panes want to grow but the parent morph does not update its layout accordingly. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008921.html Name: Installer-Core-topa.401 Ancestors: Installer-Core-cmm.400 Gemstone.com is deprecated long enough now that it does not respond any longer. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008922.html Name: System-topa.763 Ancestors: System-mt.762 since any system event fires #prefEvent:, any addition of a class side method with some pragma will fire #addPragmaPreference. So instead of bailing, just do nothing when the method is in fact no pref. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2015-August/008923.html Name: System-topa.764 Ancestors: System-topa.763 Do not return nil for unknown preferences in dNU magic but rather bail. =============================================

1 0

The Trunk: System-topa.764.mcz
by commits＠source.squeak.org 27 Aug '15

27 Aug '15

Tobias Pape uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-topa.764.mcz ==================== Summary ==================== Name: System-topa.764 Author: topa Time: 27 August 2015, 11:47:04.664 pm UUID: c205a736-8aff-48c5-8b3b-24ec808d19fd Ancestors: System-topa.763 Do not return nil for unknown preferences in dNU magic but rather bail. =============== Diff against System-topa.763 =============== Item was changed: ----- Method: Preferences class>>doesNotUnderstand: (in category 'get/set') ----- doesNotUnderstand: aMessage "Interpret unary message selectors as preference id." ^ aMessage arguments size > 0 ifTrue: [super doesNotUnderstand: aMessage] + ifFalse: [ + self + valueOfPreference: aMessage selector + ifAbsent: [super doesNotUnderstand: aMessage]]! - ifFalse: [self valueOfPreference: aMessage selector]!

1 0

The Trunk: System-topa.763.mcz
by commits＠source.squeak.org 27 Aug '15

27 Aug '15

Tobias Pape uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-topa.763.mcz ==================== Summary ==================== Name: System-topa.763 Author: topa Time: 27 August 2015, 11:39:32.305 pm UUID: 8731d6a1-ac9a-4cb9-90cf-92400d1289d2 Ancestors: System-mt.762 since any system event fires #prefEvent:, any addition of a class side method with some pragma will fire #addPragmaPreference. So instead of bailing, just do nothing when the method is in fact no pref. =============== Diff against System-mt.762 =============== Item was changed: ----- Method: Preferences class>>addPragmaPreference: (in category 'add/remove') ----- addPragmaPreference: pragma "Note that there will be no accessor method generated because the pragma's method does already govern that." | preference | - self assert: pragma methodClass isMeta. ((pragma keyword beginsWith: #preference:) and: [self respondsTo: pragma keyword]) + ifFalse: [ + "no pragma pref to be defined. do nothing" + ^ self]. + self assert: pragma methodClass isMeta. - ifFalse: [Error signal: 'Cannot create pragma preference object.'. ^ self]. preference := self perform: pragma keyword withArguments: pragma arguments. preference provider: pragma methodClass theNonMetaClass getter: pragma method selector setter: pragma method selector asMutator. self atomicUpdatePreferences: [ :copyOfDictionaryOfPreferences | copyOfDictionaryOfPreferences at: preference id put: preference]. ^ preference!

1 0

The Trunk: Installer-Core-topa.401.mcz
by commits＠source.squeak.org 27 Aug '15

27 Aug '15

Tobias Pape uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-topa.401.mcz ==================== Summary ==================== Name: Installer-Core-topa.401 Author: topa Time: 27 August 2015, 11:36:57.855 pm UUID: 67e2b760-0986-4b40-a9cf-f36a951e48fb Ancestors: Installer-Core-cmm.400 Gemstone.com is deprecated long enough now that it does not respond any longer. =============== Diff against Installer-Core-cmm.400 =============== Item was changed: ----- Method: Installer class>>gemsource (in category 'repositories') ----- gemsource + ^ self monticello http: 'http://seaside.gemtalksystems.com/ss'! - ^ self monticello http: 'http://seaside.gemstone.com/ss'!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
22
Older →

Jump to page: