Squeak-dev January 2016

squeak-dev@lists.squeakfoundation.org

40 participants
206 discussions

The Trunk: Tools-mt.664.mcz
by commits＠source.squeak.org 21 Jan '16

21 Jan '16

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.664.mcz ==================== Summary ==================== Name: Tools-mt.664 Author: mt Time: 21 January 2016, 3:20:55.039876 pm UUID: 7640e095-75e6-4add-add8-6bf4748f802e Ancestors: Tools-ul.663 Fixes drop behavior in File List. Ignore things that are not files or folders. However, move/copy folders might still work on Unix-based systems only. =============== Diff against Tools-ul.663 =============== Item was changed: ----- Method: FileList>>buildDirectoryTreeWith: (in category 'toolbuilder') ----- buildDirectoryTreeWith: builder | treeSpec | treeSpec := builder pluggableTreeSpec new. treeSpec model: self ; roots: #rootDirectoryList ; hasChildren: #hasMoreDirectories: ; getChildren: #subDirectoriesOf: ; getSelectedPath: #selectedPath ; setSelected: #setDirectoryTo: ; getSelected: #directory; label: #directoryNameOf: ; menu: #volumeMenu: ; autoDeselect: false. SystemBrowser browseWithDragNDrop ifTrue: [ treeSpec + dragItem: #dragFromDirectoryList: ; + dropItem: #drop:ontoDirectory:shouldCopy: ; + dropAccept: #wantsDraggedObject: ]. - dragItem: #dragFromDirectoryList: ; - dropItem: #drop:ontoDirectory:shouldCopy: ]. ^ treeSpec! Item was added: + ----- Method: FileList>>wantsDraggedObject: (in category 'drag''n''drop') ----- + wantsDraggedObject: anObject + + ^ (anObject isKindOf: DirectoryEntry) or: [anObject isKindOf: FileDirectory]!

1 0

[BUG]FileList PluggableTreeMorph accept drops of any morph
by karl ramberg 21 Jan '16

21 Jan '16

FileList's PluggableTreeMorph accepts drops of any morph, but give a PreDebuggerWindow Best, Karl

2 1

Daily Commit Log
by commits＠source.squeak.org 20 Jan '16

20 Jan '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-January/009266.ht… Name: MultilingualTests-tpr.19 Ancestors: MultilingualTests-fbs.18 Fix a failing test - when formatting NewParagraphs the caretWidth is added to the width required by the actual included text. The test needs to allow for that ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-January/009267.ht… Name: System-tpr.786 Ancestors: System-mt.785 The preference's idea of caret width is no longer used. See Editor instead. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-January/009268.ht… Name: MultilingualTests-tpr.20 Ancestors: MultilingualTests-tpr.19 testParagraphFallback also needs to handle the caret width ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-January/009269.ht… Name: System-eem.787 Ancestors: System-tpr.786 When triming change set history, nuke changes for methods that can't be found as well as those that have been added then removed. Add some robustness to parsing class names in class definitions in ChangeRecord. =============================================

1 0

Ignore shortcut
by Eliot Miranda 20 Jan '16

20 Jan '16

Hi, Bert did a brilliant thing adding the "ignore" Monticello check-in option, which allows one, cheaply to maintain a fork with a few changes, which still checking into the main line. However, for a while now the menu shortcut (i) hasn't worked and one must pick from the menu. Is there any way this can be fixed? _,,,^..^,,,_ best, Eliot

3 3

The Trunk: System-eem.787.mcz
by commits＠source.squeak.org 20 Jan '16

20 Jan '16

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.787.mcz ==================== Summary ==================== Name: System-eem.787 Author: eem Time: 20 January 2016, 1:47:21.381067 pm UUID: 14aec38e-df6c-4751-9bb8-fa68dffb16e5 Ancestors: System-tpr.786 When triming change set history, nuke changes for methods that can't be found as well as those that have been added then removed. Add some robustness to parsing class names in class definitions in ChangeRecord. =============== Diff against System-tpr.786 =============== Item was changed: ----- Method: ChangeRecord>>methodClassName (in category 'access') ----- methodClassName | tokens | (class isNil and: [type = #doIt + and: [([(tokens := Scanner new scanTokens: self text) size >= 3] + on: Error do: [:ex| false]) - and: [(tokens := Scanner new scanTokens: self text) size >= 3 and: [(tokens includes: #'.') not "exclude multi-statement doits" and: [tokens first isSymbol and: [tokens first isKeyword not and: [tokens first first canBeGlobalVarInitial and: [(tokens includes: #instanceVariableNames:) or: [tokens second == #comment: or: [tokens third == #comment:]]]]]]]]]) ifTrue: ["Could be a class definition. Class definitions start with Superclass blahSubclass: #ClassName Metaclass definitions start with ClassName class instanceVariableNames:" (tokens second isSymbol and: [tokens second isKeyword and: [tokens third isSymbol and: [tokens third isKeyword not and: [(2 to: tokens size by: 2) allSatisfy: [:i| (tokens at: i) isKeyword]]]]]) ifTrue: [^tokens third]. (tokens size = 4 and: [tokens second = #class and: [(tokens third = #instanceVariableNames: or: [tokens third = #comment:]) and: [tokens last isString]]]) ifTrue: [^tokens first]. (tokens size = 3 and: [tokens second = #comment: and: [tokens last isString]]) ifTrue: [^tokens first]]. ^class! Item was changed: ----- Method: ClassChangeRecord>>trimHistory (in category 'all changes') ----- trimHistory "Drop non-essential history." + | realClass | + realClass := self realClass. "Forget methods added and later removed" methodChanges keysAndValuesRemove: + [:sel :chgRecord | + chgRecord changeType == #addedThenRemoved + "this removes methods that have been lost, e.g. by being deleted in a different change set, etc" + or: [(chgRecord changeType == #add or: [chgRecord changeType == #change]) + and: [realClass isNil or: [(realClass includesSelector: sel) not]]]]. - [:sel :chgRecord | chgRecord changeType == #addedThenRemoved]. "Forget renaming and reorganization of newly-added classes." (changeTypes includes: #add) ifTrue: + [changeTypes removeAllFoundIn: #(rename reorganize)]! - [changeTypes removeAllFoundIn: #(rename reorganize)]. - !

1 0

ExceptionTests>testHandlerFromAction fails
by tim Rowledge 20 Jan '16

20 Jan '16

I’ve been running the SUnits on my Pi whilst other stuff compiles and noticed this one failing. Fails on the Mac as well so it’s not platform specific (phew). I’m not sure I see how it fails without lots of other stuff failing, but that’s life. Image is up to update 15569. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: MII: Mask all Interrupts and then Interrupt

3 3

Re: [squeak-dev] The Trunk: Morphic-tpr.1069.mcz
by Chris Muller 20 Jan '16

20 Jan '16

Does it still work correctly if you toggle your swapMouseButtons setting? On Tue, Jan 19, 2016 at 4:00 PM, <commits(a)source.squeak.org> wrote: > tim Rowledge uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-tpr.1069.mcz > > ==================== Summary ==================== > > Name: Morphic-tpr.1069 > Author: tpr > Time: 19 January 2016, 2:00:10.351434 pm > UUID: 080b7719-2b70-419c-91f3-4842337058a6 > Ancestors: Morphic-mt.1068, Morphic-tpr.1068 > > This seems to be the best way to make sure that the preference 'cmd gestures enabled' being false results in no Halos. > > If you have a nicer way, please replace this. > > =============== Diff against Morphic-mt.1068 =============== > > Item was changed: > ----- Method: Morph>>handleMouseDown: (in category 'events-processing') ----- > handleMouseDown: anEvent > "System level event handling." > anEvent wasHandled ifTrue:[^self]. "not interested" > anEvent hand removePendingBalloonFor: self. > anEvent hand removePendingHaloFor: self. > anEvent wasHandled: true. > > (anEvent controlKeyPressed > and: [anEvent blueButtonChanged not > and: [Preferences cmdGesturesEnabled]]) > ifTrue: [^ self invokeMetaMenu: anEvent]. > > "Make me modal during mouse transitions" > anEvent hand newMouseFocus: self event: anEvent. > + (anEvent blueButtonChanged and:[Preferences cmdGesturesEnabled]) ifTrue:[^self blueButtonDown: anEvent]. > - anEvent blueButtonChanged ifTrue:[^self blueButtonDown: anEvent]. > > "this mouse down could be the start of a gesture, or the end of a gesture focus" > (self isGestureStart: anEvent) > ifTrue: [^ self gestureStart: anEvent]. > > "Filter events sent to the subwidgets of non-MorphicModels in inactive windows, if they are not supposed to receive them due to windowActiveOnFirstClick being set to false. I don't like having this check for owningWindow here, is there another way?" > SystemWindow allWindowsAcceptInput > ifTrue: > [ self owningWindow > ifNil: [ self mouseDown: anEvent ] > ifNotNil: > [ : owningWindow | > (owningWindow canProcessMouseDown: anEvent) > ifTrue: [ self mouseDown: anEvent ] > ifFalse: [ owningWindow activate ] ] ] > ifFalse: [ self mouseDown: anEvent ]. > > Preferences maintainHalos > ifFalse:[ anEvent hand removeHaloFromClick: anEvent on: self ]. > > (self handlesMouseStillDown: anEvent) ifTrue:[ > self startStepping: #handleMouseStillDown: > at: Time millisecondClockValue + self mouseStillDownThreshold > arguments: {anEvent copy resetHandlerFields} > stepTime: self mouseStillDownStepRate ]. > ! > >

2 1

The Trunk: MultilingualTests-tpr.20.mcz
by commits＠source.squeak.org 20 Jan '16

20 Jan '16

tim Rowledge uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-tpr.20.mcz ==================== Summary ==================== Name: MultilingualTests-tpr.20 Author: tpr Time: 20 January 2016, 6:08:00.796359 pm UUID: f3143cf4-b0b2-43d3-9549-55c4c2e56070 Ancestors: MultilingualTests-tpr.19 testParagraphFallback also needs to handle the caret width =============== Diff against MultilingualTests-tpr.19 =============== Item was changed: ----- Method: FontTest>>testParagraphFallback (in category 'testing') ----- testParagraphFallback "self debug: #testParagraphFallback" | text p style height width e expect | e := (Character value: 257) asString. text := ('test' , e , e , e , e , 'test') asText. expect := 'test????test'. p := NewParagraph new. style := TextStyle default. p compose: text style: style from: 1 in: (0 @ 0 corner: 100 @ 100). "See CompositionScanner>>setActualFont: & CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:" height := style defaultFont height + style leading. + width := (expect - width := expect inject: 0 into: [:tally :next | tally + + (style defaultFont widthOf: next)]) + p caretWidth. - + (style defaultFont widthOf: next)]. p adjustRightX. self assert: p extent = (width @ height). "Display getCanvas paragraph: p bounds: (10 @ 10 extent: 100 @ 100) color: Color black"!

1 0

The Trunk: System-tpr.786.mcz
by commits＠source.squeak.org 20 Jan '16

20 Jan '16

tim Rowledge uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tpr.786.mcz ==================== Summary ==================== Name: System-tpr.786 Author: tpr Time: 20 January 2016, 6:02:02.528554 pm UUID: b9b4f339-997d-40ad-af12-1101a18c7b1b Ancestors: System-mt.785 The preference's idea of caret width is no longer used. See Editor instead. =============== Diff against System-mt.785 =============== Item was removed: - ----- Method: Preferences class>>caretWidth (in category 'prefs - text') ----- - caretWidth - ^ Parameters at: #caretWidth! Item was removed: - ----- Method: Preferences class>>caretWidth: (in category 'prefs - text') ----- - caretWidth: anInteger - ^ Parameters at: #caretWidth put: anInteger! Item was changed: ----- Method: Preferences class>>initializeTextHighlightingParameters (in category 'prefs - text') ----- initializeTextHighlightingParameters "Preferences initializeTextHighlightingParameters" self - caretWidth: 2; insertionPointColor: (TranslucentColor r: 0.0 g: 0.0 b: 0.8 alpha: 0.8); textHighlightColor: (TranslucentColor r: 0.0 g: 0.0 b: 0.8 alpha: 0.2)!

1 0

The Trunk: MultilingualTests-tpr.19.mcz
by commits＠source.squeak.org 20 Jan '16

20 Jan '16

tim Rowledge uploaded a new version of MultilingualTests to project The Trunk: http://source.squeak.org/trunk/MultilingualTests-tpr.19.mcz ==================== Summary ==================== Name: MultilingualTests-tpr.19 Author: tpr Time: 20 January 2016, 5:59:14.555529 pm UUID: b2182a04-860d-4137-a68e-89b4502e581d Ancestors: MultilingualTests-fbs.18 Fix a failing test - when formatting NewParagraphs the caretWidth is added to the width required by the actual included text. The test needs to allow for that =============== Diff against MultilingualTests-fbs.18 =============== Item was changed: ----- Method: FontTest>>testParagraph (in category 'testing') ----- testParagraph "self debug: #testParagraph" | text p style height width | text := 'test' asText. p := NewParagraph new. style := TextStyle default. p compose: text style: style from: 1 in: (0 @ 0 corner: 100 @ 100). "See CompositionScanner>>setActualFont: & CompositionScanner>>composeFrom:inRectangle:firstLine:leftSide:rightSide:" height := style defaultFont height + style leading. + width := (text - width := text inject: 0 into: [:tally :next | tally + + (style defaultFont widthOf: next)]) + p caretWidth. "because it is added by the paragraph formatting" - + (style defaultFont widthOf: next)]. p adjustRightX. self assert: p extent = (width @ height)!

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
21
Older →

Jump to page: