Squeak-dev March 2016

squeak-dev@lists.squeakfoundation.org

31 participants
150 discussions

The Trunk: Regex-Tests-Core-ul.4.mcz
by commits＠source.squeak.org 27 Mar '16

27 Mar '16

Levente Uzonyi uploaded a new version of Regex-Tests-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Tests-Core-ul.4.mcz ==================== Summary ==================== Name: Regex-Tests-Core-ul.4 Author: ul Time: 27 March 2016, 12:38:52.983055 am UUID: a859f723-20b0-49e2-8644-eb66837f4ceb Ancestors: Regex-Tests-Core-ul.3 Added RxParserTest >> #testPredicates to cover the case sensitive/case insensitive predicates a bit better. =============== Diff against Regex-Tests-Core-ul.3 =============== Item was added: + ----- Method: RxParserTest>>testPredicates (in category 'tests') ----- + testPredicates + + #( + "input" "regex" "expected case sensitive result" "expected case insensitive result" + 'abc' '[a]bc' true true + 'abc' '[A]bc' false true + 'abc' '[ab]bc' true true + 'abc' '[Ab]bc' false true + 'Abc' '[a]bc' false true + 'Abc' '[A]bc' true true + 'Abc' '[ab]bc' false true + 'Abc' '[Ab]bc' true true + 'abc' '[b]bc' false false + 'abc' '[bB]bc' false false + 'abc' '[bc]bc' false false + 'abc' '[bcBC]bc' false false + ) groupsDo: [ :input :regexString :expectedCaseSensitiveResult :expectedCaseInsensitiveResult | + self + assert: expectedCaseSensitiveResult + equals: (input matchesRegex: regexString) + description: ('{1} matchesRegex: {2} should be {3}' format: { input. regexString. expectedCaseSensitiveResult }). + self + assert: expectedCaseInsensitiveResult + equals: (input matchesRegexIgnoringCase: regexString) + description: ('{1} matchesRegexIgnoringCase: {2} should be {3}' format: { input. regexString. expectedCaseInsensitiveResult }) ]!

1 0

Daily Commit Log
by commits＠source.squeak.org 26 Mar '16

26 Mar '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-March/009502.html Name: Network-ul.174 Ancestors: Network-eem.173 Socket changes - use the instance variables for the semaphores, since it's clear now which semaphore is responsible for reading and writing (it might as well been done that way originally by assigning the same value to all three variables) - removed the max: 0 checks when the wait time is passed to the semaphores via #waitTimeoutMSecs:, because that method will do the same check ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-March/009503.html Name: Regex-Core-ul.46 Ancestors: Regex-Core-ul.45 Few more RxMatchOptimizer tweaks: - prefixes, nonPrefixes, predicates, nonPredicates can never be empty - #predicateTester creates better blocks - removed the never sent #addNonPrefix: method RxMatcher >> #atEndOfLine considers line feed as end of line as well. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-March/009504.html Name: Regex-Core-ul.47 Ancestors: Regex-Core-ul.46 - fix a slip in RxMatchOptimizer >> #prefixTester =============================================

1 0

The Trunk: Regex-Core-ul.47.mcz
by commits＠source.squeak.org 26 Mar '16

26 Mar '16

Levente Uzonyi uploaded a new version of Regex-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Core-ul.47.mcz ==================== Summary ==================== Name: Regex-Core-ul.47 Author: ul Time: 26 March 2016, 8:40:59.776673 pm UUID: 37a57fa6-b710-420a-a5fa-c4ce991ec118 Ancestors: Regex-Core-ul.46 - fix a slip in RxMatchOptimizer >> #prefixTester =============== Diff against Regex-Core-ul.46 =============== Item was changed: ----- Method: RxMatchOptimizer>>prefixTester (in category 'private') ----- prefixTester | p | prefixes ifNil: [ ^nil ]. prefixes size = 1 ifTrue: [ | prefixChar | prefixChar := prefixes anyOne. ignoreCase ifTrue: [ | lowercasePrefixChar | lowercasePrefixChar := prefixChar asLowercase. prefixChar := prefixChar asUppercase. prefixChar == lowercasePrefixChar ifFalse: [ ^[ :char :matcher | char == prefixChar or: [ char == lowercasePrefixChar ] ] ] ]. ^[ :char :matcher | char == prefixChar ] ]. ignoreCase ifTrue: [ prefixes copy do: [ :each | | character | + (character := each asUppercase) == each + ifFalse: [ prefixes add: character ] + ifTrue: [ + (character := each asLowercase) == each ifFalse: [ + prefixes add: character ] ] ] ]. - (character := each asUppercase) == each ifFalse: [ - prefixes add: character ]. - (character := each asUppercase) == each ifFalse: [ - prefixes add: character ] ] ]. prefixes size < 10 ifTrue: [ "10 is an empirical value" p := prefixes asArray. ^[ :char :matcher | p instVarsInclude: char ] ]. ^[ :char :matcher | prefixes includes: char ]!

1 0

I would be extremely grateful for a reproducible case for the following Socket issue
by Eliot Miranda 26 Mar '16

26 Mar '16

http://forum.world.st/Socket-s-readSemaphore-is-losing-signals-with-Cog-on-… On 8/13/2011 13:42, Levente Uzonyi wrote: > Socket's readSemaphore is losing signals with CogVMs on linux. We > found several cases (RFB, PostgreSQL) when processes are stuck in the > following method: > > Socket >> waitForDataIfClosed: closedBlock > "Wait indefinitely for data to arrive. This method will block until > data is available or the socket is closed." > > [ > (self primSocketReceiveDataAvailable: socketHandle) > ifTrue: [^self]. > self isConnected > ifFalse: [^closedBlock value]. > self readSemaphore wait ] repeat > > When we inspect the contexts, the process is waiting for the > readSemaphore, but evaluating (self primSocketReceiveDataAvailable: > socketHandle) yields true. Signaling the readSemaphore makes the > process running again. As a workaround we replaced #wait with > #waitTimeoutMSecs: and all our problems disappeared. > > The interpreter VM doesn't seem to have this bug, so I guess the bug > was introduced with the changes of aio.c. « [hide part of quote] Oh, interesting. We know this problem fairly well and have always worked around by changing the wait in the above to a "waitTimeoutMSecs: 500" which turns it into a soft busy loop. It would be interesting to see if there's a bug in Cog which causes this. FWIW, here is the relevant portion: "Soft 500ms busy loop - to protect against AIO probs; occasionally, VM-level AIO fails to trip the semaphore" self readSemaphore waitTimeoutMSecs: 500. Cheers, - Andreas _,,,^..^,,,_ best, Eliot

4 8

The Trunk: Regex-Core-ul.46.mcz
by commits＠source.squeak.org 26 Mar '16

26 Mar '16

Levente Uzonyi uploaded a new version of Regex-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Core-ul.46.mcz ==================== Summary ==================== Name: Regex-Core-ul.46 Author: ul Time: 26 March 2016, 7:18:24.505619 pm UUID: d7cbc4e5-32ee-4ea3-9228-ff39b3c76af7 Ancestors: Regex-Core-ul.45 Few more RxMatchOptimizer tweaks: - prefixes, nonPrefixes, predicates, nonPredicates can never be empty - #predicateTester creates better blocks - removed the never sent #addNonPrefix: method RxMatcher >> #atEndOfLine considers line feed as end of line as well. =============== Diff against Regex-Core-ul.45 =============== Item was removed: - ----- Method: RxMatchOptimizer>>addNonPrefix: (in category 'private') ----- - addNonPrefix: aCharacter - - ^(nonPrefixes ifNil: [ nonPrefixes := CharacterSet new ]) add: aCharacter! Item was changed: ----- Method: RxMatchOptimizer>>addNonPrefixes: (in category 'private') ----- addNonPrefixes: aSet + aSet size = 0 ifTrue: [ ^aSet ]. ^nonPrefixes ifNil: [ nonPrefixes := aSet ] ifNotNil: [ nonPrefixes addAll: aSet ]! Item was changed: ----- Method: RxMatchOptimizer>>addPrefixes: (in category 'private') ----- addPrefixes: aSet + aSet size = 0 ifTrue: [ ^aSet ]. ^prefixes ifNil: [ prefixes := aSet ] ifNotNil: [ prefixes addAll: aSet ]! Item was changed: ----- Method: RxMatchOptimizer>>nonPredicateTester (in category 'private') ----- nonPredicateTester + | p | - | p size | nonPredicates ifNil: [ ^nil ]. + nonPredicates size = 1 ifTrue: [ - (size := nonPredicates size) = 0 ifTrue: [ ^nil ]. - size = 1 ifTrue: [ | predicate | predicate := nonPredicates anyOne. + ^[ :char :matcher | (predicate value: char) not ] ]. - ^[ :char :matcher | (predicate value: char) not] ]. p := nonPredicates asArray. + ^[ :char :matcher | (p allSatisfy: [ :some | some value: char ]) not ]! - ^[ :char :m | (p allSatisfy: [:some | some value: char ]) not ]! Item was changed: ----- Method: RxMatchOptimizer>>nonPrefixTester (in category 'private') ----- nonPrefixTester - | size | nonPrefixes ifNil: [ ^nil ]. + nonPrefixes size = 1 ifTrue: [ - (size := nonPrefixes size) = 0 ifTrue: [ ^nil ]. - size = 1 ifTrue: [ | nonPrefixChar | nonPrefixChar := nonPrefixes anyOne. ^[ :char :matcher | char ~~ nonPrefixChar ] ]. ^[ :char : matcher | (nonPrefixes includes: char) not ]! Item was changed: ----- Method: RxMatchOptimizer>>predicateTester (in category 'private') ----- predicateTester + | p | - | p size | predicates ifNil: [ ^nil ]. + predicates size = 1 ifTrue: [ - (size := predicates size) = 0 ifTrue: [ ^nil ]. - size = 1 ifTrue: [ | pred | pred := predicates anyOne. ^[ :char :matcher | pred value: char ] ]. p := predicates asArray. ^[ :char :matcher | p anySatisfy: [:some | some value: char ] ]! Item was changed: ----- Method: RxMatchOptimizer>>prefixTester (in category 'private') ----- prefixTester + | p | - | p size | prefixes ifNil: [ ^nil ]. + prefixes size = 1 ifTrue: [ - (size := prefixes size) = 0 ifTrue: [ ^nil ]. - size = 1 ifTrue: [ | prefixChar | prefixChar := prefixes anyOne. + ignoreCase ifTrue: [ + | lowercasePrefixChar | + lowercasePrefixChar := prefixChar asLowercase. + prefixChar := prefixChar asUppercase. + prefixChar == lowercasePrefixChar ifFalse: [ + ^[ :char :matcher | char == prefixChar or: [ char == lowercasePrefixChar ] ] ] ]. - ignoreCase ifTrue: [ ^[ :char :matcher | char sameAs: prefixChar ] ]. ^[ :char :matcher | char == prefixChar ] ]. + ignoreCase ifTrue: [ + prefixes copy do: [ :each | + | character | + (character := each asUppercase) == each ifFalse: [ + prefixes add: character ]. + (character := each asUppercase) == each ifFalse: [ + prefixes add: character ] ] ]. + prefixes size < 10 ifTrue: [ "10 is an empirical value" + p := prefixes asArray. + ^[ :char :matcher | p instVarsInclude: char ] ]. + ^[ :char :matcher | prefixes includes: char ]! - ignoreCase ifFalse: [ ^[ :char :matcher | prefixes includes: char ] ]. - p := prefixes collect: [ :each | each asUppercase ]. - ^[ :char :matcher | p includes: char asUppercase ]! Item was changed: ----- Method: RxMatcher>>atEndOfLine (in category 'testing') ----- atEndOfLine + | peek | + (peek := stream peek ifNil: [ ^true ]) == Cr ifTrue: [ ^true ]. + ^peek == Lf! - ^self atEnd or: [stream peek = Cr]!

1 0

modifying copied context vars
by Nicolai Hess 26 Mar '16

26 Mar '16

Hello, we have a failing test (OCClosureCompilerTest>>#testDebuggerTempAccess) (fails since spur, but not related - I think). A simple example to reproduce the behavior: | local1 remote1| remote1:=4. local1 :=3.[:i | |c| c := local1. remote1 := i. i halt. "local1:=25. <-- evaluate during debugging" ] value:1. Transcript show:local1;cr. Transcript show:remote1;cr. (Executing this code and evaluating "local:=25" after the debugger halts for "i halt" will modify the var "remote1" instead of "local1", as this is a vector tempvar , proceeding the execution will crash at accessing the remote1 value). The purpose of the testDebuggerTempAccess test case is, evaluating code that changes the value of a copied temp var *does not* change the value of this var in the outer context. (see comment in the test case: "this is not 25 as the var is a local, non escaping variable that was copied into the block, If the compiler would have known about the write, it would have made the var escaping". ) But the implementation (OCCopyingTempVariable>>#writeFromContext: aContext scope: contextScope value: aValue) explicitly iterates through all outer context(s) and changes the vars as well. 1. Question: Who is right? But the reason why the test actually fails is different. It is because evaluating the code that modifies the var "local1:=25" ends up to a call aContext tempAt: self indexFromIR put: aValue but the index (indexFromIR) can be different for every context (method context / inner block context(s)). 2. Question: should the index be always the same? thanks inadvance Nicolai ps: since spur (resp. compiler changes that were done for new spur images), the index of tempvars can be different. In pre-spur, this testcase modifies an outer context var, but one that isn't checked (the argument "two"), therefore the test succeed. In spur, this testcase modifes a different outer context var "remote1", and the test fails.

2 4

The Trunk: Network-ul.174.mcz
by commits＠source.squeak.org 26 Mar '16

26 Mar '16

Levente Uzonyi uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-ul.174.mcz ==================== Summary ==================== Name: Network-ul.174 Author: ul Time: 26 March 2016, 4:46:36.918112 am UUID: e49a70ec-9eac-48e7-a03e-d712e2fcd12d Ancestors: Network-eem.173 Socket changes - use the instance variables for the semaphores, since it's clear now which semaphore is responsible for reading and writing (it might as well been done that way originally by assigning the same value to all three variables) - removed the max: 0 checks when the wait time is passed to the semaphores via #waitTimeoutMSecs:, because that method will do the same check =============== Diff against Network-eem.173 =============== Item was changed: ----- Method: Socket>>waitForDataFor:ifClosed:ifTimedOut: (in category 'waiting') ----- waitForDataFor: timeout ifClosed: closedBlock ifTimedOut: timedOutBlock "Wait for the given nr of seconds for data to arrive." | startTime msecsDelta | startTime := Time millisecondClockValue. msecsDelta := (timeout * 1000) truncated. [(Time millisecondsSince: startTime) < msecsDelta] whileTrue: [ (self primSocketReceiveDataAvailable: socketHandle) ifTrue: [^self]. self isConnected ifFalse: [^closedBlock value]. "Providing a maximum for the time for waiting is a workaround for a VM bug which causes sockets waiting for data forever in some rare cases, because the semaphore doesn't get signaled. Remove the ""min: self class maximumReadSemaphoreWaitTimeout"" part when the bug is fixed." + readSemaphore waitTimeoutMSecs: + (msecsDelta - (Time millisecondsSince: startTime) min: self class maximumReadSemaphoreWaitTimeout). - self readSemaphore waitTimeoutMSecs: - ((msecsDelta - (Time millisecondsSince: startTime) max: 0) min: self class maximumReadSemaphoreWaitTimeout). ]. (self primSocketReceiveDataAvailable: socketHandle) ifFalse: [ self isConnected ifTrue: [^timedOutBlock value] ifFalse: [^closedBlock value]].! Item was changed: ----- Method: Socket>>waitForDataIfClosed: (in category 'waiting') ----- waitForDataIfClosed: closedBlock "Wait indefinitely for data to arrive. This method will block until data is available or the socket is closed." [(socketHandle ~~ nil and: [self primSocketReceiveDataAvailable: socketHandle]) ifTrue: [^self]. self isConnected ifFalse: [^closedBlock value]. "ul 8/13/2014 21:16 Providing a maximum for the time for waiting is a workaround for a VM bug which causes sockets waiting for data forever in some rare cases, because the semaphore doesn't get signaled. Replace the ""waitTimeoutMSecs: self class maximumReadSemaphoreWaitTimeout"" part with ""wait"" when the bug is fixed." + readSemaphore waitTimeoutMSecs: self class maximumReadSemaphoreWaitTimeout] repeat! - self readSemaphore waitTimeoutMSecs: self class maximumReadSemaphoreWaitTimeout] repeat! Item was changed: ----- Method: Socket>>waitForDisconnectionFor: (in category 'waiting') ----- waitForDisconnectionFor: timeout "Wait for the given nr of seconds for the connection to be broken. Return true if it is broken by the deadline, false if not. The client should know the connection is really going to be closed (e.g., because he has called 'close' to send a close request to the other end) before calling this method." | startTime msecsDelta status | startTime := Time millisecondClockValue. msecsDelta := (timeout * 1000) truncated. status := self primSocketConnectionStatus: socketHandle. [((status == Connected) or: [(status == ThisEndClosed)]) and: [(Time millisecondsSince: startTime) < msecsDelta]] whileTrue: [ self discardReceivedData. "Providing a maximum for the time for waiting is a workaround for a VM bug which causes sockets waiting for data forever in some rare cases, because the semaphore doesn't get signaled. Remove the ""min: self class maximumReadSemaphoreWaitTimeout"" part when the bug is fixed." + readSemaphore waitTimeoutMSecs: + (msecsDelta - (Time millisecondsSince: startTime) min: self class maximumReadSemaphoreWaitTimeout). - self readSemaphore waitTimeoutMSecs: - ((msecsDelta - (Time millisecondsSince: startTime) max: 0) min: self class maximumReadSemaphoreWaitTimeout). status := self primSocketConnectionStatus: socketHandle]. ^ status ~= Connected! Item was changed: ----- Method: Socket>>waitForSendDoneFor: (in category 'waiting') ----- waitForSendDoneFor: timeout "Wait up until the given deadline for the current send operation to complete. Return true if it completes by the deadline, false if not." | startTime msecsDelta msecsEllapsed sendDone | startTime := Time millisecondClockValue. msecsDelta := (timeout * 1000) truncated. [(sendDone := self primSocketSendDone: socketHandle) not and: [ self isConnected "Connection end and final data can happen fast, so test in this order" and: [(msecsEllapsed := Time millisecondsSince: startTime) < msecsDelta]]] whileTrue: [ + writeSemaphore waitTimeoutMSecs: msecsDelta - msecsEllapsed]. - self writeSemaphore waitTimeoutMSecs: msecsDelta - msecsEllapsed]. ^ sendDone!

1 0

Re: [squeak-dev] [Vm-dev] I would be extremely grateful for a reproducible case for the following Socket issue
by Eliot Miranda 25 Mar '16

25 Mar '16

Hi Holger, let's collaborate on this. You and I and lots of others want this to be done. But in fixing the below bug my priorities are to a) deliver a fix promptly b) write the code so that either kqueue or epoll or select will be used based on HAVE_KQUEUE & HAVE_EPOLL defines So if I deliver a fix don't think that I'm against having a proper event-driven or idling VM, I just don't have it in my head yet and want the bug fixed and kqueue/epoll available asap. On Thu, Mar 24, 2016 at 11:42 PM, Holger Freyther <holger(a)freyther.de> wrote: > > > > On 25 Mar 2016, at 00:35, Eliot Miranda <eliot.miranda(a)gmail.com> wrote: > > > > > Dear Eliot, > > > > Fabulous, thank you! replace the self halts with e.g. self assert: > (clientSocket dataAvailable = (clientSocket readSemaphore excessSignals > > 0)), and we even have a test. I have work to do tomorrow but hope I should > be able to debug this soon. I'll add kqueue and epoll support when I fix > it. > > before going to kqueue, could you have a look at my hack to create a > completely idle VM? Once the VM has moved to kqueue it seems one can not > get a SIGIO for the "kqueue descriptor"[1] itself and I don't know if SIGIO > remains working for the individual file descriptors. > > holger > > > [1] > https://github.com/freebsd/freebsd/blob/master/sys/kern/kern_event.c#L1735 > > -- _,,,^..^,,,_ best, Eliot

1 0

Re: [squeak-dev] [Vm-dev] I would be extremely grateful for a reproducible case for the following Socket issue
by Levente Uzonyi 25 Mar '16

25 Mar '16

Hi Holger, The snippet doesn't seem to trigger the issue when strace is attached to the process. But it usually runs into the issue short after I stop strace. Levente On Thu, 24 Mar 2016, Holger Freyther wrote: > > >> On 24 Mar 2016, at 10:16, Levente Uzonyi <leves(a)caesar.elte.hu> wrote: >> >> Hi Eliot, >> >> The snippet below, evaluated from a workspace, triggered the issue in less than a minute for me, three times in a row. >> Both processes will halt if #sloppyWaitForDataIfClosed: doesn't return within a second. If you send #dataAvailable to the socket, you'll find that it has data ready to be read, but its readSemaphore has no signal. > > does it happen if you have strace -o output.txt -f on the VM as well? > > kind regards > holger

1 0

preference to add Monticello merges to recent changes?
by Eliot Miranda 25 Mar '16

25 Mar '16

Hi All, I often times find myself wanting to see the most recently loaded changes after a package update. How about a preference that would cause Monticello to add changes to recent changes if loading a new version of a package (but not if loading a package for the first time)? _,,,^..^,,,_ best, Eliot

5 9

← Newer
1
2
3
4
5
6
7
8
9
...
15
Older →

Jump to page: