Squeak-dev May 2016

squeak-dev@lists.squeakfoundation.org

45 participants
258 discussions

Re: [squeak-dev] The Trunk: Regex-Core-ul.52.mcz
by Nicolas Cellier 20 May '16

20 May '16

+1 I presume copyChain is a bit more expensive than copy (I didn’t measure it though). More expensive but allways correct. If the inexpensive copy is used extensively, and my suggestion is a performance killer, then let’s keep current solution: cleverly use expensive copy exactly where we now we are going to need it. Otherwise, I suggest renaming copyChain into copy, and hence have something much more robust. 2016-05-20 1:03 GMT+02:00 <commits(a)source.squeak.org>: > Levente Uzonyi uploaded a new version of Regex-Core to project The Trunk: > http://source.squeak.org/trunk/Regex-Core-ul.52.mcz > > ==================== Summary ==================== > > Name: Regex-Core-ul.52 > Author: ul > Time: 20 May 2016, 1:02:48.025069 am > UUID: 25d06172-cbd2-4454-a5e7-0dcfc27525b4 > Ancestors: Regex-Core-pre.51 > > RxmLink changes: > - implemented #copyChain, #copyUsing: and #postCopyUsing: to create a copy > of the matcher chain without creating duplicates of links being referenced > from more than one place > - implemented missing #postCopy methods > - removed unused variables from subclasses > > - use #copyChain instead of #veryDeepCopy in RxMatcher >> > #makeQuantified:min:max: to avoid unnecessary duplication of non-link > objects > > =============== Diff against Regex-Core-pre.51 =============== > > Item was changed: > ----- Method: RxMatcher>>makeQuantified:min:max: (in category 'private') > ----- > makeQuantified: anRxmLink min: min max: max > "Perform recursive poor-man's transformation of the {<min>,<max>} > quantifiers." > | aMatcher | > > "<atom>{,<max>} ==> (<atom>{1,<max>})?" > min = 0 ifTrue: [ > ^ self makeOptional: (self makeQuantified: anRxmLink min: > 1 max: max) ]. > > "<atom>{<min>,} ==> <atom>{<min>-1, <min>-1}<atom>+" > max ifNil: [ > + ^ (self makeQuantified: anRxmLink min: 1 max: min-1) > pointTailTo: (self makePlus: anRxmLink copyChain) ]. > - ^ (self makeQuantified: anRxmLink min: 1 max: min-1) > pointTailTo: (self makePlus: anRxmLink veryDeepCopy) ]. > > "<atom>{<max>,<max>} ==> <atom><atom> ... <atom>" > min = max > ifTrue: [ > + aMatcher := anRxmLink copyChain. > + (min-1) timesRepeat: [ aMatcher pointTailTo: > anRxmLink copyChain ]. > - aMatcher := anRxmLink veryDeepCopy. > - (min-1) timesRepeat: [ aMatcher pointTailTo: > anRxmLink veryDeepCopy ]. > ^ aMatcher ]. > > "<atom>{<min>,<max>} ==> <atom>{<min>,<min>}(<atom>{1,<max>-1})?" > + aMatcher := self makeOptional: anRxmLink copyChain. > - aMatcher := self makeOptional: anRxmLink veryDeepCopy. > (max - min - 1) timesRepeat: [ > + aMatcher := self makeOptional: (anRxmLink copyChain > pointTailTo: aMatcher) ]. > - aMatcher := self makeOptional: (anRxmLink veryDeepCopy > pointTailTo: aMatcher) ]. > ^ (self makeQuantified: anRxmLink min: min max: min) pointTailTo: > aMatcher! > > Item was added: > + ----- Method: RxmBranch>>postCopyUsing: (in category 'copying') ----- > + postCopyUsing: anIdentityDictionary > + > + super postCopyUsing: anIdentityDictionary. > + alternative ifNotNil: [ > + alternative := alternative copyUsing: anIdentityDictionary > ]! > > Item was added: > + ----- Method: RxmLink>>copyChain (in category 'copying') ----- > + copyChain > + "Create a full copy of all the links in this chain, including > branches, while letting them share and reuse non-link objects as much as > possible." > + > + ^self copyUsing: IdentityDictionary new! > > Item was added: > + ----- Method: RxmLink>>copyUsing: (in category 'copying') ----- > + copyUsing: anIdentityDictionary > + "Copy the receiver if it's not present in the argument dictionary, > or just return the previously made copy. The rest of the object graph will > be copied by #postCopyUsing:." > + > + ^anIdentityDictionary > + at: self > + ifAbsent: [ > + "It may be tempting to use #at:ifAbsentPut: > instead, but the argument block must not modify the receiver, so that > wouldn't work." > + anIdentityDictionary > + at: self > + put: (self shallowCopy > + postCopyUsing: > anIdentityDictionary; > + yourself) ]! > > Item was added: > + ----- Method: RxmLink>>postCopyUsing: (in category 'copying') ----- > + postCopyUsing: anIdentityDictionary > + "Copy the rest of the chain the same way as it's done in > #copyUsing:." > + > + next ifNotNil: [ > + next := next copyUsing: anIdentityDictionary ]! > > Item was changed: > RxmLink subclass: #RxmLookahead > + instanceVariableNames: 'lookahead' > - instanceVariableNames: 'lookahead positive' > classVariableNames: '' > poolDictionaries: '' > category: 'Regex-Core'! > > !RxmLookahead commentStamp: '<historical>' prior: 0! > Instance holds onto a lookead which matches but does not consume > anything. > > Instance variables: > predicate <RxmLink>! > > Item was removed: > - ----- Method: RxmLookahead>>initialize (in category 'initialization') > ----- > - initialize > - super initialize. > - positive := true.! > > Item was added: > + ----- Method: RxmLookahead>>postCopy (in category 'copying') ----- > + postCopy > + > + super postCopy. > + lookahead := lookahead copy! > > Item was added: > + ----- Method: RxmLookahead>>postCopyUsing: (in category 'copying') ----- > + postCopyUsing: anIdentityDictionary > + > + super postCopyUsing: anIdentityDictionary. > + lookahead := lookahead copyUsing: anIdentityDictionary! > > Item was changed: > RxmLink subclass: #RxmSubstring > + instanceVariableNames: 'sampleStream ignoreCase' > - instanceVariableNames: 'sampleStream caseSensitive ignoreCase' > classVariableNames: '' > poolDictionaries: '' > category: 'Regex-Core'! > > !RxmSubstring commentStamp: 'Tbn 11/12/2010 23:14' prior: 0! > -- Regular Expression Matcher v 1.1 (C) 1996, 1999 Vassili Bykov > -- > Instance holds onto a string and matches exactly this string, and > exactly once. > > Instance variables: > string <String>! > > Item was added: > + ----- Method: RxmSubstring>>postCopy (in category 'copying') ----- > + postCopy > + > + super postCopy. > + sampleStream := sampleStream copy! > > Item was added: > + ----- Method: RxmSubstring>>postCopyUsing: (in category 'copying') ----- > + postCopyUsing: anIdentityDictionary > + > + super postCopyUsing: anIdentityDictionary. > + sampleStream := sampleStream copy! > > >

1 1

Re: [squeak-dev] The Trunk: Regex-Core-pre.51.mcz
by Nicolas Cellier 20 May '16

20 May '16

Hi Patrick, IMO copy should copy deep enough without the need to invoke veryDeepCopy. Wouldn't it be a missing postCopy in RxmLookahead? postCopy super postCopy. lookahead := lookahead copy 2016-05-19 20:49 GMT+02:00 <commits(a)source.squeak.org>: > Patrick Rein uploaded a new version of Regex-Core to project The Trunk: > http://source.squeak.org/trunk/Regex-Core-pre.51.mcz > > ==================== Summary ==================== > > Name: Regex-Core-pre.51 > Author: pre > Time: 19 May 2016, 8:49:05.994548 pm > UUID: 49e3e29a-cf96-4f42-a8f1-4af75dbb9bca > Ancestors: Regex-Core-ul.50 > > Fixes an erroring test of RxMatcher by replacing a copy with a > veryDeepCopy to sustain the integrity of the RxmLink tree. > > =============== Diff against Regex-Core-ul.50 =============== > > Item was changed: > ----- Method: RxMatcher>>makeQuantified:min:max: (in category 'private') > ----- > makeQuantified: anRxmLink min: min max: max > "Perform recursive poor-man's transformation of the {<min>,<max>} > quantifiers." > | aMatcher | > > "<atom>{,<max>} ==> (<atom>{1,<max>})?" > min = 0 ifTrue: [ > ^ self makeOptional: (self makeQuantified: anRxmLink min: > 1 max: max) ]. > > "<atom>{<min>,} ==> <atom>{<min>-1, <min>-1}<atom>+" > max ifNil: [ > + ^ (self makeQuantified: anRxmLink min: 1 max: min-1) > pointTailTo: (self makePlus: anRxmLink veryDeepCopy) ]. > - ^ (self makeQuantified: anRxmLink min: 1 max: min-1) > pointTailTo: (self makePlus: anRxmLink copy) ]. > > "<atom>{<max>,<max>} ==> <atom><atom> ... <atom>" > min = max > ifTrue: [ > + aMatcher := anRxmLink veryDeepCopy. > + (min-1) timesRepeat: [ aMatcher pointTailTo: > anRxmLink veryDeepCopy ]. > - aMatcher := anRxmLink copy. > - (min-1) timesRepeat: [ aMatcher pointTailTo: > anRxmLink copy ]. > ^ aMatcher ]. > > "<atom>{<min>,<max>} ==> <atom>{<min>,<min>}(<atom>{1,<max>-1})?" > + aMatcher := self makeOptional: anRxmLink veryDeepCopy. > - aMatcher := self makeOptional: anRxmLink copy. > (max - min - 1) timesRepeat: [ > + aMatcher := self makeOptional: (anRxmLink veryDeepCopy > pointTailTo: aMatcher) ]. > - aMatcher := self makeOptional: (anRxmLink copy > pointTailTo: aMatcher) ]. > ^ (self makeQuantified: anRxmLink min: min max: min) pointTailTo: > aMatcher! > > >

3 3

The Trunk: Kernel-ul.1024.mcz
by commits＠source.squeak.org 20 May '16

20 May '16

Levente Uzonyi uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ul.1024.mcz ==================== Summary ==================== Name: Kernel-ul.1024 Author: ul Time: 20 May 2016, 1:19:14.472859 am UUID: 68c736cc-d98c-4303-a68e-312488b5c51a Ancestors: Kernel-eem.1023 Copied the fallback code of LargePositiveInteger >> #replaceFrom:to:with:startingAt: from its parent class and extended it to make it compatible with the primitive as well. =============== Diff against Kernel-eem.1023 =============== Item was changed: ----- Method: LargePositiveInteger>>replaceFrom:to:with:startingAt: (in category 'system primitives') ----- replaceFrom: start to: stop with: replacement startingAt: repStart "Primitive. This destructively replaces elements from start to stop in the receiver starting at index, repStart, in the collection, replacement. Answer the receiver. Range checks are performed in the primitive only. Optional. See Object documentation whatIsAPrimitive." + + | index replacementIndex | <primitive: 105> + replacementIndex := repStart. + index := start. + replacement isInteger ifTrue: [ + "This branch is only here to accept SmallInteger replacements not handled by the primitive." + [ index <= stop ] whileTrue: [ + self digitAt: index put: (replacement digitAt: replacementIndex). + index := index + 1. + replacementIndex := replacementIndex + 1 ]. + ^self ]. + "Primitive compatible variant which doesn't support SmallInteger replacements." + [ index <= stop ] whileTrue: [ + self basicAt: index put: (replacement basicAt: replacementIndex). + index := index + 1. + replacementIndex := replacementIndex + 1 ]! - ^ super replaceFrom: start to: stop with: replacement startingAt: repStart!

1 0

The Trunk: Regex-Core-ul.52.mcz
by commits＠source.squeak.org 20 May '16

20 May '16

Levente Uzonyi uploaded a new version of Regex-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Core-ul.52.mcz ==================== Summary ==================== Name: Regex-Core-ul.52 Author: ul Time: 20 May 2016, 1:02:48.025069 am UUID: 25d06172-cbd2-4454-a5e7-0dcfc27525b4 Ancestors: Regex-Core-pre.51 RxmLink changes: - implemented #copyChain, #copyUsing: and #postCopyUsing: to create a copy of the matcher chain without creating duplicates of links being referenced from more than one place - implemented missing #postCopy methods - removed unused variables from subclasses - use #copyChain instead of #veryDeepCopy in RxMatcher >> #makeQuantified:min:max: to avoid unnecessary duplication of non-link objects =============== Diff against Regex-Core-pre.51 =============== Item was changed: ----- Method: RxMatcher>>makeQuantified:min:max: (in category 'private') ----- makeQuantified: anRxmLink min: min max: max "Perform recursive poor-man's transformation of the {<min>,<max>} quantifiers." | aMatcher | "<atom>{,<max>} ==> (<atom>{1,<max>})?" min = 0 ifTrue: [ ^ self makeOptional: (self makeQuantified: anRxmLink min: 1 max: max) ]. "<atom>{<min>,} ==> <atom>{<min>-1, <min>-1}<atom>+" max ifNil: [ + ^ (self makeQuantified: anRxmLink min: 1 max: min-1) pointTailTo: (self makePlus: anRxmLink copyChain) ]. - ^ (self makeQuantified: anRxmLink min: 1 max: min-1) pointTailTo: (self makePlus: anRxmLink veryDeepCopy) ]. "<atom>{<max>,<max>} ==> <atom><atom> ... <atom>" min = max ifTrue: [ + aMatcher := anRxmLink copyChain. + (min-1) timesRepeat: [ aMatcher pointTailTo: anRxmLink copyChain ]. - aMatcher := anRxmLink veryDeepCopy. - (min-1) timesRepeat: [ aMatcher pointTailTo: anRxmLink veryDeepCopy ]. ^ aMatcher ]. "<atom>{<min>,<max>} ==> <atom>{<min>,<min>}(<atom>{1,<max>-1})?" + aMatcher := self makeOptional: anRxmLink copyChain. - aMatcher := self makeOptional: anRxmLink veryDeepCopy. (max - min - 1) timesRepeat: [ + aMatcher := self makeOptional: (anRxmLink copyChain pointTailTo: aMatcher) ]. - aMatcher := self makeOptional: (anRxmLink veryDeepCopy pointTailTo: aMatcher) ]. ^ (self makeQuantified: anRxmLink min: min max: min) pointTailTo: aMatcher! Item was added: + ----- Method: RxmBranch>>postCopyUsing: (in category 'copying') ----- + postCopyUsing: anIdentityDictionary + + super postCopyUsing: anIdentityDictionary. + alternative ifNotNil: [ + alternative := alternative copyUsing: anIdentityDictionary ]! Item was added: + ----- Method: RxmLink>>copyChain (in category 'copying') ----- + copyChain + "Create a full copy of all the links in this chain, including branches, while letting them share and reuse non-link objects as much as possible." + + ^self copyUsing: IdentityDictionary new! Item was added: + ----- Method: RxmLink>>copyUsing: (in category 'copying') ----- + copyUsing: anIdentityDictionary + "Copy the receiver if it's not present in the argument dictionary, or just return the previously made copy. The rest of the object graph will be copied by #postCopyUsing:." + + ^anIdentityDictionary + at: self + ifAbsent: [ + "It may be tempting to use #at:ifAbsentPut: instead, but the argument block must not modify the receiver, so that wouldn't work." + anIdentityDictionary + at: self + put: (self shallowCopy + postCopyUsing: anIdentityDictionary; + yourself) ]! Item was added: + ----- Method: RxmLink>>postCopyUsing: (in category 'copying') ----- + postCopyUsing: anIdentityDictionary + "Copy the rest of the chain the same way as it's done in #copyUsing:." + + next ifNotNil: [ + next := next copyUsing: anIdentityDictionary ]! Item was changed: RxmLink subclass: #RxmLookahead + instanceVariableNames: 'lookahead' - instanceVariableNames: 'lookahead positive' classVariableNames: '' poolDictionaries: '' category: 'Regex-Core'! !RxmLookahead commentStamp: '<historical>' prior: 0! Instance holds onto a lookead which matches but does not consume anything. Instance variables: predicate <RxmLink>! Item was removed: - ----- Method: RxmLookahead>>initialize (in category 'initialization') ----- - initialize - super initialize. - positive := true.! Item was added: + ----- Method: RxmLookahead>>postCopy (in category 'copying') ----- + postCopy + + super postCopy. + lookahead := lookahead copy! Item was added: + ----- Method: RxmLookahead>>postCopyUsing: (in category 'copying') ----- + postCopyUsing: anIdentityDictionary + + super postCopyUsing: anIdentityDictionary. + lookahead := lookahead copyUsing: anIdentityDictionary! Item was changed: RxmLink subclass: #RxmSubstring + instanceVariableNames: 'sampleStream ignoreCase' - instanceVariableNames: 'sampleStream caseSensitive ignoreCase' classVariableNames: '' poolDictionaries: '' category: 'Regex-Core'! !RxmSubstring commentStamp: 'Tbn 11/12/2010 23:14' prior: 0! -- Regular Expression Matcher v 1.1 (C) 1996, 1999 Vassili Bykov -- Instance holds onto a string and matches exactly this string, and exactly once. Instance variables: string <String>! Item was added: + ----- Method: RxmSubstring>>postCopy (in category 'copying') ----- + postCopy + + super postCopy. + sampleStream := sampleStream copy! Item was added: + ----- Method: RxmSubstring>>postCopyUsing: (in category 'copying') ----- + postCopyUsing: anIdentityDictionary + + super postCopyUsing: anIdentityDictionary. + sampleStream := sampleStream copy!

1 0

Re: [squeak-dev] The Inbox: Regex-Tests-Core-pre.6.mcz
by Rein, Patrick 20 May '16

20 May '16

I would like to comment further on these changes as they change the expected Regex engine behavior. The behavior, that matching groups in a multiple quantifier return the last match of the group is consistent with for example the Ruby regex engine: http://rubular.com/r/kxoreyPolG The issue is also decribed here: http://www.regular-expressions.info/captureall.html However, I am not sure what the intended behavior for RxMatcher is. Has this ever been working and what was the intended behavior? Bests Patrick ________________________________________ From: squeak-dev-bounces(a)lists.squeakfoundation.org <squeak-dev-bounces(a)lists.squeakfoundation.org> on behalf of commits(a)source.squeak.org <commits(a)source.squeak.org> Sent: Thursday, May 19, 2016 13:50 To: squeak-dev(a)lists.squeakfoundation.org Subject: [squeak-dev] The Inbox: Regex-Tests-Core-pre.6.mcz Patrick Rein uploaded a new version of Regex-Tests-Core to project The Inbox: http://source.squeak.org/inbox/Regex-Tests-Core-pre.6.mcz ==================== Summary ==================== Name: Regex-Tests-Core-pre.6 Author: pre Time: 19 May 2016, 8:50:59.559548 pm UUID: e1cbdf20-9ce2-4e4a-b1d8-574186c2e746 Ancestors: Regex-Tests-Core-ul.5 Adjustments to the Regex tests for optional subexpressions in multiple quantifiers. These tests demonstrate the different behavior when nesting subexpressions in quantifiers and the other way round. =============== Diff against Regex-Tests-Core-ul.5 =============== Item was added: + ----- Method: RxMatcherTest>>testOptionalMultipleQuantifiedSubexpression (in category 'testing') ----- + testOptionalMultipleQuantifiedSubexpression + <timeout: 0.1> + + self runRegex: #('((aa?){2})' + '' false nil + 'a' false nil + 'aa' true (1 'aa') + 'baaa' true (2 'aaa'))! Item was changed: ----- Method: RxMatcherTest>>testOptionalNestedIntoMultipleQuantified (in category 'testing') ----- testOptionalNestedIntoMultipleQuantified <timeout: 0.1> self runRegex: #('(aa?){2}' '' false nil 'a' false nil 'aa' true (1 'aa') + 'baaa' true (2 'a'))! - 'baaa' true (2 'aaa'))!

2 1

Daily Commit Log
by commits＠source.squeak.org 19 May '16

19 May '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-May/068125.html Name: System-ul.831 Ancestors: System-mt.830 - use #adoptInstance: instead of copying the ByteArray into a new LargeInteger in SecureHashAlgorithm >> #finalHash. This should be somewhat quicker and it should also avoid running the fallback code of LargePositiveInteger >> #replaceFrom:to:with:startingAt: with a ByteArray argument, which wouldn't work. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068126.html Name: ST80Tests-pre.4 Ancestors: ST80Tests-ul.3 Fixes a test for the ST80 package which asserts the packages the ST80 package depends on. Adds Monticello to the list as it is now needed for the unloading capabilities ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068127.html Name: Multilingual-pre.212 Ancestors: Multilingual-ul.211 Fixes broken TestIndenting as StrikeFontSet did not fullfill the interface required for a Font although it is a subclass of AbstractFont ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068128.html Name: ToolsTests-pre.77 Ancestors: ToolsTests-nice.76 Fixes a test for the FileList class. The itemsForFile: method requires a fully qualified path which is stated in the method and also provided by internal methods of FileList. The test however used a relative path. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068129.html Name: Tests-pre.342 Ancestors: Tests-pre.341 As discussed several times on the mailing list the ExceptionTests>>testHandlerFromAction test is a feature request test and should be regarded as an expectedFailure. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068130.html Name: Tests-pre.343 Ancestors: Tests-pre.342 Reverts accidential change to the PackageDependencyTest which actually resides in the inbox ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-May/068131.html Name: Regex-Core-pre.51 Ancestors: Regex-Core-ul.50 Fixes an erroring test of RxMatcher by replacing a copy with a veryDeepCopy to sustain the integrity of the RxmLink tree. =============================================

1 0

StrikeFonstSet vs StrikeFont
by Patrick R. 19 May '16

19 May '16

Hi everyone :) I am currently fixing some tests in the Multilingual package. While doing this I edited the StrikeFontSet class and was wondering about its purpose. Although it is called a FontSet it is actually a subclass of AbstractFont and all instances available in a recent image do only contain one single font. Even further some methods of the class are implemented along the line of: self fontArray first ... Unfortunately the class does not include a class comment yet and I would like to fix this. That is why I wanted to ask whether anyone still knows the rationale behind this seeming contradiction. Thanks! and Bests Patrick -- View this message in context: http://forum.world.st/StrikeFonstSet-vs-StrikeFont-tp4895960.html Sent from the Squeak - Dev mailing list archive at Nabble.com.

3 2

The Inbox: Regex-Tests-Core-pre.6.mcz
by commits＠source.squeak.org 19 May '16

19 May '16

Patrick Rein uploaded a new version of Regex-Tests-Core to project The Inbox: http://source.squeak.org/inbox/Regex-Tests-Core-pre.6.mcz ==================== Summary ==================== Name: Regex-Tests-Core-pre.6 Author: pre Time: 19 May 2016, 8:50:59.559548 pm UUID: e1cbdf20-9ce2-4e4a-b1d8-574186c2e746 Ancestors: Regex-Tests-Core-ul.5 Adjustments to the Regex tests for optional subexpressions in multiple quantifiers. These tests demonstrate the different behavior when nesting subexpressions in quantifiers and the other way round. =============== Diff against Regex-Tests-Core-ul.5 =============== Item was added: + ----- Method: RxMatcherTest>>testOptionalMultipleQuantifiedSubexpression (in category 'testing') ----- + testOptionalMultipleQuantifiedSubexpression + <timeout: 0.1> + + self runRegex: #('((aa?){2})' + '' false nil + 'a' false nil + 'aa' true (1 'aa') + 'baaa' true (2 'aaa'))! Item was changed: ----- Method: RxMatcherTest>>testOptionalNestedIntoMultipleQuantified (in category 'testing') ----- testOptionalNestedIntoMultipleQuantified <timeout: 0.1> self runRegex: #('(aa?){2}' '' false nil 'a' false nil 'aa' true (1 'aa') + 'baaa' true (2 'a'))! - 'baaa' true (2 'aaa'))!

1 0

The Trunk: Regex-Core-pre.51.mcz
by commits＠source.squeak.org 19 May '16

19 May '16

Patrick Rein uploaded a new version of Regex-Core to project The Trunk: http://source.squeak.org/trunk/Regex-Core-pre.51.mcz ==================== Summary ==================== Name: Regex-Core-pre.51 Author: pre Time: 19 May 2016, 8:49:05.994548 pm UUID: 49e3e29a-cf96-4f42-a8f1-4af75dbb9bca Ancestors: Regex-Core-ul.50 Fixes an erroring test of RxMatcher by replacing a copy with a veryDeepCopy to sustain the integrity of the RxmLink tree. =============== Diff against Regex-Core-ul.50 =============== Item was changed: ----- Method: RxMatcher>>makeQuantified:min:max: (in category 'private') ----- makeQuantified: anRxmLink min: min max: max "Perform recursive poor-man's transformation of the {<min>,<max>} quantifiers." | aMatcher | "<atom>{,<max>} ==> (<atom>{1,<max>})?" min = 0 ifTrue: [ ^ self makeOptional: (self makeQuantified: anRxmLink min: 1 max: max) ]. "<atom>{<min>,} ==> <atom>{<min>-1, <min>-1}<atom>+" max ifNil: [ + ^ (self makeQuantified: anRxmLink min: 1 max: min-1) pointTailTo: (self makePlus: anRxmLink veryDeepCopy) ]. - ^ (self makeQuantified: anRxmLink min: 1 max: min-1) pointTailTo: (self makePlus: anRxmLink copy) ]. "<atom>{<max>,<max>} ==> <atom><atom> ... <atom>" min = max ifTrue: [ + aMatcher := anRxmLink veryDeepCopy. + (min-1) timesRepeat: [ aMatcher pointTailTo: anRxmLink veryDeepCopy ]. - aMatcher := anRxmLink copy. - (min-1) timesRepeat: [ aMatcher pointTailTo: anRxmLink copy ]. ^ aMatcher ]. "<atom>{<min>,<max>} ==> <atom>{<min>,<min>}(<atom>{1,<max>-1})?" + aMatcher := self makeOptional: anRxmLink veryDeepCopy. - aMatcher := self makeOptional: anRxmLink copy. (max - min - 1) timesRepeat: [ + aMatcher := self makeOptional: (anRxmLink veryDeepCopy pointTailTo: aMatcher) ]. - aMatcher := self makeOptional: (anRxmLink copy pointTailTo: aMatcher) ]. ^ (self makeQuantified: anRxmLink min: min max: min) pointTailTo: aMatcher!

1 0

Re: [squeak-dev] The Inbox: Tests-pre.341.mcz
by Levente Uzonyi 19 May '16

19 May '16

Hi Patrick, Even if the change was intentional, PreferenceBrowser depending on Etoys is not something we would want. Accepting this dependency would mean that if we were able to unload Etoys, we would lose PreferenceBrowser as well. Instead, we should move UpdatingRectangleMorph from Etoys to Morphic or MorphicExtras. Levente On Thu, 19 May 2016, commits(a)source.squeak.org wrote: > Patrick Rein uploaded a new version of Tests to project The Inbox: > http://source.squeak.org/inbox/Tests-pre.341.mcz > > ==================== Summary ==================== > > Name: Tests-pre.341 > Author: pre > Time: 19 May 2016, 5:34:18.672168 pm > UUID: 0209ce70-2b8b-4d53-b743-ed1024d367ea > Ancestors: Tests-eem.340 > > By moving the PBColorPreferenceView from the EToys package to the PreferenceBrowser package, the PB package now depends on etyos through the UpdatingRectangleMorph. If this is intentional we should make the following modification to the PackageDependencyTests. > > =============== Diff against Tests-eem.340 =============== > > Item was changed: > ----- Method: PackageDependencyTest>>testPreferenceBrowser (in category 'tests') ----- > testPreferenceBrowser > self testPackage: #PreferenceBrowser dependsExactlyOn: #( > #'Chronology-Core' > Collections > Graphics > Kernel > Morphic > MorphicExtras > System > Tools > + #'ToolBuilder-Morphic' > + EToys > + Balloon > ).! > > >

2 2

← Newer
1
...
6
7
8
9
10
11
12
...
26
Older →

Jump to page: