Squeak-dev June 2016

squeak-dev@lists.squeakfoundation.org

39 participants
202 discussions

New Window and Focus related preferences
by Chris Muller 01 Jun '16

01 Jun '16

HI all, with Morphic-mt.1154, Marcel did a great upgrade to the focus-related preferences introduced last October. He was able to reduce the number of preferences from four to three, while eliminating all semantic ambiguity between them AND keeping all of the existing functionality. The old preferences: mouseOverForKeyboardFocus Focus Follows Mouse Window Active On First Click Windows Raise On Click have been replaced with just these three: Windows' Contents Are Always Active Windows' Controls Are Always Active Windows Raise On Any Click and yet every combination of variability among the dimensions of z-ordering, widget focus, and window focus are still available, except now, unambiguously. Nice work!

3 3

The Inbox: Compiler-cmm.179.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Chris Muller uploaded a new version of Compiler to project The Inbox: http://source.squeak.org/inbox/Compiler-cmm.179.mcz ==================== Summary ==================== Name: Compiler-cmm.179 Author: cmm Time: 7 November 2010, 8:37:59.582 pm UUID: 083197fc-650d-46da-9d1c-50a51630023c Ancestors: Compiler-ul.178, Compiler-cmm.174 - Merged improved pretty-print formatting. =============== Diff against Compiler-ul.178 =============== Item was added: + ----- Method: AssignmentNode>>isComplex (in category 'testing') ----- + isComplex + ^ value isComplex! Item was changed: ----- Method: AssignmentNode>>printOn:indent: (in category 'printing') ----- printOn: aStream indent: level variable printOn: aStream indent: level. aStream nextPutAll: ' := '. + value printOn: aStream indent: level! - value printOn: aStream indent: level + 2! Item was changed: ----- Method: BlockNode>>isComplex (in category 'testing') ----- isComplex + ^ statements size > 1 or: + [ (statements size = 1 and: [ statements first isComplex ]) or: + [ arguments size > 0 or: [ temporaries size > 0 ] ] ]! - - ^statements size > 1 or: [statements size = 1 and: [statements first isComplex]]! Item was changed: ----- Method: BlockNode>>printArgumentsOn:indent: (in category 'printing') ----- + printArgumentsOn: aStream indent: level - printArgumentsOn: aStream indent: level arguments size = 0 ifTrue: [^ self]. + arguments do: + [ : arg | + aStream nextPut: $: ; + space; + nextPutAll: arg key; + space ]. + aStream + nextPut: $|; + space! - arguments do: - [:arg | aStream nextPut: $:; nextPutAll: arg key; space]. - aStream nextPut: $|; space. - "If >0 args and >1 statement, put all statements on separate lines" - statements size > 1 ifTrue: - [aStream crtab: level]! Item was changed: ----- Method: BlockNode>>printOn:indent: (in category 'printing') ----- + printOn: aStream indent: level + aStream + nextPut: $[ ; + space. + self + printArgumentsOn: aStream + indent: level. + (self + printTemporaries: temporaries + on: aStream + doPrior: [ ] ) ifTrue: + [ "If >0 temps and >1 statement, put all statements on separate lines" + statements size > 1 + ifTrue: [ aStream crtab: level ] + ifFalse: [ aStream space] ] . + self + printStatementsOn: aStream + indent: level. + aStream + space ; + nextPut: $]! - printOn: aStream indent: level - - "statements size <= 1 ifFalse: [aStream crtab: level]." - aStream nextPut: $[. - self printArgumentsOn: aStream indent: level. - (self printTemporaries: temporaries on: aStream doPrior: []) ifTrue: - ["If >0 temps and >1 statement, put all statements on separate lines" - statements size > 1 - ifTrue: [aStream crtab: level] - ifFalse: [aStream space]]. - self printStatementsOn: aStream indent: level. - aStream nextPut: $]! Item was changed: ----- Method: BlockNode>>printWithClosureAnalysisOn:indent: (in category 'printing') ----- printWithClosureAnalysisOn: aStream indent: level + aStream nextPut: $[; space. - aStream nextPut: $[. blockExtent ifNotNil: [aStream print: blockExtent]. self printWithClosureAnalysisArgumentsOn: aStream indent: level. self printWithClosureAnalysisTemporariesOn: aStream indent: level. self printWithClosureAnalysisStatementsOn: aStream indent: level. + aStream space; nextPut: $]! - aStream nextPut: $]! Item was changed: ----- Method: BraceNode>>printOn:indent: (in category 'printing') ----- + printOn: aStream indent: level - printOn: aStream indent: level - aStream nextPut: ${. + 1 + to: elements size + do: + [ : i | + (elements at: i) + printOn: aStream + indent: level. + i < elements size ifTrue: + [ aStream + nextPutAll: '. ' ; + crtab: level ] ]. - 1 to: elements size do: - [:i | (elements at: i) printOn: aStream indent: level. - i < elements size ifTrue: [aStream nextPutAll: '. ']]. aStream nextPut: $}! Item was added: + ----- Method: CascadeNode>>isComplex (in category 'testing') ----- + isComplex + ^ true! Item was changed: ----- Method: CascadeNode>>printOn:indent:precedence: (in category 'printing') ----- printOn: aStream indent: level precedence: p + p > 0 ifTrue: [ aStream nextPut: $( ]. + messages first + printReceiver: receiver + on: aStream + indent: level. + 1 + to: messages size + do: + [ : i | + aStream crtab: level + 1. + (messages at: i) + printOn: aStream + indent: level. + i < messages size ifTrue: [ aStream nextPutAll: ' ;' ] ]. + p > 0 ifTrue: [ aStream nextPut: $) ]! - - p > 0 ifTrue: [aStream nextPut: $(]. - messages first printReceiver: receiver on: aStream indent: level. - 1 to: messages size do: - [:i | (messages at: i) printOn: aStream indent: level. - i < messages size ifTrue: - [aStream nextPut: $;. - messages first precedence >= 2 ifTrue: [aStream crtab: level + 1]]]. - p > 0 ifTrue: [aStream nextPut: $)]! Item was changed: ----- Method: MessageNode>>isComplex (in category 'testing') ----- isComplex + ^ (special + between: 1 + and: 10) + or: + [ arguments size > 1 + or: + [ receiver isComplex or: [ arguments anySatisfy: [ : each | each isComplex ] ] ] ]! - - ^(special between: 1 and: 10) or: [arguments size > 2 or: [receiver isComplex]]! Item was changed: ----- Method: MessageNode>>printIfOn:indent: (in category 'printing') ----- + printIfOn: aStream indent: level + receiver ifNotNil: + [ receiver + printOn: aStream + indent: level + precedence: precedence ]. + (arguments last isJust: NodeNil) ifTrue: [ ^ self + printKeywords: #ifTrue: + arguments: (Array with: arguments first) + on: aStream + indent: level ]. + (arguments last isJust: NodeFalse) ifTrue: [ ^ self + printKeywords: #and: + arguments: (Array with: arguments first) + on: aStream + indent: level ]. + (arguments first isJust: NodeNil) ifTrue: [ ^ self + printKeywords: #ifFalse: + arguments: (Array with: arguments last) + on: aStream + indent: level ]. + (arguments first isJust: NodeTrue) ifTrue: [ ^ self + printKeywords: #or: + arguments: (Array with: arguments last) + on: aStream + indent: level ]. + self + printKeywords: #ifTrue:ifFalse: + arguments: arguments + on: aStream + indent: level! - printIfOn: aStream indent: level - - receiver ifNotNil: - [receiver printOn: aStream indent: level + 1 precedence: precedence]. - (arguments last isJust: NodeNil) ifTrue: - [^self printKeywords: #ifTrue: arguments: (Array with: arguments first) - on: aStream indent: level]. - (arguments last isJust: NodeFalse) ifTrue: - [^self printKeywords: #and: arguments: (Array with: arguments first) - on: aStream indent: level]. - (arguments first isJust: NodeNil) ifTrue: - [^self printKeywords: #ifFalse: arguments: (Array with: arguments last) - on: aStream indent: level]. - (arguments first isJust: NodeTrue) ifTrue: - [^self printKeywords: #or: arguments: (Array with: arguments last) - on: aStream indent: level]. - self printKeywords: #ifTrue:ifFalse: arguments: arguments - on: aStream indent: level! Item was changed: ----- Method: MessageNode>>printKeywords:arguments:on:indent: (in category 'printing') ----- + printKeywords: key arguments: args on: aStream indent: level - printKeywords: key arguments: args on: aStream indent: level | keywords indent arg kwd doCrTab | args size = 0 ifTrue: + [ aStream + space ; + nextPutAll: key. + ^ self ]. - [aStream space; nextPutAll: key. - ^self]. keywords := key keywords. + doCrTab := args size > 1. + 1 + to: (args size min: keywords size) + do: + [ : i | arg := args at: i. + kwd := keywords at: i. + doCrTab + ifTrue: + [ aStream crtab: level + 1. + indent := 1 + "newline after big args" ] + ifFalse: + [ aStream space. + indent := 0 ]. + aStream nextPutAll: kwd. + arg isComplex + ifTrue: [ aStream crtab: level + indent + 1 ] + ifFalse: [ aStream space ]. + arg + printOn: aStream + indent: level + 1 + indent + precedence: + (precedence = 2 + ifTrue: [ 1 ] + ifFalse: [ precedence ]) ]! - doCrTab := args size > 2 - or: [{receiver} , args anySatisfy: - [:thisArg | - thisArg notNil - and: [thisArg isBlockNode - or: [thisArg isMessageNode and: [thisArg precedence >= 3]]]]]. - 1 to: (args size min: keywords size) do: - [:i | - arg := args at: i. - kwd := keywords at: i. - doCrTab - ifTrue: [aStream crtab: level+1. indent := 1] "newline after big args" - ifFalse: [aStream space. indent := 0]. - aStream nextPutAll: kwd; space. - arg printOn: aStream - indent: level + 1 + indent - precedence: (precedence = 2 ifTrue: [1] ifFalse: [precedence])]! Item was changed: ----- Method: ParseNode>>printSingleComment:on:indent: (in category 'private') ----- printSingleComment: aString on: aStream indent: indent + "Print the comment string, assuming it has been indented indent tabs. Break the string at word breaks, given the widths in the default font, at 450 points." + aStream nextPutAll: aString! - "Print the comment string, assuming it has been indented indent tabs. - Break the string at word breaks, given the widths in the default - font, at 450 points." - - | readStream word position lineBreak font wordWidth tabWidth spaceWidth lastChar | - readStream := ReadStream on: aString. - font := TextStyle default defaultFont. - tabWidth := TextConstants at: #DefaultTab. - spaceWidth := font widthOf: Character space. - position := indent * tabWidth. - lineBreak := 450. - [readStream atEnd] - whileFalse: - [word := self nextWordFrom: readStream setCharacter: [:lc | lastChar := lc]. - wordWidth := word inject: 0 into: [:width :char | width + (font widthOf: char)]. - position := position + wordWidth. - position > lineBreak - ifTrue: - [aStream skip: -1; crtab: indent. - position := indent * tabWidth + wordWidth + spaceWidth. - lastChar = Character cr - ifTrue: [[readStream peekFor: Character tab] whileTrue]. - word isEmpty ifFalse: [aStream nextPutAll: word; space]] - ifFalse: - [aStream nextPutAll: word. - readStream atEnd - ifFalse: - [position := position + spaceWidth. - aStream space]. - lastChar = Character cr - ifTrue: - [aStream skip: -1; crtab: indent. - position := indent * tabWidth. - [readStream peekFor: Character tab] whileTrue]]]!

1 0

Re: [squeak-dev] The Trunk: Morphic-mt.1156.mcz
by Chris Muller 01 Jun '16

01 Jun '16

> Note that there is still a bug, which I intend to fix if the event filters make it into the trunk. Namely, if you "debug it" and expression via the context menu, the appearing debugger will not be the top window. An additional click is required. Sorry for this inconvenience. It works if you use Tobias' new hot-key... (I love that hot-key!!) On Wed, Jun 1, 2016 at 9:09 AM, <commits(a)source.squeak.org> wrote: > Marcel Taeumel uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-mt.1156.mcz > > ==================== Summary ==================== > > Name: Morphic-mt.1156 > Author: mt > Time: 1 June 2016, 4:09:34.015287 pm > UUID: 522ade56-9b2e-f749-bb5c-cb117aa97c56 > Ancestors: Morphic-topa.1155 > > If #mouseOverForKeyboardFocus is disabled, do not highlight (a.k.a. "look focused") background windows on mouse-enter, even if they are active due to the preference "Windows' Contents Are Always Active". > > Note that there is still a bug, which I intend to fix if the event filters make it into the trunk. Namely, if you "debug it" and expression via the context menu, the appearing debugger will not be the top window. An additional click is required. Sorry for this inconvenience. > > =============== Diff against Morphic-topa.1155 =============== > > Item was changed: > MorphicModel subclass: #SystemWindow > + instanceVariableNames: 'labelString stripes label closeBox collapseBox paneMorphs paneRects collapsedFrame fullFrame isCollapsed isActive isLookingFocused menuBox mustNotClose labelWidgetAllowance updatablePanes allowReframeHandles labelArea expandBox' > - instanceVariableNames: 'labelString stripes label closeBox collapseBox paneMorphs paneRects collapsedFrame fullFrame isCollapsed isActive menuBox mustNotClose labelWidgetAllowance updatablePanes allowReframeHandles labelArea expandBox' > classVariableNames: 'ClickOnLabelToEdit CloseBoxFrame CloseBoxImageFlat CloseBoxImageGradient CollapseBoxImageFlat CollapseBoxImageGradient DoubleClickOnLabelToExpand ExpandBoxFrame ExpandBoxImageFlat ExpandBoxImageGradient FocusFollowsMouse GradientWindow HideExpandButton MenuBoxFrame MenuBoxImageFlat MenuBoxImageGradient ResizeAlongEdges ReuseWindows TopWindow WindowTitleActiveOnFirstClick WindowsRaiseOnClick' > poolDictionaries: '' > category: 'Morphic-Windows'! > > !SystemWindow commentStamp: '<historical>' prior: 0! > SystemWindow is the Morphic equivalent of StandardSystemView -- a labelled container for rectangular views, with iconic facilities for close, collapse/expand, and resizing. > > The attribute onlyActiveOnTop, if set to true (and any call to activate will set this), determines that only the top member of a collection of such windows on the screen shall be active. To be not active means that a mouse click in any region will only result in bringing the window to the top and then making it active.! > > Item was added: > + ----- Method: SystemWindow>>activateIfNeeded: (in category 'focus') ----- > + activateIfNeeded: evt > + "Make me the new key window if needed. Ensure that the focus look matches the keyboard focus." > + > + (self isKeyWindow not > + and: [self class windowsRaiseOnClick > + or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) > + ifTrue: [self beKeyWindow] > + ifFalse: [self updateFocusLookForKeyboardFocus].! > > Item was changed: > ----- Method: SystemWindow>>handleMouseDown: (in category 'events') ----- > handleMouseDown: evt > - > - "If my submorphs handled the events, we still need to use this hook to raise." > - (self isKeyWindow not > - and: [self class windowsRaiseOnClick > - or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) > - ifTrue: [self beKeyWindow]. > > + self activateIfNeeded: evt. > ^ super handleMouseDown: evt! > > Item was added: > + ----- Method: SystemWindow>>handleMouseUp: (in category 'events') ----- > + handleMouseUp: evt > + > + self activateIfNeeded: evt. > + ^ super handleMouseUp: evt! > > Item was added: > + ----- Method: SystemWindow>>isLookingFocused (in category 'focus') ----- > + isLookingFocused > + > + ^ isLookingFocused ifNil: [false]! > > Item was added: > + ----- Method: SystemWindow>>isLookingFocused: (in category 'focus') ----- > + isLookingFocused: aBoolean > + > + isLookingFocused := aBoolean.! > > Item was changed: > ----- Method: SystemWindow>>lookFocused (in category 'focus') ----- > lookFocused > + > + "Optimize performance." > + self isLookingFocused ifTrue: [^ self]. > + self isLookingFocused: true. > + > label ifNotNil: [ label color: Color black ]. > > (self isKeyWindow or: [self class windowTitleActiveOnFirstClick]) > ifTrue: [self undimWindowButtons]. > > self paneColorToUse in: [ : col | > self > setStripeColorsFrom: col ; > adoptPaneColor: col].! > > Item was changed: > ----- Method: SystemWindow>>lookUnfocused (in category 'focus') ----- > lookUnfocused > + > + "Optimize performance." > + self isLookingFocused ifFalse: [^ self]. > + self isLookingFocused: false. > + > label ifNotNil: [ label color: Color darkGray ]. > self dimWindowButtons. > self paneColorToUseWhenNotActive in: [ : col | > self > setStripeColorsFrom: col ; > adoptPaneColor: col ]! > > Item was changed: > ----- Method: SystemWindow>>mouseEnter: (in category 'events') ----- > mouseEnter: anEvent > "Handle a mouseEnter event, meaning the mouse just entered my bounds with no button pressed. The default response is to let my eventHandler, if any, handle it." > super mouseEnter: anEvent. > > + (self isActive and: [Preferences mouseOverForKeyboardFocus]) > + ifTrue: [self lookFocused].! > - self isActive ifTrue: [self lookFocused].! > > Item was changed: > ----- Method: SystemWindow>>mouseLeave: (in category 'events') ----- > mouseLeave: anEvent > "Handle a mouseEnter event, meaning the mouse just entered my bounds with no button pressed. The default response is to let my eventHandler, if any, handle it." > super mouseLeave: anEvent. > > + (model windowActiveOnFirstClick and: [Preferences mouseOverForKeyboardFocus > + or: [anEvent hand keyboardFocus notNil and: [anEvent hand keyboardFocus containingWindow ~= self]]]) > + ifTrue: [self lookUnfocused].! > - model windowActiveOnFirstClick ifTrue: [self lookUnfocused].! > > Item was changed: > ----- Method: SystemWindow>>mouseLeaveDragging: (in category 'events') ----- > mouseLeaveDragging: evt > + "Passivate after drop operations if needed. Unfortunately, we get a leave-dragging event for the system window we want to drag. Watch out for it." > - "Passivate after drop operations if needed." > > + ((model windowActiveOnFirstClick and: [(evt hand submorphs includes: self) not]) > + or: [self isKeyWindow not]) > + ifTrue: [self lookUnfocused]. > + > - model windowActiveOnFirstClick ifTrue: [self lookUnfocused]. > - > (self isKeyWindow not and: [evt hand hasSubmorphs]) ifTrue:[ > self passivateIfNeeded. > evt hand removeMouseListener: self. "no more drop completion possible on submorph" > ].! > > Item was changed: > ----- Method: SystemWindow>>openAsIsIn: (in category 'open/close') ----- > openAsIsIn: aWorld > "This msg and its callees result in the window being activeOnlyOnTop" > aWorld addMorph: self. > self beKeyWindow. > + aWorld startSteppingSubmorphsOf: self.! > - aWorld startSteppingSubmorphsOf: self. > - self activeHand > - releaseKeyboardFocus; > - releaseMouseFocus.! > > Item was changed: > ----- Method: SystemWindow>>openInWorld: (in category 'open/close') ----- > openInWorld: aWorld > "This msg and its callees result in the window being activeOnlyOnTop" > + ^ self anyOpenWindowLikeMe > - [^ self anyOpenWindowLikeMe > ifEmpty: > [ self > bounds: (RealEstateAgent initialFrameFor: self world: aWorld) ; > openAsIsIn: aWorld ] > ifNotEmptyDo: > [ : windows | > windows anyOne > expand ; > beKeyWindow ; > + postAcceptBrowseFor: self ].! > - postAcceptBrowseFor: self ]. > - ] ensure: [ > - self activeHand > - releaseKeyboardFocus; > - releaseMouseFocus. ]! > > Item was changed: > ----- Method: SystemWindow>>openInWorld:extent: (in category 'open/close') ----- > openInWorld: aWorld extent: extent > "This msg and its callees result in the window being activeOnlyOnTop" > + ^ self anyOpenWindowLikeMe > - [^ self anyOpenWindowLikeMe > ifEmpty: > [ self > position: (RealEstateAgent initialFrameFor: self initialExtent: extent world: aWorld) topLeft ; > extent: extent. > self openAsIsIn: aWorld ] > ifNotEmptyDo: > [ : windows | > windows anyOne > expand ; > beKeyWindow ; > + postAcceptBrowseFor: self ].! > - postAcceptBrowseFor: self ]. > - ] ensure: [ > - self activeHand > - releaseKeyboardFocus; > - releaseMouseFocus. ]! > > Item was changed: > ----- Method: SystemWindow>>passivate (in category 'focus') ----- > passivate > "Reconfigure my focus according to preferences." > > self isActive ifFalse: [^ self]. > self isActive: false. > > self isCollapsed ifFalse: [model modelSleep]. > > self submorphsDo: [:each | each lock]. > > + self activeHand keyboardFocus ifNotNil: [:morph | > + morph containingWindow == self > + ifTrue: [self activeHand releaseKeyboardFocus]]. > + > self lookUnfocused.! > > Item was changed: > ----- Method: SystemWindow>>updateFocusLookAtHand (in category 'focus') ----- > updateFocusLookAtHand > "If there is more than one active window, look for the mouse cursor and update the window focus look accordingly. This method is not on the class-side because we need our world and some active hand." > > + (model windowActiveOnFirstClick and: [Preferences mouseOverForKeyboardFocus]) > + ifFalse: [self updateFocusLookForKeyboardFocus] > + ifTrue: [ > + ((self class windowsIn: self world) > + do: [:window | window lookUnfocused]; > + select: [:window | window bounds containsPoint: self activeHand position]) > + ifNotEmpty: [:windowsPointed | windowsPointed first lookFocused "only to foremost window"]].! > - model windowActiveOnFirstClick ifFalse: [^ self]. > - > - ((self class windowsIn: self world) > - do: [:window | window lookUnfocused]; > - select: [:window | window bounds containsPoint: self activeHand position]) > - ifNotEmpty: [:windowsPointed | windowsPointed first lookFocused "only to foremost window"].! > > Item was added: > + ----- Method: SystemWindow>>updateFocusLookForKeyboardFocus (in category 'focus') ----- > + updateFocusLookForKeyboardFocus > + > + | f w | > + (((f := self activeHand keyboardFocus) notNil and: [(w := f containingWindow) notNil]) > + and: [w isActive]) > + ifTrue: [ > + (self class windowsIn: self world) do: [:window | window lookUnfocused]. > + w lookFocused]! > >

2 1

The Trunk: Morphic-mt.1157.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1157.mcz ==================== Summary ==================== Name: Morphic-mt.1157 Author: mt Time: 1 June 2016, 4:45:15.847666 pm UUID: b3500079-b6e7-af43-9e06-7df9250fb1f8 Ancestors: Morphic-mt.1156 Grab the keyboard focus if models request that. Models have to use the respective selectors (get or set) so that the correct widget will grab the keyboard focus. =============== Diff against Morphic-mt.1156 =============== Item was added: + ----- Method: PluggableListMorph>>update:with: (in category 'updating') ----- + update: aSymbol with: arg1 + + (aSymbol == #inputRequested and: [getIndexSelector == arg1 or: [setIndexSelector == arg1]]) + ifTrue: [self activeHand newKeyboardFocus: self]. + + super update: aSymbol with: arg1.! Item was added: + ----- Method: PluggableTextMorph>>setTextSelector (in category 'accessing') ----- + setTextSelector + ^setTextSelector! Item was changed: ----- Method: PluggableTextMorph>>update:with: (in category 'updating') ----- update: aSymbol with: arg1 + aSymbol == #editString ifTrue:[ self editString: arg1. self hasUnacceptedEdits: true. ]. + + (aSymbol == #inputRequested and: [self getTextSelector == arg1 or: [self setTextSelector == arg1]]) + ifTrue: [self activeHand newKeyboardFocus: self]. + ^super update: aSymbol with: arg1!

1 0

The Trunk: ToolBuilder-Morphic-mt.165.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.165.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.165 Author: mt Time: 1 June 2016, 4:43:17.541666 pm UUID: eb5a9bb7-d38f-c84d-bf97-5643786996e8 Ancestors: ToolBuilder-Morphic-cmm.164 Our list choosers use system windows. Request input for specific data. Use that to update the current keyboard focus. See #update:with: in pluggable list and text morphs. =============== Diff against ToolBuilder-Morphic-cmm.164 =============== Item was changed: ----- Method: ListChooser>>chooseItemFrom:title:addAllowed: (in category 'initialize-release') ----- chooseItemFrom: labelList title: aString addAllowed: aBoolean fullList := labelList asOrderedCollection. "coerce everything into an OC" builder := ToolBuilder default. self list: fullList. self title: aString. addAllowed := aBoolean. window := ToolBuilder default open: self. window center: Sensor cursorPoint. window setConstrainedPosition: (Sensor cursorPoint - (window fullBounds extent // 2)) hangOut: false. + + self changed: #inputRequested with: #searchText. + window lookFocused. "Sigh..." + builder runModal: window. ^ result! Item was changed: ----- Method: ListMultipleChooser>>choose (in category 'actions') ----- choose | builder window | builder := ToolBuilder default. window := builder open: self.. window center: Sensor cursorPoint. "Avoid morphic dependency here..." + + self changed: #inputRequested with: #selectedIndex. + window lookFocused. "Sigh..." + builder runModal: window. ^ self selectedValues!

1 0

The Trunk: Morphic-mt.1156.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1156.mcz ==================== Summary ==================== Name: Morphic-mt.1156 Author: mt Time: 1 June 2016, 4:09:34.015287 pm UUID: 522ade56-9b2e-f749-bb5c-cb117aa97c56 Ancestors: Morphic-topa.1155 If #mouseOverForKeyboardFocus is disabled, do not highlight (a.k.a. "look focused") background windows on mouse-enter, even if they are active due to the preference "Windows' Contents Are Always Active". Note that there is still a bug, which I intend to fix if the event filters make it into the trunk. Namely, if you "debug it" and expression via the context menu, the appearing debugger will not be the top window. An additional click is required. Sorry for this inconvenience. =============== Diff against Morphic-topa.1155 =============== Item was changed: MorphicModel subclass: #SystemWindow + instanceVariableNames: 'labelString stripes label closeBox collapseBox paneMorphs paneRects collapsedFrame fullFrame isCollapsed isActive isLookingFocused menuBox mustNotClose labelWidgetAllowance updatablePanes allowReframeHandles labelArea expandBox' - instanceVariableNames: 'labelString stripes label closeBox collapseBox paneMorphs paneRects collapsedFrame fullFrame isCollapsed isActive menuBox mustNotClose labelWidgetAllowance updatablePanes allowReframeHandles labelArea expandBox' classVariableNames: 'ClickOnLabelToEdit CloseBoxFrame CloseBoxImageFlat CloseBoxImageGradient CollapseBoxImageFlat CollapseBoxImageGradient DoubleClickOnLabelToExpand ExpandBoxFrame ExpandBoxImageFlat ExpandBoxImageGradient FocusFollowsMouse GradientWindow HideExpandButton MenuBoxFrame MenuBoxImageFlat MenuBoxImageGradient ResizeAlongEdges ReuseWindows TopWindow WindowTitleActiveOnFirstClick WindowsRaiseOnClick' poolDictionaries: '' category: 'Morphic-Windows'! !SystemWindow commentStamp: '<historical>' prior: 0! SystemWindow is the Morphic equivalent of StandardSystemView -- a labelled container for rectangular views, with iconic facilities for close, collapse/expand, and resizing. The attribute onlyActiveOnTop, if set to true (and any call to activate will set this), determines that only the top member of a collection of such windows on the screen shall be active. To be not active means that a mouse click in any region will only result in bringing the window to the top and then making it active.! Item was added: + ----- Method: SystemWindow>>activateIfNeeded: (in category 'focus') ----- + activateIfNeeded: evt + "Make me the new key window if needed. Ensure that the focus look matches the keyboard focus." + + (self isKeyWindow not + and: [self class windowsRaiseOnClick + or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) + ifTrue: [self beKeyWindow] + ifFalse: [self updateFocusLookForKeyboardFocus].! Item was changed: ----- Method: SystemWindow>>handleMouseDown: (in category 'events') ----- handleMouseDown: evt - - "If my submorphs handled the events, we still need to use this hook to raise." - (self isKeyWindow not - and: [self class windowsRaiseOnClick - or: [self windowDecorations anySatisfy: [:morph | morph bounds containsPoint: evt position]] ]) - ifTrue: [self beKeyWindow]. + self activateIfNeeded: evt. ^ super handleMouseDown: evt! Item was added: + ----- Method: SystemWindow>>handleMouseUp: (in category 'events') ----- + handleMouseUp: evt + + self activateIfNeeded: evt. + ^ super handleMouseUp: evt! Item was added: + ----- Method: SystemWindow>>isLookingFocused (in category 'focus') ----- + isLookingFocused + + ^ isLookingFocused ifNil: [false]! Item was added: + ----- Method: SystemWindow>>isLookingFocused: (in category 'focus') ----- + isLookingFocused: aBoolean + + isLookingFocused := aBoolean.! Item was changed: ----- Method: SystemWindow>>lookFocused (in category 'focus') ----- lookFocused + + "Optimize performance." + self isLookingFocused ifTrue: [^ self]. + self isLookingFocused: true. + label ifNotNil: [ label color: Color black ]. (self isKeyWindow or: [self class windowTitleActiveOnFirstClick]) ifTrue: [self undimWindowButtons]. self paneColorToUse in: [ : col | self setStripeColorsFrom: col ; adoptPaneColor: col].! Item was changed: ----- Method: SystemWindow>>lookUnfocused (in category 'focus') ----- lookUnfocused + + "Optimize performance." + self isLookingFocused ifFalse: [^ self]. + self isLookingFocused: false. + label ifNotNil: [ label color: Color darkGray ]. self dimWindowButtons. self paneColorToUseWhenNotActive in: [ : col | self setStripeColorsFrom: col ; adoptPaneColor: col ]! Item was changed: ----- Method: SystemWindow>>mouseEnter: (in category 'events') ----- mouseEnter: anEvent "Handle a mouseEnter event, meaning the mouse just entered my bounds with no button pressed. The default response is to let my eventHandler, if any, handle it." super mouseEnter: anEvent. + (self isActive and: [Preferences mouseOverForKeyboardFocus]) + ifTrue: [self lookFocused].! - self isActive ifTrue: [self lookFocused].! Item was changed: ----- Method: SystemWindow>>mouseLeave: (in category 'events') ----- mouseLeave: anEvent "Handle a mouseEnter event, meaning the mouse just entered my bounds with no button pressed. The default response is to let my eventHandler, if any, handle it." super mouseLeave: anEvent. + (model windowActiveOnFirstClick and: [Preferences mouseOverForKeyboardFocus + or: [anEvent hand keyboardFocus notNil and: [anEvent hand keyboardFocus containingWindow ~= self]]]) + ifTrue: [self lookUnfocused].! - model windowActiveOnFirstClick ifTrue: [self lookUnfocused].! Item was changed: ----- Method: SystemWindow>>mouseLeaveDragging: (in category 'events') ----- mouseLeaveDragging: evt + "Passivate after drop operations if needed. Unfortunately, we get a leave-dragging event for the system window we want to drag. Watch out for it." - "Passivate after drop operations if needed." + ((model windowActiveOnFirstClick and: [(evt hand submorphs includes: self) not]) + or: [self isKeyWindow not]) + ifTrue: [self lookUnfocused]. + - model windowActiveOnFirstClick ifTrue: [self lookUnfocused]. - (self isKeyWindow not and: [evt hand hasSubmorphs]) ifTrue:[ self passivateIfNeeded. evt hand removeMouseListener: self. "no more drop completion possible on submorph" ].! Item was changed: ----- Method: SystemWindow>>openAsIsIn: (in category 'open/close') ----- openAsIsIn: aWorld "This msg and its callees result in the window being activeOnlyOnTop" aWorld addMorph: self. self beKeyWindow. + aWorld startSteppingSubmorphsOf: self.! - aWorld startSteppingSubmorphsOf: self. - self activeHand - releaseKeyboardFocus; - releaseMouseFocus.! Item was changed: ----- Method: SystemWindow>>openInWorld: (in category 'open/close') ----- openInWorld: aWorld "This msg and its callees result in the window being activeOnlyOnTop" + ^ self anyOpenWindowLikeMe - [^ self anyOpenWindowLikeMe ifEmpty: [ self bounds: (RealEstateAgent initialFrameFor: self world: aWorld) ; openAsIsIn: aWorld ] ifNotEmptyDo: [ : windows | windows anyOne expand ; beKeyWindow ; + postAcceptBrowseFor: self ].! - postAcceptBrowseFor: self ]. - ] ensure: [ - self activeHand - releaseKeyboardFocus; - releaseMouseFocus. ]! Item was changed: ----- Method: SystemWindow>>openInWorld:extent: (in category 'open/close') ----- openInWorld: aWorld extent: extent "This msg and its callees result in the window being activeOnlyOnTop" + ^ self anyOpenWindowLikeMe - [^ self anyOpenWindowLikeMe ifEmpty: [ self position: (RealEstateAgent initialFrameFor: self initialExtent: extent world: aWorld) topLeft ; extent: extent. self openAsIsIn: aWorld ] ifNotEmptyDo: [ : windows | windows anyOne expand ; beKeyWindow ; + postAcceptBrowseFor: self ].! - postAcceptBrowseFor: self ]. - ] ensure: [ - self activeHand - releaseKeyboardFocus; - releaseMouseFocus. ]! Item was changed: ----- Method: SystemWindow>>passivate (in category 'focus') ----- passivate "Reconfigure my focus according to preferences." self isActive ifFalse: [^ self]. self isActive: false. self isCollapsed ifFalse: [model modelSleep]. self submorphsDo: [:each | each lock]. + self activeHand keyboardFocus ifNotNil: [:morph | + morph containingWindow == self + ifTrue: [self activeHand releaseKeyboardFocus]]. + self lookUnfocused.! Item was changed: ----- Method: SystemWindow>>updateFocusLookAtHand (in category 'focus') ----- updateFocusLookAtHand "If there is more than one active window, look for the mouse cursor and update the window focus look accordingly. This method is not on the class-side because we need our world and some active hand." + (model windowActiveOnFirstClick and: [Preferences mouseOverForKeyboardFocus]) + ifFalse: [self updateFocusLookForKeyboardFocus] + ifTrue: [ + ((self class windowsIn: self world) + do: [:window | window lookUnfocused]; + select: [:window | window bounds containsPoint: self activeHand position]) + ifNotEmpty: [:windowsPointed | windowsPointed first lookFocused "only to foremost window"]].! - model windowActiveOnFirstClick ifFalse: [^ self]. - - ((self class windowsIn: self world) - do: [:window | window lookUnfocused]; - select: [:window | window bounds containsPoint: self activeHand position]) - ifNotEmpty: [:windowsPointed | windowsPointed first lookFocused "only to foremost window"].! Item was added: + ----- Method: SystemWindow>>updateFocusLookForKeyboardFocus (in category 'focus') ----- + updateFocusLookForKeyboardFocus + + | f w | + (((f := self activeHand keyboardFocus) notNil and: [(w := f containingWindow) notNil]) + and: [w isActive]) + ifTrue: [ + (self class windowsIn: self world) do: [:window | window lookUnfocused]. + w lookFocused]!

1 0

Re: [squeak-dev] How do I debug the debugger?
by Jakob Reschke 01 Jun '16

01 Jun '16

You could start by putting a breakpoint in Debugger class>>morphicOpenOn:context:label:contents:fullView: or ToolBuilder>>openDebugger:label: Also save your image before you start your debugging attempt. The last time I tried to debug the Debugger, stepping out of the original context or, in general, pressing the wrong button at the wrong time gave me countless more debuggers or froze the image. However, if you only navigate through the ToolBuilder code, you might be better off. 2016-05-31 22:28 GMT+02:00 gettimothy <gettimothy(a)zoho.com>: > Hi all. > > I am trying to track down this bug: > > https://timmydosmalltalk.wordpress.com/2016/05/29/linux-64x64-squeak-cog-sp… > > > I need to debug how that debugger window gets built. > > ideas? > > thx > > >

4 4

The Trunk: TrueType-topa.42.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Tobias Pape uploaded a new version of TrueType to project The Trunk: http://source.squeak.org/trunk/TrueType-topa.42.mcz ==================== Summary ==================== Name: TrueType-topa.42 Author: topa Time: 1 June 2016, 12:11:05.54556 pm UUID: d19fb495-4371-456b-8551-ab05a789f105 Ancestors: TrueType-topa.41 All fonts should know whether they have a glyph. For the way TT fonts currently work, this information is tricky to get, tho. =============== Diff against TrueType-topa.41 =============== Item was added: + ----- Method: TTCFont>>basicHasGlyphOf: (in category 'private') ----- + basicHasGlyphOf: aCharacter + "Answer whether this font includes a glyph for the given character" + ^ aCharacter charCode <= self maxAscii + and:[ + aCharacter = Character null + ifTrue: [(self formOf: aCharacter) notNil] + ifFalse: [ + "this should also be + (self formOf: aCharacter) notNil + but it does not work, the fallback glyph -- if present -- is always found instead. + So we fake. if aCharacter is the same form as Character null aka 0, we assume absence." + (self characterFormAt: aCharacter) bits ~= self fallbackForm bits]]! Item was changed: ----- Method: TTCFont>>hasGlyphOf: (in category 'private') ----- hasGlyphOf: aCharacter + "Answer whether this font includes a glyph for the given character (or a fallback)" + self flag: #topa. "formOf: never actually returns nil for ttcfonts..." - "Answer whether this font includes a glyph for the given character" ^ aCharacter charCode <= self maxAscii and:[(self formOf: aCharacter) notNil]! Item was added: + ----- Method: TTCFontSet>>basicHasGlyphOf: (in category 'private') ----- + basicHasGlyphOf: aCharacter + "see TTCFont>>hasGlyphOf:" + ^ fontArray first basicHasGlyphOf: aCharacter! Item was added: + ----- Method: TTCFontSet>>hasGlyphOf: (in category 'private') ----- + hasGlyphOf: aCharacter + "see TTCFont>>hasGlyphOf:" + ^ fontArray first hasGlyphOf: aCharacter!

1 0

The Trunk: Multilingual-topa.213.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Tobias Pape uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-topa.213.mcz ==================== Summary ==================== Name: Multilingual-topa.213 Author: topa Time: 1 June 2016, 12:09:52.450255 pm UUID: 3b6d0aef-b027-4adc-8442-10f00e2eaeb2 Ancestors: Multilingual-pre.212 All fonts should know whether they have a glyph. =============== Diff against Multilingual-pre.212 =============== Item was added: + ----- Method: StrikeFontSet>>basicHasGlyphOf: (in category 'private') ----- + basicHasGlyphOf: aCharacter + + | actualFont | + actualFont := self fontOf: aCharacter ifAbsent: [^ false]. + ^ actualFont basicHasGlyphOf: aCharacter!

1 0

The Trunk: Morphic-topa.1155.mcz
by commits＠source.squeak.org 01 Jun '16

01 Jun '16

Tobias Pape uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-topa.1155.mcz ==================== Summary ==================== Name: Morphic-topa.1155 Author: topa Time: 1 June 2016, 12:07:52.187561 pm UUID: 7b8792c9-7a3f-4c43-85a7-18d40734b624 Ancestors: Morphic-mt.1154 Let the fonts provide their sample =============== Diff against Morphic-mt.1154 =============== Item was changed: ----- Method: FontChooserTool>>contents (in category 'toolbuilder') ----- contents + + ^ self selectedFont + ifNil: [Text new] + ifNotNil: [:font | font sampleText]! - | sample i c f | - sample := WriteStream on: ''. - f := self selectedFont ifNil:[^Text new]. - f isSymbolFont ifFalse:[ - sample - nextPutAll: 'the quick brown fox jumps over the lazy dog' ;cr; - nextPutAll: 'THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG.' ;cr;cr; - nextPutAll: '0123456789'; cr; cr; - nextPutAll: - 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, - sed do eiusmod tempor incididunt ut labore et dolore - magna aliqua. Ut enim ad minim veniam, quis nostrud - exercitation ullamco laboris nisi ut aliquip ex ea commodo - consequat. Duis aute irure dolor in reprehenderit in voluptate - velit esse cillum dolore eu fugiat nulla pariatur. Excepteur - sint occaecat cupidatat non proident, sunt in culpa qui - officia deserunt mollit anim id est laborum.' - ] ifTrue:[ - i := 0. - 33 to: 255 do:[:ci | - sample nextPut: (c:=Character value: ci). - i := i + 1. - (('@Z`z' includes:c) or:[i = 30]) - ifTrue:[i :=0. sample cr]]. - ]. - sample := sample contents asText. - sample addAttribute: (TextFontReference toFont: f). - ^sample! Item was changed: ----- Method: FontImporterTool>>previewText (in category 'model access') ----- previewText + + ^ self selectedFont + ifNil: [Text new] + ifNotNil: [:font | font sampleText]! - | sample i c f | - sample := WriteStream on: ''. - f := self selectedFont ifNil:[^Text new]. - (f isSymbolFont or: [(self font: f hasGlyphOf: $a) not]) ifFalse:[ - sample - nextPutAll: 'the quick brown fox jumps over the lazy dog' ;cr; - nextPutAll: 'THE QUICK BROWN FOX JUMPS OVER THE LAZY DOG.' ;cr;cr; - nextPutAll: '0123456789'; cr; cr; - nextPutAll: - 'Lorem ipsum dolor sit amet, consectetur adipisicing elit, - sed do eiusmod tempor incididunt ut labore et dolore - magna aliqua. Ut enim ad minim veniam, quis nostrud - exercitation ullamco laboris nisi ut aliquip ex ea commodo - consequat. Duis aute irure dolor in reprehenderit in voluptate - velit esse cillum dolore eu fugiat nulla pariatur. Excepteur - sint occaecat cupidatat non proident, sunt in culpa qui - officia deserunt mollit anim id est laborum.' - ] ifTrue:[ - i := 0. - 33 to: 255 do:[:ci | - sample nextPut: (c:=Character value: ci). - i := i + 1. - (('@Z`z' includes:c) or:[i = 30]) - ifTrue:[i :=0. sample cr]]. - ]. - sample := sample contents asText. - sample addAttribute: (TextFontReference toFont: f). - ^sample!

1 0

Jump to page: