Squeak-dev August 2016

squeak-dev@lists.squeakfoundation.org

38 participants
609 discussions

The Trunk: Morphic-pre.1229.mcz
by commits＠source.squeak.org 04 Aug '16

04 Aug '16

Patrick Rein uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-pre.1229.mcz ==================== Summary ==================== Name: Morphic-pre.1229 Author: pre Time: 4 August 2016, 12:40:48.215407 pm UUID: 4d9cc4e1-e64b-f946-8a54-1e329d9e4d5a Ancestors: Morphic-mt.1228 Fixes the handling of block provided answers to send out the message instead of the window title and to deal with a request for the default value. =============== Diff against Morphic-mt.1228 =============== Item was changed: ----- Method: DialogWindow>>getUserResponse (in category 'running') ----- getUserResponse | hand world | + (ProvideAnswerNotification signal: self message asString) + ifNotNil: [:answer| + ^ answer = #default + ifTrue: [result] + ifFalse: [answer]]. - (ProvideAnswerNotification signal: self title asString) ifNotNil: [:answer| ^ answer]. self message ifEmpty: [messageMorph delete]. "Do not waste space." self paneMorph submorphs ifEmpty: [self paneMorph delete]. "Do not waste space." hand := self currentHand. world := self currentWorld. self fullBounds. self center: preferredPosition. self bounds: (self bounds translatedToBeWithin: world bounds). self openInWorld: world. hand keyboardFocus in: [:priorKeyboardFocus | hand mouseFocus in: [:priorMouseFocus | self exclusive ifTrue: [hand newMouseFocus: self]. hand newKeyboardFocus: self. [self isInWorld] whileTrue:[world doOneSubCycle]. hand newKeyboardFocus: priorKeyboardFocus. self exclusive ifTrue: [ hand newMouseFocus: priorMouseFocus]]]. ^ result!

1 0

The Trunk: MorphicExtras-eem.179.mcz
by commits＠source.squeak.org 04 Aug '16

04 Aug '16

Eliot Miranda uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-eem.179.mcz ==================== Summary ==================== Name: MorphicExtras-eem.179 Author: eem Time: 3 August 2016, 7:42:04.74973 pm UUID: 7e0dd147-e862-4ad7-9218-8de41bb8b81b Ancestors: MorphicExtras-tfel.178 Use allInsyancesDo: instead of someInstance/nextInstance to remove grab commands from MorphExtensions. P.S. to improve start-up time we might consider moving these to snapshot time, if at all possible. =============== Diff against MorphicExtras-tfel.178 =============== Item was removed: - ----- Method: CommandHistory class>>forgetAllGrabCommandsFrom: (in category 'system startup') ----- - forgetAllGrabCommandsFrom: starterInstance - "Forget all the commands that might be held on to in the properties dicitonary of various morphs for various reasons." - - | object | - object := starterInstance. - [ - [nil == object] whileFalse: [ - object removeProperty: #undoGrabCommand. - object := object nextInstance]. - ] ifError: [:err :rcvr | "object is obsolete" - self forgetAllGrabCommandsFrom: object nextInstance]. - - "CommandHistory forgetAllGrabCommandsFrom: MorphExtension someInstance" - ! Item was changed: ----- Method: CommandHistory class>>resetAllHistory (in category 'system startup') ----- resetAllHistory "Reset all command histories, and make all morphs that might be holding on to undo-grab-commands forget them" self allInstancesDo: [:c | c resetCommandHistory]. MorphExtension withAllSubclassesDo: + [:morphExtensionClass| + morphExtensionClass allInstancesDo: + [:object| object removeProperty: #undoGrabCommand]] - [:mexc| - self forgetAllGrabCommandsFrom: mexc someInstance] "CommandHistory resetAllHistory" !

1 0

Daily Commit Log
by commits＠source.squeak.org 03 Aug '16

03 Aug '16

Changes to Trunk (http://source.squeak.org/trunk.html) in the last 24 hours: http://lists.squeakfoundation.org/pipermail/packages/2016-August/068410.html Name: Morphic-mt.1225 Ancestors: Morphic-mt.1224 Fixes scratch-pad to be compatible with UI themes. This is not the optimal solution but it works for now. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068411.html Name: HelpSystem-Core-mt.88 Ancestors: HelpSystem-Core-mt.87 For prospective content authors in our help system, avoid changing protected texts by accident. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068412.html Name: Help-Squeak-Project-mt.37 Ancestors: Help-Squeak-Project-mt.36 Protect help texts that are fixed or derived from other strings in the system from editing (and duplicating). ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068413.html Name: Morphic-mt.1226 Ancestors: Morphic-mt.1225 Fixes retractable scroll bars, which did not work properly of mouseOverForKeyboardFocus was disabled. Note that #hasFocus is ancient and not needed anymore for controlling keyboard focus here. See also #hIsScrollbarNeeded and #vIsScrollbarNeeded and maybe other senders of #hasFocus. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068414.html Name: Morphic-mt.1227 Ancestors: Morphic-mt.1226 Fixes a small regression where the text cursor did not show up on a simple mouse down when it was invisible due to its blinking animation. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068415.html Name: ToolBuilder-Morphic-mt.178 Ancestors: ToolBuilder-Morphic-mt.177 For disabled buttons, still draw a border to make them still look like buttons, not like labels. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068416.html Name: Morphic-mt.1228 Ancestors: Morphic-mt.1227 Some last-minute UI theming fix, which applies to the non-flat look (i.e. using gradients) in progress bars. Implementation is not perfect but consistent with LazyListMorph selections, now. Note that, in the future, we should untangle the use of #gradientMenu and, maybe, add specific preferences. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068417.html Name: System-mt.861 Ancestors: System-cmm.860 Provide progress indication when applying a new UI theme. Use 1000-ms updates to not slow-down the process unnecessarily. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068418.html Name: System-mt.862 Ancestors: System-mt.861 Implements Karl's suggestions for the colors in Monokai and Solarized themes for progress bars. Also improve the non-shadow scenario. ============================================= http://lists.squeakfoundation.org/pipermail/packages/2016-August/068419.html Name: Monticello-mt.643 Ancestors: Monticello-mt.642 Fixes the merge button in MC's merge browser. =============================================

1 0

Re: [squeak-dev] The Trunk: Morphic-mt.1228.mcz
by karl ramberg 03 Aug '16

03 Aug '16

The gradientMenu stuff is pretty bad. Best, Karl On Wed, Aug 3, 2016 at 3:28 PM, <commits(a)source.squeak.org> wrote: > Marcel Taeumel uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-mt.1228.mcz > > ==================== Summary ==================== > > Name: Morphic-mt.1228 > Author: mt > Time: 3 August 2016, 3:28:25.722418 pm > UUID: 24a39e09-443b-0b41-8d8d-3bd49125fe20 > Ancestors: Morphic-mt.1227 > > Some last-minute UI theming fix, which applies to the non-flat look (i.e. > using gradients) in progress bars. Implementation is not perfect but > consistent with LazyListMorph selections, now. > > Note that, in the future, we should untangle the use of #gradientMenu and, > maybe, add specific preferences. > > =============== Diff against Morphic-mt.1227 =============== > > Item was added: > + ----- Method: SystemProgressBarMorph>>barColor (in category 'accessing') > ----- > + barColor > + > + ^ barColor! > > Item was added: > + ----- Method: SystemProgressBarMorph>>barColor: (in category > 'accessing') ----- > + barColor: aColor > + > + | cc fill | > + cc := aColor. > + > + MenuMorph gradientMenu > + ifFalse: [fill := SolidFillStyle color: cc] > + ifTrue: [ > + fill := GradientFillStyle ramp: { > + 0.0 -> cc twiceLighter. > + 1 -> cc twiceDarker }]. > + > + barColor := fill. > + self changed.! > > Item was added: > + ----- Method: SystemProgressBarMorph>>barSize (in category 'accessing') > ----- > + barSize > + > + ^ barSize! > > Item was changed: > ----- Method: SystemProgressBarMorph>>drawOn: (in category 'drawing') > ----- > drawOn: aCanvas > + > + | area fill | > - | area | > super drawOn: aCanvas. > > + self barSize > 0 ifTrue: [ > - barSize > 0 ifTrue: [ > area := self innerBounds. > + area := area origin extent: (self barSize min: area extent > x)@area extent y. > + > + fill := self barColor isColor > + ifTrue: [SolidFillStyle color: self barColor] > + ifFalse: [self barColor]. > + fill isGradientFill ifTrue: [ > + fill origin: area origin. > + fill direction: 0@ area height]. > + > + aCanvas > + fillRectangle: area > + fillStyle: fill > + borderStyle: (SimpleBorder new width: 1; color: > fill asColor muchDarker). > - area := area origin extent: (barSize min: area extent > x)@area extent y. > - aCanvas fillRectangle: area color: barColor > ]. > ! > > Item was changed: > ----- Method: SystemProgressBarMorph>>setDefaultParameters (in category > 'initialization') ----- > setDefaultParameters > "change the receiver's appareance parameters" > > self > color: (self userInterfaceTheme color ifNil: [Color r: > 0.977 g: 0.977 b: 0.977]); > borderStyle: (self userInterfaceTheme borderStyle ifNil: > [BorderStyle default]); > borderColor: (self userInterfaceTheme borderColor ifNil: > [Color transparent]); > + borderWidth: (self userInterfaceTheme borderWidth ifNil: > [0]); > + barColor: (self userInterfaceTheme barColor ifNil: [Color > r: 0.72 g: 0.72 b: 0.9]).! > - borderWidth: (self userInterfaceTheme borderWidth ifNil: > [0]). > - > - barColor := self userInterfaceTheme barColor ifNil: [Color r: 0.72 > g: 0.72 b: 0.9].! > > >

2 2

The Trunk: Monticello-mt.643.mcz
by commits＠source.squeak.org 03 Aug '16

03 Aug '16

Marcel Taeumel uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.643.mcz ==================== Summary ==================== Name: Monticello-mt.643 Author: mt Time: 3 August 2016, 5:12:29.133179 pm UUID: 75d22f47-6cf5-5d44-9416-dd46377863ec Ancestors: Monticello-mt.642 Fixes the merge button in MC's merge browser. =============== Diff against Monticello-mt.642 =============== Item was changed: ----- Method: MCMergeBrowser>>chooseAllNewerConflicts (in category 'as yet unclassified') ----- chooseAllNewerConflicts conflicts do: [ :ea | ea chooseNewer ]. + self changed: #text; changed: #list; changed: #canMerge.! - self changed: #text; changed: #list.! Item was changed: ----- Method: MCMergeBrowser>>chooseAllOlderConflicts (in category 'as yet unclassified') ----- chooseAllOlderConflicts conflicts do: [ :ea | ea chooseOlder ]. + self changed: #text; changed: #list; changed: #canMerge.! - self changed: #text; changed: #list.! Item was changed: ----- Method: MCMergeBrowser>>chooseAllSameAST (in category 'as yet unclassified') ----- chooseAllSameAST conflicts do: [ :ea | ea chooseSameAST ]. + self changed: #text; changed: #list; changed: #canMerge.! - self changed: #text; changed: #list.! Item was changed: ----- Method: MCMergeBrowser>>chooseAllUnchosenLocal (in category 'as yet unclassified') ----- chooseAllUnchosenLocal conflicts do: [ :ea | ea isResolved ifFalse: [ ea chooseLocal ] ]. + self changed: #text; changed: #list; changed: #canMerge.! - self changed: #text; changed: #list.! Item was changed: ----- Method: MCMergeBrowser>>chooseAllUnchosenRemote (in category 'as yet unclassified') ----- chooseAllUnchosenRemote conflicts do: [ :ea | ea isResolved ifFalse: [ ea chooseRemote ] ]. + self changed: #text; changed: #list; changed: #canMerge.! - self changed: #text; changed: #list.! Item was changed: ----- Method: MCMergeBrowser>>chooseLocal (in category 'as yet unclassified') ----- chooseLocal self conflictSelectionDo: [selection chooseLocal. + self changed: #text; changed: #list; changed: #canMerge]. - self changed: #text; changed: #list]. self selectNextUnresolvedConflict! Item was changed: ----- Method: MCMergeBrowser>>chooseRemote (in category 'as yet unclassified') ----- chooseRemote self conflictSelectionDo: [selection chooseRemote. + self changed: #text; changed: #list; changed: #canMerge]. - self changed: #text; changed: #list]. self selectNextUnresolvedConflict! Item was changed: ----- Method: MCMergeBrowser>>clearChoice (in category 'as yet unclassified') ----- clearChoice self conflictSelectionDo: [selection clearChoice. + self changed: #text; changed: #list; changed: #canMerge]! - self changed: #text; changed: #list]!

1 0

Re: [squeak-dev] The Inbox: Network-ul.180.mcz
by Levente Uzonyi 03 Aug '16

03 Aug '16

Hi All, This is something to test on all platforms before push. I've used it on 64-bit linux without problems so far. Levente On Mon, 25 Jul 2016, commits(a)source.squeak.org wrote: > Levente Uzonyi uploaded a new version of Network to project The Inbox: > http://source.squeak.org/inbox/Network-ul.180.mcz > > ==================== Summary ==================== > > Name: Network-ul.180 > Author: ul > Time: 25 July 2016, 8:40:01.001452 pm > UUID: 2f23a55c-fec5-41ac-95bd-6a8c2458be95 > Ancestors: Network-nice.179 > > Socket changes: > - fixed the comment of #isOtherEndConnected and #isThisEndConnected > - do not slice the data (TCP) in the image in #sendData:. Let the VM, the kernel, the hardware deal with that. > - use #isOtherEndConnected when receiving data, and #isThisEndConnected when sending data instead of #isConnected > - move away from #milliseconds:since:, since we have a clock that won't roll over > > =============== Diff against Network-nice.179 =============== > > Item was changed: > ----- Method: Socket>>closeAndDestroy: (in category 'connection open/close') ----- > closeAndDestroy: timeoutSeconds > "First, try to close this connection gracefully. If the close attempt fails or times out, abort the connection. In either case, destroy the socket. Do nothing if the socket has already been destroyed (i.e., if its socketHandle is nil)." > > + socketHandle ifNil: [ ^self ]. > + self isThisEndConnected ifTrue: [ > + self close. "Close this end." ]. > + (self waitForDisconnectionFor: timeoutSeconds) ifFalse: [ > + "The other end has not closed the connect yet, so we will just abort it." > + self primSocketAbortConnection: socketHandle ]. > + self destroy! > - socketHandle ifNotNil: [ > - self isConnected ifTrue: [ > - self close. "close this end" > - (self waitForDisconnectionFor: timeoutSeconds) ifFalse: [ > - "The other end didn't close so we just abort the connection" > - self primSocketAbortConnection: socketHandle]]. > - self destroy]. > - ! > > Item was changed: > ----- Method: Socket>>discardReceivedData (in category 'receiving') ----- > discardReceivedData > "Discard any data received up until now, and return the number of bytes discarded." > > | buf totalBytesDiscarded | > buf := String new: 10000. > totalBytesDiscarded := 0. > + [self isOtherEndConnected and: [self dataAvailable]] whileTrue: [ > - [self isConnected and: [self dataAvailable]] whileTrue: [ > totalBytesDiscarded := > totalBytesDiscarded + (self receiveDataInto: buf)]. > ^ totalBytesDiscarded > ! > > Item was changed: > ----- Method: Socket>>isOtherEndConnected (in category 'queries') ----- > isOtherEndConnected > + "Return true if this socket is connected, or this end has closed the connection but not the other end, so we can still receive data." > - "Return true if this socket is connected, or this end has closed the connection but not the other end, so we can still send data." > > | state | > socketHandle ifNil: [ ^false ]. > (state := self primSocketConnectionStatus: socketHandle) == Connected ifTrue: [ ^true ]. > ^state == ThisEndClosed > ! > > Item was changed: > ----- Method: Socket>>isThisEndConnected (in category 'queries') ----- > isThisEndConnected > + "Return true if this socket is connected, other the other end has closed the connection but not this end, so we can still send data." > - "Return true if this socket is connected, other the other end has closed the connection but not this end, so we can still receive data." > > | state | > socketHandle ifNil: [ ^false ]. > (state := self primSocketConnectionStatus: socketHandle) == Connected ifTrue: [ ^true ]. > ^state == OtherEndClosed > ! > > Item was changed: > ----- Method: Socket>>sendData: (in category 'sending') ----- > sendData: aStringOrByteArray > "Send all of the data in the given array, even if it requires multiple calls to send it all. Return the number of bytes sent." > > "An experimental version use on slow lines: Longer timeout and smaller writes to try to avoid spurious timeouts." > > | bytesSent bytesToSend count | > bytesToSend := aStringOrByteArray size. > bytesSent := 0. > [bytesSent < bytesToSend] whileTrue: [ > (self waitForSendDoneFor: 60) > ifFalse: [ConnectionTimedOut signal: 'send data timeout; data not sent']. > count := self primSocket: socketHandle > sendData: aStringOrByteArray > startIndex: bytesSent + 1 > + count: bytesToSend - bytesSent. > - count: (bytesToSend - bytesSent min: DefaultSendBufferSize). > bytesSent := bytesSent + count]. > > ^ bytesSent > ! > > Item was changed: > ----- Method: Socket>>waitForConnectionFor:ifTimedOut:ifRefused: (in category 'waiting') ----- > waitForConnectionFor: timeout ifTimedOut: timeoutBlock ifRefused: refusedBlock > "Wait up until the given deadline for a connection to be established. Return true if it is established by the deadline, false if not." > > + | deadline timeLeft status | > + deadline := Time millisecondClockValue + (timeout * 1000) truncated. > + (status := self primSocketConnectionStatus: socketHandle) == Connected ifTrue: [^true]. > + [ (status == WaitingForConnection) and: [ (timeLeft := deadline - Time millisecondClockValue) > 0 ] ] > - | startTime msecsDelta msecsEllapsed status | > - startTime := Time millisecondClockValue. > - msecsDelta := (timeout * 1000) truncated. > - status := self primSocketConnectionStatus: socketHandle. > - status = Connected ifTrue: [^true]. > - [(status = WaitingForConnection) and: [(msecsEllapsed := Time millisecondsSince: startTime) < msecsDelta]] > whileTrue: [ > + semaphore waitTimeoutMSecs: timeLeft. > + status := self primSocketConnectionStatus: socketHandle ]. > + status == Connected ifTrue: [ ^true ]. > + status == WaitingForConnection > + ifTrue: [ timeoutBlock value ] > + ifFalse: [ refusedBlock value ]. > + ^false! > - semaphore waitTimeoutMSecs: msecsDelta - msecsEllapsed. > - status := self primSocketConnectionStatus: socketHandle]. > - status = Connected > - ifFalse: [ > - status = WaitingForConnection > - ifTrue: [timeoutBlock value] > - ifFalse: [refusedBlock value]. > - ^false]. > - ^ true! > > Item was changed: > ----- Method: Socket>>waitForConnectionUntil: (in category 'waiting') ----- > waitForConnectionUntil: deadline > "Wait up until the given deadline for a connection to be established. Return true if it is established by the deadline, false if not." > > + | status timeLeft | > - | status waitTime | > [ > (status := self primSocketConnectionStatus: socketHandle) == Connected ifTrue: [ ^true ]. > status == WaitingForConnection ifFalse: [ ^false ]. > + (timeLeft := deadline - Time millisecondClockValue) <= 0 ifTrue: [ ^false ]. > + semaphore waitTimeoutMSecs: timeLeft ] repeat! > - (waitTime := deadline - Time millisecondClockValue) > 0 ifFalse: [ ^false ]. > - semaphore waitTimeoutMSecs: waitTime ] repeat! > > Item was changed: > ----- Method: Socket>>waitForDataFor:ifClosed:ifTimedOut: (in category 'waiting') ----- > waitForDataFor: timeout ifClosed: closedBlock ifTimedOut: timedOutBlock > "Wait for the given nr of seconds for data to arrive." > > + | deadline timeLeft | > - | startTime msecsDelta | > socketHandle ifNil: [ ^closedBlock value ]. > + deadline := Time millisecondClockValue + (timeout * 1000) truncated. > - startTime := Time millisecondClockValue. > - msecsDelta := (timeout * 1000) truncated. > [ > (self primSocketReceiveDataAvailable: socketHandle) ifTrue: [ ^self ]. > + self isOtherEndConnected ifFalse: [ ^closedBlock value ]. > + (timeLeft := deadline - Time millisecondClockValue) <= 0 ifTrue: [ ^timedOutBlock value ]. > - self isConnected ifFalse: [ ^closedBlock value ]. > - (Time millisecondsSince: startTime) < msecsDelta ifFalse: [ ^timedOutBlock value ]. > "Providing a maximum for the time for waiting is a workaround for a VM bug which causes sockets waiting for data forever in some rare cases, because the semaphore doesn't get signaled. Remove the ""min: self class maximumReadSemaphoreWaitTimeout"" part when the bug is fixed." > readSemaphore waitTimeoutMSecs: > + (timeLeft min: self class maximumReadSemaphoreWaitTimeout) ] repeat! > - (msecsDelta - (Time millisecondsSince: startTime) min: self class maximumReadSemaphoreWaitTimeout) ] repeat! > > Item was changed: > ----- Method: Socket>>waitForDataIfClosed: (in category 'waiting') ----- > waitForDataIfClosed: closedBlock > "Wait indefinitely for data to arrive. This method will block until > data is available or the socket is closed." > > socketHandle ifNil: [ ^closedBlock value ]. > [ > (self primSocketReceiveDataAvailable: socketHandle) ifTrue: [ ^self ]. > + self isOtherEndConnected ifFalse: [ ^closedBlock value ]. > - self isConnected ifFalse: [ ^closedBlock value ]. > "ul 8/13/2014 21:16 > Providing a maximum for the time for waiting is a workaround for a VM bug which > causes sockets waiting for data forever in some rare cases, because the semaphore > doesn't get signaled. Replace the ""waitTimeoutMSecs: self class maximumReadSemaphoreWaitTimeout"" > part with ""wait"" when the bug is fixed." > readSemaphore waitTimeoutMSecs: self class maximumReadSemaphoreWaitTimeout ] repeat! > > Item was changed: > ----- Method: Socket>>waitForDisconnectionFor: (in category 'waiting') ----- > waitForDisconnectionFor: timeout > "Wait for the given nr of seconds for the connection to be broken. > Return true if it is broken by the deadline, false if not. > The client should know the connection is really going to be closed > (e.g., because he has called 'close' to send a close request to the other end) > before calling this method." > > + | deadline | > + deadline := Time millisecondClockValue + (timeout * 1000) truncated. > + [ self isOtherEndConnected and: [ deadline - Time millisecondClockValue > 0 ] ] > + whileTrue: [ > + self discardReceivedData. > + "Providing a maximum for the time for waiting is a workaround for a VM bug which causes sockets waiting for data forever in some rare cases, because the semaphore doesn't get signaled. Remove the ""min: self class maximumReadSemaphoreWaitTimeout"" part when the bug is fixed." > + readSemaphore waitTimeoutMSecs: > + (deadline - Time millisecondClockValue min: self class maximumReadSemaphoreWaitTimeout) ]. > + ^self isOtherEndConnected! > - | startTime msecsDelta status | > - startTime := Time millisecondClockValue. > - msecsDelta := (timeout * 1000) truncated. > - status := self primSocketConnectionStatus: socketHandle. > - [((status == Connected) or: [(status == ThisEndClosed)]) and: > - [(Time millisecondsSince: startTime) < msecsDelta]] whileTrue: [ > - self discardReceivedData. > - "Providing a maximum for the time for waiting is a workaround for a VM bug which causes sockets waiting for data forever in some rare cases, because the semaphore doesn't get signaled. Remove the ""min: self class maximumReadSemaphoreWaitTimeout"" part when the bug is fixed." > - readSemaphore waitTimeoutMSecs: > - (msecsDelta - (Time millisecondsSince: startTime) min: self class maximumReadSemaphoreWaitTimeout). > - status := self primSocketConnectionStatus: socketHandle]. > - ^ status ~= Connected! > > Item was changed: > ----- Method: Socket>>waitForSendDoneFor: (in category 'waiting') ----- > waitForSendDoneFor: timeout > "Wait up until the given deadline for the current send operation to complete. Return true if it completes by the deadline, false if not." > > + | deadline timeleft | > + deadline := Time millisecondClockValue + (timeout * 1000) truncated. > - | startTime msecsDelta msecsEllapsed | > - startTime := Time millisecondClockValue. > - msecsDelta := (timeout * 1000) truncated. > [ > (self primSocketSendDone: socketHandle) ifTrue: [ ^true ]. > + self isThisEndConnected ifFalse: [ ^false ]. > + (timeleft := deadline - Time millisecondClockValue) <= 0 ifTrue: [ ^false ]. > + writeSemaphore waitTimeoutMSecs: timeleft ] repeat! > - self isConnected ifFalse: [ ^false ]. > - (msecsEllapsed := Time millisecondsSince: startTime) < msecsDelta ifFalse: [ ^false ]. > - writeSemaphore waitTimeoutMSecs: msecsDelta - msecsEllapsed ] repeat! > > >

2 4

The Trunk: System-mt.862.mcz
by commits＠source.squeak.org 03 Aug '16

03 Aug '16

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.862.mcz ==================== Summary ==================== Name: System-mt.862 Author: mt Time: 3 August 2016, 5:02:47.934179 pm UUID: d0377fca-6807-b948-b464-e74122834e6f Ancestors: System-mt.861 Implements Karl's suggestions for the colors in Monokai and Solarized themes for progress bars. Also improve the non-shadow scenario. =============== Diff against System-mt.861 =============== Item was changed: ----- Method: MonokaiTheme class>>addDarkDialogs: (in category 'instance creation') ----- addDarkDialogs: theme "self createDark apply." theme set: #borderColor for: #DialogWindow to: self backgroundColor muchDarker; set: #color for: #DialogWindow to: self invisibleColor; set: #titleColor for: #DialogWindow to: self backgroundColor; set: #titleTextColor for: #DialogWindow to: self foregroundColor; set: #textColor for: #DialogWindow to: self yellow; set: #okColor for: #DialogWindow to: self green muchDarker; set: #cancelColor for: #DialogWindow to: self orange muchDarker; set: #buttonColor for: #DialogWindow to: self invisibleColor; set: #selectionModifier for: #DialogWindow to: [ [:c | c adjustBrightness: -0.1 ] ]. "The List Chooser is a dialog, too." theme set: #addColor for: #ListChooser to: self blue; set: #disabledColor for: #ListChooser to: Color transparent. "And the system progress bar." theme + set: #color for: #SystemProgressBarMorph to: self invisibleColor; - set: #color for: #SystemProgressBarMorph to: Color transparent; set: #barColor for: #SystemProgressBarMorph to: self foregroundColor. "And the balloon morphs." theme set: #borderColor for: #NewBalloonMorph to: self backgroundColor muchDarker; set: #color for: #NewBalloonMorph to: self invisibleColor.! Item was changed: ----- Method: MonokaiTheme class>>addDarkMenusAndDockingBars: (in category 'instance creation') ----- addDarkMenusAndDockingBars: theme "self createDark apply." theme + set: #borderWidth for: #MenuMorph to: 1; + set: #borderColor for: #MenuMorph to: self invisibleColor; - set: #borderWidth for: #MenuMorph to: 0; set: #color for: #MenuMorph to: self backgroundColor; set: #titleTextColor for: #MenuMorph to: self yellow; set: #lineColor for: #MenuMorph to: self invisibleColor; set: #lineStyle for: #MenuMorph to: BorderStyle default; set: #lineWidth for: #MenuMorph to: 1. theme set: #textColor for: #MenuItemMorph to: self foregroundColor; set: #selectionColor for: #MenuItemMorph to: self invisibleColor; set: #selectionTextColor for: #MenuItemMorph to: self yellow. "set: #subMenuMarker for: #MenuItemMorph to: nil." "Use hard-coded default. See MenuItemMorph." "The world main docking bar." theme set: #color for: #DockingBarMorph to: self invisibleColor; set: #selectionColor for: #DockingBarItemMorph to: self grayLight; set: #logoColor for: #TheWorldMainDockingBar to: self foregroundColor; set: #selectionLogoColor for: #TheWorldMainDockingBar to: self yellow.! Item was changed: ----- Method: SolarizedTheme class>>addDarkDialogs: (in category 'instance creation') ----- addDarkDialogs: theme "self createDark apply." theme set: #borderColor for: #DialogWindow to: self darkBackground muchDarker; set: #color for: #DialogWindow to: self darkBackgroundHighlights; set: #titleColor for: #DialogWindow to: self darkBackground; set: #titleTextColor for: #DialogWindow to: self darkContentEmphasized; set: #textColor for: #DialogWindow to: self darkContentEmphasizedMore; set: #okColor for: #DialogWindow to: self green; set: #cancelColor for: #DialogWindow to: self orange; set: #buttonColor for: #DialogWindow to: self darkBackgroundHighlights; set: #selectionModifier for: #DialogWindow to: [ [:c | c adjustBrightness: -0.1 ] ]. "The List Chooser is a dialog, too." theme set: #addColor for: #ListChooser to: self blue; set: #disabledColor for: #ListChooser to: Color transparent. "And the system progress bar." theme + set: #color for: #SystemProgressBarMorph to: self darkBackgroundHighlights; + set: #barColor for: #SystemProgressBarMorph to: self darkContentSecondary. - set: #color for: #SystemProgressBarMorph to: Color transparent; - set: #barColor for: #SystemProgressBarMorph to: self darkContentEmphasized. "And the balloon morphs." theme set: #borderColor for: #NewBalloonMorph to: self darkBackground muchDarker; set: #color for: #NewBalloonMorph to: self darkBackgroundHighlights.! Item was changed: ----- Method: SolarizedTheme class>>addDarkMenusAndDockingBars: (in category 'instance creation') ----- addDarkMenusAndDockingBars: theme "self createDark apply." theme + set: #borderWidth for: #MenuMorph to: 1; + set: #borderColor for: #MenuMorph to: self darkBackgroundHighlights; - set: #borderWidth for: #MenuMorph to: 0; set: #color for: #MenuMorph to: self darkBackground; set: #titleTextColor for: #MenuMorph to: self darkContentEmphasizedMore; set: #lineColor for: #MenuMorph to: self darkBackgroundHighlights; set: #lineStyle for: #MenuMorph to: BorderStyle default; set: #lineWidth for: #MenuMorph to: 1. theme set: #textColor for: #MenuItemMorph to: self darkContentEmphasized; set: #selectionColor for: #MenuItemMorph to: self darkBackgroundHighlights; set: #selectionTextColor for: #MenuItemMorph to: self darkContentEmphasizedMore. "set: #subMenuMarker for: #MenuItemMorph to: nil." "Use hard-coded default. See MenuItemMorph." "The world main docking bar." theme set: #color for: #DockingBarMorph to: self darkBackgroundHighlights; set: #selectionColor for: #DockingBarItemMorph to: self darkContentSecondary; set: #logoColor for: #TheWorldMainDockingBar to: self darkContentEmphasized; set: #selectionLogoColor for: #TheWorldMainDockingBar to: self darkContentEmphasizedMore.! Item was changed: ----- Method: SolarizedTheme class>>addLightDialogs: (in category 'instance creation') ----- addLightDialogs: theme "self createLight apply." theme set: #borderColor for: #DialogWindow to: self lightBackground muchDarker; set: #color for: #DialogWindow to: self lightBackgroundHighlights; set: #titleColor for: #DialogWindow to: self lightBackground; set: #titleTextColor for: #DialogWindow to: self lightContentEmphasized; set: #textColor for: #DialogWindow to: self lightContentEmphasizedMore; set: #okColor for: #DialogWindow to: self green; set: #cancelColor for: #DialogWindow to: self orange; set: #buttonColor for: #DialogWindow to: self lightBackgroundHighlights; set: #selectionModifier for: #DialogWindow to: [ [:c | c adjustBrightness: -0.1 ] ]. "The List Chooser is a dialog, too." theme set: #addColor for: #ListChooser to: self blue; set: #disabledColor for: #ListChooser to: Color transparent. "And the system progress bar." theme + set: #color for: #SystemProgressBarMorph to: self lightBackgroundHighlights; + set: #barColor for: #SystemProgressBarMorph to: self lightContentSecondary. - set: #color for: #SystemProgressBarMorph to: Color transparent; - set: #barColor for: #SystemProgressBarMorph to: self lightContentEmphasized. "And the balloon morphs." theme set: #borderColor for: #NewBalloonMorph to: self lightBackground muchDarker; set: #color for: #NewBalloonMorph to: self lightBackgroundHighlights.! Item was changed: ----- Method: SolarizedTheme class>>addLightMenusAndDockingBars: (in category 'instance creation') ----- addLightMenusAndDockingBars: theme "self createLight apply." theme + set: #borderWidth for: #MenuMorph to: 1; + set: #borderColor for: #MenuMorph to: self lightBackgroundHighlights; - set: #borderWidth for: #MenuMorph to: 0; set: #color for: #MenuMorph to: self lightBackground; set: #titleTextColor for: #MenuMorph to: self lightContentEmphasizedMore; set: #lineColor for: #MenuMorph to: self lightBackgroundHighlights; set: #lineStyle for: #MenuMorph to: BorderStyle default; set: #lineWidth for: #MenuMorph to: 1. theme set: #textColor for: #MenuItemMorph to: self lightContentEmphasized; set: #selectionColor for: #MenuItemMorph to: self lightBackgroundHighlights; set: #selectionTextColor for: #MenuItemMorph to: self lightContentEmphasizedMore. "set: #subMenuMarker for: #MenuItemMorph to: nil." "Use hard-coded default. See MenuItemMorph." "The world main docking bar." theme set: #color for: #DockingBarMorph to: self lightBackgroundHighlights; set: #selectionColor for: #DockingBarItemMorph to: self lightContentSecondary; set: #logoColor for: #TheWorldMainDockingBar to: self lightContentEmphasized; set: #selectionLogoColor for: #TheWorldMainDockingBar to: self lightContentEmphasizedMore.!

1 0

A couple Monokai theme issues
by karl ramberg 03 Aug '16

03 Aug '16

The sub menu indicator arrow is black and menu color is very dark gray so it is hard to see. Selection color is used as progress bar indication color. And same color is used as color for progress bar morph. Best, Karl

2 1

The Trunk: System-mt.861.mcz
by commits＠source.squeak.org 03 Aug '16

03 Aug '16

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.861.mcz ==================== Summary ==================== Name: System-mt.861 Author: mt Time: 3 August 2016, 3:48:48.221245 pm UUID: 74e725aa-ea12-df48-b3cf-730dba8dccc6 Ancestors: System-cmm.860 Provide progress indication when applying a new UI theme. Use 1000-ms updates to not slow-down the process unnecessarily. =============== Diff against System-cmm.860 =============== Item was changed: ----- Method: UserInterfaceTheme>>apply (in category 'actions') ----- apply "Apply this theme to all affected objects. Let classes decide on how to iterate and call their instances." UserInterfaceTheme current: self. self class clientClassesToReapply in: [:cc | cc do: [:eachClass | eachClass applyUserInterfaceTheme]. + (cc select: [:eachClass | eachClass canApplyThemeToInstances]) + do: [:eachClass | eachClass applyThemeToInstances] + displayingProgress: [:eachClass | 'Applying {1} to instances of {2}' format: {self name. eachClass name}] + every: 1000 ]. - cc - select: [:eachClass | eachClass canApplyThemeToInstances] - thenDo: [:eachClass | eachClass applyThemeToInstances]]. Project current restoreDisplay.!

1 0

The Trunk: Morphic-mt.1228.mcz
by commits＠source.squeak.org 03 Aug '16

03 Aug '16

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1228.mcz ==================== Summary ==================== Name: Morphic-mt.1228 Author: mt Time: 3 August 2016, 3:28:25.722418 pm UUID: 24a39e09-443b-0b41-8d8d-3bd49125fe20 Ancestors: Morphic-mt.1227 Some last-minute UI theming fix, which applies to the non-flat look (i.e. using gradients) in progress bars. Implementation is not perfect but consistent with LazyListMorph selections, now. Note that, in the future, we should untangle the use of #gradientMenu and, maybe, add specific preferences. =============== Diff against Morphic-mt.1227 =============== Item was added: + ----- Method: SystemProgressBarMorph>>barColor (in category 'accessing') ----- + barColor + + ^ barColor! Item was added: + ----- Method: SystemProgressBarMorph>>barColor: (in category 'accessing') ----- + barColor: aColor + + | cc fill | + cc := aColor. + + MenuMorph gradientMenu + ifFalse: [fill := SolidFillStyle color: cc] + ifTrue: [ + fill := GradientFillStyle ramp: { + 0.0 -> cc twiceLighter. + 1 -> cc twiceDarker }]. + + barColor := fill. + self changed.! Item was added: + ----- Method: SystemProgressBarMorph>>barSize (in category 'accessing') ----- + barSize + + ^ barSize! Item was changed: ----- Method: SystemProgressBarMorph>>drawOn: (in category 'drawing') ----- drawOn: aCanvas + + | area fill | - | area | super drawOn: aCanvas. + self barSize > 0 ifTrue: [ - barSize > 0 ifTrue: [ area := self innerBounds. + area := area origin extent: (self barSize min: area extent x)@area extent y. + + fill := self barColor isColor + ifTrue: [SolidFillStyle color: self barColor] + ifFalse: [self barColor]. + fill isGradientFill ifTrue: [ + fill origin: area origin. + fill direction: 0@ area height]. + + aCanvas + fillRectangle: area + fillStyle: fill + borderStyle: (SimpleBorder new width: 1; color: fill asColor muchDarker). - area := area origin extent: (barSize min: area extent x)@area extent y. - aCanvas fillRectangle: area color: barColor ]. ! Item was changed: ----- Method: SystemProgressBarMorph>>setDefaultParameters (in category 'initialization') ----- setDefaultParameters "change the receiver's appareance parameters" self color: (self userInterfaceTheme color ifNil: [Color r: 0.977 g: 0.977 b: 0.977]); borderStyle: (self userInterfaceTheme borderStyle ifNil: [BorderStyle default]); borderColor: (self userInterfaceTheme borderColor ifNil: [Color transparent]); + borderWidth: (self userInterfaceTheme borderWidth ifNil: [0]); + barColor: (self userInterfaceTheme barColor ifNil: [Color r: 0.72 g: 0.72 b: 0.9]).! - borderWidth: (self userInterfaceTheme borderWidth ifNil: [0]). - - barColor := self userInterfaceTheme barColor ifNil: [Color r: 0.72 g: 0.72 b: 0.9].!

1 0

← Newer
1
...
54
55
56
57
58
59
60
61
Older →

Jump to page: