Squeak-dev January 2017

squeak-dev@lists.squeakfoundation.org

34 participants
77 discussions

The Inbox: Multilingual-jr.218.mcz
by commits＠source.squeak.org 23 Jan '17

23 Jan '17

A new version of Multilingual was added to project The Inbox: http://source.squeak.org/inbox/Multilingual-jr.218.mcz ==================== Summary ==================== Name: Multilingual-jr.218 Author: jr Time: 19 January 2017, 5:14:23.763655 pm UUID: 36416c42-a4b4-554f-8203-aba25eee794f Ancestors: Multilingual-tfel.217 support 'iso-8859-1' and do not let UTF8TextConverter expect that its input stream returns Characters from basicNext A stream implementation might always return bytes from basicNext and expect the conversion to Character to be done solely by the TextConverter, so use asInteger instead of asciiValue to support both cases. Convert back with asCharacter. =============== Diff against Multilingual-tfel.217 =============== Item was changed: ----- Method: Latin1TextConverter class>>encodingNames (in category 'utilities') ----- encodingNames + ^ #('latin-1' 'latin1' 'iso-8859-1') copy. - ^ #('latin-1' 'latin1') copy. ! Item was changed: ----- Method: UTF8TextConverter>>nextFromStream: (in category 'conversion') ----- nextFromStream: aStream | char1 value1 char2 value2 unicode char3 value3 char4 value4 | aStream isBinary ifTrue: [^ aStream basicNext]. char1 := aStream basicNext. char1 ifNil:[^ nil]. + value1 := char1 asInteger. - value1 := char1 asciiValue. value1 <= 127 ifTrue: [ "1-byte char" + ^ char1 asCharacter - ^ char1 ]. "at least 2-byte char" char2 := aStream basicNext. + char2 ifNil:[^self errorMalformedInput: (String with: char1 asCharacter)]. + value2 := char2 asInteger. - char2 ifNil:[^self errorMalformedInput: (String with: char1)]. - value2 := char2 asciiValue. (value1 bitAnd: 16rE0) = 192 ifTrue: [ ^ Unicode value: ((value1 bitAnd: 31) bitShift: 6) + (value2 bitAnd: 63). ]. "at least 3-byte char" char3 := aStream basicNext. + char3 ifNil:[^self errorMalformedInput: (String with: char1 asCharacter with: char2 asCharacter)]. + value3 := char3 asInteger. - char3 ifNil:[^self errorMalformedInput: (String with: char1 with: char2)]. - value3 := char3 asciiValue. (value1 bitAnd: 16rF0) = 224 ifTrue: [ unicode := ((value1 bitAnd: 15) bitShift: 12) + ((value2 bitAnd: 63) bitShift: 6) + (value3 bitAnd: 63). ]. (value1 bitAnd: 16rF8) = 240 ifTrue: [ "4-byte char" char4 := aStream basicNext. + char4 ifNil:[^self errorMalformedInput: (String with: char1 asCharacter with: char2 asCharacter with: char3 asCharacter)]. + value4 := char4 asInteger. - char4 ifNil:[^self errorMalformedInput: (String with: char1 with: char2 with: char3)]. - value4 := char4 asciiValue. unicode := ((value1 bitAnd: 16r7) bitShift: 18) + ((value2 bitAnd: 63) bitShift: 12) + ((value3 bitAnd: 63) bitShift: 6) + (value4 bitAnd: 63). ]. + unicode ifNil:[^self errorMalformedInput: (String with: char1 asCharacter with: char2 asCharacter with: char3 asCharacter)]. - unicode ifNil:[^self errorMalformedInput: (String with: char1 with: char2 with: char3)]. unicode > 16r10FFFD ifTrue: [ + ^self errorMalformedInput: (String with: char1 asCharacter with: char2 asCharacter with: char3 asCharacter). - ^self errorMalformedInput: (String with: char1 with: char2 with: char3). ]. unicode = 16rFEFF ifTrue: [^ self nextFromStream: aStream]. ^ Unicode value: unicode. !

4 8

The Trunk: Morphic-mdlh.1319.mcz
by commits＠source.squeak.org 23 Jan '17

23 Jan '17

Patrick Rein uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mdlh.1319.mcz ==================== Summary ==================== Name: Morphic-mdlh.1319 Author: mdlh Time: 23 January 2017, 5:10:01.812757 pm UUID: 32f7ff94-54f4-6641-a426-88ea9ca86a4e Ancestors: Morphic-tfel.1318 corrected typo in description text of preference visualWrapBorder =============== Diff against Morphic-tfel.1318 =============== Item was changed: ----- Method: PluggableTextMorph class>>visualWrapBorder (in category 'preferences') ----- visualWrapBorder <preference: 'Show wrap border in code panes.' categoryList: #(editing visuals performance) + description: 'Show a visual border after a specific amount of characters. Makes sense for monospaced fonts.' - description: 'Show a visual border after a specific amout of characters. Makes sense for monospaced fonts.' type: #Boolean> ^ VisualWrapBorder ifNil: [false]!

1 0

The Trunk: System-tfel.924.mcz
by commits＠source.squeak.org 23 Jan '17

23 Jan '17

Tim Felgentreff uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-tfel.924.mcz ==================== Summary ==================== Name: System-tfel.924 Author: tfel Time: 23 January 2017, 9:31:46.987369 am UUID: bd501831-ebe7-de41-8860-123b9fafdbc3 Ancestors: System-tfel.923 Update the hack around scaling in UserInterfaceTheme, so the label areas of Windows is resized correctly. =============== Diff against System-tfel.923 =============== Item was changed: ----- Method: UserInterfaceTheme>>fixFontsAndScaleAround: (in category 'private') ----- fixFontsAndScaleAround: block "Due to the current situation with fonts and the real-estate manager, this is a small workaround to support theme switching with largely different font sizes." lastScaleFactor ifNil: [lastScaleFactor := RealEstateAgent scaleFactor]. "Due to the current font situation, update TextConstants." [ ignoreApply := true. (self get: #standardSystemFont) ifNotNil: [:font | Preferences setSystemFontTo: font]. (self get: #standardFixedFont) ifNotNil: [:font | Preferences setFixedFontTo: font]. ] ensure: [ignoreApply := false]. "Apply theme etc." block value. + - "Due to the current real-estate manager situation, resize all windows. Works only for Morphic projects." + (RealEstateAgent scaleFactor - lastScaleFactor) abs > 0.1 ifTrue: [ - (RealEstateAgent scaleFactor - lastScaleFactor) abs > 0.5 ifTrue: [ Project current isMorphic ifTrue: [ | scale | scale := RealEstateAgent scaleFactor / lastScaleFactor. Project current world submorphs select: [:ea | ea isSystemWindow] + thenDo: [:ea | + ea extent: (ea extent * scale). + ea layoutChanged. + ea setFramesForLabelArea]]]. + - thenDo: [:ea | ea extent: (ea extent * scale)]]]. - lastScaleFactor := nil.!

1 0

The Trunk: Morphic-tfel.1318.mcz
by commits＠source.squeak.org 23 Jan '17

23 Jan '17

Tim Felgentreff uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-tfel.1318.mcz ==================== Summary ==================== Name: Morphic-tfel.1318 Author: tfel Time: 23 January 2017, 9:29:29.465369 am UUID: 0a89c742-2294-8146-9196-afa7557a1cc4 Ancestors: Morphic-tfel.1317 - put font resizing on command key, so it works across platforms - when we update the label area of a system window, also update the boxes =============== Diff against Morphic-tfel.1317 =============== Item was changed: ----- Method: PasteUpMorph>>filterEvent:for: (in category 'events-processing') ----- filterEvent: aKeyboardEvent for: anObject "Provide keyboard shortcuts." "Delegate keyboard shortcuts to my docking bars." self submorphsDo: [:ea | ea isDockingBar ifTrue: [ ea filterEvent: aKeyboardEvent for: anObject. "No support for converting events here!!" aKeyboardEvent wasIgnored ifTrue: [^ aKeyboardEvent "early out"]]]. aKeyboardEvent isKeystroke ifFalse: [^ aKeyboardEvent]. + - aKeyboardEvent commandKeyPressed ifTrue: [ aKeyboardEvent keyCharacter caseOf: { [$R] -> [Utilities browseRecentSubmissions]. [$L] -> [self findAFileList: aKeyboardEvent]. [$O] -> [self findAMonticelloBrowser]. [$P] -> [self findAPreferencesPanel: aKeyboardEvent]. "[$Z] -> [ChangeList browseRecentLog]." [$]] -> [Smalltalk snapshot: true andQuit: false]. - } otherwise: [^ aKeyboardEvent "no hit"]. - ^ aKeyboardEvent ignore "hit!!"]. - aKeyboardEvent controlKeyPressed ifTrue: [ - aKeyboardEvent keyCharacter caseOf: { [$+] -> [Preferences increaseFontSize]. [$-] -> [Preferences decreaseFontSize]. [$=] -> [Preferences restoreDefaultFonts]. } otherwise: [^ aKeyboardEvent "no hit"]. ^ aKeyboardEvent ignore "hit!!"]. + ^ aKeyboardEvent "no hit"! Item was changed: ----- Method: SystemWindow>>setFramesForLabelArea (in category 'initialization') ----- setFramesForLabelArea "an aid to converting old instances, but then I found convertAlignment (jesse welton's note)" | frame | labelArea ifNil: [^ self]. labelArea layoutPolicy: TableLayout new; listDirection: #leftToRight; hResizing: #spaceFill; layoutInset: 0. label hResizing: #spaceFill. + {closeBox. menuBox. expandBox. collapseBox} do: [:box | + box ifNotNil: [box extent: self boxExtent]]. + frame := LayoutFrame new. + frame leftFraction: 0; + topFraction: 0; + rightFraction: 1; + bottomFraction: 0; + topOffset: self labelHeight negated. + labelArea layoutFrame: frame! - labelArea - ifNotNil: [frame := LayoutFrame new. - frame leftFraction: 0; - topFraction: 0; - rightFraction: 1; - bottomFraction: 0; - topOffset: self labelHeight negated. - labelArea layoutFrame: frame]!

1 0

Smallapack issue, may be FFI?
by Yoshiki Ohshima 22 Jan '17

22 Jan '17

Hello Nico and all, I came back to trying to use Smallapack, and found an interesting problem of getting different results. Let us say the following code: ------------- random := Random new. i := 40. data := (1 to: i) collect: [:j | FloatArray new: i]. 1 to: i do: [:y | 1 to: i do: [:x | (data at: y) at: x put: random next * 10.0.]]. a := LapackSGEMatrix rows: data. ------------- This creates a 40x40 matrix with some numbers in it; it uses Random here but the values in 'a' are fixed below. Then evaluate: ------------- ((1 to: 100) collect: [:i | a reciprocal]) asSet size ------------- To compute reciprocal of the same 'a' 100 times. So I expect the value from the 'asSet size' to be one, as it should always compute the same value. However, I get variations in the result. some times the result is 4, sometimes 2, etc. When the size of matrix is 100x100 or such, the number of variations become even bigger. This happens on the recent VMs and the latest lapack. I don't have a good guess where the error could be? As far as I can tell, the algorithm Lapack is deterministic. As it happens when the matrix is large, I could suspect that some boundary is crossed ExternalArray creation or such. I am also curious if this is reproducible on other environments. This happens on Mac OS. The dylabs I use are coypied from the system directory. -- Yoshiki

1 0

Re: [squeak-dev] The Inbox: Tests-jr.362.mcz
by Jakob Reschke 22 Jan '17

22 Jan '17

It is clearly debatable whether keeping the imported binding (last line) is the correct solution. After all the statement was #unbind: ... 2017-01-22 2:18 GMT+01:00 commits(a)source.squeak.org <commits(a)source.squeak.org>: > A new version of Tests was added to project The Inbox: > http://source.squeak.org/inbox/Tests-jr.362.mcz > > ==================== Summary ==================== > > Name: Tests-jr.362 > Author: jr > Time: 22 January 2017, 2:18:34.010832 am > UUID: 67cd6b66-44de-774a-bfea-625e0c50d00a > Ancestors: Tests-jr.361 > > add another test for Environments-jr.69 > > This time about not altering other environments when unbinding a symbol. > > =============== Diff against Tests-jr.361 =============== > > Item was added: > + ----- Method: EnvironmentTest>>testUnbindDoesNotAlterImportedBindings (in category 'observation tests') ----- > + testUnbindDoesNotAlterImportedBindings > + "When attempting to unbind a symbol, do not alter bindings outside of the envrionments' > + own declarations." > + > + | foreign foreignBinding one two | > + foreign := Environment withName: #Foreign. > + foreign exportSelf. > + foreign bind: #Griffle to: value. > + foreignBinding := foreign associationAt: #Griffle. > + env at: #Griffle put: Object new. > + env importSelf. > + env import: foreign. > + one := env bindingOf: #Griffle. > + self assert: one == foreignBinding description: 'imported binding'. > + > + env unbind: #Griffle. > + two := env bindingOf: #Griffle. > + self assert: value equals: foreignBinding value description: 'imported value unaffacted'. > + self assert: two == foreignBinding description: 'imported binding still in place'.! > >

1 0

Environments: imported bindings overwriting each other
by Jakob Reschke 22 Jan '17

22 Jan '17

Hi all, I stumbled on something with Environment imports and would like to hear other opinions about the issue. Currently, environments do not care all that much about other environments declaring the same name. If an environment T imports from environments A, B, C, the binding of #x in T will be replaced with the binding of #x that was added last in any of the environments A, B, C, or T. Example: env1 := Environment new. env2 := Environment new. env1 exportSelf. env2 importSelf. env2 import: env1. env2 bind: #Griffle to: 2. env2 bindingOf: #Griffle. "#Griffle=>2" env1 bind: #Griffle to: 1. env2 bindingOf: #Griffle. "#Griffle=>1" Note that the imported environment hides the local binding of env2. If the environments already come with bindings at "import time", the import order matters: env1 := Environment new. env2 := Environment new. target := Environment new. env1 exportSelf. env2 exportSelf. env1 bind: #Griffle to: 1. env2 bind: #Griffle to: 2. target import: env1; import: env2. target bindingOf: #Griffle. "#Griffle=>2" "...but when done the other way around (start over up to the imports)..." target import: env2; import: env1. target bindingOf: #Griffle. "#Griffle=>1" Now the funniest part: Let's assume target imported env1 last, so the binding comes from env1 and is #Griffle=>1. Guess what happens when env2 unbinds its #Griffle: env2 unbind: #Griffle. target bindingOf: #Griffle. "nil" So an environment can unbind something in another environment that was actually imported from a third environment. I consider this a bug and have a fix proposal for it, which I plan to put into the inbox soon. This behavior can have a really nasty consequence, which you can read up in the PS at the bottom if you like. Another peculiarity is that #importSelf does not overwrite existing bindings (if you imported something else before), but #import: and friends happily do overwrite bindings from self. What do you think about that reckless overwriting of bindings in general? I would like at least the "own" bindings (declarations) of an environment to have precedence over imported bindings. So you do not surprisingly lose your class binding when another class with the same name enters the original Smalltalk environment or is removed from it: env := Environment withName: #Demo. env importSelf; import: Smalltalk globals. classfactory := ClassFactoryForTestCase new. [class := classfactory newClass] on: CurrentEnvironment do: [:e | e resume: env]. (env valueOf: class name) environment. "Demo" "put the CurrentEnvironment handling around the following instead to test the removing case" Object subclass: class name instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'CategoryForTestToBeDeleted-Default'. (env valueOf: class name) environment. "Smalltalk" (Smalltalk at: class name) removeFromSystem. env bindingOf: class name. "nil" classfactory cleanUp. Kind regards, Jakob PS. Here the nasty story about the "bug" from above: It "literally destroys Smalltalk" when you attempt to #destroy a named environment (created with Environment withName: or named:) that imports "Smalltalk globals" and imports self. Every named environment has an own #Smalltalk declaration with an own SmalltalkImage instance that answers the named environment itself from "Smalltalk globals". Destroy unbinds all declarations, including this #Smalltalk. Because #importSelf does not overwrite existing bindings, the effective #Smalltalk binding is the one from the original Smalltalk environment, #Smalltalk=>Smalltalk (instead of #Smalltalk=>TheOtherEnvironmentsSmalltalk). Because the environment imports itself, it propagates the unbind: #Smalltalk to itself and eventually, as per the above bug, modifies the #Smalltalk=>Smalltalk binding with a nice becomeForward:. So the whole image has just lost its binding for #Smalltalk, nothing happens anymore, great. The code for the adventurous: env := Environment withName: #Demo. (env at: #Smalltalk) globals. "Demo" env importSelf. (env valueOf: #Smalltalk) globals. "Demo" env import: Smalltalk globals. (env valueOf: #Smalltalk) globals. "Smalltalk" env destroy.

2 1

The Inbox: Tests-jr.362.mcz
by commits＠source.squeak.org 22 Jan '17

22 Jan '17

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-jr.362.mcz ==================== Summary ==================== Name: Tests-jr.362 Author: jr Time: 22 January 2017, 2:18:34.010832 am UUID: 67cd6b66-44de-774a-bfea-625e0c50d00a Ancestors: Tests-jr.361 add another test for Environments-jr.69 This time about not altering other environments when unbinding a symbol. =============== Diff against Tests-jr.361 =============== Item was added: + ----- Method: EnvironmentTest>>testUnbindDoesNotAlterImportedBindings (in category 'observation tests') ----- + testUnbindDoesNotAlterImportedBindings + "When attempting to unbind a symbol, do not alter bindings outside of the envrionments' + own declarations." + + | foreign foreignBinding one two | + foreign := Environment withName: #Foreign. + foreign exportSelf. + foreign bind: #Griffle to: value. + foreignBinding := foreign associationAt: #Griffle. + env at: #Griffle put: Object new. + env importSelf. + env import: foreign. + one := env bindingOf: #Griffle. + self assert: one == foreignBinding description: 'imported binding'. + + env unbind: #Griffle. + two := env bindingOf: #Griffle. + self assert: value equals: foreignBinding value description: 'imported value unaffacted'. + self assert: two == foreignBinding description: 'imported binding still in place'.!

1 0

The Inbox: Tests-jr.361.mcz
by commits＠source.squeak.org 22 Jan '17

22 Jan '17

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-jr.361.mcz ==================== Summary ==================== Name: Tests-jr.361 Author: jr Time: 22 January 2017, 2:03:39.879832 am UUID: 198acafe-d1e1-9847-b530-bac77258f6c4 Ancestors: Tests-pre.360 add a test case for Environments-jr.69 =============== Diff against Tests-pre.360 =============== Item was added: + ----- Method: EnvironmentTest>>testUnbindDoesNotDestroyImportedBindingsFromAnotherEnvironment (in category 'observation tests') ----- + testUnbindDoesNotDestroyImportedBindingsFromAnotherEnvironment + "When a symbol is undeclared, the observing environments should not + lose a binding with the same key if that binding is actually imported from + self or a third environment." + + | foreign foreignBinding one ownValue two three | + foreign := Environment withName: #Foreign. + foreign exportSelf. + foreign bind: #Griffle to: value. + foreignBinding := foreign associationAt: #Griffle. + env importSelf. + env import: foreign. + one := env bindingOf: #Griffle. + self assert: one == foreignBinding description: 'imported binding'. + self assert: one value == value description: 'imported binding'. + + ownValue := Object new. + env bind: #Griffle to: ownValue. + two := env bindingOf: #Griffle. + self assert: one ~~ two description: 'new binding'. + + foreign unbind: #Griffle. + self assert: nil equals: one value description: 'imported binding undeclared'. + three := env bindingOf: #Griffle. + self assert: two == three description: 'own binding unaffected'. + self assert: three value == ownValue description: 'own binding''s value unaffected'.!

1 0

The Inbox: Environments-jr.68.mcz
by commits＠source.squeak.org 22 Jan '17

22 Jan '17

A new version of Environments was added to project The Inbox: http://source.squeak.org/inbox/Environments-jr.68.mcz ==================== Summary ==================== Name: Environments-jr.68 Author: jr Time: 22 January 2017, 1:28:18.011832 am UUID: 41256adf-d98a-4c4f-8bb6-6e5d800a4014 Ancestors: Environments-nice.67 add a convenience method to activate an environment during a block =============== Diff against Environments-nice.67 =============== Item was added: + ----- Method: Environment>>beCurrentDuring: (in category 'as yet unclassified') ----- + beCurrentDuring: aBlock + "Evaluate aBlock with me as the current dynamic Environment" + ^ aBlock on: CurrentEnvironment do: [:e | e resume: self]!

1 0