Squeak-dev December 2017

squeak-dev@lists.squeakfoundation.org

34 participants
159 discussions

The Trunk: System-eem.981.mcz
by commits＠source.squeak.org 12 Dec '17

12 Dec '17

Eliot Miranda uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-eem.981.mcz ==================== Summary ==================== Name: System-eem.981 Author: eem Time: 12 December 2017, 9:35:15.69532 am UUID: 4397750d-0bd0-49ce-8cf5-380642a069a6 Ancestors: System-mt.980 Add PrimitiveOSError that allows external primitives to answer a platform-specific error code with a primtiive error. Needs a VM of at least VMMaker.oscog-eem.2293 to report errors in this way. =============== Diff against System-mt.980 =============== Item was added: + ----- Method: Object>>isPrimitiveOSError (in category '*System-Support-error handling') ----- + isPrimitiveOSError + ^false! Item was added: + ----- Method: Preferences class>>enablePortraitMode (in category 'standard queries') ----- + enablePortraitMode + ^ self + valueOfFlag: #enablePortraitMode + ifAbsent: [false]! Item was added: + ----- Method: Preferences class>>enableVirtualOLPCDisplay (in category 'standard queries') ----- + enableVirtualOLPCDisplay + ^ self + valueOfFlag: #enableVirtualOLPCDisplay + ifAbsent: [false]! Item was changed: + ----- Method: Preferences class>>haloTheme (in category 'standard queries') ----- - ----- Method: Preferences class>>haloTheme (in category 'prefs - halos') ----- haloTheme ^ self valueOfFlag: #haloTheme + ifAbsent: [#iconicHaloSpecifications]! - ifAbsent: [ #iconicHaloSpecifications ]! Item was changed: ----- Method: Preferences class>>showAdvancedNavigatorButtons (in category 'standard queries') ----- showAdvancedNavigatorButtons ^ self valueOfFlag: #showAdvancedNavigatorButtons + ifAbsent: [false]! - ifAbsent: [ true ]! Item was added: + ----- Method: Preferences class>>sugarAutoSave (in category 'standard queries') ----- + sugarAutoSave + ^ self + valueOfFlag: #sugarAutoSave + ifAbsent: [false]! Item was added: + ----- Method: Preferences class>>vmProfilerFillInIntegral (in category 'standard queries') ----- + vmProfilerFillInIntegral + ^ self + valueOfFlag: #vmProfilerFillInIntegral + ifAbsent: [false]! Item was added: + Object subclass: #PrimitiveOSError + instanceVariableNames: 'errorName errorCode' + classVariableNames: '' + poolDictionaries: '' + category: 'System-Support'! + + !PrimitiveOSError commentStamp: 'eem 12/7/2017 19:31' prior: 0! + A PrimitiveOSError is used to answer a primitive failure code that has an associated operating system/library error. + + Instance Variables + errorName: <Symbol> + errorValue: <Integer> + + errorName + - typically #'operating system error' + + errorValue + - the value of the error, a signed 64-bit value, a representation imposed by the VM; specific clients must map this error value into an unsigned value as appropriate if required! Item was added: + ----- Method: PrimitiveOSError>>errorCode (in category 'accessing') ----- + errorCode + + ^errorCode! Item was added: + ----- Method: PrimitiveOSError>>errorCode: (in category 'accessing') ----- + errorCode: anObject + + errorCode := anObject! Item was added: + ----- Method: PrimitiveOSError>>errorName (in category 'accessing') ----- + errorName + + ^errorName! Item was added: + ----- Method: PrimitiveOSError>>errorName: (in category 'accessing') ----- + errorName: anObject + + errorName := anObject! Item was added: + ----- Method: PrimitiveOSError>>isPrimitiveOSError (in category 'testing') ----- + isPrimitiveOSError + ^true! Item was changed: ----- Method: SmalltalkImage>>recreateSpecialObjectsArray (in category 'special objects') ----- recreateSpecialObjectsArray "Smalltalk recreateSpecialObjectsArray" "To external package developers: **** DO NOT OVERRIDE THIS METHOD. ***** If you are writing a plugin and need additional special object(s) for your own use, use addGCRoot() function and use own, separate special objects registry " "The Special Objects Array is an array of objects used by the Squeak virtual machine. Its contents are critical and accesses to it by the VM are unchecked, so don't even think of playing here unless you know what you are doing." | newArray | newArray := Array new: 60. + "Nil false and true get used throughout the VM" - "Nil false and true get used throughout the interpreter" newArray at: 1 put: nil. newArray at: 2 put: false. newArray at: 3 put: true. "This association holds the active process (a ProcessScheduler)" newArray at: 4 put: (self specialObjectsArray at: 4) "(self bindingOf: #Processor) but it answers an Alias". "Numerous classes below used for type checking and instantiation" newArray at: 5 put: Bitmap. newArray at: 6 put: SmallInteger. newArray at: 7 put: ByteString. newArray at: 8 put: Array. newArray at: 9 put: Smalltalk. newArray at: 10 put: BoxedFloat64. newArray at: 11 put: (self globals at: #Context). newArray at: 12 put: nil. "was BlockContext." newArray at: 13 put: Point. newArray at: 14 put: LargePositiveInteger. newArray at: 15 put: Display. newArray at: 16 put: Message. newArray at: 17 put: CompiledMethod. newArray at: 18 put: ((self specialObjectsArray at: 18) ifNil: [Semaphore new]). "low space Semaphore" newArray at: 19 put: Semaphore. newArray at: 20 put: Character. newArray at: 21 put: #doesNotUnderstand:. newArray at: 22 put: #cannotReturn:. newArray at: 23 put: nil. "This is the process signalling low space." "An array of the 32 selectors that are compiled as special bytecodes, paired alternately with the number of arguments each takes." newArray at: 24 put: #( #+ 1 #- 1 #< 1 #> 1 #<= 1 #>= 1 #= 1 #~= 1 #* 1 #/ 1 #\\ 1 #@ 1 #bitShift: 1 #// 1 #bitAnd: 1 #bitOr: 1 #at: 1 #at:put: 2 #size 0 #next 0 #nextPut: 1 #atEnd 0 #== 1 #class 0 #~~ 1 #value 0 #value: 1 #do: 1 #new 0 #new: 1 #x 0 #y 0 ). "An array of the 255 Characters in ascii order. Cog inlines table into machine code at: prim so do not regenerate it. This is nil in Spur, which has immediate Characters." newArray at: 25 put: (self specialObjectsArray at: 25). newArray at: 26 put: #mustBeBoolean. newArray at: 27 put: ByteArray. newArray at: 28 put: Process. "An array of up to 31 classes whose instances will have compact headers; an empty array in Spur" newArray at: 29 put: self compactClassesArray. newArray at: 30 put: ((self specialObjectsArray at: 30) ifNil: [Semaphore new]). "delay Semaphore" newArray at: 31 put: ((self specialObjectsArray at: 31) ifNil: [Semaphore new]). "user interrupt Semaphore" "Entries 32 - 34 unreferenced. Previously these contained prototype instances to be copied for fast initialization" newArray at: 32 put: nil. "was the prototype Float" newArray at: 33 put: nil. "was the prototype 4-byte LargePositiveInteger" newArray at: 34 put: nil. "was the prototype Point" newArray at: 35 put: #cannotInterpret:. newArray at: 36 put: nil. "was the prototype MethodContext" newArray at: 37 put: BlockClosure. newArray at: 38 put: nil. "was the prototype BlockContext" "array of objects referred to by external code" newArray at: 39 put: (self specialObjectsArray at: 39). "external semaphores" newArray at: 40 put: nil. "Reserved for Mutex in Cog VMs" newArray at: 41 put: ((self specialObjectsArray at: 41) ifNil: [LinkedList new]). "Reserved for a LinkedList instance for overlapped calls in CogMT" newArray at: 42 put: ((self specialObjectsArray at: 42) ifNil: [Semaphore new]). "finalization Semaphore" newArray at: 43 put: LargeNegativeInteger. "External objects for callout. Note: Written so that one can actually completely remove the FFI." newArray at: 44 put: (self at: #ExternalAddress ifAbsent: []). newArray at: 45 put: (self at: #ExternalStructure ifAbsent: []). newArray at: 46 put: (self at: #ExternalData ifAbsent: []). newArray at: 47 put: (self at: #ExternalFunction ifAbsent: []). newArray at: 48 put: (self at: #ExternalLibrary ifAbsent: []). newArray at: 49 put: #aboutToReturn:through:. newArray at: 50 put: #run:with:in:. "51 reserved for immutability message" newArray at: 51 put: #attemptToAssign:withIndex:. newArray at: 52 put: #(nil "nil => generic error" #'bad receiver' #'bad argument' #'bad index' #'bad number of arguments' #'inappropriate operation' #'unsupported operation' #'no modification' #'insufficient object memory' #'insufficient C memory' #'not found' #'bad method' #'internal error in named primitive machinery' #'object may move' #'resource limit exceeded' #'object is pinned' #'primitive write beyond end of object' + #'object moved' #'object not pinned' #'callback error'), + {PrimitiveOSError new errorName: #'operating system error'; yourself}. - #'object moved' #'object not pinned' #'callback error'). "53 to 55 are for Alien" newArray at: 53 put: (self at: #Alien ifAbsent: []). newArray at: 54 put: #invokeCallbackContext:. "use invokeCallback:stack:registers:jmpbuf: for old Alien callbacks." newArray at: 55 put: (self at: #UnsafeAlien ifAbsent: []). "Used to be WeakFinalizationList for WeakFinalizationList hasNewFinalization, obsoleted by ephemeron support." newArray at: 56 put: nil. "reserved for foreign callback process" newArray at: 57 put: (self specialObjectsArray at: 57 ifAbsent: []). newArray at: 58 put: #unusedBytecode. "59 reserved for Sista counter tripped message" newArray at: 59 put: #conditionalBranchCounterTrippedOn:. "60 reserved for Sista class trap message" newArray at: 60 put: #classTrapFor:. + "Now replace the virtual machine's reference in one atomic operation" - "Now replace the interpreter's reference in one atomic operation" self specialObjectsArray becomeForward: newArray! Item was changed: + (PackageInfo named: 'System') postscript: '(Smalltalk specialSelectorNames includes: #~~) ifFalse: + ["Re-create the specialObjectsArray to let the jit optimize #~~. Also add the new primitive error codes if they are not there yet." + | senders | + senders := #(#~~ #blockCopy:) gather: [ :selector | + "Recompile senders blockCopy: too, just in case." + SystemNavigation default allCallsOn: selector ]. + Smalltalk recreateSpecialObjectsArray. + VariableNode initialize. + Decompiler initialize. + senders + do: [ :methodReference | + | class | + class := methodReference actualClass. + class recompile: methodReference selector from: class ] + displayingProgress: ''Recompiling...'']. + "If PrimitiveOSError is not in the primitiveErrorTable, add it." + Smalltalk primitiveErrorTable size < 21 ifTrue: + [Smalltalk recreateSpecialObjectsArray]'! - (PackageInfo named: 'System') postscript: '| senders | - "Re-create the specialObjectsArray to let the jit optimize #~~. Also add the new primitive error codes if they are not there yet." - senders := #(#~~ #blockCopy:) gather: [ :selector | - "Recompile senders blockCopy: too, just in case." - SystemNavigation default allCallsOn: selector ]. - Smalltalk recreateSpecialObjectsArray. - VariableNode initialize. - Decompiler initialize. - senders - do: [ :methodReference | - | class | - class := methodReference actualClass. - class recompile: methodReference selector from: class ] - displayingProgress: ''Recompiling...''.'!

1 0

Fwd: [Pharo-users] REST client hints
by Tobias Pape 12 Dec '17

12 Dec '17

FYI, Paul has made a cross-platform wrapper for web api clients :) > Begin forwarded message: > > From: Paul DeBruicker <pdebruic(a)gmail.com> > Subject: Re: [Pharo-users] REST client hints > Date: 5. Dezember 2017 um 19:46:48 MEZ > To: pharo-users(a)lists.pharo.org > Reply-To: Any question about pharo is welcome <pharo-users(a)lists.pharo.org> > > Hi Ben, > > > I've made a few REST Clients > > http://smalltalkhub.com/#!/~pdebruic/Stripe > http://smalltalkhub.com/#!/~pdebruic/Tropo > http://smalltalkhub.com/#!/~pdebruic/SegmentIO > > And the elasticsearch one but its been advanced mostly lately by Sho Yoshida > (https://github.com/newapplesho) here > https://github.com/newapplesho/elasticsearch-smalltalk > > He has also made REST clients for Twilio, AWS, SendGrid, Salesforce, and > Mixpanel among others. > > Norbert Hartl made one for Mandrill (Mailchimps transactional email service) > http://smalltalkhub.com/#!/~NorbertHartl/Mandrill > > And Francois Stephany made one for Postmark (another transactional email > service) http://smalltalkhub.com/#!/~PharoExtras/Postmark > > > So those are some examples of different approaches. > > vvvvvvvvvvvvvvvvvvvvvvvvvvvvv > I also started/made a cross platform web client wrapper (just wraps calls to > ZnClient or WebClient on Squeak) > http://smalltalkhub.com/#!/~pdebruic/HTTPAPIClient > > But IIRC I only used it in the Stripe API client. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Hope this gives you some ideas about how to approach your own solution > > Paul > > > > Ben Coman wrote >> I'm just about to write my first client interface to a REST service. >> In some respects I understand this is as simple as doing GET responses >> using Zinc, >> but I'm inquiring about tutorials or libraries that might help. Most >> of the stuff turned up by searches is about server-side of REST. >> >> cheers -ben > > > > > > -- > Sent from: http://forum.world.st/Pharo-Smalltalk-Users-f1310670.html >

2 1

The Inbox: Protocols-nice.49.mcz
by commits＠source.squeak.org 11 Dec '17

11 Dec '17

A new version of Protocols was added to project The Inbox: http://source.squeak.org/inbox/Protocols-nice.49.mcz ==================== Summary ==================== Name: Protocols-nice.49 Author: nice Time: 11 December 2017, 9:47:58.015 pm UUID: 4d293bcf-9f74-4e4b-93e6-6c5c8d56dea9 Ancestors: Protocols-topa.48 No use to send '-- all --' asSymbol, since it is already interned. You can test this with Symbol findInterned: '-- all --' . '-- all --' asSymbol chasePointers. =============== Diff against Protocols-topa.48 =============== Item was changed: ----- Method: Vocabulary>>allCategoryName (in category 'queries') ----- allCategoryName "Answer the name by which the 'all' category is known. This is redundant with two other things, including ClassOrganizer allCategory, at the moment -- should be cleaned up someday." + ^ #'-- all --'! - ^ '-- all --' asSymbol!

1 0

The Inbox: Sound-nice.44.mcz
by commits＠source.squeak.org 11 Dec '17

11 Dec '17

Nicolas Cellier uploaded a new version of Sound to project The Inbox: http://source.squeak.org/inbox/Sound-nice.44.mcz ==================== Summary ==================== Name: Sound-nice.44 Author: nice Time: 11 December 2017, 9:28:57.599 pm UUID: 815ceacc-8a61-46c9-946d-0d6ea2761f67 Ancestors: Sound-topa.43 Transform 2 repeat loops into whileTrue: loops in ADPCMCodec =============== Diff against Sound-topa.43 =============== Item was changed: ----- Method: ADPCMCodec>>nextBits: (in category 'bit streaming') ----- nextBits: n "Answer the next n bits of my bit stream as an unsigned integer." | result remaining shift | <inline: true> result := 0. remaining := n. [ shift := remaining - bitPosition. + shift > 0 ] + whileTrue: [ "consumed currentByte buffer; fetch next byte" - shift > 0 - ifTrue: [ "consumed currentByte buffer; fetch next byte" result := result + (currentByte << shift). remaining := remaining - bitPosition. currentByte := (encodedBytes at: (byteIndex := byteIndex + 1)). + bitPosition := 8]. + + "update bits left in currentByte buffer" + result := result + (currentByte >> (0 - shift)). + bitPosition := bitPosition - remaining. + "mask out the consumed bits:" + currentByte := currentByte bitAnd: (255 >> (8 - bitPosition)). + ^ result - bitPosition := 8] - ifFalse: [ "still some bits left in currentByte buffer" - result := result + (currentByte >> (0 - shift)). - bitPosition := bitPosition - remaining. - "mask out the consumed bits:" - currentByte := currentByte bitAnd: (255 >> (8 - bitPosition)). - ^ result]] repeat ! Item was changed: ----- Method: ADPCMCodec>>nextBits:put: (in category 'bit streaming') ----- nextBits: n put: anInteger "Write the next n bits to my bit stream." | buf bufBits bitsAvailable shift | <inline: true> buf := anInteger. bufBits := n. [ bitsAvailable := 8 - bitPosition. shift := bitsAvailable - bufBits. "either left or right shift" "append high bits of buf to end of currentByte:" + shift < 0 ] + whileTrue: [ "currentByte buffer filled; output it" - shift < 0 - ifTrue: [ "currentByte buffer filled; output it" currentByte := currentByte + (buf >> (0 - shift)). encodedBytes at: (byteIndex := byteIndex + 1) put: currentByte. bitPosition := 0. currentByte := 0. "clear saved high bits of buf:" buf := buf bitAnd: (1 << (0 - shift)) - 1. + bufBits := bufBits - bitsAvailable]. + + "update bits available in currentByte buffer" + currentByte := currentByte + (buf << shift). + bitPosition := bitPosition + bufBits. + ^ self - bufBits := bufBits - bitsAvailable] - ifFalse: [ "still some bits available in currentByte buffer" - currentByte := currentByte + (buf << shift). - bitPosition := bitPosition + bufBits. - ^ self]] repeat !

1 0

Squeak 4.6: Files-nice.145.mcz
by commits＠source.squeak.org 11 Dec '17

11 Dec '17

Nicolas Cellier uploaded a new version of Files to project Squeak 4.6: http://source.squeak.org/squeak46/Files-nice.145.mcz ==================== Summary ==================== Name: Files-nice.145 Author: nice Time: 11 December 2017, 6:56:01.168 pm UUID: 14fc2b3b-7138-41e8-8dde-9ebcccc011d2 Ancestors: Files-cmm.144 Backport workaround for truncated .changes readOnlyCopy on linux. =============== Diff against Files-cmm.144 =============== Item was changed: ----- Method: StandardFileStream>>readOnlyCopy (in category 'read, write, position') ----- readOnlyCopy + self flush. "Some linux open a truncated readOnlyCopy. Force it to take latest bytes written into account." - ^ self class readOnlyFileNamed: self name. !

1 0

The Inbox: System-dtl.981.mcz
by commits＠source.squeak.org 10 Dec '17

10 Dec '17

David T. Lewis uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-dtl.981.mcz ==================== Summary ==================== Name: System-dtl.981 Author: dtl Time: 6 December 2017, 9:52:13.947225 pm UUID: d00b5ac2-0e56-40d3-91d6-7803be283e1c Ancestors: System-mt.980 For emergency evaluator handling, Project class>>handlePrimitiveError: will first try to find a parent project of different type (e.g. MVC if current project is Morphic, or vice versa). If found, the other project is opened, and the error is handled there. If no such project is found, then the traditional emergency evaluator transcript is opened. Extend this strategy by first checking parent project types, and if not successful search all projects to find any project of different type. A typical scenario is the case of an image with many Morphic projects, and one MVC project anywhere in the project hierarchy. In the event of an unrecoverable error in any of the Morphic projects, the MVC project will be identified as the project for emergency recovery. This permits an MVC debugger to be used to recover from the error condition, after which the failed Morphic user interface can be reentered. =============== Diff against System-mt.980 =============== Item was changed: ----- Method: Project class>>tryOtherProjectForRecovery: (in category 'error recovery') ----- tryOtherProjectForRecovery: errorMessage "Try entering the parent project if it uses a different user interface. We determine this by comparing the project's class." | safeProject nextProject | nextProject := Project current. safeProject := nil. [safeProject notNil or: [nextProject isTopProject]] whileFalse: [ nextProject := nextProject parent. (Project current isKindOf: nextProject class) ifFalse: [safeProject := nextProject]]. + + "Parent project was not of a different type. Search through all known + projects to find any one that is of different project type." + safeProject ifNil: [ + Smalltalk garbageCollect. + safeProject := Project allSubInstances + detect: [ :proj | proj class ~= Project + or: [ (proj isKindOf: Project current class) not ] ] + ifNone: [ nil ] ]. + safeProject ifNotNil: [:p | p enterForEmergencyRecovery. "Active process will usually suspend after this."].!

4 10

The Inbox: ST80-dtl.233.mcz
by commits＠source.squeak.org 10 Dec '17

10 Dec '17

A new version of ST80 was added to project The Inbox: http://source.squeak.org/inbox/ST80-dtl.233.mcz ==================== Summary ==================== Name: ST80-dtl.233 Author: dtl Time: 10 December 2017, 1:57:45.015948 pm UUID: b442c904-3b1e-462a-9b74-14e97e5ee2b0 Ancestors: ST80-nice.232 Move SoundService stop handling in #finalExitActions from Project to MVCProject in order to allow MorphicProject to handle differently (but also call super). =============== Diff against ST80-nice.232 =============== Item was changed: ----- Method: MVCProject>>finalExitActions: (in category 'enter') ----- finalExitActions: enteringProject super finalExitActions: enteringProject. + SoundService stop. self world unCacheWindows. Sensor flushAllButDandDEvents. ScheduledControllers := nil.!

1 0

The Trunk: ST80-dtl.233.mcz
by commits＠source.squeak.org 10 Dec '17

10 Dec '17

David T. Lewis uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-dtl.233.mcz ==================== Summary ==================== Name: ST80-dtl.233 Author: dtl Time: 10 December 2017, 1:57:45.015948 pm UUID: b442c904-3b1e-462a-9b74-14e97e5ee2b0 Ancestors: ST80-nice.232 Move SoundService stop handling in #finalExitActions from Project to MVCProject in order to allow MorphicProject to handle differently (but also call super). =============== Diff against ST80-nice.232 =============== Item was changed: ----- Method: MVCProject>>finalExitActions: (in category 'enter') ----- finalExitActions: enteringProject super finalExitActions: enteringProject. + SoundService stop. self world unCacheWindows. Sensor flushAllButDandDEvents. ScheduledControllers := nil.!

2 1

The Inbox: System-dtl.983.mcz
by commits＠source.squeak.org 10 Dec '17

10 Dec '17

David T. Lewis uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-dtl.983.mcz ==================== Summary ==================== Name: System-dtl.983 Author: dtl Time: 10 December 2017, 1:54:57.456518 pm UUID: 0df950ab-8484-4d7e-bf0a-09d5450b3a0b Ancestors: System-dtl.982 Fix logic for project selection in #tryOtherProjectForRecovery: =============== Diff against System-dtl.982 =============== Item was changed: ----- Method: Project class>>tryOtherProjectForRecovery: (in category 'error recovery') ----- tryOtherProjectForRecovery: errorMessage "Try entering the parent project if it uses a different user interface. We determine this by comparing the project's class." | safeProject nextProject | nextProject := Project current. safeProject := nil. [safeProject notNil or: [nextProject isTopProject]] whileFalse: [ nextProject := nextProject parent. (Project current isKindOf: nextProject class) ifFalse: [safeProject := nextProject]]. "Parent project was not of a different type. Search through all known projects to find any one that is of different project type." + safeProject ifNil: [Smalltalk garbageCollect. - safeProject ifNil: [ - Smalltalk garbageCollect. safeProject := Project allSubInstances + detect: [:proj | (proj isKindOf: Project current class) not + and: [proj class ~= Project]] + ifNone: []]. - detect: [ :proj | proj class ~= Project - or: [ (proj isKindOf: Project current class) not ] ] - ifNone: [ nil ] ]. - safeProject ifNotNil: [:p | p enterForEmergencyRecovery. "Active process will usually suspend after this."].!

1 0

The Inbox: ToolBuilder-Morphic-jr.202.mcz
by commits＠source.squeak.org 10 Dec '17

10 Dec '17

A new version of ToolBuilder-Morphic was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Morphic-jr.202.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-jr.202 Author: jr Time: 10 December 2017, 5:21:48.408893 pm UUID: 4731ca9c-b924-514d-8f13-19a9913addb5 Ancestors: ToolBuilder-Morphic-tpr.201 fix choice from an empty list Before the preceding changes in 2016, the MorphicUIManager would answer 0 when the list to choose from was empty. After the changes, it would signal an error here: dialog selectedButtonIndex: 1. So guard against an empty list and answer 0 immediately. The case can be triggered in a fresh trunk image when you try to add a repository to an existing package without first adding an additional repository via the '+ Repository' button. There will be zero repositories to choose from. =============== Diff against ToolBuilder-Morphic-tpr.201 =============== Item was changed: ----- Method: MorphicUIManager>>chooseFrom:lines:title: (in category 'ui requests') ----- chooseFrom: aList lines: linesArray title: aString "Choose an item from the given list. Answer the index of the selected item." + aList ifEmpty: [^ 0]. aList size <= 7 ifTrue: [ | dialog | dialog := DialogWindow new title: 'Please Choose'; message: aString; filterEnabled: true; autoCancel: true; yourself. aList doWithIndex: [:ea :index | dialog createButton: ea value: index]. dialog selectedButtonIndex: 1. ^ dialog getUserResponseAtHand ifNil: [0]]. ^ ListChooser chooseFrom: aList title: aString!

1 0

← Newer
1
...
9
10
11
12
13
14
15
16
Older →

Jump to page: