Squeak-dev June 2017

squeak-dev@lists.squeakfoundation.org

36 participants
130 discussions

Re: [squeak-dev] The Trunk: Morphic-eem.1340.mcz
by Jakob Reschke 03 Jun '17

03 Jun '17

2017-06-01 22:22 GMT+02:00 commits(a)source.squeak.org <commits(a)source.squeak.org>: > Eliot Miranda uploaded a new version of Morphic to project The Trunk: > http://source.squeak.org/trunk/Morphic-eem.1340.mcz > > =============== Diff against Morphic-eem.1339 =============== > > + (anEntry isBehavior and: [anEntry name == aSymbol]) ifFalse: "When is this ever false?" > + [anEntry := anEntry class]. > - (anEntry isKindOf: Class) > - ifFalse: [anEntry := anEntry class]. How nice, this saves me a tour to the inbox. Now you can hassle-freely go to traits mentioned in a uses: clause via browseIt, instead of being taken to the class Trait. The condition is false for globals such as Smalltalk and SystemOrganization.

2 1

planet squeak and friends
by Bruce O'Neel 03 Jun '17

03 Jun '17

Hi, At a timescale that only can be described as geological I am moving the existing planet squeak and friends [http://planet.squeak.org/](http://planet.squeak.org/) to a new box and will be maintaining it. Lots of the links have rotted over time.Â If you have a squeak or pharo related blog could you glance at the links on the right hand side of planet.squeak.org and see if your blog is listed, and, if so make sure the feed link is ok?Â If it is not listed if you send me the info I will add it. Finally, does someone have an opinion about what to do with Andreas' blog?Â I would like to leave it...Â And what about the others that are no longer updated but still work? cheers bruce

2 1

The Trunk: Morphic-eem.1340.mcz
by commits＠source.squeak.org 03 Jun '17

03 Jun '17

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1340.mcz ==================== Summary ==================== Name: Morphic-eem.1340 Author: eem Time: 1 June 2017, 1:21:49.04056 pm UUID: 6117ed97-d114-454b-a38c-b35edc306c14 Ancestors: Morphic-eem.1339 Fix browseIt so that accesses to a selected inst var are browsed, not just senders of the accessor. Needs alternateBrowseIt preference disabled. =============== Diff against Morphic-eem.1339 =============== Item was changed: ----- Method: TextEditor>>browseIt (in category 'menu messages') ----- browseIt "Launch a browser for the current selection, if appropriate" + | aSymbol anEntry brow maybeBrowseInstVar | - | aSymbol anEntry brow | Preferences alternativeBrowseIt ifTrue: [^ self browseClassFromIt]. self lineSelectAndEmptyCheck: [^ self]. - (aSymbol := self selectedSymbol) isNil ifTrue: [^ morph flash]. + maybeBrowseInstVar := + [| selectionString | + selectionString := self selection asString. + ([model selectedClass] on: Error do: [:ex|]) ifNotNil: + [:class| + (class allInstVarNames includes: selectionString) ifTrue: + [self systemNavigation + browseAllAccessesTo: selectionString + from: (class classThatDefinesInstanceVariable: selectionString). + ^nil]]]. + + (aSymbol := self selectedSymbol) ifNil: + [maybeBrowseInstVar value. + ^morph flash]. + aSymbol first isUppercase ifTrue: [anEntry := (model environment valueOf: aSymbol ifAbsent: [ self systemNavigation browseAllImplementorsOf: aSymbol. ^ nil]). anEntry ifNil: [^ morph flash]. + (anEntry isBehavior and: [anEntry name == aSymbol]) ifFalse: "When is this ever false?" + [anEntry := anEntry class]. - (anEntry isKindOf: Class) - ifFalse: [anEntry := anEntry class]. brow := SystemBrowser default new. brow setClass: anEntry selector: nil. brow class openBrowserView: (brow openEditString: nil) label: 'System Browser'] ifFalse: + [self systemNavigation browseAllImplementorsOf: aSymbol. + maybeBrowseInstVar value]! - [self systemNavigation browseAllImplementorsOf: aSymbol]!

3 4

The Trunk: SUnitGUI-eem.68.mcz
by commits＠source.squeak.org 02 Jun '17

02 Jun '17

Eliot Miranda uploaded a new version of SUnitGUI to project The Trunk: http://source.squeak.org/trunk/SUnitGUI-eem.68.mcz ==================== Summary ==================== Name: SUnitGUI-eem.68 Author: eem Time: 1 June 2017, 2:20:29.979374 pm UUID: 47ec06e5-6ff4-4475-9034-b298e6f98544 Ancestors: SUnitGUI-ul.67 If Flaps is present (and not loading for the first time) run the initialize method to make sure TestRunner is in the Flaps Tools registry. =============== Diff against SUnitGUI-ul.67 =============== Item was added: + (PackageInfo named: 'SUnitGUI') preamble: '"below, add code to be run before the loading of this package" + "If Flaps is present (and not loading for the first time) run the initialize method to make sure TestRunner is in the Flaps Tools registry." + (Smalltalk classNamed: #TestRunner) ifNotNil: + [:trc| + trc environment at: #Flaps ifPresent: [ :fc | trc initialize]]'!

3 3

The Trunk: Network-eem.198.mcz
by commits＠source.squeak.org 02 Jun '17

02 Jun '17

Eliot Miranda uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-eem.198.mcz ==================== Summary ==================== Name: Network-eem.198 Author: eem Time: 2 June 2017, 12:12:33.771626 pm UUID: d5a7bb03-2ab4-45fd-9032-e190d4e154ed Ancestors: Network-pre.197 Correct deadlineSecs:. There is no roll over problem with the clock scheme from Squeak 5 on. =============== Diff against Network-pre.197 =============== Item was changed: ----- Method: Socket class>>deadlineSecs: (in category 'utilities') ----- deadlineSecs: secs + "Answer a deadline time in milliseconds a given number of seconds from now. + Note that because the millisecondClockValue is derived from the non-wrapping + 61-bit microsecond clock there is no roll over issue." - "Return a deadline time the given number of seconds from now." + ^Time millisecondClockValue + (secs * 1000) truncated - self deprecated: 'Using this method may result in clock rollover related bug. Don''t use it.'. - ^ Time millisecondClockValue + (secs * 1000) truncated !

1 0

The Trunk: Kernel-nice.1107.mcz
by commits＠source.squeak.org 02 Jun '17

02 Jun '17

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1107.mcz ==================== Summary ==================== Name: Kernel-nice.1107 Author: nice Time: 2 June 2017, 12:13:19.450751 am UUID: 597f9f85-fe7b-430a-8ba2-1dd548dc246f Ancestors: Kernel-eem.1106 Correct digitLength for negative SmallInteger The length was overestimated for some numbers, for example self assert: -16rFF01 digitLength = 2. With old code it would answer 3. Indeed, the binary representation is 16r...FFFFFF00FF After shifting once, we got 16r....FFFFFF00, that is -256 and we shifted yet another time. digitLength works on magnitude (like LargeInteger) so we have to take absolute value, but care of SmallInteger minVal abs which is a LargePositiveInteger with same trick as digitAt: =============== Diff against Kernel-eem.1106 =============== Item was changed: ----- Method: SmallInteger>>digitLength (in category 'system primitives') ----- digitLength "Answer the number of indexable fields in the receiver. This value is the same as the largest legal subscript. Included so that a SmallInteger can behave like a LargePositiveInteger or LargeNegativeInteger." | value length | length := 1. + (value := self) < -255 - value := self. - value >= 0 ifTrue: + [length := 2. + value := (-256 - self bitShift: -8) + 1 "carefully negate SmallInteger minVal"]. + [value > 255] whileTrue: + [value := value bitShift: -8. + length := length + 1]. - [[value > 255] whileTrue: - [value := value bitShift: -8. - length := length + 1]] - ifFalse: - [[value < -255] whileTrue: - [value := value bitShift: -8. - length := length + 1]]. ^length!

1 0

Getting TestRunner (an others) in the Flaps registry [Was: The Trunk: SUnitGUI-eem.68.mcz]
by Eliot Miranda 01 Jun '17

01 Jun '17

Hi All, but especially release builders, there may be an issue with the Flaops registry. The default initialization is Flaps class>>#initializeFlapsQuads. But there are additional class initializers that add to the Flaps registry, e.g. TestRunner class>>registerInToolsFlap. If we unload flaps and then reload it we will lose all the extra ones, such as TestRunner's. So for release we should run all implementors of registerInToolsFlap or registerInFlapsRegistry (or rather the relevant senders of registerQuad:forFlapNamed:) to ensure all the classes that want to be in the Flaps registry are there. Note that if instead of a Flaps registry there was a class-side "I should be in the Flaps registry" pragma, then this kind of error wouldn't happen. Either the pragmas would be collected every time the flaps registry was opened, or the Flaps registry would be updated whenever a method with the pragma was added or removed. On Thu, Jun 1, 2017 at 2:20 PM, <commits(a)source.squeak.org> wrote: > Eliot Miranda uploaded a new version of SUnitGUI to project The Trunk: > http://source.squeak.org/trunk/SUnitGUI-eem.68.mcz > > ==================== Summary ==================== > > Name: SUnitGUI-eem.68 > Author: eem > Time: 1 June 2017, 2:20:29.979374 pm > UUID: 47ec06e5-6ff4-4475-9034-b298e6f98544 > Ancestors: SUnitGUI-ul.67 > > If Flaps is present (and not loading for the first time) run the > initialize method to make sure TestRunner is in the Flaps Tools registry. > > =============== Diff against SUnitGUI-ul.67 =============== > > Item was added: > + (PackageInfo named: 'SUnitGUI') preamble: '"below, add code to be run > before the loading of this package" > + "If Flaps is present (and not loading for the first time) run the > initialize method to make sure TestRunner is in the Flaps Tools registry." > + (Smalltalk classNamed: #TestRunner) ifNotNil: > + [:trc| > + trc environment at: #Flaps ifPresent: [ :fc | trc initialize]]'! > > > -- _,,,^..^,,,_ best, Eliot

1 0

The Trunk: Morphic-eem.1339.mcz
by commits＠source.squeak.org 01 Jun '17

01 Jun '17

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1339.mcz ==================== Summary ==================== Name: Morphic-eem.1339 Author: eem Time: 1 June 2017, 12:13:06.49427 pm UUID: 8669e171-73c5-4778-aa28-4a4812dca47d Ancestors: Morphic-eem.1338 Changes harvested from Terf: Add nClicks capture and access for MouseMenuEvents (the Cog VMs have produced this info by virtue of originating at Qwaq). Break an Etoys dependency in adding halos to morphs. Minor otimization to transforms in FrmCanvas; no need to set cellSize more than once. =============== Diff against Morphic-eem.1338 =============== Item was changed: ----- Method: FormCanvas>>transformBy:clippingTo:during:smoothing: (in category 'drawing-support') ----- transformBy: aDisplayTransform clippingTo: aClipRect during: aBlock smoothing: cellSize "Note: This method has been originally copied from TransformationMorph." | innerRect patchRect sourceQuad warp start subCanvas | (aDisplayTransform isPureTranslation) ifTrue:[ ^aBlock value: (self copyOffset: aDisplayTransform offset negated truncated clipRect: aClipRect) ]. "Prepare an appropriate warp from patch to innerRect" innerRect := aClipRect. patchRect := (aDisplayTransform globalBoundsToLocal: innerRect) truncated. sourceQuad := (aDisplayTransform sourceQuadFor: innerRect) collect: [:p | p - patchRect topLeft]. warp := self warpFrom: sourceQuad toRect: innerRect. + warp cellSize: cellSize. "Render the submorphs visible in the clipping rectangle, as patchForm" start := (self depth = 1 and: [self isShadowDrawing not]) "If this is true B&W, then we need a first pass for erasure." ifTrue: [1] ifFalse: [2]. start to: 2 do: [:i | "If i=1 we first make a shadow and erase it for opaque whites in B&W" subCanvas := self class extent: patchRect extent depth: self depth. i=1 ifTrue: [subCanvas shadowColor: Color black. warp combinationRule: Form erase] ifFalse: [self isShadowDrawing ifTrue: [subCanvas shadowColor: self shadowColor]. warp combinationRule: (self depth = 32 ifTrue: [Form blendAlphaScaled] ifFalse: [Form paint])]. subCanvas translateBy: patchRect topLeft negated during: aBlock. + warp sourceForm: subCanvas form; warpBits. - warp sourceForm: subCanvas form; cellSize: cellSize; warpBits. warp sourceForm: nil. subCanvas := nil "release space for next loop"] ! Item was changed: ----- Method: HandMorph>>generateMouseEvent: (in category 'private events') ----- generateMouseEvent: evtBuf "Generate the appropriate mouse event for the given raw event buffer" | position buttons modifiers type trail stamp oldButtons evtChanged | evtBuf first = lastEventBuffer first ifTrue: ["Workaround for Mac VM bug, *always* generating 3 events on clicks" evtChanged := false. 3 to: evtBuf size do: [:i | (lastEventBuffer at: i) = (evtBuf at: i) ifFalse: [evtChanged := true]]. evtChanged ifFalse: [^nil]]. stamp := evtBuf second. stamp = 0 ifTrue: [stamp := Time eventMillisecondClock]. position := evtBuf third @ evtBuf fourth. buttons := evtBuf fifth. modifiers := evtBuf sixth. type := buttons = 0 ifTrue:[ lastEventBuffer fifth = 0 ifTrue: [#mouseMove] "this time no button and previously no button .. just mouse move" ifFalse: [#mouseUp] "this time no button but previously some button ... therefore button was released" ] ifFalse:[ buttons = lastEventBuffer fifth ifTrue: [#mouseMove] "button states are the same .. now and past .. therfore a mouse movement" ifFalse: [ "button states are different .. button was pressed or released" buttons > lastEventBuffer fifth ifTrue: [#mouseDown] ifFalse:[#mouseUp]. ]. ]. buttons := buttons bitOr: (modifiers bitShift: 3). oldButtons := lastEventBuffer fifth bitOr: (lastEventBuffer sixth bitShift: 3). lastEventBuffer := evtBuf. type == #mouseMove ifTrue: [trail := self mouseTrailFrom: evtBuf. ^MouseMoveEvent new setType: type startPoint: (self position) endPoint: trail last trail: trail buttons: buttons hand: self stamp: stamp]. ^MouseButtonEvent new setType: type position: position which: (oldButtons bitXor: buttons) buttons: buttons + nClicks: (evtBuf seventh ifNil: [0]) hand: self stamp: stamp! Item was changed: ----- Method: Morph>>addStandardHaloMenuItemsTo:hand: (in category 'menus') ----- addStandardHaloMenuItemsTo: aMenu hand: aHandMorph "Add standard halo items to the menu" + | unlockables etoysLoaded | - | unlockables | self isWorldMorph ifTrue: [^ self addWorldHaloMenuItemsTo: aMenu hand: aHandMorph]. self mustBeBackmost ifFalse: [aMenu add: 'send to back' translated action: #goBehind. aMenu add: 'bring to front' translated action: #comeToFront. self addEmbeddingMenuItemsTo: aMenu hand: aHandMorph. aMenu addLine]. self addFillStyleMenuItems: aMenu hand: aHandMorph. self addBorderStyleMenuItems: aMenu hand: aHandMorph. self addDropShadowMenuItems: aMenu hand: aHandMorph. self addLayoutMenuItems: aMenu hand: aHandMorph. self addHaloActionsTo: aMenu. owner isTextMorph ifTrue:[self addTextAnchorMenuItems: aMenu hand: aHandMorph]. aMenu addLine. self addToggleItemsToHaloMenu: aMenu. aMenu addLine. self addCopyItemsTo: aMenu. + etoysLoaded := Morph includesSelector: #addPlayerItemsTo:. + etoysLoaded ifTrue: [self addPlayerItemsTo: aMenu]. - self addPlayerItemsTo: aMenu. self addExportMenuItems: aMenu hand: aHandMorph. + etoysLoaded ifTrue: [self addStackItemsTo: aMenu]. - self addStackItemsTo: aMenu. self addMiscExtrasTo: aMenu. Preferences noviceMode ifFalse: [self addDebuggingItemsTo: aMenu hand: aHandMorph]. aMenu addLine. aMenu defaultTarget: self. aMenu addLine. unlockables := self submorphs select: [:m | m isLocked]. unlockables size = 1 ifTrue: [aMenu add: ('unlock "{1}"' translated format: unlockables first externalName) action: #unlockContents]. unlockables size > 1 ifTrue: [aMenu add: 'unlock all contents' translated action: #unlockContents. aMenu add: 'unlock...' translated action: #unlockOneSubpart]. aMenu defaultTarget: aHandMorph. ! Item was changed: MouseEvent subclass: #MouseButtonEvent + instanceVariableNames: 'whichButton nClicks' - instanceVariableNames: 'whichButton' classVariableNames: '' poolDictionaries: '' category: 'Morphic-Events'! Item was added: + ----- Method: MouseButtonEvent>>nClicks (in category 'accessing') ----- + nClicks + ^nClicks ifNil: [0]! Item was added: + ----- Method: MouseButtonEvent>>nClicks: (in category 'accessing') ----- + nClicks: n + nClicks := n! Item was added: + ----- Method: MouseButtonEvent>>setType:position:which:buttons:nClicks:hand:stamp: (in category 'private') ----- + setType: evtType position: evtPos which: button buttons: evtButtons nClicks: numClicks hand: evtHand stamp: stamp + type := evtType. + position := evtPos. + buttons := evtButtons. + nClicks := numClicks. + source := evtHand. + wasHandled := false. + whichButton := button. + timeStamp := stamp!

1 0

The Trunk: Morphic-eem.1338.mcz
by commits＠source.squeak.org 01 Jun '17

01 Jun '17

Eliot Miranda uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-eem.1338.mcz ==================== Summary ==================== Name: Morphic-eem.1338 Author: eem Time: 1 June 2017, 10:42:17.328212 am UUID: 7676f50d-5b80-44bf-914a-c32d52382040 Ancestors: Morphic-pre.1337 Increase the visibility of the menu gradient by using thriceLighter to thriceDarker. Add preferences to DialogWIndow to exclude the close button and/or control menu. =============== Diff against Morphic-pre.1337 =============== Item was changed: Morph subclass: #DialogWindow instanceVariableNames: 'titleMorph messageMorph paneMorph buttonRow result selectedButton cancelButton timeout preferredPosition keyMap exclusive filter filterEnabled filterMorph autoCancel' + classVariableNames: 'GradientDialog IncludeCloseButton IncludeControlMenu RoundedDialogCorners UseWiggleAnimation' - classVariableNames: 'GradientDialog RoundedDialogCorners UseWiggleAnimation' poolDictionaries: '' category: 'Morphic-Windows'! !DialogWindow commentStamp: '<historical>' prior: 0! A DialogBoxMorph is Morph used in simple yes/no/confirm dialogs. Strongly modal.! Item was added: + ----- Method: DialogWindow class>>includeCloseButton (in category 'preferences') ----- + includeCloseButton + + <preference: 'include dialog close button' + category: #dialogs + description: 'If true, user dialogs include a close button.' + type: #Boolean> + ^IncludeCloseButton ifNil: [true]! Item was added: + ----- Method: DialogWindow class>>includeCloseButton: (in category 'preferences') ----- + includeCloseButton: aBoolean + + IncludeCloseButton := aBoolean! Item was added: + ----- Method: DialogWindow class>>includeControlMenu (in category 'preferences') ----- + includeControlMenu + + <preference: 'include dialog control menu' + category: #dialogs + description: 'If true, user dialogs include a control menu.' + type: #Boolean> + ^IncludeControlMenu ifNil: [true]! Item was added: + ----- Method: DialogWindow class>>includeControlMenu: (in category 'preferences') ----- + includeControlMenu: aBoolean + IncludeControlMenu := aBoolean! Item was changed: ----- Method: DialogWindow>>createTitle: (in category 'initialization') ----- createTitle: aString "Mimick behavior of MenuMorph title creation." | box closeButton menuButton | box := Morph new name: #title; changeTableLayout; listDirection: #leftToRight; listCentering: #justified; yourself. titleMorph := aString asText asMorph lock. closeButton := SystemWindowButton new color: Color transparent; target: self; extent: 12@12; actionSelector: #cancelDialog; balloonText: 'Cancel this dialog' translated; borderWidth: 0; labelGraphic: SystemWindow closeBoxImage; extent: SystemWindow closeBoxImage extent; + visible: self class includeCloseButton; yourself. menuButton := SystemWindowButton new color: Color transparent; target: self; actionSelector: #offerDialogMenu; balloonText: 'Dialog menu' translated; borderWidth: 0; labelGraphic: SystemWindow menuBoxImage; extent: SystemWindow menuBoxImage extent; + visible: self class includeControlMenu; yourself. box addAllMorphs: {closeButton. titleMorph. menuButton}. self addMorphBack: box. self setTitleParameters. ! Item was changed: ----- Method: MenuItemMorph>>selectionFillStyle (in category 'private') ----- selectionFillStyle " Answer the fill style to use with the receiver is the selected element " | fill baseColor | baseColor := self userInterfaceTheme selectionColor ifNil: [Color r: 0.4 g: 0.5 b: 0.7]. MenuMorph gradientMenu ifFalse: [ ^baseColor ]. fill := GradientFillStyle ramp: { + 0.0 -> baseColor thriceLighter. + 1 -> baseColor thriceDarker }. - 0.0 -> baseColor twiceLighter. - 1 -> baseColor twiceDarker }. fill origin: self topLeft. fill direction: 0 @ self height. ^ fill! Item was added: + ----- Method: Morph class>>selectionBackground (in category 'defaults') ----- + selectionBackground + "The background for selected items in lists and tree-list thingies." + ^ self subduedHilites ifTrue: [ + Preferences textHighlightColor + ] ifFalse: [ + "This is tuned so the red-foreground used for list texts stays somewhat legible." + Color r: 0.8 g:0.8 b: 0.81 alpha: 0.85 + ]. + !

1 0

The Trunk: Graphics-eem.376.mcz
by commits＠source.squeak.org 01 Jun '17

01 Jun '17

Eliot Miranda uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-eem.376.mcz ==================== Summary ==================== Name: Graphics-eem.376 Author: eem Time: 1 June 2017, 10:36:17.709391 am UUID: b6953526-6eff-43a5-8cc6-9ac9c4b37f82 Ancestors: Graphics-eem.375 Add thriceLighter and thriceDarker for more visible gradients. =============== Diff against Graphics-eem.375 =============== Item was added: + ----- Method: Color>>thriceDarker (in category 'transformations') ----- + thriceDarker + "Answer a significantly darker shade of this color." + + ^ self adjustSaturation: 0.09 brightness: -0.22! Item was added: + ----- Method: Color>>thriceLighter (in category 'transformations') ----- + thriceLighter + "Answer a significantly lighter shade of this color." + + ^ self adjustSaturation: -0.09 brightness: 0.22!

1 0