Squeak-dev February 2018

squeak-dev@lists.squeakfoundation.org

51 participants
149 discussions

The Trunk: Nebraska-ul.52.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Nebraska to project The Trunk: http://source.squeak.org/trunk/Nebraska-ul.52.mcz ==================== Summary ==================== Name: Nebraska-ul.52 Author: ul Time: 22 January 2018, 12:52:51.341224 am UUID: e116559d-9415-4aa7-95a3-3b2cdf0e375f Ancestors: Nebraska-dtl.51 - removed #fixTemps sends =============== Diff against Nebraska-dtl.51 =============== Item was changed: ----- Method: NebraskaIncomingMessage class>>handleNewMorphFrom:sentBy:ipAddress: (in category 'handlers') ----- handleNewMorphFrom: dataStream sentBy: senderName ipAddress: ipAddressString | newObject thumbForm targetWorld | newObject := self newObjectFromStream: dataStream. NebraskaCommunicatorMorph playArrivalSound. targetWorld := self currentWorld. (NebraskaMorphsWelcomeMorph morphsWelcomeInWorld: targetWorld) ifTrue: [ newObject position: ( newObject valueOfProperty: #positionInOriginatingWorld ifAbsent: [(targetWorld randomBoundsFor: newObject) topLeft] ). WorldState addDeferredUIMessage: [ newObject openInWorld: targetWorld. + ]. - ] fixTemps. ^self ]. thumbForm := newObject imageForm scaledToSize: 50@50. Smalltalk at: #SugarListenerMorph ifPresent: [:c | c addToGlobalIncomingQueue: { thumbForm. newObject. senderName. ipAddressString }. WorldState addDeferredUIMessage: [ c ensureListenerInCurrentWorld ]. ].! Item was changed: ----- Method: NebraskaSenderMorph>>startNebraskaClient (in category 'as yet unclassified') ----- startNebraskaClient | newMorph | [ [ newMorph := NetworkTerminalMorph connectTo: (self ipAddress copyUpTo: $:). "FIXME: get real port of Nebraska Server" + WorldState addDeferredUIMessage: [newMorph openInStyle: #scaled]. - WorldState addDeferredUIMessage: [newMorph openInStyle: #scaled] fixTemps. ] on: Error do: [ :ex | WorldState addDeferredUIMessage: [ self inform: 'No connection to: ' translated. self ipAddress,' (',ex printString,')' + ] - ] fixTemps ]. ] fork !

1 0

The Trunk: Morphic-ul.1393.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ul.1393.mcz ==================== Summary ==================== Name: Morphic-ul.1393 Author: ul Time: 5 February 2018, 9:11:37.44438 pm UUID: a9608a85-3f47-45e1-9316-fabd23e326d1 Ancestors: Morphic-tpr.1392 - avoid multiple #halo sends in some methods sending #halo to Morphs - minor improvement to Morph>>updateDropShadowCache's performance - removed a sender of #fixTemps - use ByteArray literals instead of Arrays =============== Diff against Morphic-tpr.1392 =============== Item was changed: ----- Method: BalloonMorph class>>getVertices: (in category 'private') ----- getVertices: bounds "Construct vertices for a balloon up and to left of anchor" | corners | + corners := bounds corners atAll: #[1 4 3 2]. - corners := bounds corners atAll: #(1 4 3 2). ^ (Array with: corners first + (0 - bounds width // 2 @ 0) with: corners first + (0 - bounds width // 4 @ (bounds height // 2))) , corners! Item was changed: ----- Method: HandMorph>>halo: (in category 'halo handling') ----- halo: newHalo "Set halo associated with this hand" + | oldHalo | + (oldHalo := self halo) == newHalo ifTrue: [ ^self ]. + oldHalo ifNotNil: [ oldHalo delete ]. - oldHalo := self halo. - (oldHalo isNil or:[oldHalo == newHalo]) ifFalse:[oldHalo delete]. newHalo ifNil:[self removeProperty: #halo] ifNotNil:[self setProperty: #halo toValue: newHalo]! Item was changed: ----- Method: HandMorph>>removeHalo (in category 'halo handling') ----- removeHalo "remove the receiver's halo (if any)" + + self halo ifNotNil: [ :halo | + halo delete. + self removeProperty: #halo ]! - | halo | - halo := self halo. - halo - ifNil: [^ self]. - halo delete. - self removeProperty: #halo! Item was changed: ----- Method: HandMorph>>selectedObject (in category 'selected object') ----- selectedObject "answer the selected object for the hand or nil is none" + + ^self halo ifNotNil: [ :halo | halo target renderedMorph ]! - | halo | - halo := self halo. - halo isNil - ifTrue: [^ nil]. - ^ halo target renderedMorph! Item was changed: ----- Method: HandMorph>>spawnMagicHaloFor: (in category 'halo handling') ----- spawnMagicHaloFor: aMorph + + self halo ifNotNil: [ :halo | + halo target == aMorph ifTrue:[ ^self ] ]. - (self halo notNil and:[self halo target == aMorph]) ifTrue:[^self]. aMorph addMagicHaloFor: self.! Item was changed: ----- Method: Morph>>removeHalo (in category 'halos and balloon help') ----- removeHalo "remove the surrounding halo (if any)" + + self halo ifNotNil: [ self primaryHand removeHalo ]! - self halo isNil - ifFalse: [self primaryHand removeHalo]! Item was changed: ----- Method: Morph>>updateDropShadowCache (in category 'drawing') ----- updateDropShadowCache + | shadowOffset shadowBounds offset form canvas drawBlock localBounds mask maskCanvas | + (shadowOffset := self shadowOffset) isRectangle + ifTrue: [ + shadowBounds := 0@0 corner: (self bounds outsetBy: shadowOffset) extent. + offset := 0@0. + localBounds := shadowOffset topLeft extent: self extent ] + ifFalse: [ + | extent | + extent := self extent. + shadowBounds := 0@0 corner: extent + shadowOffset abs. + offset := shadowOffset max: 0@0. + localBounds := (shadowOffset negated max: 0@0) extent: extent ]. - | shadowBounds offset form canvas drawBlock localBounds mask maskCanvas | - shadowBounds := self shadowOffset isRectangle - ifTrue: [0@0 corner: (self bounds outsetBy: self shadowOffset) extent] - ifFalse: [0@0 corner: self extent + self shadowOffset abs]. - offset := self shadowOffset isRectangle - ifTrue: [0@0] - ifFalse: [self shadowOffset max: 0@0]. - localBounds := self shadowOffset isRectangle - ifTrue: [self shadowOffset topLeft extent: self extent] - ifFalse: [(self shadowOffset negated max: 0@0) extent: self extent]. form := Form extent: shadowBounds extent depth: Display depth. canvas := form getCanvas. drawBlock := self useSoftDropShadow ifFalse: [ [:c | self wantsRoundedCorners ifTrue: [c fillRoundRect: localBounds radius: self cornerRadius fillStyle: self shadowColor] ifFalse: [c fillRectangle: localBounds fillStyle: self shadowColor]]] ifTrue: [ [:c | self wantsRoundedCorners ifTrue: [0 to: 9 do: [:i | c fillRoundRect: (shadowBounds insetBy: i) radius: (self cornerRadius max: 20) -i fillStyle: (self shadowColor alpha: self shadowColor alpha * (i+1))]] ifFalse: [0 to: 9 do: [:i | c fillRoundRect: (shadowBounds insetBy: i) radius: 20-i fillStyle: (self shadowColor alpha: self shadowColor alpha * (i+1))]]]]. canvas translateBy: offset during: [ :shadowCanvas | drawBlock value: shadowCanvas]. "Support transparent morph colors without having the shadow to shine through.." mask := Form extent: shadowBounds extent depth: Display depth. maskCanvas := mask getCanvas. self wantsRoundedCorners ifTrue: [maskCanvas fillRoundRect: (localBounds insetBy: self borderWidth) radius: self cornerRadius fillStyle: Color black] ifFalse: [maskCanvas fillRectangle: (localBounds insetBy: self borderWidth) fillStyle: Color black]. mask displayOn: form at: 0@0 rule: Form erase. self setProperty: #dropShadow toValue: form.! Item was changed: ----- Method: SelectionMorph>>justDroppedInto:event: (in category 'dropping/grabbing') ----- justDroppedInto: newOwner event: evt "This message is sent to a dropped morph after it has been dropped on -- and been accepted by -- a drop-sensitive morph" selectedItems isEmpty ifTrue: ["Hand just clicked down to draw out a new selection" ^ self extendByHand: evt hand]. dupLoc ifNotNil: [dupDelta := self position - dupLoc]. selectedItems reverseDo: [:m | WorldState addDeferredUIMessage: [m referencePosition: (newOwner localPointToGlobal: m referencePosition). newOwner handleDropMorph: + (DropEvent new setPosition: evt cursorPoint contents: m hand: evt hand)]]. - (DropEvent new setPosition: evt cursorPoint contents: m hand: evt hand)] fixTemps]. selectedItems := nil. self removeHalo. + self halo ifNotNil: [ :halo | halo visible: false ]. - self halo ifNotNil: [self halo visible: false]. self delete. evt wasHandled: true!

1 0

The Trunk: GraphicsTests-ul.46.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of GraphicsTests to project The Trunk: http://source.squeak.org/trunk/GraphicsTests-ul.46.mcz ==================== Summary ==================== Name: GraphicsTests-ul.46 Author: ul Time: 22 January 2018, 12:28:47.553681 am UUID: baf0a864-6d1d-46ed-b0a8-ba22893e8e26 Ancestors: GraphicsTests-dtl.45 - use ByteArray literals instead of Arrays =============== Diff against GraphicsTests-dtl.45 =============== Item was changed: ----- Method: BitBltTest>>testPivelValueAt (in category 'bugs') ----- testPivelValueAt "tests for the pixel peeking extension to bitBlt" " self run: #testPixelValueAt" |formList pixels | "make a Form of each depth" + formList := #[1 2 4 8 16 32] collect:[:d| Form extent: 17@7 depth: d] as: Array. - formList := #(1 2 4 8 16 32) collect:[:d| Form extent: 17@7 depth: d]. pixels := Dictionary new. pixels at: 1 put: 1; at: 2 put: 3; at:4 put: 7; at: 8 put: 16rFF; at: 16 put: 16rFFFF ; at: 32 put: 16rFFFFFFFF. "poke pixels to topleft (to test handling 0) bottomright (to test limits) middle (just because) peek at each location (to make sure it matches expectations)" formList do:[:f| |d pixval| d := f depth. pixval := pixels at: d. f pixelValueAt: 0@0 put: pixval. f pixelValueAt: 16@6 put: pixval. f pixelValueAt: 7@3 put: pixval. self assert: (f pixelValueAt: 0@0) = pixval. self assert: (f pixelValueAt: 1@0) = 0. self assert: (f pixelValueAt: 16@6) = pixval. self assert:(f pixelValueAt: 15@6) = 0. self assert: (f pixelValueAt: 7@3) = pixval. self assert: (f pixelValueAt: 6@3) = 0. ]!

1 0

The Inbox: Files-ul.178.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Files to project The Inbox: http://source.squeak.org/inbox/Files-ul.178.mcz ==================== Summary ==================== Name: Files-ul.178 Author: ul Time: 22 January 2018, 12:27:00.720911 am UUID: 7b7a5c36-da7a-4404-9dd4-20b21975aa30 Ancestors: Files-tpr.177 - only check once for #badDirectoryPath in FileDirectory>>directoryContentsFor:do: =============== Diff against Files-tpr.177 =============== Item was changed: ----- Method: FileDirectory>>directoryContentsFor:do: (in category 'private') ----- directoryContentsFor: fullPath do: aBlock "Do aBlock for the files and directories in the directory with the given path. See primLookupEntryIn:index: for further details." "FileDirectory default directoryContentsFor: '' do: [ :each | Transcript show: each; cr ]" + | vmPath entryArray index | + vmPath := fullPath asVmPathName. - | f entryArray index | - f := fullPath asVmPathName. index := 1. + entryArray := self primLookupEntryIn: vmPath index: index. + #badDirectoryPath == entryArray ifTrue: [ + ^(InvalidDirectoryError pathName: fullPath) signal ]. + [ + aBlock value: (DirectoryEntry fromArray: entryArray directory: self) convertFromSystemName. + (entryArray := self primLookupEntryIn: vmPath index: (index := index + 1)) == nil ] whileFalse! - [(entryArray := self primLookupEntryIn: f index: index) == nil] whileFalse: [ - #badDirectoryPath == entryArray ifTrue: [ - ^(InvalidDirectoryError pathName: pathName) signal]. - index := index + 1. - aBlock value: (DirectoryEntry fromArray: entryArray directory: self) convertFromSystemName]!

1 0

The Trunk: Collections-ul.782.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ul.782.mcz ==================== Summary ==================== Name: Collections-ul.782 Author: ul Time: 5 February 2018, 9:00:26.138464 pm UUID: e2bb4a8b-6a0e-4342-b347-4f2226460a85 Ancestors: Collections-mt.781 - various minor tweaks =============== Diff against Collections-mt.781 =============== Item was changed: ----- Method: Ascii85Converter>>padOfSize: (in category 'private') ----- + padOfSize: anInteger - padOfSize: aNumber + anInteger = 1 ifTrue: [ ^#[0] ]. + anInteger = 2 ifTrue: [ ^#[0 0] ]. + anInteger = 3 ifTrue: [ ^#[0 0 0] ]. + self error: 'Should not reach'! - aNumber = 1 ifTrue: [^ #(0)]. - aNumber = 2 ifTrue: [^ #(0 0)]. - aNumber = 3 ifTrue: [^ #(0 0 0)]. - self error: 'Should not reach'.! Item was changed: ----- Method: ByteString>>asIntegerSigned: (in category 'converting') ----- asIntegerSigned: signed "Return the first decimal integer I can find or nil." | index integerValue result size negative | (size := self size) <= 16 ifFalse: [ ^super asIntegerSigned: signed ]. "Find the first character between $0 and $9." index := 0. + [ + (index := index + 1) <= size ifFalse: [ ^nil "There are no digits in this string." ]. + (integerValue := self basicAt: index) <= 47 "$0 asInteger - 1" + or: [ 58 "$9 asInteger + 1" <= integerValue ] ] whileTrue. + "Check the sign." - [ (index := index + 1) <= size and: [ - (integerValue := (self at: index) asInteger) <= 47 "$0 asInteger - 1" or: [ - 58 "$9 asInteger + 1" <= integerValue ] ] ] whileTrue. - index <= size ifFalse: [ ^nil ]. negative := signed and: [ 2 <= index and: [ (self at: index - 1) == $- ] ]. "Parse the number." result := integerValue - 48 "$0 asInteger". [ (index := index + 1) <= size + and: [ (integerValue := self basicAt: index) <= 57 "$9 asInteger" - and: [ (integerValue := (self at: index) asInteger) <= 57 "$9 asInteger" and: [ 48 "$0 asInteger" <= integerValue ] ] ] whileTrue: [ result := result * 10 + integerValue - 48 ]. negative ifTrue: [ ^result negated ]. ^result! Item was changed: ----- Method: SequenceableCollection>>copyReplaceFrom:to:with: (in category 'copying') ----- copyReplaceFrom: start to: stop with: replacementCollection "Answer a copy of the receiver satisfying the following conditions: If stop is less than start, then this is an insertion; stop should be exactly start-1, start = 1 means insert before the first character, start = size+1 means append after last character. Otherwise, this is a replacement; start and stop have to be within the receiver's bounds." | newSequenceableCollection newSize endReplacement | - newSize := self size - (stop - start + 1) + replacementCollection size. endReplacement := start - 1 + replacementCollection size. + newSize := self size + endReplacement - stop. newSequenceableCollection := self species new: newSize. start > 1 ifTrue:[ newSequenceableCollection replaceFrom: 1 to: start - 1 with: self startingAt: 1]. start <= endReplacement ifTrue:[ newSequenceableCollection replaceFrom: start to: endReplacement with: replacementCollection startingAt: 1]. endReplacement < newSize ifTrue:[ newSequenceableCollection replaceFrom: endReplacement + 1 to: newSize with: self startingAt: stop + 1]. ^newSequenceableCollection! Item was changed: ----- Method: String>>endsWith: (in category 'testing') ----- endsWith: sequence "Answer true if the receiver ends with the argument collection. The comparison is case-sensitive." | index sequenceSize offset | + sequence isString ifFalse: [ ^super endsWith: sequence ]. + (sequenceSize := sequence size) = 0 ifTrue: [ ^false ]. "old convention" + (offset := self size - sequenceSize) < 0 ifTrue: [ ^false ]. - sequence isString ifFalse: [ ^ super endsWith: sequence ]. - ((sequenceSize := sequence size) = 0 or: [ (offset := self size - sequenceSize) < 0 ]) ifTrue: [ ^false ]. index := 0. [ (index := index + 1) <= sequenceSize ] whileTrue: [ (sequence at: index) == (self at: index + offset) ifFalse: [ ^false ] ]. ^true!

1 0

The Trunk: Chronology-Core-ul.10.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-ul.10.mcz ==================== Summary ==================== Name: Chronology-Core-ul.10 Author: ul Time: 21 January 2018, 10:47:08.890119 pm UUID: 415cc09f-0491-491c-b6a1-d4e696597018 Ancestors: Chronology-Core-pre.9 - applied SourceCodeFixer =============== Diff against Chronology-Core-pre.9 =============== Item was changed: ----- Method: DateAndTime>>< (in category 'ansi protocol') ----- < comparand "comparand conforms to protocol DateAndTime, or can be converted into something that conforms." | lvalue rvalue comparandAsDateAndTime | + comparandAsDateAndTime := comparand asDateAndTime. - comparandAsDateAndTime _ comparand asDateAndTime. self offset = comparandAsDateAndTime offset ifTrue: [ lvalue := self. rvalue := comparandAsDateAndTime ] ifFalse: [ lvalue := self asUTC. rvalue := comparandAsDateAndTime asUTC ]. ^ lvalue julianDayNumber < rvalue julianDayNumber or: [ lvalue julianDayNumber > rvalue julianDayNumber ifTrue: [ false ] ifFalse: [ lvalue secondsSinceMidnight < rvalue secondsSinceMidnight or: [ lvalue secondsSinceMidnight > rvalue secondsSinceMidnight ifTrue: [ false ] ifFalse: [ lvalue nanoSecond < rvalue nanoSecond ] ] ] ]!

1 0

The Inbox: Kernel-ul.1152.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.1152.mcz ==================== Summary ==================== Name: Kernel-ul.1152 Author: ul Time: 5 February 2018, 8:47:28.262652 pm UUID: ae7053df-0c5e-489e-b14c-46ab4fd00986 Ancestors: Kernel-ul.1151 Monitor changes: - Monitor is now a subclass of Mutex. - All methods implemented by Mutex have been removed from Monitor. - The ownerProcess instance variable has been removed, because Mutex has its own owner instance variable. It was not referenced from Monitor's code. =============== Diff against Kernel-ul.1151 =============== Item was changed: + Mutex subclass: #Monitor + instanceVariableNames: 'defaultQueue queueDict queuesMutex nestingLevel' - LinkedList subclass: #Monitor - instanceVariableNames: 'ownerProcess defaultQueue queueDict queuesMutex nestingLevel' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Processes'! !Monitor commentStamp: 'eem 1/7/2016 11:38' prior: 0! A monitor provides process synchronization that is more high level than the one provided by a Semaphore. Similar to the classical definition of a Monitor it has the following properties: 1) At any time, only one process can execute code inside a critical section of a monitor. 2) A monitor is reentrant, which means that the active process in a monitor never gets blocked when it enters a (nested) critical section of the same monitor. For example a monitor will not block when trying the following: | m | m := Monitor new. m critical: [m critical: [#yes]] whereas a Semaphore will deadlock: | s | s := Semaphore forMutualExclusion. s critical: [s critical: [#no]] 3) Inside a critical section, a process can wait for an event that may be coupled to a certain condition. If the condition is not fulfilled, the process leaves the monitor temporarily (in order to let other processes enter) and waits until another process signals the event. Then, the original process checks the condition again (this is often necessary because the state of the monitor could have changed in the meantime) and continues if it is fulfilled. 4) The monitor is fair, which means that the process that is waiting on a signaled condition the longest gets activated first. 5) The monitor allows you to define timeouts after which a process gets activated automatically. Basic usage: Monitor>>critical: aBlock Critical section. Executes aBlock as a critical section. At any time, only one process can execute code in a critical section. NOTE: All the following synchronization operations are only valid inside the critical section of the monitor!! Monitor>>wait Unconditional waiting for the default event. The current process gets blocked and leaves the monitor, which means that the monitor allows another process to execute critical code. When the default event is signaled, the original process is resumed. Monitor>>waitWhile: aBlock Conditional waiting for the default event. The current process gets blocked and leaves the monitor only if the argument block evaluates to true. This means that another process can enter the monitor. When the default event is signaled, the original process is resumed, which means that the condition (argument block) is checked again. Only if it evaluates to false, does execution proceed. Otherwise, the process gets blocked and leaves the monitor again... Monitor>>waitUntil: aBlock Conditional waiting for the default event. See Monitor>>waitWhile: aBlock. Monitor>>signal One process waiting for the default event is woken up. Monitor>>signalAll All processes waiting for the default event are woken up. Using non-default (specific) events: Monitor>>waitFor: aSymbol Unconditional waiting for the non-default event represented by the argument symbol. Same as Monitor>>wait, but the process gets only reactivated by the specific event and not the default event. Monitor>>waitWhile: aBlock for: aSymbol Confitional waiting for the non-default event represented by the argument symbol. Same as Monitor>>waitWhile:for:, but the process gets only reactivated by the specific event and not the default event. Monitor>>waitUntil: aBlock for: aSymbol Confitional waiting for the non-default event represented by the argument symbol. See Monitor>>waitWhile:for: aBlock. Monitor>>signal: aSymbol One process waiting for the given event is woken up. If there is no process waiting for this specific event, a process waiting for the default event gets resumed. Monitor>>signalAll: aSymbol All process waiting for the given event or the default event are woken up. Monitor>>signalReallyAll All processes waiting for any events (default or specific) are woken up. Using timeouts Monitor>>waitMaxMilliseconds: anInteger Monitor>>waitFor: aSymbol maxMilliseconds: anInteger Same as Monitor>>wait (resp. Monitor>>waitFor:), but the process gets automatically woken up when the specified time has passed. Monitor>>waitWhile: aBlock maxMilliseconds: anInteger Monitor>>waitWhile: aBlock for: aSymbol maxMilliseconds: anInteger Same as Monitor>>waitWhile: (resp. Monitor>>waitWhile:for:), but the process gets automatically woken up when the specified time has passed. Monitor>>waitUntil: aBlock maxMilliseconds: anInteger Monitor>>waitUntil: aBlock for: aSymbol maxMilliseconds: anInteger Same as Monitor>>waitUntil: (resp. Monitor>>waitUntil:for:), but the process gets automatically woken up when the specified time has passed.! Item was removed: - ----- Method: Monitor>>critical: (in category 'mutual exclusion') ----- - critical: aBlock - "Evaluate aBlock protected by the receiver." - <criticalSection> - ^self primitiveEnterCriticalSection - ifTrue: [aBlock value] - ifFalse: [aBlock ensure: [self primitiveExitCriticalSection]]! Item was removed: - ----- Method: Monitor>>critical:ifLocked: (in category 'mutual exclusion') ----- - critical: aBlock ifLocked: lockedBlock - "Answer the evaluation of aBlock protected by the receiver. If it is already in a critical - section on behalf of some other process answer the evaluation of lockedBlock." - <criticalSection> - ^self primitiveTestAndSetOwnershipOfCriticalSection - ifNil: [lockedBlock value] - ifNotNil: - [:alreadyOwner| - alreadyOwner - ifTrue: [aBlock value] - ifFalse: [aBlock ensure: [self primitiveExitCriticalSection]]]! Item was removed: - ----- Method: Monitor>>primitiveEnterCriticalSection (in category 'private-primitives') ----- - primitiveEnterCriticalSection - "Primitive. The receiver must be unowned or owned by the current process to proceed. - Answer if the process is owned by the current process. - - Copyright (c) 2016 - 3D Immersive Collaboration Consulting, LLC." - <primitive: 186> - self primitiveFailed - "In the spirit of the following" - "[owner ifNil: - [owner := Processor activeProcess. - ^false]. - owner = Processor activeProcess ifTrue: - [^true]. - self addLast: Processor activeProcess. - Processor activeProcess suspend] valueUnpreemptively"! Item was removed: - ----- Method: Monitor>>primitiveEnterCriticalSectionOnBehalfOf: (in category 'system simulation') ----- - primitiveEnterCriticalSectionOnBehalfOf: effectiveProcess - "Primitive. Simulate primitiveEnterCriticalSection. The receiver - must be unowned or owned by the effectiveProcess to proceed. - Answer if the process is already owned by the current process." - <primitive: 186> - ^Context primitiveFailTokenFor: nil! Item was removed: - ----- Method: Monitor>>primitiveExitCriticalSection (in category 'private-primitives') ----- - primitiveExitCriticalSection - "Primitive. Set the receiver to unowned and if any processes are waiting on - the receiver then proceed the first one, indicating that the receiver is unowned. - - Copyright (c) 2016 - 3D Immersive Collaboration Consulting, LLC." - <primitive: 185> - self primitiveFailed - "In the spirit of the following" - "[owner := nil. - self isEmpty ifFalse: - [process := self removeFirst. - process resume]] valueUnpreemptively"! Item was removed: - ----- Method: Monitor>>primitiveTestAndSetOwnershipOfCriticalSection (in category 'private-primitives') ----- - primitiveTestAndSetOwnershipOfCriticalSection - "Primitive. Attempt to set the ownership of the receiver. - If the receiver is unowned set its owningProcess to the - activeProcess and answer false. If the receiver is owned - by the activeProcess answer true. If the receiver is owned - by some other process answer nil. - - Copyright (c) 2016 - 3D Immersive Collaboration Consulting, LLC." - <primitive: 187> - self primitiveFailed - "In the spirit of the following" - "[owner ifNil: - [owningProcess := Processor activeProcess. - ^false]. - owner = Processor activeProcess ifTrue: [^true]. - ^nil] valueUnpreemptively"! Item was removed: - ----- Method: Monitor>>primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: (in category 'system simulation') ----- - primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effectiveProcess - "Primitive. Simulate primitiveEnterCriticalSection. Attempt to set the ownership - of the receiver. If the receiver is unowned set its owningProcess to the - effectiveProcess and answer false. If the receiver is owned by the effectiveProcess - answer true. If the receiver is owned by some other process answer nil." - <primitive: 187> - ^Context primitiveFailTokenFor: nil!

1 0

The Inbox: Kernel-ul.1151.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.1151.mcz ==================== Summary ==================== Name: Kernel-ul.1151 Author: ul Time: 5 February 2018, 8:36:45.002788 pm UUID: 42deff55-7552-442b-ac97-a046ece97558 Ancestors: Kernel-tonyg.1150 Monitor changes: - copied the missing methods used by the debugger: primitiveEnterCriticalSectionOnBehalfOf: and primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: - queuesMutex is now a Mutex instead of a Semaphore - removed the unused mutex variable - the next step could be to make Monitor a subclass of Mutex - improved Integer >> #isPrime's performance in 64-bit images - ScaledDecimal >> #printOn: rounds the number instead of truncating it =============== Diff against Kernel-tonyg.1150 =============== Item was changed: ----- Method: Integer>>isPrime (in category 'testing') ----- isPrime "Answer true if the receiver is a prime number. See isProbablyPrime for a probabilistic implementation that is much faster for large integers, and that is correct to an extremely high statistical level of confidence (effectively deterministic)." self <= 1 ifTrue: [ ^false ]. self even ifTrue: [ ^self = 2]. + self <= 1073741823 ifFalse: [ "1 << 30 - 1. For numbers larger than this, the calculation takes longer than #isProbablyPrime when the receiver is a prime. The absolue turning point is about at 1 << 35 - 1." + ^self isProbablyPrime ]. 3 to: self sqrtFloor by: 2 do: [ :each | self \\ each = 0 ifTrue: [ ^false ] ]. ^true! Item was changed: LinkedList subclass: #Monitor + instanceVariableNames: 'ownerProcess defaultQueue queueDict queuesMutex nestingLevel' - instanceVariableNames: 'ownerProcess defaultQueue queueDict queuesMutex mutex nestingLevel' classVariableNames: '' poolDictionaries: '' category: 'Kernel-Processes'! !Monitor commentStamp: 'eem 1/7/2016 11:38' prior: 0! A monitor provides process synchronization that is more high level than the one provided by a Semaphore. Similar to the classical definition of a Monitor it has the following properties: 1) At any time, only one process can execute code inside a critical section of a monitor. 2) A monitor is reentrant, which means that the active process in a monitor never gets blocked when it enters a (nested) critical section of the same monitor. For example a monitor will not block when trying the following: | m | m := Monitor new. m critical: [m critical: [#yes]] whereas a Semaphore will deadlock: | s | s := Semaphore forMutualExclusion. s critical: [s critical: [#no]] 3) Inside a critical section, a process can wait for an event that may be coupled to a certain condition. If the condition is not fulfilled, the process leaves the monitor temporarily (in order to let other processes enter) and waits until another process signals the event. Then, the original process checks the condition again (this is often necessary because the state of the monitor could have changed in the meantime) and continues if it is fulfilled. 4) The monitor is fair, which means that the process that is waiting on a signaled condition the longest gets activated first. 5) The monitor allows you to define timeouts after which a process gets activated automatically. Basic usage: Monitor>>critical: aBlock Critical section. Executes aBlock as a critical section. At any time, only one process can execute code in a critical section. NOTE: All the following synchronization operations are only valid inside the critical section of the monitor!! Monitor>>wait Unconditional waiting for the default event. The current process gets blocked and leaves the monitor, which means that the monitor allows another process to execute critical code. When the default event is signaled, the original process is resumed. Monitor>>waitWhile: aBlock Conditional waiting for the default event. The current process gets blocked and leaves the monitor only if the argument block evaluates to true. This means that another process can enter the monitor. When the default event is signaled, the original process is resumed, which means that the condition (argument block) is checked again. Only if it evaluates to false, does execution proceed. Otherwise, the process gets blocked and leaves the monitor again... Monitor>>waitUntil: aBlock Conditional waiting for the default event. See Monitor>>waitWhile: aBlock. Monitor>>signal One process waiting for the default event is woken up. Monitor>>signalAll All processes waiting for the default event are woken up. Using non-default (specific) events: Monitor>>waitFor: aSymbol Unconditional waiting for the non-default event represented by the argument symbol. Same as Monitor>>wait, but the process gets only reactivated by the specific event and not the default event. Monitor>>waitWhile: aBlock for: aSymbol Confitional waiting for the non-default event represented by the argument symbol. Same as Monitor>>waitWhile:for:, but the process gets only reactivated by the specific event and not the default event. Monitor>>waitUntil: aBlock for: aSymbol Confitional waiting for the non-default event represented by the argument symbol. See Monitor>>waitWhile:for: aBlock. Monitor>>signal: aSymbol One process waiting for the given event is woken up. If there is no process waiting for this specific event, a process waiting for the default event gets resumed. Monitor>>signalAll: aSymbol All process waiting for the given event or the default event are woken up. Monitor>>signalReallyAll All processes waiting for any events (default or specific) are woken up. Using timeouts Monitor>>waitMaxMilliseconds: anInteger Monitor>>waitFor: aSymbol maxMilliseconds: anInteger Same as Monitor>>wait (resp. Monitor>>waitFor:), but the process gets automatically woken up when the specified time has passed. Monitor>>waitWhile: aBlock maxMilliseconds: anInteger Monitor>>waitWhile: aBlock for: aSymbol maxMilliseconds: anInteger Same as Monitor>>waitWhile: (resp. Monitor>>waitWhile:for:), but the process gets automatically woken up when the specified time has passed. Monitor>>waitUntil: aBlock maxMilliseconds: anInteger Monitor>>waitUntil: aBlock for: aSymbol maxMilliseconds: anInteger Same as Monitor>>waitUntil: (resp. Monitor>>waitUntil:for:), but the process gets automatically woken up when the specified time has passed.! Item was changed: ----- Method: Monitor>>initialize (in category 'initialize-release') ----- initialize + queuesMutex := Mutex new! - queuesMutex := Semaphore forMutualExclusion! Item was added: + ----- Method: Monitor>>primitiveEnterCriticalSectionOnBehalfOf: (in category 'system simulation') ----- + primitiveEnterCriticalSectionOnBehalfOf: effectiveProcess + "Primitive. Simulate primitiveEnterCriticalSection. The receiver + must be unowned or owned by the effectiveProcess to proceed. + Answer if the process is already owned by the current process." + <primitive: 186> + ^Context primitiveFailTokenFor: nil! Item was added: + ----- Method: Monitor>>primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: (in category 'system simulation') ----- + primitiveTestAndSetOwnershipOfCriticalSectionOnBehalfOf: effectiveProcess + "Primitive. Simulate primitiveEnterCriticalSection. Attempt to set the ownership + of the receiver. If the receiver is unowned set its owningProcess to the + effectiveProcess and answer false. If the receiver is owned by the effectiveProcess + answer true. If the receiver is owned by some other process answer nil." + <primitive: 187> + ^Context primitiveFailTokenFor: nil! Item was changed: ----- Method: ScaledDecimal>>printOn: (in category 'printing') ----- printOn: stream self + printOn: stream showingDecimalPlaces: scale; - printFractionAsDecimalOn: stream; printScaleOn: stream!

1 0

The Trunk: KernelTests-ul.332.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Levente Uzonyi uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-ul.332.mcz ==================== Summary ==================== Name: KernelTests-ul.332 Author: ul Time: 5 February 2018, 8:42:17.266896 pm UUID: 93605545-3a6c-4059-9763-f8d733f1c218 Ancestors: KernelTests-tonyg.331 - added a test for object pinning - use the #excessSignals accessor in SemaphoreTest =============== Diff against KernelTests-tonyg.331 =============== Item was added: + ----- Method: ObjectTest>>testPinning (in category 'tests') ----- + testPinning + "Test pinning state changes for two objects. Iterate over all possible state transitions." + + | objects | + objects := { Object new. Object new }. + #((false false) (false true) (true false) (true true)) + combinations: 2 + atATimeDo: [ :transition | + | fromState toState | + fromState := transition first. + toState := transition second. + fromState with: objects do: [ :pinned :object | + pinned + ifTrue: [ object pin ] + ifFalse: [ object unpin ]. + self assert: pinned equals: object isPinned ]. + objects withIndexDo: [ :object :index | + | from to | + from := fromState at: index. + to := toState at: index. + self assert: from equals: (to + ifTrue: [ object pin ] + ifFalse: [ object unpin ]). + self assert: to equals: object isPinned ] ]! Item was changed: ----- Method: SemaphoreTest>>testSemaAfterCriticalWait (in category 'testing') ----- testSemaAfterCriticalWait "self run: #testSemaAfterCriticalWait" "This tests whether a semaphore that has just left the wait in Semaphore>>critical: leaves it with signaling the associated semaphore." | s p | s := Semaphore new. p := [s critical:[]] forkAt: Processor activePriority-1. "wait until p entered the critical section" [p suspendingList == s] whileFalse:[(Delay forMilliseconds: 10) wait]. "Now that p entered it, signal the semaphore. p now 'owns' the semaphore but since we are running at higher priority than p it will not get to do anything." s signal. p terminate. + self assert: 1 equals: s excessSignals! - self assert: ((s instVarNamed: #excessSignals) = 1)! Item was changed: ----- Method: SemaphoreTest>>testSemaInCriticalWait (in category 'testing') ----- testSemaInCriticalWait "self run: #testSemaInCriticalWait" "This tests whether a semaphore that has entered the wait in Semaphore>>critical: leaves it without signaling the associated semaphore." | s p | s := Semaphore new. p := [s critical:[]] fork. Processor yield. self assert:(p suspendingList == s). p terminate. + self assert: 0 equals: s excessSignals! - self assert:((s instVarNamed: #excessSignals) = 0)!

1 0

The Trunk: Tools-eem.796.mcz
by commits＠source.squeak.org 05 Feb '18

05 Feb '18

Eliot Miranda uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-eem.796.mcz ==================== Summary ==================== Name: Tools-eem.796 Author: eem Time: 5 February 2018, 10:55:12.092928 am UUID: cc39c046-0da0-4dc7-b932-e00c98e1b729 Ancestors: Tools-tpr.795 Show a Character's code in the inspector label, as per SmallInteger. =============== Diff against Tools-tpr.795 =============== Item was added: + ----- Method: Character>>defaultLabelForInspector (in category '*Tools-Inspecting-label') ----- + defaultLabelForInspector + "Answer the default label to be used for an Inspector window on the receiver." + + ^ super defaultLabelForInspector, ': code ', self asInteger printString! Item was changed: ----- Method: StandardToolSet class>>inspectorClassOf: (in category 'inspecting') ----- inspectorClassOf: anObject "Answer the inspector class for the given object. The tool set must know which inspector type to use for which object - the object cannot possibly know what kind of inspectors the toolset provides." | map | map := Dictionary new. #( + (CompiledCode CompiledMethodInspector) - (CompiledMethod CompiledMethodInspector) (CompositeEvent OrderedCollectionInspector) (Dictionary DictionaryInspector) (ExternalStructure ExternalStructureInspector) (FloatArray OrderedCollectionInspector) (OrderedCollection OrderedCollectionInspector) (Set SetInspector) (WeakSet WeakSetInspector) ) do:[:spec| map at: spec first put: spec last. ]. anObject class withAllSuperclassesDo:[:cls| map at: cls name ifPresent:[:inspectorName| ^Smalltalk classNamed: inspectorName]. ]. ^Inspector!

1 0

← Newer
1
...
9
10
11
12
13
14
15
Older →

Jump to page: