Squeak-dev December 2019

squeak-dev@lists.squeakfoundation.org

32 participants
256 discussions

The Trunk: Morphic-cmm.1484.mcz
by commits＠source.squeak.org 13 Jan '20

13 Jan '20

Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-cmm.1484.mcz ==================== Summary ==================== Name: Morphic-cmm.1484 Author: cmm Time: 4 April 2019, 5:46:17.398582 pm UUID: 5a57ba6f-fa15-44a3-9581-c919060f0378 Ancestors: Morphic-cmm.1483 Metacello and GitInfrastructure tools are currently the best way to load projects hosted by github.com. Promote installation of the these tools to the Tools menu. =============== Diff against Morphic-cmm.1483 =============== Item was added: + ----- Method: TheWorldMainDockingBar>>gitInfrastructureMenuItemOn: (in category 'submenu - tools') ----- + gitInfrastructureMenuItemOn: menu + menu addItem: + [ : item | item + contents: 'Git Infrastructure' translated ; + help: 'Load tools for accessing github repositories.' translated ; + icon: (self colorIcon: Color lightGray) ; + target: Installer ; + selector: #installGitInfrastructure ]! Item was added: + ----- Method: TheWorldMainDockingBar>>metacelloMenuItemOn: (in category 'submenu - tools') ----- + metacelloMenuItemOn: menu + menu addItem: + [ : item | item + contents: 'Metacello' translated ; + help: 'Install Metacello' translated ; + icon: (self colorIcon: Color lightGray) ; + target: Installer ; + selector: #ensureRecentMetacello ]! Item was changed: ----- Method: TheWorldMainDockingBar>>toolsMenuOn: (in category 'construction') ----- toolsMenuOn: aDockingBar aDockingBar addItem: [ :item | item contents: 'Tools' translated; addSubMenu: [ :menu | self browserMenuItemOn: menu; workspaceMenuItemOn: menu; transcriptMenuItemOn: menu; testRunnerMenuItemOn: menu; methodFinderMenuItemOn: menu; messageNamesMenuItemOn: menu. menu addLine. self - monticelloBrowserMenuItemOn: menu; - monticelloConfigurationsMenuItemOn: menu; simpleChangeSorterMenuItemOn: menu; + dualChangeSorterMenuItemOn: menu; + monticelloBrowserMenuItemOn: menu; + monticelloConfigurationsMenuItemOn: menu ; + metacelloMenuItemOn: menu ; + gitInfrastructureMenuItemOn: menu. - dualChangeSorterMenuItemOn: menu. menu addLine. self processBrowserMenuItemOn: menu; preferenceBrowserMenuItemOn: menu; fileListMenuItemOn: menu. ] ]! Item was changed: + (PackageInfo named: 'Morphic') postscript: '"updated Tools menu" + TheWorldMainDockingBar updateInstances'! - (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances'!

10 21

inescapable modal dialog in trunk
by Chris Muller 11 Jan '20

11 Jan '20

1. Make a method in a browser dirty. 2. Click on another method. Squeak displays, "Changes have not been saved, is it okay to cancel those changes?" 3. Click "No". 4. Now try click anywhere else or do anything else in other windows or the desktop. Every click anywhere causes the dialog to reappear until you say "Yes" or cancel the method changes.

7 20

The Inbox: Morphic-nice.1613.mcz
by commits＠source.squeak.org 08 Jan '20

08 Jan '20

Nicolas Cellier uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-nice.1613.mcz ==================== Summary ==================== Name: Morphic-nice.1613 Author: nice Time: 27 December 2019, 10:57:36.813907 pm UUID: 07043442-aa16-4af4-9123-601cd503346a Ancestors: Morphic-mt.1612 Provide smoother scrolling in response to mouse wheel events Instead of delivering the events when delta reaches 120, make this threshold a Preference (minimumWheelDelta) Reminder: 120 represents a single notch for traditional mouse wheel with notches, but trackpads can deliver much smaller deltas Rather than accumulating the deltas into MouseWheelState, do it when we #generateMouseWheelEvent: Indeed, small deltas will come in packets of successive events, and it's more efficient to regroup then, a bit like we do with mouse trails... Also MouseWheelState did ignore time outs (long delays between deltas) and other state changes (buttons/modifiers), which was not ideal. Directly get those states from the raw eventBuffer, like any other mouse event. This requires integration of tose 2 PR: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/461 for Windows https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/462 for OSX and linux Honour larger deltas too in ScrollPane>>#mouseWheel: event handling Honour horizontal mouse wheels too in ScrollPane With patched VM, and following settings, I get a reasonnable scrolling experience on OSX: HandMorph minimumWheelDelta: 20. Smalltalk sendMouseWheelEvents: true. =============== Diff against Morphic-mt.1612 =============== Item was changed: Morph subclass: #HandMorph instanceVariableNames: 'mouseFocus keyboardFocus eventListeners mouseListeners keyboardListeners eventCaptureFilters mouseCaptureFilters keyboardCaptureFilters mouseClickState mouseOverHandler mouseWheelState lastMouseEvent targetOffset damageRecorder cacheCanvas cachedCanvasHasHoles temporaryCursor temporaryCursorOffset hardwareCursor hasChanged savedPatch userInitials lastEventBuffer genieGestureProcessor keyboardInterpreter' + classVariableNames: 'CompositionWindowManager DoubleClickTime DragThreshold EventStats MinimalWheelDelta NewEventRules NormalCursor PasteBuffer SendMouseWheelToKeyboardFocus ShowEvents SynthesizeMouseWheelEvents' - classVariableNames: 'CompositionWindowManager DoubleClickTime DragThreshold EventStats NewEventRules NormalCursor PasteBuffer SendMouseWheelToKeyboardFocus ShowEvents SynthesizeMouseWheelEvents' poolDictionaries: 'EventSensorConstants' category: 'Morphic-Kernel'! !HandMorph commentStamp: '<historical>' prior: 0! The cursor may be thought of as the HandMorph. The hand's submorphs hold anything being carried by dragging. There is some minimal support for multiple hands in the same world.! Item was added: + ----- Method: HandMorph class>>minimumWheelDelta (in category 'preferences') ----- + minimumWheelDelta + <preference: 'Minimal Mouse Wheel Scroll Delta' + categoryList: #(Morphic mouse) + description: 'Answer the minimal scroll increment taken into account + Defaults to 120, corresponding to a single mouse wheel notch. + Use a lower value (20) if wanting smoother scrolling with trackpads.' + type: #Number> + ^MinimalWheelDelta ifNil: [120].! Item was added: + ----- Method: HandMorph class>>minimumWheelDelta: (in category 'preferences') ----- + minimumWheelDelta: anInteger + MinimalWheelDelta := anInteger ifNotNil: [anInteger clampLow: 20 high: 120]! Item was changed: ----- Method: HandMorph>>generateMouseWheelEvent: (in category 'private events') ----- generateMouseWheelEvent: evtBuf "Generate the appropriate mouse wheel event for the given raw event buffer" + | buttons modifiers deltaX deltaY stamp nextEvent | - | buttons modifiers deltaX deltaY stamp | stamp := evtBuf second. stamp = 0 ifTrue: [stamp := Time eventMillisecondClock]. deltaX := evtBuf third. deltaY := evtBuf fourth. + buttons := evtBuf fifth. + modifiers := evtBuf sixth. + [(deltaX abs + deltaY abs < self class minimumWheelDelta) + and: [(nextEvent := Sensor peekEvent) notNil + and: [nextEvent first = evtBuf first + and: [nextEvent fifth = evtBuf fifth + and: [nextEvent sixth = evtBuf sixth] + and: [nextEvent third isZero = evtBuf third isZero "both horizontal or vertical"]]]]] + whileTrue: + ["nextEvent is similar. Remove it from the queue, and check the next." + nextEvent := Sensor nextEvent. + deltaX := deltaX + nextEvent third. + deltaY := deltaY + nextEvent fourth]. - modifiers := evtBuf fifth. - buttons := (modifiers bitShift: 3) bitOr: (lastMouseEvent buttons bitAnd: 7). ^ MouseWheelEvent new setType: #mouseWheel position: self position delta: deltaX@deltaY - direction: 2r0000 buttons: buttons hand: self stamp: stamp! Item was changed: ----- Method: HandMorph>>handleEvent: (in category 'events-processing') ----- handleEvent: unfilteredEvent | filteredEvent | owner ifNil: [^ unfilteredEvent "not necessary but good style -- see Morph >> #handleEvent:"]. self logEvent: unfilteredEvent. "Mouse-over events occur really, really, really often. They are kind of the heart beat of the Morphic UI process." unfilteredEvent isMouseOver ifTrue: [^ self sendMouseEvent: unfilteredEvent]. self showEvent: unfilteredEvent. self sendListenEvents: unfilteredEvent. filteredEvent := self sendFilterEventCapture: unfilteredEvent for: nil. "filteredEvent := unfilteredEvent" " <-- use this to disable global capture filters" filteredEvent wasIgnored ifTrue: [ self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. filteredEvent isWindowEvent ifTrue: [ self sendEvent: filteredEvent focus: nil. self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. filteredEvent isKeyboard ifTrue:[ self sendKeyboardEvent: filteredEvent. self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. filteredEvent isDropEvent ifTrue:[ self sendEvent: filteredEvent focus: nil. self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. filteredEvent isMouse ifFalse: [ self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. " ********** MOUSE EVENT *********** " lastMouseEvent := filteredEvent. "Check for pending drag or double click operations." mouseClickState ifNotNil:[ (mouseClickState handleEvent: filteredEvent from: self) ifFalse:[ "Possibly dispatched #click: or something and will not re-establish otherwise" self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]]. filteredEvent isMouseWheel ifTrue: [ + self class sendMouseWheelToKeyboardFocus + ifFalse: [self sendMouseEvent: filteredEvent] + ifTrue: [self sendEvent: filteredEvent focus: self keyboardFocus clear: [self keyboardFocus: nil]]. - mouseWheelState ifNil: [mouseWheelState := MouseWheelState new]. - mouseWheelState handleEvent: filteredEvent from: self. self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. filteredEvent isMove ifTrue:[ self position: filteredEvent position. self sendMouseEvent: filteredEvent. self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent]. "Issue a synthetic move event if we're not at the position of the event" filteredEvent position = self position ifFalse: [self moveToEvent: filteredEvent]. "Drop submorphs on button events" self hasSubmorphs ifTrue:[self dropMorphs: filteredEvent] ifFalse:[self sendMouseEvent: filteredEvent]. self mouseOverHandler processMouseOver: lastMouseEvent. ^ filteredEvent "not necessary but good style -- see Morph >> #handleEvent:" ! Item was added: + ----- Method: MouseWheelEvent>>setDirection (in category 'initialization') ----- + setDirection + delta x > 0 ifTrue: [self setWheelRight]. + delta x < 0 ifTrue: [self setWheelLeft]. + + delta y > 0 ifTrue: [self setWheelUp]. + delta y < 0 ifTrue: [self setWheelDown].! Item was added: + ----- Method: MouseWheelEvent>>setType:position:delta:buttons:hand:stamp: (in category 'private') ----- + setType: evtType position: evtPos delta: evtDelta buttons: evtButtons hand: evtHand stamp: stamp + type := evtType. + position := evtPos. + buttons := evtButtons. + source := evtHand. + wasHandled := false. + direction := 2r0000. + delta := evtDelta. + timeStamp := stamp. + self setDirection! Item was removed: - Object subclass: #MouseWheelState - instanceVariableNames: 'currentDelta' - classVariableNames: '' - poolDictionaries: '' - category: 'Morphic-Events'! Item was removed: - ----- Method: MouseWheelState>>handleEvent:from: (in category 'event processing') ----- - handleEvent: aMouseWheelEvent from: aHand - "Every 120 units, raise the wheel flags for convenient mouse wheel programming. We choose not to send multiple mouse-wheel events for multiples of 120 because applications can always react to the actual delta values if they want to do more scrolling or zooming." - - | sign | - currentDelta := currentDelta + aMouseWheelEvent wheelDelta. - - sign := currentDelta sign. - currentDelta := currentDelta abs. - - (currentDelta x // 120) > 0 ifTrue: [ - sign x = 1 - ifTrue: [aMouseWheelEvent setWheelRight] - ifFalse: [aMouseWheelEvent setWheelLeft]]. - - (currentDelta y // 120) > 0 ifTrue: [ - sign y = 1 - ifTrue: [aMouseWheelEvent setWheelUp] - ifFalse: [aMouseWheelEvent setWheelDown]]. - - currentDelta := currentDelta \\ 120. - currentDelta := currentDelta * sign. - - "Finally, send the event." - HandMorph sendMouseWheelToKeyboardFocus - ifFalse: [aHand sendMouseEvent: aMouseWheelEvent] - ifTrue: [aHand sendEvent: aMouseWheelEvent focus: aHand keyboardFocus clear: [aHand keyboardFocus: nil]]. - ! Item was removed: - ----- Method: MouseWheelState>>initialize (in category 'initialize-release') ----- - initialize - - super initialize. - currentDelta := 0@0.! Item was changed: ----- Method: ScrollPane>>mouseWheel: (in category 'event handling') ----- mouseWheel: evt + evt isWheelUp ifTrue: [scrollBar scrollUp: (3 * evt wheelDelta y abs // 120 max: 1)]. + evt isWheelDown ifTrue: [scrollBar scrollDown: (3 * evt wheelDelta y abs // 120 max: 1)]. + evt isWheelLeft ifTrue: [hScrollBar scrollUp: (3 * evt wheelDelta x abs // 120 max: 1)]. + evt isWheelRight ifTrue: [hScrollBar scrollDown: (3 * evt wheelDelta x abs // 120 max: 1)].! - evt isWheelUp ifTrue: [scrollBar scrollUp: 3]. - evt isWheelDown ifTrue: [scrollBar scrollDown: 3].!

3 5

The Inbox: Morphic-nice.1614.mcz
by commits＠source.squeak.org 08 Jan '20

08 Jan '20

Nicolas Cellier uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-nice.1614.mcz ==================== Summary ==================== Name: Morphic-nice.1614 Author: nice Time: 29 December 2019, 3:07:59.051586 pm UUID: 003857a5-817d-4dc9-bf15-80c6bc584d51 Ancestors: Morphic-nice.1613 Forgot to remove the mouseWheelState ivar from HandMorph The testNoObsoleteClasses was already failing, but we shall not make it worse... =============== Diff against Morphic-nice.1613 =============== Item was changed: Morph subclass: #HandMorph + instanceVariableNames: 'mouseFocus keyboardFocus eventListeners mouseListeners keyboardListeners eventCaptureFilters mouseCaptureFilters keyboardCaptureFilters mouseClickState mouseOverHandler lastMouseEvent targetOffset damageRecorder cacheCanvas cachedCanvasHasHoles temporaryCursor temporaryCursorOffset hardwareCursor hasChanged savedPatch userInitials lastEventBuffer genieGestureProcessor keyboardInterpreter' - instanceVariableNames: 'mouseFocus keyboardFocus eventListeners mouseListeners keyboardListeners eventCaptureFilters mouseCaptureFilters keyboardCaptureFilters mouseClickState mouseOverHandler mouseWheelState lastMouseEvent targetOffset damageRecorder cacheCanvas cachedCanvasHasHoles temporaryCursor temporaryCursorOffset hardwareCursor hasChanged savedPatch userInitials lastEventBuffer genieGestureProcessor keyboardInterpreter' classVariableNames: 'CompositionWindowManager DoubleClickTime DragThreshold EventStats MinimalWheelDelta NewEventRules NormalCursor PasteBuffer SendMouseWheelToKeyboardFocus ShowEvents SynthesizeMouseWheelEvents' poolDictionaries: 'EventSensorConstants' category: 'Morphic-Kernel'! !HandMorph commentStamp: '<historical>' prior: 0! The cursor may be thought of as the HandMorph. The hand's submorphs hold anything being carried by dragging. There is some minimal support for multiple hands in the same world.!

3 4

Annoying list morph selection/menu click bug
by tim Rowledge 07 Jan '20

07 Jan '20

For some time now I've been occasionally irritated by a bug in the way lists seem to work. When it happens it really grates. It doesn't always seem to happen, which somehow made me sort of ignore it and adapt. Today I actually took a look to see if I was imagining things and perhaps it was always how lists behaved - but no, it is a change since the 4.5 release. I first see the issue in a 4.6 15102 image but I haven't tried any more precise searching as yet. What happens is that after selecting an item in a list - the obvious easy test is in a Browser - I <menu> and the selection is jumped to where the pointer is as I <Menu>. What used to happen - what should happen - is that the selection *stays where I put it*. I selected it for a reason; that being that I wanted it selected. If I move around and hit <Menu> later, with the pointer having moved around a bit, I still want the same thing selected. It's especially annoying when you get a combination of a) having thre menu buttons in the correct order b) a mouse with a sensitive scroll-wheel-middle-button c) the list scrolling madly because your finger moves microscopically as you press the scroll-wheel-middle-button So before I dig into looking for this, does anyone remember anything about this being done deliberately? A preference being changed that might cause it? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: PNG: Pass Noxious Gas

7 13

Debugger Through slow
by Thiede, Christoph 07 Jan '20

07 Jan '20

Hi all, take the following snippet, debug-it and press "Through": SqueakMessageCategoriesHelp asHelpTopic. For me, it makes the debugger hang really long time, as apparently the whole code execution is simulated, searching for the current context (#stepToHome:). "Over", in contrast, is faster by far, calling #completeStep: instead. Can we speed up "Through" in any way? As the button is explained as "Step into a block", we could call #completeStep: internally if the selected message does not contain a block argument, for example. Best, Christoph

3 6

Possible bug in PluggableTextMorph: Selection is reversed when rehovering text
by Christoph Thiede 06 Jan '20

06 Jan '20

Hi, I will quote the bug report from here <https://github.com/MrModder/Autocompletion/pull/25#issuecomment-513546349> : > - Open a workspace window, enter some text > - press shift+left once > - set the keyboard focus to another window > - bring focus back to the Workspace > - press shift+left once again > Instead of selecting two characters, zero characters will be selected The reason is in PluggableTextMorph>>#mouseEnter:, where the following is done: ...textMorph editor selectInterval: selectionInterval... As the selectionInterval is always positive, this operation destroys any editor state where pointIndex < markIndex. I just disabled this section in my image, and in a rush, I could not find out what is missing. What has been the purpose of this snippet? I also see this might be a debatable behavior: On the one hand, the user might be irritated when he is returning to a textmorph after a long time, trying to extend the selection with <shift>Arrow right but the selection is shrinked indead. On the other hand, I have activated the #mouseOverForKeyboardFocus setting (which is basically genius) and find it annoying that the selection behavior changes after repositioning your mouse. Has this ever been debated before? I would welcome your opinions! Best, Christoph -- Sent from: http://forum.world.st/Squeak-Dev-f45488.html

4 6

Wiki pages for screenshots & details about Squeak projects
by tim Rowledge 06 Jan '20

06 Jan '20

Whilst quickly updating the VMMaker swiki page I got lead to the exobox page, and thence the 'Screenshots of Applications created with Squeak' page and the 'Production Squeak' page. Oh my, very out of date and many missing images. If you have or had entries on such pages, please see if you can recover the missing screenshots. If there is news about the products/projects, please add it; if you know of something not listed, please add it ! tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim "Yummy" said Pooh, as he rotated Piglet slowly on the spit.

2 1

[Q][Squeak5.3a][ExternalPackage] FileList class>>#registerFileReader: has been deprecated --> How do I fix this?
by H. Hirzel 06 Jan '20

06 Jan '20

Hello When loading an external package I get the following feedback FileList class>>#registerFileReader: has been deprecated. FileList is not responsible for file reader registration anymore. Use FileServices instead. When I click on 'debug' I get registeredFileReaderClasses self deprecated: 'FileList is not responsible for file reader registration anymore. Use FileServices instead.'. FileReaderRegistry := nil. "wipe it out" ^FileServices registeredFileReaderClasses How do I deal with this? Old code? New code? Regards Hannes

2 1

SystemProgressMorph applyUserInterfaceTheme
by Thiede, Christoph 06 Jan '20

06 Jan '20

Hi all, hi Marcel :-) What is the purpose of the class-side #applyUserInterfaceTheme implementation in SystemProgressMorph? SystemProgressMorph class >> applyUserInterfaceTheme self reset. Given the following snippet: Project current uiManager informUser: 'Foo' during: [ Preferences changeFontSize: 0. self halt] Currently, the SystemProgressMorph has abandoned when a debugger appears. If I remove the class-side method from above, everything works as expected. What are the considerations to hide all progress if the UI theme is changed? Best, Christoph

2 2

← Newer
1
2
3
4
5
6
7
8
...
26
Older →

Jump to page: