Squeak-dev May 2019

squeak-dev@lists.squeakfoundation.org

36 participants
153 discussions

The Trunk: Kernel-nice.1225.mcz
by commits＠source.squeak.org 04 May '19

04 May '19

Nicolas Cellier uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-nice.1225.mcz ==================== Summary ==================== Name: Kernel-nice.1225 Author: nice Time: 4 May 2019, 11:50:07.297369 pm UUID: 02906432-5829-436e-92de-4f1fd552397c Ancestors: Kernel-nice.1224 Fix nthRootRounded: How does it work? To have short notation, say we have the truncated nth root x of y such that: x^n <= y (x+1)^n > y The true root r is somewhere in between r^n = y x <= r < x+1 But is r closer to x or x+1? Let's just check the mid point (x+0.5)^n (x+0.5)^n < y ==> (x+0.5 < r) we must answer x+1 (x+0.5)^n > y ==> (r < x+0.5) we must answer x (x+0.5)^n = y is impossible, the left member of inequality is an irreducible Fraction (odd numerator, even denominator), the right member is an Integer. We eliminate the Fraction denominator to stick with Integer arithmetic and test: (x*2+1)^n < (y << n) It seems like ancient code was testing (x^n + (x+1)^n)/2 < y Gasp, did I write this? =============== Diff against Kernel-nice.1224 =============== Item was changed: ----- Method: Integer>>nthRootRounded: (in category 'mathematical functions') ----- nthRootRounded: aPositiveInteger "Answer the integer nearest the nth root of the receiver." | guess | self = 0 ifTrue: [^0]. self negative ifTrue: [aPositiveInteger even ifTrue: [ ArithmeticError signal: 'Negative numbers don''t have even roots.' ]. ^(self negated nthRootRounded: aPositiveInteger) negated]. guess := self nthRootTruncated: aPositiveInteger. + ^(2 * guess + 1 raisedToInteger: aPositiveInteger) < (self bitShift: aPositiveInteger) - ^self * 2 > ((guess + 1 raisedTo: aPositiveInteger) + (guess raisedTo: aPositiveInteger)) ifTrue: [guess + 1] ifFalse: [guess]!

1 0

The Trunk: KernelTests-nice.362.mcz
by commits＠source.squeak.org 04 May '19

04 May '19

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.362.mcz ==================== Summary ==================== Name: KernelTests-nice.362 Author: nice Time: 4 May 2019, 11:35:49.311657 pm UUID: bfa7db2b-b88d-4b99-bf74-7271520443e6 Ancestors: KernelTests-nice.361 Exhibit a problem with nthRootRounded: which does not round to nearest Integer. =============== Diff against KernelTests-nice.361 =============== Item was added: + ----- Method: IntegerTest>>testNthRootRounded (in category 'tests - mathematical functions') ----- + testNthRootRounded + <timeout: 5 "seconds"> + | d x | + d := ((1 + 2 reciprocal - (1<<30) reciprocal) raisedTo: 1000) floor. "close to 1.5 by default" + x := ((1 + 2 reciprocal + (1<<30) reciprocal) raisedTo: 1000) ceiling. "close to 1.5 by excess" + self assert: (d nthRootTruncated: 1000) equals: 1. + self assert: (x nthRootTruncated: 1000) equals: 1. + self assert: (d nthRootRounded: 1000) equals: 1. + self assert: (x nthRootRounded: 1000) equals: 2.!

1 0

The Inbox: TraitsTests-pre.19.mcz
by commits＠source.squeak.org 04 May '19

04 May '19

Patrick Rein uploaded a new version of TraitsTests to project The Inbox: http://source.squeak.org/inbox/TraitsTests-pre.19.mcz ==================== Summary ==================== Name: TraitsTests-pre.19 Author: pre Time: 28 March 2019, 3:30:48.769796 pm UUID: 2ed07595-23e5-5f41-92ef-17c27ad0a017 Ancestors: TraitsTests-ul.18 Adds a test case for removing traits from a class by simply executing a class creation method without a trait composition. This does currently not yet work. =============== Diff against TraitsTests-ul.18 =============== Item was added: + ----- Method: TraitTest>>expectedFailures (in category 'failures') ----- + expectedFailures + + ^ #(testRemoveTraitBySimpleClassDefinition)! Item was added: + ----- Method: TraitTest>>testRemoveTraitBySimpleClassDefinition (in category 'testing') ----- + testRemoveTraitBySimpleClassDefinition + + | classAv1 classAv2 | + classAv1 := self createClassNamed: #TraitTestMethodClassA superclass: Object uses: T1. + classAv2 := self createClassNamed: #TraitTestMethodClassA superclass: Object. + + self assert: classAv1 == classAv2. + self assert: classAv2 traits isEmpty.! Item was added: + ----- Method: TraitsTestCase>>createClassNamed:superclass: (in category 'utility') ----- + createClassNamed: aSymbol superclass: aClass + | class | + class := aClass + subclass: aSymbol + instanceVariableNames: '' + classVariableNames: '' + poolDictionaries: '' + category: self categoryName. + self createdClassesAndTraits add: class. + ^class!

10 18

The Trunk: Collections-nice.829.mcz
by commits＠source.squeak.org 03 May '19

03 May '19

Nicolas Cellier uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-nice.829.mcz ==================== Summary ==================== Name: Collections-nice.829 Author: nice Time: 3 May 2019, 11:06:11.65639 pm UUID: 695419ed-754d-41ff-8b51-b8715934b1f5 Ancestors: Collections-fn.828 Remove unused digitShiftSum: (since Kernel-nice.1224) =============== Diff against Collections-fn.828 =============== Item was removed: - ----- Method: Interval>>digitShiftSum: (in category 'enumerating') ----- - digitShiftSum: aBlock - "Reconstruct an Integer that has been split in chunks by using shift and add. - Each of my element represent a digitShift, an my step size repreent the digit length of chunks. - The block is evaluated with each digitShift to produce the chunks. - - Algorithm insights: - Let d0,d1,d2,... be the chunks, and s be the bit shift (8*step because digitLength is 8bits) - The naive loop does shift each chunk and accumulate into a sum: - ((d0 + (d1<<s)) + (d2<<s)) + (d3<<s) + ... - The length of accumulator increase at each iteration (1+2+3...) resulting in a cost (size+1)*size/2, or O(size^2) - Note that Horner scheme would be of about same cost - (((... + d3) << s + d2) << s + d1) << s + d0 - (a bit like so called Shlemiel the painter) - If we instead divide and conquer, we add smaller parts (1+1+2+...) resulting into a cost of O(size*log2(size)) - (d0 + (d1<<s)) + ((d2 + (d3<<s)) << s) + ... - However, the divide and conquer split comes with an additionnal cost, so do it only if worth it." - - | sz half offset | - "Naive loop in O(size^2)/2 is best for small size" - (sz := self size) <= 8 ifTrue: [^self inject: 0 into: [:sum :shift | ((aBlock value: shift) bitShift: 8 * shift) + sum]]. - half := sz // 2. - offset := half * step + start. - ^((start to: half - 1 * step + start by: step) digitShiftSum: aBlock) - + (((0 to: self last - offset by: step) digitShiftSum: [:k | aBlock value: offset + k]) bitShift: 8 * offset)!

1 0

The Trunk: KernelTests-nice.361.mcz
by commits＠source.squeak.org 03 May '19

03 May '19

Nicolas Cellier uploaded a new version of KernelTests to project The Trunk: http://source.squeak.org/trunk/KernelTests-nice.361.mcz ==================== Summary ==================== Name: KernelTests-nice.361 Author: nice Time: 3 May 2019, 10:46:16.703499 pm UUID: 8630d99a-ddab-4914-96bf-7f06d1899cee Ancestors: KernelTests-pre.360 Apply refactorings of Kernel-nice.1224 =============== Diff against KernelTests-pre.360 =============== Item was changed: ----- Method: LargePositiveIntegerTest>>testDigitDiv (in category 'tests') ----- testDigitDiv | a b q r qr ap bp | ap := self x23kbits. bp := self x13kbits. + self assert: (ap digitDivSplit: bp) = ((ap digitDiv: bp neg: false) collect: #normalize). - self assert: (ap recursiveDigitDiv: bp) = ((ap primDigitDiv: bp neg: false) collect: #normalize). #(#yourself #negated) do: [:opa | #(#yourself #negated) do: [:opb | a := ap perform: opa. b := bp perform: opb. qr := a digitDiv: b neg: opa ~~ opb. q := qr first normalize. r := qr last normalize. self assert: q * b + r = a. self assert: r abs < b abs. self assert: a positive ==> r positive. self assert: a negative ==> (r negative | r isZero)]] ! Item was changed: ----- Method: LargePositiveIntegerTest>>testFastMultiply (in category 'tests') ----- testFastMultiply | a b ab ap bp | ap := self x92kbits. bp := self x106kbits. #(#yourself #negated) do: [:opa | #(#yourself #negated) do: [:opb | a := ap perform: opa. b := bp perform: opb. ab := a * b. + self assert: (a multiplyByInteger: b) = ab. + self assert: (a digitMultiply: b neg: a negative ~~ b negative) = ab. + self assert: (a digitMul22: b) = ab. + self assert: (a digitMul23: b) = ab. + self assert: (a digitMul33: b) = ab]]! - self assert: (a fastMultiply: b) = ab. - self assert: (a karatsubaTimes: b) = ab. - self assert: (a toom3Times: b) = ab]]! Item was changed: ----- Method: LargePositiveIntegerTest>>testSquared (in category 'tests') ----- testSquared | large ref | large := self x23kbits. ref := large * large. self assert: ref = large squared. + self assert: ref = large squaredByHalf. + self assert: ref = large squaredByThird. + self assert: ref = large squaredByFourth.! - self assert: ref = large squaredKaratsuba. - self assert: ref = large squaredToom3. - self assert: ref = large squaredToom4.!

1 0

The Trunk: Tests-pre.411.mcz
by commits＠source.squeak.org 03 May '19

03 May '19

Patrick Rein uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-pre.411.mcz ==================== Summary ==================== Name: Tests-pre.411 Author: pre Time: 3 May 2019, 4:34:55.658882 pm UUID: 8679cdcb-147d-4246-9cbd-01f00224c140 Ancestors: Tests-pre.410 Adds a simple test case for listing file directory entries and adjusts the tearDown accordingly. =============== Diff against Tests-pre.410 =============== Item was changed: + ----- Method: FileDirectoryTest>>deleteDirectory (in category 'running') ----- - ----- Method: FileDirectoryTest>>deleteDirectory (in category 'tests - create/delete') ----- deleteDirectory + (self myDirectory exists) ifTrue: [self myDirectory recursiveDelete]! - (self myDirectory exists) ifTrue: - [self myDirectory containingDirectory deleteDirectory: self myLocalDirectoryName]! Item was changed: + ----- Method: FileDirectoryTest>>tearDown (in category 'running') ----- - ----- Method: FileDirectoryTest>>tearDown (in category 'resources') ----- tearDown [ self deleteDirectory ] on: Error do: [ :ex | ]! Item was changed: ----- Method: FileDirectoryTest>>testDeleteDirectory (in category 'tests - create/delete') ----- testDeleteDirectory "Test deletion of a directory" | aContainingDirectory preTestItems | aContainingDirectory := self myDirectory containingDirectory. preTestItems := aContainingDirectory fileAndDirectoryNames. + self myAssuredDirectory. - self assert: self myAssuredDirectory exists. aContainingDirectory deleteDirectory: self myLocalDirectoryName. + self + shouldnt: [aContainingDirectory directoryNames includes: self myLocalDirectoryName ] - self shouldnt: - [aContainingDirectory directoryNames - includes: self myLocalDirectoryName ] description: 'Should successfully delete directory.'. + self + should: [preTestItems = aContainingDirectory fileAndDirectoryNames] - self should: - [preTestItems = aContainingDirectory fileAndDirectoryNames] description: 'Should only delete the indicated directory.'. ! Item was added: + ----- Method: FileDirectoryTest>>testListEntries (in category 'tests') ----- + testListEntries + + self myAssuredDirectory createDirectory: 'foobar'. + self myAssuredDirectory createDirectory: 'b'. + self myAssuredDirectory fileNamed: 'test.file' do: [:str | + str << 'test content']. + self + assert: 3 equals: self myAssuredDirectory entries size + description: '#entries should list all contained directory entries'!

1 0

The Trunk: Chronology-Core-cbc.41.mcz
by commits＠source.squeak.org 03 May '19

03 May '19

David T. Lewis uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-cbc.41.mcz ==================== Summary ==================== Name: Chronology-Core-cbc.41 Author: cbc Time: 22 April 2019, 8:58:13.835953 am UUID: 3d8013b6-d58f-004e-8e6b-5a59ed5841e7 Ancestors: Chronology-Core-dtl.40 We have the ability to change the starting day of the week (Week>>startDay:). This change adds #dayOfLocalWeek to DateAndTime and Timespan to return the indexed day of the week based on the altered starting day. Original #dayOfWeek is left as-is along with all other working code. =============== Diff against Chronology-Core-dtl.40 =============== Item was added: + ----- Method: DateAndTime>>dayOfLocalWeek (in category 'ansi protocol') ----- + dayOfLocalWeek + + "Sunday=1, ... , Saturday=7" + + ^ (self julianDayNumber + 2 - Week weekdayStartIndex rem: 7) + 1 + ! Item was added: + ----- Method: Timespan>>dayOfLocalWeek (in category 'ansi protocol') ----- + dayOfLocalWeek + "Answer the day of the week represented by the receiver." + + ^ start dayOfLocalWeek! Item was added: + ----- Method: Week class>>weekdayStartIndex (in category 'squeak protocol') ----- + weekdayStartIndex + ^self indexOfDay: self startDay!

1 0

The Trunk: SqueakSSL-Tests-pre.24.mcz
by commits＠source.squeak.org 02 May '19

02 May '19

Patrick Rein uploaded a new version of SqueakSSL-Tests to project The Trunk: http://source.squeak.org/trunk/SqueakSSL-Tests-pre.24.mcz ==================== Summary ==================== Name: SqueakSSL-Tests-pre.24 Author: pre Time: 2 May 2019, 3:22:08.38663 pm UUID: 024dc8cf-e5d7-4e4b-91ab-09d51d7cdfe9 Ancestors: SqueakSSL-Tests-eem.23 Recategorizes tests and test utility methods in SqueakSSL =============== Diff against SqueakSSL-Tests-eem.23 =============== Item was changed: + ----- Method: SqueakSSLTest>>certName (in category 'fixtures') ----- - ----- Method: SqueakSSLTest>>certName (in category 'setup') ----- certName "Answer the name of the cert to use in tests" ^self class certName! Item was changed: + ----- Method: SqueakSSLTest>>expectedFailures (in category 'failures') ----- - ----- Method: SqueakSSLTest>>expectedFailures (in category 'setup') ----- expectedFailures "If we don't have a cert all the tests fail" SqueakSSL platformName = 'Mac OS' ifTrue:[ "The following tests all need certificate selection to work properly." ^#( testConnectAccept testEncryptDecrypt testMultiFrameDecrypt testSingleByteDecrypt testSplitTlsFrameRead testStreamAccept testStreamConnect testStreamTransfer ) ] ifFalse:[^#()].! Item was changed: + ----- Method: SqueakSSLTest>>hasCertInfo (in category 'fixtures') ----- - ----- Method: SqueakSSLTest>>hasCertInfo (in category 'setup') ----- hasCertInfo "Returns true if we have cert information available" ^self class certName notNil! Item was changed: + ----- Method: SqueakSSLTest>>port (in category 'fixtures') ----- - ----- Method: SqueakSSLTest>>port (in category 'setup') ----- port ^8844! Item was changed: + ----- Method: SqueakSSLTest>>secureSocket (in category 'fixtures') ----- - ----- Method: SqueakSSLTest>>secureSocket (in category 'setup') ----- secureSocket ^SqueakSSL secureSocket! Item was changed: + ----- Method: SqueakSSLTest>>secureSocketStream (in category 'fixtures') ----- - ----- Method: SqueakSSLTest>>secureSocketStream (in category 'setup') ----- secureSocketStream ^SqueakSSL secureSocketStream! Item was changed: + ----- Method: SqueakSSLTest>>setUp (in category 'running') ----- - ----- Method: SqueakSSLTest>>setUp (in category 'setup') ----- setUp "The default setUp" self class ensureValidCert. clientReadQueue := serverWriteQueue := SharedQueue new. serverReadQueue := clientWriteQueue := SharedQueue new. sslClient := SqueakSSL new. sslClient readBlock:[:buffer| | inbuf | inbuf := clientReadQueue next. buffer replaceFrom: 1 to: inbuf size with: inbuf startingAt: 1. inbuf size. ]. sslClient writeBlock:[:buffer :count| clientWriteQueue nextPut: (buffer copyFrom: 1 to: count) ]. sslServer := SqueakSSL new. sslServer certName: self certName. sslServer readBlock:[:buffer| | inbuf | inbuf := serverReadQueue next. buffer replaceFrom: 1 to: inbuf size with: inbuf startingAt: 1. inbuf size. ]. sslServer writeBlock:[:buffer :count| serverWriteQueue nextPut: (buffer copyFrom: 1 to: count) ]. ! Item was changed: + ----- Method: SqueakSSLTest>>tearDown (in category 'running') ----- - ----- Method: SqueakSSLTest>>tearDown (in category 'setup') ----- tearDown "Shut down everything" clientProcess ifNotNil:[clientProcess terminate]. serverProcess ifNotNil:[serverProcess terminate]. sslClient ifNotNil:[sslClient destroy]. sslServer ifNotNil:[sslServer destroy]. !

1 0

The Trunk: NetworkTests-pre.58.mcz
by commits＠source.squeak.org 02 May '19

02 May '19

Patrick Rein uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-pre.58.mcz ==================== Summary ==================== Name: NetworkTests-pre.58 Author: pre Time: 2 May 2019, 3:20:22.414906 pm UUID: 7fac5835-3b19-454a-91e2-2a091cc900e0 Ancestors: NetworkTests-pre.57 Improves two test cases for MailMessages relying on old DateAndTime behavior. =============== Diff against NetworkTests-pre.57 =============== Item was changed: ----- Method: MailMessageTest>>testDateAndDateString (in category 'tests') ----- testDateAndDateString | newMail | newMail := MailMessage from: 'From: Al Gore <vicepresident(a)whitehouse.gov> To: White House Transportation Coordinator <transport(a)whitehouse.gov> Subject: [Map of a country] Date: Mon, 12 Aug 2002 17:42:00 +0000 there is a country map in this mail somewhere'. + self assert: (DateAndTime year: 2002 month: 8 day: 12 hour: 17 minute: 42 second: 0 offset: Timespan defaultOffset) equals: newMail date. - self assert: (DateAndTime year: 2002 month: 8 day: 12 hour: 17 minute: 42) equals: newMail date. self assert: '8/12/02' equals: newMail dateString.! Item was changed: ----- Method: MailMessageTest>>testDateStampFractionalSecondFormatting (in category 'tests') ----- testDateStampFractionalSecondFormatting + self + assert: (MailMessage dateStamp: (DateAndTime year: 1901 month: 1 day: 1 hour: 0 minute: 0 second: 1.234 offset: Timespan defaultOffset)) + equals: 'Tue, 1 Jan 1901 00:00:01' - self assert: (MailMessage dateStamp: (DateAndTime fromSeconds: 1.234)) - = 'Tue, 1 Jan 1901 00:00:01' description: 'RFC822 (and RFC2822) forbids non-integer seconds in dates'!

1 0

The Trunk: NetworkTests-pre.57.mcz
by commits＠source.squeak.org 02 May '19

02 May '19

Patrick Rein uploaded a new version of NetworkTests to project The Trunk: http://source.squeak.org/trunk/NetworkTests-pre.57.mcz ==================== Summary ==================== Name: NetworkTests-pre.57 Author: pre Time: 2 May 2019, 3:10:21.137906 pm UUID: 933a4b0f-4442-1c4f-91ce-f1a8730f2a43 Ancestors: NetworkTests-pre.56 Adds a number of new tests for the MIMEDocument class. =============== Diff against NetworkTests-pre.56 =============== Item was added: + ----- Method: MIMEDocumentTest>>testCharset (in category 'tests') ----- + testCharset + + | document | + document := MIMEDocument contentType: 'text/plain;charset=utf-8' content: self utf8String. + self assert: 'utf-8' equals: document charset. ! Item was added: + ----- Method: MIMEDocumentTest>>testContentType (in category 'tests') ----- + testContentType + + | document | + document := MIMEDocument contentType: 'text/plain;charset=utf-8' content: self utf8String. + self assert: 'text/plain' equals: document contentType. ! Item was added: + ----- Method: MIMEDocumentTest>>testMainAndSubType (in category 'tests') ----- + testMainAndSubType + + | document | + document := MIMEDocument contentType: 'text/plain' content: self utf8String. + self assert: 'text' equals: document mainType. + self assert: 'plain' equals: document subType.! Item was added: + ----- Method: MIMEDocumentTest>>testMultipartDocument (in category 'tests') ----- + testMultipartDocument + + | document | + document := MIMEDocument newMultipart. + self assert: 'multipart/mixed' equals: document contentType. ! Item was added: + ----- Method: MIMEDocumentTest>>testParameterizedContentType (in category 'tests') ----- + testParameterizedContentType + + | document | + document := MIMEDocument contentType: 'text/plain;charset=utf-8' content: self utf8String. + self assert: 'text/plain;charset=utf-8' equals: document parameterizedContentType. !

1 0

Jump to page: