Squeak-dev July 2019

squeak-dev@lists.squeakfoundation.org

44 participants
160 discussions

The Trunk: Morphic-mt.1491.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1491.mcz ==================== Summary ==================== Name: Morphic-mt.1491 Author: mt Time: 11 July 2019, 7:43:26.133838 am UUID: 8e7d61cb-067a-d145-a86e-3484bfb38617 Ancestors: Morphic-cmfcmf.1490 Replaces one use of Symbol class >> #lookup: with the more common (i.e., more senders) idiom Symbol class >> #hasInterned:ifTrue:. =============== Diff against Morphic-cmfcmf.1490 =============== Item was changed: ----- Method: SearchBar>>smartSearch:in: (in category 'searching') ----- smartSearch: text in: morph "Take the user input and perform an appropriate search" | input newContents | self removeResultsWidget. input := text asString ifEmpty:[^self]. self class useSmartSearch ifFalse: [^ ToolSet default browseMessageNames: input]. "If it is a global or a full class name, browse that class." (Smalltalk bindingOf: input) ifNotNil:[:assoc| | global | global := assoc value. ^ToolSet browse: (global isBehavior ifTrue:[global] ifFalse:[global class]) selector: nil]. "If it is a symbol and there are implementors of it, browse those implementors." + Symbol hasInterned: input ifTrue: [:selector | - (Symbol lookup: input) ifNotNil: [:selector | (SystemNavigation new allImplementorsOf: selector) ifNotEmpty:[:list| ^SystemNavigation new browseMessageList: list name: 'Implementors of ' , input]]. "If it starts uppercase, browse classes if any. Otherwise, just search for messages." input first isUppercase ifTrue: [ (UIManager default classFromPattern: input withCaption: '') ifNotNil:[:aClass| ^ToolSet browse: aClass selector: nil] ifNil: [ newContents := input, ' -- not found.'. self searchTerm: newContents. self selection: (input size+1 to: newContents size). self currentHand newKeyboardFocus: morph textMorph. ^ self]] ifFalse: [ ToolSet default browseMessageNames: input].!

3 6

The Trunk: System-mt.1069.mcz
by commits＠source.squeak.org 12 Jul '19

12 Jul '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1069.mcz ==================== Summary ==================== Name: System-mt.1069 Author: mt Time: 11 July 2019, 9:21:36.166354 am UUID: 27227430-c08f-3c47-b9fd-b646e7f948b6 Ancestors: System-mt.1068 Fixes minor regression in suggestedTypeNames. That is. 'someMorphThing' should also yield 'MorphThing', not just 'Morph' and 'Thing'. =============== Diff against System-mt.1068 =============== Item was changed: ----- Method: String>>suggestedTypeNames (in category '*system') ----- suggestedTypeNames ^ Array streamContents: [:stream | self findFeatureIndicesDo: [:start :end | (self at: start) isUppercase ifTrue: [ stream nextPut: (self copyFrom: start to: end). + end ~= self size ifTrue: [ + stream nextPut: (self copyFrom: start to: self size) withBlanksTrimmed]. "Often, argument names that refer to Collections end in the letter s, which can cause the suggested type-name to not be found. Account for this." (self at: end) = $s ifTrue: [ stream nextPut: (self copyFrom: start to: end -1)]]]].!

3 2

Symbol > OneCharacterSymbols
by Marcel Taeumel 12 Jul '19

12 Jul '19

Hi, there. Can we safely remove the class variable "OneCharacterSymbols" in Symbol? Best, Marcel

3 2

The Inbox: Collections-mt.840.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

A new version of Collections was added to project The Inbox: http://source.squeak.org/inbox/Collections-mt.840.mcz ==================== Summary ==================== Name: Collections-mt.840 Author: mt Time: 11 July 2019, 5:44:50.457612 pm UUID: ce7e6999-68aa-a642-9fda-d74f42b3233b Ancestors: Collections-mt.839 Propose more readable symbol-lookup interface to (1) replace #hasInterned:ifTrue: and (2) avoid ifNil-checks in plain #lookup: use. Interface is inspired by Collection >> #detect:ifFound:ifNone:. =============== Diff against Collections-mt.839 =============== Item was changed: ----- Method: Symbol class>>lookup: (in category 'instance creation') ----- lookup: aStringOrSymbol + ^ self lookup: aStringOrSymbol ifFound: [:symbol | symbol] ifNone: nil! - | originalNewSymbols originalSymbolTable | - originalNewSymbols := NewSymbols. - originalSymbolTable := SymbolTable. - ^(originalNewSymbols like: aStringOrSymbol) ifNil: [ - originalSymbolTable like: aStringOrSymbol ]! Item was added: + ----- Method: Symbol class>>lookup:ifFound: (in category 'instance creation') ----- + lookup: aStringOrSymbol ifFound: aBlock + + ^ self lookup: aStringOrSymbol ifFound: aBlock ifNone: nil + ! Item was added: + ----- Method: Symbol class>>lookup:ifFound:ifNone: (in category 'instance creation') ----- + lookup: aStringOrSymbol ifFound: foundBlock ifNone: exceptionBlock + + | originalNewSymbols originalSymbolTable | + originalNewSymbols := NewSymbols. + originalSymbolTable := SymbolTable. + ^ (originalNewSymbols like: aStringOrSymbol) + ifNotNil: [:symbol | foundBlock value: symbol] + ifNil: [(originalSymbolTable like: aStringOrSymbol) + ifNotNil: [:symbol | foundBlock value: symbol] + ifNil: [exceptionBlock value]]! Item was added: + ----- Method: Symbol class>>lookup:ifNone: (in category 'instance creation') ----- + lookup: aStringOrSymbol ifNone: exceptionBlock + + ^ self lookup: aStringOrSymbol ifFound: [:symbol | symbol] ifNone: exceptionBlock!

1 0

The Trunk: Morphic-mt.1492.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1492.mcz ==================== Summary ==================== Name: Morphic-mt.1492 Author: mt Time: 11 July 2019, 10:57:02.027354 am UUID: b06d3a7a-19d0-c243-9a9a-ad14c6cc7106 Ancestors: Morphic-mt.1491 Improves clean-up code of Etoys' standard scripting system. =============== Diff against Morphic-mt.1491 =============== Item was changed: ----- Method: StandardScriptingSystem class>>cleanUp: (in category 'class initialization') ----- cleanUp: agressive "Clean up unreferenced players. If agressive, reinitialize and nuke players" self removeUnreferencedPlayers. agressive ifTrue:[ References keys do: [:k | References removeKey: k]. + ClassVarNamesInUse := nil. self initialize. ].!

1 0

The Trunk: Tools-mt.852.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.852.mcz ==================== Summary ==================== Name: Tools-mt.852 Author: mt Time: 11 July 2019, 10:56:16.891354 am UUID: f66c189d-541b-5742-8032-4bd3df1a4e9e Ancestors: Tools-mt.851 Adds clean-up code for MethodFinder. =============== Diff against Tools-mt.851 =============== Item was added: + ----- Method: MethodFinder class>>cleanUp: (in category 'class initialization') ----- + cleanUp: aggressive + + Approved := nil. + AddAndRemove := nil. + Blocks := nil.!

1 0

The Trunk: Tools-mt.851.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.851.mcz ==================== Summary ==================== Name: Tools-mt.851 Author: mt Time: 11 July 2019, 9:58:05.941354 am UUID: 1bc52807-ebb1-3640-b47c-e4219e085080 Ancestors: Tools-eem.850 Fixes "explore pointers" and "chase pointers" for CompiledCode. Migrates the unused #explorerStringFor: (from 2018) to #asString. Seems interesting to also see the object hash besides the member name. Not sure why this was put into Trunk back then. =============== Diff against Tools-eem.850 =============== Item was added: + ----- Method: PointerExplorerWrapper>>asString (in category 'converting') ----- + asString + + ^ self object identityHash asString, ': ', super asString.! Item was removed: - ----- Method: PointerExplorerWrapper>>explorerStringFor: (in category 'converting') ----- - explorerStringFor: anObject - - ^ anObject identityHash asString, ': ', (super explorerStringFor: anObject).! Item was changed: ----- Method: PointerExplorerWrapper>>memberNameFrom:to: (in category 'accessing') ----- memberNameFrom: aParent to: aChild 1 to: aParent class instSize do: [ :instVarIndex | (aParent instVarAt: instVarIndex) == aChild ifTrue: [ ^ '''', (aParent class instVarNameForIndex: instVarIndex), '''' ]]. + + "This covers compiled methods and compiled blocks." + aParent isCompiledCode ifTrue: [ + 1 to: aParent numLiterals do: [ :index | + (aParent literalAt: index) == aChild + ifTrue: [^ 'literal', index asString]]]. + "This also covers arrays" 1 to: aParent basicSize do: [ :index | (aParent basicAt: index) == aChild ifTrue: [^ index asString]]. ^ '???'!

1 0

The Inbox: ToolBuilder-Kernel-mt.125.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

A new version of ToolBuilder-Kernel was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Kernel-mt.125.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-mt.125 Author: mt Time: 11 July 2019, 8:50:30.487838 am UUID: 3f3a21f8-a141-734f-8aed-f0c21aff22b9 Ancestors: ToolBuilder-Kernel-mt.124 Updates the search for class names using the new find-features feature on strings. Find WeakIdentityKeyDictionary (in a small list of results) with any of the following patterns: WKD Weak*Dict* WeakDict WeakIdentityKeyDictionary =============== Diff against ToolBuilder-Kernel-mt.124 =============== Item was changed: ----- Method: UIManager>>classOrTraitFrom:pattern:label: (in category 'system introspecting') ----- classOrTraitFrom: environment pattern: pattern label: label + "Given a pattern and an environment, try to find a class or trait using several strategies: + - EXACT: If there is a class or trait whose name exactly given by pattern, return it. + - UPPER: If the pattern is upper-case only, find camel-case letters with that sequence. + - WILD: Try the pattern as-is for regular wild-card search. + - FEATURE: Split patterns at feature boundaries and insert wild cards between. + - FUZZY: Split patterns at feature boundaries BUT treat each feature as a full class name. + If there is only one class or trait in the given environment whose name matches pattern, return it. Otherwise, put up a menu offering the names of all classes that match pattern, and return the class chosen, else nil if nothing chosen. - "If there is a class or trait whose name exactly given by pattern, return it. - If there is only one class or trait in the given environment whose name matches pattern, return it. - Otherwise, put up a menu offering the names of all classes that match pattern, and return the class chosen, else nil if nothing chosen. - This method ignores separator characters in the pattern" + !!!! In any case, separator characters in the pattern are ignored." + + | toMatch potentialNames names selectedIndex | + + "If there's a class or trait named as pattern, then return it." + (environment classOrTraitNamed: pattern) ifNotNil: [:classOrTrait | ^ classOrTrait]. + + "Validate pattern." - | toMatch potentialNames names exactMatch lines reducedIdentifiers selectedIndex | toMatch := pattern copyWithoutAll: Character separators. + toMatch := toMatch asLowercase copyWithout: $.. toMatch ifEmpty: [ ^nil ]. + + "Fetch search space." + names := OrderedCollection new. + potentialNames := environment classAndTraitNames asOrderedCollection. + + "Try uppercase-only patterns for patterns such as 'WKD' to find 'WeakIdentityKeyDictionary' etc." + names ifEmpty: [ + (pattern allSatisfy: [:char | char isUppercase]) ifTrue: [ + potentialNames do: [:each | + | patternStream | + patternStream := pattern readStream. + each detect: [:char | + (patternStream atEnd not and: [patternStream peek = char]) + ifTrue: [ + patternStream next. + patternStream atEnd + ifTrue: [names add: each. true "Match!!"] + ifFalse: [false "Not yet..."]] + ifFalse: [false "No match..."] ] ifNone: [] ] ]]. + + "Try wildcard search for patterns such as 'Weak*Dict*' to find 'WeakIdentityKeyDictionary' etc." + names ifEmpty: [ + names := potentialNames select: [ :each | toMatch match: each ]]. - "If there's a class or trait named as pattern, then return it." - Symbol hasInterned: pattern ifTrue: [ :symbol | - environment at: symbol ifPresent: [ :maybeClassOrTrait | - ((maybeClassOrTrait isKindOf: Class) or: [ - maybeClassOrTrait isTrait ]) - ifTrue: [ ^maybeClassOrTrait ] ] ]. - "No exact match, look for potential matches." - toMatch := pattern asLowercase copyWithout: $.. - potentialNames := (environment classAndTraitNames) asOrderedCollection. - names := pattern last = $. "This is some old hack, using String>>#match: may be better." - ifTrue: [ potentialNames select: [ :each | each asLowercase = toMatch ] ] - ifFalse: [ - potentialNames select: [ :each | - each includesSubstring: toMatch caseSensitive: false ] ]. - exactMatch := names detect: [ :each | each asLowercase = toMatch ] ifNone: [ nil ]. - lines := OrderedCollection new. - exactMatch ifNotNil: [ lines add: 1 ]. - "Also try some fuzzy matching." - reducedIdentifiers := pattern suggestedTypeNames select: [ :each | - potentialNames includes: each ]. - reducedIdentifiers ifNotEmpty: [ - names addAll: reducedIdentifiers. - lines add: 1 + names size + reducedIdentifiers size ]. - "Let the user select if there's more than one possible match. This may give surprising results." - names size = 0 ifTrue: [^ nil "nothing matches"]. + "Try feature-based search for patterns such as 'WeakDict' to find 'WeakIdentityKeyDictionary' etc." + names ifEmpty: [ + toMatch := pattern copyWithoutAll: '.*#'. + toMatch findFeatures in: [:features | + "1) Insert wildcards between features and at the end." + toMatch := (features joinSeparatedBy: '*'), '*'. + names := potentialNames select: [ :each | toMatch match: each ]. + names ifEmpty: [ + "2) Insert wildcards before, between, and after features." + toMatch := '*', (features joinSeparatedBy: '*'), '*'. + names := potentialNames select: [ :each | toMatch match: each ] ]] ]. + + "Try some fuzzy matching." + names addAll: (pattern suggestedTypeNames select: [ :each | potentialNames includes: each ]). + + "Still no match?" + names ifEmpty: [ ^ nil ]. + + "Let the user select if there's more than one possible match. This may give surprising results." selectedIndex := names size = 1 ifTrue: [ 1 ] + ifFalse: [ self chooseFrom: names title: label ]. - ifFalse: [ - exactMatch ifNotNil: [ names addFirst: exactMatch ]. - self chooseFrom: names lines: lines title: label ]. selectedIndex = 0 ifTrue: [ ^nil ]. ^environment at: (names at: selectedIndex) asSymbol!

2 1

The Trunk: System-mt.1068.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1068.mcz ==================== Summary ==================== Name: System-mt.1068 Author: mt Time: 11 July 2019, 8:46:30.024838 am UUID: e2fe883c-8353-bf4d-8921-ba296fa973bb Ancestors: System-cmm.1067 Use new find-features feature to implement #suggestedTypeNames. =============== Diff against System-cmm.1067 =============== Item was changed: ----- Method: String>>suggestedTypeNames (in category '*system') ----- suggestedTypeNames + + ^ Array streamContents: [:stream | + self findFeatureIndicesDo: [:start :end | + (self at: start) isUppercase ifTrue: [ + stream nextPut: (self copyFrom: start to: end). + "Often, argument names that refer to Collections end in the letter s, which can cause the suggested type-name to not be found. Account for this." + (self at: end) = $s ifTrue: [ + stream nextPut: (self copyFrom: start to: end -1)]]]].! - ^ Array streamContents: - [ : stream | - self withIndexDo: - [ : eachChar : index | - eachChar isUppercase ifTrue: - [ stream nextPut: - (self - copyFrom: index - to: self size) withBlanksTrimmed. - "Often, argument names that refer to Collections end in the letter s, which can cause the suggested type-name to not be found. Account for this." - self last = $s - ifTrue: - [ stream nextPut: - (self - copyFrom: index - to: self size-1) withBlanksTrimmed ] ] ] ]!

1 0

The Trunk: CollectionsTests-mt.313.mcz
by commits＠source.squeak.org 11 Jul '19

11 Jul '19

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-mt.313.mcz ==================== Summary ==================== Name: CollectionsTests-mt.313 Author: mt Time: 5 July 2019, 4:55:01.111089 pm UUID: a8af1eda-b723-2940-8838-912b24df886a Ancestors: CollectionsTests-pre.312 Adds tests for Collections-mt.839. =============== Diff against CollectionsTests-pre.312 =============== Item was added: + ----- Method: StringTest>>testFindFeatures (in category 'tests - tokenizing') ----- + testFindFeatures + + { + "input . expected features" + 'camelCase' . #('camel' 'Case'). + 'UPPERCase' . #('UPPER' 'Case'). + 'MyModel55' . #('My' 'Model' '55'). + '5 <= 4' . #('5' '<=' '4'). + '[state := 2]' . #('[' 'state' ':=' '2' ']'). + } pairsDo: [:input :features | + | output | + output := features readStream. + input findFeatureIndicesDo: [:start :end | + self + assert: output next + equals: (input copyFrom: start to: end)]].!

1 0

Jump to page: