Squeak-dev July 2019

squeak-dev@lists.squeakfoundation.org

44 participants
160 discussions

The Inbox: Collections-nice.825.mcz
by commits＠source.squeak.org 16 Sep '19

16 Sep '19

Nicolas Cellier uploaded a new version of Collections to project The Inbox: http://source.squeak.org/inbox/Collections-nice.825.mcz ==================== Summary ==================== Name: Collections-nice.825 Author: nice Time: 7 April 2019, 11:10:11.564693 pm UUID: c9836c60-9acc-45eb-83b2-851f147b70ca Ancestors: Collections-nice.824 Try to improve some Interval of Float Behavior. - change #last so that it agrees with (self at: self size) Note that last behavior slightly changes for empty Interval: (3 to: 0) last is now 2 instead of 0 previously. I don't know of any code impacted, but it's not a completely neutral change Note: this solves 2 out of the 3 failures of #testIntervalOfFloatLast... The last element might still overshoot the prescribed upper bound. I can also fix it, but implementation of #last is getting overkill. - implement a ReversedInterval that lazily reverse an Interval of Float, and resolves #testIntervalOfFloatReversed. The alternative would be resorting to an Array... - renounce fuzzy inclusion test. As exhibited by #testSurprisingFuzzyInclusionBehavior, it creates more weirdness than it tries to solve. There will be two more test failing, asserting this fuzzy inclusion, but we can later change them. =============== Diff against Collections-nice.824 =============== Item was changed: ----- Method: Interval>>indexOf:startingAt: (in category 'accessing') ----- indexOf: anElement startingAt: startIndex "startIndex is an positive integer, the collection index where the search is started." - "during the computation of val , floats are only used when the receiver contains floats" + | index | - | index val | (self rangeIncludes: anElement) ifFalse: [ ^0 ]. + index := (anElement - start / step) rounded + 1. - val := anElement - self first / self increment. - val isFloat - ifTrue: [ - (val - val rounded) abs * 100000000 < 1 ifFalse: [ ^0 ]. - index := val rounded + 1 ] - ifFalse: [ - val isInteger ifFalse: [ ^0 ]. - index := val + 1 ]. - "finally, the value of startIndex comes into play:" (index between: startIndex and: self size) ifFalse: [ ^0 ]. + (self at: index) = anElement ifFalse: [ ^0 ]. ^index! Item was changed: ----- Method: Interval>>last (in category 'accessing') ----- last "Refer to the comment in SequenceableCollection|last." + ^start + (step * (self size - 1))! - ^stop - (stop - start \\ step)! Item was changed: ----- Method: Interval>>reversed (in category 'converting') ----- reversed self isEmpty ifTrue: [^stop to: start by: step negated]. + (start isFraction and: [step isFraction]) ifFalse: [^ReversedInterval newFrom: self]. ^self last to: start by: step negated! Item was added: + SequenceableCollection subclass: #ReversedInterval + instanceVariableNames: 'original' + classVariableNames: '' + poolDictionaries: '' + category: 'Collections-Sequenceable'! + + !ReversedInterval commentStamp: 'nice 4/6/2019 16:30' prior: 0! + A ReversedInterval is an Interval reversed. + An Interval reversed is generally an Interval, except when made of Float. + This is because Float arithmetic does not guarantee reversible operations. + + Instead of transforming the reversed Float Interval into an Array, I keep a lazier and cheaper representation. + I can even pretend being an Interval myself. As long as I quake like a duck... + + Instance Variables + original: <Interval> + + original + - the Interval being reversed + ! Item was added: + ----- Method: ReversedInterval class>>newFrom: (in category 'as yet unclassified') ----- + newFrom: aCollection + "Answer an instance of me containing the same elements as aCollection, reversed." + + aCollection isInterval ifTrue: [^self basicNew setOriginal: aCollection]. + ^(Interval newFrom: aCollection) reversed! Item was added: + ----- Method: ReversedInterval>>+ (in category 'arithmetic') ----- + + aNumber + ^(original + aNumber) reversed! Item was added: + ----- Method: ReversedInterval>>- (in category 'arithmetic') ----- + - aNumber + ^(original - aNumber) reversed! Item was added: + ----- Method: ReversedInterval>>= (in category 'comparing') ----- + = anObject + ^ self == anObject + or: [anObject class = self class + and: [original = anObject reversed]]! Item was added: + ----- Method: ReversedInterval>>at: (in category 'accessing') ----- + at: anInteger + ^original at: original size + 1 - anInteger! Item was added: + ----- Method: ReversedInterval>>copyFrom:to: (in category 'copying') ----- + copyFrom: startIndex to: stopIndex + (startIndex = 1 and: [stopIndex = self size]) ifTrue: [^self]. + stopIndex < startIndex ifTrue: [^self copyEmpty]. + ^((self at: stopIndex) to: (self at: startIndex) by: original increment) reversed! Item was added: + ----- Method: ReversedInterval>>do: (in category 'enumerating') ----- + do: aBlock + original reverseDo: aBlock! Item was added: + ----- Method: ReversedInterval>>hash (in category 'comparing') ----- + hash + ^original hash bitXor: SmallInteger maxVal! Item was added: + ----- Method: ReversedInterval>>isEmpty (in category 'testing') ----- + isEmpty + ^self size = 0! Item was added: + ----- Method: ReversedInterval>>printOn: (in category 'printing') ----- + printOn: aStream + aStream + nextPut: $(; + print: original; + nextPut: $); + space; + nextPutAll: #reversed! Item was added: + ----- Method: ReversedInterval>>reverseDo: (in category 'enumerating') ----- + reverseDo: aBlock + original do: aBlock! Item was added: + ----- Method: ReversedInterval>>reversed (in category 'converting') ----- + reversed + ^original! Item was added: + ----- Method: ReversedInterval>>setOriginal: (in category 'private') ----- + setOriginal: anInterval + original := anInterval! Item was added: + ----- Method: ReversedInterval>>size (in category 'accessing') ----- + size + ^original size! Item was added: + ----- Method: ReversedInterval>>sorted (in category 'sorting') ----- + sorted + original increment > 0 ifTrue: [^original]. + ^self! Item was added: + ----- Method: ReversedInterval>>species (in category 'private') ----- + species + + ^original species! Item was added: + ----- Method: ReversedInterval>>storeOn: (in category 'printing') ----- + storeOn: aStream + aStream + nextPut: $(; + store: original; + nextPut: $); + space; + nextPutAll: #reversed! Item was added: + ----- Method: ReversedInterval>>sum (in category 'accessing') ----- + sum + ^original sum!

6 8

Towards a more flexible CMD+Dot ...
by Marcel Taeumel 30 Aug '19

30 Aug '19

Hi, there. Please find attached a changeset. It represents a quick prototype to make the CMD+Dot command more powerful. One might extend it to provide user-friendly, domain-specific clean-up or restarts of applications. Best, Marcel

7 8

swiki source suited to recent Squeaks
by tim Rowledge 24 Aug '19

24 Aug '19

I swear I've asked this before but a quick google didn't find anything, so forgive any duplication. Do we have a swiki package suited to recent (preferably current ) Squeak? The only trace I see evidence of is a very, very, old package in squeakmap, intended for 3.6 with KomService & KommHTTPServer. Surely there is something newer than 2005 out there? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Littergators resolve disputes about rubbish

7 39

Re: [squeak-dev] Proposal: Morphs in Text
by karl ramberg 22 Aug '19

22 Aug '19

I'm a little late here. TextMorph does not really need TextAnchor I think. You can just drop morphs on the text and select avoid occlusions in the menu. What are the use of text anchors instead just dropped in morphs ? I filed in TextAnchorPlacement change set and it interferes somewhat with the avoid occlusions functions. Best, Karl On Fri, Jun 28, 2019 at 4:42 PM <patrick.rein(a)hpi.uni-potsdam.de> wrote: > Hi everyone, > > please find attached a new version of the change including an improved > protocol for setting the alignment added by Chris (basically as discussed > below). :) > > Bests > Patrick > > >Hi Chris, > > > >thanks for the recommendations! > > > >>The only thing that gave me pause was that API for #verticalAlignment:. > Initially, I just saw the selector and thought about it the same as the API > for regular horizontal text alignment (e.g., #left, #center, #right, > justified), and so tried: > >> self verticalAlignment: #bottom > >>but this informed me that this single-argument selector is actually > looking for two arguments. That's some great flexibility that I didn't > even consider, but I wonder whether this detracts from the usability of the > common cases: > >> #bottom, expected to do what #(#bottom #bottom) does, #center, to > do what, uh, #(#middle #middle) does, and #top, would do what, #top #top > does. > >>#verticalAlignment: handle the above, while #verticalAlignmentMorph: and > #verticalAlignmentLine: could be used for advanced customizations. Even > once I figured out it wanted a two-element Array for input, I had to go > back look at the method to remind myself which is first and which is > second. Separate attributes would be more readable. > > > >That is a good point. I myself had some difficulties remembering which > way they have to go... I have added a convenience case which now allows for > just sending a symbol and the method takes care of converting it to the > array internally (so #top results in #(top top)). > > > >>Lastly, #middle vs. #center. #center is what we have _everywhere_ to > refer to geometric centers, all over the image, including even for > horizontal text-alignment. The only #middle in the whole image relates to > a Collection element access. Could we use #center? > > > >Yes, that makes sense :) I renamed #middle to #center. > > > >The new changeset includes these changes. > > > >Bests > >Patrick > > > > > >["TextAnchorPlacement.cs"] > > > > > >[TextAnchorPlacement.cs] > ["TextAnchorPlacement.cs"] >

9 20

Re: [squeak-dev] The Trunk: Collections-pre.822.mcz
by Chris Muller 21 Aug '19

21 Aug '19

My main objection is about growing the "mutator" nomenclature further instead of trimming it back. I'm working on a GraphQL framework. GraphQL has a first-class notion of "mutations". https://graphql.org/learn/queries/ Currently, we have almost zero mention of the word "mutator" in the image. I would appreciate if, instead of germinating the overloading the word, we uproot it and keep the nomenclature for this Smalltalk tooling confined to "getter" and "setter" that we have now. So, instead of #asMutator and #isMutator, how about #asSimpleSetter and #isSimpleSetter? We can end up removing a method instead of adding one. We already have many existing methods which are dealing with this conversion, all of which use the traditional Smalltalk / developer linguisitic of "setter". Browsing through all the "setter" nomenclature we have in a message names browser, including Utilities class>>#getterSelectorFor: Utilities class>>#setterSelectorFor: Utilities class>>#simpleSetterFor: which instruct Etoys users to use existing methods on String, #asSetterSelector or #asSimpleSetter. Of special note is SyntaxMorph>>#isStandardSetterKeyword: which, by its use of a utility-method implementation, acknowledges that this behavior is _application-specific_. I, myself, would just write: someSelector asSimpleSetter = someSelector "same as isMutator / isSimpleSetter" instead of #isSimpleSetter, but can appreciate both styles. They both better avoid the awkwardness of "mutator" as a general, reliable behavior when: #at: isMutator "true" while #at:put: isMutator "false" Best, Chris On Thu, Mar 21, 2019 at 1:16 AM <patrick.rein(a)hpi.uni-potsdam.de> wrote: > > Which one are you refering to? I only see Symbol>>#asMutator in Collections in the method category converting. It is also used in a few other places beyond generating instance variable accessors. > > Bests, > Patrick > > >#asMutator: is for "generate instVar accessors" code-generation, and > >that's why it's in the Tools package. > > > >IMHO, if #isMutator belongs anywhere, it isn't in Collections. > > > >Regards, > > Chris > > > > > > > >On Wed, Mar 20, 2019 at 3:08 PM Chris Muller <asqueaker(a)gmail.com> wrote: > >> > >> Assuming a single-keyword is a mutator? Object>>#at: is not a > >> mutator. #indexOf: is not. #first: is not. Obviously many more.. > >> > >> If API balance is the goal of this, perhaps #asMutator should be > >> removed instead. This feels application-specific... > >> > >> On Wed, Mar 20, 2019 at 2:05 PM <commits(a)source.squeak.org> wrote: > >> > > >> > Patrick Rein uploaded a new version of Collections to project The Trunk: > >> > http://source.squeak.org/trunk/Collections-pre.822.mcz > >> > > >> > ==================== Summary ==================== > >> > > >> > Name: Collections-pre.822 > >> > Author: pre > >> > Time: 20 March 2019, 8:05:20.383677 pm > >> > UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc > >> > Ancestors: Collections-dtl.821 > >> > > >> > Adds #isMutator to Symbol which is analogous to asMutator. > >> > > >> > =============== Diff against Collections-dtl.821 =============== > >> > > >> > Item was added: > >> > + ----- Method: Symbol>>isMutator (in category 'testing') ----- > >> > + isMutator > >> > + > >> > + ^ self isKeyword and: [self numArgs = 1]! > >> > > >> > > > >

6 12

The Inbox: Tools-mt.856.mcz
by commits＠source.squeak.org 13 Aug '19

13 Aug '19

A new version of Tools was added to project The Inbox: http://source.squeak.org/inbox/Tools-mt.856.mcz ==================== Summary ==================== Name: Tools-mt.856 Author: mt Time: 24 July 2019, 1:18:41.968109 pm UUID: 49d7ca18-63b6-4870-acaf-a44ec7c91b84 Ancestors: Tools-mt.855 In the system browser's message list, show deprecated methods gray and struck-out when all message are listed. =============== Diff against Tools-mt.855 =============== Item was changed: ----- Method: Browser>>messageList (in category 'message list') ----- messageList + "Answer an Array of the message selectors of the currently selected message category. If no category is selected or the '-- all --' category is selected, return all method selectors. Make deprecated messages look gray and struck-out." + - "Answer an Array of the message selectors of the currently selected message category, provided that the messageCategoryListIndex is in proper range. Otherwise, answer an empty Array If messageCategoryListIndex is found to be larger than the number of categories (it happens!!), it is reset to zero." - | sel | - (sel := self messageCategoryListSelection) ifNil: - [ - ^ self classOrMetaClassOrganizer - ifNil: [Array new] - ifNotNil: [self classOrMetaClassOrganizer allMethodSelectors] - "^ Array new" - ]. + ^ (self selectedMessageCategoryName isNil or: [self selectedMessageCategoryName = ClassOrganizer allCategory]) + ifTrue: [ + self classOrMetaClassOrganizer + ifNil: [Array new] + ifNotNil: [:organizer | organizer allMethodSelectors collect: [:ea | + | method | + ea = #messageList ifTrue: [ea] ifFalse: [ + method := self selectedClassOrMetaClass compiledMethodAt: ea. + ((method hasLiteral: #deprecated scanForSpecial: false) + or: [method hasLiteral: #deprecated: scanForSpecial: false]) + ifTrue: [ea asText + addAttribute: (TextColor color: Color gray); + addAttribute: TextEmphasis struckOut; + yourself] + ifFalse: [ea]]]]] + ifFalse: [ + (self classOrMetaClassOrganizer listAtCategoryNamed: self selectedMessageCategoryName) + ifNil: [Array new]]! - ^ sel = ClassOrganizer allCategory - ifTrue: - [self classOrMetaClassOrganizer - ifNil: [Array new] - ifNotNil: [self classOrMetaClassOrganizer allMethodSelectors]] - ifFalse: - [(self classOrMetaClassOrganizer listAtCategoryNamed: self selectedMessageCategoryName ) - ifNil: [selectedMessageCategoryName := nil. Array new]]!

9 15

truncatedTo: / roundTo: oddities with fractions
by Rein, Patrick 12 Aug '19

12 Aug '19

Hi everyone, a student recently encountered the following behavior: fraction := 5 / 9. (fraction* 100) truncateTo: 0.01. “55.550000000000004" fraction:= 1/18. (fraction * 100) roundTo: 0.01. “5.5600000000000005" This is not what I would expect from #truncateTo: or #roundTo: even when using Floats (especially roundTo:). Is this what we want or an open issue? I have not found any test covering the protocol. Bests Patrick

6 6

linux installation & squeak.sh confusions
by tim Rowledge 01 Aug '19

01 Aug '19

One of the interesting things that happens when you try to introduce someone new to Squeak is that you come up against all the habits you've built up about how to do stuff and how they don't necessarily match current reality. In this case, I noticed that installing Squeak on a linux machine has some curious issues. To start with, we don't actually seem to have any advice on what to install where, which makes it hard to tell people to RTFM. There are three plausible packages to install and each has a different shell script! The linux current 5.2b package squeak.sh is different to the all-in-one squeak.sh which is different to the version included in any locally built or grabbed from bintray package. Oh, and the version included in Raspbian is again different! We should probably try to improve that, wouldn't you say? Once upon a time(long ago), the norm was for the .sources file to live where the vm executable did. I'd sorta-kinda noticed that it could also be in the same directory as the image too, but we seem to have drifted a bit from that earlier rule. The only install details mentioned on https://squeak.org/downloads/ actually specify only the 'same directory as image' part. This is not the best option for anyone wanting to keep images for different purposes spread in various directories. The code in SourceFileArray does actually look for a sources file in the vm path *but* with the unix approach of having date/time coded vm paths - not to mention the more general idea of the 'shared' assets directory - this isn't going to be that useful; '/usr/lib/squeak/5.0-201907192337' is ok until you update to 5.2-201908031yyyy'. Then again, anyone having several VMs in different places will have some fun if paths based on the vm location are relied upon! I know that part of this is the result of the rather varied rules different unixes have for storing loaded applications. I don't know very much about those rules - and I really, really, don't want to have to care - so maybe somebody has ideas that might help have a decent shared location for the sources file that would fit? Could we just use vmPath/../ for 'normal' installs? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim A conscience is what hurts when all your other parts feel so good.

2 3

The Inbox: System-ct.1073.mcz
by commits＠source.squeak.org 01 Aug '19

01 Aug '19

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-ct.1073.mcz ==================== Summary ==================== Name: System-ct.1073 Author: ct Time: 30 July 2019, 5:18:34.214556 pm UUID: 8e29c8e1-c869-c541-b274-e0beb170c532 Ancestors: System-kfr.1072 Add SmalltalkImage>>#at:ifPresent:ifAbsent: A shorthand for SmalltalkImage globals access =============== Diff against System-kfr.1072 =============== Item was added: + ----- Method: SmalltalkImage>>at:ifPresent:ifAbsent: (in category 'accessing') ----- + at: key ifPresent: aBlock ifAbsent: anotherBlock + + ^globals at: key ifPresent: aBlock ifAbsent: anotherBlock!

5 5

The Inbox: ShoutCore-ul.68.mcz
by commits＠source.squeak.org 31 Jul '19

31 Jul '19

Levente Uzonyi uploaded a new version of ShoutCore to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ul.68.mcz ==================== Summary ==================== Name: ShoutCore-ul.68 Author: ul Time: 30 July 2019, 4:54:51.155525 pm UUID: c4f9bfa4-c725-48d5-beb1-4805e5e0efd2 Ancestors: ShoutCore-ul.67, ShoutCore-ct.66 - merged with ShoutCore-ct.66 - extracted most instance variable initialization before parsing to SHParserST80 >> #initializeInstanceVariables - improved #parseString - implemented #= and #hash for SHRange =============== Diff against ShoutCore-ul.67 =============== Item was changed: Object subclass: #SHParserST80 + instanceVariableNames: 'classOrMetaClass source workspace arguments sourcePosition currentToken currentTokenFirst temporaries instanceVariables errorBlock currentTokenSourcePosition bracketDepth ranges environment allowUnderscoreAssignments allowUnderscoreSelectors allowBlockArgumentAssignment parseAMethod currentTokenType context' - instanceVariableNames: 'classOrMetaClass source workspace arguments sourcePosition currentToken currentTokenFirst temporaries instanceVariables errorBlock currentTokenSourcePosition bracketDepth ranges environment allowUnderscoreAssignments allowUnderscoreSelectors allowBlockArgumentAssignment parseAMethod currentTokenType' classVariableNames: '' poolDictionaries: '' category: 'ShoutCore-Parsing'! + !SHParserST80 commentStamp: 'ul 7/30/2019 00:31' prior: 0! - !SHParserST80 commentStamp: 'ul 7/18/2019 21:12' prior: 0! I am a Smalltalk method / expression parser. Rather than creating an Abstract Syntax Tree, I create a sequence of SHRanges (in my 'ranges' instance variable), which represent the tokens within the String I am parsing. I am used by a SHTextStylerST80 to parse method source strings. I am able to parse incomplete / incorrect methods, and so can be used to parse methods that are being edited. Instance Variables allowBlockArgumentAssignment: <Boolean> allowUnderscoreAssignments: <Boolean> allowUnderscoreSelectors: <Boolean> arguments: <OrderedCollection<OrderedCollection<String>|nil> bracketDepth: <Integer> classOrMetaClass: <Class|nil> currentToken: <String|nil> currentTokenFirst: <Character> currentTokenSourcePosition: <Integer|nil> currentTokenType: <Symbol|nil> environment: <Environment> errorBlock: <Block> instanceVariables: <Array> parseAMethod: <Boolean> ranges: <OrderedCollection<SHRange>> source: <String> sourcePosition: <Integer> temporaries: <OrderedCollection<OrderedCollection<String>|nil> workspace: <Workspace|nil> + context: <Context|nil> allowBlockArgumentAssignment The value cached at the beginning of parsing of Scanner allowBlockArgumentAssignment. allowUnderscoreAssignments The value cached at the beginning of parsing of Scanner allowUnderscoreAsAssignment. allowUnderscoreSelectors The value cached at the beginning of parsing of Scanner prefAllowUnderscoreSelectors. arguments This OrderedCollection has an element for each scope encapsulating the current scope. The current scope's arguments are stored in the last element. The first element holds the outermost scope's arguments. Each element is nil when the corresponding scope doesn't have any arguments, and the element is an OrderedCollection with the names of the arguments declared at the given scope when there's at least one. The size of this variable is the same as the size of temporaries. bracketDepth Stores the number of unclosed brackets "(" and parentheses "[" before the current sourcePosition. classOrMetaClass The Class or MetaClass instance, class and pool variables should be looked up during parsing or nil when not parsing code in the context of a class (e.g. when parsing code written in a Workspace). Having this set doesn't mean a method is being parsed. currentToken The token being analyzed for which the next range should be created for. currentTokenFirst The first character of currentToken cached for quick access or a space character when there are no more tokens to parse. Being always a Character helps avoiding extra checks. currentTokenSourcePosition The position of source the current token starts at or nil when there are no more tokens to process. currentTokenType The type of the current token calculated lazily by #currentTokenType. When it has been calculated, Its value is one of #keyword, #assignment, #ansiAssignment, #binary, #name, #other and occasionally #invalid. environment The Environment globals and classes should be looked up at during parsing when classOrMetaClass is nil. Its value is Smalltalk globals by default. errorBlock A block used to quickly stop parsing in case of an unrecoverable parse error. instanceVariables An Array with the instance variable names of classOrMetaClass or an empty Array when classOrMetaClass is nil. parseAMethod A way to tell the parser to parse source as a code snippet instead of a method. Mainly used by inspectors. ranges The SHRanges parsed by the parser. source The source code as a String to be parsed. sourcePosition souce is treated as a stream by the parser. This variable stores the stream position. temporaries This OrderedCollection has an element for each scope encapsulating the current scope. The current scope's temporaries are stored in the last element. The first element holds the outermost scope's temporaries. Each element is nil when the corresponding scope doesn't have any temporary variables, and the element is an OrderedCollection with the names of the temporaries declared at the given scope when there's at least one. The size of this variable is the same as the size of arguments. workspace The Workspace in whose context variables should be looked up during parsing or nil when not parsing code in a workspace. + context + The Context in which variables should be looked up during parsing or nil when not parsing within a context. Example (explore it): ranges := SHParserST80 new classOrMetaClass: Object; source: 'testMethod ^self'; parse; ranges Benchmark (print it): SHParserST80 benchmark! Item was changed: ----- Method: SHParserST80>>initializeInstanceVariables (in category 'parse support') ----- initializeInstanceVariables instanceVariables := classOrMetaClass ifNil: [ #() ] + ifNotNil: [ classOrMetaClass allInstVarNames asArray ]. + allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. + allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. + allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment. + sourcePosition := 1. + arguments + ifNil: [ arguments := OrderedCollection with: nil ] + ifNotNil: [ arguments reset; addLast: nil ]. + temporaries + ifNil: [ temporaries := OrderedCollection with: nil ] + ifNotNil: [ temporaries reset; addLast: nil ]. + context ifNotNil: [ + | contextArgumentCount contextVariableNames | + contextArgumentCount := context numArgs. + contextVariableNames := context tempNames asOrderedCollection. + contextArgumentCount > 0 ifTrue: [ + arguments at: 1 put: (contextVariableNames first: contextArgumentCount) ]. + contextArgumentCount < contextVariableNames size ifTrue: [ + temporaries at: 1 put: (contextVariableNames allButFirst: contextArgumentCount) ] ]. + bracketDepth := 0. + ranges + ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] + ifNotNil: [ ranges reset ]! - ifNotNil: [ classOrMetaClass allInstVarNames asArray ]! Item was changed: ----- Method: SHParserST80>>parse: (in category 'parse') ----- parse: isAMethod + "Parse the receiver's text. If isAMethod is true then treat text as a method, if false as an expression with no message pattern" - "Parse the receiver's text. If isAMethod is true - then treat text as a method, if false as an - expression with no message pattern" self initializeInstanceVariables. + errorBlock := [^false]. "This must be defined in this method, as the goal is to return from this method in case of an error." - allowUnderscoreAssignments := Scanner allowUnderscoreAsAssignment. - allowUnderscoreSelectors := Scanner prefAllowUnderscoreSelectors. - allowBlockArgumentAssignment := Scanner allowBlockArgumentAssignment. - sourcePosition := 1. - arguments - ifNil: [ arguments := OrderedCollection with: nil ] - ifNotNil: [ arguments reset; addLast: nil ]. - temporaries - ifNil: [ temporaries := OrderedCollection with: nil ] - ifNotNil: [ temporaries reset; addLast: nil ]. - bracketDepth := 0. - ranges - ifNil: [ ranges := OrderedCollection new: 40 "Covers over 80% of all methods." ] - ifNotNil: [ ranges reset ]. - errorBlock := [^false]. self scanNext. isAMethod ifTrue: [ self parseMessagePattern; parsePragmaSequence ]. self parseTemporaries. isAMethod ifTrue: [ self parsePragmaSequence ]. self parseStatementList. currentToken ifNotNil: [ self fail ]. ^true! Item was changed: ----- Method: SHParserST80>>parseString (in category 'parse') ----- parseString - | first c last | - first := sourcePosition. + | stringStart | + stringStart := sourcePosition - 1. + [ + (sourcePosition := source indexOf: $' startingAt: sourcePosition) = 0 ifTrue: [ - [(c := self currentChar) - ifNil: [ self + addRangeType: #unfinishedString start: stringStart end: source size; - addRangeType: #unfinishedString start: first - 1 end: source size; fail ": 'unfinished string'"]. + self peekChar == $' - c ~~ $' or: [ - self peekChar == $' ifTrue: [ sourcePosition := sourcePosition + 1. + true ] + ifFalse: [ false ] ] + whileTrue: [ sourcePosition := sourcePosition + 1 ]. + sourcePosition := sourcePosition + 1. + self scanPast: #string start: stringStart end: sourcePosition - 1! - true] - ifFalse: [false]] - ] whileTrue: [sourcePosition := sourcePosition + 1]. - last := sourcePosition. - self - nextChar; - scanPast: #string start: first - 1 end: last! Item was changed: ----- Method: SHParserST80>>rangesIn:classOrMetaClass:workspace:environment: (in category 'parse') ----- rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil + ^ self rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil context: nil! - anEnvironmentOrNil ifNotNil: [environment := anEnvironmentOrNil]. - self - workspace: aWorkspace; - classOrMetaClass: aBehaviour; - source: sourceString. - self parse. - ^ranges! Item was added: + ----- Method: SHParserST80>>rangesIn:classOrMetaClass:workspace:environment:context: (in category 'parse') ----- + rangesIn: sourceString classOrMetaClass: aBehaviour workspace: aWorkspace environment: anEnvironmentOrNil context: aContextOrNil + anEnvironmentOrNil ifNotNil: [environment := anEnvironmentOrNil]. + aContextOrNil ifNotNil: [context := aContextOrNil]. + self + workspace: aWorkspace; + classOrMetaClass: aBehaviour; + source: sourceString. + self parse. + ^ranges! Item was added: + ----- Method: SHRange>>= (in category 'comparing') ----- + = anObject + + anObject class == SHRange ifFalse: [ ^false ]. + type = anObject type ifFalse: [ ^false ]. + start = anObject start ifFalse: [ ^false ]. + end = anObject end ifFalse: [ ^false ]. + ^true! Item was added: + ----- Method: SHRange>>hash (in category 'comparing') ----- + hash + + ^(((self class hash + type hash) hashMultiply + start) hashMultiply + end) hashMultiply! Item was changed: SHTextStyler subclass: #SHTextStylerST80 + instanceVariableNames: 'classOrMetaClass workspace font parser formatAssignments environment sourceMap processedSourceMap pixelHeight attributesByPixelHeight parseAMethod context' - instanceVariableNames: 'classOrMetaClass workspace font parser formatAssignments environment sourceMap processedSourceMap pixelHeight attributesByPixelHeight parseAMethod' classVariableNames: 'SyntaxHighlightingAsYouType SyntaxHighlightingAsYouTypeAnsiAssignment SyntaxHighlightingAsYouTypeLeftArrowAssignment TextAttributesByPixelHeight' poolDictionaries: '' category: 'ShoutCore-Styling'! !SHTextStylerST80 commentStamp: 'tween 8/27/2004 10:55' prior: 0! I style Smalltalk methods and expressions. My 'styleTable' class instance var holds an array ofArrays which control how each token is styled/coloured. See my defaultStyleTable class method for its structure. My styleTable can be changed by either modifying the defaultStyleTable class method and then executing SHTextStylerST80 initialize ; or by giving me a new styleTable through my #styleTable: class method. My 'textAttributesByPixelSize' class instance var contains a dictionary of dictionaries. The key is a pixelSize and the value a Dictionary from token type Symbol to TextAttribute array. It is created/maintained automatically. I also install these 3 preferences when my class initialize method is executed.... #syntaxHighlightingAsYouType - controls whether methods are styled in browsers #syntaxHighlightingAsYouTypeAnsiAssignment - controls whether assignments are formatted to be := #syntaxHighlightingAsYouTypeLeftArrowAssignment - controls whether assignments are formatted to be _ I reimplement #unstyledTextFrom: so that TextActions are preserved in the unstyled text ! Item was added: + ----- Method: SHTextStylerST80>>context: (in category 'accessing') ----- + context: aContext + context := aContext! Item was changed: ----- Method: SHTextStylerST80>>rangesIn:setWorkspace: (in category 'private') ----- rangesIn: aText setWorkspace: aBoolean "Answer a collection of SHRanges by parsing aText. When formatting it is not necessary to set the workspace, and this can make the parse take less time, so aBoolean specifies whether the parser should be given the workspace" | shoutParserClass | "Switch parsers if we have to" shoutParserClass := (classOrMetaClass ifNil:[Object]) shoutParserClass. parser class == shoutParserClass ifFalse:[parser := shoutParserClass new]. parser parseAMethod: parseAMethod. ^parser rangesIn: aText asString classOrMetaClass: classOrMetaClass workspace: (aBoolean ifTrue:[workspace]) environment: environment + context: context! - !

3 3

Jump to page: