Squeak-dev November 2020

squeak-dev@lists.squeakfoundation.org

31 participants
223 discussions

The Trunk: Kernel-ct.1357.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1357.mcz ==================== Summary ==================== Name: Kernel-ct.1357 Author: ct Time: 28 October 2020, 9:30:35.577652 pm UUID: efd94ae0-26ab-0c4f-b854-52f414ff2d3e Ancestors: Kernel-eem.1354 Implement missing simulation of objects as methods. In the past, it was not possible to debug/simulate code that used objects as methods properly. (Thanks to Marcel for the hint!) This very simple commit adds support of the OaM protocol [1] to the simulation machinery. Now you can debug all tests in TestObjectsAsMethods as you would expect, instead of crashing your image! Update: Uploaded a third time, this time with Kent Beck block formatting preserved. [1] "The [Objects as Methods] contract is that, when the VM encounters an ordinary object (rather than a compiled method) in the method dictionary during lookup, it sends it the special selector #run:with:in: providing the original selector, arguments, and receiver.". DOI: 10.1145/2991041.2991062. =============== Diff against Kernel-eem.1354 =============== Item was changed: ----- Method: Context>>send:to:with:lookupIn: (in category 'controlling') ----- send: selector to: rcvr with: arguments lookupIn: lookupClass + "Simulate the action of sending a message with selector and arguments to rcvr. The argument, lookupClass, is the class in which to lookup the message. This is the receiver's class for normal messages, but for super messages it will be some specific class related to the source method." - "Simulate the action of sending a message with selector and arguments - to rcvr. The argument, lookupClass, is the class in which to lookup the - message. This is the receiver's class for normal messages, but for super - messages it will be some specific class related to the source method." | meth primIndex val ctxt | (meth := lookupClass lookupSelector: selector) ifNil: [^self send: #doesNotUnderstand: to: rcvr with: {(Message selector: selector arguments: arguments) lookupClass: lookupClass} lookupIn: lookupClass]. + + meth isCompiledMethod ifFalse: + ["Object as Methods (OaM) protocol: 'The contract is that, when the VM encounters an ordinary object (rather than a compiled method) in the method dictionary during lookup, it sends it the special selector #run:with:in: providing the original selector, arguments, and receiver.'. DOI: 10.1145/2991041.2991062." + ^ self send: #run:with:in: + to: meth + with: {selector. arguments. rcvr}]. + + meth numArgs = arguments size ifFalse: + [^ self error: ('Wrong number of arguments in simulated message {1}' translated format: {selector})]. - meth numArgs ~= arguments size ifTrue: - [^self error: 'Wrong number of arguments in simulated message ', selector printString]. (primIndex := meth primitive) > 0 ifTrue: [val := self doPrimitive: primIndex method: meth receiver: rcvr args: arguments. + (self isPrimFailToken: val) ifFalse: - (self isPrimFailToken: val) ifFalse: [^val]]. + (selector == #doesNotUnderstand: and: [lookupClass == ProtoObject]) ifTrue: + [^ self error: ('Simulated message {1} not understood' translated format: {arguments first selector})]. + - [^self error: 'Simulated message ', arguments first selector, ' not understood']. ctxt := Context sender: self receiver: rcvr method: meth arguments: arguments. + (primIndex notNil and: [primIndex > 0]) ifTrue: - primIndex > 0 ifTrue: [ctxt failPrimitiveWith: val]. + ^ctxt!

1 0

The Trunk: Kernel-ct.1359.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1359.mcz ==================== Summary ==================== Name: Kernel-ct.1359 Author: ct Time: 1 November 2020, 7:50:24.183428 pm UUID: 3b12b316-79f3-de41-8765-8296d964b821 Ancestors: Kernel-mt.1353 Revise and extend Context #runSimulated: implementation. Remove restriction to blocks that do not have a method return. Add support for exception signaling during the execution, which caused unterminated simulation of the calling process in the past. Support argless contextAtEachStep blocks. Benchmarks: code: [Context runSimulated: [100@100 corner: 200@200]] bench before: 16.7 ms/run after: 19.8 ms/run I think this should be okay, given the fact that the primary purpose of simulation is providing explorability but not efficiency ... =============== Diff against Kernel-mt.1353 =============== Item was changed: ----- Method: Context class>>runSimulated: (in category 'simulation') ----- runSimulated: aBlock + "Simulate the execution of aBlock, until it ends or is curtailed. Answer the result it returns." - "Simulate the execution of the argument, current. Answer the result it - returns." ^ thisContext sender runSimulated: aBlock + contextAtEachStep: [] - contextAtEachStep: [:ignored] "Context runSimulated: [Pen new defaultNib: 5; go: 100]"! Item was changed: ----- Method: Context>>runSimulated:contextAtEachStep: (in category 'system simulation') ----- + runSimulated: aBlock contextAtEachStep: anotherBlock + "Simulate the execution of the argument, aBlock, until it ends or is curtailed. If any exception is signaled during the execution, simulate it being handled on the present caller stack. Evaluate anotherBlock with the current context prior to each instruction executed. Answer the simulated value of aBlock." + + | current resume ensure | + resume := false. - runSimulated: aBlock contextAtEachStep: block2 - "Simulate the execution of the argument, aBlock, until it ends. aBlock - MUST NOT contain an '^'. Evaluate block2 with the current context - prior to each instruction executed. Answer the simulated value of aBlock." - | current | - aBlock hasMethodReturn - ifTrue: [self error: 'simulation of blocks with ^ can run loose']. current := aBlock asContext. + ensure := current insertSender: (Context contextEnsure: [resume := true]). + ensure sender ifNil: [ensure privSender: self]. "For backward compatibility, do not fail if aBlock is dead." + + (anotherBlock numArgs = 0 + ifTrue: ["optimized" [resume]] + ifFalse: ["stop execution on time, don't expose simulation details to caller" + [current == ensure or: + ["Context >> #resume:" + current size >= 2 and: + [(current at: 2) == ensure]]] ]) - current pushArgs: Array new from: self. - [current == self] whileFalse: + [anotherBlock cull: current. - [block2 value: current. current := current step]. + + ^ current jump! - ^self pop!

1 0

The Inbox: System-kfr.1161.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

A new version of System was added to project The Inbox: http://source.squeak.org/inbox/System-kfr.1161.mcz ==================== Summary ==================== Name: System-kfr.1161 Author: kfr Time: 4 June 2020, 11:05:51.49313 pm UUID: 38776d4a-508a-7044-ab72-4cb34ceaceea Ancestors: System-mt.1160 Return nil instead of opening pre debugger =============== Diff against System-mt.1160 =============== Item was changed: ----- Method: StandardFileStream class>>fileExistsUserHandling:ifDebug: (in category '*System-Files-error handling') ----- fileExistsUserHandling: fullFileName ifDebug: debugBlock | dir localName choice newName newFullFileName | dir := FileDirectory forFileName: fullFileName. localName := FileDirectory localNameFor: fullFileName. choice := (UIManager default chooseFrom: #('overwrite that file' 'append (risky!!!!)' 'choose another name' 'debug' 'cancel') title: localName, ' already exists.'). choice = 1 ifTrue: [ dir deleteFileNamed: localName ifAbsent: [self error: 'Could not delete the old version of that file']. ^ self new open: fullFileName forWrite: true]. choice = 2 ifTrue: [ ^ (self new open: fullFileName forWrite: true) setToEnd]. choice = 3 ifTrue: [ newName := UIManager default request: 'Enter a new file name' initialAnswer: fullFileName. newFullFileName := self fullName: newName. ^ self newFileNamed: newFullFileName]. choice = 4 ifTrue: [^ debugBlock value]. + choice = 5 ifTrue: [^ nil].! - self error: 'Please close this to abort file opening'!

2 1

The Trunk: System-nice.1128.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-nice.1128.mcz ==================== Summary ==================== Name: System-nice.1128 Author: nice Time: 9 December 2019, 6:25:31.07858 pm UUID: 8b2bd676-0898-c843-914e-039dde2db037 Ancestors: System-mt.1127 Nuke windows CE OS support. Let Win32 VM default to UTF32InputInterpreter rather than MacRomanInputInterpreter. Note: I think that this method is unused and is just adding confusion to already convoluted code... But it is difficult to analyze the source, so it's better to differ this after 5.3 release if unsure. Unless we have a good set of tests? =============== Diff against System-mt.1127 =============== Item was changed: ----- Method: Locale class>>defaultInputInterpreter (in category 'platform specific') ----- defaultInputInterpreter + | platformName | - | platformName osVersion | platformName := Smalltalk platformName. + platformName = 'Win32' ifTrue: [^UTF32InputInterpreter new]. - osVersion := Smalltalk getSystemAttribute: 1002. - (platformName = 'Win32' and: [osVersion = 'CE']) - ifTrue: [^NoInputInterpreter new]. - platformName = 'Win32' ifTrue: [^MacRomanInputInterpreter new]. ^NoInputInterpreter new!

1 0

The Trunk: Monticello-mt.731.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-mt.731.mcz ==================== Summary ==================== Name: Monticello-mt.731 Author: mt Time: 4 November 2020, 10:45:45.08162 am UUID: cc112dfa-3c81-8844-b323-1e07d2f73e32 Ancestors: Monticello-mt.730 Show a warning when trying to copy an inbox version to trunk or treated as a compromise until a proper move operation can be implemented in the image. =============== Diff against Monticello-mt.730 =============== Item was changed: ----- Method: MCVersionInspector>>save (in category 'accessing') ----- save self pickRepository ifNotNil: + [:repository | + (self repository = MCRepository inbox and: + [repository = MCRepository trunk or: [repository = MCRepository treated]]) ifTrue: + [self notify: 'Versions from the inbox should only be moved, not copied. Instead, use the web interface via source.squeak.org to manage inbox constributions.\\Do you want to proceed anyway?' translated withCRs]. + repository storeVersion: self version]! - [:ea | - ea storeVersion: self version]!

1 0

The Trunk: Collections-ct.876.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.876.mcz ==================== Summary ==================== Name: Collections-ct.876 Author: ct Time: 16 February 2020, 3:38:21.566 pm UUID: 83e0e8f6-a3b2-f540-a88e-6d833e2146fd Ancestors: Collections-topa.873 Fixes a typo in #withFirstCharacterDownshifted =============== Diff against Collections-topa.873 =============== Item was changed: ----- Method: Symbol>>withFirstCharacterDownshifted (in category 'converting') ----- withFirstCharacterDownshifted + "Answer an object like the receiver but with first character downshifted if necessary" - "Answer an object like the receiver but with first character downshifted if necesary" + ^self asString withFirstCharacterDownshifted asSymbol! - ^self asString withFirstCharacterDownshifted asSymbol.!

1 0

The Trunk: Collections-ct.855.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.855.mcz ==================== Summary ==================== Name: Collections-ct.855 Author: ct Time: 20 September 2019, 6:56:22.518437 pm UUID: 079663b5-47e2-bd47-bfa4-86db03bd98d8 Ancestors: Collections-mt.854 Add convenience method for adding many attributes to a Text. =============== Diff against Collections-mt.854 =============== Item was added: + ----- Method: Text>>addAllAttributes: (in category 'emphasis') ----- + addAllAttributes: attributes + + attributes do: [:attribute | + self addAttribute: attribute].!

1 0

The Trunk: Collections-kfr.878.mcz
by commits＠source.squeak.org 04 Nov '20

04 Nov '20

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-kfr.878.mcz ==================== Summary ==================== Name: Collections-kfr.878 Author: kfr Time: 29 February 2020, 12:18:54.1853 pm UUID: ce016281-22ee-4948-b534-944fb3913521 Ancestors: Collections-ul.877 Add 'clear' to Transcript window menu. =============== Diff against Collections-ul.877 =============== Item was added: + ----- Method: TranscriptStream>>addModelItemsToWindowMenu: (in category 'menu') ----- + addModelItemsToWindowMenu: aMenu + + aMenu addLine. + aMenu + add: 'clear' + target: self + action: #clear.!

1 0

The Inbox: Tests-ct.444.mcz
by commits＠source.squeak.org 02 Nov '20

02 Nov '20

A new version of Tests was added to project The Inbox: http://source.squeak.org/inbox/Tests-ct.444.mcz ==================== Summary ==================== Name: Tests-ct.444 Author: ct Time: 2 November 2020, 8:00:44.071122 pm UUID: c171d656-c1c7-8644-9267-2fddf331d58c Ancestors: Tests-mt.442 Complements SUnit-ct.131. =============== Diff against Tests-mt.442 =============== Item was removed: - ----- Method: CompilerNotifyingTest class>>lastStoredRun (in category 'history') ----- - lastStoredRun - ^ ((Dictionary new) add: (#failures->((Set new) add: #testTooManyArguments; add: #testifTrueBlockWithArgument; add: #testMissingArgumentAfterAMessageKey; add: #testTooManyLiterals; add: #testAlltogether; add: #testUnmatchedLocalTempDeclarationInABlock; add: #testUnmatchedExpressionParenthesis; add: #testCaseOtherwiseBlockWithArgument; yourself)); add: (#errors->((Set new) add: #testTooManyTemporaries; yourself)); add: (#passed->((Set new) add: #testUnmatchedBraceArray; add: #testTooLargeAnIntegerInALiteralByteArray; add: #testDigitTooLargeForARadix; add: #testInvalidLiteralCharacter; add: #testAssignmentOfSelf; add: #testInvalidPrimitive; add: #testInvalidExternalFunctionDeclaration; add: #testMissingExpressionAfterAReturn; add: #testInvalidRadix; add: #testMissingArgumentAfterABinaryMessage; add: #testMissingPeriodSeparatorBetweenStatements; add: #testCascadeInASuperSend; add: #testATempShadowingAnotherTemp; add: #testExtraneousStatementAfterAReturnInABlock; add: #testLiteralChar acterMissing; add: #testUnmatchedCommentQuote; add: #testInvalidPattern; add: #testUnmatchedByteArrayBracket; add: #testUnmatchedLiteralParenthesis; add: #testUnmatchedLocalTempDeclaration; add: #testExpectedExpressionInBraceArray; add: #testInvalidPragma; add: #testMissingSeparatorBetweenBlockArgumentAndStatements; add: #testMissingBlockArgumentName; add: #testMissingMessageAfterACascade; add: #testUnmatchedStringQuote; add: #testTempDoubledDefined; add: #testMissingExpression; add: #testUnmatchedBlockBracket; add: #testEmptyCaseStatement; yourself)); add: (#timeStamp->'22 February 2012 3:52:10 am' asTimeStamp); yourself)!

1 0

The Inbox: SUnit-ct.131.mcz
by commits＠source.squeak.org 02 Nov '20

02 Nov '20

A new version of SUnit was added to project The Inbox: http://source.squeak.org/inbox/SUnit-ct.131.mcz ==================== Summary ==================== Name: SUnit-ct.131 Author: ct Time: 2 November 2020, 8:00:15.279122 pm UUID: eb678be0-b6de-f540-bcce-37b84404df99 Ancestors: SUnit-pre.123 Don't save #lastStoredRun results into the source package. See also ReleaseBuilder class >>#discardUserObjects. Thanks to tobe & mt for the advice! :-) =============== Diff against SUnit-pre.123 =============== Item was removed: - ----- Method: ClassFactoryForTestCaseTest class>>lastStoredRun (in category 'history') ----- - lastStoredRun - ^ ((Dictionary new) add: (#passed->((Set new) add: #testDefaultCategoryCleanUp; add: #testPackageCleanUp; add: #testSingleClassCreation; add: #testClassCreationInDifferentCategories; add: #testClassFastCreationInDifferentCategories; add: #testMultipleClassCreation; add: #testSingleClassFastCreation; yourself)); add: (#timeStamp->'22 November 2008 10:11:35 pm'); add: (#failures->((Set new))); add: (#errors->((Set new))); yourself)! Item was removed: - ----- Method: ResumableTestFailureTestCase class>>lastStoredRun (in category 'history') ----- - lastStoredRun - ^ ((Dictionary new) add: (#passed->((Set new) add: #testResumable; yourself)); add: (#timeStamp->'22 November 2008 10:11:35 pm'); add: (#failures->((Set new))); add: (#errors->((Set new))); yourself)! Item was removed: - ----- Method: SUnitExtensionsTest class>>lastStoredRun (in category 'history') ----- - lastStoredRun - ^ ((Dictionary new) add: (#passed->((Set new) add: #testNoExceptionWithMatchingString; add: #testNoExceptionWithNoMatchingString; add: #testExceptionWithMatchingString; add: #testExceptionWithoutMatchingString; add: #testValidShouldNotTakeMoreThan; add: #testInvalidShouldNotTakeMoreThanMilliseconds; add: #testDifferentExceptionInShouldRaiseWithExceptionDo; add: #testShouldRaiseWithExceptionDo; add: #testShouldFix; add: #testAssertionFailedInRaiseWithExceptionDo; add: #testAutoDenyFalse; add: #testAutoDenyTrue; add: #testAutoAssertFalse; add: #testAutoAssertTrue; add: #testValidShouldNotTakeMoreThanMilliseconds; add: #testErrorInRaiseWithExceptionDo; add: #testNoExceptionInShouldRaiseWithExceptionDo; add: #testInvalidShouldNotTakeMoreThan; yourself)); add: (#timeStamp->'22 November 2008 10:11:35 pm'); add: (#failures->((Set new))); add: (#errors->((Set new))); yourself)! Item was removed: - ----- Method: SUnitTest class>>lastStoredRun (in category 'history') ----- - lastStoredRun - ^ ((Dictionary new) add: (#passed->((Set new) add: #testWithExceptionDo; add: #testRan; add: #testAssert; add: #testRanOnlyOnce; add: #testDialectLocalizedException; add: #testFail; add: #testDefects; add: #testIsNotRerunOnDebug; add: #testResult; add: #testRunning; add: #testError; add: #testException; add: #testShould; add: #testSuite; yourself)); add: (#timeStamp->'22 November 2008 10:11:35 pm'); add: (#failures->((Set new))); add: (#errors->((Set new))); yourself)! Item was removed: - ----- Method: SimpleTestResourceTestCase class>>lastStoredRun (in category 'history') ----- - lastStoredRun - ^ ((Dictionary new) add: (#passed->((Set new) add: #testResourceInitRelease; add: #testResourcesCollection; add: #testRan; yourself)); add: (#timeStamp->'22 November 2008 10:11:35 pm'); add: (#failures->((Set new))); add: (#errors->((Set new))); yourself)! Item was changed: ----- Method: TestCase class>>generateLastStoredRunMethod (in category 'history') ----- generateLastStoredRunMethod self shouldGenerateLastStoredRunMethod ifTrue: [ self class compile: (self lastRunMethodNamed: #lastStoredRun) + classified: '*autogenerated-history' ]! - classified: 'history' ]! Item was changed: ----- Method: TestCase class>>lastRunMethodNamed: (in category 'history') ----- lastRunMethodNamed: aSelector + ^ String streamContents: [:stream | + stream + nextPutAll: aSelector asString; + crtab; nextPutAll: ('<autogenerated> "See {1}"' format: {thisContext home}); + crtab; nextPutAll: '^ ', (self lastRun) storeString] - ^ String streamContents: [:str | - str nextPutAll: aSelector asString ;cr. - str tab; nextPutAll: '^ ', (self lastRun) storeString] !

1 0

Jump to page: