Squeak-dev March 2020

squeak-dev@lists.squeakfoundation.org

38 participants
319 discussions

The Trunk: System-ul.1148.mcz
by commits＠source.squeak.org 26 Mar '20

26 Mar '20

Levente Uzonyi uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-ul.1148.mcz ==================== Summary ==================== Name: System-ul.1148 Author: ul Time: 24 March 2020, 9:15:28.593463 pm UUID: 79bbf013-47f5-4f3c-9e42-8f169fe22a6c Ancestors: System-ul.1147 - create a deep copy of the keys read from the file in SecurityManager >> #loadSecurityKeys, so that they can be modified later =============== Diff against System-ul.1147 =============== Item was changed: ----- Method: SecurityManager>>loadSecurityKeys (in category 'fileIn/out') ----- loadSecurityKeys "SecurityManager default loadSecurityKeys" "Load the keys file for the current user" | fd loc file keys | self isInRestrictedMode ifTrue:[^self]. "no point in even trying" loc := self secureUserDirectory. "where to get it from" loc last = FileDirectory pathNameDelimiter ifFalse:[ loc := loc copyWith: FileDirectory pathNameDelimiter. ]. fd := FileDirectory on: loc. file := [fd readOnlyFileNamed: keysFileName] on: FileDoesNotExistException do:[:ex| nil]. file ifNil:[^self]. "no keys file" + keys := (Object readFrom: file) veryDeepCopy. "Use #veryDeepCopy to make the non-writable literal objects created by the Compiler writable." - keys := Object readFrom: file. privateKeyPair := keys first. trustedKeys := keys last. file close.!

4 4

DockingBarMorph errors?
by K K Subbu 26 Mar '20

26 Mar '20

All, I encountered a strange problem by accident with the main docking bar in Squeak 6.0alpha-19541 (linux VM): * bring up halo menu on the main docking bar * click on pick icon and click again in the same place. * Expected behavior - the main docking bar remains unchanged * Actual behavior - menu items are packed to the left. Does anyone else see the same behavior? I also saw another anomaly: * If I click ctrl-1 ctrl-2 etc, the drop down menu appears below Project, Tools etc. But if I press ctrl-0, the drop down menu remains in place but the text cursor switches to the Search Bar. This is confusing and disconcerting. Regards .. Subbu

3 5

Save as new image -> ModificationForbidden!
by Marcel Taeumel 26 Mar '20

26 Mar '20

Hi, there. I just wanted to save a 32-bit image (Update 19541, VM 202003021730, Windows 10) under a new filename. Boom! ModificationForbidden! Here is the interesting stack: Context>>modificationForbiddenFor:at:put: LargePositiveInteger(Object)>>basicAt:put: SecurityManager>>flushSecurityKey: SecurityManager>>flushSecurityKeys SecurityManager>>shutDown SecurityManager class>>shutDown SecurityManager class(Behavior)>>shutDown: [] in SmalltalkImage>>send:toClassesNamedIn:with: OrderedCollection>>do: SmalltalkImage>>send:toClassesNamedIn:with: SmalltalkImage>>processShutDownList: Well, that code tries to change a LargePositiveInteger: SecurityManager >> flushSecurityKey: aKey "Flush a security key" | n | n := aKey first. 1 to: n basicSize do:[:i| n basicAt: i put: 0]. n := aKey second. 1 to: n basicSize do:[:i| n basicAt: i put: 0]. How to fix that without breaking security measures or the underlying concept? Best, Marcel

7 14

The Inbox: HelpSystem-Core-ct.123.mcz
by commits＠source.squeak.org 26 Mar '20

26 Mar '20

A new version of HelpSystem-Core was added to project The Inbox: http://source.squeak.org/inbox/HelpSystem-Core-ct.123.mcz ==================== Summary ==================== Name: HelpSystem-Core-ct.123 Author: ct Time: 13 October 2019, 9:04:08.373932 pm UUID: dec7ceca-320f-d945-8d2a-c2f6a5e49a52 Ancestors: HelpSystem-Core-ct.120 Refactors HelpBrowser menu: Move menu stuff from HelpBrowser into HelpTopic hierarchy in favor of a better object design Thanks again, Marcel :-) =============== Diff against HelpSystem-Core-ct.120 =============== Item was added: + ----- Method: AbstractHelpTopic>>browseTopicFromParent: (in category 'tools') ----- + browseTopicFromParent: parentTopic + + self canBrowseTopic + ifTrue: [^ self browseTopic]. + parentTopic canBrowseSubtopic + ifTrue: [^ parentTopic browseSubtopic: self]. + ! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseSubtopic (in category 'testing') ----- + canBrowseSubtopic + + ^ false! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ false! Item was added: + ----- Method: AbstractHelpTopic>>canBrowseTopicFromParent: (in category 'testing') ----- + canBrowseTopicFromParent: parentTopic + + ^ self canBrowseTopic or: [ + parentTopic ifNotNil: #canBrowseSubtopic ifNil: [false]]! Item was added: + ----- Method: AbstractHelpTopic>>topicMenu:parentTopic: (in category 'menus') ----- + topicMenu: aMenu parentTopic: parentTopic + + aMenu + add: 'Inspect (i)' translated target: self action: #inspect; + add: 'Explore (I)' translated target: self action: #explore. + (self canBrowseTopicFromParent: parentTopic) + ifTrue: [ + aMenu add: 'Browse (b)' translated + target: self + selector: #browseTopicFromParent: + argumentList: {parentTopic} ]. + + ^ aMenu! Item was added: + ----- Method: AbstractHelpTopic>>topicMenuKey:fromParent: (in category 'menus') ----- + topicMenuKey: aChar fromParent: parentTopic + + aChar + caseOf: { + [$b] -> [(self canBrowseTopicFromParent: parentTopic) + ifTrue: [ self browseTopicFromParent: parentTopic ]]. + [$i] -> [self inspect]. + [$I] -> [self explore] } + otherwise: [^ false]. + ^ true! Item was added: + ----- Method: ClassAPIHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: ClassBasedHelpTopic>>canBrowseSubtopic (in category 'testing') ----- + canBrowseSubtopic + + ^ true! Item was added: + ----- Method: ClassBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: DirectoryBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: FileBasedHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was removed: - ----- Method: HelpBrowser>>browseTopic (in category 'actions') ----- - browseTopic - - ^ (self currentTopic respondsTo: #browseTopic) - ifTrue: [self currentTopic browseTopic] - ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]! Item was removed: - ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') ----- - canBrowseTopic - - ^ (self currentTopic respondsTo: #browseTopic) - or: [self currentParentTopic respondsTo: #browseSubtopic:]! Item was removed: - ----- Method: HelpBrowser>>exploreTopic (in category 'actions') ----- - exploreTopic - - ^ self currentTopic explore! Item was removed: - ----- Method: HelpBrowser>>inspectTopic (in category 'actions') ----- - inspectTopic - - ^ self currentTopic inspect! Item was changed: ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') ----- treeKey: aChar from: aView event: anEvent anEvent anyModifierKeyPressed ifFalse: [^ false]. + ^ (self currentTopic topicMenuKey: aChar fromParent: self currentParentTopic)! - aChar - caseOf: { - [$b] -> [self browseTopic]. - [$i] -> [self inspectTopic]. - [$I] -> [self exploreTopic]. } - otherwise: [^ false]. - ^ true! Item was changed: ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') ----- treeListMenu: aMenu <treeListMenu> + ^ self currentTopic + ifNil: [aMenu] + ifNotNil: [:topic | topic + topicMenu: aMenu + parentTopic: self currentParentTopic]! - self currentTopic ifNil: [^ aMenu]. - - aMenu - add: 'Inspect (i)' action: #inspectTopic; - add: 'Explore (I)' action: #exploreTopic. - - self canBrowseTopic ifTrue: [ - aMenu - addLine; - add: 'Browse (b)' action: #browseTopic]. - - ^ aMenu! Item was added: + ----- Method: MethodListHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true! Item was added: + ----- Method: PackageAPIHelpTopic>>canBrowseTopic (in category 'testing') ----- + canBrowseTopic + + ^ true!

9 22

Re: [squeak-dev] Save as new image -> ModificationForbidden!
by Eliot Miranda 26 Mar '20

26 Mar '20

>> On Mar 25, 2020, at 12:52 PM, Thiede, Christoph <Christoph.Thiede(a)student.hpi.uni-potsdam.de> wrote: > > Hm, it would be indeed very confusing it the same code worked in a workspace but not in a compiled method. > > > > Would it be a trade-off if we changed Object >> #readFrom: to apply #asWriteable on the deserialized object? > Yes, I suggested this in response to Levente’s commit of System-ul.1148. It might need to be smart. For example, if the deserialized object referred to a literal deep within its structure, that literal shouldn’t be changed. So it might me that the right way to implement this is indeed to change evaluation within readFrom: a it only makes literals within the doit(s) created writable. > > > Best, > Christoph > Von: Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im Auftrag von Eliot Miranda <eliot.miranda(a)gmail.com> > Gesendet: Mittwoch, 25. März 2020 18:45:37 > An: The general-purpose Squeak developers list > Betreff: Re: [squeak-dev] Save as new image -> ModificationForbidden! > > Hi Jakob, > > >> On Mar 25, 2020, at 10:13 AM, Jakob Reschke <forums.jakob(a)resfarm.de> wrote: >> >> If you write #(1 2 3) in an inspector on a variable and accept that value, does it now make the variable's value immutable? > > Read-only ;-) Potsdam were the people who wanted the language ui change from mutable/immutable to writable/read-only to reserve mutable/immutable for deep immutability for E-style concurrency :-) > > Yes, it means it is marked as read-only. Currently you can either write #(1 2 3) copy or #(1 2 3) beWritableObject. But we could modify the Inspector’s accept action to preserve the state if the object is of the same class, etc. I’m not necessarily in favor of such auto-magic; it can get tricky. But I understand that this use case might turn out to be tedious. > > I guess what we should be doing is collecting these “gotchers” for the HelpBrowser page on read-only literals that we’ll want to feature in the release. > > And of course we’re early in the discussion Levente started about whether literals answered by doits should be read-only or not. I said I thought they should be in the interests of consistency. But in the interests of utility one might want them to be writable. I think one wants large integers and floats to be read-only no matter what, right? So we’re taking about literal arrays, byte arrays, and strings. If so, it seems to me that the right place to do any modifications to make things writable is in the evaluators. Perhaps we add an evaluateWritableResult: or add a writableResult: argument to the core evaluator api that would make array, byte array and string results writable iff the argument was true, the result was of the relevant class and it was a literal in the doit method. > > Weird (or perhaps not) that I can’t remember this issue ever coming up in VisualWorks. Anyone got a better recollection than me? > >> Marcel Taeumel <marcel.taeumel(a)hpi.de> schrieb am Mi., 25. März 2020, 09:36: >>> > Why do you think this is the wrong print string? >>> >>> It happens easily to evaluate the printString again. If we now have ModificationForbidden, this can be quite confusing. >>> >>> Same for #storeString: >>> >>> {1. 2. 3} storeString -> '#(1 2 3)' >>> >>> Best, >>> Marcel >>>> Am 25.03.2020 09:32:04 schrieb Thiede, Christoph <christoph.thiede(a)student.hpi.uni-potsdam.de>: >>>> >>>> Hi Marcel, hi Levente! >>>> >>>> >>>> >>>> > For starters, the #printString of modifiable arrays is wrong if literal arrays should be immutable: >>>> >>>> > >>>> > x := {1. 2. 3}. >>>> > x at: 1 put: #foo. >>>> > x "#(#foo 2 3) --- wrong print string!" >>>> >>>> Why do you think this is the wrong print string? {#foo. 2. 3} is also printed as #(#foo 2 3). >>>> >>>> Also, the following example shows that brace nodes generate a new instance each time: >>>> >>>> c := Object newSubclass. >>>> c compile: 'foo ^ {1. 2. 3}'. >>>> o := c new. >>>> o foo at: 1 put: #foo. >>>> o foo. "#(1 2 3)" >>>> >>>> Best, >>>> Christoph >>>> Von: Squeak-dev <squeak-dev-bounces(a)lists.squeakfoundation.org> im Auftrag von Taeumel, Marcel >>>> Gesendet: Mittwoch, 25. März 2020 09:19:01 >>>> An: gettimothy via Squeak-dev >>>> Betreff: Re: [squeak-dev] Save as new image -> ModificationForbidden! >>>> >>>> Hi Levente, hi Christoph. >>>> >>>> > I cannot reproduce this using a fresh Trunk image >>>> >>>> I am not exactly sure why my Trunk image keeps generating those private keys. But I am happy that the bug surfaced. Now we need to address it. :-) >>>> >>>> > The main issue is that literal objects created by Compiler >> #evaluate:* are now immutable but I think they shouldn't be. What do you think? >>>> >>>> Well, I think that literals producing numbers, strings, or symbols should be protected in this way. For literal arrays, I am not so sure. >>>> >>>> For starters, the #printString of modifiable arrays is wrong if literal arrays should be immutable: >>>> >>>> x := {1. 2. 3}. >>>> x at: 1 put: #foo. >>>> x "#(#foo 2 3) --- wrong print string!" >>>> >>>> y := #(1 2 3). >>>> y at: 1 put: #foo. "ModificationForbidden" >>>> >>>> Then, in the past, I have been complaining about the array cache in compiled methods: >>>> >>>> someDefault >>>> ^ #(1 2 3) >>>> >>>> In this case, I expected the method to always return a new array. Now, it is immutable, but that is not as expected. I think. Is it still cached? >>>> >>>> *** >>>> >>>> In my case here, the code tries to change a LargePositiveInteger, not an array, which has always been wrong. :-) Is there a way to safely discard a LargePositiveInteger from memory? >>>> >>>> > System-ul.1148 should work the issue around. Please let me know if it >>>> helped. >>>> >>>> Not quite. I think have to manually clear the current keys in the SecurityManager first. >>>> >>>> Best, >>>> Marcel >>>>> Am 24.03.2020 21:18:51 schrieb Levente Uzonyi <leves(a)caesar.elte.hu>: >>>>> >>>>> Hi Marcel, >>>>> >>>>> System-ul.1148 should work the issue around. Please let me know if it >>>>> helped. >>>>> The main issue is that literal objects created by Compiler >> #evaluate:* >>>>> are now immutable but I think they shouldn't be. What do you think? >>>>> >>>>> >>>>> Levente >>>>> >>>>> On Tue, 24 Mar 2020, Marcel Taeumel wrote: >>>>> >>>>> > Hi, there. >>>>> > >>>>> > I just wanted to save a 32-bit image (Update 19541, VM 202003021730, Windows 10) under a new filename. >>>>> > >>>>> > Boom! ModificationForbidden! >>>>> > >>>>> > Here is the interesting stack: >>>>> > >>>>> > Context>>modificationForbiddenFor:at:put: >>>>> > LargePositiveInteger(Object)>>basicAt:put: >>>>> > SecurityManager>>flushSecurityKey: >>>>> > SecurityManager>>flushSecurityKeys >>>>> > SecurityManager>>shutDown >>>>> > SecurityManager class>>shutDown >>>>> > SecurityManager class(Behavior)>>shutDown: >>>>> > [] in SmalltalkImage>>send:toClassesNamedIn:with: >>>>> > OrderedCollection>>do: >>>>> > SmalltalkImage>>send:toClassesNamedIn:with: >>>>> > SmalltalkImage>>processShutDownList: >>>>> > >>>>> > Well, that code tries to change a LargePositiveInteger: >>>>> > >>>>> > SecurityManager >> flushSecurityKey: aKey >>>>> > "Flush a security key" >>>>> > | n | >>>>> > n := aKey first. >>>>> > 1 to: n basicSize do:[:i| n basicAt: i put: 0]. >>>>> > n := aKey second. >>>>> > 1 to: n basicSize do:[:i| n basicAt: i put: 0]. >>>>> > >>>>> > How to fix that without breaking security measures or the underlying concept? >>>>> > >>>>> > Best, >>>>> > Marcel >>>>> > >>>>> >

1 1

The Inbox: Kernel-eem.1320.mcz
by commits＠source.squeak.org 26 Mar '20

26 Mar '20

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-eem.1320.mcz ==================== Summary ==================== Name: Kernel-eem.1320 Author: eem Time: 25 March 2020, 9:01:48.950717 pm UUID: 5e03652f-dca4-40fb-991e-ec71a89bb282 Ancestors: Kernel-eem.1319 Use Compiler-eem.421 to make Object class>>readFrom: answer writable collection literals. =============== Diff against Kernel-eem.1319 =============== Item was changed: ----- Method: Object class>>basicReadFrom: (in category 'instance creation') ----- basicReadFrom: textStringOrStream "Create an object based on the contents of textStringOrStream." | object | + (Compiler couldEvaluate: textStringOrStream) ifFalse: + [^ self error: 'expected String, Stream, or Text' translated]. + object := self environment beCurrentDuring: + [Compiler evaluate: textStringOrStream writableCollectionLiterals: true environment: self environment]. + (object isKindOf: self) ifFalse: + [self error: ('{1} expected' translated format: {self name})]. - (Compiler couldEvaluate: textStringOrStream) - ifFalse: [^ self error: 'expected String, Stream, or Text' translated]. - object := self environment beCurrentDuring: [ - Compiler evaluate: textStringOrStream environment: self environment]. - (object isKindOf: self) ifFalse: [self error: ('{1} expected' translated format: {self name})]. ^object!

1 0

The Inbox: Compiler-eem.421.mcz
by commits＠source.squeak.org 26 Mar '20

26 Mar '20

A new version of Compiler was added to project The Inbox: http://source.squeak.org/inbox/Compiler-eem.421.mcz ==================== Summary ==================== Name: Compiler-eem.421 Author: eem Time: 25 March 2020, 9:00:37.328826 pm UUID: 7bacb14a-f088-4fca-aa94-35dae28aa8e8 Ancestors: Compiler-nice.420 A suggested implementation of writable results from doits. This scheme is careful to only make read-only collection literals that the compiler makes read-only, not e.g. numeric literals (which should always be read-only) or objects the evaluation makes read-only. =============== Diff against Compiler-nice.420 =============== Item was changed: Object subclass: #CompilationCue + instanceVariableNames: 'source context receiver class environment requestor writableCollectionLiterals' - instanceVariableNames: 'source context receiver class environment requestor' classVariableNames: '' poolDictionaries: '' category: 'Compiler-Kernel'! + !CompilationCue commentStamp: 'eem 3/25/2020 20:52' prior: 0! - !CompilationCue commentStamp: 'eem 3/30/2017 17:32' prior: 0! A CompilationCue is a helper class holding enough context for evaluating/compiling Smalltalk code. That is mainly the source code, and the source code editor to interact with if the Compiler is used interactively. But that is also any additional information necessary to resolve variable names. When compiling a method, the Compiler typically need to know the target class in which to install the method. When evaluating an expression, the Compiler also needs a receiver (for accessing the value of its instance variables), its class (for resolving instance/class variable names), and optionnally a context of execution when debugging a method (for accessing values of temporaries and parameters). Instance Variables + class: <Behavior> + context: <Context | nil> + environment: <Environment | nil> + receiver: <Object> + requestor: <TextEditor | nil> + source: <Stream> + writableCollectionLiterals: <Boolean> - class: <Behavior> - context: <Context | nil> - environment: <Environment | nil> - receiver: <Object> - requestor: <TextEditor | nil> - source: <Stream> class - the target class in which to install the compiled method; this enables to resolve the instance variable names, class variable names and shared pool variable names. When evaluating, this should be the receiver class context - the context introspected when evaluating the code: this is typically for accessing parameters and temporary variables when debugging environment - the environment in which to resolve global variable names receiver - the receiver into which to evaluate the code: this is typically for accessing instance variables in an inspector requestor - typically the text editor containing the source code being compiled/evaluated. This enables the Compiler to interact in case of syntax error. source - a ReadStream on the source code to be compiled + + writableCollectionLiterals + - if true then the compiler should answer writable collection literals in an evaluation; by default all literals are read-only ! Item was changed: ----- Method: CompilationCue class>>source:context:class:environment:requestor: (in category 'instance creation') ----- source: aTextOrStream context: aContext class: aClass environment: anEnvironment requestor: reqObject ^ self basicNew initializeWithSource: aTextOrStream context: aContext receiver: (aContext ifNotNil: [aContext receiver]) class: aClass environment: anEnvironment + requestor: reqObject + writableCollectionLiterals: false! - requestor: reqObject! Item was changed: ----- Method: CompilationCue class>>source:context:receiver:class:environment:requestor: (in category 'instance creation') ----- source: aTextOrStream context: aContext receiver: recObject class: aClass environment: anEnvironment requestor: reqObject ^ self basicNew initializeWithSource: aTextOrStream context: aContext receiver: recObject class: aClass environment: anEnvironment + requestor: reqObject + writableCollectionLiterals: false! - requestor: reqObject! Item was added: + ----- Method: CompilationCue class>>source:context:receiver:class:environment:requestor:writableCollectionLiterals: (in category 'instance creation') ----- + source: aTextOrStream context: aContext receiver: recObject class: aClass environment: anEnvironment requestor: reqObject writableCollectionLiterals: writableCollectionLiteralsBool + ^ self basicNew + initializeWithSource: aTextOrStream + context: aContext + receiver: recObject + class: aClass + environment: anEnvironment + requestor: reqObject + writableCollectionLiterals: writableCollectionLiteralsBool! Item was added: + ----- Method: CompilationCue class>>source:writableCollectionLiterals:environment: (in category 'instance creation') ----- + source: aString writableCollectionLiterals: writableCollectionLiterals environment: anEnvironment + ^ self + source: aString + context: nil + receiver: nil + class: UndefinedObject + environment: anEnvironment + requestor: nil + writableCollectionLiterals: writableCollectionLiterals! Item was removed: - ----- Method: CompilationCue>>initializeWithSource:context:receiver:class:environment:requestor: (in category 'initialization') ----- - initializeWithSource: aTextOrString context: aContext receiver: recObject class: aClass environment: anEnvironment requestor: reqObject - self initialize. - source := (aTextOrString isKindOf: PositionableStream) - ifTrue: [ aTextOrString ] - ifFalse: [ ReadStream on: aTextOrString asString ]. - context := aContext. - receiver := recObject. - class := aClass. - environment := anEnvironment. - requestor := reqObject! Item was added: + ----- Method: CompilationCue>>initializeWithSource:context:receiver:class:environment:requestor:writableCollectionLiterals: (in category 'initialization') ----- + initializeWithSource: aTextOrString context: aContext receiver: recObject class: aClass environment: anEnvironment requestor: reqObject writableCollectionLiterals: writableCollectionLiteralsBool + self initialize. + source := aTextOrString isStream + ifTrue: [ aTextOrString ] + ifFalse: [ ReadStream on: aTextOrString asString ]. + context := aContext. + receiver := recObject. + class := aClass. + environment := anEnvironment. + requestor := reqObject. + writableCollectionLiterals := writableCollectionLiteralsBool! Item was added: + ----- Method: CompilationCue>>writableCollectionLiterals (in category 'accessing') ----- + writableCollectionLiterals + ^writableCollectionLiterals! Item was added: + ----- Method: Compiler class>>evaluate:writableCollectionLiterals:environment: (in category 'evaluating') ----- + evaluate: aString writableCollectionLiterals: writableCollectionLiteralsBool environment: anEnvironment + ^ self new + evaluateCue: (CompilationCue + source: aString + writableCollectionLiterals: writableCollectionLiteralsBool + environment: anEnvironment) + ifFail: [^ nil]! Item was changed: ----- Method: Compiler>>evaluateCue:ifFail: (in category 'private') ----- evaluateCue: aCue ifFail: failBlock "Compiles the cue source into a parse tree, then generates code into a method. Finally, the compiled method is invoked from here via withArgs:executeMethod:, hence the system no longer creates Doit method litter on errors." | methodNode method value | methodNode := self compileCue: aCue noPattern: true ifFail: [^failBlock value]. method := self interactive ifTrue: [methodNode generateWithTempNames] ifFalse: [methodNode generate]. value := cue receiver withArgs: (cue context ifNil: [#()] ifNotNil: [{cue context}]) executeMethod: method. + cue writableCollectionLiterals ifTrue: + [method allLiteralsDo: + [:lit| self makeCollectionLiteralWritable: lit]]. ^ value ! Item was added: + ----- Method: Compiler>>makeCollectionLiteralWritable: (in category 'private') ----- + makeCollectionLiteralWritable: lit + "By default all literals are read-only. Usually this is exactly what we desire. + Sometimes this is inconvenient. This method makes collection literals, and + only collection literals, writable, in response to the writableCollectionLiterals cue" + lit isCollection ifTrue: + [lit beWritableObject. + lit isArray ifTrue: + [lit do: + [:subLiteral| self makeCollectionLiteralWritable: subLiteral]]]!

1 0

Croquet
by gettimothy 25 Mar '20

25 Mar '20

After core-dumping on running the FFI-Tests on the 32 bit box, I decided to reproduce on the 64 bit box. They all passed on the 64 bit box. 74 run in 0:00:00:00.002, 74 passes, 0 expected failures, 0 failures, 0 errors, 0 unexpected passes go figure. (:

2 2

squeak 4.10 on files.squeak.org ?
by stes 25 Mar '20

25 Mar '20

Hello, When I look on http://files.squeak.org the last 4.x directory I see is : 4.6alpha/ it has Squeak4.6-13700.zip 2014-03-17 20:23 12.0M File Squeak4.6-14191.zip 2015-03-06 19:37 12.6M File On the other hand on the squeakvm.org website there seems to be a 4.10 the page http://squeakvm.org/unix/ states: "Generated Sources Anyone who has tried to recreate the VM 'from first principles' knows that it is often difficult (or impossible) to assemble all the necessary pieces of the image in compatible versions. For that reason I am now archiving the images that I use to generate sources for every released version along with the VMMaker configuration. Regenerating 'src' from this preloaded VMMaker image unix-4.10.2.image unix-4.10.2.changes unix-4.10.2.config should yield a 'src' directory identical to the one in the repository at revision 2614. " My question is now : why are those 4.10 image/changes files not on files.squeak.org ? Also what is the meaning of the revision 2614 compared to the numbers 13700 and 14191 in the files.squeak.org filenames ? Thanks! -- Sent from: http://forum.world.st/Squeak-Dev-f45488.html

3 2

Croquet FFI tests segfault
by gettimothy 25 Mar '20

25 Mar '20

Per Bert, I ran the FFI-Tests->FFIPluginTests(74 tests) and squeak 5.3 on 32 bit machine segfaults. I ran squeak as squeak.sh >> debug. text of debug is at bottom of this email. Suggestions on how to isolate which test(s) are barfing and I will do that to try and hunt it down thanks ----------------------------------debug below-------------- Using /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak... 8 ints came in as i1 = 12 (c) i2 = 29 (1d) i3 = 46 (2e) i4 = 63 (3f) i5 = 0 (0) i6 = 162350382 (9ad452e) i7 = 0 (0) i8 = 85 (55) 8 long longs came in as i1 = -103079215112 (ffffffe7fffffff8) i2 = -34359738352 (fffffff800000010) i3 = 34359738408 (800000028) i4 = 103079215168 (1800000040) i5 = 171798691928 (2800000058) i6 = 240518168688 (3800000070) i7 = 4 (4) i8 = 162360629 (9ad6d35) 4 characters came in as c1 = \0 (0) c2 = \0 (0) c3 = \0 (0) c4 = \0 (0) The two floats are 0.000000 and 0.000000 The two floats are 0.000000 and 0.000000 4 ints came in as i1 = 0 (0) i2 = 0 (0) i3 = 131632 (20230) i4 = 0 (0) Segmentation fault Wed Mar 25 07:00:59 2020 /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak Squeak VM version: 5.0-202003021730 Tue Mar 3 08:28:29 UTC 2020 gcc 5.4.0 [Production Spur VM] Built from: CoInterpreter VMMaker.oscog-nice.2712 uuid: da64ef0b-fb0a-4770-ac16-f9b448234615 Mar 3 2020 With: StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020 Revision: VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Build host: Linux travis-job-56ef6ed6-a99c-4420-b3aa-37bf991d063a 4.15.0-1028-gcp #29~16.04.1-Ubuntu SMP Tue Feb 12 16:31:10 UTC 2019 i686 i686 i686 GNU/Linux plugin path: /home/wm/usr/src/smalltalk/squeak5.3/bin/ [default: /home/wm/usr/src/smalltalk/squeak5.3/bin/] C stack backtrace & registers: eax 0x7cd17041 ebx 0x00000072 ecx 0x00000072 edx 0x0d0ace14 edi 0xbfbbab38 esi 0xbfbbab38 ebp 0xbfba7dc8 esp 0xbfba7d60 eip 0x0809d420 */home/wm/usr/src/smalltalk/squeak5.3/bin/squeak(interpret+0x1440)[0x809d420] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak[0x805ee55] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak[0x8060883] linux-gate.so.1(__kernel_rt_sigreturn+0x0)[0xb7749ba0] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak(interpret+0x1440)[0x809d420] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak[0x80a549b] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak(interpret+0x1e5)[0x809c1c5] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak(main+0x2f1)[0x805e381] /lib/libc.so.6(__libc_start_main+0x107)[0xb752a697] /home/wm/usr/src/smalltalk/squeak5.3/bin/squeak[0x805e6b4] [0x1000] Smalltalk stack dump: 0xbfbbac10 I SmallInteger(ExternalFunction)>invokeWithArguments: 0x101=128 0xbfbbac34 I ExternalLibraryFunction(ExternalFunction)>invokeWith: 0x9d9ef38: a(n) ExternalLibraryFunction 0xbfbbac60 I FFIPluginTests>testConstructedPrintString 0x9bebcd0: a(n) FFIPluginTests 0xbfbbac78 M FFIPluginTests(TestCase)>performTest 0x9bebcd0: a(n) FFIPluginTests 0xbfbbac90 M [] in FFIPluginTests(TestCase)>runCase 0x9bebcd0: a(n) FFIPluginTests 0xbfbbacac M BlockClosure>on:do: 0x9d9e7e0: a(n) BlockClosure 0xbfbbacd4 M [] in FFIPluginTests(TestCase)>timeout:after: 0x9bebcd0: a(n) FFIPluginTests 0xbfbbacf4 M BlockClosure>ensure: 0x9d9ed28: a(n) BlockClosure 0xbfbbad1c M FFIPluginTests(TestCase)>timeout:after: 0x9bebcd0: a(n) FFIPluginTests 0xbfbbad3c M [] in FFIPluginTests(TestCase)>runCase 0x9bebcd0: a(n) FFIPluginTests 0xbfbbad5c M BlockClosure>ensure: 0x9d9e098: a(n) BlockClosure 0xbfbbad78 M FFIPluginTests(TestCase)>runCase 0x9bebcd0: a(n) FFIPluginTests 0xbfbbad94 M [] in TestResult>runCase: 0x9b92850: a(n) TestResult 0xbfbbadb0 M Time class>microsecondsToRun: 0xa2cde48: a(n) Time class 0xbfbbadcc M Time class>millisecondsToRun: 0xa2cde48: a(n) Time class 0xbfbb29f8 M BlockClosure>timeToRun 0x9d9df50: a(n) BlockClosure 0xbfbb2a14 M BlockClosure>timeToRunWithoutGC 0x9d9df50: a(n) BlockClosure 0xbfbb2a34 M [] in TestResult>runCase: 0x9b92850: a(n) TestResult 0xbfbb2a50 M BlockClosure>on:do: 0x9d9de10: a(n) BlockClosure 0xbfbb2a78 M [] in BlockClosure>on:do:on:do: 0x9d9de10: a(n) BlockClosure 0xbfbb2a94 M BlockClosure>on:do: 0x9d9ded0: a(n) BlockClosure 0xbfbb2ab4 M BlockClosure>on:do:on:do: 0x9d9de10: a(n) BlockClosure 0xbfbb2ae0 M TestResult>runCase: 0x9b92850: a(n) TestResult 0xbfbb2afc M FFIPluginTests(TestCase)>run: 0x9bebcd0: a(n) FFIPluginTests 0xbfbb2b18 M TestRunner>runTest: 0xdd3b320: a(n) TestRunner 0xbfbb2b34 M [] in TestRunner>runSuite: 0xdd3b320: a(n) TestRunner 0xbfbb2b6c M [] in OrderedCollection(Collection)>do:displayingProgress:every: 0x9ba9ea8: a(n) OrderedCollection 0xbfbb2b8c M OrderedCollection>do: 0x9ba9ea8: a(n) OrderedCollection 0xbfbb2bbc M [] in OrderedCollection(Collection)>do:displayingProgress:every: 0x9ba9ea8: a(n) OrderedCollection 0xbfbb2be4 M [] in MorphicUIManager>displayProgress:at:from:to:during: 0xb874b60: a(n) MorphicUIManager 0xbfbb2c00 M BlockClosure>on:do: 0x9ba9f98: a(n) BlockClosure 0xbfbb2c2c M [] in MorphicUIManager>displayProgress:at:from:to:during: 0xb874b60: a(n) MorphicUIManager 0xbfbb2c4c M BlockClosure>ensure: 0x9baa030: a(n) BlockClosure 0xbfbb2c78 I MorphicUIManager>displayProgress:at:from:to:during: 0xb874b60: a(n) MorphicUIManager 0xbfbb2cac I ProgressInitiationException>defaultResumeValue 0x9baa0c8: a(n) ProgressInitiationException 0xbfbb2cd0 I ProgressInitiationException(Exception)>resume 0x9baa0c8: a(n) ProgressInitiationException 0xbfbb2cf0 I ProgressInitiationException>defaultAction 0x9baa0c8: a(n) ProgressInitiationException 0xbfbb2d14 I UndefinedObject>handleSignal: 0x9fc4c70: a(n) UndefinedObject 0xbfbb2d38 I ProgressInitiationException(Exception)>signal 0x9baa0c8: a(n) ProgressInitiationException 0xbfbb2d58 I ProgressInitiationException>display:at:from:to:during: 0x9baa0c8: a(n) ProgressInitiationException 0xbfbb2d8c I ProgressInitiationException class>display:at:from:to:during: 0xa3dc1a8: a(n) ProgressInitiationException class 0xbfbb2dc0 I ByteString(String)>displayProgressAt:from:to:during: 0xb2bae48: a(n) ByteString 0xbfbb3b94 I ByteString(String)>displayProgressFrom:to:during: 0xb2bae48: a(n) ByteString 0xbfbb3bcc I OrderedCollection(Collection)>do:displayingProgress:every: 0x9ba9ea8: a(n) OrderedCollection 0xbfbb3bfc M [] in TestRunner>basicRunSuite:do: 0xdd3b320: a(n) TestRunner 0xbfbb3c1c M BlockClosure>ensure: 0x9baa370: a(n) BlockClosure 0xbfbb3c40 I TestRunner>basicRunSuite:do: 0xdd3b320: a(n) TestRunner 0xbfbb3c68 I TestRunner>runSuite: 0xdd3b320: a(n) TestRunner 0xbfbb3c8c I TestRunner>runAll 0xdd3b320: a(n) TestRunner 0xbfbb3cac I PluggableButtonMorphPlus(PluggableButtonMorph)>performAction 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3ccc I PluggableButtonMorphPlus>performAction 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3ce8 M [] in PluggableButtonMorphPlus(PluggableButtonMorph)>mouseUp: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3d0c M Array(SequenceableCollection)>do: 0x9baa4b0: a(n) Array 0xbfbb3d30 I PluggableButtonMorphPlus(PluggableButtonMorph)>mouseUp: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3d4c M PluggableButtonMorphPlus(Morph)>handleMouseUp: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3d68 M MouseButtonEvent>sentTo: 0x9baa468: a(n) MouseButtonEvent 0xbfbb3d88 M PluggableButtonMorphPlus(Morph)>handleEvent: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3da4 M PluggableButtonMorphPlus(Morph)>handleFocusEvent: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb3dc8 M MorphicEventDispatcher>doHandlingForFocusEvent:with: 0x9ba9650: a(n) MorphicEventDispatcher 0xbfbb0acc M MorphicEventDispatcher>dispatchFocusEvent:with: 0x9ba9650: a(n) MorphicEventDispatcher 0xbfbb0aec M PluggableButtonMorphPlus(Morph)>processFocusEvent:using: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb0b0c M PluggableButtonMorphPlus(Morph)>processFocusEvent: 0x9ba96c0: a(n) PluggableButtonMorphPlus 0xbfbb0b34 M [] in HandMorph>sendFocusEvent:to:clear: 0xa5a34a0: a(n) HandMorph 0xbfbb0b54 M BlockClosure>ensure: 0x9ba9770: a(n) BlockClosure 0xbfbb0b74 M MouseButtonEvent(MorphicEvent)>becomeActiveDuring: 0x9b94710: a(n) MouseButtonEvent 0xbfbb0b9c M [] in HandMorph>sendFocusEvent:to:clear: 0xa5a34a0: a(n) HandMorph 0xbfbb0bbc M BlockClosure>ensure: 0x9ba9868: a(n) BlockClosure 0xbfbb0bdc M HandMorph>becomeActiveDuring: 0xa5a34a0: a(n) HandMorph 0xbfbb0c04 M [] in HandMorph>sendFocusEvent:to:clear: 0xa5a34a0: a(n) HandMorph 0xbfbb0c24 M BlockClosure>ensure: 0x9ba9960: a(n) BlockClosure 0xbfbb0c44 M PasteUpMorph>becomeActiveDuring: 0xa395e38: a(n) PasteUpMorph 0xbfbb0c68 M HandMorph>sendFocusEvent:to:clear: 0xa5a34a0: a(n) HandMorph 0xbfbb0c94 M HandMorph>sendEvent:focus:clear: 0xa5a34a0: a(n) HandMorph 0xbfbb0cb8 M HandMorph>sendMouseEvent: 0xa5a34a0: a(n) HandMorph 0xbfbb0cd8 M HandMorph>handleEvent: 0xa5a34a0: a(n) HandMorph 0xbfbb0d04 M HandMorph>processEvents 0xa5a34a0: a(n) HandMorph 0xbfbb0d20 M [] in WorldState>doOneCycleNowFor: 0xa534910: a(n) WorldState 0xbfbb0d44 M Array(SequenceableCollection)>do: 0x9fde028: a(n) Array 0xbfbb0d60 M WorldState>handsDo: 0xa534910: a(n) WorldState 0xbfbb0d80 M WorldState>doOneCycleNowFor: 0xa534910: a(n) WorldState 0xbfbb0d9c M WorldState>doOneCycleFor: 0xa534910: a(n) WorldState 0xbfbb0db8 M PasteUpMorph>doOneCycle 0xa395e38: a(n) PasteUpMorph 0xbfbb0dd0 M [] in MorphicProject>spawnNewProcess 0xa6618e8: a(n) MorphicProject 0xd647100 s [] in BlockClosure>newProcess Most recent primitives @ @ @ @ copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits @ @ @ @ truncated @ @ bitAnd: @ @ @ @ @ @ @ @ @ @ @ @ @ copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits copyBits @ basicNew: @ @ @ @ @ @ @ @ @ @ @ @ @ @ @ copyBits @ @ @ @ @ @ @ @ copyBits @ @ @ copyBits @ @ @ @ @ @ @ @ @ @ copyBits @ @ @ @ @ @ @ @ @ @ @ @ copyBits copyBits copyBits copyBits @ @ @ @ @ @ @ @ @ @ copyBits @ @ @ @ @ @ @ @ fractionPart truncated fractionPart truncated fractionPart truncated @ @ @ @ @ @ @ @ @ @ copyBits @ @ + at:put: @ @ @ @ @ @ @ @ @ @ copyBits copyBits copyBits copyBits @ @ @ @ primDisplayString:from:to:map:xTable:kern: @ primDisplayString:from:to:map:xTable:kern: @ primShowRectLeft:right:top:bottom: primitiveDeferUpdates: forceDisplayUpdate findNextUnwindContextUpTo: tempAt: tempAt:put: tempAt: terminateTo: tempAt:put: findNextUnwindContextUpTo: terminateTo: utcMicrosecondClock // vmParameterAt: vmParameterAt: **StackOverflow** utcMicrosecondClock getSystemAttribute: getSystemAttribute: basicNew: stackp: resume wait signal utcMicrosecondClock + < <= >= + < primSignal:atUTCMicroseconds: wait signal wait signal suspend getSystemAttribute: getSystemAttribute: basicNew: stackp: resume wait signal utcMicrosecondClock + < <= >= + < primSignal:atUTCMicroseconds: wait signal wait perform: hashWithInitialHash: compare:with:collated: at: headerWord hashWithInitialHash: compare:with:collated: invokeWithArguments: stack page bytes 4096 available headroom 2788 minimum unused headroom 3012 (Segmentation fault)

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
32
Older →

Jump to page: