Squeak-dev April 2020

squeak-dev@lists.squeakfoundation.org

39 participants
236 discussions

The Trunk: ST80-mt.250.mcz
by commits＠source.squeak.org 15 Apr '20

15 Apr '20

Marcel Taeumel uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-mt.250.mcz ==================== Summary ==================== Name: ST80-mt.250 Author: mt Time: 15 April 2020, 3:57:45.964534 pm UUID: e34860eb-ab2f-944c-a581-3df631705a37 Ancestors: ST80-eem.249 Complements ToolBuilder-Kernel-mt.138. And fixes the issue that choosing "find and replace" from the menu raised a debugger. =============== Diff against ST80-eem.249 =============== Item was changed: ----- Method: FillInTheBlank class>>request:initialAnswer:centerAt: (in category 'instance creation') ----- request: queryString initialAnswer: defaultAnswer centerAt: aPoint - "Create an instance of me whose question is queryString with the given - initial answer. Invoke it centered at the given point, and answer the - string the user accepts. Answer the empty string if the user cancels." + ^ self + request: queryString + initialAnswer: defaultAnswer + centerAt: aPoint + onCancelReturn: ''! - "UIManager default - request: 'Type something, then type CR.' - initialAnswer: 'yo ho ho!!' - centerAt: Display center" - - | model fillInView | - Smalltalk isMorphic - ifTrue: - [^self fillInTheBlankMorphClass - request: queryString - initialAnswer: defaultAnswer - centerAt: aPoint]. - model := self new. - model contents: defaultAnswer. - fillInView := self fillInTheBlankViewClass - on: model - message: queryString - centerAt: aPoint. - ^model show: fillInView! Item was added: + ----- Method: FillInTheBlank class>>request:initialAnswer:centerAt:onCancelReturn: (in category 'instance creation') ----- + request: queryString initialAnswer: defaultAnswer centerAt: aPoint onCancelReturn: cancelResponse + "Create an instance of me whose question is queryString with the given + initial answer. Invoke it centered at the given point, and answer the + string the user accepts. Answer the empty string if the user cancels." + + "UIManager default + request: 'Type something, then type CR.' + initialAnswer: 'yo ho ho!!' + centerAt: Display center" + + | model fillInView | + Smalltalk isMorphic + ifTrue: + [^self fillInTheBlankMorphClass + request: queryString + initialAnswer: defaultAnswer + centerAt: aPoint]. + model := self new. + model contents: defaultAnswer. + model responseUponCancel: cancelResponse. + fillInView := self fillInTheBlankViewClass + on: model + message: queryString + centerAt: aPoint. + ^model show: fillInView! Item was added: + ----- Method: FillInTheBlank class>>request:initialAnswer:onCancelReturn: (in category 'instance creation') ----- + request: queryString initialAnswer: defaultAnswer onCancelReturn: cancelResponse + + ^ self + request: queryString + initialAnswer: defaultAnswer + centerAt: (ActiveHand ifNil:[Sensor]) cursorPoint + onCancelReturn: cancelResponse! Item was added: + ----- Method: ParagraphEditor>>findReplace (in category 'menu messages') ----- + findReplace + + (Project uiManager + request: 'Find what to replace?' + initialAnswer: FindText) + ifNotEmpty: [:find | + + (Project uiManager + request: ('Replace ''{1}'' with?' format: {find}) + initialAnswer: (ChangeText ifEmpty: [find]) + onCancelReturn: nil) + ifNotNil: [:replace | + + FindText := find. + ChangeText := replace. + self againOrSame: true ]]!

1 0

The Trunk: ToolBuilder-MVC-mt.59.mcz
by commits＠source.squeak.org 15 Apr '20

15 Apr '20

Marcel Taeumel uploaded a new version of ToolBuilder-MVC to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-MVC-mt.59.mcz ==================== Summary ==================== Name: ToolBuilder-MVC-mt.59 Author: mt Time: 15 April 2020, 3:56:47.074534 pm UUID: 3523b197-7793-cc40-baef-9cf2518ced06 Ancestors: ToolBuilder-MVC-mt.58 Complements ToolBuilder-Kernel-mt.138 =============== Diff against ToolBuilder-MVC-mt.58 =============== Item was added: + ----- Method: MVCUIManager>>request:initialAnswer:onCancelReturn: (in category 'ui requests') ----- + request: queryString initialAnswer: defaultAnswer onCancelReturn: cancelResponse + "Create an instance of me whose question is queryString with the given initial answer. Answer the string the user accepts. Answer cancelResponse if the user cancels." + + self askForProvidedAnswerTo: queryString ifSupplied: [:answer | + ^ answer = #default + ifTrue: [defaultAnswer] + ifFalse: [answer]]. + + ^ FillInTheBlank + request: queryString + initialAnswer: defaultAnswer + onCancelReturn: cancelResponse!

1 0

The Trunk: ToolBuilder-Morphic-mt.257.mcz
by commits＠source.squeak.org 15 Apr '20

15 Apr '20

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.257.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.257 Author: mt Time: 15 April 2020, 3:56:21.096534 pm UUID: d24dd086-2194-9444-bff3-29bc71ae3e5a Ancestors: ToolBuilder-Morphic-mt.256 Complements ToolBuilder-Kernel-mt.138. =============== Diff against ToolBuilder-Morphic-mt.256 =============== Item was added: + ----- Method: MorphicUIManager>>request:initialAnswer:onCancelReturn: (in category 'ui requests') ----- + request: queryString initialAnswer: defaultAnswer onCancelReturn: cancelResponse + "Create an instance of me whose question is queryString with the given initial answer. Answer the string the user accepts. Answer cancelResponse if the user cancels." + + self askForProvidedAnswerTo: queryString ifSupplied: [:answer | + ^ answer = #default + ifTrue: [defaultAnswer] + ifFalse: [answer]]. + + ^ FillInTheBlankMorph + request: queryString + initialAnswer: defaultAnswer + onCancelReturn: cancelResponse!

1 0

Find and Replace with nothing does not work. Requires a space to get it to work
by gettimothy 15 Apr '20

15 Apr '20

Hi folks, Just an FYI I have a very long test (don't ask) in my PEG Grammar for a long rule. I am attempting to find and replace actor transcripton: false. Note the empty line above the "actor transcription: false" If I do a Find and Replace on this, I cannot just leave the "replace" dialog empty. I must enter at least one space character to get it to do the job. cheers, t

2 1

The Trunk: Morphic-mt.1644.mcz
by commits＠source.squeak.org 15 Apr '20

15 Apr '20

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1644.mcz ==================== Summary ==================== Name: Morphic-mt.1644 Author: mt Time: 15 April 2020, 3:08:24.191047 pm UUID: 230c1e8d-5cad-1d44-a3db-29bc3887e602 Ancestors: Morphic-mt.1643 Revising the latest fix in TableLayout. Thanks to Levente for pointing this out. There is no benefit in renaming "arrangement" into "cells". =============== Diff against Morphic-mt.1643 =============== Item was changed: ----- Method: TableLayout>>computeExtraSpacing:in:horizontal:target: (in category 'layout') ----- computeExtraSpacing: arrangement in: newBounds horizontal: aBool target: aMorph "Compute the required extra spacing for laying out the cells" "match newBounds extent with arrangement's orientation" | extent extra centering n extraPerCell cell last hFill vFill max amount allow | extent := newBounds extent. aBool ifFalse: [extent := extent transposed]. "figure out if we have any horizontal or vertical space fillers" hFill := vFill := false. max := 0 @ 0. arrangement do: [:c | max := (max x max: c cellSize x) @ (max y + c cellSize y). max := max max: c cellSize. hFill := hFill or: [c hSpaceFill]. vFill := vFill or: [c vSpaceFill]]. "Take client's shrink wrap constraints into account. Note: these are only honored when there are no #spaceFill children, or when #rubberBandCells is set." allow := properties rubberBandCells not. aMorph hResizing == #shrinkWrap ifTrue: [aBool ifTrue: [allow & hFill ifFalse: [extent := max x @ (max y max: extent y)]] ifFalse: [allow & vFill ifFalse: [extent := (max x max: extent x) @ max y]]]. aMorph vResizing == #shrinkWrap ifTrue: [aBool ifFalse: [allow & hFill ifFalse: [extent := max x @ (max y max: extent y)]] ifTrue: [allow & vFill ifFalse: [extent := (max x max: extent x) @ max y]]]. "Now compute the extra v space" extra := extent y - (arrangement inject: 0 into: [:sum :c | sum + c cellSize y]). extra > 0 ifTrue: ["Check if we have any #spaceFillers" vFill ifTrue: ["use only #spaceFillers" n := arrangement inject: 0 into: [:sum :c | c vSpaceFill ifTrue: [sum + 1] ifFalse: [sum]]. n isZero ifFalse: [extraPerCell := extra asFloat / n asFloat]. extra := last := 0. arrangement do: [:c | c vSpaceFill ifTrue: [extra := (last := extra) + extraPerCell. amount := 0 @ (extra truncated - last truncated). c do: [:cc | cc cellSize: cc cellSize + amount]]]] ifFalse: ["no #spaceFillers; distribute regularly" centering := properties wrapCentering. "centering == #topLeft ifTrue:[]." "add all extra space to the last cell; e.g., do nothing" centering == #bottomRight ifTrue: ["add all extra space to the first cell" + arrangement ifNotEmpty: [arrangement first addExtraSpace: 0 @ extra]]. - arrangement ifNotEmpty: [:cells | cells first addExtraSpace: 0 @ extra]]. centering == #center ifTrue: ["add 1/2 extra space to the first and last cell" + arrangement ifNotEmpty: [arrangement first addExtraSpace: 0 @ (extra // 2)]]. - arrangement ifNotEmpty: [:cells | cells first addExtraSpace: 0 @ (extra // 2)]]. centering == #justified ifTrue: ["add extra space equally distributed to each cell" n := arrangement size - 1 max: 1. extraPerCell := extra asFloat / n asFloat. extra := last := 0. arrangement do: [:c | c addExtraSpace: 0 @ (extra truncated - last truncated). extra := (last := extra) + extraPerCell]]]]. "Now compute the extra space for the primary direction" centering := properties listCentering. 1 to: arrangement size do: [:i | cell := arrangement at: i. extra := extent x - cell cellSize x. extra > 0 ifTrue: ["Check if we have any #spaceFillers" cell := cell nextCell. cell hSpaceFill ifTrue: ["use only #spaceFillers" n := cell inject: 0 into: [:sum :c | c hSpaceFill ifTrue: [sum + c target spaceFillWeight] ifFalse: [sum]]. n isZero ifFalse: [extraPerCell := extra asFloat / n asFloat]. extra := last := 0. cell do: [:c | c hSpaceFill ifTrue: [extra := (last := extra) + (extraPerCell * c target spaceFillWeight). amount := extra truncated - last truncated. c cellSize: c cellSize + (amount @ 0)]]] ifFalse: ["no #spaceFiller; distribute regularly" "centering == #topLeft ifTrue:[]" "add all extra space to the last cell; e.g., do nothing" centering == #bottomRight ifTrue: ["add all extra space to the first cell" cell addExtraSpace: extra @ 0]. centering == #center ifTrue: ["add 1/2 extra space to the first and last cell" cell addExtraSpace: (extra // 2) @ 0]. centering == #justified ifTrue: ["add extra space equally distributed to each cell" n := cell size - 1 max: 1. extraPerCell := extra asFloat / n asFloat. extra := last := 0. cell do: [:c | c addExtraSpace: (extra truncated - last truncated) @ 0. extra := (last := extra) + extraPerCell]]]]]!

1 0

The Trunk: System-mt.1151.mcz
by commits＠source.squeak.org 15 Apr '20

15 Apr '20

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1151.mcz ==================== Summary ==================== Name: System-mt.1151 Author: mt Time: 15 April 2020, 11:08:14.421692 am UUID: ed2417d1-2e26-7048-90a0-6ecadf2ade6f Ancestors: System-mt.1150 Fix typo and choose a more friendly color for text highlights in trees in Squeak's standard UI theme. For example, those highlights are used for indicating monitors on nodes in the ObjectExplorer's tree. I hope you agree that that color should not indicate an erroneous state. So red felt kind of harsh. =============== Diff against System-mt.1150 =============== Item was changed: ----- Method: SqueakTheme class>>addScrollables: (in category 'instance creation') ----- addScrollables: theme "self create apply" "Sliders" theme set: #borderColor for: #Slider to: Color gray; set: #borderWidth for: #Slider to: 1; set: #color for: #Slider to: Color lightGray; set: #thumbBorderColor for: #Slider to: [Color gray: 0.6]; set: #thumbBorderWidth for: #Slider to: 0; set: #thumbColor for: #Slider to: Color veryVeryLightGray; set: #thumbShadowModifier for: #Slider to: [ [:c | c alpha: 0.7] ]. "Scroll bars" theme set: #thumbBorderWidth for: #ScrollBar to: 1; set: #thumbColorModifier for: #ScrollBar to: [ [:c | c] ]; set: #pagingAreaColorModifier for: #ScrollBar to: [ [:c | c darker alpha: 0.35] ]; set: #borderColorModifier for: #ScrollBar to: [ [:c | c adjustBrightness: -0.3] ]. "Scroll panes (includes generic stuff for list widgets, tree widgets, and text widgets." theme set: #borderColor for: #ScrollPane to: (Color gray: 0.6); set: #borderWidth for: #ScrollPane to: 1; set: #borderStyle for: #ScrollPane to: BorderStyle simple; set: #color for: #ScrollPane to: Color white. "List widgets" theme set: #font for: #PluggableListMorph to: [Preferences standardListFont]; set: #textColor for: #PluggableListMorph to: Color black; set: #selectionColor for: #PluggableListMorph to: (Color r: 0.72 g: 0.72 b: 0.9); derive: #multiSelectionColor for: #PluggableListMorph from: #PluggableListMorph at: #selectionColor do: [:c | c lighter]; set: #selectionTextColor for: #PluggableListMorph to: Color black; set: #filterColor for: #PluggableListMorph to: Color yellow paler; set: #filterTextColor for: #PluggableListMorph to: Color black; set: #preSelectionModifier for: #PluggableListMorph to: [ [:c | Color gray: 0.9] ]; set: #hoverSelectionModifier for: #PluggableListMorph to: [ [:c | c darker alpha: 0.3] ]. "Tree widgets" theme derive: #font for: #SimpleHierarchicalListMorph from: #PluggableListMorph; derive: #textColor for: #SimpleHierarchicalListMorph from: #PluggableListMorph; derive: #selectionColor for: #SimpleHierarchicalListMorph from: #PluggableListMorph; derive: #selectionTextColor for: #SimpleHierarchicalListMorph from: #PluggableListMorph; derive: #filterColor for: #SimpleHierarchicalListMorph from: #PluggableListMorph; derive: #filterTextColor for: #SimpleHierarchicalListMorph from: #PluggableListMorph; derive: #hoverSelectionModifier for: #SimpleHierarchicalListMorph from: #PluggableListMorph; + set: #highlightTextColor for: #SimpleHierarchicalListMorph to: Color fern; - set: #higlightTextColor for: #SimpleHierarchicalListMorph to: Color red; set: #lineColor for: #SimpleHierarchicalListMorph to: Color veryLightGray. "Text widgets" theme set: #font for: #PluggableTextMorph to: [Preferences standardSystemFont]; set: #textColor for: #PluggableTextMorph to: Color black; set: #caretColor for: #PluggableTextMorph to: Color red; set: #selectionColor for: #PluggableTextMorph to: (TranslucentColor r: 0.0 g: 0.0 b: 0.8 alpha: 0.2); set: #unfocusedSelectionModifier for: #PluggableTextMorph to: [ [:c | Color gray: 0.9] ]; set: #adornmentReadOnly for: #PluggableTextMorph to: Color black; set: #adornmentRefuse for: #PluggableTextMorph to: Color tan; set: #adornmentConflict for: #PluggableTextMorph to: Color red; set: #adornmentDiff for: #PluggableTextMorph to: Color green; set: #adornmentNormalEdit for: #PluggableTextMorph to: Color orange; set: #adornmentDiffEdit for: #PluggableTextMorph to: Color yellow; set: #frameAdornmentWidth for: #PluggableTextMorph to: 1. theme set: #balloonTextColor for: #PluggableTextMorphPlus to: (Color gray: 0.7); derive: #balloonTextFont for: #PluggableTextMorphPlus from: #PluggableTextMorph at: #font.!

1 0

The Trunk: GraphicsTests-eem.54.mcz
by commits＠source.squeak.org 15 Apr '20

15 Apr '20

Eliot Miranda uploaded a new version of GraphicsTests to project The Trunk: http://source.squeak.org/trunk/GraphicsTests-eem.54.mcz ==================== Summary ==================== Name: GraphicsTests-eem.54 Author: eem Time: 14 April 2020, 5:36:18.540866 pm UUID: c06dde54-9aee-4d1b-b32c-81aa7a57802a Ancestors: GraphicsTests-nice.53 Add the more complete set of tests for the JPEGReadWriter2Plugin from VMMaker to the base JPEGReadWriter2Test =============== Diff against GraphicsTests-nice.53 =============== Item was added: + ----- Method: JPEGReadWriter2Test>>formBytes (in category 'private') ----- + formBytes + "A jpeg that was generated from Squeak. When written to and from a + stream, the same bytes should be obtained." + + ^ #(255 216 255 224 0 16 74 70 73 70 0 1 1 0 0 1 0 1 0 0 255 219 0 67 0 8 6 6 7 6 5 8 7 7 7 9 9 8 10 12 20 13 12 11 11 12 25 18 19 15 20 29 26 31 30 29 26 28 28 32 36 46 39 32 34 44 35 28 28 40 55 41 44 48 49 52 52 52 31 39 57 61 56 50 60 46 51 52 50 255 219 0 67 1 9 9 9 12 11 12 24 13 13 24 50 33 28 33 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 50 255 192 0 17 8 0 1 0 1 3 1 34 0 2 17 1 3 17 1 255 196 0 31 0 0 1 5 1 1 1 1 1 1 0 0 0 0 0 0 0 0 1 2 3 4 5 6 7 8 9 10 11 255 196 0 181 16 0 2 1 3 3 2 4 3 5 5 4 4 0 0 1 125 1 2 3 0 4 17 5 18 33 49 65 6 19 81 97 7 34 113 20 50 129 145 161 8 35 66 177 193 21 82 209 240 36 51 98 114 130 9 10 22 23 24 25 26 37 38 39 40 41 42 52 53 54 55 56 57 58 67 68 69 70 71 72 73 74 83 84 85 86 87 88 89 90 99 100 101 102 103 104 105 106 115 116 117 118 119 120 121 122 131 132 133 134 135 136 137 138 146 147 148 149 150 151 152 153 154 162 163 164 165 166 167 168 169 170 178 179 180 181 182 183 184 185 186 194 195 196 197 198 199 200 201 202 210 211 212 213 214 215 216 217 218 225 226 227 228 229 230 231 232 233 234 241 242 243 244 245 246 247 248 249 250 255 196 0 31 1 0 3 1 1 1 1 1 1 1 1 1 0 0 0 0 0 0 1 2 3 4 5 6 7 8 9 10 11 255 196 0 181 17 0 2 1 2 4 4 3 4 7 5 4 4 0 1 2 119 0 1 2 3 17 4 5 33 49 6 18 65 81 7 97 113 19 34 50 129 8 20 66 145 161 177 193 9 35 51 82 240 21 98 114 209 10 22 36 52 225 37 241 23 24 25 26 38 39 40 41 42 53 54 55 56 57 58 67 68 69 70 71 72 73 74 83 84 85 86 87 88 89 90 99 100 101 102 103 104 105 106 115 116 117 118 119 120 121 122 130 131 132 133 134 135 136 137 138 146 147 148 149 150 151 152 153 154 162 163 164 165 166 167 168 169 170 178 179 180 181 182 183 184 185 186 194 195 196 197 198 199 200 201 202 210 211 212 213 214 215 216 217 218 226 227 228 229 230 231 232 233 234 242 243 244 245 246 247 248 249 250 255 218 0 12 3 1 0 2 17 3 17 0 63 0 40 162 138 0 255 217) asByteArray! Item was added: + ----- Method: JPEGReadWriter2Test>>testPluginPresent (in category 'tests') ----- + testPluginPresent + + self assert: JPEGReadWriter2 new isPluginPresent! Item was added: + ----- Method: JPEGReadWriter2Test>>testPrimJPEGReadImage (in category 'tests') ----- + testPrimJPEGReadImage + + | form | + form := JPEGReadWriter2 formFromStream: self formBytes readStream. + self should: form bits first = 16rFF808080 + + "[Vm-dev] JPEGReadWriter2Plugin + Bert Freudenberg bert at freudenbergs.de + Mon Sep 27 15:22:43 UTC 2010 + + Hi, + + have there been changes lately to the jpeg plugin? + + On a Mac 4.2.4 VM I see an off-by-one error, all pixels are moved to the right, the first pixel is transparent. On a Mac 5.8.1 Cog VM it works as expected though. + + Here's my little test: + + (JPEGReadWriter2 formFromStream: #[16rFF 16rD8 16rFF 16rE0 16r00 16r10 16r4A 16r46 16r49 16r46 16r00 16r01 16r01 16r01 16r00 16r48 16r00 16r48 16r00 16r00 16rFF 16rDB 16r00 16r43 16r00 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rFF 16rC2 16r00 16r0B 16r08 16r00 16r01 16r00 16r01 16r01 16r01 16r11 16r00 16rFF 16rC4 16r00 16r14 16r10 16r01 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16r00 16rFF 16rDA 16r00 16r08 16r01 16r01 16r00 16r01 16r3F 16r10] readStream) bits first hex + + On 5.8.11 I get 16rFF808080 as expected, on 4.2.4 I get 0. + "! Item was added: + ----- Method: JPEGReadWriter2Test>>testPrimJPEGWriteImage (in category 'tests') ----- + testPrimJPEGWriteImage + + | form bytes ws | + form := JPEGReadWriter2 formFromStream: self formBytes readStream. + ws := WriteStream on: ByteArray new. + JPEGReadWriter2 putForm: form onStream: ws. + bytes := ws contents. + self should: self formBytes = bytes!

1 0

The Inbox: ST80-dtl.250.mcz
by commits＠source.squeak.org 12 Apr '20

12 Apr '20

David T. Lewis uploaded a new version of ST80 to project The Inbox: http://source.squeak.org/inbox/ST80-dtl.250.mcz ==================== Summary ==================== Name: ST80-dtl.250 Author: dtl Time: 12 April 2020, 3:57:39.533465 pm UUID: 427795eb-1858-4bd4-a28f-546b4a95eb62 Ancestors: ST80-eem.249 Do not burn CPU if there is nothing to do. If the ScreenController is the only scheduled controller available, then call interActivityPause before rescheduling it. =============== Diff against ST80-eem.249 =============== Item was changed: ----- Method: ControlManager>>nextActiveController (in category 'private') ----- nextActiveController "Answer the controller that would like control. If there was a click outside the active window, it's the top window that now has the mouse, otherwise it's just the top window." (newTopClicked notNil and: [newTopClicked]) ifTrue: [newTopClicked := false. ^ scheduledControllers detect: [:aController | aController isControlWanted] ifNone: [scheduledControllers first]] + ifFalse: [^ scheduledControllers first interActivityPause]! - ifFalse: [^ scheduledControllers first]!

1 0

Porting my programs from Squeak 3.10.2 to 3.5
by Trygve Reenskaug 11 Apr '20

11 Apr '20

Hi, I have been programming in Squeak3.10.2 for 10 years. Squeak 3.5 is a great improvement from the old 3.10.2 and it is time to update all my programs. There is a new VM that is different from the old. I'm used to letting the file extension identify the appropriate program for handling a file so I want to use a new file extension, /.image3/, for the /Squeak Cog Spur Virtual Machine/. It transpires that the String '.image' is embedded in any number of methods. In my Fortran days, we learned to avoid embedded constants because they had a tendency to change. (E.g., '3.14' to '3.14159265358979323846' because we needed higher precision.) Should I try to replace all embedded '.image' with a method call, e.g., Smalltalk imageExtension? --Trygve -- /The essence of object orientation is that objects collaborateto achieve a goal. / Trygve Reenskaug mailto: trygver(a)ifi.uio.no <mailto:%20trygver@ifi.uio.no> Morgedalsvn. 5A http://folk.uio.no/trygver/ N-0378 Oslo Norway Tel: (+47) 468 58 625

6 10

Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz
by Thiede, Christoph 11 Apr '20

11 Apr '20

Hi Jakob, hi all, > Did you intentionally not reply the mailing list? I could not find your previous mail on the list, too! However, we're back on the list now :) Hm ... what about deprecating #orderedItems and introducing a new #allItems instead? Then we could avoid any internal confusion and had a stable public protocol. > Which reminds me in general that Monticello classes could use some class comments. :-( A really good idea! :D Best, Christoph ________________________________ Von: Jakob Reschke <forums.jakob(a)resfarm.de> Gesendet: Samstag, 11. April 2020 15:53:11 An: Thiede, Christoph Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz Hi Christoph, Did you intentionally not reply the mailing list? We should care, the method is public and AFAIK the class is also not in some private category. Also "outsiders" should not care about the instance variable, but about the interface. Which was altered by this change. Which reminds me in general that Monticello classes could use some class comments. :-( Kinds regards, Jakob Thiede, Christoph <Christoph.Thiede(a)student.hpi.uni-potsdam.de<mailto:Christoph.Thiede@student.hpi.uni-potsdam.de>> schrieb am Sa., 11. Apr. 2020, 14:41: Hi Jakob, sorry for the late reply! My doubts about option 2 would be that as a developer of the sorter, you might not expect "self orderedItems" to return a different result than "orderedItems" (the instance variable). To me, this feels a bit like an anti-pattern. I don't know whether we have to care about compatibility outside the Trunk: If not, we could introduce a new getter such as #allOrderedItems for this purpose ... Best, Christoph <http://www.hpi.de/> ________________________________ Von: Jakob Reschke <forums.jakob(a)resfarm.de<mailto:forums.jakob@resfarm.de>> Gesendet: Freitag, 10. April 2020 08:39:31 An: Thiede, Christoph Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz Hi, Is there a use case for not getting all the items, or getting an intermediate list? There wasn't before, right? I would find it strange if I had to tell the sorter "give me what you have got, I mean all of it". This would be unusual and presumably easy to forget. So without further arguments, I would pick option 2. Kind regards, Jakob Am Fr., 10. Apr. 2020 um 00:33 Uhr schrieb Thiede, Christoph <Christoph.Thiede(a)student.hpi.uni-potsdam.de<mailto:Christoph.Thiede@student.hpi.uni-potsdam.de>>: > > Hi Jakob, > > > Thanks for the report - and I'm sorry to hear that I broke this! > > > The motivation for the deferred list was that #addToOrder: (and so the constructor #items:) actually does not sort the added items, but only their dependencies. That's why you need to send #addDeferred to the sorter after adding all other items. Before now, I did not realize that #orderedItems has external users. > > > So there are two options: > > 1. Permanently change the public protocol of the dependency sorter - if you want to get all items, you need to send #addDeferred ti the sorter before retrieving the #orderedItems. In the Trunk, we would need to update four senders in three classes for this solution. > > 2. Change #orderedItems to lazily append the deferred items to the returned list. This is not ideal as it makes the getter more expensive, but on the other hand, we can preserve compatibility by doing so. > > > I'm open for your opinion on both approaches, or for any other idea! :-) > > > Best, > > Christoph > > ________________________________ > Von: Jakob Reschke <forums.jakob(a)resfarm.de<mailto:forums.jakob@resfarm.de>> > Gesendet: Freitag, 10. April 2020 00:03:47 > An: Thiede, Christoph; squeak-dev(a)lists.squeakfoundation.org<mailto:squeak-dev@lists.squeakfoundation.org> > Betreff: Re: [squeak-dev] The Trunk: Monticello-ct.715.mcz > > Forgot to mention the net result of the issue: the postscripts gets > effectively removed in the saved version. > > Am Fr., 10. Apr. 2020 um 00:02 Uhr schrieb Jakob Reschke > <forums.jakob(a)resfarm.de<mailto:forums.jakob@resfarm.de>>: > > > > It looks like this broke the writing of postscripts in FileTree repositories. > > > > MCFileTreePackageStructureStWriter>>acceptVisitor:forDefinitions: > > (MCDependencySorter sortItems: aCollection) does not include an > > MCPostscriptDefinition that is still present in aCollection. > > > > MCDependencySorter class>>sortItems: > > The sorter includes the MCPostscriptDefinition in the new deferred > > list, but not in the orderedItems. Therefore it is not included in the > > result of sortItems:, because it only returns the orderedItems, not > > the deferred ones. > > > > Christoph, can and must sortItems: be fixed or a different method? > > > > > > Am Do., 5. März 2020 um 21:05 Uhr schrieb <commits(a)source.squeak.org<mailto:commits@source.squeak.org>>: > > > > > > Nicolas Cellier uploaded a new version of Monticello to project The Trunk: > > > http://source.squeak.org/trunk/Monticello-ct.715.mcz > > > > > > ==================== Summary ==================== > > > > > > Name: Monticello-ct.715 > > > Author: ct > > > Time: 6 February 2020, 6:58:26.533648 pm > > > UUID: 199bf8a3-5eee-1045-a44b-89ad30fa5523 > > > Ancestors: Monticello-cmm.708 > > > > > > Fixes wrong load and unload order of MCScriptDefinitions > > > > > > See http://forum.world.st/Monticello-Bug-Preamble-of-removal-is-executed-too-la…. Regression tests are in Tests-ct.426. > > > > > > Please review! > > > > > > =============== Diff against Monticello-cmm.708 =============== > > > > > > Item was added: > > > + ----- Method: MCDefinition>>wantsToBeOutermost (in category 'testing') ----- > > > + wantsToBeOutermost > > > + > > > + ^ false! > > > > > > Item was changed: > > > Object subclass: #MCDependencySorter > > > + instanceVariableNames: 'required provided deferred orderedItems' > > > - instanceVariableNames: 'required provided orderedItems' > > > classVariableNames: '' > > > poolDictionaries: '' > > > category: 'Monticello-Loading'! > > > > > > Item was changed: > > > ----- Method: MCDependencySorter>>add: (in category 'building') ----- > > > add: anItem > > > | requirements | > > > + (anItem wantsToBeOutermost) > > > + ifTrue: [^self addDeferred: anItem]. > > > requirements := self unresolvedRequirementsFor: anItem. > > > requirements isEmpty > > > ifTrue: [self addToOrder: anItem] > > > ifFalse: [self addRequirements: requirements for: anItem]. > > > ^anItem! > > > > > > Item was added: > > > + ----- Method: MCDependencySorter>>addDeferred (in category 'building') ----- > > > + addDeferred > > > + deferred do: [:ea | > > > + self addToOrder: ea].! > > > > > > Item was added: > > > + ----- Method: MCDependencySorter>>addDeferred: (in category 'private') ----- > > > + addDeferred: anItem > > > + ^ deferred add: anItem! > > > > > > Item was changed: > > > ----- Method: MCDependencySorter>>initialize (in category 'initialize-release') ----- > > > initialize > > > provided := Set new. > > > required := Dictionary new. > > > + orderedItems := OrderedCollection new. > > > + deferred := OrderedCollection new.! > > > - orderedItems := OrderedCollection new.! > > > > > > Item was changed: > > > ----- Method: MCPackageLoader>>sorterForItems: (in category 'private') ----- > > > sorterForItems: aCollection > > > | sorter | > > > sorter := MCDependencySorter items: aCollection. > > > sorter addExternalProvisions: self provisions. > > > + sorter addDeferred. > > > ^ sorter! > > > > > > Item was added: > > > + ----- Method: MCPostscriptDefinition>>wantsToBeOutermost (in category 'nil') ----- > > > + wantsToBeOutermost > > > + > > > + ^ true! > > > > > > Item was added: > > > + ----- Method: MCRemovalPreambleDefinition>>wantsToBeOutermost (in category 'testing') ----- > > > + wantsToBeOutermost > > > + > > > + ^ true! > > > > > >

2 1

← Newer
1
...
16
17
18
19
20
21
22
23
24
Older →

Jump to page: