Squeak-dev October 2021

squeak-dev@lists.squeakfoundation.org

24 participants
212 discussions

The Trunk: MorphicExtras-ct.295.mcz
by commits＠source.squeak.org 07 Oct '21

07 Oct '21

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-ct.295.mcz ==================== Summary ==================== Name: MorphicExtras-ct.295 Author: ct Time: 17 April 2021, 7:09:30.182932 pm UUID: e1a46d30-9232-aa4e-a316-9aad80fa0978 Ancestors: MorphicExtras-eem.293 PianoKeyboardMorph: Don't play a sound when a menu is invoked. =============== Diff against MorphicExtras-eem.293 =============== Item was changed: ----- Method: PianoKeyboardMorph>>mouseDownPitch:event:noteMorph: (in category 'simple keyboard') ----- mouseDownPitch: midiKey event: event noteMorph: noteMorph | pitch | + event redButtonPressed ifFalse: [^ self]. event hand hasSubmorphs ifTrue: [^ self "no response if drag something over me"]. event hand mouseFocus ifNil: ["If dragged into me, then establish focus so I'll see moves" event hand newMouseFocus: noteMorph event: event]. noteMorph color: playingKeyColor. pitch := AbstractSound pitchForMIDIKey: midiKey + 23. soundPlaying ifNotNil: [soundPlaying stopGracefully]. soundPlaying := soundPrototype soundForPitch: pitch dur: 100.0 loudness: 0.3. SoundPlayer resumePlaying: soundPlaying quickStart: true. !

1 0

The Trunk: MorphicExtras-ct.299.mcz
by commits＠source.squeak.org 07 Oct '21

07 Oct '21

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-ct.299.mcz ==================== Summary ==================== Name: MorphicExtras-ct.299 Author: ct Time: 3 October 2021, 3:39:23.706874 pm UUID: 771933d3-7bec-9346-aa54-c4549fa6ae87 Ancestors: MorphicExtras-ul.298 Adds FrameRateMorph to the 'Tools' category of the parts bin. I seriously use this morph for performance measuring. =============== Diff against MorphicExtras-ul.298 =============== Item was changed: ----- Method: FrameRateMorph class>>descriptionForPartsBin (in category 'parts bin') ----- descriptionForPartsBin ^ self partName: 'FrameRate' translatedNoop + categories: {'Just for Fun' translatedNoop. 'Tools' translatedNoop} - categories: {'Just for Fun' translatedNoop} documentation: 'A readout that allows you to monitor the frame rate of your system' translatedNoop!

1 0

The Trunk: MorphicExtras-mt.300.mcz
by commits＠source.squeak.org 07 Oct '21

07 Oct '21

Marcel Taeumel uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-mt.300.mcz ==================== Summary ==================== Name: MorphicExtras-mt.300 Author: mt Time: 7 October 2021, 4:39:47.760277 pm UUID: 4bc12538-f6c7-3c40-af48-9d04c8993e16 Ancestors: MorphicExtras-ct.294, MorphicExtras-ct.295, MorphicExtras-ct.299 Merge. Merge. Merge. - Make proper use of DisplayScreen >>#restoreAfter: in SketchMorph examples. - PianoKeyboardMorph: Don't play a sound when a menu is invoked. - Adds FrameRateMorph to the 'Tools' category of the parts bin. I seriously use this morph for performance measuring. =============== Diff against MorphicExtras-eem.293 =============== Item was changed: ----- Method: FrameRateMorph class>>descriptionForPartsBin (in category 'parts bin') ----- descriptionForPartsBin ^ self partName: 'FrameRate' translatedNoop + categories: {'Just for Fun' translatedNoop. 'Tools' translatedNoop} - categories: {'Just for Fun' translatedNoop} documentation: 'A readout that allows you to monitor the frame rate of your system' translatedNoop! Item was added: + ----- Method: MovingEyeMorph class>>extraExampleSqueakGhostIsWatchingYou (in category 'examples') ----- + extraExampleSqueakGhostIsWatchingYou + "MovingEyeMorph extraExampleSqueakGhostIsWatchingYou openInHand" + + | logoMorph leftEye rightEye | + logoMorph := (Form squeakLogo collectColors: #negated) asMorph. + leftEye := (self color: Color white irisColor: Color black) + extent: logoMorph extent * (0.1 @ 0.15); + center: (logoMorph pointAtFraction: 0.39 @ 0.55); + yourself. + rightEye := (self color: Color white irisColor: Color black) + extent: logoMorph extent * (0.1 @ 0.15); + center: (logoMorph pointAtFraction: 0.59 @ 0.56); + yourself. + logoMorph addAllMorphs: {leftEye. rightEye}. + ^ logoMorph.! Item was changed: ----- Method: PianoKeyboardMorph>>mouseDownPitch:event:noteMorph: (in category 'simple keyboard') ----- mouseDownPitch: midiKey event: event noteMorph: noteMorph | pitch | + event redButtonPressed ifFalse: [^ self]. event hand hasSubmorphs ifTrue: [^ self "no response if drag something over me"]. event hand mouseFocus ifNil: ["If dragged into me, then establish focus so I'll see moves" event hand newMouseFocus: noteMorph event: event]. noteMorph color: playingKeyColor. pitch := AbstractSound pitchForMIDIKey: midiKey + 23. soundPlaying ifNotNil: [soundPlaying stopGracefully]. soundPlaying := soundPrototype soundForPitch: pitch dur: 100.0 loudness: 0.3. SoundPlayer resumePlaying: soundPlaying quickStart: true. ! Item was changed: ----- Method: PostscriptCanvas>>image:at:sourceRect:rule: (in category 'private') ----- image: form at: aPoint sourceRect: sourceRect rule: rule | aForm | self preserveStateDuring: [:inner | inner translate: aPoint + self origin. aForm := form depth <= 8 ifTrue: [form asFormOfDepth: 32] ifFalse: [form]. target write: ((aForm colorsUsed includes: Color transparent) ifTrue: [| top f2 c2 offset | "tfel: This was taken from SketchMorph, but is actually needed for all forms that use transparency" + offset := currentTransformation ifNil: [0@0] ifNotNil: [:t | t offset]. - offset := currentTransformation ifNil: [0@0] ifNotNilDo: [:t | t offset]. top := self topLevelMorph. f2 := Form extent: aForm extent depth: self depth. c2 := f2 getCanvas. c2 fillColor: Color white. c2 translateBy: offset - self origin - aPoint clippingTo: f2 boundingBox during: [:c | top fullDrawOn: c]. f2] ifFalse: [aForm])]. ! Item was changed: ----- Method: SketchMorph class>>extraExampleCook (in category '*MorphicExtras-examples') ----- extraExampleCook "SketchMorph extraExampleCook openInWorld" ^ (self withForm: Form extraCook) + addMouseUpActionWith: 'Display restoreAfter: [Form toothpaste: 30]'; - addMouseUpActionWith: 'Form toothpaste: 30'; balloonText: 'Click me and then drag the cursor over the screen'; yourself! Item was changed: ----- Method: SketchMorph class>>extraExampleWizard (in category '*MorphicExtras-examples') ----- extraExampleWizard "SketchMorph extraExampleWizard openInWorld" ^ (self withForm: Form extraWizard) addMouseUpActionWith: + (MessageSend receiver: Display selector: #restoreAfter: argument: [Pen new web]); - (MessageSend receiver: Pen new selector: #web); balloonText: 'Click me and then drag the cursor over the screen\(Trust me, I won''t turn you into a toad!!)' withCRs; yourself! Item was added: + ----- Method: StringButtonMorph>>isButton (in category 'classification') ----- + isButton + + ^ true! Item was changed: ----- Method: Workspace class>>extraExampleContents2 (in category '*MorphicExtras-examples') ----- extraExampleContents2 "This is example code for #extraExample2" "Inspect any (sub)expression result by pressing <cmd>i" (20 to: 40 by: 2) asOrderedCollection addFirst: 16; addLast: 42; sort: [:x | x \\ 3] descending; yourself. "Explore any (sub)expression result by pressing <cmd>I" Project current world. "Debug any (sub)expression using <cmd>D" (1 to: 9) join asNumber sqrt truncateTo: 1e-3. + (SystemWindow windowsIn: self currentWorld) - (SystemWindow windowsIn: ActiveWorld) select: [:window | window bounds isWide] thenDo: [:window | window color: window color negated].!

1 0

The Trunk: Morphic-mt.1783.mcz
by commits＠source.squeak.org 07 Oct '21

07 Oct '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1783.mcz ==================== Summary ==================== Name: Morphic-mt.1783 Author: mt Time: 7 October 2021, 3:16:58.720277 pm UUID: ccc05305-cb74-6841-8a74-ed5a772f7b4b Ancestors: Morphic-mt.1782 Revises Morphic-mt.1781. Only be a renderer if you have a single submorph. Now you can open a halo on the items in a tree morph again. Also fixes meta-click+drag bug on morphs that have a flex-shell. Also fixes change-hierarchy bug on morphs that have a flex-shell. =============== Diff against Morphic-mt.1782 =============== Item was changed: ----- Method: MorphicHaloDispatcher>>dispatchHalo:createFor: (in category 'dispatching') ----- dispatchHalo: anEvent createFor: aContainer "Invoke a halo on any aContainer's submorph that wants it. Dispatch uses anEvent's #position. The dispatch only ends in that container if no other morph wants it. Note that the event's #shiftPressed state determines whether the dispatch goes innermost-to-outermost (if pressed) or the other way around (if not pressed). If there already is a halo, check whether the event still points into the same hierarchy. If it does, do nothing here but rely on the halo itself to process the event (see implementors of #transferHalo:from:). If, however, the event points to a different hierarchy in the container, invoke a new halo and discard the current one. We do this here because the current halo should not bother with its container but only its #target." | stack innermost haloTarget | "The stack is the frontmost (i.e. innermost) to backmost (i.e. outermost) morph." stack := (aContainer morphsAt: anEvent position unlocked: true) select: + [ : each | each wantsHaloFromClick or: [ each isRenderer ] ]. - [ : each | each wantsHaloFromClick ]. "self assert: [ stack last == aContainer ]." innermost := anEvent hand halo ifNil: [ stack first ] ifNotNil: [ : existingHalo | "self assert: [ existingHalo wantsHaloFromClick not ]. " stack detect: [ : each | each owner == aContainer ] ifFound: [ : topInContainer | "Is existingHalo's target part of the same topInContainer as the morph clicked?" (existingHalo target withAllOwners includes: topInContainer) ifTrue: [ "same hierarchy, let #transferHalo: continue to handle it for now." ^ false ] ifFalse: [ "different hierarchy, remove + add." anEvent hand removeHalo. anEvent shiftPressed ifTrue: [ stack first ] ifFalse: [ topInContainer ] ] ] ifNone: [ "existingHalo is on the World, defer to #transferHalo: for now." ^ false ] ]. "If modifier key is pressed, start at innermost (the target), otherwise the outermost (direct child of the world (self))." haloTarget := (innermost == aContainer or: [ anEvent shiftPressed ]) ifTrue: [ innermost ] ifFalse: [ "Find the outermost owner that wants it. Ignore containment above aContainer." stack := innermost withAllOwners. (stack first: (stack findFirst: [ : each | each owner == aContainer ])) reversed + detect: [ : each | each wantsHaloFromClick or: [ each isRenderer ] ] - detect: [ : each | each wantsHaloFromClick ] ifNone: [ "haloTarget has its own mouseDown handler, don't halo." ^ false ] ]. "Now that we have the haloTarget, show the halo." self invokeHaloOrMove: anEvent on: haloTarget. ^ true! Item was changed: ----- Method: MorphicHaloDispatcher>>invokeHaloOrMove:on: (in category 'invoking') ----- invokeHaloOrMove: anEvent on: aMorph "Special gestures (cmd-mouse on the Macintosh; Alt-mouse on Windows and Unix) allow a mouse-sensitive morph to be moved or bring up a halo for the morph." + | h doNotDrag | - | h tfm doNotDrag | anEvent hand newMouseFocus: aMorph event: anEvent. h := anEvent hand halo. "Prevent wrap around halo transfers originating from throwing the event back in" doNotDrag := false. h ifNotNil:[ (h innerTarget == aMorph) ifTrue:[doNotDrag := true]. (h innerTarget hasOwner: aMorph) ifTrue:[doNotDrag := true]. (aMorph hasOwner: h target) ifTrue:[doNotDrag := true]]. + h := aMorph addHalo: anEvent. - tfm := (aMorph transformedFrom: nil) inverseTransformation. - - "cmd-drag on flexed morphs works better this way" - h := aMorph addHalo: (anEvent transformedBy: tfm). h setProperty: #lastHaloDispatcher toValue: self. doNotDrag ifTrue:[^ true]. "Initiate drag transition if requested" anEvent hand waitForClicksOrDrag: h + event: anEvent - event: (anEvent transformedBy: tfm) selectors: { nil. nil. nil. #startDragTarget:. } threshold: HandMorph dragThreshold. "Pass focus explicitly here" anEvent hand newMouseFocus: h. "Reset temporary cursors to make available halo interaction visible." anEvent hand showTemporaryCursor: nil. ^ true! Item was changed: ----- Method: TransformMorph>>isRenderer (in category 'classification') ----- isRenderer + ^ submorphs size = 1 - ^ true ! Item was changed: ----- Method: TransformMorph>>morphicLayerNumber (in category 'submorphs - layers') ----- morphicLayerNumber + ^ self isRenderer + ifTrue: [self renderedMorph morphicLayerNumber] - ^ self hasSubmorphs ifFalse: [super morphicLayerNumber] + ! - ifTrue: [self firstSubmorph morphicLayerNumber]! Item was changed: ----- Method: TransformMorph>>renderedMorph (in category 'classification') ----- renderedMorph "We are a renderer. Answer appropriately." + ^ self isRenderer - ^ self hasSubmorphs ifTrue: [self firstSubmorph renderedMorph] + ifFalse: [super renderedMorph]! - ifFalse: [self]! Item was changed: ----- Method: TransformMorph>>wantsHaloFromClick (in category 'halos and balloon help') ----- wantsHaloFromClick + ^ self hasSubmorphs not! - ^ self renderedMorph == self!

2 1

The Trunk: Morphic-mt.1781.mcz
by commits＠source.squeak.org 07 Oct '21

07 Oct '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1781.mcz ==================== Summary ==================== Name: Morphic-mt.1781 Author: mt Time: 6 October 2021, 10:15:44.239651 am UUID: 9fef6ccb-8df4-8047-8b0b-f8292ad3c397 Ancestors: Morphic-ul.1780 Fixes infinite-loop bug regarding #topRendererOrSelf by promoting TransformMorph to be an #isRenderer too, which makes sense because it clips and translates its contents already and usually has only a single submorph. The #transform could also scale and rotate. In the long term, the few extra features of TransformationMorph could be merged into TransformMorph. This would make it easier for clients to pick the right one. :-) See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-October/216637.… =============== Diff against Morphic-ul.1780 =============== Item was changed: ----- Method: MorphicHaloDispatcher>>dispatchHalo:transferInwardsFrom: (in category 'dispatching') ----- dispatchHalo: event transferInwardsFrom: currentTarget | localEvent world | "Note that a halo usually attaches to the outermost (or top) renderer in a composition around the rendered morph. Thus, we have to lookup that inner (or rendered) morph first when transferring the halo inwards in the hierarchy of submorphs." currentTarget renderedMorph submorphsDo: [:nextTarget | localEvent := event transformedBy: (nextTarget transformedFrom: currentTarget). (nextTarget fullContainsPoint: localEvent position) ifTrue: [ + ^ nextTarget renderedMorph wantsHaloFromClick - ^ nextTarget wantsHaloFromClick ifTrue: [self invokeHalo: localEvent on: nextTarget] ifFalse: [self dispatchHalo: localEvent transferInwardsFrom: nextTarget]]]. "We're at the bottom most level; throw the event back up to the root to find recipient" event hand removeHalo. Preferences maintainHalos ifFalse: [ (world := currentTarget world) ifNil: [ ^ false ]. localEvent := event transformedBy: (currentTarget transformedFrom: world) inverseTransformation. world processEvent: localEvent resetHandlerFields]. ^ false! Item was added: + ----- Method: TransformMorph>>innocuousName (in category 'naming') ----- + innocuousName + + | r | + ^ (r := self renderedMorph) == self + ifTrue: [super innocuousName] + ifFalse: [r innocuousName]! Item was added: + ----- Method: TransformMorph>>isRenderer (in category 'classification') ----- + isRenderer + + ^ true + ! Item was added: + ----- Method: TransformMorph>>renderedMorph (in category 'classification') ----- + renderedMorph + "We are a renderer. Answer appropriately." + + ^ self hasSubmorphs + ifTrue: [self firstSubmorph renderedMorph] + ifFalse: [self]! Item was changed: ----- Method: TransformMorph>>wantsHaloFromClick (in category 'halos and balloon help') ----- wantsHaloFromClick + + ^ self renderedMorph == self! - ^ false! Item was removed: - ----- Method: TransformationMorph>>innocuousName (in category 'naming') ----- - innocuousName - | r | - ^ (r := self renderedMorph) == self - ifTrue: [super innocuousName] ifFalse: [r innocuousName]! Item was removed: - ----- Method: TransformationMorph>>isRenderer (in category 'classification') ----- - isRenderer - - ^ true - ! Item was removed: - ----- Method: TransformationMorph>>renderedMorph (in category 'classification') ----- - renderedMorph - "We are a renderer. Answer appropriately." - - submorphs isEmpty ifTrue: [^self]. - ^self firstSubmorph renderedMorph! Item was removed: - ----- Method: TransformationMorph>>wantsHaloFromClick (in category 'halos and balloon help') ----- - wantsHaloFromClick - - ^ self renderedMorph == self!

2 1

looking for a job, please delete if inappropriate for this thread
by gettimothy 06 Oct '21

06 Oct '21

Hi folks I quit my factory job and am now looking for software work. I applied to Cincom (I am not qualified for what they want, but I applied anyway). I am happy with remote grunt work to get my foot in the door. Again, please delete if inappropriate. tty

1 0

seg-fault for the morphic team
by gettimothy 06 Oct '21

06 Oct '21

Good morning folks. /home/wm/usr/src/smalltalk/Squeak6.0alpha-20579/shared/Squeak6.0alpha-20579-64bit.image Squeak6.0alpha latest update: #20633 To reproduce. Open Monticello. Open a remote repository (not sure if being remote matters..but for brevity sake) the repo window opens towards the right of the screen. Open a local repository. this opens more to the left of the original. on the remote repo on the right, highlight a version ad select "copy". the teeny window with the available repos opens. Select the left bottom handle and drag to expand it. segfault. Right bottom handle does not have the issue. cheers,

2 4

The Trunk: Morphic-mt.1782.mcz
by commits＠source.squeak.org 06 Oct '21

06 Oct '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1782.mcz ==================== Summary ==================== Name: Morphic-mt.1782 Author: mt Time: 6 October 2021, 11:00:59.501367 am UUID: 917d7198-f778-8d40-94ef-8a0d6a48186c Ancestors: Morphic-mt.1781 Fixes regression in grip resizing. =============== Diff against Morphic-mt.1781 =============== Item was changed: ----- Method: BottomLeftGripMorph>>apply: (in category 'target resize') ----- apply: delta | oldBounds | oldBounds := self target bounds. self target bounds: (oldBounds origin + (delta x @ 0) corner: oldBounds corner + (0 @ delta y)). self flag: #workaround. "mt: Due to a layout-specific 'let us start in the top-left corner of a layout cell'-behavior, we have to go up the owner chain and propagate the delta. See Morph >> #layoutInBounds:positioning: and there section 1.2." self target allOwnersDo: [:anOwner | (anOwner layoutPolicy notNil and: [anOwner ~~ Project current world]) + ifTrue: [anOwner left: anOwner left + delta x]].! - ifTrue: [anOwner left: owner left + delta x]].!

1 0

[BUG] Infinite recursion for #morphicLayerNumber of TextMorphForEditView
by christoph.thiede＠student.hpi.uni-potsdam.de 06 Oct '21

06 Oct '21

Hi all, hi Marcel, sending #morphicLayerNumber to a TextMorphForEditView currently raises an infinite loop. This can be observed when triggering the "choose color..." option from the change emphasis (alt + 6) menu. See the implementations on Morph and TransformMorph or the attached screenshots. How shall we fix this infinite recursion? :-) Best, Christoph --- Sent from Squeak Inbox Talk

2 1

Menu filters override item enablements
by christoph.thiede＠student.hpi.uni-potsdam.de 06 Oct '21

06 Oct '21

Hi all, today I was investigating why enablements in docking bar menu items do not work (for instance, if there are no open windows, then the "No Windows" item should be disabled, but it is not). I traced this down to our delightful type-to-filter feature which overwrites the enablement of menu items (see MenuMorph >> #displayFiltered: and MenuItemMorph >> #isEnabled:). I think two mental models are clashing here: First, the menu provider/model wants to declare whether an item is available/locked from the domain-specific perspective. Second, the UI needs a way to temporarily disable items that have been filtered out. I suggest we add a second pair of selectors to MenuItemMorph to differentiate between both kinds of enablement - i.e., something like #isDomainEnabled[:] and #isFilterEnabled[:]. Here are two actionable questions for you: 1. Do you aggree with this idea in general? 2. How shall we name these selectors? In the Trunk, there are 3 senders to the existing setter and and ~10 senders to the existing getter. I wonder whether we shall maintain backward compatibility here or whether the existing #isEnabled[:] is also subjected to change. Maybe #isAvailable[:] (domain) and #isLocked[:]? Or #isAvailable[:] and #isFilteredOut[:]? In any case, #isEnabled should be the logical conjunction of both states. Looking forward to your help. Best, Christoph --- Sent from Squeak Inbox Talk

4 4

Jump to page: