Squeak-dev November 2021

squeak-dev@lists.squeakfoundation.org

27 participants
278 discussions

The Inbox: Morphic-ct.1792.mcz
by commits＠source.squeak.org 10 Dec '21

10 Dec '21

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1792.mcz ==================== Summary ==================== Name: Morphic-ct.1792 Author: ct Time: 1 November 2021, 7:53:35.595429 pm UUID: d73224ba-841c-b647-a544-0d171ae13e69 Ancestors: Morphic-eem.1784 Editors: Extends autoEnclose and blinkPrevParen: to also support quotes and chevrons, which is just consistent with encloseSelection imho. =============== Diff against Morphic-eem.1784 =============== Item was changed: ----- Method: SmalltalkEditor>>blinkPrevParen: (in category 'parenblinking') ----- blinkPrevParen: aCharacter "Same as super, but tries to follow the Smalltalk syntax." | openDelimiter closeDelimiter level string here inside | string := paragraph text string. here := pointBlock stringIndex. openDelimiter := aCharacter. + closeDelimiter := '([{<"''|' at: (')]}>"''|' indexOf: openDelimiter). - closeDelimiter := '([{' at: (')]}' indexOf: openDelimiter). level := 1. inside := nil. "Tricky." (here > 1 and: [ (string at: here - 1) = $$ ]) ifTrue: [ ^self ]. "Just a character literal." [ level > 0 and: [ here > 1 ] ] whileTrue: [ | hereChar | hereChar := string at: (here := here - 1). inside "Are we inside a comment or string literal?" ifNotNil: [ "Yes." hereChar = inside ifTrue: [ (here > 1 and: [ (string at: here - 1) ~= inside ]) ifTrue: [ inside := nil ] ifFalse: [ here := here - 1 ] ] ] ifNil: [ (here > 1 and: [ (string at: here - 1) = $$ ]) "Just a character literal." ifTrue: [ here := here - 1 ] ifFalse: [ hereChar caseOf: { [ closeDelimiter ] -> [ (level := level - 1) = 0 ifTrue: [ ^self blinkParenAt: here ] ]. [ openDelimiter ] -> [ level := level + 1 ]. [ $" ] -> [ inside := $" ]. [ $' ] -> [ inside := $' ] } otherwise: [] ] ] ]! Item was changed: ----- Method: TextEditor class>>autoEnclose (in category 'preferences') ----- autoEnclose + <preference: 'Auto enclose brackets () {} [] '''' "" || <>' - <preference: 'Auto enclose brackets () {} []' categoryList: #('Morphic' 'editing') description: 'When true, typing an opening parenthesis, bracket or square-bracket will also add its corresponding closing character after the cursor so you can type within the bracket.' type: #Boolean> ^ AutoEnclose ifNil: [ false ]! Item was changed: ----- Method: TextEditor>>autoEncloseFor: (in category 'typing support') ----- autoEncloseFor: typedChar "Answer whether typeChar was handled by auto-enclosure. Caller should call normalCharacter if not." | openers closers | + openers := '([{<"''|'. + closers := ')]}>"''|'. - openers := '([{'. - closers := ')]}'. (closers includes: typedChar) ifTrue: [ | pos | self blinkPrevParen: typedChar. ((pos := self indexOfNextNonwhitespaceCharacter) notNil and: [ (paragraph string at: pos) = typedChar ]) ifTrue: [ self moveCursor: [ : position | position + pos - pointBlock stringIndex + 1 ] forward: true select: false. + ^ true ] ]. - ^ true ] - ifFalse: [ ^ false ] ]. (openers includes: typedChar) ifTrue: [ self openTypeIn; addString: typedChar asString; addString: (closers at: (openers indexOf: typedChar)) asString; insertAndCloseTypeIn; moveCursor: [ : position | position - 1 ] forward: false select: false. ^ true ]. ^ false! Item was changed: ----- Method: TextEditor>>blinkPrevParen: (in category 'parenblinking') ----- blinkPrevParen: aCharacter "Used if not Shout" | openDelimiter closeDelimiter level string here hereChar | string := paragraph string. here := pointBlock stringIndex. openDelimiter := aCharacter. + closeDelimiter := '([{<"''|' at: (')]}>''"|' indexOf: openDelimiter). - closeDelimiter := '([{' at: (')]}' indexOf: openDelimiter). level := 1. [level > 0 and: [here > 1]] whileTrue: [hereChar := string at: (here := here - 1). hereChar = closeDelimiter ifTrue: [level := level - 1. level = 0 ifTrue: [^ self blinkParenAt: here]] ifFalse: [hereChar = openDelimiter ifTrue: [level := level + 1]]]!

2 1

Changeset: fix-generic-inspectOne-with-truncation.cs
by Thiede, Christoph 08 Dec '21

08 Dec '21

Hi all! Jan Ehmueller and Fabio (fn) have discovered an Inspector bug with #inspectOne/"inspect element..." in the field list menu that hindered users from entering the index of a truncated element in the inspect element dialog. Possible ways to reproduce the issue include: * Inspector openOn: (Array new: 1024) -> … -> Click -> 90 -> Enter * (SmalltalkImage>>#snapshot:andQuit:withExitCode:embedded:) inspect -> right click self -> inspect element... -> 450 -> Enter (might depend on Sista) * TruffleSqueak was also affected: https://github.com/hpi-swa/trufflesqueak/issues/143 The attached changeset attempts to fix the bug. Changelog: Problem: The variant of Inspector >> #inspectOne, as it is now in the trunk, fails if the key is the value for a field that has been truncated. Because in this place, explicitly only the keys of self fields are passed to #inspectOneOf: which are already truncated. The bug does not affect CollectionInspectors which passes the elementIndices directly to #inspectOneOf: without the need of having fields. Solution: I have now essentially pushed this logic from CollectionInspector with #elementIndices up to Inspector. This should make it run again. Please review and merge if you don't have any further objections. :-) Best, Christoph

3 3

Changeset: MimeDocument>>url
by Thiede, Christoph 08 Dec '21

08 Dec '21

Hi all, this changeset is really (!) small, but it fixes an implicit reference from Network on MorphicExtras because WebUtils class >> #encodeMultipartForm:boundary: accesses the URL of every MIMEDocument. I only recategorized this one selector. Could someone with Trunk permissions please merge this into the Trunk? :-) Thanks in advance, Christoph

2 1

Changeset: Deprecate SyntaxErrorNotification >> #errorMessage
by Thiede, Christoph 08 Dec '21

08 Dec '21

Hi all, please have a look at the attached changeset. It deprecates the IMO redundant instance variable 'errorMessage' in SyntaxErrorNotification and uses super's 'messageText' instead. The two single senders in the Trunk image are patched as well. I wonder at all how the usage in DecompilerTests could have worked before, giving the prior implementation of #messageText in SyntaxErrorNotification ... Please review and merge if you like it. Best, Christoph

2 1

Changeset: forceString.1.cs
by Thiede, Christoph 08 Dec '21

08 Dec '21

This changeset proposes an additional property for PluggableTextMorph/PluggableTextSpec, named #forceString. If it is activated, any formattings will be erased from the text morph instantly. This can be useful for widgets that are not actually designed to accept texts and thus display a heap of unwanted formattings. An example is the SearchBar, which at least in my image too often looks totally misstyled after several copy'n'paste operations: [cid:4dc50742-4fb0-49c7-8e91-e28c30faaff0] (Or should maybe use a text styler there, instead?) Another, probably better example is FillInTheBlankMorph. As it only returns a string, there is no need to display styled texts. How would you think about it? Please let me know. :-) Best, Christoph

3 5

[OT] some Squeak music
by Stéphane Rollandin 07 Dec '21

07 Dec '21

Hello all, I just finished a new piece of music entirely composed and performed within a muO image - the audio is recorded from virtual instruments fed a live MIDI output stream. This is done with a technology that does not exists elsewhere. I know it is not the place to post (weird) music, but in the broader context of the discussion about the death of Smalltalk, I felt inclined to illustrate how for some of us it is very much alive and singing. Here it is: http://www.zogotounga.net/zik/Pentaxoyothol.ogg Stef

6 9

The Inbox: System-ct.1136.mcz
by commits＠source.squeak.org 07 Dec '21

07 Dec '21

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1136.mcz ==================== Summary ==================== Name: System-ct.1136 Author: ct Time: 6 February 2020, 7:50:02.954648 pm UUID: 0a637557-d32d-9347-bc4b-4f2bb95a707d Ancestors: System-cmm.1131 Make Smalltalk more robust against interruptions/timeouts during sources compilation A popular example is a test case that compiles a lot of methods and then is terminated via timeout. See [1] for an example. This commit ensures that the changes file does not remain closed when the method is curtailed. Before probably destroyed your image, now works: [MCSnapshotResource mockPackage unload] valueWithin: 1 seconds "you may need to adapt the limit to reproduce" onTimeout: []. [1] http://forum.world.st/BUG-MultiByteFileStream-Object-gt-gt-error-primGetPos… =============== Diff against System-cmm.1131 =============== Item was changed: ----- Method: SmalltalkImage>>forceChangesToDisk (in category 'sources, changes log') ----- forceChangesToDisk "Ensure that the changes file has been fully written to disk by closing and re-opening it. This makes the system more robust in the face of a power failure or hard-reboot." | changesFile | changesFile := SourceFiles at: 2. (changesFile isKindOf: FileStream) ifTrue: [ changesFile flush. + SecurityManager default hasFileAccess ifTrue: [ + [changesFile close] ensure: [ + changesFile open: changesFile name forWrite: true]]. + changesFile setToEnd].! - SecurityManager default hasFileAccess ifTrue:[ - changesFile close. - changesFile open: changesFile name forWrite: true]. - changesFile setToEnd. - ]. - !

6 7

The Inbox: Tools-ct.962.mcz
by commits＠source.squeak.org 07 Dec '21

07 Dec '21

Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.962.mcz ==================== Summary ==================== Name: Tools-ct.962 Author: ct Time: 20 March 2020, 6:58:18.856237 pm UUID: c4cbd7b0-ddf5-3b4b-93ed-55e5b2c80465 Ancestors: Tools-mt.955 Makes variable bindings in Workspace more comfortable: - Ask for a useful variable name when dropping something into a workspace - Validate variable name before creating inaccessible bindings - Do not propose invalid names at all (for example, dropped class were given an invalid name in the past) - Ask before removing variable bindings. This also increases responsiveness of the UI. - Improves multilingual support =============== Diff against Tools-mt.955 =============== Item was changed: ----- Method: Workspace>>acceptDroppingMorph:event:inMorph: (in category 'drag and drop') ----- acceptDroppingMorph: dropee event: evt inMorph: targetMorph + "Return the dropee to its old position, and add a reference to it at the cursor point." + - "Return the dropee to its old position, and add a reference to it at the - cursor point." | bindingName externalName reference | (dropee isKindOf: TransferMorph) ifTrue: [reference := dropee passenger. externalName := dropee passenger className] ifFalse: [reference := dropee. externalName := dropee externalName]. externalName := externalName isOctetString + ifTrue: [externalName] + ifFalse: ['a' , externalName]. + + bindingName := Project uiManager + request: 'Please enter a name for the dropped object:' translated + initialAnswer: (externalName withFirstCharacterDownshifted , reference identityHash printString) asLegalSelector. + bindingName isEmptyOrNil ifTrue: [^ false]. + bindingName := Parser new parseSelector: bindingName. + bindingName ifNil: [ + self inform: 'Invalid selector.' translated. + ^ false]. + - ifTrue: [externalName] - ifFalse: ['a' , externalName]. - bindingName := externalName withFirstCharacterDownshifted , reference identityHash printString. - targetMorph correctSelectionWithString: bindingName , ' '. (self bindingOf: bindingName) value: reference. + targetMorph correctSelectionWithString: bindingName , ' '. (dropee isKindOf: TransferMorph) ifFalse: [dropee rejectDropMorphEvent: evt]. + ^ true "success"! - ^ true"success"! Item was changed: ----- Method: Workspace>>addModelItemsToWindowMenu: (in category 'menu commands') ----- addModelItemsToWindowMenu: aMenu aMenu addLine. aMenu + add: 'save contents to file...' translated - add: 'save contents to file...' target: self action: #saveContentsInFile. aMenu + add: 'inspect variables' translated - add: 'inspect variables' target: self action: #inspectBindings. aMenu + add: 'reset variables' translated - add: 'reset variables' target: self + action: #resetBindings. - action: #initializeBindings. aMenu addUpdating: #mustDeclareVariableWording target: self action: #toggleVariableDeclarationMode. aMenu addUpdating: #acceptDroppedMorphsWording target: self action: #toggleDroppingMorphForReference. + self addToggleStylingMenuItemTo: aMenu.! - self addToggleStylingMenuItemTo: aMenu. - ! Item was added: + ----- Method: Workspace>>resetBindings (in category 'menu commands') ----- + resetBindings + + (self bindings notEmpty ==> [self confirm: ('Are you sure you would like to remove {1} variables?' translated format: {self bindings size})]) + ifFalse: [^ self]. + self initializeBindings.!

5 7

The Inbox: System-ct.1156.mcz
by commits＠source.squeak.org 07 Dec '21

07 Dec '21

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1156.mcz ==================== Summary ==================== Name: System-ct.1156 Author: ct Time: 5 May 2020, 5:41:10.96399 pm UUID: 2ce2496e-92e9-f744-9a58-d9e9320adfab Ancestors: System-mt.1155 Fixes double prompt for handling a dropped file when the first dialog was cancelled. Cleans up duplication between ExternalDropHandler >> #lookupServiceBasedHandler: and DefaultExternalDropHandler by deprecating the first one. Maybe we can also remove this method? =============== Diff against System-mt.1155 =============== Item was changed: ----- Method: DefaultExternalDropHandler>>chooseServiceFrom: (in category 'private') ----- chooseServiceFrom: aCollection + "private - choose a service from aCollection asking the user if needed" + ^ aCollection size = 1 - "private - choose a service from aCollection asking the user if needed" - ^aCollection size = 1 ifTrue: [aCollection anyOne] + ifFalse: [UIManager default + chooseFrom: (aCollection collect: [:each | each label]) - ifFalse:[UIManager default - chooseFrom: (aCollection collect:[:each| each label]) values: aCollection title: 'You dropped a file. Please choose a service:' translated withCRs].! Item was changed: ----- Method: DefaultExternalDropHandler>>handle:in:dropEvent: (in category 'event handling') ----- handle: dropStream in: pasteUp dropEvent: anEvent "the file was just droped, let's do our job" | fileName services chosen | fileName := dropStream name. services := self servicesForFileNamed: fileName. + - "no service, default behavior" + services ifEmpty: [ + ^ UIManager default edit: dropStream contentsOfEntireFile]. + - services isEmpty - ifTrue: [^UIManager default edit: dropStream contentsOfEntireFile]. - chosen := self chooseServiceFrom: services. + chosen ifNotNil: [chosen performServiceFor: dropStream].! - chosen ifNotNil:[chosen performServiceFor: dropStream]! Item was changed: ----- Method: DefaultExternalDropHandler>>servicesForFileNamed: (in category 'private') ----- servicesForFileNamed: aString + "private - answer a collection of file-services for the file named aString" + + ^ (FileServices itemsForFile: aString) + copyWithoutAll: self unwantedSelectors! - "private - answer a collection of file-services for the file named - aString" - | allServices | - allServices := FileServices itemsForFile: aString. - ^ allServices - reject: [:svc | self unwantedSelectors includes: svc selector]! Item was changed: ----- Method: ExternalDropHandler class>>defaultHandler (in category 'accessing') ----- defaultHandler + + ^ DefaultHandler ifNil: [ + DefaultHandler := ExternalDropHandler + type: nil + extension: nil + action: #edit]! - DefaultHandler ifNil: [DefaultHandler := ExternalDropHandler type: nil extension: nil action: [:dropStream | dropStream edit]]. - ^DefaultHandler! Item was changed: ----- Method: ExternalDropHandler class>>lookupExternalDropHandler: (in category 'accessing') ----- lookupExternalDropHandler: stream | types extension serviceHandler | types := stream mimeTypes. types ifNotNil: [ + self registeredHandlers + detect: [:handler | handler matchesTypes: types] + ifFound: [:handler | ^ handler]]. - self registeredHandlers do: [:handler | - (handler matchesTypes: types) - ifTrue: [^handler]]]. extension := FileDirectory extensionFor: stream name. + self registeredHandlers + detect: [:handler | handler matchesExtension: extension] + ifFound: [:handler | ^ handler]. + + ^ serviceHandler ifNil: [self defaultHandler]! - self registeredHandlers do: [:handler | - (handler matchesExtension: extension) - ifTrue: [^handler]]. - serviceHandler := self lookupServiceBasedHandler: stream. - ^serviceHandler - ifNil: [self defaultHandler]! Item was changed: ----- Method: ExternalDropHandler class>>lookupServiceBasedHandler: (in category 'accessing') ----- lookupServiceBasedHandler: dropStream + - "The file was just dropped; let's do our job" | fileName services theOne | + self deprecated: 'ct: Use DefaultExternalDropHandler'. fileName := dropStream name. - services := (FileServices itemsForFile: fileName) reject: [:svc | self unwantedSelectors includes: svc selector]. + - "no service, default behavior" + services ifEmpty: [^ nil]. + - services isEmpty - ifTrue: [^nil]. - theOne := self chooseServiceFrom: services. + ^ theOne ifNotNil: [ + ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]! - ^theOne - ifNotNil: [ExternalDropHandler type: nil extension: nil action: [:stream | theOne performServiceFor: stream]]!

3 3

The Inbox: ShoutCore-ct.69.mcz
by commits＠source.squeak.org 06 Dec '21

06 Dec '21

A new version of ShoutCore was added to project The Inbox: http://source.squeak.org/inbox/ShoutCore-ct.69.mcz ==================== Summary ==================== Name: ShoutCore-ct.69 Author: ct Time: 14 August 2019, 10:43:04.7164 pm UUID: 7d165f4e-09bf-a445-a664-5e8edb9867b8 Ancestors: ShoutCore-ul.68 Fix bug in SHParserST80: Wrong styling after blocks with arguments without statements Thanks Jakob for the report! =============== Diff against ShoutCore-ul.68 =============== Item was changed: ----- Method: SHParserST80>>parseBlockArguments (in category 'parse') ----- parseBlockArguments currentTokenFirst == $: ifFalse: [ ^self ]. [ currentTokenFirst == $: ] whileTrue: [ self scanPast: #blockArgColon; parseArgument: #blockPatternArg ]. + ((self parseVerticalBarForTemporaries: #blockArgsBar) and: [ + currentTokenFirst ~= $] ]) + ifFalse: [ + self fail ": Missing block args bar" ]! - (self parseVerticalBarForTemporaries: #blockArgsBar) ifFalse: [ - self fail ": Missing block args bar" ]!

12 25

← Newer
1
...
5
6
7
8
9
10
11
...
28
Older →

Jump to page: