Squeak-dev December 2021

squeak-dev@lists.squeakfoundation.org

30 participants
390 discussions

The Trunk: System-mt.1263.mcz
by commits＠source.squeak.org 03 Dec '21

03 Dec '21

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1263.mcz ==================== Summary ==================== Name: System-mt.1263 Author: mt Time: 3 December 2021, 11:36:33.507016 am UUID: 4ab14722-538d-3a4b-81a5-84ddac50ce97 Ancestors: System-mt.1262 Next iteration on information the user of conflicts with known author initials: - Avoid suggesting "firstname.lastname" but just "a little longer" because we cannot guarantee the absence of name collisions. - Only show the new dialog if there is any conflict. - Do not clear the initials if you cancel the dialog. =============== Diff against System-mt.1262 =============== Item was changed: ----- Method: Utilities class>>setAuthorInitials (in category 'identification') ----- setAuthorInitials "Put up a dialog allowing the user to specify the author's initials. Inform the user about collisions with known contributors. See SystemNavigation class >> #authors. " | newInitials newName | newInitials := Project uiManager request: 'Please type your initials:' translated initialAnswer: AuthorInitials. + newInitials ifEmpty: [^ self "No Change"]. + (SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames | + newName := existingNames sorted joinSeparatedBy: '/'. - SystemNavigation authorsInverted at: newInitials ifPresent: [:existingNames | - newName := existingNames sorted joinSeparatedBy: '/']. + (self confirm: ('Hello, {1}!! :-) Our <a href="code://{3}">list of known contributors</{6}> associates the initials you have entered with this name. If this is not you, please consider alternative initials, preferably more than just a few characters, to avoid collisions. Do you want to use these author initials? {2}' translated format: { - (self confirm: ('Hello, {1}!! :-) Our <a href="code://{3}">list of known contributors</{6}> associates the initials you have entered with this name. If this is not you, please consider entering alternative initials, preferably in the format firstName.lastName to avoid collisions. Are these your author initials? {2}' translated format: { newName ifNil: [newInitials]. newInitials. 'SystemReporter open model categoryAt: 1 put: true'. Preferences standardButtonFont familyName. Preferences standardButtonFont pointSize. "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346…" + 'a' }) asTextFromHtml) ] ifAbsent: [true]) + ifTrue: [self authorInitials: newInitials].! - 'a' }) asTextFromHtml) - - ifTrue: [self authorInitials: newInitials].!

2 1

The Trunk: ToolBuilder-Morphic-ct.281.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Christoph Thiede uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.281.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.281 Author: ct Time: 2 December 2021, 9:42:51.429746 pm UUID: 3714f3d3-013d-644c-ac49-363076421856 Ancestors: ToolBuilder-Morphic-mt.280 Fixes a layout slip for multi-column lists with #shrinkWrap'ped column resizings. Update the column widths eagerly to avoid an incorrect default layout when the list enters the world. The original bug can be reproduced by searching in SqueakInboxTalk for the conversation "PSA | Slow .changes access | Real-time protection in Windows Defender". =============== Diff against ToolBuilder-Morphic-mt.280 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableMultiColumnList: (in category 'widgets required') ----- buildPluggableMultiColumnList: aSpec + | widget listClass getIndex setIndex | + aSpec getSelected + ifNil: [ + listClass := self multiColumnListClass. + getIndex := aSpec getIndex. + setIndex := aSpec setIndex] + ifNotNil: [ + listClass := self multiColumnListByItemClass. + getIndex := aSpec getSelected. + setIndex := aSpec setSelected]. + widget := listClass + on: aSpec model + list: aSpec list + selected: getIndex + changeSelected: setIndex + menu: aSpec menu + keystroke: aSpec keyPress. - aSpec getSelected ifNil:[ - listClass := self multiColumnListClass. - getIndex := aSpec getIndex. - setIndex := aSpec setIndex. - ] ifNotNil: [ - listClass := self multiColumnListByItemClass. - getIndex := aSpec getSelected. - setIndex := aSpec setSelected. - ]. - widget := listClass on: aSpec model - list: aSpec list - selected: getIndex - changeSelected: setIndex - menu: aSpec menu - keystroke: aSpec keyPress. self register: widget id: aSpec name. + " widget - " widget dragItemSelector: aSpec dragItem; dropItemSelector: aSpec dropItem; wantsDropSelector: aSpec dropAccept; dragStartedSelector: aSpec dragStarted." + - self setListPropertiesFor: widget spec: aSpec. "Be sure to enable the horizontal scrollbar if not all columns are #spaceFill." + (aSpec columnResizings anySatisfy: [:sym | sym ~= #spaceFill]) ifTrue: [widget hScrollBarPolicy: #whenNeeded]. + - (aSpec columnResizings anySatisfy: [:sym | sym ~= #spaceFill]) - ifTrue: [widget hScrollBarPolicy: #whenNeeded]. - widget cellPositioningForColumns: aSpec itemAlignments; cellInsetForColumns: aSpec itemPaddings; hResizingForColumns: aSpec columnResizings; spaceFillWeightForColumns: aSpec columnSpaceFillWeights. + widget updateColumns. + ^ widget! - ^widget!

2 1

The Trunk: Morphic-mt.1809.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1809.mcz ==================== Summary ==================== Name: Morphic-mt.1809 Author: mt Time: 2 December 2021, 5:40:51.014715 pm UUID: c4587ea6-ec38-da4c-923c-3f9382d32eeb Ancestors: Morphic-mt.1808 Tweaks #autoEnclose feature. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217304… Please report issues ASAP. =============== Diff against Morphic-mt.1808 =============== Item was changed: ----- Method: TextEditor>>autoEncloseFor: (in category 'typing support') ----- autoEncloseFor: typedChar "Answer whether typeChar was handled by auto-enclosure. Caller should call normalCharacter if not." + | openers closers next | - | openers closers | openers := '([{'. closers := ')]}'. + next := self string at: self startIndex ifAbsent: nil. (closers includes: typedChar) ifTrue: [ | pos | + (next isNil or: [next = typedChar]) ifFalse: [ ^ false ]. self blinkPrevParen: typedChar. ((pos := self indexOfNextNonwhitespaceCharacter) notNil and: [ (paragraph string at: pos) = typedChar ]) ifTrue: [ self moveCursor: [ : position | position + pos - pointBlock stringIndex + 1 ] forward: true select: false. ^ true ] ifFalse: [ ^ false ] ]. (openers includes: typedChar) ifTrue: + [ (self hasSelection or: [next isNil or: [next isSeparator or: [closers includes: next]]]) ifFalse: [ ^ false ]. + self - [ self openTypeIn; addString: typedChar asString; addString: (closers at: (openers indexOf: typedChar)) asString; insertAndCloseTypeIn; moveCursor: [ : position | position - 1 ] forward: false select: false. ^ true ]. ^ false!

1 0

The Trunk: Morphic-mt.1808.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1808.mcz ==================== Summary ==================== Name: Morphic-mt.1808 Author: mt Time: 2 December 2021, 5:27:20.653715 pm UUID: fe15ea45-d206-5243-8a7f-58a3d2713547 Ancestors: Morphic-mt.1807 Complements ToolBuilder-Morphic-mt.280 =============== Diff against Morphic-mt.1807 =============== Item was changed: ----- Method: DialogWindow>>updateButtonExtent (in category 'updating') ----- updateButtonExtent + self updateButtonExtent: (20@10 * RealEstateAgent scaleFactor) rounded.! - self updateButtonExtent: 20@10.! Item was changed: ----- Method: DialogWindow>>updateButtonExtent: (in category 'updating') ----- updateButtonExtent: margin "Update all button extents." (buttonRow submorphs collect: [:ea | ea minimumExtent]) max + margin in: [:preferredExtent | buttonRow submorphsDo: [:ea | ea extent: preferredExtent]]. "See if horizontal button layout would be more appropriate." self flag: #magicNumber. "mt: Remove number with computation, maybe choose button font and 20 characters" + (buttonRow submorphs collect: [:ea | ea fullBounds width]) sum > (400 * RealEstateAgent scaleFactor) - (buttonRow submorphs collect: [:ea | ea fullBounds width]) sum > 400 ifTrue: [buttonRow hResizing: #shrinkWrap; listDirection: #topToBottom; wrapDirection: #none; layoutInset: (buttonRow owner fullBounds width - (buttonRow owner layoutInset left*2) - buttonRow submorphs first fullBounds width // 2@0)] ifFalse: [buttonRow hResizing: #spaceFill; listDirection: #leftToRight; wrapDirection: #topToBottom; layoutInset: 0].!

1 0

The Trunk: ToolBuilder-Morphic-mt.280.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.280.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.280 Author: mt Time: 2 December 2021, 5:26:45.972715 pm UUID: 2f5a09f9-48fe-ce42-a70d-00b47c1513c3 Ancestors: ToolBuilder-Morphic-mt.279 Fixes high-dpi scaling of dialog windows. =============== Diff against ToolBuilder-Morphic-mt.279 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableDialog: (in category 'widgets optional') ----- buildPluggableDialog: aSpec | widget | widget := self dialogClass new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties. The pane morph holds the special contents." widget paneMorph wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). self setLayoutHintsFor: widget paneMorph spec: aSpec. widget paneMorph layoutInset: (aSpec padding ifNil: [ProportionalSplitterMorph gripThickness]). widget paneMorph cellGap: (aSpec spacing ifNil: [ProportionalSplitterMorph gripThickness]). widget morphicLayerNumber: widget class dialogLayer. widget paneMorph wantsPaneSplitters ifTrue: [ widget paneMorph addCornerGrips"addEdgeGrips". widget paneMorph grips do: [:ea | ea showHandle: true]]. "Now create the children." panes := OrderedCollection new. aSpec children isSymbol ifTrue: [ widget getChildrenSelector: aSpec children. widget update: aSpec children] ifFalse: [ self buildAll: aSpec children in: widget paneMorph]. "Now create the buttons." aSpec buttons isSymbol ifTrue: [ widget getButtonsSelector: aSpec buttons. widget update: aSpec buttons] ifFalse: [ self buildAll: aSpec buttons in: widget buttonRowMorph. widget updateButtonProperties]. aSpec title ifNotNil: [:label | label isSymbol ifTrue:[widget getTitleSelector: label; update: label] ifFalse:[widget title: label]]. aSpec message ifNotNil: [:label | label isSymbol ifTrue:[widget getMessageSelector: label; update: label] ifFalse:[widget message: label]]. "Interaction behavior." aSpec autoCancel ifNotNil: [:b | widget autoCancel: b]. aSpec exclusive ifNotNil: [:b | widget exclusive: b]. widget closeDialogSelector: aSpec closeAction. self buildHelpFor: widget spec: aSpec. "Everything is shrink-wrapped around the pane morph." + widget paneMorph extent: ((aSpec extent ifNil:[widget initialExtent]) + + (widget paneMorph layoutInset * 2) asPoint * RealEstateAgent scaleFactor) truncated. - widget paneMorph extent: (aSpec extent ifNil:[widget initialExtent]) - + (widget paneMorph layoutInset * 2) asPoint. ^ widget! Item was added: + ----- Method: PluggableDialogWindow>>initialExtent (in category 'initialization') ----- + initialExtent + + ^ model initialExtent!

1 0

The Trunk: MonticelloConfigurations-mt.170.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-mt.170.mcz ==================== Summary ==================== Name: MonticelloConfigurations-mt.170 Author: mt Time: 2 December 2021, 4:09:23.873715 pm UUID: c5da41de-7a1d-dc43-a5c7-47ac7387de1a Ancestors: MonticelloConfigurations-mt.169 Minor cosmetic tweak in the update dialog. Now that we can set the font size (and color) in dialogs, make the font for that ALPHA/BETA/RC-Warning smaller. =============== Diff against MonticelloConfigurations-mt.169 =============== Item was changed: ----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private') ----- updateMessageFor: previousUpdateLevel ^ ('Update completed. Version: {1} Update: {3}{2} Url: <a href="{4}">{4}</{10}> Map: ''{5}'' CI status: <a href="{8}"><img src="{7}" /> {9}</{10}>{6}' translated format: { SystemVersion current version. SystemVersion current highestUpdate. previousUpdateLevel = SystemVersion current highestUpdate ifTrue: [''] ifFalse: [previousUpdateLevel asString, ' -> ']. self repository. MCMcmUpdater updateMapName. SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | + ' {1}' + format: { + d copyReplaceAll: String cr with: ' '. + Preferences standardButtonFont familyName. + Preferences standardButtonFont pointSize. + }]. - ' ', (d copyReplaceAll: String cr with: ' ')]. SystemVersion current ciStatusBadgeUrl. SystemVersion current ciStatusPageUrl. SystemVersion current ciStatusTimestamp ifNil: ['(build inaccessible!!)' translated]. "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346…" 'a'. }) asTextFromHtml!

1 0

The Trunk: Morphic-mt.1807.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1807.mcz ==================== Summary ==================== Name: Morphic-mt.1807 Author: mt Time: 2 December 2021, 4:07:38.353715 pm UUID: c0df95ee-9347-1d47-b845-35b6b99a4f51 Ancestors: Morphic-mt.1806 Complements Collections-mt.966 =============== Diff against Morphic-mt.1806 =============== Item was changed: ----- Method: DialogWindow>>setMessageParameters (in category 'initialization') ----- setMessageParameters + | fontToUse colorToUse | - | fontToUse colorToUse fontAttr offset | messageMorph ifNil: [^ self]. fontToUse := self userInterfaceTheme font ifNil: [TextStyle defaultFont]. colorToUse := self userInterfaceTheme textColor ifNil: [Color black]. messageMorph hResizing: #shrinkWrap; vResizing: #shrinkWrap; textColor: colorToUse. + + messageMorph contents + addAttribute: (TextFontReference toFont: fontToUse) + unless: [:attrs | attrs anySatisfy: [:each | + "Do not overwrite existing font attributes." + each class == TextFontChange or: [each class == TextFontReference]]]. + messageMorph contents + addAttribute: (TextColor color: colorToUse) + unless: [:attrs | attrs anySatisfy: [:each | + "Do not overwrite existing color attributes" + each class == TextColor or: [each mayActOnClick "usually colored, too"]]].! - - "Only set text attributes for ranges that have none." - self flag: #todo. "mt: Add interface to Text?" - self flag: #todo. "mt: Do the same for TextColor. We must not know that #textColor: above does all the magic already." - fontAttr := TextFontReference toFont: fontToUse. - offset := nil. - messageMorph contents runs withIndexDo: [:attrs :index | - (attrs anySatisfy: [:each | each isKindOf: TextFontChange]) - ifFalse: [offset ifNil: [offset := index]] - ifTrue: [offset ifNotNil: [ - messageMorph contents - addAttribute: fontAttr - from: offset to: index - 1. - offset := nil]]]. - offset ifNotNil: [ - messageMorph contents - addAttribute: fontAttr - from: offset to: messageMorph contents size]. - !

1 0

The Trunk: CollectionsTests-mt.364.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of CollectionsTests to project The Trunk: http://source.squeak.org/trunk/CollectionsTests-mt.364.mcz ==================== Summary ==================== Name: CollectionsTests-mt.364 Author: mt Time: 2 December 2021, 4:06:39.658715 pm UUID: ab63b474-7dcb-bf4f-b41d-2a660e2b7a1c Ancestors: CollectionsTests-mt.363 Complements Collections-mt.966. =============== Diff against CollectionsTests-mt.363 =============== Item was added: + ----- Method: TextTest>>test08AddAttributeUnless (in category 'tests') ----- + test08AddAttributeUnless + + | text attributeOne attributeTwo | + text := Text fromString: 'Hello World!!'. + attributeOne := TextEmphasis bold. + attributeTwo := TextColor color: Color yellow. + text addAttribute: attributeOne from: 1 to: 5 "Hello". + text + addAttribute: attributeTwo + unless: [:attrs | attrs anySatisfy: [:ea | ea == attributeOne]]. + + 1 to: 5 do: [:index | + self assert: {attributeOne} equals: (text attributesAt: index)]. + 6 to: text size do: [:index | + self assert: {attributeTwo} equals: (text attributesAt: index)]. !

1 0

The Trunk: Collections-mt.966.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-mt.966.mcz ==================== Summary ==================== Name: Collections-mt.966 Author: mt Time: 2 December 2021, 4:06:07.345715 pm UUID: e18db8cb-0b3c-1d48-95f3-f5955e1ea837 Ancestors: Collections-mt.965 New message on Text: add a text attribute to the entire text unless there is a conflict with an existing text attribute. So, automatically compute the ranges that fit. =============== Diff against Collections-mt.965 =============== Item was added: + ----- Method: Text>>addAttribute:unless: (in category 'emphasis') ----- + addAttribute: anAttribute unless: aBlock + "Only add anAttribute when aBlock evaluates to false. Can be used to avoid overwriting existing attributes without knowing exactly where they are. Kind of complements the #dominates: protocol in TextAttribute." + + | offset | + self flag: #performance. "mt: Can we do this faster?" + runs copy withIndexDo: [:attrs :index | + (aBlock cull: attrs cull: index) + ifFalse: [offset ifNil: [ + offset := index]] + ifTrue: [offset ifNotNil: [ + self addAttribute: anAttribute from: offset to: index - 1. + offset := nil]]]. + offset ifNotNil: [ + self addAttribute: anAttribute from: offset to: self size].!

1 0

The Trunk: MonticelloConfigurations-mt.169.mcz
by commits＠source.squeak.org 02 Dec '21

02 Dec '21

Marcel Taeumel uploaded a new version of MonticelloConfigurations to project The Trunk: http://source.squeak.org/trunk/MonticelloConfigurations-mt.169.mcz ==================== Summary ==================== Name: MonticelloConfigurations-mt.169 Author: mt Time: 2 December 2021, 2:56:24.480715 pm UUID: 7c0fb674-93ba-2443-9c53-725956da9084 Ancestors: MonticelloConfigurations-ct.168 We have a few places in the sources, where we hard-code the literal '</a>' in one form or another. In this rather recent example, avoid that through a little indirection to fool the Windows Defender. Also to document the overall issue somewhere within the image. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346… =============== Diff against MonticelloConfigurations-ct.168 =============== Item was changed: ----- Method: MCMcmUpdater>>updateMessageFor: (in category 'private') ----- updateMessageFor: previousUpdateLevel + ^ ('Update completed. Version: {1} Update: {3}{2} Url: <a href="{4}">{4}</{10}> Map: ''{5}'' CI status: <a href="{8}"><img src="{7}" /> {9}</{10}>{6}' translated format: { - ^ ('Update completed. Version: {1} Update: {3}{2} Url: <a href="{4}">{4}</a> Map: ''{5}'' CI status: <a href="{8}"><img src="{7}" /> {9}</a>{6}' translated format: { SystemVersion current version. SystemVersion current highestUpdate. previousUpdateLevel = SystemVersion current highestUpdate ifTrue: [''] ifFalse: [previousUpdateLevel asString, ' -> ']. self repository. MCMcmUpdater updateMapName. SystemVersion current description ifEmpty: [''] ifNotEmpty: [:d | ' ', (d copyReplaceAll: String cr with: ' ')]. SystemVersion current ciStatusBadgeUrl. SystemVersion current ciStatusPageUrl. SystemVersion current ciStatusTimestamp ifNil: ['(build inaccessible!!)' translated]. + "mt: Avoid triggering the Windows Defender. See http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217346…" + 'a'. }) asTextFromHtml!

1 0

Jump to page: