Squeak-dev April 2021

squeak-dev@lists.squeakfoundation.org

33 participants
393 discussions

The Trunk: Graphics-ct.418.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-ct.418.mcz ==================== Summary ==================== Name: Graphics-ct.418 Author: ct Time: 20 September 2019, 7:41:50.741726 pm UUID: eabbce5b-ef86-6e42-8fb2-8b789a51d798 Ancestors: Graphics-nice.417 Add Color>>#veryMuchDarker We also have #veryMuchLighter, so balance this out :) =============== Diff against Graphics-nice.417 =============== Item was added: + ----- Method: Color>>veryMuchDarker (in category 'transformations') ----- + veryMuchDarker + + ^ self alphaMixed: 0.25 with: Color black + !

1 0

The Trunk: Morphic-nice.1625.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-nice.1625.mcz ==================== Summary ==================== Name: Morphic-nice.1625 Author: nice Time: 17 February 2020, 5:06:10.606532 pm UUID: 094e2566-ddfe-2340-8fab-2338d255e164 Ancestors: Morphic-mt.1624 Free our mind from un-initialized LayoutFrame. There should not be any such thing. Require Graphics-nice.425 =============== Diff against Morphic-mt.1624 =============== Item was changed: ----- Method: BorderedMorph>>addMorph:fullFrame: (in category 'resize handling') ----- addMorph: aMorph fullFrame: aLayoutFrame "Add aMorph according to aLayoutFrame." self cellGap > 0 ifTrue: [ | left right bottom top spacing | spacing := self cellGap. + left := aLayoutFrame leftOffset. + right := aLayoutFrame rightOffset. - left := aLayoutFrame leftOffset ifNil: [0]. - right := aLayoutFrame rightOffset ifNil: [0]. + bottom := aLayoutFrame bottomOffset. + top := aLayoutFrame topOffset. - bottom := aLayoutFrame bottomOffset ifNil: [0]. - top := aLayoutFrame topOffset ifNil: [0]. "Add a spacing to the frame if it is not top or leftmost." aLayoutFrame leftFraction = 0 ifFalse: [left := left + spacing] ifTrue: [ "Expect another, resizable widget besides me if I have a fixed width." aLayoutFrame hasFixedWidth ifTrue: [right := right - spacing]]. aLayoutFrame topFraction = 0 ifFalse: [top := top + spacing] ifTrue: [ "Expect another, resizable widget besides me if I have a fixed height." aLayoutFrame hasFixedHeight ifTrue: [bottom := bottom - spacing]]. aLayoutFrame topOffset: top; bottomOffset: bottom; leftOffset: left; rightOffset: right]. super addMorph: aMorph fullFrame: aLayoutFrame. self wantsPaneSplitters ifTrue: [self addPaneSplitters].! Item was changed: ----- Method: BorderedMorph>>addPaneHSplitterAtBottomOfRow: (in category 'resize handling') ----- addPaneHSplitterAtBottomOfRow: someMorphs | targetY minX maxX splitter | targetY := someMorphs first layoutFrame bottomFraction. minX := (someMorphs detectMin: [:each | each layoutFrame leftFraction]) layoutFrame leftFraction. maxX := (someMorphs detectMax: [:each | each layoutFrame rightFraction]) layoutFrame rightFraction. splitter := ProportionalSplitterMorph new beSplitsTopAndBottom; yourself. splitter layoutFrame: (LayoutFrame fractions: (minX @ targetY corner: maxX @ targetY) + offsets: (someMorphs first layoutFrame leftOffset @ 0 + corner: someMorphs first layoutFrame rightOffset @ AbstractResizerMorph gripThickness)). - offsets: ((someMorphs first layoutFrame leftOffset ifNil: [0]) @ 0 - corner: (someMorphs first layoutFrame rightOffset ifNil: [0]) @ AbstractResizerMorph gripThickness)). self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>addPaneVSplitterAtRightOfColumn: (in category 'resize handling') ----- addPaneVSplitterAtRightOfColumn: someMorphs | targetX minY maxY splitter | targetX := someMorphs first layoutFrame rightFraction. minY := (someMorphs detectMin: [:each | each layoutFrame topFraction]) layoutFrame topFraction. maxY := (someMorphs detectMax: [:each | each layoutFrame bottomFraction]) layoutFrame bottomFraction. splitter := ProportionalSplitterMorph new beSplitsLeftAndRight; yourself. splitter layoutFrame: (LayoutFrame fractions: (targetX @ minY corner: targetX @ maxY) + offsets: (0 @ (someMorphs first layoutFrame topOffset) + corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset)))). - offsets: (0 @ (someMorphs first layoutFrame topOffset ifNil: [0]) - corner: (AbstractResizerMorph gripThickness@ (someMorphs first layoutFrame bottomOffset ifNil: [0])))). self addMorphBack: (splitter position: self position).! Item was changed: ----- Method: BorderedMorph>>linkSubmorphsToSplitters (in category 'resize handling') ----- linkSubmorphsToSplitters self splitters do: [:splitter | splitter splitsTopAndBottom ifTrue: [ self submorphsDo: [:morph | ((morph ~= splitter and: [morph layoutFrame bottomFraction = splitter layoutFrame topFraction]) and: [morph layoutFrame hasFixedHeight not + or: [(morph layoutFrame topOffset) < 0]]) - or: [(morph layoutFrame topOffset ifNil: [0]) < 0]]) ifTrue: [splitter addLeftOrTop: morph]. ((morph ~= splitter and: [morph layoutFrame topFraction = splitter layoutFrame bottomFraction]) and: [morph layoutFrame hasFixedHeight not + or: [(morph layoutFrame bottomOffset) > 0]]) - or: [(morph layoutFrame bottomOffset ifNil: [0]) > 0]]) ifTrue: [splitter addRightOrBottom: morph]]]. splitter splitsLeftAndRight ifTrue: [ self submorphsDo: [:morph | ((morph ~= splitter and: [morph layoutFrame rightFraction = splitter layoutFrame leftFraction]) and: [morph layoutFrame hasFixedWidth not + or: [(morph layoutFrame leftOffset) < 0]]) - or: [(morph layoutFrame leftOffset ifNil: [0]) < 0]]) ifTrue: [splitter addLeftOrTop: morph]. ((morph ~= splitter and: [morph layoutFrame leftFraction = splitter layoutFrame rightFraction]) and: [morph layoutFrame hasFixedWidth not + or: [(morph layoutFrame rightOffset) > 0]]) - or: [(morph layoutFrame rightOffset ifNil: [0]) > 0]]) ifTrue: [splitter addRightOrBottom: morph]]]]! Item was changed: ----- Method: ProportionalSplitterMorph>>balanceOffsets (in category 'events') ----- balanceOffsets | fdx fdy | (self hasProperty: #fullDelta) ifFalse: [^ self]. fdx := (self valueOfProperty: #fullDelta) x. fdy := (self valueOfProperty: #fullDelta) y. self layoutFrame hasFixedHeight ifTrue: [ | otop obot ctop cbot topf | otop := (owner submorphs detect: [:m | m layoutFrame topFraction isZero] ifNone: [^ self]) in: [:tm | + tm top - (tm layoutFrame topOffset)]. - tm top - (tm layoutFrame topOffset ifNil: [0])]. obot := (owner submorphs detect: [:m | m layoutFrame bottomFraction = 1] ifNone: [^ self]) in: [:tm | + tm bottom - (tm layoutFrame bottomOffset)]. - tm bottom - (tm layoutFrame bottomOffset ifNil: [0])]. ctop := (self layoutFrame topFraction * (obot - otop)) rounded + + otop + (self layoutFrame topOffset). - + otop + (self layoutFrame topOffset ifNil: [0]). cbot := (self layoutFrame bottomFraction * (obot - otop)) rounded + + otop + (self layoutFrame bottomOffset). - + otop + (self layoutFrame bottomOffset ifNil: [0]). topf := self layoutFrame topFraction. self layoutFrame topFraction: ((ctop + cbot) * 0.5 - otop) / (obot - otop) asFloat. self layoutFrame bottomFraction: self layoutFrame topFraction. self layoutFrame topOffset: self layoutFrame topOffset - fdy. self layoutFrame bottomOffset: self layoutFrame bottomOffset - fdy. (leftOrTop copy union: rightOrBottom) do: [:m | (m layoutFrame topFraction closeTo: topf) ifTrue: [ m layoutFrame topFraction: self layoutFrame topFraction. m layoutFrame topOffset: m layoutFrame topOffset - fdy]. (m layoutFrame bottomFraction closeTo: topf) ifTrue: [ m layoutFrame bottomFraction: self layoutFrame topFraction. m layoutFrame bottomOffset: m layoutFrame bottomOffset - fdy]]] . self layoutFrame hasFixedWidth ifTrue: [ | oleft oright cleft cright leftf | oleft := (owner submorphs detect: [:m | m layoutFrame leftFraction isZero] ifNone: [^ self]) in: [:tm | + tm left - (tm layoutFrame leftOffset)]. - tm left - (tm layoutFrame leftOffset ifNil: [0])]. oright := (owner submorphs detect: [:m | m layoutFrame rightFraction = 1] ifNone: [^ self]) in: [:tm | + tm right - (tm layoutFrame rightOffset)]. - tm right - (tm layoutFrame rightOffset ifNil: [0])]. cleft := (self layoutFrame leftFraction * (oright - oleft)) rounded + + oleft + (self layoutFrame leftOffset). - + oleft + (self layoutFrame leftOffset ifNil: [0]). cright := (self layoutFrame rightFraction * (oright - oleft)) rounded + + oleft + (self layoutFrame rightOffset). - + oleft + (self layoutFrame rightOffset ifNil: [0]). leftf := self layoutFrame leftFraction. self layoutFrame leftFraction: ((cleft + cright) * 0.5 - oleft) / (oright - oleft) asFloat. self layoutFrame rightFraction: self layoutFrame leftFraction. self layoutFrame leftOffset: self layoutFrame leftOffset - fdx. self layoutFrame rightOffset: self layoutFrame rightOffset - fdx. (leftOrTop copy union: rightOrBottom) do: [:m | (m layoutFrame leftFraction closeTo: leftf) ifTrue: [ m layoutFrame leftFraction: self layoutFrame leftFraction. m layoutFrame leftOffset: m layoutFrame leftOffset - fdx]. (m layoutFrame rightFraction closeTo: leftf) ifTrue: [ m layoutFrame rightFraction: self layoutFrame leftFraction. m layoutFrame rightOffset: m layoutFrame rightOffset - fdx.]]] . self removeProperty: #fullDelta. owner layoutChanged ! Item was changed: ----- Method: ProportionalSplitterMorph>>repositionBy: (in category 'events') ----- repositionBy: delta | selfTop selfBottom selfLeft selfRight | self setProperty: #fullDelta toValue: ((self valueOfProperty: #fullDelta) ifNil: [0@0]) + delta. leftOrTop do: [ : each | | firstRight firstBottom firstLeft firstTop | + firstRight := each layoutFrame rightOffset. + firstBottom := each layoutFrame bottomOffset. - firstRight := each layoutFrame rightOffset ifNil: [ 0 ]. - firstBottom := each layoutFrame bottomOffset ifNil: [ 0 ]. each layoutFrame rightOffset: firstRight + delta x. each layoutFrame bottomOffset: firstBottom + delta y. each layoutFrame hasFixedHeight ifTrue: [ + firstTop := each layoutFrame topOffset. - firstTop := each layoutFrame topOffset ifNil: [ 0 ]. each layoutFrame topOffset: firstTop + delta y ]. each layoutFrame hasFixedWidth ifTrue: [ + firstLeft := each layoutFrame leftOffset. - firstLeft := each layoutFrame leftOffset ifNil: [ 0 ]. each layoutFrame leftOffset: firstLeft + delta x. ] ]. rightOrBottom do: [ : each | | secondLeft secondTop secondRight secondBottom | + secondLeft := each layoutFrame leftOffset. + secondTop := each layoutFrame topOffset. - secondLeft := each layoutFrame leftOffset ifNil: [ 0 ]. - secondTop := each layoutFrame topOffset ifNil: [ 0 ]. each layoutFrame leftOffset: secondLeft + delta x. each layoutFrame topOffset: secondTop + delta y. each layoutFrame hasFixedHeight ifTrue: [ + secondBottom := each layoutFrame bottomOffset. - secondBottom := each layoutFrame bottomOffset ifNil: [ 0 ]. each layoutFrame bottomOffset: secondBottom + delta y. ]. each layoutFrame hasFixedWidth ifTrue: [ + secondRight := each layoutFrame rightOffset. - secondRight := each layoutFrame rightOffset ifNil: [ 0 ]. each layoutFrame rightOffset: secondRight + delta x. ] ]. + selfTop := self layoutFrame topOffset. + selfBottom := self layoutFrame bottomOffset. + selfLeft := self layoutFrame leftOffset. + selfRight := self layoutFrame rightOffset. - selfTop := self layoutFrame topOffset ifNil: [ 0 ]. - selfBottom := self layoutFrame bottomOffset ifNil: [ 0 ]. - selfLeft := self layoutFrame leftOffset ifNil: [ 0 ]. - selfRight := self layoutFrame rightOffset ifNil: [ 0 ]. self layoutFrame topOffset: selfTop + delta y ; bottomOffset: selfBottom + delta y ; leftOffset: selfLeft + delta x ; rightOffset: selfRight + delta x. self owner layoutChanged. self movements removeFirst; add: (splitsTopAndBottom ifTrue: [ delta y sign ] ifFalse: [ delta x sign ])! Item was changed: ----- Method: SystemWindow>>convertAlignment (in category 'layout') ----- convertAlignment "Primarily Jesse Welton's code to convert old system windows to ones with modern layout scheme" self layoutPolicy: ProportionalLayout new. (paneMorphs isNil or: [paneRects isNil or: [paneMorphs size ~= paneRects size]]) ifFalse: [self addLabelArea. self putLabelItemsInLabelArea. self setFramesForLabelArea. paneMorphs with: paneRects do: [:m :r | | frame | frame := LayoutFrame new. frame leftFraction: r left; rightFraction: r right; topFraction: r top; bottomFraction: r bottom. m layoutFrame: frame. m hResizing: #spaceFill; vResizing: #spaceFill]]. labelArea isNil ifTrue: [self addLabelArea. self putLabelItemsInLabelArea. self setFramesForLabelArea. paneMorphs ifNotNil: [paneMorphs do: [:m | | frame | frame := m layoutFrame ifNil: [LayoutFrame new]. + frame topOffset: (frame topOffset) - self labelHeight. - frame topOffset: (frame topOffset ifNil: [0]) - self labelHeight. frame bottomFraction ~= 1.0 ifTrue: + [frame bottomOffset: (frame bottomOffset) - self labelHeight]]]]. - [frame bottomOffset: (frame bottomOffset ifNil: [0]) - self labelHeight]]]]. label ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0.5; topFraction: 0; leftOffset: label width negated // 2. label layoutFrame: frame]. collapseBox ifNotNil: [| frame | frame := LayoutFrame new. frame rightFraction: 1; topFraction: 0; rightOffset: -1; topOffset: 1. collapseBox layoutFrame: frame]. stripes ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0; topFraction: 0; rightFraction: 1; leftOffset: 1; topOffset: 1; rightOffset: -1. stripes first layoutFrame: frame. stripes first height: self labelHeight - 2. stripes first hResizing: #spaceFill. frame := LayoutFrame new. frame leftFraction: 0; topFraction: 0; rightFraction: 1; leftOffset: 3; topOffset: 3; rightOffset: -3. stripes last layoutFrame: frame. stripes last height: self labelHeight - 6. stripes last hResizing: #spaceFill]. menuBox ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0; leftOffset: 19; topFraction: 0; topOffset: 1. menuBox layoutFrame: frame]. closeBox ifNotNil: [| frame | frame := LayoutFrame new. frame leftFraction: 0; leftOffset: 4; topFraction: 0; topOffset: 1. closeBox layoutFrame: frame]! Item was changed: ----- Method: SystemWindow>>setPaneRectsFromBounds (in category 'geometry') ----- setPaneRectsFromBounds "Reset proportional specs from actual bounds, eg, after reframing panes" | layoutBounds | layoutBounds := self layoutBounds. paneMorphs do:[:m| | box left bottom top frame right | frame := m layoutFrame. box := m bounds. frame ifNotNil:[ + left := box left - layoutBounds left - frame leftOffset. + right := box right - layoutBounds left - frame rightOffset. + top := box top - layoutBounds top - frame topOffset. + bottom := box bottom - layoutBounds top - frame bottomOffset. - left := box left - layoutBounds left - (frame leftOffset ifNil:[0]). - right := box right - layoutBounds left - (frame rightOffset ifNil:[0]). - top := box top - layoutBounds top - (frame topOffset ifNil:[0]). - bottom := box bottom - layoutBounds top - (frame bottomOffset ifNil:[0]). frame leftFraction: (left / layoutBounds width asFloat). frame rightFraction: (right / layoutBounds width asFloat). frame topFraction: (top / layoutBounds height asFloat). frame bottomFraction: (bottom / layoutBounds height asFloat). ]. ].!

1 0

The Trunk: Tests-mt.449.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Marcel Taeumel uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-mt.449.mcz ==================== Summary ==================== Name: Tests-mt.449 Author: mt Time: 13 April 2021, 10:51:15.223811 am UUID: 23984a3a-fc1c-2a44-a023-9862b3d2ba8d Ancestors: Tests-nice.448 Simplify #testUnknownSelector. Avoid interfering with garbage collection and symbol tables. (Note that #lookup: is the preferred interface, not #findInterned: or #hasInterned:ifTrue:. The concept of internalization should not leak into client code.) =============== Diff against Tests-nice.448 =============== Item was changed: TestCase subclass: #CompilerExceptionsTest + instanceVariableNames: 'text selectionInterval originalText previousSelection originalSelection' - instanceVariableNames: 'text selectionInterval originalText previousSelection originalSelection tearDowns' classVariableNames: '' poolDictionaries: '' category: 'Tests-Compiler'! Item was added: + ----- Method: CompilerExceptionsTest>>generateUnknownSelector (in category 'private') ----- + generateUnknownSelector + + | selector num | + selector := 'yourself'. + num := 0. + [(Symbol lookup: selector, num) notNil] whileTrue: [num := num + 1]. + ^ selector, num! Item was removed: - ----- Method: CompilerExceptionsTest>>setUp (in category 'running') ----- - setUp - - super setUp. - tearDowns := OrderedCollection new. - Symbol hasInterned: self unknownSelector ifTrue: [:symbol | - tearDowns add: [Symbol intern: symbol]]. - Symbol extern: self unknownSelector.! Item was changed: ----- Method: CompilerExceptionsTest>>tearDown (in category 'running') ----- tearDown self removeGeneratedMethods. - Symbol extern: self unknownSelector. - tearDowns do: #value. super tearDown.! Item was changed: ----- Method: CompilerExceptionsTest>>testUnknownSelector (in category 'tests') ----- testUnknownSelector + | unknownSelector | + self flag: #flaky. "mt: This test depends on a list of suggestions that is derived from the system's known selectors. Any desired replacement might not be present in the actual list. Maybe we could use an index-based choice instead." + unknownSelector := self generateUnknownSelector. self + compiling: 'griffle self ' , unknownSelector - compiling: 'griffle self ' , self unknownSelector shouldRaise: UnknownSelector + andSelect: unknownSelector - andSelect: self unknownSelector testing: { + false -> [ + self assertCanceled. + self assert: (Symbol lookup: unknownSelector) isNil]. + 'yourself' -> [ + self assertSucceeded: 'griffle self yourself'. + self assert: (Symbol lookup: unknownSelector) isNil]. + unknownSelector -> [ - false -> [self assertCanceled]. - 'yourself' -> [self assertSucceeded: 'griffle self yourself']. - self unknownSelector -> [ self assertSucceeded. + self assert: (Symbol lookup: unknownSelector) notNil] }. + unknownSelector := self generateUnknownSelector. - self assert: (Symbol hasInterned: self unknownSelector ifTrue: [:symbol |]). - Symbol extern: self unknownSelector] }. self + compiling: 'griffle [ self ' , unknownSelector , ' ] value' - compiling: 'griffle [ self ' , self unknownSelector , ' ] value' shouldRaise: UnknownSelector + andSelect: unknownSelector - andSelect: self unknownSelector testing: { + false -> [ + self assertCanceled. + self assert: (Symbol lookup: unknownSelector) isNil]. + 'yourself' -> [ + self assertSucceeded: 'griffle [ self yourself ] value'. + self assert: (Symbol lookup: unknownSelector) isNil]. + unknownSelector -> [ - false -> [self assertCanceled]. - 'yourself' -> [self assertSucceeded: 'griffle [ self yourself ] value']. - self unknownSelector -> [ self assertSucceeded. + self assert: (Symbol lookup: unknownSelector) notNil] }.! - self assert: (Symbol hasInterned: self unknownSelector ifTrue: [:symbol |])] }.! Item was removed: - ----- Method: CompilerExceptionsTest>>unknownSelector (in category 'private') ----- - unknownSelector - - ^ 'yourrsellff'! Item was removed: - ----- Method: Symbol class>>extern: (in category '*Tests-release') ----- - extern: aStringOrSymbol - - {NewSymbols. SymbolTable} do: [:table | - table remove: aStringOrSymbol ifAbsent: []].!

3 6

The Trunk: Tools-nice.1037.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Nicolas Cellier uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-nice.1037.mcz ==================== Summary ==================== Name: Tools-nice.1037 Author: nice Time: 13 April 2021, 11:48:06.48889 am UUID: 8144ec43-bc2a-4145-8d24-e68052041c0c Ancestors: Tools-eem.1036 Prefer Symbol lookup: to #findInterned: =============== Diff against Tools-eem.1036 =============== Item was changed: ----- Method: StringHolder>>browseLocalSenders (in category '*Tools') ----- browseLocalSenders self selectedClassOrMetaClass ifNotNil: [:cls| | token | token := UIManager default request: 'browse for selector or literal'. token isEmpty ifTrue: [^self]. Scanner new typedScan: token do: [:scannedToken :tokenType| token := tokenType = #word ifTrue: + [(Symbol lookup: token) - [(Symbol findInterned: token) ifNil: [^UIManager default inform: 'no such selector: ', token] ifNotNil: [:symbol| symbol]] ifFalse: [scannedToken]. self systemNavigation browseAllCallsOn: token localTo: cls]]!

1 0

The Trunk: Morphic-nice.1743.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Nicolas Cellier uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-nice.1743.mcz ==================== Summary ==================== Name: Morphic-nice.1743 Author: nice Time: 13 April 2021, 11:46:40.70289 am UUID: d369fef2-23fa-2c47-867b-e21b9615d22b Ancestors: Morphic-eem.1742 Prefer Symbol lookup: to #findInterned: =============== Diff against Morphic-eem.1742 =============== Item was changed: ----- Method: SearchBar>>smartSearch:in: (in category 'searching') ----- smartSearch: text in: morph "Take the user input and perform an appropriate search" | input newContents | self removeResultsWidget. input := text asString ifEmpty:[^self]. self class useSmartSearch ifFalse: [^ ToolSet default browseMessageNames: input]. + (Symbol lookup: input) ifNotNil: - (Symbol findInterned: input) ifNotNil: [:symbol| input := symbol]. "If it is a global or a full class name, browse that class." (Smalltalk bindingOf: input) ifNotNil: [:assoc| | class | class := (assoc value isBehavior ifTrue:[assoc value] ifFalse:[assoc value class]) theNonMetaClass. Project current world submorphs do: [:windowMorph| (windowMorph isSystemWindow and: [(windowMorph model isKindOf: Browser) and: [windowMorph model isDisplayingClass: class]]) ifTrue: [windowMorph beKeyWindow. ^windowMorph model displayClass: class]]. ^ToolSet browse: class selector: nil]. "If it is a symbol and there are implementors of it, browse those implementors." input isSymbol ifTrue: [(SystemNavigation new allImplementorsOf: input) ifNotEmpty: [:list| ^SystemNavigation new browseMessageList: list name: 'Implementors of ' , input]]. "If it starts uppercase, browse classes if any. Otherwise, just search for messages." input first isUppercase ifTrue: [(UIManager default classFromPattern: input withCaption: '') ifNotNil: [:aClass| ^ToolSet browse: aClass selector: nil]. newContents := input, ' -- not found.'. self searchTerm: newContents. self selection: (input size+1 to: newContents size). self currentHand newKeyboardFocus: morph textMorph. ^ self]. "Default to browse message names..." ToolSet default browseMessageNames: input!

1 0

Squeak Oversight Board meeting
by Benoit St-Jean 13 Apr '21

13 Apr '21

What's the frequency of the SOB meetings and around what time do you guys meet? I'm in the Montreal area if that helps. And via which tool? Zoom? Teams? On the same subject (SOB), what is the role and functions of SOB members? I could only find old pages related to that on the swiki! tia

2 1

The Trunk: Monticello-nice.742.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Nicolas Cellier uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-nice.742.mcz ==================== Summary ==================== Name: Monticello-nice.742 Author: nice Time: 13 April 2021, 2:59:20.188121 am UUID: b83bdaba-8e8c-4c01-984a-f5ea46f50529 Ancestors: Monticello-nice.741 Revert Monticello-jr.726 because the proper patch of match: have been integrated already. =============== Diff against Monticello-nice.741 =============== Item was changed: ----- Method: MCStReader>>classDefinitionFrom: (in category 'converting') ----- classDefinitionFrom: aPseudoClass + | tokens traitCompositionString lastIndex classTraitCompositionString typeOfSubclass className | - | tokens definitionStream hasTraitComposition traitCompositionString lastIndex hasClassTraitComposition classTraitCompositionString typeOfSubclass className | tokens := Scanner new scanTokens: aPseudoClass definition. + traitCompositionString := ((ReadStream on: aPseudoClass definition) + match: 'uses:'; + upToAll: 'instanceVariableNames:') withBlanksTrimmed. + classTraitCompositionString := ((ReadStream on: aPseudoClass metaClass definition asString) + match: 'uses:'; + upToAll: 'instanceVariableNames:') withBlanksTrimmed. + traitCompositionString isEmpty ifTrue: [traitCompositionString := '{}']. + classTraitCompositionString isEmpty ifTrue: [classTraitCompositionString := '{}']. - definitionStream := ReadStream on: aPseudoClass definition. - hasTraitComposition := definitionStream match: 'uses:'. - traitCompositionString := hasTraitComposition ifTrue: [(definitionStream upToAll: 'instanceVariableNames:') withBlanksTrimmed] ifFalse: ['{}']. - definitionStream := ReadStream on: aPseudoClass metaClass definition asString. - hasClassTraitComposition := definitionStream match: 'uses:'. - classTraitCompositionString := hasClassTraitComposition ifTrue: [(definitionStream upToAll: 'instanceVariableNames:') withBlanksTrimmed] ifFalse: ['{}']. lastIndex := tokens size. className := tokens at: 3. typeOfSubclass := self typeOfSubclass: (tokens at: 2). "Compiled code classes are special cases of the #bytes class type" (#bytes == typeOfSubclass and: [self compiledCodeClassNames includes: className]) ifTrue: [typeOfSubclass := #compiledMethod]. ^ MCClassDefinition name: className superclassName: (tokens at: 1) traitComposition: traitCompositionString classTraitComposition: classTraitCompositionString category: (tokens at: lastIndex) instVarNames: ((tokens at: lastIndex - 6) findTokens: ' ') classVarNames: ((tokens at: lastIndex - 4) findTokens: ' ') poolDictionaryNames: ((tokens at: lastIndex - 2) findTokens: ' ') classInstVarNames: (self classInstVarNamesFor: aPseudoClass) type: typeOfSubclass comment: (self commentFor: aPseudoClass) commentStamp: (self commentStampFor: aPseudoClass)!

1 0

The Trunk: Tests-nice.448.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-nice.448.mcz ==================== Summary ==================== Name: Tests-nice.448 Author: nice Time: 13 April 2021, 2:56:53.406097 am UUID: 2e7d1b04-14b7-410c-9ef8-20688a8fd857 Ancestors: Tests-nice.447, Tests-jr.436 Merge Tests-jr.436: Test class definition reading =============== Diff against Tests-nice.447 =============== Item was changed: SystemOrganization addCategory: #'Tests-Bugs'! SystemOrganization addCategory: #'Tests-Compiler'! SystemOrganization addCategory: #'Tests-Dependencies'! SystemOrganization addCategory: #'Tests-Digital Signatures'! SystemOrganization addCategory: #'Tests-Environments'! SystemOrganization addCategory: #'Tests-Exceptions'! SystemOrganization addCategory: #'Tests-FilePackage'! SystemOrganization addCategory: #'Tests-Files'! SystemOrganization addCategory: #'Tests-Finalization'! SystemOrganization addCategory: #'Tests-Hex'! SystemOrganization addCategory: #'Tests-Installer-Core'! SystemOrganization addCategory: #'Tests-Localization'! SystemOrganization addCategory: #'Tests-Monticello'! SystemOrganization addCategory: #'Tests-Monticello-Mocks'! SystemOrganization addCategory: #'Tests-Monticello-Utils'! SystemOrganization addCategory: #'Tests-Object Events'! SystemOrganization addCategory: #'Tests-ObjectsAsMethods'! SystemOrganization addCategory: #'Tests-PrimCallController'! SystemOrganization addCategory: #'Tests-Release'! SystemOrganization addCategory: #'Tests-System-Applications'! SystemOrganization addCategory: #'Tests-System-Digital Signatures'! SystemOrganization addCategory: #'Tests-System-Object Storage'! SystemOrganization addCategory: #'Tests-System-Preferences'! SystemOrganization addCategory: #'Tests-System-Support'! SystemOrganization addCategory: #'Tests-Utilities'! SystemOrganization addCategory: #'Tests-VM'! - SystemOrganization addCategory: #'Tests-MonticelloMocks'! SystemOrganization addCategory: #'Tests-Sound'! Item was added: + ----- Method: MCStReaderTest>>testClassDefinition (in category 'tests') ----- + testClassDefinition + | reader definition | + reader := MCStReader on: 'Object subclass: #NewClass + instanceVariableNames: ''instVar1 instVar2'' + classVariableNames: ''ClassVar1 ClassVar2'' + poolDictionaries: ''Pool1 Pool2'' + category: ''NewCategory''!!' readStream. + definition := reader definitions first. + self assert: definition isClassDefinition; + assert: #NewClass equals: definition className; + assert: #(instVar1 instVar2) equals: definition instVarNames asArray; + assert: #(ClassVar1 ClassVar2) equals: definition classVarNames asArray; + assert: #(Pool1 Pool2) equals: definition poolDictionaries asArray; + assert: 'NewCategory' equals: definition category; + assert: '{}' equals: definition traitCompositionString; + assert: '{}' equals: definition classTraitCompositionString.! Item was added: + ----- Method: MCStReaderTest>>testClassDefinitionFromPseudoClass (in category 'tests') ----- + testClassDefinitionFromPseudoClass + | reader pseudoClass definition | + reader := MCStReader new. + pseudoClass := PseudoClass new + name: #NewClass; + definition: 'Object subclass: #NewClass + instanceVariableNames: ''instVar1 instVar2'' + classVariableNames: ''ClassVar1 ClassVar2'' + poolDictionaries: ''Pool1 Pool2'' + category: ''NewCategory'''; + yourself. + definition := reader classDefinitionFrom: pseudoClass. + self assert: definition isClassDefinition; + assert: #NewClass equals: definition className; + assert: #(instVar1 instVar2) equals: definition instVarNames asArray; + assert: #(ClassVar1 ClassVar2) equals: definition classVarNames asArray; + assert: #(Pool1 Pool2) equals: definition poolDictionaries asArray; + assert: 'NewCategory' equals: definition category; + assert: '{}' equals: definition traitCompositionString; + assert: '{}' equals: definition classTraitCompositionString.!

1 0

The Trunk: Tests-jr.436.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Nicolas Cellier uploaded a new version of Tests to project The Trunk: http://source.squeak.org/trunk/Tests-jr.436.mcz ==================== Summary ==================== Name: Tests-jr.436 Author: jr Time: 28 June 2020, 10:18:05.236052 pm UUID: 049894aa-5f79-a44d-a2c0-ee65887af7ac Ancestors: Tests-mt.435 Test class definition reading testClassDefinitionFromPseudoClass exposes the traitComposition bug triggered by Collections-ul.900. Monticello-jr.726 is supposed to fix this bug. =============== Diff against Tests-mt.435 =============== Item was added: + ----- Method: MCStReaderTest>>testClassDefinition (in category 'tests') ----- + testClassDefinition + | reader definition | + reader := MCStReader on: 'Object subclass: #NewClass + instanceVariableNames: ''instVar1 instVar2'' + classVariableNames: ''ClassVar1 ClassVar2'' + poolDictionaries: ''Pool1 Pool2'' + category: ''NewCategory''!!' readStream. + definition := reader definitions first. + self assert: definition isClassDefinition; + assert: #NewClass equals: definition className; + assert: #(instVar1 instVar2) equals: definition instVarNames asArray; + assert: #(ClassVar1 ClassVar2) equals: definition classVarNames asArray; + assert: #(Pool1 Pool2) equals: definition poolDictionaries asArray; + assert: 'NewCategory' equals: definition category; + assert: '{}' equals: definition traitCompositionString; + assert: '{}' equals: definition classTraitCompositionString.! Item was added: + ----- Method: MCStReaderTest>>testClassDefinitionFromPseudoClass (in category 'tests') ----- + testClassDefinitionFromPseudoClass + | reader pseudoClass definition | + reader := MCStReader new. + pseudoClass := PseudoClass new + name: #NewClass; + definition: 'Object subclass: #NewClass + instanceVariableNames: ''instVar1 instVar2'' + classVariableNames: ''ClassVar1 ClassVar2'' + poolDictionaries: ''Pool1 Pool2'' + category: ''NewCategory'''; + yourself. + definition := reader classDefinitionFrom: pseudoClass. + self assert: definition isClassDefinition; + assert: #NewClass equals: definition className; + assert: #(instVar1 instVar2) equals: definition instVarNames asArray; + assert: #(ClassVar1 ClassVar2) equals: definition classVarNames asArray; + assert: #(Pool1 Pool2) equals: definition poolDictionaries asArray; + assert: 'NewCategory' equals: definition category; + assert: '{}' equals: definition traitCompositionString; + assert: '{}' equals: definition classTraitCompositionString.!

1 0

The Trunk: ST80-ct.258.mcz
by commits＠source.squeak.org 13 Apr '21

13 Apr '21

Nicolas Cellier uploaded a new version of ST80 to project The Trunk: http://source.squeak.org/trunk/ST80-ct.258.mcz ==================== Summary ==================== Name: ST80-ct.258 Author: ct Time: 5 September 2020, 1:20:54.682421 am UUID: db2a2f67-e818-ea46-b2f6-f4a9950577db Ancestors: ST80-mt.257 Fixes home and end keys in MVC editors if the text is empty =============== Diff against ST80-mt.257 =============== Item was changed: ----- Method: ParagraphEditor>>cursorEnd: (in category 'nonediting/nontyping keys') ----- cursorEnd: characterStream "Private - Move cursor end of current line." | string | self closeTypeIn: characterStream. string := paragraph text string. self moveCursor: [:position | Preferences wordStyleCursorMovement + ifTrue: [ + paragraph lines + at: (paragraph lineIndexOfCharacterIndex: position) + ifPresent: [:targetLine | targetLine last + (targetLine last = string size) asBit] + ifAbsent: [position]] + ifFalse: [ - ifTrue:[| targetLine | - targetLine := paragraph lines at:(paragraph lineIndexOfCharacterIndex: position). - targetLine = paragraph lines last - ifTrue:[targetLine last + 1] - ifFalse:[targetLine last]] - ifFalse:[ string indexOfAnyOf: CharacterSet crlf startingAt: position ifAbsent:[string size + 1]]] forward: true specialBlock:[:dummy | string size + 1]. ^true! Item was changed: ----- Method: ParagraphEditor>>cursorHome: (in category 'nonediting/nontyping keys') ----- cursorHome: characterStream "Private - Move cursor from position in current line to beginning of current line. If control key is pressed put cursor at beginning of text" | string | string := paragraph text string. self + moveCursor: [:position | Preferences wordStyleCursorMovement + ifTrue: [ + paragraph lines + at: (paragraph lineIndexOfCharacterIndex: position) + ifPresent: [:targetLine | targetLine first] ifAbsent: [position]] - moveCursor: [ :position | Preferences wordStyleCursorMovement - ifTrue:[ - (paragraph lines at:(paragraph lineIndexOfCharacterIndex: position)) first] ifFalse:[ (string lastIndexOfAnyOf: CharacterSet crlf startingAt: position - 1) + 1]] forward: false specialBlock: [:dummy | 1]. ^true!

1 0

← Newer
1
...
31
32
33
34
35
36
37
...
40
Older →

Jump to page: