Squeak-dev July 2021

squeak-dev@lists.squeakfoundation.org

25 participants
180 discussions

Speech.sar is missing
by Thiede, Christoph 14 Oct '21

14 Oct '21

Hi all, I tried to load the Speech package from SqueakMap into a current Trunk image, but the installation fails because the Speech-Phonetics category seems to be missing in the SAR package. Would it be possible to update the SAR with this package or is the dependency structure more complicated than I am assuming? Thanks in advance! Best, Christoph <http://www.hpi.de/>

4 17

The Trunk: Network-dtl.240.mcz
by commits＠source.squeak.org 21 Sep '21

21 Sep '21

David T. Lewis uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-dtl.240.mcz ==================== Summary ==================== Name: Network-dtl.240 Author: dtl Time: 6 April 2020, 10:33:07.751386 pm UUID: a8f00e08-7398-4d4a-8cd2-09cedcada729 Ancestors: Network-eem.239 This update enables the Squeak new networking and IPv6 support by default. The update is in the package postscript. IPv6 network support for the VM (SocketPlugin) and image were implemented by Ian Piumarta circa 2007. This included IPv6 support and a more general image-side representation of network addressing. In 2012, this work was merged into Squeak trunk, with a preference to switch between the old networking support or the new networking support with IPv6. At that time, there were concerns with performance of NetNameResolver on some Windows platforms, and for this reason the "Enable IPv6 and new network support" preference was left disabled for official Squeak distributions. It now 2020, and operating systems have improved over the years, so it is time to enable the new networking preference by default. =============== Diff against Network-eem.239 =============== Item was changed: + (PackageInfo named: 'Network') postscript: '"Enable IPv6 and new network support by default" + NetNameResolver enableIPv6: true + '! - (PackageInfo named: 'Network') postscript: '"Rebuild CSNonAtom." - MailAddressTokenizer cleanUp: false'!

8 14

The Trunk: Morphic-mt.1755.mcz
by commits＠source.squeak.org 20 Sep '21

20 Sep '21

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.1755.mcz ==================== Summary ==================== Name: Morphic-mt.1755 Author: mt Time: 18 April 2021, 7:00:43.878254 pm UUID: e5705780-2988-a54e-b6c7-21b4194fcd5c Ancestors: Morphic-mt.1754, Morphic-ct.1659 Fix our two menu-invocating buttons to act on mouse-down and actually look like menus: (1) menu button in system window and (2) change-set button in world-main-docking-bar. Merges Morphic-ct.1659. Thanks Christoph (ct) for pointing out this issue about menu invocation through buttons. See http://forum.world.st/The-Inbox-Morphic-ct-1659-mcz-tp5116728.html By example, this commit also adds a menu to the change-set button in the docking bar. This menu lists the latest method and class changes. To make this work, the following things got addressed: - Fixes DockingBarUpdatingItemMorph, which missed several changes from DockingBarItemMorph. (Interesting specialization challenge...) - Let menus #rubberBandCells to allow for changing menu item's widths. - Adds query about latest changes to #listChangesOn:. (Feel free to improve this. Maybe add preference for number of elements?) Complements (and depends on) System-mt.1228 and Tools-mt.1042. =============== Diff against Morphic-mt.1754 =============== Item was changed: ----- Method: DockingBarMorph>>addUpdatingItem: (in category 'construction') ----- addUpdatingItem: aBlock | item | item := DockingBarUpdatingItemMorph new. aBlock value: item. + item subMenu ifNotNil: [:menu | + "Docking bar and protruding menu should appear visually merged." + menu morphicLayerNumber: self morphicLayerNumber + 1]. self addMorphBack: item! Item was changed: ----- Method: DockingBarMorph>>ensureSelectedItem: (in category 'events') ----- ensureSelectedItem: evt self selectedItem ifNil: [ self selectItem: ( self submorphs + detect: [ :each | each isMenuItemMorph ] - detect: [ :each | each isKindOf: DockingBarItemMorph ] ifNone: [ ^self ]) event: evt ]! Item was changed: ----- Method: DockingBarMorph>>filterEvent:for: (in category 'events-processing') ----- filterEvent: aKeyboardEvent for: anObject "Provide keyboard shortcuts." | index itemToSelect | aKeyboardEvent controlKeyPressed ifFalse: [^ aKeyboardEvent]. aKeyboardEvent isKeystroke ifFalse: [^ aKeyboardEvent]. "Search field." aKeyboardEvent keyCharacter = $0 ifTrue: [ self searchBarMorph ifNotNil: [ :morph | morph model activate: aKeyboardEvent in: morph ]. ^ aKeyboardEvent ignore "hit!!"]. "Select menu items." (aKeyboardEvent keyValue between: $1 asciiValue and: $9 asciiValue) ifFalse: [^ aKeyboardEvent]. index := aKeyboardEvent keyValue - $1 asciiValue + 1. itemToSelect := (self submorphs select: [ :each | + each isMenuItemMorph ]) - each isKindOf: DockingBarItemMorph ]) at: index ifAbsent: [^ aKeyboardEvent]. self activate: aKeyboardEvent. self selectItem: itemToSelect event: aKeyboardEvent. ^ aKeyboardEvent ignore "hit!!"! Item was changed: ----- Method: DockingBarMorph>>moveSelectionDown:event: (in category 'control') ----- moveSelectionDown: direction event: evt "Move the current selection up or down by one, presumably under keyboard control. direction = +/-1" | index | index := (submorphs indexOf: selectedItem ifAbsent: [1-direction]) + direction. submorphs do: "Ensure finite" [:unused | | m | m := submorphs atWrap: index. + (m isMenuItemMorph and: [m isEnabled]) ifTrue: - ((m isKindOf: DockingBarItemMorph) and: [m isEnabled]) ifTrue: [^ self selectItem: m event: evt]. "Keep looking for an enabled item" index := index + direction sign]. ^ self selectItem: nil event: evt! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>adjacentTo (in category 'selecting') ----- + adjacentTo + + | roundedCornersOffset verticalOffset | + roundedCornersOffset := MenuMorph roundedMenuCorners + ifTrue: [Morph preferredCornerRadius negated] + ifFalse: [0]. + verticalOffset := 2. + + owner isFloating + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToTop + ifTrue: [^ {self bounds bottomLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToLeft + ifTrue: [^ {self bounds topRight + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToBottom + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ verticalOffset)}]. + owner isAdheringToRight + ifTrue: [^ {self bounds topLeft + (roundedCornersOffset @ verticalOffset negated)}]. + ^ {self bounds bottomLeft + (roundedCornersOffset @ 5)}! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>createSubmenu (in category 'private') ----- + createSubmenu + + ^DockingBarMenuMorph new! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>createUpdatingSubmenu (in category 'private') ----- + createUpdatingSubmenu + + ^DockingBarUpdatingMenuMorph new! Item was changed: + ----- Method: DockingBarUpdatingItemMorph>>decorateOwner (in category 'world') ----- - ----- Method: DockingBarUpdatingItemMorph>>decorateOwner (in category 'as yet unclassified') ----- decorateOwner "Ignore."! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawIconOn: (in category 'drawing') ----- + drawIconOn: aCanvas + + | pos | + self hasIcon ifTrue: [ + | iconForm | + iconForm := self iconForm. + + pos := (contents + ifEmpty: [self left + (self width - iconForm width // 2)] + ifNotEmpty: [self left]) + @ (self top + (self height - iconForm height // 2)). + + aCanvas + translucentImage: iconForm + at: pos].! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawLabelOn: (in category 'drawing') ----- + drawLabelOn: aCanvas + + | stringBounds | + self contents ifEmpty: [^ self]. + + stringBounds := bounds. + + self hasIcon ifTrue: [ + stringBounds := stringBounds left: stringBounds left + self iconForm width + 2 ]. + + "Vertical centering." + stringBounds := stringBounds top: stringBounds top + stringBounds bottom - self fontToUse height // 2. + "Horizontal centering." + stringBounds := stringBounds left: stringBounds left + (stringBounds width - (self fontToUse widthOfString: contents) // 2) abs. + + aCanvas + drawString: contents + in: stringBounds + font: self fontToUse + color: self colorToUse.! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>drawSubMenuMarkerOn: (in category 'drawing') ----- + drawSubMenuMarkerOn: aCanvas + "Ignore."! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>mouseDown: (in category 'events') ----- + mouseDown: evt + "Handle a mouse down event. Menu items get activated when the mouse is over them." + + (evt shiftPressed and:[self wantsKeyboardFocusOnShiftClick]) ifTrue: [ ^super mouseDown: evt ]. "enable label editing" + isSelected + ifTrue: [ + owner selectItem: nil event: evt. ] + ifFalse: [ + owner activate: evt. "Redirect to menu for valid transitions" + owner selectItem: self event: evt. ] + ! Item was changed: + ----- Method: DockingBarUpdatingItemMorph>>mouseEnter: (in category 'events') ----- - ----- Method: DockingBarUpdatingItemMorph>>mouseEnter: (in category 'as yet unclassified') ----- mouseEnter: evt "Do not hover docking bar items directory. Mouse-down required. But if you already see a submenu, support hovering." owner selectedItem ifNotNil: [owner selectItem: self event: evt]! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>mouseUp: (in category 'events') ----- + mouseUp: evt + "Handle a mouse up event. Menu items get activated when the mouse is over them. Do nothing if we're not in a 'valid menu transition', meaning that the current hand focus must be aimed at the owning menu." + + evt hand mouseFocus == owner ifFalse: [ ^self ]. + self contentString ifNotNil: [ + self contents: self contentString withMarkers: true inverse: true. + self refreshWorld. + (Delay forMilliseconds: 200) wait ].! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>select: (in category 'selecting') ----- + select: evt + + super select: evt. + subMenu ifNotNil: [ + evt hand newKeyboardFocus: subMenu ]! Item was added: + ----- Method: DockingBarUpdatingItemMorph>>wantsKeyboardFocusOnShiftClick (in category 'events') ----- + wantsKeyboardFocusOnShiftClick + "set this preference to false to prevent user editing of docking bar menu items" + ^Preferences valueOfPreference: #allowMenubarItemEditing ifAbsent: [false]! Item was added: + ----- Method: DockingBarUpdatingMenuMorph>>morphicLayerNumber: (in category 'update') ----- + morphicLayerNumber: n + + super morphicLayerNumber: n. + ! Item was changed: ----- Method: MenuMorph>>initialize (in category 'initialization') ----- initialize super initialize. self setDefaultParameters. self changeTableLayout. self listDirection: #topToBottom. self hResizing: #shrinkWrap. self vResizing: #shrinkWrap. + self rubberBandCells: true. self disableLayout: true. self morphicLayerNumber: self class menuLayer. defaultTarget := nil. selectedItem := nil. stayUp := false. popUpOwner := nil.! Item was changed: ----- Method: SystemWindow>>createMenuBox (in category 'initialization') ----- createMenuBox ^ (self createBox: self class menuBoxImage) actionSelector: #offerWindowMenu; + setBalloonText: 'window menu' translated; + actWhen: #buttonDown; + yourself! - setBalloonText: 'window menu' translated! Item was changed: + ----- Method: TheWorldMainDockingBar>>browseChanges (in category 'submenu - changes') ----- - ----- Method: TheWorldMainDockingBar>>browseChanges (in category 'right side') ----- browseChanges ChangeSorter open.! Item was changed: + ----- Method: TheWorldMainDockingBar>>browseChangesLabel (in category 'submenu - changes') ----- - ----- Method: TheWorldMainDockingBar>>browseChangesLabel (in category 'right side') ----- browseChangesLabel "The project name is the same as the current change set." ^ Project current name! Item was added: + ----- Method: TheWorldMainDockingBar>>changesMenuOn: (in category 'submenu - changes') ----- + changesMenuOn: aDockingBar + + aDockingBar addUpdatingItem: [:item | + item + help: 'Browse this project''s changes' translated; + wordingProvider: self + wordingSelector: #browseChangesLabel; + subMenuUpdater: self + selector: #listChangesOn:].! Item was changed: ----- Method: TheWorldMainDockingBar>>fillDockingBar: (in category 'construction') ----- fillDockingBar: aDockingBar "Private - fill the given docking bar" self menusOn: aDockingBar. aDockingBar addSpacer. + self changesMenuOn: aDockingBar. - self projectNameOn: aDockingBar. aDockingBar addSpacer. self rightSideOn: aDockingBar. aDockingBar setProperty: #mainDockingBarTimeStamp toValue: self class timeStamp.! Item was added: + ----- Method: TheWorldMainDockingBar>>listChangesOn: (in category 'submenu - changes') ----- + listChangesOn: menu + + | latestMethodChanges latestClassChanges| + latestMethodChanges := (Array streamContents: [:s | + ChangeSet current changedMethodsDo: [:method :changeType :dateAndTime :category | + s nextPut: { dateAndTime. method. changeType. category }]]) + sorted: [:a :b | a first >= b first]. + + 1 to: (10 min: latestMethodChanges size) do: [:index | | spec method | + spec := latestMethodChanges at: index. + method := spec second. + menu addItem: [:item | + item + contents: ('{1} {2} \{{3}\} \{{4}\}' format: {method methodClass. method selector. spec fourth. method methodClass category}) ; + target: ToolSet; + balloonText: spec third asString; + icon: ((#(remove addedThenRemoved) includes: spec third) ifTrue: [MenuIcons smallDeleteIcon] ifFalse: [ + spec third = #add ifTrue: [MenuIcons smallNewIcon] ifFalse: [MenuIcons blankIcon]]); + selector: (method isInstalled ifTrue: [#browseMethod:] ifFalse: [#browseMethodVersion:]); + arguments: {method}]]. + + latestClassChanges := (Array streamContents: [:s | + ChangeSet current changedClassesDo: [:class :changeTypes :dateAndTime :category | + "We are not interested in classes whose method's did only change." + changeTypes ifNotEmpty: [s nextPut: { dateAndTime. class. changeTypes. category }]]]) + sorted: [:a :b | a first >= b first]. + + latestClassChanges ifNotEmpty: [menu addLine]. + 1 to: (10 min: latestClassChanges size) do: [:index | | spec class | + spec := latestClassChanges at: index. + class := spec second. + menu addItem: [:item | + item + contents: ('{1} \{{2}\}' format: {class name. spec fourth }) ; + target: ToolSet; + balloonText: (spec third sorted joinSeparatedBy: Character space); + icon: ((spec third includesAnyOf: #(remove addedThenRemoved)) + ifTrue: [MenuIcons smallDeleteIcon] + ifFalse: [ + (spec third includes: #add) + ifTrue: [MenuIcons smallNewIcon] + ifFalse: [MenuIcons blankIcon]]); + selector: ((spec third includes: #remove) ifTrue: [#inspect:] ifFalse: [#browseClass:]); + arguments: {class}]]. + + menu addLine; addItem: [:item | + item + contents: 'Browse current change set...' translated; + target: self; + selector: #browseChanges].! Item was removed: - ----- Method: TheWorldMainDockingBar>>projectNameOn: (in category 'right side') ----- - projectNameOn: aDockingBar - - aDockingBar addUpdatingItem: [:item | - item - help: 'Browse this project''s changes'; - target: self; - selector: #browseChanges; - wordingProvider: self - wordingSelector: #browseChangesLabel].! Item was changed: + (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances.'! - (PackageInfo named: 'Morphic') postscript: 'Transcript showln: ''[NOTICE] There is a new preference called "Interactive print-it". Please check your preference browser to choose the preferred value.'''!

4 6

The Inbox: Morphic-ct.1771.mcz
by commits＠source.squeak.org 20 Sep '21

20 Sep '21

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1771.mcz ==================== Summary ==================== Name: Morphic-ct.1771 Author: ct Time: 25 May 2021, 7:38:48.072683 pm UUID: 5a9ddaf0-a062-7047-b5b2-d2ae2da3fe15 Ancestors: Morphic-mt.1769 Fixes a bottleneck when opening a yellow button menu on a morph that contains a very large number of subsub*morphs. On not-so-fast systems, this can be reproduced using: self systemNavigation browseAllSelect: #notNil On faster systems, you might need to write a small toolbuilder application to reproduce the bottleneck. I have an app with >10k list items in my image which actually blocked the image for several seconds when I yellow-clicked the window. Fixed the problem without duplicating the logic of #allStringsAfter: by using a generator. =============== Diff against Morphic-mt.1769 =============== Item was changed: ----- Method: Morph>>addYellowButtonMenuItemsTo:event: (in category 'menu') ----- addYellowButtonMenuItemsTo: aMenu event: evt "Populate aMenu with appropriate menu items for a yellow-button (context menu) click." aMenu defaultTarget: self. "" Preferences noviceMode ifFalse: [aMenu addStayUpItem]. "" self addModelYellowButtonItemsTo: aMenu event: evt. "" Preferences generalizedYellowButtonMenu ifFalse: [^ self]. "" aMenu addLine. aMenu add: 'inspect' translated action: #inspect. "" aMenu addLine. self world selectedObject == self ifTrue: [aMenu add: 'deselect' translated action: #removeHalo] ifFalse: [aMenu add: 'select' translated action: #addHalo]. "" (self isWorldMorph or: [self mustBeBackmost or: [self wantsToBeTopmost]]) ifFalse: ["" aMenu addLine. aMenu add: 'send to back' translated action: #goBehind. aMenu add: 'bring to front' translated action: #comeToFront. self addEmbeddingMenuItemsTo: aMenu hand: evt hand]. "" self isWorldMorph ifFalse: ["" Smalltalk at: #NCAAConnectorMorph ifPresent: [:connectorClass | aMenu addLine. aMenu add: 'connect to' translated action: #startWiring. aMenu addLine]. "" self isFullOnScreen ifFalse: [aMenu add: 'move onscreen' translated action: #goHome]]. "" Preferences noviceMode ifFalse: ["" self addLayoutMenuItems: aMenu hand: evt hand. (owner notNil and: [owner isTextMorph]) ifTrue: [self addTextAnchorMenuItems: aMenu hand: evt hand]]. "" self isWorldMorph ifFalse: ["" aMenu addLine. self addToggleItemsToHaloMenu: aMenu]. "" aMenu addLine. self isWorldMorph ifFalse: [aMenu add: 'copy to paste buffer' translated action: #copyToPasteBuffer:]. + (Generator on: [:gen | self streamAllStringsAfter: nil on: gen]) in: [:gen | + "optimized!! #allStringsAfter: can be slow for large subtrees." + gen atEnd ifFalse: [ + aMenu add: 'copy text' translated action: #clipText]]. - (self allStringsAfter: nil) isEmpty - ifFalse: [aMenu add: 'copy text' translated action: #clipText]. "" self addExportMenuItems: aMenu hand: evt hand. "" (Preferences noviceMode not and: [self isWorldMorph not]) ifTrue: ["" aMenu addLine. aMenu add: 'adhere to edge...' translated action: #adhereToEdge]. "" self addCustomMenuItems: aMenu hand: evt hand! Item was changed: ----- Method: Morph>>allStringsAfter: (in category 'debug and other') ----- + allStringsAfter: aSubmorph - allStringsAfter: aSubmorph - "return an OrderedCollection of strings of text in my submorphs. If aSubmorph is non-nil, begin with that container." + ^ OrderedCollection streamContents: [:stream | + self streamAllStringsAfter: aSubmorph on: stream]! - | list ok | - list := OrderedCollection new. - ok := aSubmorph isNil. - self allMorphsDo: - [:sub | | string | - ok ifFalse: [ok := sub == aSubmorph]. "and do this one too" - ok - ifTrue: - [(string := sub userString) ifNotNil: - [string isString ifTrue: [list add: string] ifFalse: [list addAll: string]]]]. - ^list! Item was added: + ----- Method: Morph>>streamAllStringsAfter:on: (in category 'debug and other') ----- + streamAllStringsAfter: aSubmorph on: aStream + "Stream all strings of text in my submorphs on aStream. If aSubmorph is non-nil, begin with that container." + + | ok | + ok := aSubmorph isNil. + self allMorphsDo: [:sub | | string | + ok ifFalse: [ok := sub == aSubmorph]. + "and do this one too" + ok ifTrue: [ + (string := sub userString) + ifNotNil: [string isString + ifTrue: [aStream nextPut: string] + ifFalse: [aStream nextPutAll: string]]]].!

4 4

The Trunk: Chronology-Core-ul.55.mcz
by commits＠source.squeak.org 19 Sep '21

19 Sep '21

Levente Uzonyi uploaded a new version of Chronology-Core to project The Trunk: http://source.squeak.org/trunk/Chronology-Core-ul.55.mcz ==================== Summary ==================== Name: Chronology-Core-ul.55 Author: ul Time: 31 May 2020, 12:10:20.250221 am UUID: ea36b609-177c-405a-b64e-9988deb3d26e Ancestors: Chronology-Core-nice.52 Automatically update the time zone cached by the VM every 30 minutes: - copied and modified Eliot's accessor to primitive 243 to do the actual updating (Time class >> #primitiveUpdateTimeZone) - update happens when Time class >> #posixMicrosecondClockWithOffset or Time class >> #posixMicrosecondClockWithOffset: are sent. Other low-level accessors of the VM time zone are not updating the cached time zone value (e.g. Time class >> #localMicrosecondClockPrimitive) - actual update happens in Time class >> #updateTimeZoneCacheAt: - postscript activates the update mechanism which can be turned off by evaluating [ Time classPool at: #UpdateVMTimeZoneCacheAt put: nil ] Other changes: - do not send Time class >> #initialize from DateAndTime class >> #startUp:. Let Time have its own #startUp: method instead. Postscript adds Time to the startUpList before DateAndTime. - do not send super initialize from DateAndTime class >> #initialize - do not send #automaticTimezone to DateAndTime on startup, because that's just an accessor with no side effects - do not overwrite set variables in Time class >> #initialize - assert that the value passed to Time class >> #clockPolicy: is one of the known values =============== Diff against Chronology-Core-nice.52 =============== Item was changed: ----- Method: DateAndTime class>>initialize (in category 'initialize-release') ----- initialize - super initialize. - ClockProvider := Time. PosixEpochJulianDays := 2440588. InitializeFromPrimitive := self canInitializeFromPrimitive. Smalltalk addToStartUpList: self. self startUp: true ! Item was changed: ----- Method: DateAndTime class>>startUp: (in category 'system startup') ----- startUp: startingAfresh "Set local timezone" startingAfresh ifTrue: [InitializeFromPrimitive := self canInitializeFromPrimitive. Time initialize. "set LastClockTick to 0". + self now]! - self now. - self automaticTimezone]! Item was changed: Magnitude subclass: #Time instanceVariableNames: 'seconds nanos' + classVariableNames: 'ClockPolicy HighResClockTicksPerMillisecond LastClockTick UpdateVMTimeZoneCacheAt UseHighResClockForTiming' - classVariableNames: 'ClockPolicy HighResClockTicksPerMillisecond LastClockTick UseHighResClockForTiming' poolDictionaries: 'ChronologyConstants' category: 'Chronology-Core'! !Time commentStamp: 'dew 10/23/2004 17:58' prior: 0! This represents a particular point in time during any given day. For example, '5:19:45 pm'. If you need a point in time on a particular day, use DateAndTime. If you need a duration of time, use Duration. ! Item was changed: ----- Method: Time class>>clockPolicy: (in category 'class initialization') ----- clockPolicy: aSymbol "When sequencial calls are made to DateAndTime now, it may be desirable to force the system clock to be monotonic, and it may be desirable for the clock to appear to be strictly increasing with no repeat values. The ClockPolicy identifies which of several possible strategies to use. Allowable values are #acceptPlatformTime #monotonicAllowDuplicates #monotonicForceMicrosecondIncrement #monotonicForceNanosecondIncrement " + self assert: ( + #( + acceptPlatformTime + monotonicAllowDuplicates + monotonicForceMicrosecondIncrement + monotonicForceNanosecondIncrement) includes: aSymbol). ClockPolicy := aSymbol! Item was changed: ----- Method: Time class>>initialize (in category 'class initialization') ----- initialize + " self initialize " - "Time initialize" + LastClockTick ifNil: [ LastClockTick := 0 ]. - "Initialize at startup time to protect for the case of an image saved with bad LastClockTick" - LastClockTick := 0. + HighResClockTicksPerMillisecond ifNil: [ HighResClockTicksPerMillisecond := 0 ]. - HighResClockTicksPerMillisecond := 0. + ClockPolicy ifNil: [ + "self clockPolicy: #acceptPlatformTime." + self clockPolicy: #monotonicAllowDuplicates. + "self clockPolicy: #monotonicForceMicrosecondIncrement." + "self clockPolicy: #monotonicForceNanosecondIncrement." ]! - "self clockPolicy: #acceptPlatformTime." - self clockPolicy: #monotonicAllowDuplicates. - "self clockPolicy: #monotonicForceMicrosecondIncrement." - "self clockPolicy: #monotonicForceNanosecondIncrement." - ! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset (in category 'clock') ----- posixMicrosecondClockWithOffset "Answer an array with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." + | array posixUtcValue | - | array utcValue | array := self primPosixMicrosecondClockWithOffset. + posixUtcValue := array at: 1. + (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." + self primPosixMicrosecondClockWithOffset: array. + posixUtcValue := array at: 1 ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ array] . [#monotonicAllowDuplicates] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [array at: 1 put: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" array at: 1 put: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := array at: 1. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" array at: 1 put: LastClockTick]] } otherwise: []. + ^array! - ^array - - ! Item was changed: ----- Method: Time class>>posixMicrosecondClockWithOffset: (in category 'clock') ----- posixMicrosecondClockWithOffset: aDateAndTime "Initialize aDateAndTime initialized with local microseconds since the Posix epoch and the current seconds offset from GMT in the local time zone." + | posixUtcValue | - - | utcValue | self primPosixMicrosecondClockWithOffset: aDateAndTime. + posixUtcValue := aDateAndTime utcMicroseconds. + (self updateTimeZoneCacheAt: posixUtcValue) ifTrue: [ "Time zone may have changed: fetch again." + self primPosixMicrosecondClockWithOffset: aDateAndTime . + posixUtcValue := aDateAndTime utcMicroseconds ]. ClockPolicy caseOf: { [#acceptPlatformTime] -> [^ aDateAndTime] . [#monotonicAllowDuplicates] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceMicrosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + 1. "add one microsecond" aDateAndTime utcMicroseconds: LastClockTick]] . [#monotonicForceNanosecondIncrement] -> [ + posixUtcValue > LastClockTick + ifTrue: [LastClockTick := posixUtcValue] - utcValue := aDateAndTime utcMicroseconds. - utcValue > LastClockTick - ifTrue: [LastClockTick := utcValue] ifFalse: [LastClockTick := LastClockTick + (1 / 1000). "add one nanosecond" aDateAndTime utcMicroseconds: LastClockTick]] } otherwise: []. + ^aDateAndTime! - ^aDateAndTime - ! Item was added: + ----- Method: Time class>>primitiveUpdateTimeZone (in category 'clock') ----- + primitiveUpdateTimeZone + "Update the VMs notion of the current time zone. The VM sets its notion + of the time zone once at start-up. If one wants the VM to keep its notion + up-to-date arrange to invoke this primitive periodically." + + <primitive: 243> + ^nil "Return nil instead of self to indicate that the primitive failed."! Item was added: + ----- Method: Time class>>startUp: (in category 'system startup') ----- + startUp: resuming + + resuming ifTrue: [ + LastClockTick := 0 ]! Item was added: + ----- Method: Time class>>updateTimeZoneCacheAt: (in category 'clock') ----- + updateTimeZoneCacheAt: posixUtcMicrosecondClock + "Tell the VM to update its cached time zone value if the POSIX UTC time reached the valute stored in UpdateVMTimeZoneCacheAt has been reached. Assume that posixUtcMicrosecondClock is an integer with the current POSIX UTC microsecond clock value. Return true when the cache was updated to indicate that the time zone may have changed." + + | updateInterval | + UpdateVMTimeZoneCacheAt ifNil: [ + "Automatic update is disabled." + ^false ]. + posixUtcMicrosecondClock < UpdateVMTimeZoneCacheAt ifTrue: [ ^false ]. + self primitiveUpdateTimeZone ifNil: [ + "The primitive failed." + ^false ]. + updateInterval := 1800000000. "This could be a preference but 30 minutes matches all upcoming DST change times." + UpdateVMTimeZoneCacheAt := posixUtcMicrosecondClock // updateInterval + 1 * updateInterval "Round up posixUtcMicrosecondClock to the next multiple of updateInterval.". + ^true! Item was changed: + (PackageInfo named: 'Chronology-Core') postscript: '"Make sure UpdateVMTimeZoneCacheAt of Time is initialized." + Time classPool at: #UpdateVMTimeZoneCacheAt put: 0. + "Separated Time''s startup duties from DateAndTime." + Smalltalk addToStartUpList: Time before: DateAndTime'! - (PackageInfo named: 'Chronology-Core') postscript: 'DateAndTime startUp: true. - HashedCollection rehashAll. - '!

5 9

TTCFont >> flushCachedValues
by Tony Garnock-Jones 18 Sep '21

18 Sep '21

Hi all, I'm looking at the image-side DPI-change code, namely TextStyle >> pixelsPerInch:. The broadcast of the change is fine. But the handler in TTCFont is subtly wrong, I think. - I believe instance variables height, ascent, descent have to be nil'd as part of pixelsPerInchChanged. Is that right? Without nil'ing them, my TTCFonts don't resize properly. - This suggests flushCachedValues, which has NO SENDERS (!), should be folded into flushCache. Does that sound right? - Finally, if both the above hold, then pixelsPerInchChanged should be calling flushCache instead of recreateCache. Does that sound right? I'll be running for a few days with these changes in my image, to see if there are any obvious problems with them. But, before I push a commit out to Trunk, if I could get a thumbs-up from someone who knows a bit about the font subsystem, that'd be great! Regards, Tony

3 4

The Trunk: Collections-eem.904.mcz
by commits＠source.squeak.org 18 Sep '21

18 Sep '21

Eliot Miranda uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-eem.904.mcz ==================== Summary ==================== Name: Collections-eem.904 Author: eem Time: 21 July 2020, 12:48:47.966166 pm UUID: 5aa53764-ee46-4fee-b681-0bc142550102 Ancestors: Collections-ul.903 Supercede the slow Float[64]ArrayPlugin>>at:[put:] primitives with much faster ones in the Spur VM. =============== Diff against Collections-ul.903 =============== Item was changed: + (PackageInfo named: 'Collections') preamble: '"Use of the Spur FloatArray>>at:[put:] prims requires at least VMMaker.oscog.2778" - (PackageInfo named: 'Collections') preamble: '"FloatArray is going to become the abstract class above Float32Array and Float64Array. - In order to avoid spurious instance migration or recompilation errors, this preamble is required." + Smalltalk vmVMMakerVersion < 2778 ifTrue: + [Warning signal: ''This virtual machine is too old to support correct versions of the FloatArray>>at:[put:] primitives 238 and 239. FloatArray subclasses will not behave correctly and FloatArray[64]Test tests will fail. Please upgrade your VM. You may continue and upgrade later or abort and upgrade now.'']'! - FloatArray rename: #Float32Array.'! Item was removed: - ----- Method: Float32Array>>at: (in category 'accessing') ----- - at: index - <primitive: 'primitiveAt' module: 'FloatArrayPlugin'> - ^Float fromIEEE32Bit: (self basicAt: index)! Item was removed: - ----- Method: Float32Array>>at:put: (in category 'accessing') ----- - at: index put: value - <primitive: 'primitiveAtPut' module: 'FloatArrayPlugin'> - value isFloat - ifTrue:[self basicAt: index put: value asIEEE32BitWord] - ifFalse:[self at: index put: value asFloat]. - ^value! Item was removed: - ----- Method: Float32Array>>defaultElement (in category 'accessing') ----- - defaultElement - "Return the default element of the receiver" - ^0.0! Item was removed: - ----- Method: Float64Array>>at: (in category 'accessing') ----- - at: index - <primitive: 'primitiveAt' module: 'Float64ArrayPlugin'> - | f64 u64 | - u64 := self basicAt: index. - (f64 := Float basicNew) - basicAt: 1 put: (u64 >> 32); - basicAt: 2 put: (u64 bitAnd: 16rFFFFFFFF). - ^f64 * 1.0! Item was removed: - ----- Method: Float64Array>>at:put: (in category 'accessing') ----- - at: index put: value - <primitive: 'primitiveAtPut' module: 'Float64ArrayPlugin'> - value isFloat - ifTrue:[self basicAt: index put: (value basicAt: 1) << 32 + (value basicAt: 2)] - ifFalse:[self at: index put: value asFloat]. - ^value! Item was added: + ----- Method: FloatArray>>at: (in category 'accessing') ----- + at: index + "Answer the Float at index in the receiver. This method converts from either a 32-bit IEEE representation, + or a 64-bit IEEE representation to a Squeak Float object. Primitive. Optional." + <primitive: 238 error: ec> + ^self bytesPerElement = 4 + ifTrue: [Float fromIEEE32Bit: (self basicAt: index)] + ifFalse: [Float fromIEEE64Bit: (self basicAt: index)]! Item was added: + ----- Method: FloatArray>>at:put: (in category 'accessing') ----- + at: index put: value + "Store the Float value at index in the receiver. This method converts from a Squeak Float object, + or an Integer, into either a 32-bit IEEE representation, or a 64-bit IEEE representation. Primitive. Optional." + <primitive: 239 error: ec> + value isFloat + ifTrue:[self basicAt: index put: (self bytesPerElement = 4 + ifTrue: [value asIEEE32BitWord] + ifFalse: [value asIEEE64BitWord])] + ifFalse: [self at: index put: value asFloat]. + ^value!

3 3

The Trunk: Kernel-mt.1244.mcz
by commits＠source.squeak.org 13 Sep '21

13 Sep '21

Marcel Taeumel uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-mt.1244.mcz ==================== Summary ==================== Name: Kernel-mt.1244 Author: mt Time: 12 July 2019, 9:59:41.866568 am UUID: d585f898-09cc-094b-98ed-a74204c82019 Ancestors: Kernel-mt.1243 Refactoring of #literalsDo: - Step 2 of 3. For more information, see http://forum.world.st/Please-Review-Refactoring-for-literalsDo-etc-tp509975…. =============== Diff against Kernel-mt.1243 =============== Item was removed: - ----- Method: AdditionalMethodState>>hasLiteralSuchThat: (in category 'testing') ----- - hasLiteralSuchThat: aBlock - "Answer true if litBlock returns true for any literal in this array, even if embedded in further array structure. - This method is only intended for private use by CompiledMethod hasLiteralSuchThat:" - 1 to: self basicSize do: [:i | - | propertyOrPragma "<Association|Pragma>" | - propertyOrPragma := self basicAt: i. - (propertyOrPragma isVariableBinding - ifTrue: [(aBlock value: propertyOrPragma key) - or: [(aBlock value: propertyOrPragma value) - or: [propertyOrPragma value isArray - and: [propertyOrPragma value hasLiteralSuchThat: aBlock]]]] - ifFalse: [propertyOrPragma hasLiteralSuchThat: aBlock]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledBlock>>allLiterals (in category 'literals') ----- - allLiterals - ^self homeMethod allLiterals! Item was removed: - ----- Method: CompiledBlock>>allSubLiterals (in category 'literals') ----- - allSubLiterals - | literalsExceptOuter unfoldedSubLiterals | - literalsExceptOuter := self literals allButLast. - unfoldedSubLiterals := literalsExceptOuter - select: [:lit| lit isCompiledCode] - thenCollect: [:blockMethod| blockMethod allSubLiterals]. - unfoldedSubLiterals ifEmpty: - [^literalsExceptOuter]. - ^literalsExceptOuter, (unfoldedSubLiterals fold: [:a :b| a, b])! Item was added: + ----- Method: CompiledBlock>>codeLiteralsDo: (in category 'literals') ----- + codeLiteralsDo: aBlock + "Overwritten to not cause infinite loop." + + aBlock value: self. + + self literalsDo: [:literal | + (literal isCompiledCode and: [literal ~~ self outerCode]) ifTrue: [ + literal codeLiteralsDo: aBlock]].! Item was removed: - ----- Method: CompiledBlock>>hasLiteral: (in category 'literals') ----- - hasLiteral: literal - "Answer whether the receiver references the argument, literal." - 2 to: self numLiterals do: "exclude outerCode" - [:index | | lit | - lit := self objectAt: index. - (lit literalEqual: literal) ifTrue: - [^true]. - (lit isCompiledCode and: [lit hasLiteral: literal]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledBlock>>hasLiteralSuchThat: (in category 'literals') ----- - hasLiteralSuchThat: litBlock - "Answer true if litBlock returns true for any literal in this method, even if embedded in array structure." - 2 to: self numLiterals do: "exclude outerCode" - [:index | | lit | - lit := self objectAt: index. - ((litBlock value: lit) - or: [(lit isArray or: [lit isCompiledCode]) and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: - [^true]]. - ^false! Item was changed: ----- Method: CompiledCode>>allLiterals (in category 'literals') ----- allLiterals + "Skip compiled-code objects. Keep literal arrays, bindings, etc." + + ^ Array streamContents: [:result | + self allLiteralsDo: [:literal | result nextPut: literal]]! - self subclassResponsibility! Item was added: + ----- Method: CompiledCode>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "Enumerate all literals thoroughly. Follow nested instances of CompiledCode. Do not treat compiled code as literals here." + + self codeLiteralsDo: [:compiledCode | compiledCode literalsDo: [:literal | + literal isCompiledCode ifFalse: [literal allLiteralsDo: aBlock] ]]. + + "Enumerate special selectors." + self flag: #todo. + + "Enumerate special literals such as true and false." + self flag: #todo.! Item was added: + ----- Method: CompiledCode>>codeLiterals (in category 'literals') ----- + codeLiterals + + ^ Array streamContents: [:stream | + self codeLiteralsDo: [:compiledCode | stream nextPut: compiledCode]]! Item was added: + ----- Method: CompiledCode>>codeLiteralsDo: (in category 'literals') ----- + codeLiteralsDo: aBlock + "Enumerate all literals that represent instances of CompiledCode. This is especially required for SistaV1." + + aBlock value: self. + + self literalsDo: [:literal | literal isCompiledCode ifTrue: [ + literal codeLiteralsDo: aBlock]].! Item was added: + ----- Method: CompiledCode>>hasLiteral: (in category 'literals') ----- + hasLiteral: aLiteral + "Since we cannot enumerate this code's special literals, we have to overwrite this method to invoke the encoder scanner explicitely." + + | scanBlock | + (super hasLiteral: aLiteral) ifTrue: [^ true]. + + scanBlock := self class + scanBlocksForLiteral: aLiteral + do: [:primaryScanner :secondaryScanner | + "E.g., scanner for SistaV1 or scanner for V3PlusClosures" + self signFlag ifTrue: [secondaryScanner] ifFalse: [primaryScanner]]. + + self codeLiteralsDo: [:compiledCode | + (compiledCode scanFor: scanBlock) ifTrue: [^ true]]. + + ^ false! Item was added: + ----- Method: CompiledCode>>hasMethodReturn (in category 'testing') ----- + hasMethodReturn + "Answer whether the receiver has a method-return ('^') in its code." + + | scanner | + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: [:x | (scanner willReturn + and: [scanner willBlockReturn not]) + "and: [scanner willReturnTopFromMethod not]" "-> Not supported in EncoderForSistaV1"]) + ifTrue: [^ true]]. + ^ false! Item was added: + ----- Method: CompiledCode>>isQuick (in category 'testing') ----- + isQuick + + self subclassResponsibility.! Item was changed: ----- Method: CompiledCode>>literals (in category 'literals') ----- literals + + ^ Array streamContents: [:result | + self literalsDo: [:lit | result nextPut: lit]]! - "Answer an Array of the literals referenced by the receiver." - | literals numberLiterals | - literals := Array new: (numberLiterals := self numLiterals). - 1 to: numberLiterals do: - [:index | - literals at: index put: (self objectAt: index + 1)]. - ^literals! Item was added: + ----- Method: CompiledCode>>literalsDo: (in category 'literals') ----- + literalsDo: aBlock + "Evaluate aBlock for each of the literals referenced by the receiver. Note that this (raw) enumeration addresses *all* objects stored *after* the method header and *before* the first byte code. If you require a deep and meaningful enumeration of literals use #allLiteralsDo: or #codeLiteralsDo:." + + 1 to: self numLiterals do: [:index | + aBlock value: (self literalAt: index)].! Item was changed: ----- Method: CompiledCode>>messages (in category 'scanning') ----- messages "Answer a Set of all the message selectors sent by this method." + | result | + result := Set new. + self messagesDo: [:selector | result add: selector]. + ^ result! - | encoderClass scanner aSet | - encoderClass := self encoderClass. - aSet := Set new. - scanner := InstructionStream on: self. - scanner scanFor: [ :x | - | selector | - (selector := encoderClass selectorToSendOrItselfFor: scanner in: self at: scanner pc) == scanner - ifFalse: - [aSet add: selector] - ifTrue: - [(encoderClass blockMethodOrNilFor: scanner in: self at: scanner pc) ifNotNil: - [:blockMethod| aSet addAll: blockMethod messages]]. - false "keep scanning" ]. - ^aSet! Item was added: + ----- Method: CompiledCode>>messagesDo: (in category 'scanning') ----- + messagesDo: workBlock + "Evaluate aBlock with all the message selectors sent by me. Duplicate sends possible." + + | scanner selector | + self isQuick ifTrue: [^ self]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + scanner scanFor: [ :x | + (selector := scanner selectorToSendOrSelf) == scanner + ifFalse: [workBlock value: selector]. + false "keep scanning" ] ].! Item was removed: - ----- Method: CompiledCode>>messagesDo:encoderClass:visitedSet: (in category 'private') ----- - messagesDo: aBlock encoderClass: encoderClass visitedSet: visitedSet - "The inner engine for messagesDo:" - - | scanner | - scanner := InstructionStream on: self. - scanner scanFor: [ :x | - | selector | - (selector := encoderClass selectorToSendOrItselfFor: scanner in: self at: scanner pc) == scanner - ifFalse: - [(visitedSet ifAbsentAdd: selector) ifTrue: - [aBlock value: selector]] - ifTrue: - [(encoderClass blockMethodOrNilFor: scanner in: self at: scanner pc) ifNotNil: - [:blockMethod| - blockMethod messagesDo: aBlock encoderClass: encoderClass visitedSet: visitedSet]]. - false "keep scanning" ]! Item was removed: - ----- Method: CompiledCode>>refersTo:bytecodeScanner:thorough: (in category 'literals') ----- - refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough - "Answer if the receiver refers to the literal. If the scan block is non-nil, then - use it to find the literal in bytecode. If thorough is true, dive down into - literal arrays and method properties to locate references to the literal there-in." - 2 to: (self isCompiledBlock - ifTrue: [self numLiterals] "exclude outerCode or methodClass" - ifFalse: [self numLiterals - 1]) "exclude selector/properties and methodClass" - do: [:i| | lit | - lit := self objectAt: i. - (literal == lit or: [literal literalEqual: lit]) ifTrue: [^true]. "== for Float bindingOf: #NaN since NaN ~= NaN" - lit isCompiledCode - ifTrue: - [(lit refersTo: literal bytecodeScanner: scanBlockOrNil thorough: thorough) ifTrue: - [^true]] - ifFalse: - [thorough ifTrue: - [lit isVariableBinding - ifTrue: - [literal == lit key ifTrue: [^true]] - ifFalse: - [(lit isArray - and: [(lit hasLiteral: literal) - or: [literal isVariableBinding - and: [literal key isSymbol - and: [lit hasLiteral: literal key]]]]) ifTrue: - [^true]]]]]. - scanBlockOrNil ifNotNil: - [(self scanFor: scanBlockOrNil) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledCode>>refersTo:primaryBytecodeScanner:secondaryBytecodeScanner:thorough: (in category 'literals') ----- - refersTo: literal primaryBytecodeScanner: primaryScanBlockOrNil secondaryBytecodeScanner: secondaryScanBlockOrNil thorough: thorough - "Answer if the receiver refers to the literal. If the scan blocks are non-nil, then - use them to find the literal in bytecode. If thorough is true, dive down into - literal arrays and method properties to locate references to the literal there-in." - ^self - refersTo: literal - bytecodeScanner: (self signFlag - ifTrue: [secondaryScanBlockOrNil] - ifFalse: [primaryScanBlockOrNil]) - thorough: thorough! Item was changed: ----- Method: CompiledCode>>scanFor: (in category 'scanning') ----- scanFor: byteOrClosure "Answer whether the receiver contains the argument as a bytecode, if it is a number, or evaluates to true if a block. If a block it can take from one to four bytes." | s end | ^(s := InstructionStream on: self) scanFor: (byteOrClosure isBlock ifTrue: [byteOrClosure numArgs caseOf: { [1] -> [byteOrClosure]. [2] -> [[:byte| byteOrClosure value: byte value: s secondByte]]. [3] -> [end := self endPC - 2. [:byte| s pc <= end and: [byteOrClosure value: byte value: s secondByte value: s thirdByte]]]. [4] -> [end := self endPC - 3. [:byte| s pc <= end and: [byteOrClosure value: byte value: s secondByte value: s thirdByte value: s fourthByte]]] }] ifFalse: [[:instr | instr = byteOrClosure]]) " + SystemNavigation default browseAllSelect: [:m | m scanFor: 134] - Smalltalk browseAllSelect: [:m | m scanFor: 134] "! Item was added: + ----- Method: CompiledCode>>sendsMessage: (in category 'testing') ----- + sendsMessage: aSelector + + self messagesDo: [:selector | + selector = aSelector ifTrue: [^ true]]. + ^ false! Item was added: + ----- Method: CompiledCode>>sendsSelector: (in category 'testing') ----- + sendsSelector: aSelector + + self flag: #todo. "mt: Deprecate? AST/Refactoring project needs it..." + ^ self sendsMessage: aSelector! Item was added: + ----- Method: CompiledCode>>sendsToSuper (in category 'testing') ----- + sendsToSuper + "Answer whether the receiver sends any message to super." + + | scanner | + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass superSendScanBlockUsing: scanner)) + ifTrue: [^ true]]. + ^ false! Item was removed: - ----- Method: CompiledMethod>>allLiterals (in category 'literals') ----- - allLiterals - | literals unfoldedSubLiterals | - literals := self literals. - unfoldedSubLiterals := literals - select: [:lit| lit isCompiledCode] - thenCollect: [:blockMethod| blockMethod allSubLiterals]. - unfoldedSubLiterals ifEmpty: - [^literals]. - ^literals, (unfoldedSubLiterals fold: [:a :b| a, b])! Item was added: + ----- Method: CompiledMethod>>allLiteralsDo: (in category 'literals') ----- + allLiteralsDo: aBlock + "Overwritten to skip certain (raw) literals." + + " Exclude method selector (or properties) and the method's class." + 1 to: self numLiterals - 2 do: [:index | + (self literalAt: index) allLiteralsDo: aBlock]. + + "Enumerate method selector only through additional method state." + self penultimateLiteral isMethodProperties + ifTrue: [self penultimateLiteral allLiteralsDo: aBlock]. + + "Enumerate special selectors." + self flag: #todo. + + "Enumerate special literals such as true and false." + self flag: #todo.! Item was removed: - ----- Method: CompiledMethod>>hasLiteral: (in category 'literals') ----- - hasLiteral: literal - "Answer whether the receiver references the argument, literal." - 2 to: self numLiterals - 1 do: "exclude selector/properties & methodClass" - [:index | | lit | - lit := self objectAt: index. - (lit literalEqual: literal) ifTrue: - [^true]. - (lit isCompiledCode and: [lit hasLiteral: literal]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledMethod>>hasLiteralSuchThat: (in category 'literals') ----- - hasLiteralSuchThat: litBlock - "Answer true if litBlock returns true for any literal in this method, even if embedded in array structure." - (self penultimateLiteral isMethodProperties - and: [self penultimateLiteral hasLiteralSuchThat: litBlock]) ifTrue: - [^true]. - 2 to: self numLiterals + 1 do: - [:index | | lit | - lit := self objectAt: index. - ((litBlock value: lit) - or: [(lit isArray or: [lit isCompiledCode]) and: [lit hasLiteralSuchThat: litBlock]]) ifTrue: - [^true]]. - ^false! Item was removed: - ----- Method: CompiledMethod>>hasLiteralThorough: (in category 'literals') ----- - hasLiteralThorough: literal - "Answer true if any literal in this method is literal, - even if embedded in array structure." - - (self penultimateLiteral isMethodProperties - and: [self penultimateLiteral hasLiteralThorough: literal]) ifTrue:[^true]. - 2 to: self numLiterals - 1 "exclude superclass + selector/properties" - do:[:index | | lit | - (((lit := self objectAt: index) literalEqual: literal) - or: [(lit isVariableBinding and: [lit key == literal]) - or: [lit isArray and: [lit hasLiteral: literal]]]) ifTrue: - [^ true]]. - ^ false ! Item was removed: - ----- Method: CompiledMethod>>literalsDo: (in category 'literals') ----- - literalsDo: aBlock - "Evaluate aBlock for each of the literals referenced by the receiver." - 1 to: self numLiterals do: - [:index | - aBlock value: (self objectAt: index + 1)]! Item was removed: - ----- Method: CompiledMethod>>messages (in category 'scanning') ----- - messages - "Answer a Set of all the message selectors sent by this method." - - | scanner aSet | - aSet := Set new. - scanner := InstructionStream on: self. - scanner scanFor: [ :x | - | selector | - (selector := scanner selectorToSendOrSelf) == scanner ifFalse: [ - aSet add: selector ]. - false "keep scanning" ]. - ^aSet! Item was removed: - ----- Method: CompiledMethod>>messagesDo: (in category 'scanning') ----- - messagesDo: aBlock - "Evaluate aBlock exactly once with all the message selectors sent by me." - - self isQuick ifFalse: - [self messagesDo: aBlock - encoderClass: self encoderClass - visitedSet: IdentitySet new]! Item was changed: ----- Method: CompiledMethod>>messagesSequence (in category 'scanning') ----- messagesSequence - "Answer a Set of all the message selectors sent by this method." + self flag: #todo. "mt: Better change #messages to return an array instead of a set?" + ^ self messages asArray! - ^Array streamContents: - [:str| | scanner | - scanner := InstructionStream on: self. - scanner scanFor: - [:x | | selectorOrSelf | - (selectorOrSelf := scanner selectorToSendOrSelf) == scanner ifFalse: - [str nextPut: selectorOrSelf]. - false "keep scanning"]]! Item was changed: ----- Method: CompiledMethod>>objectForDataStream: (in category 'file in/out') ----- objectForDataStream: refStrm + "Reconfigure pragma. Example: #(#FFTPlugin #primitiveFFTTransformData 0 0). See FFT >> #pluginTransformData:." + + self primitive = 117 ifTrue: [(self literalAt: 1) at: 4 put: 0].! - - self primitive = 117 ifTrue: [self literals first at: 4 put: 0]. - ! Item was changed: ----- Method: CompiledMethod>>readsField: (in category 'scanning') ----- readsField: varIndex + "Answer whether the receiver loads the instance variable indexed by the argument." + - "Answer whether the receiver loads the instance variable indexed by the argument." | varIndexCode scanner | varIndexCode := varIndex - 1. + self isQuick ifTrue: [^ self isReturnField and: [self returnField = varIndexCode]]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass instVarReadScanBlockFor: varIndexCode using: scanner)) + ifTrue: [^ true]]. + + ^ false! - self isQuick ifTrue: - [^self isReturnField and: [self returnField = varIndexCode]]. - scanner := InstructionStream on: self. - ^scanner scanFor:(self encoderClass instVarReadScanBlockFor: varIndexCode using: scanner)! Item was changed: ----- Method: CompiledMethod>>readsRef: (in category 'scanning') ----- readsRef: variableBinding "Answer whether the receiver reads the value of the argument." "eem 5/24/2008 Rewritten to no longer assume the compler uses the most compact encoding available (for EncoderForLongFormV3 support)." + | litIndex scanner | + (litIndex := self indexOfLiteral: variableBinding) = 0 + ifTrue: [^false]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass bindingReadScanBlockFor: litIndex - 1 using: scanner)) + ifTrue: [^ true]]. + + ^ false! - (litIndex := self indexOfLiteral: variableBinding) = 0 ifTrue: - [^false]. - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass bindingReadScanBlockFor: litIndex - 1 using: scanner)! Item was removed: - ----- Method: CompiledMethod>>refersToLiteral: (in category 'literals') ----- - refersToLiteral:aLiteral - - ^self hasLiteral: aLiteral.! Item was removed: - ----- Method: CompiledMethod>>sendsSelector: (in category 'literals') ----- - sendsSelector: aSelector - | scanner | - scanner := InstructionStream on: self. - scanner scanFor: - [:x | - scanner selectorToSendOrSelf == aSelector ifTrue: - [^true]. - false "keep scanning"]. - ^false! Item was removed: - ----- Method: CompiledMethod>>sendsToSuper (in category 'scanning') ----- - sendsToSuper - "Answer whether the receiver sends any message to super." - | scanner | - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass superSendScanBlockUsing: scanner)! Item was changed: ----- Method: CompiledMethod>>writesField: (in category 'scanning') ----- writesField: varIndex + "Answer whether the receiver stores into the instance variable indexed by the argument." - "Answer whether the receiver stores into the instance variable indexed - by the argument." + | varIndexCode scanner | + self isQuick ifTrue: [^ false]. + varIndexCode := varIndex - 1. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass instVarWriteScanBlockFor: varIndex - 1 using: scanner)) + ifTrue: [^ true]]. + + ^ false! - | scanner | - self isQuick ifTrue: [^false]. - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass instVarWriteScanBlockFor: varIndex - 1 using: scanner)! Item was changed: ----- Method: CompiledMethod>>writesRef: (in category 'scanning') ----- writesRef: variableBinding "Answer whether the receiver writes the value of the argument." "eem 5/24/2008 Rewritten to no longer assume the compler uses the most compact encoding available (for EncoderForLongFormV3 support)." + | litIndex scanner | + (litIndex := self indexOfLiteral: variableBinding) = 0 + ifTrue: [^ false]. + + self codeLiteralsDo: [:compiledCode | + scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass bindingWriteScanBlockFor: litIndex - 1 using: scanner)) + ifTrue: [^ true]]. + + ^ false! - (litIndex := self indexOfLiteral: variableBinding) = 0 ifTrue: - [^false]. - scanner := InstructionStream on: self. - ^scanner scanFor: (self encoderClass bindingWriteScanBlockFor: litIndex - 1 using: scanner)! Item was removed: - ----- Method: Pragma>>hasLiteralSuchThat: (in category 'testing') ----- - hasLiteralSuchThat: aBlock - "Answer true if litBlock returns true for any literal in the receiver, even if embedded in further array structure. - This method is only intended for private use by CompiledMethod hasLiteralSuchThat:" - ^(aBlock value: keyword) - or: [arguments hasLiteralSuchThat: aBlock]!

2 1

Image damaged due to IO error while saving
by Thiede, Christoph 04 Sep '21

04 Sep '21

Hi all, some months ago, I corrupted my image by accidentally shutting down the host system while saving the image file (many of my images are > 500 MB, so this can take a few seconds even on an SSD). The same can happen due to various other IO/connection issues, so here's an idea: Couldn't we always use overwrite-by-rename when saving the image file? I. e., first the image into a new temporary file and, after saving has completed, replace the original file with that temp file (via mv)? This would ensure the image file's integrity. A possible disadvantage, though, would be that some filesystems, such as NTFS, associate meta-information with the file identity, which changes when using the overwrite-by-rename approach. Also, technologies such as FileSystemWatcher would be confused for the same reason. However, afaik overwrite-by-rename is a quite common approach, in primary for big and sensitive files. However, what are your opinions about this topic? :-) Best, Christoph

6 21

Bug in primitiveUtcWithOffset on Windows
by Thiede, Christoph 30 Aug '21

30 Aug '21

Hi all, recently, the battery of my laptop has broken (will never buy an HP device again, rude support ...), so currently, I'm only using my device only with a direct power supply. When I unplug it while it is shut down/in hibernation mode, the system time will be reset. Windows knows how to deal with it and only seconds after rebooting, it will fetch the current time from a time server again. However, Squeak/OSVM have problems with this. In the last two weeks, I have noticed multiple cases where the image clock in the docking bar would not be updated after resuming from hibernation mode but continue to count from the previous evening's time. More precisely, primitiveUtcWithOffset always returns a time that is behind by the duration for which my device was shut down at the night. After restarting the VM, the time is synced again. I'm on Windows 20H1. Maybe some chronological expert here has an idea of how the VM could be tweaked in order to reflect the time changes applied by Windows time synchronization? :-) Best, Christoph

3 2

← Newer
1
...
6
7
8
9
10
11
12
...
18
Older →

Jump to page: