Squeak-dev September 2021

squeak-dev@lists.squeakfoundation.org

23 participants
205 discussions

Image damaged due to IO error while saving
by Thiede, Christoph 04 Sep '21

04 Sep '21

Hi all, some months ago, I corrupted my image by accidentally shutting down the host system while saving the image file (many of my images are > 500 MB, so this can take a few seconds even on an SSD). The same can happen due to various other IO/connection issues, so here's an idea: Couldn't we always use overwrite-by-rename when saving the image file? I. e., first the image into a new temporary file and, after saving has completed, replace the original file with that temp file (via mv)? This would ensure the image file's integrity. A possible disadvantage, though, would be that some filesystems, such as NTFS, associate meta-information with the file identity, which changes when using the overwrite-by-rename approach. Also, technologies such as FileSystemWatcher would be confused for the same reason. However, afaik overwrite-by-rename is a quite common approach, in primary for big and sensitive files. However, what are your opinions about this topic? :-) Best, Christoph

6 21

The Inbox: 60Deprecated-ul.96.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of 60Deprecated to project The Inbox: http://source.squeak.org/inbox/60Deprecated-ul.96.mcz ==================== Summary ==================== Name: 60Deprecated-ul.96 Author: ul Time: 3 September 2021, 4:16:18.381279 pm UUID: 73ae59f8-2544-4a04-b04f-ef3ffb085f8c Ancestors: 60Deprecated-nice.95 - deprecate ifNotNilDo:, #ifNil:ifNotNilDo: and #ifNotNilDo:ifNil: =============== Diff against 60Deprecated-nice.95 =============== Item was added: + ----- Method: Object>>ifNil:ifNotNilDo: (in category '*60Deprecated-accessing') ----- + ifNil: nilBlock ifNotNilDo: aBlock + + self flag: #deprecated. "#ifNil:ifNotNil: does the job" + ^self ifNil: nilBlock ifNotNil: aBlock! Item was added: + ----- Method: Object>>ifNotNilDo: (in category '*60Deprecated-accessing') ----- + ifNotNilDo: aBlock + + self flag: #deprecated. "#ifNotNil: does the job" + ^self ifNotNil: aBlock + ! Item was added: + ----- Method: Object>>ifNotNilDo:ifNil: (in category '*60Deprecated-accessing') ----- + ifNotNilDo: aBlock ifNil: nilBlock + + self flag: #deprecated. "#ifNotNil:ifNil: does the job" + ^self ifNotNil: aBlock ifNil: nilBlock + !

1 0

The Inbox: Kernel-ul.1409.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-ul.1409.mcz ==================== Summary ==================== Name: Kernel-ul.1409 Author: ul Time: 3 September 2021, 4:15:37.925846 pm UUID: 44b68d6f-f84b-4319-bfe0-8db351b7f018 Ancestors: Kernel-eem.1408 - deprecate ifNotNilDo:, #ifNil:ifNotNilDo: and #ifNotNilDo:ifNil: =============== Diff against Kernel-eem.1408 =============== Item was removed: - ----- Method: Object>>ifNil:ifNotNilDo: (in category 'accessing') ----- - ifNil: nilBlock ifNotNilDo: aBlock - "Evaluate aBlock with the receiver as its argument." - - ^ aBlock value: self - ! Item was removed: - ----- Method: Object>>ifNotNilDo: (in category 'accessing') ----- - ifNotNilDo: aBlock - "Evaluate the given block with the receiver as its argument." - - ^ aBlock value: self - ! Item was removed: - ----- Method: Object>>ifNotNilDo:ifNil: (in category 'accessing') ----- - ifNotNilDo: aBlock ifNil: nilBlock - "Evaluate aBlock with the receiver as its argument." - - ^ aBlock value: self - ! Item was removed: - ----- Method: UndefinedObject>>ifNil:ifNotNilDo: (in category 'testing') ----- - ifNil: nilBlock ifNotNilDo: ifNotNilBlock - "Evaluate the block for nil because I'm == nil" - - ^ nilBlock value! Item was removed: - ----- Method: UndefinedObject>>ifNotNilDo: (in category 'testing') ----- - ifNotNilDo: aBlock - "Override to do nothing." - - ^ self - ! Item was removed: - ----- Method: UndefinedObject>>ifNotNilDo:ifNil: (in category 'testing') ----- - ifNotNilDo: ifNotNilBlock ifNil: nilBlock - "If I got here, I am nil, so evaluate the block nilBlock" - - ^ nilBlock value!

1 0

The Inbox: KernelTests-ul.405.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of KernelTests to project The Inbox: http://source.squeak.org/inbox/KernelTests-ul.405.mcz ==================== Summary ==================== Name: KernelTests-ul.405 Author: ul Time: 3 September 2021, 4:09:29.590259 pm UUID: 48026890-9fb9-41cc-9ece-0d951fbc77e9 Ancestors: KernelTests-nice.404 - deprecate ifNotNilDo:, #ifNil:ifNotNilDo: and #ifNotNilDo:ifNil: =============== Diff against KernelTests-nice.404 =============== Item was added: + ----- Method: ObjectTest>>testIfNotNilDoDeprecation (in category 'tests') ----- + testIfNotNilDoDeprecation + + #(ifNotNilDo: #ifNil:ifNotNilDo: #ifNotNilDo:ifNil:) do: [ :selector | + | senders | + senders := self systemNavigation allCallsOn: selector. + self + assert: senders size = 1 + description: (String streamContents: [ :stream | + | thisSelector | + stream + nextPutAll: 'Unexpected senders of '; + print: selector; + nextPutAll: ': '. + thisSelector := thisContext method selector. + (senders reject: [ :each | + (each actualClass == self class + and: [ each selector == thisSelector ]) ]) + do: [ :each | + stream + nextPutAll: each actualClass name; + nextPutAll: ' >> '; + print: each selector ] + separatedBy: [ stream nextPut: ', ' ] ]) ]!

1 0

The Trunk: Monticello-ul.752.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ul.752.mcz ==================== Summary ==================== Name: Monticello-ul.752 Author: ul Time: 3 September 2021, 3:51:34.80549 pm UUID: 7e736996-9073-4456-9408-d6efd270abb1 Ancestors: Monticello-mt.751 - ifNotNilDo: -> ifNotNil: =============== Diff against Monticello-mt.751 =============== Item was changed: ----- Method: MCCodeTool>>copyReference (in category 'menus') ----- copyReference "Copy the selected selector to the clipboard" self selectedMessageName ifNotNil: [ : selector | Clipboard clipboardText: (self selectedClassOrMetaClass ifNil: [ selector asString ] + ifNotNil: [ : cls | (cls >> selector) reference ]) ]! - ifNotNilDo: [ : cls | (cls >> selector) reference ]) ]! Item was changed: ----- Method: MCOperationsBrowser>>browseSelectionOrigin (in category 'actions') ----- browseSelectionOrigin | mcDefinition | selection ifNil: [ UIManager inform: 'Make a selection.' ]. mcDefinition := selection definition. Cursor wait showWhile: [ mcDefinition mcModel ifNotNil: [ : mcModel | (mcModel originOf: mcDefinition) ifNil: [ UIManager inform: mcDefinition asString , ' was not found in any historical MC repository.' ] + ifNotNil: - ifNotNilDo: [ : version | version open ] ] ]! Item was changed: ----- Method: MCRepository>>copyImageVersions (in category 'versions') ----- copyImageVersions "For each package contained in the receiver, copy the version of that package which is currently loaded in this image. If no version of a package is loaded in the image, nothing is copied for that package." self cacheAllFileNamesDuring: [ self allPackageNames do: [ : eachPkgName | MCWorkingCopy allManagers detect: [ : each | each packageName = eachPkgName ] ifFound: [ : loaded | loaded ancestors do: [ : infoToCopy | (self includesVersionNamed: infoToCopy versionName) ifFalse: [ (MCRepositoryGroup default versionWithInfo: infoToCopy) ifNil: [ Warning signal: infoToCopy name , ' not found in RepositoryGroup default.' ] + ifNotNil: - ifNotNilDo: [ : ver | self storeVersion: ver ] ] ] ] ifNone: [ "Image specifies no version to copy." ] ] ]!

1 0

The Trunk: Morphic-ul.1780.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ul.1780.mcz ==================== Summary ==================== Name: Morphic-ul.1780 Author: ul Time: 3 September 2021, 3:51:14.375371 pm UUID: 752b8545-23b0-4e10-9c95-997cadb88d2a Ancestors: Morphic-mt.1779 - ifNotNilDo: -> ifNotNil: =============== Diff against Morphic-mt.1779 =============== Item was changed: ----- Method: SketchMorph>>erasePixelsUsing: (in category 'menu') ----- erasePixelsUsing: evt "Let the user specifiy a color such that all pixels of that color should be erased; then do the erasure" self changeColorTarget: self selector: #rememberedColor: originalColor: nil hand: evt hand. self rememberedColor "color to erase" ifNil: [ ^ self ] + ifNotNil: - ifNotNilDo: [ : chosenColor | self erasePixelsOfColor: chosenColor ]! Item was changed: ----- Method: SmalltalkEditor>>methodArgument: (in category 'private') ----- methodArgument: anInteger ^ (ReadStream on: self text asString) nextLine ifNil: [ String empty ] + ifNotNil: - ifNotNilDo: [ : line | line substrings at: 2 * anInteger ifAbsent: [ String empty ] ]! Item was changed: ----- Method: TextEditor>>prettyPrint: (in category 'menu messages') ----- prettyPrint: decorated "Reformat the contents of the receiver's view (a Browser or Workspace)." model selectedClassOrMetaClass ifNil: [ "arbitrary text selection in a workspace, not directly associated with a class" (Compiler new formatNoPattern: self selection environment: model environment) + ifNotNil: [:newText | self replaceSelectionWith: newText]] - ifNotNilDo: [:newText | self replaceSelectionWith: newText]] ifNotNil: [:selectedClass | "source for a method in the selected class" (selectedClass newCompiler format: self text in: selectedClass notifying: self decorated: decorated) + ifNotNil: [ :newText | - ifNotNilDo: [ :newText | self selectInvisiblyFrom: 1 to: paragraph text size. self replaceSelectionWith: (selectedClass ifNil: [newText] ifNotNil: [newText asText makeSelectorBoldIn: selectedClass]). self selectAt: self text size + 1 ]]. !

1 0

The Trunk: MorphicExtras-ul.298.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-ul.298.mcz ==================== Summary ==================== Name: MorphicExtras-ul.298 Author: ul Time: 3 September 2021, 3:50:07.605798 pm UUID: a5ca0c21-1176-4adc-a317-72a33a2ae11a Ancestors: MorphicExtras-mt.297 - ifNotNilDo: -> ifNotNil: =============== Diff against MorphicExtras-mt.297 =============== Item was changed: ----- Method: PostscriptCanvas>>image:at:sourceRect:rule: (in category 'private') ----- image: form at: aPoint sourceRect: sourceRect rule: rule | aForm | self preserveStateDuring: [:inner | inner translate: aPoint + self origin. aForm := form depth <= 8 ifTrue: [form asFormOfDepth: 32] ifFalse: [form]. target write: ((aForm colorsUsed includes: Color transparent) ifTrue: [| top f2 c2 offset | "tfel: This was taken from SketchMorph, but is actually needed for all forms that use transparency" + offset := currentTransformation ifNil: [0@0] ifNotNil: [:t | t offset]. - offset := currentTransformation ifNil: [0@0] ifNotNilDo: [:t | t offset]. top := self topLevelMorph. f2 := Form extent: aForm extent depth: self depth. c2 := f2 getCanvas. c2 fillColor: Color white. c2 translateBy: offset - self origin - aPoint clippingTo: f2 boundingBox during: [:c | top fullDrawOn: c]. f2] ifFalse: [aForm])]. !

1 0

The Trunk: Network-ul.248.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of Network to project The Trunk: http://source.squeak.org/trunk/Network-ul.248.mcz ==================== Summary ==================== Name: Network-ul.248 Author: ul Time: 3 September 2021, 3:49:34.525299 pm UUID: 8df9c093-0687-4271-b36e-829e38b2578c Ancestors: Network-mt.247 - ifNotNilDo: -> ifNotNil: =============== Diff against Network-mt.247 =============== Item was changed: ----- Method: MailMessage>>attachments (in category 'multipart') ----- attachments ^ self body parts select: [:p | (p fieldNamed: 'content-disposition' ifAbsent: [nil]) ifNil: [false] + ifNotNil: [:headerValue | headerValue mainValue = 'attachment' ]]! - ifNotNilDo: [:headerValue | headerValue mainValue = 'attachment' ]]!

1 0

The Trunk: Tools-ul.1063.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-ul.1063.mcz ==================== Summary ==================== Name: Tools-ul.1063 Author: ul Time: 3 September 2021, 3:48:00.381705 pm UUID: 63fed3fb-636f-450b-8b1f-4853a9e540fb Ancestors: Tools-cmm.1062 - doWithIndex: -> withIndexDo: - ifNotNilDo: -> ifNotNil: =============== Diff against Tools-cmm.1062 =============== Item was changed: ----- Method: DebuggerMethodMap>>tempsAndValuesForContext:contractTo: (in category 'accessing') ----- tempsAndValuesForContext: aContext contractTo: width "Return a string of the temporary variabls and their current values" | aStream tempStream | aStream := WriteStream on: (String new: 100). tempStream := WriteStream on: (String new: width). + (self tempNamesForContext: aContext) withIndexDo: - (self tempNamesForContext: aContext) doWithIndex: [:title :index | aStream nextPutAll: title; nextPut: $:; space; tab. tempStream reset. aContext print: (self namedTempAt: index in: aContext) on: tempStream. aStream nextPutAll: (tempStream contents contractTo: width). aStream cr]. ^aStream contents! Item was changed: ----- Method: StringHolder>>copyReference (in category '*Tools') ----- copyReference "Copy the selected selector to the clipboard" self selectedMessageName ifNotNil: [ : selector | Clipboard clipboardText: (self selectedClassOrMetaClass ifNil: [ selector asString ] + ifNotNil: [ : cls | (cls >> selector) reference ]) ]! - ifNotNilDo: [ : cls | (cls >> selector) reference ]) ]!

1 0

The Trunk: ToolsTests-ul.105.mcz
by commits＠source.squeak.org 03 Sep '21

03 Sep '21

Levente Uzonyi uploaded a new version of ToolsTests to project The Trunk: http://source.squeak.org/trunk/ToolsTests-ul.105.mcz ==================== Summary ==================== Name: ToolsTests-ul.105 Author: ul Time: 3 September 2021, 3:49:05.820326 pm UUID: 729f5806-257f-4ead-b0dd-e8f23239e39c Ancestors: ToolsTests-nice.104 - make sure that SetInspectorTest doesn't leave invalid Sets in the image to avoid HashedCollectionTest fail because of those =============== Diff against ToolsTests-nice.104 =============== Item was added: + ----- Method: InspectorTest>>tearDown (in category 'running') ----- + tearDown + + inspector object: nil. "Make sure we don't leave anything invalid in there, as that can break other tests." + inspector := nil. "Better get rid of that as well." + super tearDown!

1 0

Jump to page: