Squeak-dev January 2022

squeak-dev@lists.squeakfoundation.org

33 participants
361 discussions

Policy for new test packages vs the Tests package
by christoph.thiede＠student.hpi.uni-potsdam.de 03 Jan '22

03 Jan '22

Hi all! I stumbled upon a small test suite on the class side of ZipWriteStream which does not use SUnit and thus does not appear in the TestRunner or in our CI. (It was even broken, but I am fixing it right now.) I would like to integrate these tests with SUnit, but there is no CompressionTests package at the moment. What would be the right place to move these tests to? 1. Create a new CompressionTests package? 2. Create a new category 'Tests-Compression' in the Tests package? Best, Christoph --- Sent from Squeak Inbox Talk

1 0

The Inbox: Kernel-jar.1442.mcz
by commits＠source.squeak.org 03 Jan '22

03 Jan '22

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-jar.1442.mcz ==================== Summary ==================== Name: Kernel-jar.1442 Author: jar Time: 3 January 2022, 6:13:10.111222 pm UUID: 94b84422-d9f6-df4e-a55b-8baf646eafc2 Ancestors: Kernel-mt.1441 new terminate integrating revised resume's semantics; including simplified #releaseCriticalSection and updated comments. please review supersedes Kernel-jar.1437 =============== Diff against Kernel-mt.1441 =============== Item was added: + ----- Method: Context>>releaseCriticalSection (in category 'private') ----- + releaseCriticalSection + "Figure out if we are terminating a process that is in the ensure: block of a critical section. + In this case, if it hasn't made progress but is beyond the wait then the ensure: block needs to be run. + Cf. Process >> releaseCriticalSection: for pre-2022 VMs." + + | selectorJustSent | + (self method pragmaAt: #criticalSection) ifNil: [^self]. + selectorJustSent := self selectorJustSentOrSelf. + + "If still at the wait the ensure: block has not been activated, so signal to restore." + selectorJustSent == #wait ifTrue: + [self receiver signal]. + + "If still at the lock primitive and the lock primitive just acquired ownership (indicated by it answering false) + then the ensure block has not been activated, so explicitly primitiveExitCriticalSection to unlock." + (selectorJustSent == #primitiveEnterCriticalSection + or: [selectorJustSent == #primitiveTestAndSetOwnershipOfCriticalSection]) ifTrue: + [(self stackPtr > 0 + and: [self top == false]) ifTrue: + [self receiver primitiveExitCriticalSection]] + ! Item was added: + ----- Method: Context>>runUnwindTo:onBehalfOf: (in category 'private') ----- + runUnwindTo: aContext onBehalfOf: aProcess + "Run self on behalf of aProcess on aProcess's (i.e. self's) stack until aContext returns. Avoid a context that cannot return. Note: self must be a stack top context. Note: to avoid infinite recursion of MNU error: e.g. a wrapper around the message sentTo: receiver in #doesNotUnderstand: must be implemented. Note: This method is meant to be used exclusively by Process>>#terminate." + + Processor activeProcess + evaluate: [ + | here unwindBottom newTop | + here := thisContext. + "Avoid a context that cannot return (see Note 1 below)" + unwindBottom := (self findContextSuchThat: [:ctx | ctx selector = #cannotReturn:]) ifNil: [aContext]. + newTop := aContext sender. + "Insert ensure context under unwindBottom in self's stack (see Note 2 below)" + unwindBottom insertSender: (Context contextEnsure: [here jump]). + self jump. "Control jumps to self (see Note 2 below)" + "Control resumes here once the above inserted ensure block is executed" + ^newTop ] "Return the new top context (see Note 3 below)" + onBehalfOf: aProcess + + "Note 1: returning from #cannotReturn's sender would crash the VM so we install a guard ensure context right above it and after returning to #terminate the unwind will continue safely. Try running and debugging this example (avoid Proceeding the BCR error though; it would indeed crash the image): + [[[] ensure: [^2]] ensure: [^42]] fork" + "Note 2: self is run by jumping directly to it (the active process abandons thisContext and executes self on aProcess's stack; self is its top context). However, before jumping to self we insert an ensure block under unwindBottom context that jumps back to thisContext when evaluated. The inserted guard ensure context is removed once control jumps back to thisContext." + "Note 3: it doesn't matter newTop is not a proper stack top context because #terminate will use it only as a starting point in the search for the next unwind context and the computation will never return here. Cf. the pattern in #runUntilErrorOrReturnFrom:: removing the inserted ensure context by stepping until popped when executing non-local returns is not applicable here and would fail tests testTerminateInNestedEnsureWithReturn1 through 4." + + ! Item was changed: ----- Method: Process>>terminate (in category 'changing process state') ----- terminate + "Stop the process that the receiver represents forever. + Unwind to execute pending ensure:/ifCurtailed: blocks before terminating; + allow all unwind blocks to run; if they are currently in progress, let them finish. + If the process is in the middle of a #critical: critical section, release it properly. + This is the behavior we expect when terminating a healthy process. + See further comments in #terminateAggressively and #destroy methods dealing + with process termination when closing a debugger or after a catastrophic failure." - "Stop the receiver forever. - Run all unwind contexts (#ensure:/#ifCurtailed: blocks) on the stack, even if they are currently in progress. If already active unwind contexts should not be continued, send #terminateAggressively instead. - Note that ill unwind contexts are theoretically able to stall the termination (for instance, by placing a non-local return in an unwind block); however, this is a disrecommended practice. - If the process is in the middle of a critical section, release it properly." + "If terminating the active process, suspend it first and terminate it as a suspended process." - | ctxt unwindBlock oldList outerMost | self isActiveProcess ifTrue: [ - "If terminating the active process, suspend it first and terminate it as a suspended process." [self terminate] fork. ^self suspend]. + "Execute termination in the ensure argument block to ensure it completes even if it + (the termination itself) is terminated in the middle; see testTerminateInTerminate." + [] ensure: [ | top ctxt outerMost | + suspendedContext ifNil: [^self error: 'Process already terminated or terminating']. - "Always suspend the process first so it doesn't accidentally get woken up. - N.B. If oldList is a LinkedList then the process is runnable. If it is a Semaphore/Mutex et al - then the process is blocked, and if it is nil then the process is already suspended." - oldList := self suspend. - suspendedContext ifNotNil: - ["Release any method marked with the <criticalSection> pragma. - The argument is whether the process is runnable." - self releaseCriticalSection: (oldList isNil or: [oldList class == LinkedList]). + "Always suspend the process first so it doesn't accidentally get woken up. + Disable the terminating process while running its stack in active process below so it doesn't + accidentally get resumed or terminated again; see Process>>#resume and tests + testResumeTerminatingProcess and testTerminateTerminatingProcess. + Release any method marked with the <criticalSection> pragma." + Smalltalk processSuspensionUnblocks + ifFalse: [ "this part is for revised resume semantics introduced in 2022 VMs" + self suspend. + top := suspendedContext. + suspendedContext := nil. + top releaseCriticalSection] + ifTrue: [ "this part is for backward compatibilty with pre-2022 VMs" + | oldList | + oldList := self suspend. + self releaseCriticalSection: (oldList isNil or: [oldList class == LinkedList]). + top := suspendedContext. + suspendedContext := nil]. + "If terminating a process halfways through an unwind, try to complete that unwind block first; + if there are multiple such nested unwind blocks, try to complete the outer-most one; nested unwind + blocks will be completed in the process; see tests in UnwindTest, and testTerminationDuringUnwind. + Note: Halfway-through blocks have already set the complete variable (tempAt: 2) in their defining + #ensure:/#ifCurtailed contexts from nil to true; we'll search for the bottom-most one. + Note: #findNextUnwindContextUpTo: starts searching from the receiver's sender but the receiver + itself may be an unwind context; see testTerminateEnsureAsStackTop." + ctxt := top. + ctxt isUnwindContext ifFalse: [ctxt := ctxt findNextUnwindContextUpTo: nil]. + [ctxt isNil] whileFalse: [ + (ctxt tempAt:2) ifNotNil: [ + outerMost := ctxt]. + ctxt := ctxt findNextUnwindContextUpTo: nil]. + outerMost ifNotNil: [top := (top runUnwindTo: outerMost onBehalfOf: self) sender]. - if there are multiple such nested unwind blocks, try to complete the outer-most one; the inner - blocks will be completed in the process." - ctxt := suspendedContext. - [(ctxt := ctxt findNextUnwindContextUpTo: nil) isNil] whileFalse: - "Contexts under evaluation have already set their complete (tempAt: 2) to true." - [(ctxt tempAt:2) ifNotNil: [outerMost := ctxt]]. - outerMost ifNotNil: [ - "This is the outer-most unwind context currently under evaluation; - let's find an inner context executing outerMost's argument block (tempAt: 1)" - (suspendedContext findContextSuchThat: [:ctx | - ctx closure == (outerMost tempAt: 1)]) ifNotNil: [:inner | - "Let's finish the unfinished unwind context only (i.e. up to inner) and return here" - suspendedContext runUntilErrorOrReturnFrom: inner. - "Update the receiver's suspendedContext (the previous step reset its sender to nil); - return, if the execution stack reached its bottom (e.g. in case of non-local returns)." - (suspendedContext := outerMost sender) ifNil: [^self]]]. + "By now no halfway-through unwind blocks are on the stack. Create a new top context for each + pending unwind block (tempAt: 1) and execute it on the unwind block's stack on behalf of self, i.e. + the process being terminated, to preserve process identity; see testProcessFaithfulTermination. + Cf. the unwind pattern in #resume:through: : using #value instead of #runUnwindTo:onBehalfOf: + would lead to an incorrect evaluation of non-local returns on the wrong stack (active process's). + Note: new top points to the former outerMost sender, i.e. the next unexplored context." + ctxt := top. - "Now all unwind blocks caught halfway through have been completed; - let's execute the ones still pending. Note: #findNextUnwindContextUpTo: starts - searching from the receiver's sender but the receiver itself may be an unwind context." - ctxt := suspendedContext. ctxt isUnwindContext ifFalse: [ctxt := ctxt findNextUnwindContextUpTo: nil]. [ctxt isNil] whileFalse: [ (ctxt tempAt: 2) ifNil: [ ctxt tempAt: 2 put: true. + top := (ctxt tempAt: 1) asContextWithSender: ctxt. + top runUnwindTo: top onBehalfOf: self]. + ctxt := ctxt findNextUnwindContextUpTo: nil] + ]! - unwindBlock := ctxt tempAt: 1. - "Create a context for the unwind block and execute it on the unwind block's stack. - Note: using #value instead of #runUntilErrorOrReturnFrom: would lead to executing - the unwind on the wrong stack preventing the correct execution of non-local returns." - suspendedContext := unwindBlock asContextWithSender: ctxt. - suspendedContext runUntilErrorOrReturnFrom: suspendedContext]. - ctxt := ctxt findNextUnwindContextUpTo: nil]. - - "Reset the context's pc and sender to nil for the benefit of isTerminated." - suspendedContext terminate]!

1 0

The Trunk: Compiler-ct.466.mcz
by commits＠source.squeak.org 03 Jan '22

03 Jan '22

Christoph Thiede uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-ct.466.mcz ==================== Summary ==================== Name: Compiler-ct.466 Author: ct Time: 3 January 2022, 5:59:21.929703 pm UUID: 22900e61-c1eb-914e-be93-b57e0e7901fd Ancestors: Compiler-eem.465, Compiler-ct.421 Recategorizations and multilingual improvements. =============== Diff against Compiler-eem.465 =============== Item was changed: ----- Method: AmbiguousSelector>>openMenuIn: (in category 'handling') ----- openMenuIn: aBlock "Ask the user which selector to choose. Answer the choosen selector or nil if cancellation is requested." | labels actions lines caption choice | labels := { + ('selector is {1} and argument is negative' translated format: {name copyFrom: 1 to: name size - 1}). + ('selector is {1} and argument is positive' translated format: {name}). + 'cancel' translated}. - 'selector is ' , (name copyFrom: 1 to: name size - 1) , ' argument is negative'. - 'selector is ' , name , ' argument is positive'. - 'cancel'}. actions := { name copyReplaceFrom: name size to: name size - 1 with: ' '. name copyReplaceFrom: name size + 1 to: name size with: ' '. nil. }. lines := {2}. + caption := 'Ambiguous selector: {1} please correct, or cancel:' translated format: {name}. - caption := 'Ambiguous selector: ' , name , ' please correct, or cancel:'. choice := aBlock value: labels value: lines value: caption. self resume: (actions at: choice ifAbsent: [nil])! Item was changed: + ----- Method: AmbiguousSelector>>setName:range: (in category 'initialization') ----- - ----- Method: AmbiguousSelector>>setName:range: (in category 'private') ----- setName: aString range: anInterval name := aString. interval := anInterval! Item was changed: + ----- Method: OutOfScopeNotification>>defaultAction (in category 'priv handling') ----- - ----- Method: OutOfScopeNotification>>defaultAction (in category 'as yet unclassified') ----- defaultAction ^false! Item was changed: + ----- Method: ParserNotification class>>name: (in category 'instance creation') ----- - ----- Method: ParserNotification class>>name: (in category 'as yet unclassified') ----- name: aString ^ (self new setName: aString) signal! Item was changed: + ----- Method: ParserNotification>>setName: (in category 'initialization') ----- - ----- Method: ParserNotification>>setName: (in category 'private') ----- setName: aString name := aString! Item was changed: + ----- Method: UndeclaredVariable>>openMenuIn: (in category 'handling') ----- - ----- Method: UndeclaredVariable>>openMenuIn: (in category 'as yet unclassified') ----- openMenuIn: aBlock | alternatives labels actions lines caption choice | alternatives := parser possibleVariablesFor: name. labels := OrderedCollection new. actions := OrderedCollection new. lines := OrderedCollection new. name first isLowercase ifTrue: + [labels add: 'declare method temp' translated. - [labels add: 'declare method temp'. actions add: [parser declareTemp: name at: #method]. + labels add: 'declare block-local temp' translated. - labels add: 'declare block-local temp'. actions add: [parser declareTemp: name at: #block]. parser canDeclareInstanceVariable ifTrue: + [labels add: 'declare instance' translated. - [labels add: 'declare instance'. actions add: [parser declareInstVar: name]]] ifFalse: + [labels add: 'define new class' translated. - [labels add: 'define new class'. actions add: [parser defineClass: name]. + labels add: 'declare global' translated. - labels add: 'declare global'. actions add: [parser declareGlobal: name]. parser canDeclareClassVariable ifTrue: + [labels add: 'declare class variable' translated. - [labels add: 'declare class variable'. actions add: [parser declareClassVar: name]]]. lines add: labels size. alternatives do: [:each | labels add: each. actions add: [parser substituteVariable: each atInterval: interval]]. lines add: labels size. + labels add: 'cancel' translated. + caption := 'Unknown variable: {1}!! please correct, or cancel:' translated format: {name}. - labels add: 'cancel'. - caption := 'Unknown variable: ' , name , ' please correct, or cancel:'. choice := aBlock value: labels value: lines value: caption. self resume: (actions at: choice ifAbsent: [nil])! Item was changed: + ----- Method: UndeclaredVariable>>setParser:name:range: (in category 'initialize-release') ----- - ----- Method: UndeclaredVariable>>setParser:name:range: (in category 'as yet unclassified') ----- setParser: aParser name: aString range: anInterval parser := aParser. name := aString. interval := anInterval! Item was changed: + ----- Method: UndefinedVariable>>openMenuIn: (in category 'handling') ----- - ----- Method: UndefinedVariable>>openMenuIn: (in category 'as yet unclassified') ----- openMenuIn: aBlock self resume: (Project uiManager confirm: ('{1} appears to be undefined at this point.\Proceed anyway?' withCRs translated asText format: {name asText allBold}) orCancel: [false] title: 'Undefined Variable' translated).! Item was changed: + ----- Method: UnknownSelector>>openMenuIn: (in category 'handling') ----- - ----- Method: UnknownSelector>>openMenuIn: (in category 'as yet unclassified') ----- openMenuIn: aBlock | alternatives labels lines caption choice | alternatives := Symbol possibleSelectorsFor: name. labels := Array streamContents: [:s | s nextPut: name; nextPutAll: alternatives]. lines := {1. alternatives size + 1}. + caption := 'Unknown selector, please\confirm, correct, or cancel' translated withCRs. - caption := 'Unknown selector, please\confirm, correct, or cancel' withCRs. choice := aBlock value: labels value: lines value: caption. choice = 0 ifTrue: [^ self resume: nil]. choice = 1 ifTrue: [^ self resume: name asSymbol]. self resume: (alternatives at: choice - 1)!

1 0

The Trunk: Morphic-ct.1840.mcz
by commits＠source.squeak.org 03 Jan '22

03 Jan '22

Christoph Thiede uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-ct.1840.mcz ==================== Summary ==================== Name: Morphic-ct.1840 Author: ct Time: 3 January 2022, 5:10:40.762703 pm UUID: 3a699b7d-f8fa-8343-9bb3-d6f8891fffbf Ancestors: Morphic-mt.1839 Implements "browse action code" and "debug action invocation" on SimpleButtonMorph. Try it out on a system window's box, for instance. =============== Diff against Morphic-mt.1839 =============== Item was added: + ----- Method: SimpleButtonMorph>>browseImplementationOfActionSelector (in category 'debug menu') ----- + browseImplementationOfActionSelector + + ToolSet browseMethod: (self target class lookupSelector: self actionSelector).! Item was added: + ----- Method: SimpleButtonMorph>>buildDebugMenu: (in category 'debug menu') ----- + buildDebugMenu: aHandMorph + + | aMenu | + aMenu := super buildDebugMenu: aHandMorph. + aMenu addLine. + aMenu add: 'browse action code' translated target: self action: #browseImplementationOfActionSelector. + aMenu add: 'debug action invocation' translated target: self action: #debugAction. + ^ aMenu! Item was added: + ----- Method: SimpleButtonMorph>>debugAction (in category 'debug menu') ----- + debugAction + + (Process + forBlock: [self doButtonAction] + runUntil: [:context | context selector = self actionSelector]) + debugWithTitle: ('Debug button action "{1}" in model "{2}"' translated format: {self label. self target printString}).!

1 0

David O'Toole of lisp games fame
by Bruce O'Neel 03 Jan '22

03 Jan '22

is having some fun playing with Squeak. David O'Toole (@deeteeoh1138) / Twitter [https://twitter.com/deeteeoh1138]

1 0

Re: [squeak-dev] The Trunk: Kernel-eem.1360.mcz
by Thiede, Christoph 03 Jan '22

03 Jan '22

Hi Eliot, hi all, something that was still on my to-do list before the next release is to address the changed behavior of Context >> #ruinSimulated:contextAtEachStep:. A short recap: TestCase new assert: thisContext equals: (thisContext runSimulated: [thisContext sender] contextAtEachStep: [:x|]) This assertion passes in Squeak 5.3, but since I have changed the behavior of #runSimulated:..., you have to insert a second "sender" inside the simulated block. Question: Do you think this breaking change is fine (because without it, we were not able to detect any of the non-local returns? And is this change important enough to be noted in the release notes? :-) Best, Christoph ________________________________ Von: Thiede, Christoph Gesendet: Dienstag, 3. November 2020 22:28:13 An: Eliot Miranda Betreff: AW: [squeak-dev] The Trunk: Kernel-eem.1360.mcz Hi Eliot, if you executed some block using the old #runSimulated: version, there was literally no difference that could be observed from within the block: thisContext runSimulated: [thisContext sender] contextAtEachStep: [:ctxt|]. "UndefinedObject>>DoIt" [thisContext sender] value. "UndefinedObject>>DoIt" With my version, this transparency does no longer persist: thisContext runSimulated: [thisContext sender] contextAtEachStep: [:ctxt|]. "FullBlockClosure(BlockClosure)>>ensure:" Well, you could argue that this would be the price for handling exceptions and all you need to do to fix the existing implementation would be to append one additional #sender call to "thisContext": thisContext runSimulated: [thisContext sender sender] contextAtEachStep: [:ctxt|]. "UndefinedObject>>DoIt" However, this violates the principle of simulation to be invisible to the code being simulated (or maybe not being similated but executed regularly instead). That's pretty sad ... Or am I wrong with this principle? And there is even another, much more severe issue. In the past, this worked, of course: (thisContext sender runSimulated: [thisContext sender] contextAtEachStep: [:ctxt|]) selector "#evaluateCue:ifFail:" Now let's retry this sample for my ill-conveived change, so I'm adding a #sender call to "thisContext", and will be the output? (thisContext sender runSimulated: [thisContext sender sender] contextAtEachStep: [:ctxt|]) selector "Compiler>>evaluateCue:ifFail:" Panic! After performing #runSimulated:contextAtEachStep:, the execution won't continue on the calling method, but on the Context receiver instance which #runSimulated:contextAtEachStep: was sent to! I'm going to push a fix for the latter issue right now, but still, I'm not sure whether we want to lose the simulator transparency here, see above ... > Hey, did you try the mandala example I added to Context class>>#runSimulated: ? So cool :-) (not that one can squash fillWhite, but that it is so fast). Really cool :-) The TimeProfileBrowser says that 75% of time is spent in #isPrimFailToken:, by the way. Any chance to make this even faster? :D <http://www.hpi.de/> PS: You sent me this message off-list, if this was not intended, please feel free to reply on-list again :-) Best, Christoph ________________________________ Von: Eliot Miranda <eliot.miranda(a)gmail.com> Gesendet: Montag, 2. November 2020 22:08:11 An: Thiede, Christoph Betreff: Re: [squeak-dev] The Trunk: Kernel-eem.1360.mcz Hi Christoph, On Nov 2, 2020, at 10:36 AM, Thiede, Christoph <Christoph.Thiede(a)student.hpi.uni-potsdam.de> wrote: Hi Eliot, I already had noticed the broken tests but did not yet complete the work on it. I now realize that the old version of #runSimulated:...: had a real relation to the receiver instance of the Context invoked on and things like this no longer work: thisContext sender runSimulated: [thisContext sender] contextAtEachStep: [:x|] In fact, my new proposed version is nearly static, and I admit it's a pity to lose this option. Hmm, I don’t really understand this point. Can you explain a bit more? thisContext sender still exists while we run simulated with the new version so I don’t quite see why it doesn’t work. If the intent is this: | baseContext | (baseContext := thisContext) runSimulated: [baseContext sender] contextAtEachStep: [:x|] should work right? If you remove the "thisContext sender" from the other users of #runSimulated:contextAtEachStep:, the stack frame won't be preserved during the simulation of aBlock. Which context isn’t preserved? If you like to rework it, I'll hand over it to you with pleasure because this task got larger than I would have assumed; otherwise, please let me know, and I broke it, so I'll fix it, too. :-) I wish I had the time! What u like in the current state of affairs is that all the tests are green. That’s good enough for me for now. Hey, did you try the mandala example I added to Context class>>#runSimulated: ? So cool :-) (not that one can squash fillWhite, but that it is so fast). Best, Christoph ________________________________ Von: Eliot Miranda <eliot.miranda(a)gmail.com> Gesendet: Montag, 2. November 2020 19:15 Uhr An: Thiede, Christoph Betreff: Re: [squeak-dev] The Trunk: Kernel-eem.1360.mcz Hi Christoph, I found the bug in the odl code. It was the use of thisContext sender runSimulated: ... instead of thisContext runSimulated:. Now all the tests pass. Thanks for pushing to get this working. It's an important and beautiful facility. On Mon, Nov 2, 2020 at 10:11 AM <commits(a)source.squeak.org<mailto:commits@source.squeak.org>> wrote: Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1360.mcz ==================== Summary ==================== Name: Kernel-eem.1360 Author: eem Time: 2 November 2020, 10:10:50.874417 am UUID: 2041d4e1-746a-49f9-9098-8fbd6ba2f787 Ancestors: Kernel-eem.1359, Kernel-ct.1359 Merge Kernel-ct.1359 from inbox Author: ct Time: 1 November 2020, 7:50:24.183428 pm UUID: 3b12b316-79f3-de41-8765-8296d964b821 Ancestors: Kernel-mt.1353 Revise and extend Context #runSimulated: implementation. Remove restriction to blocks that do not have a method return. Add support for exception signaling during the execution, which caused unterminated simulation of the calling process in the past. Support argless contextAtEachStep blocks. Benchmarks: code: [Context runSimulated: [100@100 corner: 200@200]] bench before: 16.7 ms/run after: 19.8 ms/run I think this should be okay, given the fact that the primary purpose of simulation is providing explorability but not efficiency ... eem: Fix a bug in the use of runSimulated:contextAtEachStep:. Presumably because of the pre-closure block model existing senders were of the form thisContext sender runSimulated: aBlock contextAtEachStep: [....] but this caused the jump at the end of runSimulated:contextAtEachStep: to short-cut any processing done after runSimulated:contextAtEachStep:. So rewrite all users of runSimulated:contextAtEachStep: in this form: thisContext runSimulated: aBlock contextAtEachStep: [....] and consequently have tallyInstruction: rallyMethods: et al answer their intended results. =============== Diff against Kernel-eem.1359 =============== Item was changed: ----- Method: Context class>>runSimulated: (in category 'simulation') ----- runSimulated: aBlock + "Simulate the execution of aBlock, until it ends or is curtailed. Answer the result it returns." - "Simulate the execution of the argument, current. Answer the result it - returns." + ^thisContext - ^ thisContext sender runSimulated: aBlock + contextAtEachStep: [] - contextAtEachStep: [:ignored] "Context runSimulated: [Pen new defaultNib: 5; go: 100]"! Item was changed: ----- Method: Context class>>tallyInstructions: (in category 'examples') ----- tallyInstructions: aBlock "This method uses the simulator to count the number of occurrences of each of the Smalltalk instructions executed during evaluation of aBlock. Results appear in order of the byteCode set." | tallies | tallies := Bag new. + thisContext - thisContext sender runSimulated: aBlock contextAtEachStep: [:current | tallies add: current nextByte]. ^tallies sortedElements "Context tallyInstructions: [3.14159 printString]"! Item was changed: ----- Method: Context class>>tallyMethods: (in category 'examples') ----- tallyMethods: aBlock "This method uses the simulator to count the number of calls on each method invoked in evaluating aBlock. Results are given in order of decreasing counts." | prev tallies | tallies := Bag new. prev := aBlock. + thisContext - thisContext sender runSimulated: aBlock contextAtEachStep: [:current | current == prev ifFalse: "call or return" [prev sender == nil ifFalse: "call only" [tallies add: current printString]. prev := current]]. ^tallies sortedCounts "Context tallyMethods: [3.14159 printString]"! Item was changed: ----- Method: Context class>>trace:on: (in category 'examples') ----- trace: aBlock on: aStream "Context trace: [3 factorial]" "This method uses the simulator to print calls to a file." | prev | prev := aBlock. + ^thisContext - ^ thisContext sender runSimulated: aBlock contextAtEachStep: [:current | + Sensor anyButtonPressed ifTrue: [^nil]. + current == prev ifFalse: + [prev sender ifNil: + [aStream space; nextPut: $^. + self carefullyPrint: current top on: aStream]. + aStream cr. + (current depthBelow: aBlock) timesRepeat: [aStream space]. + self carefullyPrint: current receiver on: aStream. + aStream space; nextPutAll: current selector; flush. + prev := current]]! - Sensor anyButtonPressed ifTrue: [^ nil]. - current == prev - ifFalse: - [prev sender ifNil: - [aStream space; nextPut: $^. - self carefullyPrint: current top on: aStream]. - aStream cr. - (current depthBelow: aBlock) timesRepeat: [aStream space]. - self carefullyPrint: current receiver on: aStream. - aStream space; nextPutAll: current selector; flush. - prev := current]]! Item was changed: ----- Method: Context>>runSimulated:contextAtEachStep: (in category 'system simulation') ----- + runSimulated: aBlock contextAtEachStep: anotherBlock + "Simulate the execution of the argument, aBlock, until it ends or is curtailed. If any exception is signaled during the execution, simulate it being handled on the present caller stack. Evaluate anotherBlock with the current context prior to each instruction executed. Answer the simulated value of aBlock." + + | current resume ensure | + resume := false. - runSimulated: aBlock contextAtEachStep: block2 - "Simulate the execution of the argument, aBlock, until it ends. aBlock - MUST NOT contain an '^'. Evaluate block2 with the current context - prior to each instruction executed. Answer the simulated value of aBlock." - | current | - aBlock hasMethodReturn - ifTrue: [self error: 'simulation of blocks with ^ can run loose']. current := aBlock asContext. + ensure := current insertSender: (Context contextEnsure: [resume := true]). + ensure sender ifNil: [ensure privSender: self]. "For backward compatibility, do not fail if aBlock is dead." + + (anotherBlock numArgs = 0 + ifTrue: ["optimized" [resume]] + ifFalse: ["stop execution on time, don't expose simulation details to caller" + [current == ensure or: + ["Context >> #resume:" + current size >= 2 and: + [(current at: 2) == ensure]]] ]) - current pushArgs: Array new from: self. - [current == self] whileFalse: + [anotherBlock cull: current. - [block2 value: current. current := current step]. + + ^ current jump! - ^self pop! -- _,,,^..^,,,_ best, Eliot

1 0

KernelTests-ct.409
by christoph.thiede＠student.hpi.uni-potsdam.de 03 Jan '22

03 Jan '22

Note that these tests cause multiple failures in a recent VM at the time of writing: - #testPrimitive100/{'not a selector'. {}. Object}: The VM sends #doesNotUnderstand: to the receiver with an invalid selector whereas the simulator has the primitive failed as expected in Object>>perform:withArguments:inSuperclass:. What behavior do we want? (I would opt for the latter one.) - #testPrimitive118/{6. 'not a primitive'. {7}},{6. 9. 'not an array'}: The VM returns an error code of -3 whereas the simulator returns no error code (nil). I have adjust this behavior in the simulator via Kernel-ct.1420. - #testPrimitive118/{6. 118. {9. {7. 13}}}: The VM does not check the number of arguments but ignores the first one whereas the simulator has the primitive failed with #'bad number of arguments'. What behavior do we want? (I would opt for the latter one.) - #testPrimitive118/2: Context>>receiver:tryPrimitive:withArgs: seems pretty buggy; not all arguments are popped from the stack and there occur several serious stack invalidations. In my opinion most of these issues need to be addressed in the VM; if a new release wasn't just around the corner, it would be my pleasure to use these failures as some good starter entrypoints into the VMMaker project during Christmas or so. But if we are in a hurry, probably someone else wants to fix these issues earlier. Or we just mark the relevant tests as expected failures for now. PS: Please don't ask me why the diff was not sent to the list this time. There should not be any special characters! ==================== Summary ==================== Name: KernelTests-ct.409 Author: ct Time: 10 November 2021, 1:45:40.105242 am UUID: ab3db7b1-d980-5b4b-80a2-8c08bef9b23b Ancestors: KernelTests-mt.407 Adds new simulation tests for the reflection primitives 117 (primitiveExternalCall), 118 (primitiveDoPrimitiveWithArgs), and 218 (primitiveDoNamedPrimitiveWithArgs) and revises existing tests for the primitives 83 (primitivePerform), 84 (primitivePerformWithArgs), and 100 (primitivePerformInSuperclass) which do not need to be dispatched via primitive 118. =============== Diff against KernelTests-mt.407 =============== ContextTest>>testPrimitive100 {tests} · ct 11/10/2021 00:38 (changed) testPrimitive100 { {#isNil. {}. Object}. "valid 0-arg message" {#=. {true}. UndefinedObject}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}. Object}. "valid binary message" {{}. #=. {true}. SequenceableCollection}. "mirror primitive" - {#isNil}. "missing arguments" - {#isNil. 'not an array'}. "invalid arguments" - {#isNil. {}}. "missing lookupClass" + {'not a selector'. {}. Object}. "invalid selector" + {#isNil. 'not an array'. Object}. "invalid arguments" {#isNil. {'excess arg'}. Object}. "too many arguments" {#=. {}. UndefinedObject}. "missing argument" + {#isNil. {}. 'not a class'}. "invalid lookupClass" {#isNil. {}. Boolean}. "lookupClass not in inheritance chain" - } do: [:args | + } do: [:args | | block | + block := [[nil + perform: args first + withArguments: args second + inSuperclass: args third] + on: Error do: [:ex | ex messageText]]. self - assert: (nil tryPrimitive: 100 withArgs: args) - equals: (Context runSimulated: [nil tryPrimitive: 100 withArgs: args])]. + assert: block value + equals: (Context runSimulated: block). + + block := [[thisContext + object: nil + perform: args first + withArguments: args second + inClass: args third] + on: Error do: [:ex | ex messageText]]. + self + assert: block value + equals: (Context runSimulated: block)]. ContextTest>>testPrimitive117 {tests} · ct 11/10/2021 00:10 + testPrimitive117 + + | input1 input2 | + "valid 0-arg primitive" + self + assert: #isNil size + equals: (Context runSimulated: [#isNil size]). + + "valid unary primitive" + self + assert: 6 + 9 + equals: (Context runSimulated: [6 + 9]). + + "superfluous arguments" + self "cascade!" + assert: 6 + 9 + equals: (Context runSimulated: [6 + 9]); + assert: true. + + self + assert: ((input1 := {1. 2. 3}) at: 2 put: 4) + equals: (Context runSimulated: [(input2 := {1. 2. 3}) at: 2 put: 4]); + assert: input1 + equals: input2. ContextTest>>testPrimitive118 {tests} · ct 11/10/2021 00:56 + testPrimitive118 + + self testPrimitive118: [:receiver :primitiveIndex :arguments | + receiver tryPrimitive: primitiveIndex withArgs: arguments]. + + self testPrimitive118: [:receiver :primitiveIndex :arguments | + thisContext receiver: receiver tryPrimitive: primitiveIndex withArgs: arguments]. ContextTest>>testPrimitive118: {tests} · ct 11/10/2021 01:23 + testPrimitive118: primitiveBlock + + | input1 input2 | + { + {#isNil. 62. {}}. "valid 0-arg primitive" + {6. 9. {7}}. "valid unary primitive" + {6. 62. {7}}. "failing primitive" + {6. 'not a primitive'. {7}}. "invalid primitive" + {6. 9. 'not an array'}. "invalid arguments" + {#isNil. 62. {1}}. "too many arguments" + {6. 9. {}}. "missing argument" + + {nil. 83. {#=. true}}. "primitivePerform" + {nil. 83. {#isNil. 'excess arg'}}. "primitivePerform - too many arguments" + {nil. 84. {#=. {true}}}. "primitivePerformWithArgs" + {nil. 84. {#isNil. 'excess arg'}}. "primitivePerformWithArgs - invalid arguments" + {nil. 100. {#=. true. Object}}. "primitivePerformInSuperclass" + {nil. 100. {#isNil. {'excess arg'}. Object}}. "primitivePerformInSuperclass - too many arguments" + + {6. 118. {9. {7}}}. "primitiveDoPrimitiveWithArgs" + {6. 118. {9. {7. 13}}}. "primitiveDoPrimitiveWithArgs - superfluous arguments" + {6. 118. {118. {9. {7}}}}. "primitiveDoPrimitiveWithArgs - M3" + {thisContext. 218. {Float32Array >> #sum. Float32Array withAll: {2.0. 3.0}. {}}}. "primitiveDoNamedPrimitiveWithArgs" + {thisContext. 218. {Float32Array >> #sum. Float32Array withAll: {2.0. 3.0}. {4.0}}}. "primitiveDoNamedPrimitiveWithArgs - superfluous arguments" + } do: [:args | | block | + block := [primitiveBlock valueWithArguments: args]. + self + assert: block value + equals: (Context runSimulated: block)]. + + self + assert: (primitiveBlock value: (input1 := {1. 2. 3}) value: 61 value: {2. 4}) + equals: (Context runSimulated: [primitiveBlock value: (input2 := {1. 2. 3}) value: 61 value: {2. 4}]); + assert: input1 + equals: input2. ContextTest>>testPrimitive218 {tests} · ct 11/10/2021 00:13 + testPrimitive218 + + "valid 0-arg primitive" + self + assert: (Float32Array withAll: {2.0. 3.0}) sum + equals: (Context runSimulated: [(Float32Array withAll: {2.0. 3.0}) sum]). + + "valid unary primitive" + self + assert: 'wiffy' = 'wiffy' copy + equals: (Context runSimulated: ['wiffy' = 'wiffy' copy]); + assert: 'wiffy' = 'ziffy' + equals: (Context runSimulated: ['wiffy' = 'ziffy']). + + "superfluous arguments" + self "cascade!" + assert: 'wiffy' = 'wiffy' copy + equals: (Context runSimulated: ['wiffy' = 'wiffy' copy]); + assert: true. ContextTest>>testPrimitive83 {tests} · ct 11/10/2021 00:24 (changed) testPrimitive83 { - {#isNil}. "valid 0-arg message" - {#=. true}. "valid unary message" - {#ifNil:ifNotNil:. [2]. [:x | x]}. "valid binary message" - {#isNil. 'excess arg'}. "too many arguments" - {#=}. "missing argument" - } do: [:args | + [nil perform: #isNil]. "valid 0-arg message" + [nil perform: #= with: true]. "valid unary message" + [nil perform: #ifNil:ifNotNil: with: [2] with: [:x | x]]. "valid binary message" + [nil perform: #isNil with: 'excess arg']. "too many arguments" + [nil perform: #=] + } do: [:block | self - assert: (nil tryPrimitive: 83 withArgs: args) - equals: (Context runSimulated: [nil tryPrimitive: 83 withArgs: args])]. + assert: (block on: Error do: [:ex | ex messageText]) + equals: (Context runSimulated: [block on: Error do: [:ex | ex messageText]])]. ContextTest>>testPrimitive84 {tests} · ct 11/10/2021 00:21 (changed) testPrimitive84 { {#isNil. {}}. "valid 0-arg message" {#=. {true}}. "valid unary message" {#ifNil:ifNotNil:. {[2]. [:x | x]}}. "valid binary message" - {#isNil}. "missing arguments" {#isNil. 'not an array'}. "invalid arguments" {#isNil. {'excess arg'}}. "too many arguments" {#=. {}}. "missing argument" } do: [:args | self - assert: (nil tryPrimitive: 84 withArgs: args) - equals: (Context runSimulated: [nil tryPrimitive: 84 withArgs: args])]. + assert: ([nil perform: args first withArguments: args second] on: Error do: [:ex | ex messageText]) + equals: (Context runSimulated: [[nil perform: args first withArguments: args second] on: Error do: [:ex | ex messageText]])]. --- Sent from Squeak Inbox Talk

1 1

The Trunk: SystemReporter-eem.54.mcz
by commits＠source.squeak.org 03 Jan '22

03 Jan '22

Eliot Miranda uploaded a new version of SystemReporter to project The Trunk: http://source.squeak.org/trunk/SystemReporter-eem.54.mcz ==================== Summary ==================== Name: SystemReporter-eem.54 Author: eem Time: 2 January 2022, 8:21:30.381231 pm UUID: 3719df64-bb5c-403b-be71-44d3b86c7865 Ancestors: SystemReporter-eem.53 Add a description of the new primitive suspend feature flag =============== Diff against SystemReporter-eem.53 =============== Item was changed: ----- Method: SystemReporter>>reportVMParameters: (in category 'reporting') ----- reportVMParameters: aStream | vmParameters isStack isCog isSpur | self header: 'Virtual Machine Parameters' on: aStream. vmParameters := Smalltalk vm getVMParameters. isStack := (vmParameters at: 42 ifAbsent: [0]) ~= 0. "42 = number of stack pages available" isCog := isStack and: [(vmParameters at: 46) ~= 0]. "46 is machine code zone size" isSpur := isStack and: [(vmParameters at: 41) anyMask: 2r10000]. "41 is imageFormatVersion for the VM; bit 16 is the Spur bit" (isSpur ifFalse: [#( 1 'size of old space' 2 'size of young+old space' 3 'size of memory' 4 'allocationCount' 5 'allocations between GCs')] ifTrue: [#( 1 'size of old space' 2 'used bytes in new space (used eden + used past space)' 3 'size of heap')]), #( 6 'survivor count tenuring threshold' 7 'full GCs since startup' 8 'total milliseconds in full GCs since startup'), (isSpur ifFalse: [#( 9 'incremental GCs since startup' 10 'total milliseconds in incremental GCs since startup' 11 'tenures of surving objects since startup'), {12 to: 19. 'specific to the translating VM'}] ifTrue: [#( 9 'scavenging GCs since startup' 10 'total milliseconds in scavenging GCs since startup' 11 'tenures of surving objects since startup' 12 'event trace mask (for debugging input events)' 13 'VM ticker start microseconds (Croquet/QwaqVM)' 14 'VM ticker count (Croquet/QwaqVM)' 15 'VM ticker call count (Croquet/QwaqVM)' 16 'total microseconds in idle since startup' 17 'proportion of code zone available for use (Sista VMs only; read-write)' 18 'total milliseconds in full GC compaction since startup (a portion of parameter 8)' 19 'scavenge threshold; the effective size of eden')]), #( 20 'utc microseconds at startup (if non-zero)' 21 'root/remembered table size (occupancy)' 22 'root/remembered table overflows since startup' 23 'bytes of extra memory to reserve for VM buffers, plugins, etc.' 24 'free memory threshold above which object memory will be shrunk' 25 'memory headroom when growing object memory'), (isStack ifFalse: [#( 26 'interruptChecksEveryNms - force an ioProcessEvents every N milliseconds, in case the image is not calling getNextEvent often')] ifTrue: [#( 26 'heartbeat period (ms; see #58)')]), (isSpur ifFalse: [#( 27 'number of times mark loop iterated for current IGC/FGC includes ALL marking' 28 'number of times sweep loop iterated for current IGC/FGC' 29 'number of times make forward loop iterated for current IGC/FGC' 30 'number of times compact move loop iterated for current IGC/FGC')] ifTrue: [#()]), #( 31 'number of grow memory requests' 32 'number of shrink memory requests'), (isSpur ifFalse: [#( 33 'number of root table entries used for current IGC/FGC' 34 'number of allocations done before current IGC/FGC' 35 'number of survivor objects after current IGC/FGC' 36 'millisecond clock when current IGC/FGC completed' 37 'number of marked objects for Roots of the world, not including Root Table entries for current IGC/FGC' 38 'milliseconds taken by current IGC' 39 'Number of finalization signals for Weak Objects pending when current IGC/FGC completed')] ifTrue: [#( 33 'number of root table entries at last scavenge' 35 'number of survivor objects at last scavenge (if non-zero)' 36 'millisecond clock when current scavenge completed' 38 'milliseconds taken by current scavenge' 39 'Number of finalization signals for Weak Objects pending when current SGC/FGC completed')]), #( 40 'VM word size - 4 or 8'), (isStack ifTrue: [#( 41 'imageFormatVersion for the VM' 42 'number of stack pages available' 43 'desired number of stack pages (stored in image file header, max 65535)' 44 'size of eden, in bytes' 45 'desired size of eden, in bytes (stored in image file header)' 46 'machine code zone size, in bytes (0 in Stack VM)' 47 'desired machine code zone size (0 => default 1Mb to 2Mb depending on processor)'), { 48. 'Persistent image header flags\ bit 0: implies Process has threadId as its 4th inst var\ bit 1: if set, methods that are interpreted will have the flag bit set in their header\ bit 2: if set, implies preempting a process does not put it to the back of its run queue\ bit 3: if set, implies the GUI should run on the first thread and event queues should not be accessed from other threads\ bit 4: if set, implies the new finalization scheme where WeakArrays are queued\ bit 5: if set, implies wheel events will be delivered as such and not mapped to arrow key events\ bit 6: if set, implies arithmetic primitives will fail if given arguments of different types (float vs int)\ bit 7: if set, causes times delivered from file primitives to be in UTC rather than local time.' withCRs }, #( 49 'max size the image promises to grow the external semaphore table to'), (isSpur ifFalse: [{ 50 to: 51. 'reserved for VM parameters that persist in the image (such as size of eden above)'. 52 to: 56. 'specific to Spur' }] ifTrue: [{ 50 to: 51. 'reserved for VM parameters that persist in the image (such as size of eden above)' }, #( 52 'root/remembered table capacity' 53 'number of old space segments' 54 'total free old space' 55 'ratio of growth and image size at or above which a GC will be performed post scavenge')]), #( 56 'number of process switches since startup' 57 'number of ioProcessEvents calls since startup' 58 'number of forceInterruptCheck calls since startup' 59 'number of check event calls since startup' 60 'number of stack page overflows since startup' 61 'number of stack page divorces since startup' 62 'compiled code compactions since startup'), (isCog ifFalse: [#()] ifTrue: [#( 63 'total milliseconds in compiled code compactions since startup' 64 'the number of methods that currently have jitted machine-code')]), + { 65. 'Cog feature flags\ bit 0: set if the VM supports MULTIPLE_BYTECODE_SETS.\ bit 1: set if the VM supports read-only objects (IMMUTABILITY).\ bit 2: set if the VM has an ITIMER_HEARTBEAT\ bit 3: set if the VM supports cross-platform BIT_IDENTICAL_FLOATING_POINT arithmetic\ bit 4: set if the VM can catch exceptions in FFI calls and answer them as primitive failures\ bit 5: set if the VM''s suspend primitive backs up the process to before the wait if it was waiting on a condition variable' withCRs. - { 65. 'Cog feature flags\ bit 0: set if the VM supports MULTIPLE_BYTECODE_SETS.\ bit 1: set if the VM supports read-only objects (IMMUTABILITY).\ bit 2: set if the VM has an ITIMER_HEARTBEAT\ bit 3: set if the VM supports cross-platform BIT_IDENTICAL_FLOATING_POINT arithmetic\ bit 4: set if the VM can catch exceptions in FFI calls and answer them as primitive failures' withCRs. 66. 'the byte size of a stack page'.}, (isSpur ifFalse: [{ 67 to: 69. 'reserved for more Cog-related info' }] ifTrue: [#( 67 'the maximum allowed size of old space (if zero there is no limit)' 68 'the average number of live stack pages when scanned by scavenge/gc/become' 69 'the maximum number of live stack pages when scanned by scavenge/gc/become')]), #( 70 'the vmProxyMajorVersion (the interpreterProxy VM_MAJOR_VERSION)' 71 'the vmProxyMinorVersion (the interpreterProxy VM_MINOR_VERSION)'), (isSpur ifFalse: [#()] ifTrue: [#( 72 'milliseconds spent marking since startup' 73 'reserved for more Spur-related info' 74 'reserved for more Spur-related info' 75 'do mixed arithmetic; if false binary arithmetic primitives will fail unless receiver and argument are of the same type')]), (isCog ifFalse: [#()] ifTrue: [#(76 'minimum unused bytes of headroom on all stack pages')])] ifFalse: [#()]) pairsDo: [:idx :desc | | value values | (idx isInteger ifTrue: [idx] ifFalse: [idx last]) <= vmParameters size ifTrue: [aStream nextPut: $#. idx isInteger ifTrue: [value := vmParameters at: idx. aStream print: idx; tab: (idx < 10 ifTrue: [2] ifFalse: [1]); nextPutAll: ((value isInteger and: [idx ~= 41]) ifTrue: [(desc includesSubstring: 'bit 0:') ifTrue: [value printStringBase: 2 nDigits: value highBit] ifFalse: [value asStringWithCommas]] ifFalse: [value printString])] ifFalse: [value := vmParameters at: idx first. aStream print: idx first; next: 2 put: $.; print: idx last; tab. values := idx collect: [:i| vmParameters at: i]. values asSet size = 1 ifTrue: [aStream print: value] ifFalse: [values do: [:v| aStream print: v] separatedBy: [aStream nextPutAll: ', ']]]. aStream tab; nextPutAll: desc; cr]]!

1 0

The Trunk: Kernel-ct.1438.mcz
by commits＠source.squeak.org 02 Jan '22

02 Jan '22

Christoph Thiede uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-ct.1438.mcz ==================== Summary ==================== Name: Kernel-ct.1438 Author: ct Time: 28 December 2021, 9:13:10.136249 pm UUID: 0477e714-e01d-d34d-b6aa-0939494a4abc Ancestors: Kernel-mt.1437, Kernel-ct.1403 Merges Kernel-ct.1403 (fixes simulation of dynamic-forwarding objects as methods). =============== Diff against Kernel-mt.1437 =============== Item was changed: ----- Method: Context>>send:to:with:lookupIn: (in category 'controlling') ----- send: selector to: rcvr with: arguments lookupIn: lookupClass "Simulate the action of sending a message with selector and arguments to rcvr. The argument, lookupClass, is the class in which to lookup the message. This is the receiver's class for normal messages, but for super messages it will be some specific class related to the source method." + | meth methClass primIndex val ctxt | - | meth primIndex val ctxt | (meth := lookupClass lookupSelector: selector) ifNil: [selector == #doesNotUnderstand: ifTrue: [self error: 'Recursive message not understood!!' translated]. ^self send: #doesNotUnderstand: to: rcvr with: {(Message selector: selector arguments: arguments) lookupClass: lookupClass} lookupIn: lookupClass]. + ((methClass := self objectClass: meth) == CompiledMethod or: [methClass == CompiledBlock]) ifFalse: - meth isCompiledMethod ifFalse: ["Object as Methods (OaM) protocol: 'The contract is that, when the VM encounters an ordinary object (rather than a compiled method) in the method dictionary during lookup, it sends it the special selector #run:with:in: providing the original selector, arguments, and receiver.'. DOI: 10.1145/2991041.2991062." ^self send: #run:with:in: to: meth with: {selector. arguments. rcvr}]. meth numArgs = arguments size ifFalse: [^ self error: ('Wrong number of arguments in simulated message {1}' translated format: {selector})]. (primIndex := meth primitive) > 0 ifTrue: [val := self doPrimitive: primIndex method: meth receiver: rcvr args: arguments. (self isPrimFailToken: val) ifFalse: [^val]]. ctxt := self activateMethod: meth withArgs: arguments receiver: rcvr. (primIndex isInteger and: [primIndex > 0]) ifTrue: [ctxt failPrimitiveWith: val]. ^ctxt!

4 3

squeak 4.19.9 on OpenIndiana 2022
by stes＠PANDORA.BE 02 Jan '22

02 Jan '22

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hello, For those that are interested in running Squeak on the OpenIndiana OS, there's new packages (binaries) available on http://openindiana.org/ The new release from 2022 is version 4.19.9,5.11-2022.0.0.7. This is compiled and built with --link-shared-lib and uses for the JPEGReadWriter2Plugin now the libjpeg8-turbo implementation. There's various JPEG libraries around, for example from ijg.org or from libjpeg-turbo.org and others. The JPEG test from http://wiki.squeak.org/squeak/4043 works with libjpeg8-turbo. I've also tested with IJG libjpeg 9.4 and this also seems to work. To test Squeak on systems with Vagrant VM see: https://github.com/openindiana/vagrantfiles Regards, David Stes -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJh0eh7AAoJENdFDkXGiciz6OcIAJHWaV5rKmFyhPmIMWOJsklc lSCQre/Lx1Ib1SoWb4fQhNFH6HaON4qwf2Pa/n4KcT9XRsHUrC8xNTtM1I6MnXne SkaCZVIE5j8oTzudBD6Q4D3KFaHXbSjW5UuAKFXJoEXcLjYPw/3p7xvrtgEVgxdy Zcpn8ZcDdS05tPjz3k/X4M+OatxCHKiQvK53jA6iGHq6f1L92t8b+5845+wlVvDr YNyQJSL5jmk3XY72E6IebpqMUYTGCjS3z6Dq0es80nhMFfQwsGQwFoaQSQHTxRJl KEjOqMcnkRq2NrR9bX7JdBZ9PCUtBPVFO2THNS8IrZt1srg0/QgfkdaoxUSpI5w= =Jgt4 -----END PGP SIGNATURE-----

1 0

Jump to page: