Squeak-dev June 2022

squeak-dev@lists.squeakfoundation.org

30 participants
309 discussions

The Inbox: System-cmm.1353.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Chris Muller uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-cmm.1353.mcz ==================== Summary ==================== Name: System-cmm.1353 Author: cmm Time: 31 May 2022, 5:50:31.586558 pm UUID: 52f9f789-3ad3-4ec7-914f-85f05ecaaead Ancestors: System-mt.1352 Added SmalltalkImage>>#heapMemoryLimit to access the -memory or -maxoldspace arguments passed to the vm. =============== Diff against System-mt.1352 =============== Item was added: + ----- Method: SmalltalkImage>>heapMemoryLimit (in category 'memory space') ----- + heapMemoryLimit + "If a memory-limiting argument to the vm was supplied (-memory or -maxoldspace), answer it as an Integer number of bytes, otherwise, nil." + | foundMemoryArg | + foundMemoryArg := false. + Smalltalk optionsDo: + [ : each | + (#('-memory' '--memory' '-maxoldspace' '--maxoldspace') includes: each) + ifTrue: [ foundMemoryArg := true ] + ifFalse: + [ foundMemoryArg ifTrue: + [ | arg | + arg := each. + "The memory arg is expected to be a number that ends in k, m, or g." + (arg isEmptyOrNil or: [ arg size < 2 ]) ifFalse: + [ | requestedMemory | + requestedMemory := (arg copyFrom: 1 to: arg size - 1) asNumber. + requestedMemory > 0 ifTrue: + [ ^ requestedMemory * (arg last + caseOf: + { [$k] -> [1000]. [$K] -> [1000]. + [$m] -> [1e6]. [$M] -> [1e6]. + [$g] -> [1e9]. [$G] -> [1e9] } + otherwise: [^nil]) ] ] ] ] ]. + ^ nil! Item was removed: - ----- Method: TTFileDescription>>profileAll (in category '*System-Tools-profiling') ----- - profileAll - "Profile reading all the glyphs" - MessageTally spyOn:[ - 1 to: numGlyphs do:[:glyphIndex| self readGlyphAt: glyphIndex-1]. - ].!

3 2

NetworkTests' TestURI vs. ClassTestCase
by Tony Garnock-Jones 02 Jun '22

02 Jun '22

Hello Patrick, hello all, I just noticed some failures in TestURI in NetworkTests, and I'm wondering how to fix them most cleanly. I've addressed this message to Patrick as well as the list, since he seems to have been the most recent contributor to NetworkTests, but I'd like to hear from anyone on the list! So, three of the TestURI tests are failing now that it inherits from ClassTestCase. - if it is renamed URITest, the tests pass (!!!); or, - if it is given an override "targetClass ^ URI", the tests pass. The override is a bit gross. So, perhaps we want to rename it to URITest, for consistency with other ClassTestCase subclasses. Do people agree? Shall I do that? Relatedly: what is ClassTestCase >> classToBeTested for, now that targetClass exists? In *almost* every case, classToBeTested is set to yield the same answer as targetClass. However it's not quite *every* case :-( . It looks like classToBeTested is the earlier mechanism. It has the advantage of being explicit, and the disadvantage of being (extremely) repetitive. However, targetClass's default implementation is kind of icky, leading to the TestURI vs URITest problem noted above. What should we do to clean it up? Prefer targetClass, or prefer classToBeTested? Neither? Both?? :-) Cheers, Tony

1 0

The Trunk: Installer-Core-ct.441.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Marcel Taeumel uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-ct.441.mcz ==================== Summary ==================== Name: Installer-Core-ct.441 Author: ct Time: 3 October 2021, 3:46:11.734874 pm UUID: 83088378-3d26-e946-b7e2-8f1cf03c3717 Ancestors: Installer-Core-mt.440 Extend documentation of Installer on how to install packages that are defined under the package-definitions category. =============== Diff against Installer-Core-mt.440 =============== Item was changed: Object subclass: #Installer instanceVariableNames: 'answers packages messagesToSuppress useFileIn noiseLevel' classVariableNames: 'InstallerBindings IsSetToTrapErrors Repositories SkipLoadingTests ValidationBlock' poolDictionaries: '' category: 'Installer-Core'! Installer class instanceVariableNames: 'localRepository'! + !Installer commentStamp: 'ct 10/3/2021 15:45' prior: 0! - !Installer commentStamp: 'tpr 8/25/2019 18:37' prior: 0! Installer is a mechanism for listing, examining and installing software from a variety of sources. It is intended to help in building install scripts for package setups etc. Currently it can use - files; a file specified by a filename. Relative filenames will be treated as based form the current default directory. See InstallerFile. - urls; a file specified by a url or a script embedded in a webpage. See InstallerWeb. - squeakmap; see InstallerSqueakMap - monticello; by ftp or http access, or a local directory, or a Magma or GOODS database. There is a list of shortcuts to popular repositories in this class protocol 'repositories'. See InstallerMonticello. - mantis; accessing code attached to a mantis bug report. See InstallerMantis. Simple example usages - + Installer new merge: #osProcess. Installer squeakmap install: 'DynamicBindings'. Installer squeakmap search: '*scratch'. Installer squeakmap search: 'author:*rowledge'. Installer squeaksource project: 'ss2'; install: 'TinyWiki'. Installer ss project: 'Installer'; browse: 'Installer-Core'. useFileIn - flag to load source.st rather than using Monticello! Installer class instanceVariableNames: 'localRepository'!

1 0

The Trunk: Installer-Core-mt.448.mcz
by commits＠source.squeak.org 02 Jun '22

02 Jun '22

Marcel Taeumel uploaded a new version of Installer-Core to project The Trunk: http://source.squeak.org/trunk/Installer-Core-mt.448.mcz ==================== Summary ==================== Name: Installer-Core-mt.448 Author: mt Time: 2 June 2022, 4:46:57.950188 pm UUID: f96d06a4-61c9-5442-b7de-7f6b52079900 Ancestors: Installer-Core-ct.447, Installer-Core-ct.441 Merge Installer-Core-ct.441. Cherry pick fixes from tcj.440 (from 2020) and lrnp.447. =============== Diff against Installer-Core-ct.447 =============== Item was changed: Object subclass: #Installer instanceVariableNames: 'answers packages messagesToSuppress useFileIn noiseLevel' classVariableNames: 'InstallerBindings IsSetToTrapErrors Repositories SkipLoadingTests ValidationBlock' poolDictionaries: '' category: 'Installer-Core'! Installer class instanceVariableNames: 'localRepository'! + !Installer commentStamp: 'ct 10/3/2021 15:45' prior: 0! - !Installer commentStamp: 'tpr 8/25/2019 18:37' prior: 0! Installer is a mechanism for listing, examining and installing software from a variety of sources. It is intended to help in building install scripts for package setups etc. Currently it can use - files; a file specified by a filename. Relative filenames will be treated as based form the current default directory. See InstallerFile. - urls; a file specified by a url or a script embedded in a webpage. See InstallerWeb. - squeakmap; see InstallerSqueakMap - monticello; by ftp or http access, or a local directory, or a Magma or GOODS database. There is a list of shortcuts to popular repositories in this class protocol 'repositories'. See InstallerMonticello. - mantis; accessing code attached to a mantis bug report. See InstallerMantis. Simple example usages - + Installer new merge: #osProcess. Installer squeakmap install: 'DynamicBindings'. Installer squeakmap search: '*scratch'. Installer squeakmap search: 'author:*rowledge'. Installer squeaksource project: 'ss2'; install: 'TinyWiki'. Installer ss project: 'Installer'; browse: 'Installer-Core'. useFileIn - flag to load source.st rather than using Monticello! Installer class instanceVariableNames: 'localRepository'! Item was changed: ----- Method: Installer class>>ensureRecentMetacello (in category 'scripts') ----- ensureRecentMetacello "Copied and adapted from https://github.com/Metacello/metacello/blob/master/README.md" | metacello | ((Smalltalk classNamed: #WebClient) ifNil: [ false ] ifNotNil: [ :webClient | [ (webClient httpHead: 'https://github.com') isSuccess ] on: Error do: [ false ] ]) ifFalse: [ ^self inform: 'Could not connect to "https://github.com".\\You need an internet connection and SSL support\to install (or update) Metacello.\\Please fix those issues and try again.' translated withCRs ]. self isMetacelloInstalled ifFalse: [ | response | "Download base archive of Metacello." response := WebClient httpGet: 'https://files.squeak.org/metacello/metacello-squeak60.sar'. response isSuccess ifFalse: [ self error: ('Could not download Metacello archive: {1}' translated format: {response status})]. "Prepare a clean environment and install it." + Smalltalk globals removeKey: #Metacello ifAbsent: ["Ignore prior attempts."]. - Smalltalk globals removeKey: #Metacello. SARInstaller new fileInFrom: response content asByteArray readStream]. metacello := Smalltalk classNamed: #Metacello. "Now load latest version of Metacello" metacello new baseline: 'Metacello'; repository: 'github://Metacello/metacello:master/repository'; get. metacello new baseline: 'Metacello'; repository: 'github://Metacello/metacello:master/repository'; load: #('default' 'Metacello-Help').! Item was changed: ----- Method: Installer class>>isMetacelloInstalled (in category 'scripts') ----- isMetacelloInstalled "Squeak is shipped with the global #Metacello referring to lightweight MetacelloStub. After the first message is sent, the latest Metacello is installed, replacing the stub." + + ^ (Smalltalk at: #Metacello ifAbsent: nil) + ifNil: [false "Installation was interrupted."] + ifNotNil: [:mcClass | mcClass ~= MetacelloStub]! - ^ (Smalltalk at: #Metacello) ~= MetacelloStub!

1 0

Merge Request: autoEncloseBeforeSpace.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 02 Jun '22

02 Jun '22

Hi all! This changeset refines the existing autoEnclose mechanism. Instead of having inserted enclosing brackets always, you can now activate a new preference to only insert these characters if there is any space after the cursor. This matches VS Code's setting value "beforeWhitespace" for "editor.autoClosingBrackets". To me, this mode feels much more convenient because when having traditional autoEnclose enabled, I have been getting angry again and again when I wanted to bracketize an existing expression in some code and suddenly was disrupted by an unneeded closing bracket. The changeset does not manipulate any defaults. The PreferenceWizard and the ReleaseBuilder are updated, too. Please honor the postscript of the changeset when merging it. Best, Christoph --- Sent from Squeak Inbox Talk

15 79

The Inbox: Kernel-jar.1474.mcz
by commits＠source.squeak.org 01 Jun '22

01 Jun '22

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-jar.1474.mcz ==================== Summary ==================== Name: Kernel-jar.1474 Author: jar Time: 1 June 2022, 4:40:04.621161 pm UUID: 5610d4f5-4e77-034a-bdc8-df674ef49b60 Ancestors: Kernel-jar.1473 Fix a bug: assigning suspendedContext := nil to a runnable but not active process would freeze the image when self is awakened. This can easily happen when a process gets preempted between the assignment and the next send. Try to execute this: p := [] newProcess resume. "p placed in run queue" p suspendedContext: nil. "image freezes" =============== Diff against Kernel-jar.1473 =============== Item was changed: ----- Method: Process>>suspendedContext: (in category 'private') ----- suspendedContext: aContext + "Note: assigning nil to a runnable but not active process would freeze the image when self is scheduled to run." + suspendedContext := aContext ifNil: [self suspend. nil]! - suspendedContext := aContext!

1 0

The Trunk: Graphics-mt.518.mcz
by commits＠source.squeak.org 01 Jun '22

01 Jun '22

Marcel Taeumel uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-mt.518.mcz ==================== Summary ==================== Name: Graphics-mt.518 Author: mt Time: 1 June 2022, 12:42:42.383329 pm UUID: 39ca7519-8370-4a49-8b83-1719a4bf7008 Ancestors: Graphics-mt.517 Fixes X11 issue with XResizeWindow directly followed by XGetWindowAttributes. I think that it makes sense to address this in the image unless somebody can propose a useful fix like "sync" or "wait a frame" in the VM. See platforms/unix/vm-display-X11/sqUnixX11.c. =============== Diff against Graphics-mt.517 =============== Item was changed: ----- Method: DisplayScreen class>>hostWindowExtent: (in category 'host window access') ----- hostWindowExtent: aPoint + [self - ^ [self primitiveWindow: self hostWindowIndex width: aPoint x height: aPoint y] on: Error "primitive failed such as in headless mode" + do: [:ex | "ignore" ]. + + Smalltalk windowSystemName = 'X11' + ifTrue: [100 milliSeconds wait]. + + ^ self actualScreenSize! - do: [:ex | Display extent]!

1 0

Default preferences
by Jaromir Matas 01 Jun '22

01 Jun '22

Hi All, A quick question: What are the 'default preferences'? I thought they were the ones the fresh image comes with but when you open a Preference Browser and hit the 'default' button you get another set of preferences (round buttons, colorful windows etc.) – is this a bug? Is there a way to get back to the preferences the image comes with? A theme is not a 'preference', despite the Preference Wizard sets it, right? (slightly confusing but ok) (BTW the Community Dark theme is awesome! Even italic comments :) Using it all the time) Also, if I check the 'English' tick-box in Extras -> Language, the flaps show (that must be a bug). Best, -- Jaromír Matas mail(a)jaromir.net

7 8

The Inbox: KernelTests-cmm.423.mcz
by commits＠source.squeak.org 01 Jun '22

01 Jun '22

Chris Muller uploaded a new version of KernelTests to project The Inbox: http://source.squeak.org/inbox/KernelTests-cmm.423.mcz ==================== Summary ==================== Name: KernelTests-cmm.423 Author: cmm Time: 31 May 2022, 5:53:42.444296 pm UUID: a504f011-37fb-4d93-ae2f-c3e1fc832b49 Ancestors: KernelTests-nice.422 #testOutOfMemorySignalExtreme can be stressful on a system that running the Squeak VM unconstrained (which is the default). Therefore, only run it if the vm is explicitly constrained. Note this requires =============== Diff against KernelTests-nice.422 =============== Item was changed: ----- Method: AllocationTest>>testOutOfMemorySignalExtreme (in category 'tests') ----- testOutOfMemorySignalExtreme + "Try to allocate more memory than permitted by the -memory vm argument, and check whether the expected error is signaled. Note that current (2017) Spur VMs fail in #new: and #basicNew: with #'bad argument' if given other than a non-negative SmallInteger." + Smalltalk heapMemoryLimit ifNotNil: + [ : bytes | + self + should: [ Array new: (bytes // Smalltalk wordSize) + 100 ] + raise: OutOfMemory, Error + withExceptionDo: + [:ex| + ex class == Error ifTrue: + [self assert: [ex messageText includesSubstring: 'basicNew: with invalid argument' ]]]]! - "Try to allocate a ridiculous amount of memory and check whether the expected error is signaled. Call Eliot when this test fails, he want your machine. :-) - - Note that current (2017) Spur VMs fail in #new: and #basicNew: with #'bad argument' if given other than a non-negative SmallInteger. - - Also note that this test can be quite stressful to your machine depending on how your operating system allocates the required memory behind the curtains. Better not triggering some robot fetching a tape from somewhere..." - - | sz | - sz := 1024*1024*1024*1024. "= 1 TiB" - self should: [Array new: sz] - raise: OutOfMemory, Error - withExceptionDo: - [:ex| - ex class == Error ifTrue: - [self assert: [ex messageText includesSubstring: 'basicNew: with invalid argument']]]!

2 1

Jump to page: