Squeak-dev July 2022

squeak-dev@lists.squeakfoundation.org

33 participants
227 discussions

The Trunk: MorphicExtras-eem.320.mcz
by commits＠source.squeak.org 06 Jul '22

06 Jul '22

Eliot Miranda uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-eem.320.mcz ==================== Summary ==================== Name: MorphicExtras-eem.320 Author: eem Time: 6 July 2022, 9:45:25.449703 am UUID: c0d225df-dd2b-4722-ae89-835d65139e20 Ancestors: MorphicExtras-mt.319 Avoid the WebCamMorph>>drawOn: method immediately turning on a webcam that has been turned off, while at the same time ensuring that the drawOn: method does cause the webcam to turn on when first opened. Use allSubInstances when checking for other users of a webcam in WebCamMorph>>off so that subclasses can be active. =============== Diff against MorphicExtras-mt.319 =============== Item was changed: ----- Method: WebCamMorph>>drawOn: (in category 'drawing') ----- drawOn: aCanvas camIsOn ifFalse: + [| turnOn | + turnOn := displayForm isNil. + self initializeDisplayForm. + turnOn ifTrue: [self on]]. - [self initializeDisplayForm. - self on]. camIsOn ifTrue: [(CameraInterface frameExtent: camNum) ~= displayForm extent ifTrue: [self initializeDisplayForm]]. displayForm ifNil: [self initializeDisplayForm]. useFrameSize ifTrue: [self extent: frameExtent]. self drawCameraImageOn: aCanvas. self drawFPSOn: aCanvas. self drawOverlayTextOn: aCanvas! Item was changed: ----- Method: WebCamMorph>>off (in category 'accessing') ----- off self stopStepping. camIsOn := false. "Be careful not to close the camera if any other morphs are using the same camera." + (self class allSubInstances anySatisfy: [:wcm| wcm cameraNumber = camNum and: [wcm cameraIsOn]]) ifFalse: - (self class allInstances anySatisfy: [:wcm| wcm cameraNumber = camNum and: [wcm cameraIsOn]]) ifFalse: [CameraInterface closeCamera: camNum]. self changed "self allInstances select: [:wcm| wcm cameraNumber = 1 and: [wcm cameraIsOn]]"!

1 0

The Inbox: Morphic-jar.2018.mcz
by commits＠source.squeak.org 06 Jul '22

06 Jul '22

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-jar.2018.mcz ==================== Summary ==================== Name: Morphic-jar.2018 Author: jar Time: 6 July 2022, 10:19:54.175389 am UUID: 78dd80d9-1174-0c40-ad18-6f76e13e744b Ancestors: Morphic-mt.2017 Add an "exit condition" to the UI loop to allow a former UI process to finish its last cycle and terminate gracefully. It allows to create a new UI without the need to explicitely terminate the old one because a UI process will terminate automatically once it's replaced by a new one. This change could allow UI proceses blocked on custom semaphores to continue waiting for a signal and finish their previous job (and terminate). Also, it prevents two UI processes to exist at the same time; only the one registered in the 'uiProcess' variable is allowed to cycle. Please review for any potential drawbacks or conflicts I may have missed. =============== Diff against Morphic-mt.2017 =============== Item was changed: ----- Method: MorphicProject>>spawnNewProcess (in category 'active process') ----- spawnNewProcess uiProcess := [ + [world doOneCycle. Processor yield. uiProcess isActiveProcess] whileTrue. - [world doOneCycle. Processor yield ] repeat. ] newProcess priority: Processor userSchedulingPriority. uiProcess resume!

3 2

The Trunk: Kernel-eem.1486.mcz
by commits＠source.squeak.org 06 Jul '22

06 Jul '22

Eliot Miranda uploaded a new version of Kernel to project The Trunk: http://source.squeak.org/trunk/Kernel-eem.1486.mcz ==================== Summary ==================== Name: Kernel-eem.1486 Author: eem Time: 5 July 2022, 4:08:05.255241 pm UUID: a9406e26-5f92-40fe-a876-a151252043e1 Ancestors: Kernel-eem.1485 Slightly faster implementations of CompiledMethod>>reads/writesField:. SImilarly neater CompiledCode>>sendsToSuper. Corrected CompiledCode>>hasMethodReturn; needs Compiler-eem.479 =============== Diff against Kernel-eem.1485 =============== Item was changed: ----- Method: CompiledCode>>hasMethodReturn (in category 'testing') ----- hasMethodReturn "Answer whether the receiver has a method-return ('^') in its code." + self codeLiteralsDo: [:compiledCode | | scanner | - | scanner | - self codeLiteralsDo: [:compiledCode | scanner := InstructionStream on: compiledCode. + (scanner scanFor: + [:x | + scanner willReturn + and: [scanner willBlockReturn not + "ignore any final ^self in the home method" + and: [compiledCode isCompiledBlock + or: [(compiledCode encoderClass isReturnSelfFromMethodAt: scanner pc in: compiledCode) + ifTrue: [scanner pc < compiledCode endPC] + ifFalse: [true]]]]]) - (scanner scanFor: [:x | (scanner willReturn - and: [scanner willBlockReturn not]) - "and: [scanner willReturnTopFromMethod not]" "-> Not supported in EncoderForSistaV1"]) ifTrue: [^ true]]. ^ false! Item was changed: ----- Method: CompiledCode>>sendsToSuper (in category 'testing') ----- sendsToSuper "Answer whether the receiver sends any message to super." + self codeLiteralsDo: + [:compiledCode | | scanner | - | scanner | - self codeLiteralsDo: [:compiledCode | scanner := InstructionStream on: compiledCode. + (scanner scanFor: (self encoderClass superSendScanBlockUsing: scanner)) ifTrue: + [^ true]]. - (scanner scanFor: (self encoderClass superSendScanBlockUsing: scanner)) - ifTrue: [^ true]]. ^ false! Item was changed: ----- Method: CompiledMethod>>readsField: (in category 'scanning') ----- readsField: varIndex + "Answer whether the receiver loads the instance variable whose index is the argument." - "Answer whether the receiver loads the instance variable indexed by the argument." + | scanBlock scanner | + self isQuick ifTrue: + [^ self isReturnField and: [varIndex - 1 = self returnField]]. - | varIndexCode scanner | - varIndexCode := varIndex - 1. - self isQuick ifTrue: [^ self isReturnField and: [self returnField = varIndexCode]]. - - self codeLiteralsDo: [:compiledCode | - scanner := InstructionStream on: compiledCode. - (scanner scanFor: (self encoderClass instVarReadScanBlockFor: varIndexCode using: scanner)) - ifTrue: [^ true]]. + scanner := InstructionStream new. + scanBlock := self encoderClass instVarReadScanBlockFor: varIndex - 1 using: scanner. + self codeLiteralsDo: [:compiledCode | + scanner method: compiledCode pc: compiledCode initialPC. + (scanner scanFor: scanBlock) ifTrue: + [^ true]]. + ^ false! Item was changed: ----- Method: CompiledMethod>>writesField: (in category 'scanning') ----- writesField: varIndex "Answer whether the receiver stores into the instance variable indexed by the argument." + self isQuick ifFalse: + [| scanner scanBlock | + scanner := InstructionStream new. + scanBlock := self encoderClass instVarWriteScanBlockFor: varIndex - 1 using: scanner. + self codeLiteralsDo: + [:compiledCode | + scanner method: compiledCode pc: compiledCode initialPC. + (scanner scanFor: scanBlock) ifTrue: + [^ true]]]. - | varIndexCode scanner | - self isQuick ifTrue: [^ false]. - varIndexCode := varIndex - 1. - self codeLiteralsDo: [:compiledCode | - scanner := InstructionStream on: compiledCode. - (scanner scanFor: (self encoderClass instVarWriteScanBlockFor: varIndex - 1 using: scanner)) - ifTrue: [^ true]]. - ^ false!

1 0

The Trunk: Compiler-eem.479.mcz
by commits＠source.squeak.org 06 Jul '22

06 Jul '22

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.479.mcz ==================== Summary ==================== Name: Compiler-eem.479 Author: eem Time: 5 July 2022, 4:06:16.298061 pm UUID: 61d1f08e-6212-45d1-b07a-8d4d39ce7c2f Ancestors: Compiler-eem.478 Add BytecodeEncoder class>>isReturnSelfFromMethodAt:in: and Sista & V3 implementations so that CompiledCode>>hasMethodReturn can be implemented correctly. =============== Diff against Compiler-eem.478 =============== Item was added: + ----- Method: BytecodeEncoder class>>isReturnSelfFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnSelfFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return self from method." + + self subclassResponsibility! Item was added: + ----- Method: EncoderForSistaV1 class>>isReturnSelfFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnSelfFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return self from method." + + ^(method at: pc) = 88! Item was added: + ----- Method: EncoderForV3 class>>isReturnSelfFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnSelfFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return self from method." + + ^(method at: pc) = 120!

1 0

The Trunk: Compiler-eem.478.mcz
by commits＠source.squeak.org 06 Jul '22

06 Jul '22

Eliot Miranda uploaded a new version of Compiler to project The Trunk: http://source.squeak.org/trunk/Compiler-eem.478.mcz ==================== Summary ==================== Name: Compiler-eem.478 Author: eem Time: 5 July 2022, 3:48:42.124762 pm UUID: 86982c07-bd3e-433f-9eaa-ff18ec4828f7 Ancestors: Compiler-mt.477 Add missing EncoderForSistaV1 class>>isReturnTopFromMethodAt:in: =============== Diff against Compiler-mt.477 =============== Item was added: + ----- Method: EncoderForSistaV1 class>>isReturnTopFromMethodAt:in: (in category 'instruction stream support') ----- + isReturnTopFromMethodAt: pc in: method + "Answer whether the bytecode at pc is a return stack top from method." + + ^(method at: pc) = 92!

1 0

The Trunk: ToolBuilder-Morphic-ct.318.mcz
by commits＠source.squeak.org 05 Jul '22

05 Jul '22

Christoph Thiede uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.318.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.318 Author: ct Time: 4 July 2022, 6:56:47.006131 pm UUID: 1f295819-7564-034f-8d01-b9fdc4661573 Ancestors: ToolBuilder-Morphic-mt.316 Fixes pane slitters and pane color in PluggablePanelMorph and PluggableSystemWindow when updating dynamic children. In the past, after rebuilding the dynamic children of a panel, splitters where not relayouted properly and the new children did not receive the color of the window before it was unfocused and focused again. This change factors out the relevant updating logic from the tool builder into #rebuildPaneAfter: and uses that method both during initial toolbuilding and when updating the children later. Also, during dynamic update, children are passed the correct pane color. On PluggableSystemWindow, eliminates the redundant children instvar. Thanks to Marcel (mt) for the help! =============== Diff against ToolBuilder-Morphic-mt.316 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggablePanel: (in category 'widgets required') ----- buildPluggablePanel: aSpec | widget | widget := self panelClass new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties." self setLayoutHintsFor: widget spec: aSpec. widget layoutInset: (aSpec padding ifNil: [self panelPadding]). - - "Flip the #wantsPaneSplitters flag only after all children where added." - widget cellGap: 0. - widget wantsPaneSplitters: false; wantsGrips: false. - widget removePaneSplitters; removeGrips. - - "Now create the children." - aSpec children isSymbol - ifTrue: [ - widget getChildrenSelector: aSpec children. - widget update: aSpec children] - ifFalse: [ - self buildAll: aSpec children in: widget]. - - "Now that we have all children, let's add those splitters if necessary." widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [false]). + "widget wantsGrips: true." widget cellGap: (aSpec spacing ifNil: [ widget wantsPaneSplitters ifTrue: [self windowSpacing] ifFalse: [self panelSpacing]]). + + "Now create the children." + aSpec children isSymbol + ifTrue: [ + widget getChildrenSelector: aSpec children. + widget update: widget getChildrenSelector] + ifFalse: [ + widget rebuildPaneAfter: [ + self buildAll: aSpec children in: widget]]. + - widget wantsPaneSplitters ifTrue: [widget addPaneSplitters]. - "widget wantsGrips: true; addGrips." - self setFrame: aSpec frame in: widget. self setLayout: aSpec layout in: widget. parent ifNotNil:[self add: widget to: parent]. widget borderWidth: 0. self buildHelpFor: widget spec: aSpec. widget color: Color transparent. ^ widget! Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableWindow: (in category 'widgets required') ----- buildPluggableWindow: aSpec | widget | aSpec layout == #proportional ifFalse:[ "This needs to be implemented - probably by adding a single pane and then the rest" ^self error: 'Not implemented'. ]. widget := (self windowClassFor: aSpec) new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties." MorphicProject worldGridEnabled ifTrue: [ "Snap both #position and #extent to grid." aSpec horizontalResizing ifNil: [aSpec horizontalResizing: #spaceFill]. aSpec verticalResizing ifNil: [aSpec verticalResizing: #spaceFill]]. self setLayoutHintsFor: widget spec: aSpec. widget layoutInset: (aSpec padding ifNil: [self windowPadding]). widget morphicLayerNumber: widget class windowLayer. + self flag: #todo. "ct: Below, there is a lot of duplication with #buildPluggablePanel:. Can we factor out some of this, or even just collect all children in a PluggablePanelMorph?" + widget cellGap: (aSpec spacing ifNil: [self windowSpacing]). + widget wantsGrips: true. + widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). + - "Performance. Flip the #wantsPaneSplitters flag only after all children where added." - widget cellGap: 0. - widget wantsPaneSplitters: false; wantsGrips: false. - widget removePaneSplitters; removeGrips. - "Now create the children." panes := OrderedCollection new. aSpec children isSymbol ifTrue: [ widget getChildrenSelector: aSpec children. widget update: aSpec children] ifFalse: [ + widget rebuildPaneAfter: [ + self buildAll: aSpec children in: widget]]. - self buildAll: aSpec children in: widget]. widget setUpdatablePanesFrom: panes. - "Now that we have all children, let's add those splitters if necessary." - widget cellGap: (aSpec spacing ifNil: [self windowSpacing]). - widget wantsGrips: true; addGrips. - widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). - widget wantsPaneSplitters ifTrue: [widget addPaneSplitters]. - aSpec defaultFocus ifNotNil: [:name | widget defaultFocusMorph: name]. aSpec label ifNotNil: [:label| label isSymbol ifTrue:[widget getLabelSelector: label] ifFalse:[widget setLabel: label]]. aSpec multiWindowStyle notNil ifTrue: [widget savedMultiWindowState: (SavedMultiWindowState on: aSpec model)]. widget closeWindowSelector: aSpec closeAction. self buildHelpFor: widget spec: aSpec. widget bounds: (RealEstateAgent initialFrameFor: widget initialExtent: ((aSpec extent ifNil:[widget initialExtent]) * RealEstateAgent windowScaleFactor * RealEstateAgent scaleFactor) rounded world: self currentWorld). widget refreshWindowColor. ^ widget! Item was added: + ----- Method: PluggablePanelMorph>>rebuildPaneAfter: (in category 'private') ----- + rebuildPaneAfter: aBlock + + | cellGap wantsGrips wantsPaneSplitters | + self flag: #duplication. "See PluggableSystemWindow>>#rebuildPaneAfter: and MorphicToolBuilder>>#buildPluggableWindow:." + + cellGap := self cellGap. + wantsGrips := self wantsGrips. + wantsPaneSplitters := self wantsPaneSplitters. + + self cellGap: 0. + self wantsPaneSplitters: false; wantsGrips: false. + self removePaneSplitters; removeGrips. + + ^ aBlock ensure: [ + wantsPaneSplitters ifTrue: [ + self wantsPaneSplitters: wantsPaneSplitters. + self addPaneSplitters]. + wantsGrips ifTrue: [ + self wantsGrips: wantsGrips. + self addGrips]. + self cellGap: cellGap]! Item was changed: ----- Method: PluggablePanelMorph>>update: (in category 'update') ----- + update: selectorSymbolOrNil + + selectorSymbolOrNil ifNil: [^ self]. + selectorSymbolOrNil = getChildrenSelector ifTrue: [ + self rebuildPaneAfter: [ + | children | + children := self children. + self + removeAllMorphs; + addAllMorphs: children. + self containingWindow ifNotNil: [:window | + children do: [:child | + child adoptPaneColor: window paneColor]]. - update: selectorSymbolOrNil - selectorSymbolOrNil ifNil: [ ^ self ]. - selectorSymbolOrNil = getChildrenSelector ifTrue: - [ self - removeAllMorphs ; - addAllMorphs: self children . + "Let my children take all the place unless my extent is described by them." + self hResizing ~~ #shrinkWrap ifTrue: + [self submorphsDo: [:m | m hResizing: #spaceFill]]. + self vResizing ~~ #shrinkWrap ifTrue: + [self submorphsDo: [:m | m vResizing: #spaceFill]]. + + "Tell dependents about this update. There is no pluggable notification for changed submorphs." + self changed: #submorphs]].! - "Let my children take all the place unless my extent is described by them." - self hResizing ~~ #shrinkWrap ifTrue: - [ self submorphsDo: [ : m | m hResizing: #spaceFill ] ]. - self vResizing ~~ #shrinkWrap ifTrue: - [ self submorphsDo: [ : m | m vResizing: #spaceFill ] ]. - - "Tell dependents about this update. There is no pluggable notification for changed submorphs." - self changed: #submorphs ].! Item was changed: SystemWindow subclass: #PluggableSystemWindow + instanceVariableNames: 'getLabelSelector getChildrenSelector closeWindowSelector' - instanceVariableNames: 'getLabelSelector getChildrenSelector children closeWindowSelector' classVariableNames: '' poolDictionaries: '' category: 'ToolBuilder-Morphic'! !PluggableSystemWindow commentStamp: 'ar 2/11/2005 20:14' prior: 0! A pluggable system window. Fixes the issues with label retrieval and adds support for changing children.! Item was added: + ----- Method: PluggableSystemWindow>>rebuildPaneAfter: (in category 'private') ----- + rebuildPaneAfter: aBlock + + | cellGap wantsGrips wantsPaneSplitters | + self flag: #duplication. "See PluggablePanelMorph>>#rebuildPaneAfter: and MorphicToolBuilder>>#buildPluggableWindow:." + + cellGap := self cellGap. + wantsGrips := self wantsGrips. + wantsPaneSplitters := self wantsPaneSplitters. + + self cellGap: 0. + self wantsPaneSplitters: false; wantsGrips: false. + self removePaneSplitters; removeGrips. + + ^ aBlock ensure: [ + wantsPaneSplitters ifTrue: [ + self wantsPaneSplitters: wantsPaneSplitters. + self addPaneSplitters]. + wantsGrips ifTrue: [ + self wantsGrips: wantsGrips. + self addGrips]. + self cellGap: cellGap]! Item was changed: ----- Method: PluggableSystemWindow>>update: (in category 'updating') ----- update: what what ifNil:[^self]. what == getLabelSelector ifTrue:[self setLabel: (model perform: getLabelSelector)]. + what == getChildrenSelector ifTrue: [ + self rebuildPaneAfter: [ + paneMorphs ifNil: [paneMorphs := #()]. + self removeAllMorphsIn: paneMorphs. + paneMorphs := model perform: getChildrenSelector. + self addAllMorphs: paneMorphs. + paneMorphs do: [:child | + child adoptPaneColor: self paneColor]. + paneMorphs do: [:m | m hResizing: #spaceFill; vResizing: #spaceFill]]]. - what == getChildrenSelector ifTrue:[ - children ifNil:[children := #()]. - self removeAllMorphsIn: children. - children := model perform: getChildrenSelector. - self addAllMorphs: children. - children do:[:m| m hResizing: #spaceFill; vResizing: #spaceFill]. - ]. what == #windowColorToUse ifTrue: [ self paneColor = model windowColorToUse ifFalse: [self refreshWindowColor]]. ^super update: what!

1 0

The Trunk: ToolBuilder-Morphic-ct.319.mcz
by commits＠source.squeak.org 05 Jul '22

05 Jul '22

Christoph Thiede uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-ct.319.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.319 Author: ct Time: 5 July 2022, 9:25:47.993738 am UUID: 67a60aa1-2652-e441-8f82-f92aa227fb52 Ancestors: ToolBuilder-Morphic-ct.318 Merges ToolBuilder-Morphic-ct.318: Fixes pane slitters and pane color in PluggablePanelMorph and PluggableSystemWindow when updating dynamic children. Revision: Update commentary. =============== Diff against ToolBuilder-Morphic-mt.316 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggablePanel: (in category 'widgets required') ----- buildPluggablePanel: aSpec | widget | widget := self panelClass new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties." self setLayoutHintsFor: widget spec: aSpec. widget layoutInset: (aSpec padding ifNil: [self panelPadding]). - - "Flip the #wantsPaneSplitters flag only after all children where added." - widget cellGap: 0. - widget wantsPaneSplitters: false; wantsGrips: false. - widget removePaneSplitters; removeGrips. - - "Now create the children." - aSpec children isSymbol - ifTrue: [ - widget getChildrenSelector: aSpec children. - widget update: aSpec children] - ifFalse: [ - self buildAll: aSpec children in: widget]. - - "Now that we have all children, let's add those splitters if necessary." widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [false]). + "widget wantsGrips: true." widget cellGap: (aSpec spacing ifNil: [ widget wantsPaneSplitters ifTrue: [self windowSpacing] ifFalse: [self panelSpacing]]). + + "Now create the children." + aSpec children isSymbol + ifTrue: [ + widget getChildrenSelector: aSpec children. + widget update: widget getChildrenSelector] + ifFalse: [ + widget rebuildPaneAfter: [ + self buildAll: aSpec children in: widget]]. + - widget wantsPaneSplitters ifTrue: [widget addPaneSplitters]. - "widget wantsGrips: true; addGrips." - self setFrame: aSpec frame in: widget. self setLayout: aSpec layout in: widget. parent ifNotNil:[self add: widget to: parent]. widget borderWidth: 0. self buildHelpFor: widget spec: aSpec. widget color: Color transparent. ^ widget! Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableWindow: (in category 'widgets required') ----- buildPluggableWindow: aSpec | widget | aSpec layout == #proportional ifFalse:[ "This needs to be implemented - probably by adding a single pane and then the rest" ^self error: 'Not implemented'. ]. widget := (self windowClassFor: aSpec) new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties." MorphicProject worldGridEnabled ifTrue: [ "Snap both #position and #extent to grid." aSpec horizontalResizing ifNil: [aSpec horizontalResizing: #spaceFill]. aSpec verticalResizing ifNil: [aSpec verticalResizing: #spaceFill]]. self setLayoutHintsFor: widget spec: aSpec. widget layoutInset: (aSpec padding ifNil: [self windowPadding]). widget morphicLayerNumber: widget class windowLayer. + self flag: #todo. "ct: Below, there is a lot of duplication with #buildPluggablePanel:. Can we factor out some of this, or even just collect all children in a PluggablePanelMorph?" + widget cellGap: (aSpec spacing ifNil: [self windowSpacing]). + widget wantsGrips: true. + widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). + - "Performance. Flip the #wantsPaneSplitters flag only after all children where added." - widget cellGap: 0. - widget wantsPaneSplitters: false; wantsGrips: false. - widget removePaneSplitters; removeGrips. - "Now create the children." panes := OrderedCollection new. aSpec children isSymbol ifTrue: [ widget getChildrenSelector: aSpec children. widget update: aSpec children] ifFalse: [ + widget rebuildPaneAfter: [ + self buildAll: aSpec children in: widget]]. - self buildAll: aSpec children in: widget]. widget setUpdatablePanesFrom: panes. - "Now that we have all children, let's add those splitters if necessary." - widget cellGap: (aSpec spacing ifNil: [self windowSpacing]). - widget wantsGrips: true; addGrips. - widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). - widget wantsPaneSplitters ifTrue: [widget addPaneSplitters]. - aSpec defaultFocus ifNotNil: [:name | widget defaultFocusMorph: name]. aSpec label ifNotNil: [:label| label isSymbol ifTrue:[widget getLabelSelector: label] ifFalse:[widget setLabel: label]]. aSpec multiWindowStyle notNil ifTrue: [widget savedMultiWindowState: (SavedMultiWindowState on: aSpec model)]. widget closeWindowSelector: aSpec closeAction. self buildHelpFor: widget spec: aSpec. widget bounds: (RealEstateAgent initialFrameFor: widget initialExtent: ((aSpec extent ifNil:[widget initialExtent]) * RealEstateAgent windowScaleFactor * RealEstateAgent scaleFactor) rounded world: self currentWorld). widget refreshWindowColor. ^ widget! Item was added: + ----- Method: PluggablePanelMorph>>rebuildPaneAfter: (in category 'private') ----- + rebuildPaneAfter: replacePaneMorphsBlock + "Performance. Reset layout properties during children update to avoid intermediate relayouting." + + | cellGap wantsGrips wantsPaneSplitters | + self flag: #duplication. "See PluggableSystemWindow>>#rebuildPaneAfter: and MorphicToolBuilder>>#buildPluggableWindow:." + + cellGap := self cellGap. + wantsGrips := self wantsGrips. + wantsPaneSplitters := self wantsPaneSplitters. + + self cellGap: 0. + self wantsPaneSplitters: false; wantsGrips: false. + self removePaneSplitters; removeGrips. + + ^ replacePaneMorphsBlock ensure: [ + wantsPaneSplitters ifTrue: [ + self wantsPaneSplitters: wantsPaneSplitters. + self addPaneSplitters]. + wantsGrips ifTrue: [ + self wantsGrips: wantsGrips. + self addGrips]. + self cellGap: cellGap]! Item was changed: ----- Method: PluggablePanelMorph>>update: (in category 'update') ----- + update: selectorSymbolOrNil + + selectorSymbolOrNil ifNil: [^ self]. + selectorSymbolOrNil = getChildrenSelector ifTrue: [ + self rebuildPaneAfter: [ + | children | + children := self children. + self + removeAllMorphs; + addAllMorphs: children. + self containingWindow ifNotNil: [:window | + children do: [:child | + child adoptPaneColor: window paneColor]]. - update: selectorSymbolOrNil - selectorSymbolOrNil ifNil: [ ^ self ]. - selectorSymbolOrNil = getChildrenSelector ifTrue: - [ self - removeAllMorphs ; - addAllMorphs: self children . + "Let my children take all the place unless my extent is described by them." + self hResizing ~~ #shrinkWrap ifTrue: + [self submorphsDo: [:m | m hResizing: #spaceFill]]. + self vResizing ~~ #shrinkWrap ifTrue: + [self submorphsDo: [:m | m vResizing: #spaceFill]]. + + "Tell dependents about this update. There is no pluggable notification for changed submorphs." + self changed: #submorphs]].! - "Let my children take all the place unless my extent is described by them." - self hResizing ~~ #shrinkWrap ifTrue: - [ self submorphsDo: [ : m | m hResizing: #spaceFill ] ]. - self vResizing ~~ #shrinkWrap ifTrue: - [ self submorphsDo: [ : m | m vResizing: #spaceFill ] ]. - - "Tell dependents about this update. There is no pluggable notification for changed submorphs." - self changed: #submorphs ].! Item was changed: SystemWindow subclass: #PluggableSystemWindow + instanceVariableNames: 'getLabelSelector getChildrenSelector closeWindowSelector' - instanceVariableNames: 'getLabelSelector getChildrenSelector children closeWindowSelector' classVariableNames: '' poolDictionaries: '' category: 'ToolBuilder-Morphic'! !PluggableSystemWindow commentStamp: 'ar 2/11/2005 20:14' prior: 0! A pluggable system window. Fixes the issues with label retrieval and adds support for changing children.! Item was added: + ----- Method: PluggableSystemWindow>>rebuildPaneAfter: (in category 'private') ----- + rebuildPaneAfter: replacePaneMorphsBlock + "Performance. Reset layout properties during children update to avoid intermediate relayouting." + + | cellGap wantsGrips wantsPaneSplitters | + self flag: #duplication. "See PluggablePanelMorph>>#rebuildPaneAfter: and MorphicToolBuilder>>#buildPluggableWindow:." + + cellGap := self cellGap. + wantsGrips := self wantsGrips. + wantsPaneSplitters := self wantsPaneSplitters. + + self cellGap: 0. + self wantsPaneSplitters: false; wantsGrips: false. + self removePaneSplitters; removeGrips. + + ^ replacePaneMorphsBlock ensure: [ + wantsPaneSplitters ifTrue: [ + self wantsPaneSplitters: wantsPaneSplitters. + self addPaneSplitters]. + wantsGrips ifTrue: [ + self wantsGrips: wantsGrips. + self addGrips]. + self cellGap: cellGap]! Item was changed: ----- Method: PluggableSystemWindow>>update: (in category 'updating') ----- update: what what ifNil:[^self]. what == getLabelSelector ifTrue:[self setLabel: (model perform: getLabelSelector)]. + what == getChildrenSelector ifTrue: [ + self rebuildPaneAfter: [ + paneMorphs ifNil: [paneMorphs := #()]. + self removeAllMorphsIn: paneMorphs. + paneMorphs := model perform: getChildrenSelector. + self addAllMorphs: paneMorphs. + paneMorphs do: [:child | + child adoptPaneColor: self paneColor]. + paneMorphs do: [:m | m hResizing: #spaceFill; vResizing: #spaceFill]]]. - what == getChildrenSelector ifTrue:[ - children ifNil:[children := #()]. - self removeAllMorphsIn: children. - children := model perform: getChildrenSelector. - self addAllMorphs: children. - children do:[:m| m hResizing: #spaceFill; vResizing: #spaceFill]. - ]. what == #windowColorToUse ifTrue: [ self paneColor = model windowColorToUse ifFalse: [self refreshWindowColor]]. ^super update: what!

1 0

The Inbox: ToolBuilder-Morphic-ct.318.mcz
by commits＠source.squeak.org 04 Jul '22

04 Jul '22

A new version of ToolBuilder-Morphic was added to project The Inbox: http://source.squeak.org/inbox/ToolBuilder-Morphic-ct.318.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-ct.318 Author: ct Time: 4 July 2022, 6:56:47.006131 pm UUID: 1f295819-7564-034f-8d01-b9fdc4661573 Ancestors: ToolBuilder-Morphic-mt.316 Fixes pane slitters and pane color in PluggablePanelMorph and PluggableSystemWindow when updating dynamic children. In the past, after rebuilding the dynamic children of a panel, splitters where not relayouted properly and the new children did not receive the color of the window before it was unfocused and focused again. This change factors out the relevant updating logic from the tool builder into #rebuildPaneAfter: and uses that method both during initial toolbuilding and when updating the children later. Also, during dynamic update, children are passed the correct pane color. On PluggableSystemWindow, eliminates the redundant children instvar. Thanks to Marcel (mt) for the help! =============== Diff against ToolBuilder-Morphic-mt.316 =============== Item was changed: ----- Method: MorphicToolBuilder>>buildPluggablePanel: (in category 'widgets required') ----- buildPluggablePanel: aSpec | widget | widget := self panelClass new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties." self setLayoutHintsFor: widget spec: aSpec. widget layoutInset: (aSpec padding ifNil: [self panelPadding]). - - "Flip the #wantsPaneSplitters flag only after all children where added." - widget cellGap: 0. - widget wantsPaneSplitters: false; wantsGrips: false. - widget removePaneSplitters; removeGrips. - - "Now create the children." - aSpec children isSymbol - ifTrue: [ - widget getChildrenSelector: aSpec children. - widget update: aSpec children] - ifFalse: [ - self buildAll: aSpec children in: widget]. - - "Now that we have all children, let's add those splitters if necessary." widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [false]). + "widget wantsGrips: true." widget cellGap: (aSpec spacing ifNil: [ widget wantsPaneSplitters ifTrue: [self windowSpacing] ifFalse: [self panelSpacing]]). + + "Now create the children." + aSpec children isSymbol + ifTrue: [ + widget getChildrenSelector: aSpec children. + widget update: widget getChildrenSelector] + ifFalse: [ + widget rebuildPaneAfter: [ + self buildAll: aSpec children in: widget]]. + - widget wantsPaneSplitters ifTrue: [widget addPaneSplitters]. - "widget wantsGrips: true; addGrips." - self setFrame: aSpec frame in: widget. self setLayout: aSpec layout in: widget. parent ifNotNil:[self add: widget to: parent]. widget borderWidth: 0. self buildHelpFor: widget spec: aSpec. widget color: Color transparent. ^ widget! Item was changed: ----- Method: MorphicToolBuilder>>buildPluggableWindow: (in category 'widgets required') ----- buildPluggableWindow: aSpec | widget | aSpec layout == #proportional ifFalse:[ "This needs to be implemented - probably by adding a single pane and then the rest" ^self error: 'Not implemented'. ]. widget := (self windowClassFor: aSpec) new. self register: widget id: aSpec name. widget model: aSpec model. "Set child dependent layout properties." MorphicProject worldGridEnabled ifTrue: [ "Snap both #position and #extent to grid." aSpec horizontalResizing ifNil: [aSpec horizontalResizing: #spaceFill]. aSpec verticalResizing ifNil: [aSpec verticalResizing: #spaceFill]]. self setLayoutHintsFor: widget spec: aSpec. widget layoutInset: (aSpec padding ifNil: [self windowPadding]). widget morphicLayerNumber: widget class windowLayer. + self flag: #todo. "ct: Below, there is a lot of duplication with #buildPluggablePanel:. Can we factor out some of this, or even just collect all children in a PluggablePanelMorph?" + widget cellGap: (aSpec spacing ifNil: [self windowSpacing]). + widget wantsGrips: true. + widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). + - "Performance. Flip the #wantsPaneSplitters flag only after all children where added." - widget cellGap: 0. - widget wantsPaneSplitters: false; wantsGrips: false. - widget removePaneSplitters; removeGrips. - "Now create the children." panes := OrderedCollection new. aSpec children isSymbol ifTrue: [ widget getChildrenSelector: aSpec children. widget update: aSpec children] ifFalse: [ + widget rebuildPaneAfter: [ + self buildAll: aSpec children in: widget]]. - self buildAll: aSpec children in: widget]. widget setUpdatablePanesFrom: panes. - "Now that we have all children, let's add those splitters if necessary." - widget cellGap: (aSpec spacing ifNil: [self windowSpacing]). - widget wantsGrips: true; addGrips. - widget wantsPaneSplitters: (aSpec wantsResizeHandles ifNil: [true]). - widget wantsPaneSplitters ifTrue: [widget addPaneSplitters]. - aSpec defaultFocus ifNotNil: [:name | widget defaultFocusMorph: name]. aSpec label ifNotNil: [:label| label isSymbol ifTrue:[widget getLabelSelector: label] ifFalse:[widget setLabel: label]]. aSpec multiWindowStyle notNil ifTrue: [widget savedMultiWindowState: (SavedMultiWindowState on: aSpec model)]. widget closeWindowSelector: aSpec closeAction. self buildHelpFor: widget spec: aSpec. widget bounds: (RealEstateAgent initialFrameFor: widget initialExtent: ((aSpec extent ifNil:[widget initialExtent]) * RealEstateAgent windowScaleFactor * RealEstateAgent scaleFactor) rounded world: self currentWorld). widget refreshWindowColor. ^ widget! Item was added: + ----- Method: PluggablePanelMorph>>rebuildPaneAfter: (in category 'private') ----- + rebuildPaneAfter: aBlock + + | cellGap wantsGrips wantsPaneSplitters | + self flag: #duplication. "See PluggableSystemWindow>>#rebuildPaneAfter: and MorphicToolBuilder>>#buildPluggableWindow:." + + cellGap := self cellGap. + wantsGrips := self wantsGrips. + wantsPaneSplitters := self wantsPaneSplitters. + + self cellGap: 0. + self wantsPaneSplitters: false; wantsGrips: false. + self removePaneSplitters; removeGrips. + + ^ aBlock ensure: [ + wantsPaneSplitters ifTrue: [ + self wantsPaneSplitters: wantsPaneSplitters. + self addPaneSplitters]. + wantsGrips ifTrue: [ + self wantsGrips: wantsGrips. + self addGrips]. + self cellGap: cellGap]! Item was changed: ----- Method: PluggablePanelMorph>>update: (in category 'update') ----- + update: selectorSymbolOrNil + + selectorSymbolOrNil ifNil: [^ self]. + selectorSymbolOrNil = getChildrenSelector ifTrue: [ + self rebuildPaneAfter: [ + | children | + children := self children. + self + removeAllMorphs; + addAllMorphs: children. + self containingWindow ifNotNil: [:window | + children do: [:child | + child adoptPaneColor: window paneColor]]. - update: selectorSymbolOrNil - selectorSymbolOrNil ifNil: [ ^ self ]. - selectorSymbolOrNil = getChildrenSelector ifTrue: - [ self - removeAllMorphs ; - addAllMorphs: self children . + "Let my children take all the place unless my extent is described by them." + self hResizing ~~ #shrinkWrap ifTrue: + [self submorphsDo: [:m | m hResizing: #spaceFill]]. + self vResizing ~~ #shrinkWrap ifTrue: + [self submorphsDo: [:m | m vResizing: #spaceFill]]. + + "Tell dependents about this update. There is no pluggable notification for changed submorphs." + self changed: #submorphs]].! - "Let my children take all the place unless my extent is described by them." - self hResizing ~~ #shrinkWrap ifTrue: - [ self submorphsDo: [ : m | m hResizing: #spaceFill ] ]. - self vResizing ~~ #shrinkWrap ifTrue: - [ self submorphsDo: [ : m | m vResizing: #spaceFill ] ]. - - "Tell dependents about this update. There is no pluggable notification for changed submorphs." - self changed: #submorphs ].! Item was changed: SystemWindow subclass: #PluggableSystemWindow + instanceVariableNames: 'getLabelSelector getChildrenSelector closeWindowSelector' - instanceVariableNames: 'getLabelSelector getChildrenSelector children closeWindowSelector' classVariableNames: '' poolDictionaries: '' category: 'ToolBuilder-Morphic'! !PluggableSystemWindow commentStamp: 'ar 2/11/2005 20:14' prior: 0! A pluggable system window. Fixes the issues with label retrieval and adds support for changing children.! Item was added: + ----- Method: PluggableSystemWindow>>rebuildPaneAfter: (in category 'private') ----- + rebuildPaneAfter: aBlock + + | cellGap wantsGrips wantsPaneSplitters | + self flag: #duplication. "See PluggablePanelMorph>>#rebuildPaneAfter: and MorphicToolBuilder>>#buildPluggableWindow:." + + cellGap := self cellGap. + wantsGrips := self wantsGrips. + wantsPaneSplitters := self wantsPaneSplitters. + + self cellGap: 0. + self wantsPaneSplitters: false; wantsGrips: false. + self removePaneSplitters; removeGrips. + + ^ aBlock ensure: [ + wantsPaneSplitters ifTrue: [ + self wantsPaneSplitters: wantsPaneSplitters. + self addPaneSplitters]. + wantsGrips ifTrue: [ + self wantsGrips: wantsGrips. + self addGrips]. + self cellGap: cellGap]! Item was changed: ----- Method: PluggableSystemWindow>>update: (in category 'updating') ----- update: what what ifNil:[^self]. what == getLabelSelector ifTrue:[self setLabel: (model perform: getLabelSelector)]. + what == getChildrenSelector ifTrue: [ + self rebuildPaneAfter: [ + paneMorphs ifNil: [paneMorphs := #()]. + self removeAllMorphsIn: paneMorphs. + paneMorphs := model perform: getChildrenSelector. + self addAllMorphs: paneMorphs. + paneMorphs do: [:child | + child adoptPaneColor: self paneColor]. + paneMorphs do: [:m | m hResizing: #spaceFill; vResizing: #spaceFill]]]. - what == getChildrenSelector ifTrue:[ - children ifNil:[children := #()]. - self removeAllMorphsIn: children. - children := model perform: getChildrenSelector. - self addAllMorphs: children. - children do:[:m| m hResizing: #spaceFill; vResizing: #spaceFill]. - ]. what == #windowColorToUse ifTrue: [ self paneColor = model windowColorToUse ifFalse: [self refreshWindowColor]]. ^super update: what!

2 1

The Trunk: Morphic-mt.2017.mcz
by commits＠source.squeak.org 04 Jul '22

04 Jul '22

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2017.mcz ==================== Summary ==================== Name: Morphic-mt.2017 Author: mt Time: 4 July 2022, 6:13:11.755583 pm UUID: debf4889-cf7a-8746-80db-3bab100ccc24 Ancestors: Morphic-kfr.2015 Fixes update of cached text morph menus. Fixes UI theme-specific styling of text selection in dialog windows. =============== Diff against Morphic-kfr.2015 =============== Item was changed: ----- Method: DialogWindow>>setMessageParameters (in category 'initialization') ----- setMessageParameters | fontToUse colorToUse margins | messageMorph ifNil: [^ self]. fontToUse := self userInterfaceTheme font ifNil: [TextStyle defaultFont]. colorToUse := self userInterfaceTheme textColor ifNil: [Color black]. margins := (TextStyle pointsToPixels: 5) truncated. messageMorph margins: (self wantsRoundedCorners ifTrue: [margins @ (margins - self cornerRadius) corner: margins @ margins] ifFalse: [margins]); textColor: colorToUse; + textStyle: fontToUse asNewTextStyle. "Use style with other point sizes available" + + "Style read-only text for copy interaction." + self flag: #todo. "mt: Duplication with PluggableTextMorph >> #setDefaultParameters" + (UserInterfaceTheme current get: #caretColor for: #PluggableTextMorph) + ifNotNil: [:c | messageMorph caretColor: c]. + (UserInterfaceTheme current get: #selectionColor for: #PluggableTextMorph) + ifNotNil: [:c | + self userInterfaceTheme color = (UserInterfaceTheme current get: #color for: #PluggableTextMorph) + ifTrue: [messageMorph selectionColor: c] + ifFalse: [ + "Background is different than in a text field. Use dialog-title color to ensure contrast." + messageMorph selectionColor: self userInterfaceTheme titleColor]].! - textStyle: fontToUse asNewTextStyle. "Use style with other point sizes available"! Item was changed: ----- Method: PluggableTextMorph class>>applyUserInterfaceTheme (in category 'preferences') ----- applyUserInterfaceTheme + self flushAdornmentCache. + + TextEditor withAllSubclassesDo: [:cls | + cls initializeYellowButtonMenu. + cls initializeShiftedYellowButtonMenu].! - self flushAdornmentCache.!

1 0

The Trunk: System-mt.1366.mcz
by commits＠source.squeak.org 04 Jul '22

04 Jul '22

Marcel Taeumel uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-mt.1366.mcz ==================== Summary ==================== Name: System-mt.1366 Author: mt Time: 4 July 2022, 5:31:16.038583 pm UUID: 6e5cc98a-41f9-c840-9059-4ea5fca92db6 Ancestors: System-mt.1365 CI status: only Trunk has daily builds; release builds are manual or on push =============== Diff against System-mt.1365 =============== Item was changed: ----- Method: SystemVersion>>ciStatusPageUrl (in category 'continuous integration') ----- ciStatusPageUrl + ^ 'https://github.com/squeak-smalltalk/squeak-app/actions/workflows/{1}?query=…' + format: { + self ciWorkflow. + self ciBranch. + '+is%3Acompleted'. "Show only completed runs." + self isRelease + ifTrue: ['' "Only Trunk has daily builds"] + ifFalse: ['+event%3Aschedule']}! - ^ 'https://github.com/squeak-smalltalk/squeak-app/actions/workflows/{1}?query=…' - format: {self ciWorkflow. self ciBranch}!

1 0

Jump to page: