Squeak-dev October 2023

squeak-dev@lists.squeakfoundation.org

24 participants
148 discussions

Raspberry PI OS from October, 32 bit
by Bruce O'Neel 22 Oct '23

22 Oct '23

Hi, For those of you who want to build and run squeak on the Rapsberry PI OS 32 bit version from October, the one based on Debian 12 (bookworm), and you have a PI 3 or higher, you will still have to remove --enable-fast-bitblt from mvm in building/linux32ARMv6/squeak.cog.spur/build [http://squeak.cog.spur/build] This is because on PI3 or higher you really do have a 64 bit system, and, the aarch64 kernel is running. This means that uname -a and friends convince us we're running a 64 bit system and the wrong things happen. Honestly unless you have a special case it is probably better to just run the 64 bit version. cheers bruce

2 1

SqueakMap sha1 checking failure when trying to install new package
by Tim Rowledge 20 Oct '23

20 Oct '23

I've just been making a SqueakMap entry for the WeatherStation (it's been a long time since I last added a package!) and it seems we have some issue with calculating the sha1 checksums. The attempt to load from SM failed and initially looked like something had prevented the server from responding (the error message was a complaint from HttpUrl>>#normalizeContents:) but the Transcript also shewed "(http://map.squeak.org/accountbyid/4340a66e-2296-48b7-9aa8-5305d303752f/file…) failed with this exception: Incorrect SHA checksum of file from original URL Trying server cache instead." Digging in to the debugger tells us that the smpackagerelease has a sha1 of 1044864536495630331656691098454436905765045645695 but the calculated value for the (correctly!) downloaded install file is 401855207151508086727566629532522206807045316227 - so things start to go wrong in SMPackageRelease>>#correctSha1sum: Loading some older packages seems to work. Checking the squeakmap web page shows that the sha1 value is indeed 1044864..... Looking at the stored sha1 values for 'Command Shell' for example tells me that they match what is calculated by #correctSha1sum: for the downloaded install scripts. Checking in a 5.3 image for the sha1 of the downloaded install script agrees with my trunk image. I tried marking the package as 'published' in case I had simply forgotten sometihng; no change IIRC the SM image is ancient and I could imagine we've changed sometihng that would affect this but this is very odd. I'd almost think line-ends but the script was written and saved in Squeak. tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Useful Latin Phrases:- Ventis secundis, tene cursum. = Go with the flow.

2 4

Squeak 6.0: Sound-mt.90.mcz
by commits＠source.squeak.org 19 Oct '23

19 Oct '23

Marcel Taeumel uploaded a new version of Sound to project Squeak 6.0: http://source.squeak.org/squeak60/Sound-mt.90.mcz ==================== Summary ==================== Name: Sound-mt.90 Author: mt Time: 19 October 2023, 10:46:00.042952 am UUID: f9b6929a-c5da-7f42-90fe-83d403afcca7 Ancestors: Sound-mt.89 Backport selected fixes for sound support from 6.1alpha (Sound-ct.94 tpr.93 eem.92 eem.91). Fix the length of WAV files produced by AbstractSound>>storeSampleCount:bigEndian:on:. The old code incorrectly rounded up the output size to the buffer size (2 * samplingRate). When writing a sound out to a file we need to divide the 'remaining' value by //2 to make the file size correct - otherwise it gets padded out by a lot of 0s =============== Diff against Sound-mt.89 =============== Item was changed: ----- Method: AbstractSound>>storeSampleCount:bigEndian:on: (in category 'file i/o') ----- storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream "Store my samples on the given stream at the current SoundPlayer sampling rate. If bigFlag is true, then each 16-bit sample is stored most-significant byte first (AIFF files), otherwise it is stored least-significant byte first (WAV files). If self isStereo is true, both channels are stored, creating a stereo file. Otherwise, only the left channel is stored, creating a mono file." | bufSize stereoBuffer reverseBytes streamDirect | self reset. bufSize := (2 * self samplingRate rounded) min: samplesToStore. "two second buffer" stereoBuffer := SoundBuffer newStereoSampleCount: bufSize. streamDirect := aBinaryStream isKindOf: StandardFileStream. reverseBytes := (bigEndianFlag xor: Smalltalk isBigEndian) xor: streamDirect not. 'Storing audio...' displayProgressFrom: 0 to: samplesToStore during: [:bar | | remaining out | remaining := samplesToStore. [remaining > 0] whileTrue: [ bar value: samplesToStore - remaining. stereoBuffer primFill: 0. "clear the buffer" self playSampleCount: (bufSize min: remaining) into: stereoBuffer startingAt: 1. out := self isStereo ifTrue: [stereoBuffer] ifFalse: [stereoBuffer extractLeftChannel]. reverseBytes ifTrue: [out reverseEndianness]. streamDirect + ifTrue: "optimization for files: write sound buffer directly to file" + [aBinaryStream next: (out size // 2 min: remaining// 2) putAll: out startingAt: 1] "size in words" + ifFalse: "for non-file streams:" + [1 to: (out monoSampleCount min: remaining) do: [:i | aBinaryStream int16: (out at: i)]]. - ifTrue: [ "optimization for files: write sound buffer directly to file" - aBinaryStream next: (out size // 2) putAll: out startingAt: 1] "size in words" - ifFalse: [ "for non-file streams:" - 1 to: out monoSampleCount do: [:i | aBinaryStream int16: (out at: i)]]. remaining := remaining - bufSize]].! Item was added: + ----- Method: AbstractSound>>storeSamples:count:bigEndian:on: (in category 'file i/o') ----- + storeSamples: samples count: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream + + | reverseBytes streamDirect | + streamDirect := aBinaryStream isKindOf: StandardFileStream. + reverseBytes := (bigEndianFlag xor: Smalltalk isBigEndian) xor: streamDirect not. + reverseBytes ifTrue: [samples reverseEndianness]. + streamDirect + ifTrue: "optimization for files: write sound buffer directly to file" + [aBinaryStream next: (samples size // 2 min: samplesToStore // 2) putAll: samples startingAt: 1] "size in words" + ifFalse: "for non-file streams:" + [1 to: (samples monoSampleCount min: samplesToStore) do: [:i | aBinaryStream int16: (samples at: i)]]. + reverseBytes ifTrue: [samples reverseEndianness]. "restore to original endianness"! Item was changed: ----- Method: LoopedSampledSound>>storeSampleCount:bigEndian:on: (in category 'file i/o') ----- storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream + "Store my samples on the given stream at the current SoundPlayer sampling rate. If bigFlag is true, then each 16-bit sample is stored most-significant byte first (AIFF files), otherwise it is stored least-significant byte first (WAV files). If self isStereo is true, both channels are stored, creating a stereo file. Otherwise, only the left channel is stored, creating a mono file." - "Store my samples on the given stream at the current SoundPlayer sampling rate. If bigFlag is true, then each 16-bit sample is stored most-significant byte first (AIFF files), otherwise it is stored least-significant byte first (WAV files)." + (self isStereo or: [scaledIndexIncr ~= LoopIndexScaleFactor]) ifTrue: [ - | reverseBytes | - (self isStereo or: [self samplingRate ~= originalSamplingRate]) ifTrue: [ ^ super storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream]. "optimization: if I'm not stereo and sampling rates match, just store my buffer" + ^ self storeSamples: leftSamples count: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream! - reverseBytes := bigEndianFlag ~= Smalltalk isBigEndian. - reverseBytes ifTrue: [leftSamples reverseEndianness]. - (aBinaryStream isKindOf: StandardFileStream) - ifTrue: [ "optimization for files: write sound buffer directly to file" - aBinaryStream next: (leftSamples size // 2) putAll: leftSamples startingAt: 1] "size in words" - ifFalse: [ "for non-file streams:" - 1 to: leftSamples monoSampleCount do: [:i | aBinaryStream int16: (leftSamples at: i)]]. - reverseBytes ifTrue: [leftSamples reverseEndianness]. "restore to original endianness" - ! Item was changed: ----- Method: SampledSound>>storeSampleCount:bigEndian:on: (in category 'file i/o') ----- storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream "Store my samples on the given stream at the current SoundPlayer sampling rate. If bigFlag is true, then each 16-bit sample is stored most-significant byte first (AIFF files), otherwise it is stored least-significant byte first (WAV files)." - | reverseBytes | self samplingRate ~= originalSamplingRate ifTrue: [ ^ super storeSampleCount: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream]. + - "optimization: if sampling rates match, just store my buffer" + ^ self storeSamples: samples count: samplesToStore bigEndian: bigEndianFlag on: aBinaryStream! - reverseBytes := bigEndianFlag ~= Smalltalk isBigEndian. - reverseBytes ifTrue: [samples reverseEndianness]. - (aBinaryStream isKindOf: StandardFileStream) - ifTrue: [ "optimization for files: write sound buffer directly to file" - aBinaryStream next: (samples size // 2) putAll: samples startingAt: 1] "size in words" - ifFalse: [ "for non-file streams:" - 1 to: samples monoSampleCount do: [:i | aBinaryStream int16: (samples at: i)]]. - reverseBytes ifTrue: [samples reverseEndianness]. "restore to original endianness" - ! Item was changed: ----- Method: SoundPlayer class>>soundQuickStart (in category 'preferences') ----- soundQuickStart <preference: 'Quickstart Sounds' category: 'media' + description: 'If true, attempt to start playing sounds immediately rather than waiting for the next chance to fill the sound buffers"' - description: 'If true, attempt to start playing sounds immediately rather than waiting for the next chance to fill the sound bufffers"' type: #Boolean> ^SoundsShouldStartQuick ifNil: [self defaultQuickStartForPlatform]!

1 0

Debian etc linux moving to Wayland from X11; do we need to do anything?
by Tim Rowledge 17 Oct '23

17 Oct '23

The new Pi5 (mine is supposed to arrive hot from Pi Towers by the end of the week, yay!) is using BookWorm Debian and that means defaulting to Wayland (and PipeWire, and Network Manager, and so on). Does this need any work in the vm? I mean, sqUnixX11.c has quite a lot of X-looking calls in it. Does PipeWire require a new vm-sound plugin? Or is there a set of trivial to use adaptors and we can just go back to sleep? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: PIC: Permute Instruction Codes

4 4

Fw: [New post] Smalltalk-Meetup in Zürich on Nov. 10th 2023
by Bruce O'Neel 17 Oct '23

17 Oct '23

---------- Forwarded message --------- From: Joachims Small World <comment-reply(a)wordpress.com> Date: 2023-10-17T12:41:35.000+02:00 Subject: [New post] Smalltalk-Meetup in Zürich on Nov. 10th 2023 To: <bruce.oneel(a)pckswarms.ch> [Site logo image] Joachim posted: " Over on the ESUG Mailing list, Peter announced the next Meetup for Smalltalk developers: So if you want to get in touch with Smalltalk developers or maybe even talk about your current or next project or exchange ideas and are in the Zürich Area on Nov" Joachims Small World [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] SMALLTALK-MEETUP IN ZÜRICH ON NOV. 10TH 2023 [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] JOACHIM Oct 17 Over on the ESUG Mailing list, Peter announced [https://joachimtuchel.wordpress.com?action=user_content_redirect&uuid=486fd…] the next Meetup for Smalltalk developers: So if you want to get in touch with Smalltalk developers or maybe even talk about your current or next project or exchange ideas and are in the Zürich Area on Nov 10th, don't hesitate to register. Read more of this post [https://joachimtuchel.wordpress.com?action=user_content_redirect&uuid=7b83d…] Comment [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] Like [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] [Tip icon image] You can also reply to this email to leave a comment. ------------------------- Unsubscribe [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] to no longer receive posts from Joachims Small World. Change your email settings at manage subscriptions. [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] Trouble clicking? Copy and paste this URL into your browser: https://joachimtuchel.wordpress.com/2023/10/17/smalltalk-meetup-in-zurich-o… [WordPress.com and Jetpack Logos] GET THE JETPACK APP TO USE READER ANYWHERE, ANYTIME Follow your favorite sites, save posts to read later, and get real-time notifications for likes and comments. [Download Jetpack on Google Play] [https://play.google.com/store/apps/details?id=com.jetpack.android&referrer=…] [Download Jetpack from the App Store] [https://apps.apple.com/app/apple-store/id1565481562?pt=299112&ct=new-post&m…] [WordPress.com on Twitter] [https://twitter.com/wordpressdotcom] [WordPress.com on Facebook] [https://www.facebook.com/WordPresscom] [WordPress.com on Instagram] [https://www.instagram.com/wordpressdotcom/] [WordPress.com on YouTube] [https://www.youtube.com/c/WordPressdotcom] [WordPress.com Logo and Wordmark title=] [https://public-api.wordpress.com/bar/?stat=groovemails-events&bin=wpcom_ema…] Automattic, Inc. - 60 29th St. #343, San Francisco, CA 94110

1 0

The Trunk: Morphic-mt.2135.mcz
by commits＠source.squeak.org 17 Oct '23

17 Oct '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2135.mcz ==================== Summary ==================== Name: Morphic-mt.2135 Author: mt Time: 17 October 2023, 1:20:00.950152 pm UUID: 17b9cc30-31ac-704c-b00c-0c397e33490f Ancestors: Morphic-ct.2134 In docking bar's windows menu, reorder recently added "Expand or contract" item to be near existing "Close" item because it replicates regular window button actions. Also add "Collapse" to have all major window buttons present there. =============== Diff against Morphic-ct.2134 =============== Item was changed: ----- Method: TheWorldMainDockingBar>>windowMenuFor:on: (in category 'submenu - windows') ----- windowMenuFor: window on: menu menu addItem: [ :item | item contents: 'Close' translated ; target: window; + selector: #closeBoxHit ]; - selector: #delete ]; addItem: [ :item | + item + contents: 'Expand (or contract)' translated ; + target: window; + selector: #expandBoxHit ]; + addItem: [ :item | + item + contents: 'Collapse (or expand)' translated ; + target: window; + selector: #collapseOrExpand ]; + addLine; + addItem: [ :item | item contents: 'Close all like this' translated ; target: self; selector: #closeAllWindowsLike:; arguments: { window } ]; addItem: [ :item | item contents: 'Close all but this' translated ; target: self; selector: #closeAllWindowsBut:; arguments: { window } ]; addLine; addItem: [ :item | item contents: 'Collapse all like this' translated ; target: self; selector: #collapseAllWindowsLike:; arguments: { window } ]; addItem: [ :item | item contents: 'Collapse all but this' translated ; target: self; selector: #collapseAllWindowsBut:; + arguments: { window } ]! - arguments: { window } ]; - addLine; - addItem: [ :item | - item - contents: 'Expand or Contract' translated ; - target: window; - selector: #expandBoxHit ]!

1 0

The Trunk: ToolBuilder-Morphic-mt.348.mcz
by commits＠source.squeak.org 16 Oct '23

16 Oct '23

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.348.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.348 Author: mt Time: 16 October 2023, 9:09:41.218917 am UUID: 9ca4109b-56e9-a346-b4ca-6fbcffe46713 Ancestors: ToolBuilder-Morphic-mt.347 Fix position of "new directory" button in file-saver dialog. "Cancel" button should be right-most and also consistent with directory-chooser dialog. =============== Diff against ToolBuilder-Morphic-mt.347 =============== Item was changed: ----- Method: FileSaverDialog>>buildButtonsWith: (in category 'toolbuilder') ----- buildButtonsWith: builder + "add a 'new directory' button to the beginning of the row of buttons" + ^ {builder pluggableButtonSpec new - - ^ (super buildButtonsWith: builder) - copyWith: - (builder pluggableButtonSpec new model: self; label: 'New Directory' translated; color: (self userInterfaceTheme get: #buttonColor for: #DialogWindow); action: #newDirectoryName; + yourself}, (super buildButtonsWith: builder)! - yourself)!

2 1

The Inbox: Morphic-ct.1718.mcz
by commits＠source.squeak.org 16 Oct '23

16 Oct '23

A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1718.mcz ==================== Summary ==================== Name: Morphic-ct.1718 Author: ct Time: 24 January 2021, 5:22:59.352273 pm UUID: f630cc0f-15e2-5642-94f6-6277bb8d7bd4 Ancestors: Morphic-mt.1710 PluggableTextMorph: Fixes #selectAll to keep the current scroll position intact, as it is best practice in most modern editor implementations such as Chromium. I'm very open to refactoring proposals, but otherwise I don't care if you merge this as-is. :-) =============== Diff against Morphic-mt.1710 =============== Item was changed: ----- Method: Editor>>selectAll: (in category 'typing/selecting keys') ----- selectAll: aKeyboardEvent "select everything, invoked by cmd-a. 1/17/96 sw" self insertAndCloseTypeIn. self selectFrom: 1 to: self string size. + morph skipOnceScrollSelectionIntoView. ^ true! Item was changed: ----- Method: PluggableTextMorph>>scrollSelectionIntoView: (in category 'editor access') ----- scrollSelectionIntoView: event "Scroll my text into view. Due to line composition mechanism, we must never use the right of a character block because the lines last character block right value always comes from a global container and is *not* line specific." self rememberSelectionInterval. + (self valueOfProperty: #skipScrollSelectionIntoView ifAbsent: [false]) ifTrue: [ + self removeProperty: #skipScrollSelectionIntoView. + ^ true]. + textMorph editor hasSelection ifFalse: [self scrollToShow: (textMorph editor startBlock withWidth: 1)] ifTrue: [ self scrollToShow: (textMorph editor startBlock topLeft corner: textMorph editor stopBlock bottomLeft). self scrollToShow: (textMorph editor pointBlock withWidth: 1). "Ensure text cursor visibility."]. ^ true! Item was added: + ----- Method: TextMorph>>skipOnceScrollSelectionIntoView (in category 'as yet unclassified') ----- + skipOnceScrollSelectionIntoView + + self owner owner setProperty: #skipScrollSelectionIntoView toValue: true.!

4 4

The Trunk: Morphic-mt.2116.mcz
by commits＠source.squeak.org 15 Oct '23

15 Oct '23

Marcel Taeumel uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-mt.2116.mcz ==================== Summary ==================== Name: Morphic-mt.2116 Author: mt Time: 26 July 2023, 5:15:38.140063 pm UUID: ccde047a-5845-5345-8989-e1f2c738612c Ancestors: Morphic-mt.2115 In Morphic, redesign how text actions are processed: - underline actions on mouse hover - integrate with Morphic UI loop, i.e., no busy wait for mouse-up - allow for selecting text from within text-action ranges for a better support of the preference "Interactive print-it" Unfortunately, the current text selection is not preserved anymore when just clicking a text action at the moment. Hmmm... =============== Diff against Morphic-mt.2115 =============== Item was removed: - ----- Method: NewParagraph>>clickAt:for:controller: (in category 'editing') ----- - clickAt: clickPoint for: model controller: editor - "Give sensitive text a chance to fire. Display flash: (100@100 extent: 100@100)." - | startBlock action | - action := false. - startBlock := self characterBlockAtPoint: clickPoint. - (text attributesAt: startBlock stringIndex forStyle: textStyle) - do: [:att | | range target box boxes | - att mayActOnClick ifTrue: - [(target := model) ifNil: [target := editor morph]. - range := text rangeOf: att startingAt: startBlock stringIndex. - boxes := self selectionRectsFrom: (self characterBlockForIndex: range first) - to: (self characterBlockForIndex: range last+1). - box := boxes detect: [:each | each containsPoint: clickPoint] ifNone: [nil]. - box ifNotNil: - [ box := (editor transformFrom: nil) invertBoundsRect: box. - editor morph allOwnersDo: [ :m | box := box intersect: (m boundsInWorld) ]. - self flag: #fix. "mt: Make it stateful and with real events." - Utilities awaitMouseUpIn: box - repeating: [] - ifSucceed: [(att actOnClickFor: target in: self at: clickPoint editor: editor) ifTrue: [action := true]]. - Cursor currentCursor == Cursor webLink ifTrue:[Cursor normal show]. - ]]]. - ^ action! Item was changed: ----- Method: TextEditor>>mouseDown: (in category 'events') ----- mouseDown: evt "Either 1) handle text actions in the paragraph, 2) begin a text drag operation, or 3) modify the caret/selection." - | clickPoint b | - oldInterval := self selectionInterval. + (self mouseDownOnTextAction: evt) ifTrue: [^ self]. - clickPoint := evt cursorPoint. - b := paragraph characterBlockAtPoint: clickPoint. - (paragraph clickAt: clickPoint for: model controller: self) ifTrue: [ - self flag: #note. "mt: Do not reset the current text selection for successful text actions. Leave markBlock and pointBlock as is. This behavior matches the one in web browsers when clicking on links." - evt hand releaseKeyboardFocus: morph. - evt hand releaseMouseFocus: morph. - ^ self ]. - (morph dragEnabled and: [self isEventInSelection: evt]) ifTrue: [ evt hand waitForClicksOrDrag: morph event: evt selectors: {#click:. nil. nil. #startDrag:} threshold: HandMorph dragThreshold. morph setProperty: #waitingForTextDrag toValue: true. ^ self]. evt shiftPressed + ifFalse: [ | b | - ifFalse: [ self closeTypeIn. + b := paragraph characterBlockAtPoint: evt position. markBlock := b. pointBlock := b ] ifTrue: [ self closeTypeIn. self mouseMove: evt ]. + + self storeSelectionInParagraph.! - self storeSelectionInParagraph! Item was added: + ----- Method: TextEditor>>mouseDownOnTextAction: (in category 'events') ----- + mouseDownOnTextAction: evt + + self flag: #todo. "mt: Do not reset the current text selection for successful text actions. Leave markBlock and pointBlock as is. This behavior matches the one in web browsers when clicking on links." + ^ false! Item was added: + ----- Method: TextEditor>>mouseEnterOnTextAction: (in category 'events') ----- + mouseEnterOnTextAction: evt + "Manage mouse-hovering effects for text actions." + + | index highlights | + self removeHighlightedTextActions. + + index := (paragraph characterBlockAtPoint: evt position) stringIndex. + (paragraph text attributesAt: index forStyle: paragraph textStyle) + do: [:attr | | highlight range | + attr mayActOnClick ifTrue: [ + highlights ifNil: [ + morph + setProperty: #highlightedTextActions + toValue: (highlights := OrderedCollection new)]. + highlight := TextEmphasis underlined. + range := paragraph text rangeOf: attr startingAt: index. + highlights add: {attr. highlight. range}. + paragraph text + addAttribute: highlight + from: range start to: range stop]]. + + highlights + ifNil: [self updateCursorForEvent: evt] + ifNotNil: [ + morph updateFromParagraph. + evt hand showTemporaryCursor: Cursor webLink].! Item was changed: ----- Method: TextEditor>>mouseUp: (in category 'events') ----- mouseUp: evt "An attempt to break up the old processRedButton code into threee phases" + "0) Click on text actions." + (self mouseUpOnTextAction: evt) ifTrue: [^ self]. + + "1) A 'double-click' will result in selecting the whole word." + (self hasCaret and: [oldInterval = self selectionInterval]) - oldInterval ifNil: [^ self]. "Patched during clickAt: repair" - (self hasCaret - and: [oldInterval = self selectionInterval]) ifTrue: [self selectWord]. + + "2) For the next type-in, configure emphasis. We don't want to do this on + every key-press for performance reasons." self setEmphasisHere. + + "3) Notice selection changes." + (self isDisjointFrom: oldInterval) + ifTrue: [otherInterval := oldInterval]. - (self isDisjointFrom: oldInterval) ifTrue: - [otherInterval := oldInterval]. self storeSelectionInParagraph. + "4) Reset mouse cursor to account for selection changes." self updateCursorForEvent: evt. morph removeProperty: #waitingForTextDrag.! Item was added: + ----- Method: TextEditor>>mouseUpOnTextAction: (in category 'events') ----- + mouseUpOnTextAction: evt + + | target | + "Do not trigger text action if start and stop of the selection are within that action range." + self hasCaret ifFalse: [ + self removeHighlightedTextActions. + ^ false]. + + (morph hasProperty: #highlightedTextActions) ifTrue: [ + target := model ifNil: [morph]. + (morph valueOfProperty: #highlightedTextActions) do: [:ea | + ea first + actOnClickFor: target + in: paragraph + at: evt position + editor: self]. + + self removeHighlightedTextActions. + morph removeProperty: #waitingForTextDrag. + evt hand releaseKeyboardFocus: morph. + evt hand releaseMouseFocus: morph. + ^ true]. + + ^ false! Item was added: + ----- Method: TextEditor>>removeHighlightedTextActions (in category 'events') ----- + removeHighlightedTextActions + + (morph hasProperty: #highlightedTextActions) + ifTrue: [ + (morph valueOfProperty: #highlightedTextActions) do: [:ea | + paragraph text + removeAttribute: ea second + from: ea third start to: ea third stop]. + morph removeProperty: #highlightedTextActions. + morph updateFromParagraph].! Item was removed: - ----- Method: TextMorph>>enterClickableRegion: (in category 'editing') ----- - enterClickableRegion: evt - | index isLink | - evt hand hasSubmorphs ifTrue:[^false]. - paragraph ifNotNil:[ - index := (paragraph characterBlockAtPoint: evt position) stringIndex. - isLink := (paragraph text attributesAt: index forStyle: paragraph textStyle) - anySatisfy:[:attr| attr mayActOnClick]. - isLink ifTrue: [ - evt hand showTemporaryCursor: Cursor webLink. - ^ true]]. - ^ false - ! Item was removed: - ----- Method: TextMorph>>handleMouseMove: (in category 'events-processing') ----- - handleMouseMove: anEvent - "Re-implemented to allow for mouse-up move events" - anEvent wasHandled ifTrue:[^self]. "not interested" - (anEvent hand hasSubmorphs) ifTrue:[^self]. - anEvent wasHandled: true. - self mouseMove: anEvent. - (anEvent anyButtonPressed and:[anEvent hand mouseFocus == self]) ifFalse:[^self]. - (self handlesMouseStillDown: anEvent) ifTrue:[ - "Step at the new location" - self startStepping: #handleMouseStillDown: - at: Time millisecondClockValue - arguments: {anEvent copy resetHandlerFields} - stepTime: 1]. - ! Item was added: + ----- Method: TextMorph>>handlesMouseMove: (in category 'event handling') ----- + handlesMouseMove: anEvent + "Handle all mouse-move events unless something is attached to the hand." + + ^ anEvent hand hasSubmorphs not! Item was added: + ----- Method: TextMorph>>handlesMouseStillDown: (in category 'event handling') ----- + handlesMouseStillDown: anEvent + + (anEvent anyButtonPressed and: [anEvent hand mouseFocus == self]) ifFalse: [^ false]. + ^ super handlesMouseStillDown: anEvent! Item was changed: ----- Method: TextMorph>>mouseLeave: (in category 'event handling') ----- mouseLeave: evt + evt hand showTemporaryCursor: nil. + self editor removeHighlightedTextActions.! - evt hand showTemporaryCursor: nil.! Item was changed: ----- Method: TextMorph>>mouseMove: (in category 'event handling') ----- mouseMove: evt evt redButtonPressed ifFalse: [ + "Avoid expensive #handleInteraction:fromEvent: wrapper here." + self editor mouseEnterOnTextAction: evt. - (self enterClickableRegion: evt) - ifFalse: [self editor updateCursorForEvent: evt]. ^ self]. self handleInteraction: [self editor mouseMove: evt] fromEvent: evt.! Item was changed: ----- Method: TextMorph>>startDrag: (in category 'event handling') ----- startDrag: evt self removeProperty: #waitingForTextDrag. + self editor removeHighlightedTextActions. [evt hand grabMorph: (TransferMorph withPassenger: self selection from: self)] ensure: [evt hand releaseMouseFocus: self].!

3 4

The Trunk: Monticello-ct.801.mcz
by commits＠source.squeak.org 12 Oct '23

12 Oct '23

Christoph Thiede uploaded a new version of Monticello to project The Trunk: http://source.squeak.org/trunk/Monticello-ct.801.mcz ==================== Summary ==================== Name: Monticello-ct.801 Author: ct Time: 12 October 2023, 9:36:36.082009 pm UUID: bb80b63c-71d6-354a-9993-15c02a2a1477 Ancestors: Monticello-mt.800 Slightly refactors MCWorkingCopyBrowser>>#addWorkingCopy according to Marcel's suggestion. =============== Diff against Monticello-mt.800 =============== Item was changed: ----- Method: MCWorkingCopyBrowser>>addWorkingCopy (in category 'actions') ----- addWorkingCopy | name packageInfo | name := Project uiManager request: 'Name of package:' translated. name isEmptyOrNil ifTrue: [^ self]. packageInfo := PackageInfo registerPackageName: name. + workingCopy := MCWorkingCopy forPackage: packageInfo mcPackage. - name := packageInfo name. "PackageInfo might assign a different name, e.g., for sanitization (see PackageInfo class>>#sanitizeName:)" - workingCopy := MCWorkingCopy forPackage: (MCPackage new name: name). workingCopyWrapper := nil. self repositorySelection: 0. self workingCopyListChanged; changed: #workingCopySelection; changed: #repositoryList. self changedButtons.!

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
15
Older →

Jump to page: