Squeak-dev December 2023

squeak-dev@lists.squeakfoundation.org

26 participants
124 discussions

The Inbox: KernelTests-ct.387.mcz
by commits＠source.squeak.org 24 Feb '24

24 Feb '24

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-ct.387.mcz ==================== Summary ==================== Name: KernelTests-ct.387 Author: ct Time: 24 October 2020, 12:40:40.526058 am UUID: aa73c56f-88e1-3b4d-9d59-fb29df3363a7 Ancestors: KernelTests-ul.386 Adds regression test for Kernel-ct.1355 (source logging after SyntaxError). Should I invest further complexity into this test for the purpose of keeping the production source logs clean? =============== Diff against KernelTests-ul.386 =============== Item was added: + ----- Method: ClassDescriptionTest>>testLogSourceAfterReparseSyntaxError (in category 'testing') ----- + testLogSourceAfterReparseSyntaxError + + | class source | + SystemChangeNotifier uniqueInstance doSilently: [[ + class := Object newSubclass. + source := 'foo [x'. + [class compile: source] + on: SyntaxErrorNotification do: [:error | + error resume: (source := source , ']')]. + self assert: source equals: (class sourceCodeAt: #foo) asString. + ] ensure: [class removeFromSystem]].! Item was changed: + ----- Method: ClassDescriptionTest>>testOrganization (in category 'testing') ----- - ----- Method: ClassDescriptionTest>>testOrganization (in category 'tests') ----- testOrganization | aClassOrganizer | aClassOrganizer := ClassDescription organization. self assert: (aClassOrganizer isKindOf: ClassOrganizer).!

3 2

The Inbox: Kernel-ct.1292.mcz
by commits＠source.squeak.org 24 Feb '24

24 Feb '24

A new version of Kernel was added to project The Inbox: http://source.squeak.org/inbox/Kernel-ct.1292.mcz ==================== Summary ==================== Name: Kernel-ct.1292 Author: ct Time: 3 January 2020, 2:21:26.297116 am UUID: 95936a10-85a4-734e-a10b-0f87290b70f9 Ancestors: Kernel-nice.1291 Proposal: Implement conditional exception handling on blocks. The nomenclature is inspired from usual practice in .NET languages. For an impression of possible users, have a look at: self systemNavigation browseMessageList: ((self systemNavigation allCallsOn: #on:do: and: #pass) intersection: (#(ifTrue: ifFalse: ifTrue:ifFalse: ifFalse:ifTrue:) gather: [:sel | self systemNavigation allCallsOn: sel])) name: 'Potential users of #on:when:do:' =============== Diff against Kernel-nice.1291 =============== Item was added: + ----- Method: BlockClosure>>on:when:do: (in category 'exceptions') ----- + on: exceptionOrExceptionSet when: aPredicate do: handlerAction + + ^ self + on: exceptionOrExceptionSet + do: [:exception | + (aPredicate value: exception) + ifTrue: [handlerAction cull: exception] + ifFalse: [exception pass]]! Item was added: + ----- Method: BlockClosure>>on:when:ensure: (in category 'exceptions') ----- + on: exceptionOrExceptionSet when: aPredicate ensure: aBlock + + ^ self + on: exceptionOrExceptionSet + do: [:exception | + (aPredicate value: exception) + ifTrue: [aBlock value]. + exception pass]!

9 17

The Inbox: Kernel-nice.1294.mcz
by commits＠source.squeak.org 24 Feb '24

24 Feb '24

Nicolas Cellier uploaded a new version of Kernel to project The Inbox: http://source.squeak.org/inbox/Kernel-nice.1294.mcz ==================== Summary ==================== Name: Kernel-nice.1294 Author: nice Time: 6 February 2020, 10:00:19.603883 pm UUID: c78e67da-95e5-42ad-af82-089c149f165d Ancestors: Kernel-tonyg.1293 Complex log function was missing (base 10 logarithm) Complex already provides ln and log:, so why not log? =============== Diff against Kernel-tonyg.1293 =============== Item was added: + ----- Method: Complex>>log (in category 'mathematical functions') ----- + log + "Answer the base 10 logarithm of the receiver." + + ^self ln / 10 ln!

2 1

#asByteArray needed for more classes, maybe
by Tim Rowledge 18 Feb '24

18 Feb '24

Whilst testing out Seaside in the 6.1 trunk image we discovered that LargePositiveInteger needs an #asByteArray method to enable the entity tag method to provide all that nice formatting stuff. For the specific case of LPI it's trivial "self as: ByteArray" works fine and sure, maybe it could be optimised. However, there is actual usage of #asByteArray in the main image that appears to be unsatisfied. For example, Magnitude>>#putOn: for binary streams. It appears no subclass of Magnitude implements #asByteArray, which seems unfortunate.#putOn: is used a fair bit in writing to streams. There's also some clashing with potentially important behaviour where collections of (very)smallintegers can be converted to ByteArrays so long as all the numeric values are <255. If we were to make an #asByteArray for SmallInteger that produced up to 8 bytes, how might that affect some of these usages? And what is a good byte array representation of a LargeNegativeInteger? And should every conversion be reversible? tim -- tim Rowledge; tim(a)rowledge.org; http://www.rowledge.org/tim Strange OpCodes: EF: Emulate Fireworks

11 33

The Inbox: KernelTests-jar.418.mcz
by commits＠source.squeak.org 01 Feb '24

01 Feb '24

A new version of KernelTests was added to project The Inbox: http://source.squeak.org/inbox/KernelTests-jar.418.mcz ==================== Summary ==================== Name: KernelTests-jar.418 Author: jar Time: 20 December 2021, 9:37:26.122961 pm UUID: 229ac303-0cfa-2d45-8d4e-e2b19b88cba8 Ancestors: KernelTests-ct.415 add a test (expected failure) to document a bug in #priority via a failing test case. The bug was summarized in http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217473… and discussed in http://forum.world.st/The-Inbox-Kernel-jar-1368-mcz-td5126894.html and most likely requires a new primitive to fix it correctly. An interim fix was proposed in Kernel-jar.1368 to show the desirable functionality that satisfies this test. =============== Diff against KernelTests-ct.415 =============== Item was added: + ----- Method: ProcessTest>>expectedFailures (in category 'failures') ----- + expectedFailures + + ^ #(testDecreaseActiveProcessPriority)! Item was added: + ----- Method: ProcessTest>>testDecreaseActiveProcessPriority (in category 'tests') ----- + testDecreaseActiveProcessPriority + "test whether #priority: reschedules active process to allow higher priority processes run; + presently (12/2021) the test fails and is here to remind about the #priority bug discussed + in http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-December/217473… + and http://forum.world.st/The-Inbox-Kernel-jar-1368-mcz-td5126894.html" + + | val oldPriority oldPreemptionYields | + val := nil. + oldPriority := Processor activePriority. + oldPreemptionYields := Smalltalk processPreemptionYields. + + [ + Processor activeProcess priority: oldPriority + 2. + [ val := false ] forkAt: oldPriority + 1. + [ val := true ] forkAt: oldPriority. + Processor activeProcess priority: oldPriority. + "depending on processPreemptionYields value the active process should be placed + either at the beginning or the end of the quiescentProcessLists at: oldPriority" + self assert: val = Smalltalk processPreemptionYields. + + "test both alternative settings (true/false) of processPreemptionYields" + val := nil. + Smalltalk processPreemptionYields: oldPreemptionYields not. + + Processor activeProcess priority: oldPriority + 2. + [ val := false ] forkAt: oldPriority + 1. + [ val := true ] forkAt: oldPriority. + Processor activeProcess priority: oldPriority. + self assert: val = Smalltalk processPreemptionYields. + + ] ensure: [ + "make sure processPreemptionYields is reset to its original value even if the test fails" + Smalltalk processPreemptionYields: oldPreemptionYields. + self assert: Smalltalk processPreemptionYields equals: oldPreemptionYields]!

3 4

Review Request: whenEvaluateEnoughArguments.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 19 Jan '24

19 Jan '24

=============== Summary =============== Change Set: whenEvaluateEnoughArguments Date: 15 August 2023 Author: Christoph Thiede Proposal: Tolerates superfluous arguments/missing parameters in Object Events block for #when:evaluate:. As required, implements valueWithEnoughArguments:[otherwise:|startingFrom:] on action sequences, message sends, etc. See Object>>#triggerEvent:withArguments:. Example: Object new when: #plonk evaluate: [Transcript showln: 'griffle']; triggerEvent: #plonk with: 42. Reasoning: Provide optional arguments with object events without forcing all observers to receive them. =============== Diff =============== ActionSequence>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 09:57 + valueWithEnoughArguments: anArray + "Evaluate the elements of the receiver with enough arguments and answer the result of last evaluation." + + ^self inject: nil into: + [:previousAnswer :each | each valueWithEnoughArguments: anArray] BlockClosure>>valueWithEnoughArguments:otherwise: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray otherwise: aBlock + + ^ self valueWithEnoughArguments: anArray MessageSend>>valueWithEnoughArguments:otherwise: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray otherwise: aBlock + + ^ self valueWithEnoughArguments: anArray Object>>triggerEvent:withArguments: {*System-Object Events-accessing-triggering} · ct 8/15/2023 09:59 (changed) triggerEvent: anEventSelector withArguments: anArgumentList ^(self actionForEvent: anEventSelector) - valueWithArguments: anArgumentList + valueWithEnoughArguments: anArgumentList Object>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 10:00 + valueWithEnoughArguments: aSequenceOfArguments + + ^ self WeakActionSequence>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 09:58 + valueWithEnoughArguments: anArray + "Return the last result" + + ^self inject: nil into: [ :previousAnswer :each | + each valueWithEnoughArguments: anArray otherwise: [ previousAnswer ]] WeakActionSequenceTrappingErrors>>valueWithEnoughArguments: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray + "Do the same as my parent, but make sure that all actions that do not + give errors are evaluated before resignaling the ones that gave errors + (giving the chance to clients to handle them)." + + ^self valueWithEnoughArguments: anArray startingFrom: 1 WeakActionSequenceTrappingErrors>>valueWithEnoughArguments:startingFrom: {evaluating} · ct 8/15/2023 09:59 + valueWithEnoughArguments: anArray startingFrom: startIndex + "Do the same as my parent, but make sure that all actions that do not + give errors are evaluated before resignaling the ones that gave errors + (giving the chance to clients to handle them)." + + "Note: I currently trap Halt,Error so that I am sure to get a Halt event in case of a Halt. This is being fixed in the exception system - when the fix is done it will be enough to capture only Error." + + | each answer | + answer := nil. + startIndex to: self size do: [:index | + each := self at: index. + [ + answer := each valueWithEnoughArguments: anArray otherwise: [ answer ]. + ] + on: Halt , Error + do: [:exc | + self valueWithEnoughArguments: anArray startingFrom: index + 1. + exc pass]]. + ^ answer WeakMessageSend>>valueWithEnoughArguments:otherwise: {evaluating} · ct 8/15/2023 09:58 + valueWithEnoughArguments: anArray otherwise: aBlock + | argsToUse | + + "Safe to use, because they are built before ensureing receiver and args..." + argsToUse := self collectArguments: anArray. + ^ self + withEnsuredReceiverAndArgumentsDo: [ :r :a | + r + perform: selector + withEnoughArguments: argsToUse ] + otherwise: aBlock --- Sent from Squeak Inbox Talk ["whenEvaluateEnoughArguments.1.cs"]

2 1

Review Request: browseCorePackageOfExtensionMethod.1.cs
by christoph.thiede＠student.hpi.uni-potsdam.de 19 Jan '24

19 Jan '24

=============== Summary =============== Change Set: browseCorePackageOfExtensionMethod Date: 15 August 2023 Author: Christoph Thiede Proposal: In browsers, adds item 'browse core package' to context menu of extension category (stubs). Hides irrelevant menu items when no category is selected. Adds interface on Categorizer and PackageOrganizer for finding case-insensitive names. =============== Diff =============== Browser>>browsePackageOfExtensionMethod {message category functions} · ct 8/15/2023 12:06 + browsePackageOfExtensionMethod + + | category sepIndex | + category := self selectedMessageCategoryName ifNil: [^ self changed: #flash]. + (category beginsWith: '*') ifFalse: [^ self changed: #flash]. + category := category allButFirst. + [(self systemOrganizer findCategoryName: category caseSensitive: false) ifNotNil: [:actualCategory | + ^ ToolSet browseCategory: actualCategory]. + (self environment packageOrganizer findPackageNamed: category caseSensitive: false) ifNotNil: [:package | + ^ (SystemBrowser default includesBehavior: TreeBrowser) + ifTrue: [ToolSet browseCategory: package name] + ifFalse: [ToolSet browsePackage: package]]. + sepIndex := category lastIndexOf: $- ifAbsent: [^ self changed: #flash]. + category := category first: sepIndex - 1] repeat. + + "examples: + '*JSON' -> package JSON + '*system-support' -> syscat System-Support + '*Morphic-Events-Filtering' -> syscat Morphic-Events" Browser>>mainMessageCategoryMenu: {message category functions} · ct 8/15/2023 11:48 (changed) mainMessageCategoryMenu: aMenu <messageCategoryMenu> - ^ aMenu addList: #( + self selectedMessageCategoryName ifNotNil: [:cat | + aMenu addTranslatedList: #( ('browse' buildMessageCategoryBrowser) ('browse all' browseAllMethodsInCategory) - ('browse all related' browseAllMethodsInCategoryToken) + ('browse all related' browseAllMethodsInCategoryToken)). + (cat beginsWith: '*') ifTrue: [ + aMenu addTranslatedList: #( + ('browse core package' browsePackageOfExtensionMethod))]]. + aMenu addTranslatedList: #( - ('print out' printOutMessageCategories) ('file out' fileOutMessageCategories) - ('reorganize' editMessageCategories) ('alphabetize' alphabetizeMessageCategories) ('remove empty categories' removeEmptyCategories) ('categorize all uncategorized' categorizeAllUncategorizedMethods) - ('new category...' addCategory) + ('new category...' addCategory)). + self selectedMessageCategoryName ifNotNil: [ + aMenu addTranslatedList: #( - ('rename...' renameCategory) - ('remove (x)' removeMessageCategory)); - yourself + ('remove (x)' removeMessageCategory))]. + ^ aMenu Categorizer>>findCategoryName:caseSensitive: {accessing} · ct 8/15/2023 11:44 + findCategoryName: categoryName caseSensitive: caseSensitive + + ^ categoryArray + detect: [:category | + (categoryName compare: category caseSensitive: caseSensitive) = 2] + ifNone: [nil] PackageOrganizer>>findPackageName:caseSensitive: {searching} · ct 8/15/2023 11:44 + findPackageName: aString caseSensitive: caseSensitive + ^ packages keys + detect: [:name | + (name compare: aString caseSensitive: caseSensitive) = 2] + ifNone: [nil] PackageOrganizer>>findPackageNamed:caseSensitive: {searching} · ct 8/15/2023 11:46 + findPackageNamed: aString caseSensitive: caseSensitive + | name | + name := self findPackageName: aString caseSensitive: caseSensitive. + ^ self packageNamed: name ifAbsent: [nil] PackageOrganizer>>hasPackageNamed: {searching} · ct 8/15/2023 11:33 + hasPackageNamed: aString + ^ packages includesKey: aString PackageOrganizer>>hasPackageNamed:caseSensitive: {searching} · ct 8/15/2023 11:35 + hasPackageNamed: aString caseSensitive: caseSensitive + caseSensitive ifTrue: [^ self hasPackageNamed: aString]. + ^ packages keys anySatisfy: [:name | aString sameAs: name] --- Sent from Squeak Inbox Talk ["browseCorePackageOfExtensionMethod.1.cs"]

2 1

The Inbox: Morphic-ct.2145.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2145.mcz ==================== Summary ==================== Name: Morphic-ct.2145 Author: ct Time: 1 December 2023, 9:00:59.264752 pm UUID: 2cb1f9a9-0aad-eb44-bde5-90138c603659 Ancestors: Morphic-ct.2144 Proposal: Makes the code point and Unicode category of characters explorable in explorers, analogously to different representations of numbers. =============== Diff against Morphic-ct.2144 =============== Item was added: + ----- Method: Character>>explorerContents (in category '*Morphic-Explorer') ----- + explorerContents + + ^ {ObjectExplorerWrapper + with: self codePoint + name: 'code point' + model: self. + ObjectExplorerWrapper + with: (Unicode generalCategoryLabelOf: self codePoint) + name: 'category' + model: self}! Item was added: + ----- Method: Character>>hasContentsInExplorer (in category '*Morphic-Explorer') ----- + hasContentsInExplorer + + ^ true!

3 4

The Inbox: Morphic-ct.2148.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2148.mcz ==================== Summary ==================== Name: Morphic-ct.2148 Author: ct Time: 7 December 2023, 7:31:26.443108 pm UUID: b74139ee-af71-b64d-9b8d-0950fd862bbd Ancestors: Morphic-mt.2147 Fixes a remarkable slip that (1) prevented collapsed windows from applying a new UI theme and (2) introduced a possibly significant memory leak*. Note that #userInterfaceTheme answer a UserInterfaceThemeRequest which forwards all one-argument selectors as setters to the actual theme. *To reproduce this in an older image, open a workspace, evaluate o := Array new: 100000000, collapse the window, change the UI theme, expand the window, close it, purge all undos and run GC, and the workspace with its large binding will still be referenced in the UI theme. =============== Diff against Morphic-mt.2147 =============== Item was changed: ----- Method: SystemWindow>>collapseOrExpand (in category 'resize/collapse') ----- collapseOrExpand "Collapse or expand the window, depending on existing state" | cf | isCollapsed ifTrue: ["Expand -- restore panes to morphics structure" isCollapsed := false. self beKeyWindow. "Bring to frint first" Preferences collapseWindowsInPlace ifTrue: [fullFrame := fullFrame align: fullFrame topLeft with: self getBoundsWithFlex topLeft] ifFalse: [collapsedFrame := self getBoundsWithFlex]. collapseBox ifNotNil: [collapseBox setBalloonText: 'collapse this window' translated]. self setBoundsWithFlex: fullFrame. paneMorphs reverseDo: [:m | self addMorph: m unlock. self world startSteppingSubmorphsOf: m]. self addPaneSplitters. (self hasProperty: #applyTheme) ifTrue: [ self removeProperty: #applyTheme. + UserInterfaceTheme current applyTo: self allMorphs]] - self userInterfaceTheme applyTo: self allMorphs]] ifFalse: ["Collapse -- remove panes from morphics structure" isCollapsed := true. fullFrame := self getBoundsWithFlex. "First save latest fullFrame" paneMorphs do: [:m | m delete; releaseCachedState]. self removePaneSplitters. self removeCornerGrips. model modelSleep. cf := self getCollapsedFrame. (collapsedFrame isNil and: [Preferences collapseWindowsInPlace not]) ifTrue: [collapsedFrame := cf]. self setBoundsWithFlex: cf. collapseBox ifNotNil: [collapseBox setBalloonText: 'expand this window' translated ]. expandBox ifNotNil: [expandBox setBalloonText: 'expand this window' translated ]. self isInWorld ifTrue: [self sendToBack]]. self layoutChanged.!

3 2

The Inbox: PreferenceBrowser-ct.160.mcz
by commits＠source.squeak.org 19 Jan '24

19 Jan '24

Christoph Thiede uploaded a new version of PreferenceBrowser to project The Inbox: http://source.squeak.org/inbox/PreferenceBrowser-ct.160.mcz ==================== Summary ==================== Name: PreferenceBrowser-ct.160 Author: ct Time: 21 December 2023, 7:37:19.742632 pm UUID: e1f740cd-fd42-7540-9189-9c34140810cf Ancestors: PreferenceBrowser-codefrau.159 Makes non-pragma preferences findable through its readable name (i.e., "higher perf" instead of "higherperf"). =============== Diff against PreferenceBrowser-codefrau.159 =============== Item was changed: ----- Method: PreferenceBrowser>>searchPreferencesFor: (in category 'preferences search') ----- searchPreferencesFor: pattern | result | result := pattern asString asLowercase withBlanksTrimmed. result ifEmpty: [^self]. searchResults := self allPreferences select: [:aPreference | ((aPreference name includesSubstring: result caseSensitive: false) or: [aPreference helpString includesSubstring: result caseSensitive: false]) + or: [aPreference codeString includesSubstring: result caseSensitive: false] + "for non-pragma preferences, #readableName is different from #name" + or: [aPreference readableName includesSubstring: result caseSensitive: false] ]. - or: [aPreference codeString includesSubstring: result caseSensitive: false] ]. self updateSearchResultsLabel. self selectSearchResultsCategory. self lastExecutedSearch: pattern. !

2 1