Squeak-dev August 2023

squeak-dev@lists.squeakfoundation.org

30 participants
163 discussions

The Inbox: System-ct.1424.mcz
by commits＠source.squeak.org 06 Sep '23

06 Sep '23

Christoph Thiede uploaded a new version of System to project The Inbox: http://source.squeak.org/inbox/System-ct.1424.mcz ==================== Summary ==================== Name: System-ct.1424 Author: ct Time: 29 August 2023, 7:41:28.345934 pm UUID: 9af4e7bf-a99d-8a43-9de5-87c8ed70ce94 Ancestors: System-mt.1423 Revises RealEstateAgent logic for placing collapsed windows to deal with more windows than fit in one column by arranging them next to each other. Speeds up the logic for high-DPI displays by honoring the current scaleFactor. =============== Diff against System-mt.1423 =============== Item was changed: ----- Method: RealEstateAgent class>>assignCollapseFrameFor: (in category 'utilities') ----- assignCollapseFrameFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid verticalBorderDistance horizontalBorderDistance otherFrames viewBox collapsedFrame extent top column countInColumn topLeft newFrame row rowLeft rowFrame | + grid := 8 px. + verticalBorderDistance := 8 px. + horizontalBorderDistance := 8 px. + - | grid otherFrames topLeft viewBox collapsedFrame extent newFrame verticalBorderDistance top | - grid := 8. - verticalBorderDistance := 8. aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | w ~= aSSView]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view ~= aSSView ifTrue: [aController view collapsedFrame]] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. collapsedFrame := aSSView collapsedFrame. extent := collapsedFrame notNil ifTrue: [collapsedFrame extent] ifFalse: [aSSView isMorph + ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2 px)] + ifFalse: [(aSSView labelText extent x + 70 px) @ aSSView labelHeight - ifTrue: [aSSView getRawLabel width + aSSView labelWidgetAllowance @ (aSSView labelHeight + 2)] - ifFalse: [(aSSView labelText extent x + 70) @ aSSView labelHeight min: aSSView labelDisplayBox extent]]. collapsedFrame notNil ifTrue: [(otherFrames anySatisfy: [:f | collapsedFrame intersects: f]) ifFalse: ["non overlapping" ^ collapsedFrame]]. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [top := viewBox top + verticalBorderDistance. + countInColumn := 0. + [topLeft := viewBox left @ top. + newFrame := topLeft extent: extent. + newFrame bottom <= (viewBox height - verticalBorderDistance)] + whileTrue: + [row := otherFrames select: [:w | newFrame intersects: w]. + column > 0 ifFalse: [rowFrame := newFrame] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + horizontalBorderDistance. + rowFrame := newFrame translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | rowFrame intersects: w]]. + (viewBox containsRect: rowFrame) ifTrue: [ + row ifEmpty: ["no overlap" + ^ rowFrame]. + countInColumn := countInColumn + 1]. + top := top + grid]. + column := column + 1]. + + "If all else fails... (really too many wins here)" - top := viewBox top + verticalBorderDistance. - [topLeft := viewBox left @ top. - newFrame := topLeft extent: extent. - newFrame bottom <= (viewBox height - verticalBorderDistance)] - whileTrue: - [(otherFrames anySatisfy: [:w | newFrame intersects: w]) - ifFalse: ["no overlap" - ^ newFrame]. - top := top + grid]. - "If all else fails... (really to many wins here)" aSSView isMorph ifTrue:[ Project current showWorldMainDockingBar ifTrue:[^ (0 @ Project current world mainDockingBars first height) extent: extent]]. ^ 0 @ 0 extent: extent! Item was changed: ----- Method: RealEstateAgent class>>assignCollapsePointFor: (in category 'utilities') ----- assignCollapsePointFor: aSSView "Offer up a location along the left edge of the screen for a collapsed SSView. Make sure it doesn't overlap any other collapsed frames." + | grid otherFrames viewBox column countInColumn y row topLeft currentRowLeft rowLeft | + grid := 24 px. "should be mult of 8, since manual move is gridded by 8 px" - | grid otherFrames y free topLeft viewBox | - grid := 24. "should be mult of 8, since manual move is gridded by 8" aSSView isMorph ifTrue: [otherFrames := (SystemWindow windowsIn: aSSView world satisfying: [:w | true]) collect: [:w | w collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := self maximumUsableAreaInWorld: aSSView world] ifFalse: [otherFrames := ScheduledControllers scheduledWindowControllers collect: [:aController | aController view collapsedFrame] thenSelect: [:rect | rect notNil]. viewBox := Display boundingBox]. + otherFrames sort: [:w | w right] ascending. + + column := 0. + countInColumn := nil. + [countInColumn = 0] + whileFalse: + [y := viewBox top. + countInColumn := 0. + [(y := y + grid) <= (viewBox height - grid)] + whileTrue: + [topLeft := viewBox left@y. + row := otherFrames select: [:w | topLeft = w topLeft]. + column > 0 ifFalse: [currentRowLeft := topLeft] ifTrue: [ + rowLeft := ((otherFrames collect: [:w | w right]) take: column) last + grid. + currentRowLeft := topLeft translateBy: (rowLeft @ 0). + row := otherFrames select: [:w | currentRowLeft = w topLeft]]. + (viewBox containsPoint: topLeft) ifTrue: [ + row ifEmpty: ["no overlap" + ^ topLeft]. + countInColumn := countInColumn + 1]]. + column := column + 1]. + - y := viewBox top. - [(y := y + grid) <= (viewBox height - grid)] - whileTrue: - [topLeft := viewBox left@y. - free := true. - otherFrames do: [:w | free := free & (topLeft ~= w topLeft)]. - free ifTrue: [^ topLeft]]. "If all else fails..." ^ 0 @ 0!

6 14

Your suggestions for uuseful Preferences?
by rabbit 05 Sep '23

05 Sep '23

I am trying to figure my proper environment Preferences. I'm grateful for your suggestions. Here's my list so far... > enable <Update from server at startup> > enable <Open Tools Attached to Mouse Cursor> > enable <Use colorful windows> > enable <Click on label to edit> > enable <Extra debugger buttons> > disable <Use Soft Drop Shadow> -- ••• rabbit ❤️‍🔥🐰

7 20

[BUG] Tree browsers lose unaccepted methods in several cases
by christoph.thiede＠student.hpi.uni-potsdam.de 04 Sep '23

04 Sep '23

Hi Marcel, hi all, here is a couple of simple way to reproduce: Browse a class in the tree browser. Select message category A. Start typing a method but do not yet accept it ('myMethod ^self greatNewInvention...') Turn on mouseOverForKeyboardFocus, hover the message category list, press arrow up/down to select a different category. Oh no! Your new unaccepted method is lost! Other triggers of this bug include removing the currently selected message category in a tree browser from a second browser (or adding the first category which will remoev the default 'no messages' category). Quickfix to recover your changes (maybe): String allSubInstances select: [:ea | ea includesSubstring: 'greatNewInvention']. Insights from my examination: There is a missing #okToChange in Browser>>selectMessageCategoryNamed:. The bug does not occur when selecting a different category through the mouse because PluggableListMorph and SimpleHierarchicalListMorph send #okToChange to the model before handling mouse click events. PluggableListMorph also sends this for keyboard events (such as keyDown), but SimpleHierarchicalListMorph doesn't. When the selection is triggered programmatically, e.g., through #updateCodePaneIfNeeded, neither sends #okToChange first. So, how can we fix this? I think we should be sure to send #okToChange prior to all selection changes in browsers. We should not rely on the widget to send this in any case, flag existing uses with a comment, and maybe ultimately remove these sends. Sending #okToChange from the widgets seems to be bad style to me - it is hard to discover, existing triggers such as user interactions vs programmatic events are disputable, and importantly, this style introduces global state. I think I have also seen more than one model in the past where I was spammed with irrelevant 'Is it OK to cancel those changes?' messages because the actual interaction would not actually cancel any changes, but I unfortunately can't find these right now. Best, Christoph --- Sent from Squeak Inbox Talk

2 5

The Inbox: Morphic-ct.2125.mcz
by commits＠source.squeak.org 01 Sep '23

01 Sep '23

Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.2125.mcz ==================== Summary ==================== Name: Morphic-ct.2125 Author: ct Time: 27 August 2023, 4:39:22.523324 pm UUID: 610cd311-cf21-c844-a7da-678a093aee91 Ancestors: Morphic-ct.2124 Revises #insertTextReplacement proposal for PluggableTextMorph by moving the insertion logic to TextEditor. Indeed an ancestor of Morphic-ct.2124. =============== Diff against Morphic-ct.2124 =============== Item was changed: ----- Method: PluggableTextMorph>>insertText:from:to:invisibly: (in category 'transcript') ----- insertText: newText from: start to: stop invisibly: invisibly + invisibly + ifTrue: [ + textMorph editor insertText: newText from: start to: stop invisibly: invisibly. + textMorph selectionChanged. + textMorph updateFromParagraph. + self rememberSelectionInterval] + ifFalse: [self handleEdit: [ + textMorph editor insertText: newText from: start to: stop invisibly: invisibly]]. - | priorSelection priorHadUnacceptedEdits | - priorSelection := self selectionInterval. - self selectInvisiblyFrom: start to: stop. - priorHadUnacceptedEdits := self hasUnacceptedEdits. - textMorph editor restoreEmphasisHereAfter: [ - textMorph editor setEmphasisHere. - self replaceSelectionWith: newText]. - - invisibly ifFalse: [^ self]. - - "cover all our tracks" - self hasUnacceptedEdits: priorHadUnacceptedEdits. - - "Restore previous selection. Also update it if behind insertion." - priorSelection start >= start ifTrue: [ - priorSelection := priorSelection start + newText size - (stop - start) - 1 to: priorSelection stop]. - priorSelection stop >= start ifTrue: [ - priorSelection := priorSelection start to: priorSelection stop + newText size - (stop - start) - 1]. - self selectInvisiblyFrom: priorSelection start to: priorSelection stop. - textMorph selectionChanged. - textMorph updateFromParagraph. - self rememberSelectionInterval. - self flag: #todo. "Also preserve scroll position (which is NOT identical to the selection), so that insertions at the beginning do not interrupt the user further down in the text. This is rarely visible to the user, but should ultimately be done."! Item was added: + ----- Method: TextEditor>>insertText:from:to:invisibly: (in category 'accessing') ----- + insertText: newText from: start to: stop invisibly: invisibly + + | priorSelection | + priorSelection := self selectionInterval. + self selectInvisiblyFrom: start to: stop. + + self restoreEmphasisHereAfter: [ + self setEmphasisHere. + self replaceSelectionWith: newText invisibly: invisibly]. + + invisibly ifFalse: [^ self]. + + "Restore previous selection. Also update it if behind insertion." + priorSelection start >= start ifTrue: [ + priorSelection := priorSelection start + newText size - (stop - start) - 1 to: priorSelection stop]. + priorSelection stop >= start ifTrue: [ + priorSelection := priorSelection start to: priorSelection stop + newText size - (stop - start) - 1]. + self selectInvisiblyFrom: priorSelection start to: priorSelection stop.! Item was changed: ----- Method: TextEditor>>replaceSelectionWith: (in category 'undo') ----- replaceSelectionWith: aText - "Remember the selection text in UndoSelection. - Deselect, and replace the selection text by aText. - Remember the resulting selectionInterval in UndoInterval and PriorInterval. - Set up undo to use UndoReplace." + ^ self replaceSelectionWith: aText invisibly: false! - self openTypeIn. - self zapSelectionWith: aText. - self closeTypeIn.! Item was added: + ----- Method: TextEditor>>replaceSelectionWith:invisibly: (in category 'undo') ----- + replaceSelectionWith: aText invisibly: invisibly + "Remember the selection text in UndoSelection. + Deselect, and replace the selection text by aText. + Remember the resulting selectionInterval in UndoInterval and PriorInterval. + Set up undo to use UndoReplace. + Unless invisibly, notify the text morph about the change." + + self openTypeIn. + self zapSelectionWith: aText invisibly: invisibly. + self closeTypeIn.! Item was changed: ----- Method: TextEditor>>zapSelectionWith: (in category 'mvc compatibility') ----- zapSelectionWith: replacement + ^ self zapSelectionWith: replacement invisibly: false! - | start stop rep | - morph readOnly ifTrue: [^ self]. - start := self startIndex. - stop := self stopIndex. - (replacement isEmpty and: [stop > start]) ifTrue: [ - "If deleting, then set emphasisHere from 1st character of the deletion" - emphasisHere := (self text attributesAt: start) select: [:att | att mayBeExtended]]. - (start = stop and: [ replacement isEmpty ]) ifFalse: [ - morph plainTextOnly - ifTrue: [ - "We support TextAlignment but nothing else. Rely on emphasisHere." - rep := Text string: replacement asString attributes: emphasisHere ] - ifFalse: [ replacement isText - ifTrue: [ rep := replacement] - ifFalse: [ rep := Text string: replacement attributes: emphasisHere ] ]. - - self text replaceFrom: start to: stop - 1 with: rep. - paragraph - recomposeFrom: start - to: start + rep size - 1 - delta: rep size - (stop-start). - self markIndex: start pointIndex: start + rep size. - otherInterval := self selectionInterval]. - - self userHasEdited " -- note text now dirty"! Item was added: + ----- Method: TextEditor>>zapSelectionWith:invisibly: (in category 'mvc compatibility') ----- + zapSelectionWith: replacement invisibly: invisibly + + | start stop rep | + morph readOnly ifTrue: [^ self]. + start := self startIndex. + stop := self stopIndex. + (replacement isEmpty and: [stop > start]) ifTrue: [ + "If deleting, then set emphasisHere from 1st character of the deletion" + emphasisHere := (self text attributesAt: start) select: [:att | att mayBeExtended]]. + (start = stop and: [ replacement isEmpty ]) ifFalse: [ + morph plainTextOnly + ifTrue: [ + "We support TextAlignment but nothing else. Rely on emphasisHere." + rep := Text string: replacement asString attributes: emphasisHere ] + ifFalse: [ replacement isText + ifTrue: [ rep := replacement] + ifFalse: [ rep := Text string: replacement attributes: emphasisHere ] ]. + + self text replaceFrom: start to: stop - 1 with: rep. + paragraph + recomposeFrom: start + to: start + rep size - 1 + delta: rep size - (stop-start). + self markIndex: start pointIndex: start + rep size. + otherInterval := self selectionInterval]. + + invisibly ifFalse: [ + self userHasEdited " -- note text now dirty"].!

3 2

Review Request: noUNCPaths
by christoph.thiede＠student.hpi.uni-potsdam.de 31 Aug '23

31 Aug '23

Repairs FileDirectory>>#exists for long paths (> 260 characters) on Windows by well-defining an edge case in the Windows implementation of the FilePlugin primitiveDirectoryEntry, that is, to specify a single dot (.) as the file name. Documents the present limitations to syntactic sugar in long file paths in the platform code, the relevant plugin methods, and on the image side of Squeak Trunk. An alternative consideration was to rewrite FileDirectory>>#exists to pass an empty string as file name to the primitive instead of modifying the VM, but strictly speaking, even this would have exploited an undefined behavior in the VM plugin, and an empty file name would be less idiomatic than a single dot. For the original bug report, see: https://github.com/hpi-swa-teaching/Morphic-Testing-Framework/issues/13 Thanks to Marcel (mt) for his support! Signed-off-by: Christoph Thiede <christoph.thiede(a)student.hpi.de> --- Note that this mail contains both a git diff for the changes in the opensmalltalk-vm repository and a changeset for the changes in the Squeak Trunk so that they may be reviewed together. Any feedback on this formatting approach will be appreciated. Excited to receive your review! platforms/win32/vm/sqWin32Directory.c | 29 +++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/platforms/win32/vm/sqWin32Directory.c b/platforms/win32/vm/sqWin32Directory.c index 2b3d090ec..0aa5c2108 100644 --- a/platforms/win32/vm/sqWin32Directory.c +++ b/platforms/win32/vm/sqWin32Directory.c @@ -196,6 +196,15 @@ sqInt dir_Lookup(char *pathString, sqInt pathLength, sqInt index, /* Lookup the index-th entry of the directory with the given path, starting at the root of the file system. Set the name, name length, creation date, creation time, directory flag, and file size (if the entry is a file). + + Note that, due to restrictions by the operating system, this method only + has limited support for paths longer than 260 characters. In the case of + longer paths, they must not contain syntactic sugar such as ".", "..", or + "a/b".* For more details, see: + https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#paths + *) Long paths are automatically converted into UNC paths, which only + support a subset of the normal path syntax. + Return: 0 if a entry is found at the given index 1 if the directory has fewer than index entries @@ -354,6 +363,20 @@ sqInt dir_EntryLookup(char *pathString, sqInt pathLength, char* nameString, sqIn /* Lookup a given file in a given named directory. Set the name, name length, creation date, creation time, directory flag, and file size (if the entry is a file). + + Note that, due to restrictions by the operating system, this method only + has limited support for paths longer than 260 characters (for the full + path concatenated from the directory path, a backslash, and the file + name). In the case of longer paths, neither the path nor the file name + must contain syntactic sugar such as ".", "..", or "a/b".* However, this + method defines a single (!) convention for passing nameString as ".", + which is also supported for long paths. This convention is provided for + an efficient existence check of the directory (e.g., + FileDirectory>>#exists). For more details, see: + https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#paths + *) Long paths are automatically converted into UNC paths, which only + support a subset of the normal path syntax. + Return: 0 if found (a file or directory 'nameString' exists in directory 'pathString') 1 if the directory has no such entry @@ -416,6 +439,12 @@ sqInt dir_EntryLookup(char *pathString, sqInt pathLength, char* nameString, sqIn fullPath=(char *)calloc(fullPathLength,sizeof(char)); memcpy(fullPath,pathString,pathLength); if (pathString[pathLength-1] != '\\') fullPath[pathLength]='\\'; + if (nameStringLength == 1 && nameString[0] == '.') { + /* special syntax: "." is the current directory. Trim it from the full + path to avoid generating a UNC path with an unresolved ".", which is + not supported there. See comment above. */ + nameStringLength = 0; + } memcpy(fullPath+fullPathLength-nameStringLength,nameString,nameStringLength); /* convert the path name into a null-terminated C string */ -- 2.37.3.windows.1 =============== Summary =============== Change Set: noUNCPaths Date: 30 November 2022 Author: Christoph Thiede Documents the present limitations to syntactic sugar in long file paths in the relevant plugin methods and on the image side. For the original bug report, see: https://github.com/hpi-swa-teaching/Morphic-Testing-Framework/issues/13 Thanks to Marcel (mt) for his support! =============== Diff =============== FileDirectory>>primLookupEntryIn:index: {private} · ct 11/29/2022 20:24 (changed) primLookupEntryIn: fullPath index: index "Look up the index-th entry of the directory with the given fully-qualified path (i.e., starting from the root of the file hierarchy) and return an array containing: <name> <creationTime> <modificationTime> <dirFlag> <fileSize> The empty string enumerates the top-level files or drives. (For example, on Unix, the empty path enumerates the contents of '/'. On Macs and PCs, it enumerates the mounted volumes/drives.) + Note that in general, fullPath must not contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters. See the comment in the primitive implementation for more details. The creation and modification times are in seconds since the start of the Smalltalk time epoch. DirFlag is true if the entry is a directory. FileSize the file size in bytes or zero for directories. The primitive returns nil when index is past the end of the directory. It fails if the given path is bad." <primitive: 'primitiveDirectoryLookup' module: 'FilePlugin'> ^ #badDirectoryPath FileDirectory>>primLookupEntryIn:name: {private} · ct 11/30/2022 15:38 (changed) primLookupEntryIn: fullPath name: fName - "Look up <fName> (a simple file name) in the directory identified by <fullPath> and return an array containing: <fName> <creationTime> <modificationTime> <dirFlag> <fileSize> On Unix, the empty path denotes '/'. On Macs and PCs, it is the container of the system volumes.) + Note that in general, neither fullPath nor fName must contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters (for the full path concatenated from the directory path, a backslash, and the file name). As a single (!) exception, the file name may always be a single dot ('.'), which is supported for an efficient existence test of the directory path (e.g., FileDirectory>>#exists). See the comment in the primitive implementation for more details. The creation and modification times are in seconds since the start of the Smalltalk time epoch. DirFlag is true if the entry is a directory. FileSize the file size in bytes or zero for directories. The primitive returns nil when index is past the end of the directory. It fails if the given path is bad." <primitive: 'primitiveDirectoryEntry' module: 'FilePlugin'> ^ #primFailed "to distinguish from nil" FilePlugin>>primitiveDirectoryEntry {directory primitives} · ct 11/30/2022 15:13 (changed) primitiveDirectoryEntry "Two arguments - directory path, and simple file name; returns an array (see primitiveDirectoryLookup) describing the file or directory, or nil if it does not exist. + + Note that in general, neither the directory path nor the file name must + contain syntactic sugar for the current platform (e.g., '.' or '..', or on + Windows, forward slashes instead of backslashes). These conventions are + only fully supported on Unix platforms; on Windows, they are only + supported for short non-UNC file paths containing max 260 characters (for + the full path concatenated from the directory path, a backslash, and the + file name). As a single (!) exception, the file name may always be a + single dot ('.'), which is supported for an efficient existence test of + the directory path (e.g., FileDirectory>>#exists). See the comment in + sqWin32Directory.c for more details. + Primitive fails if the outer path does not identify a readable directory. (This is a lookup-by-name variant of primitiveDirectoryLookup.)" | requestedName pathName pathNameIndex pathNameSize status entryName entryNameSize createDate modifiedDate dirFlag posixPermissions symlinkFlag fileSize okToList reqNameIndex reqNameSize | <var: 'entryName' declareC: 'char entryName[256]'> <var: 'pathNameIndex' type: #'char *'> <var: 'reqNameIndex' type: #'char *'> <var: 'fileSize' type: #squeakFileOffsetType> <export: true> requestedName := interpreterProxy stackValue: 0. pathName := interpreterProxy stackValue: 1. (interpreterProxy isBytes: pathName) ifFalse: [^interpreterProxy primitiveFail]. "Outbound string parameters" pathNameIndex := interpreterProxy firstIndexableField: pathName. pathNameSize := interpreterProxy byteSizeOf: pathName. reqNameIndex := interpreterProxy firstIndexableField: requestedName. reqNameSize := interpreterProxy byteSizeOf: requestedName. self cCode: '' inSmalltalk: [entryName := ByteString new: 256. entryNameSize := createDate := modifiedDate := dirFlag := fileSize := posixPermissions := symlinkFlag := nil]. "If the security plugin can be loaded, use it to check for permission. If not, assume it's ok" okToList := sCLPfn ~= 0 ifTrue: [self cCode: '((sqInt (*)(char *, sqInt))sCLPfn)(pathNameIndex, pathNameSize)' inSmalltalk: [true]] ifFalse: [true]. status := okToList ifTrue: [self dir_EntryLookup: pathNameIndex _: pathNameSize _: reqNameIndex _: reqNameSize _: entryName _: (self addressOf: entryNameSize put: [:v| entryNameSize := v]) _: (self addressOf: createDate put: [:v| createDate := v]) _: (self addressOf: modifiedDate put: [:v| modifiedDate := v]) _: (self addressOf: dirFlag put: [:v| dirFlag := v]) _: (self addressOf: fileSize put: [:v| fileSize := v]) _: (self addressOf: posixPermissions put: [:v| posixPermissions := v]) _: (self addressOf: symlinkFlag put: [:v| symlinkFlag := v])] ifFalse: [DirNoMoreEntries]. interpreterProxy failed ifTrue: [^nil]. status = DirNoMoreEntries ifTrue: "no entry; return nil" [interpreterProxy "pop pathName, index, rcvr" pop: 3 thenPush: interpreterProxy nilObject. ^nil]. status = DirBadPath ifTrue: [^interpreterProxy primitiveFail]."bad path" interpreterProxy pop: 3 "pop pathName, index, rcvr" thenPush: (self cppIf: PharoVM ifTrue: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize posixPermissions: posixPermissions isSymlink: symlinkFlag] ifFalse: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize]) FilePlugin>>primitiveDirectoryLookup {directory primitives} · ct 11/30/2022 15:00 (changed) primitiveDirectoryLookup + "Two arguments - directory path, and an index to an item; returns an array (see primitiveDirectoryLookup) describing the file or directory, or nil if it does not exist. + + Note that in general, the directory path must not contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters. See the comment in sqWin32Directory.c for more details. + + Primitive fails if the outer path does not identify a readable directory. (For a lookup-by-name variant, see primitiveDirectoryEntry.)" | index pathName pathNameIndex pathNameSize status entryName entryNameSize createDate modifiedDate dirFlag symlinkFlag posixPermissions fileSize okToList | <var: 'entryName' declareC: 'char entryName[256]'> <var: 'pathNameIndex' type: #'char *'> <var: 'fileSize' type: #squeakFileOffsetType> <export: true> index := interpreterProxy stackIntegerValue: 0. pathName := interpreterProxy stackValue: 1. (interpreterProxy isBytes: pathName) ifFalse: [^interpreterProxy primitiveFail]. pathNameIndex := interpreterProxy firstIndexableField: pathName. pathNameSize := interpreterProxy byteSizeOf: pathName. self cCode: '' inSmalltalk: [entryName := ByteString new: 256. entryNameSize := createDate := modifiedDate := dirFlag := fileSize := posixPermissions := symlinkFlag := nil]. "If the security plugin can be loaded, use it to check for permission. If not, assume it's ok" okToList := sCLPfn ~= 0 ifTrue: [self cCode: '((sqInt (*)(char *, sqInt))sCLPfn)(pathNameIndex, pathNameSize)' inSmalltalk: [true]] ifFalse: [true]. status := okToList ifTrue: [self dir_Lookup: pathNameIndex _: pathNameSize _: index _: entryName _: (self addressOf: entryNameSize put: [:v| entryNameSize := v]) _: (self addressOf: createDate put: [:v| createDate := v]) _: (self addressOf: modifiedDate put: [:v| modifiedDate := v]) _: (self addressOf: dirFlag put: [:v| dirFlag := v]) _: (self addressOf: fileSize put: [:v| fileSize := v]) _: (self addressOf: posixPermissions put: [:v| posixPermissions := v]) _: (self addressOf: symlinkFlag put: [:v| symlinkFlag := v])] ifFalse: [DirNoMoreEntries]. interpreterProxy failed ifTrue: [^nil]. status = DirNoMoreEntries ifTrue: "no more entries; return nil" [interpreterProxy "pop pathName, index, rcvr" pop: 3 thenPush: interpreterProxy nilObject. ^nil]. status = DirBadPath ifTrue: [^interpreterProxy primitiveFail]."bad path" interpreterProxy pop: 3 "pop pathName, index, rcvr" thenPush: (self cppIf: PharoVM ifTrue: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize posixPermissions: posixPermissions isSymlink: symlinkFlag] ifFalse: [self makeDirEntryName: entryName size: entryNameSize createDate: createDate modDate: modifiedDate isDir: dirFlag fileSize: fileSize]) --- Sent from Squeak Inbox Talk ["noUNCPaths.3.cs"]

3 5

The Trunk: Files-mt.205.mcz
by commits＠source.squeak.org 31 Aug '23

31 Aug '23

Marcel Taeumel uploaded a new version of Files to project The Trunk: http://source.squeak.org/trunk/Files-mt.205.mcz ==================== Summary ==================== Name: Files-mt.205 Author: mt Time: 31 August 2023, 2:45:15.602117 pm UUID: f266e8ba-65e3-6c43-9f32-cb92acce32ab Ancestors: Files-mt.204 Adds commentary for path-lookup edge case on Windows platform. For the changed win32 platform code, see OSVM commit 330d6779ad2ecbce1f07131f53d75cd168165f0b Complements VMMaker.oscog-mt.3336 (only commentary) =============== Diff against Files-mt.204 =============== Item was changed: FileDirectory subclass: #DosFileDirectory instanceVariableNames: '' classVariableNames: '' poolDictionaries: '' category: 'Files-Directories'! + !DosFileDirectory commentStamp: 'ct 8/17/2023 13:25' prior: 0! + I represent a DOS or Windows FileDirectory. Paths follow the usual syntax for Microsoft Windows, including a length limit to 260 characters. Above these limit, the VM falls back to UNC paths, which however do not support syntactic sugar in paths such as '.', '..', or forward slashes instead of backward slashes. See examples in my primitive methods. Thus, any primitive call for a possibly long path should not contain such syntactic sugar. Perspectively, this class should wipe out all this sugar during construction (normalization).! - !DosFileDirectory commentStamp: '<historical>' prior: 0! - I represent a DOS or Windows FileDirectory. - ! Item was changed: ----- Method: FileDirectory>>primLookupEntryIn:index: (in category 'private') ----- primLookupEntryIn: fullPath index: index "Look up the index-th entry of the directory with the given fully-qualified path (i.e., starting from the root of the file hierarchy) and return an array containing: <name> <creationTime> <modificationTime> <dirFlag> <fileSize> The empty string enumerates the top-level files or drives. (For example, on Unix, the empty path enumerates the contents of '/'. On Macs and PCs, it enumerates the mounted volumes/drives.) + Note that in general, fullPath must not contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters: + DON'T: self primLookupEntryIn: '<very long path>\foo\.' index: ... + DON'T: self primLookupEntryIn: '<very long path>\foo\..' index: ... + DON'T (on Windows): self primLookupEntryIn: '<very long path>\foo/bar' index: ... + See the comment in the primitive implementation for more details. The creation and modification times are in seconds since the start of the Smalltalk time epoch. DirFlag is true if the entry is a directory. FileSize the file size in bytes or zero for directories. The primitive returns nil when index is past the end of the directory. It fails if the given path is bad." <primitive: 'primitiveDirectoryLookup' module: 'FilePlugin'> ^ #badDirectoryPath ! Item was changed: ----- Method: FileDirectory>>primLookupEntryIn:name: (in category 'private') ----- primLookupEntryIn: fullPath name: fName - "Look up <fName> (a simple file name) in the directory identified by <fullPath> and return an array containing: <fName> <creationTime> <modificationTime> <dirFlag> <fileSize> On Unix, the empty path denotes '/'. On Macs and PCs, it is the container of the system volumes.) + Note that in general, neither fullPath nor fName must contain syntactic sugar for the current platform (e.g., '.' or '..', or on Windows, forward slashes instead of backslashes). These conventions are only fully supported on Unix platforms; on Windows, they are only supported for short non-UNC file paths containing max 260 characters (for the full path concatenated from the directory path, a backslash, and the file name). As a single (!!) exception, the file name may always be a single dot ('.'), which is supported for an efficient existence test of the directory path (e.g., FileDirectory>>#exists): + DON'T: self primLookupEntryIn: '<very long path>' name: 'plonk\.'. + DON'T: self primLookupEntryIn: '<very long path>' name: 'plonk\..'. + DON'T (on Windows): self primLookupEntryIn: '<very long path>' name: 'foo/bar'. + DO: self primLookupEntryIn: '<very long path>' name: '.'. + See the comment in the primitive implementation for more details. The creation and modification times are in seconds since the start of the Smalltalk time epoch. DirFlag is true if the entry is a directory. FileSize the file size in bytes or zero for directories. The primitive returns nil when index is past the end of the directory. It fails if the given path is bad." <primitive: 'primitiveDirectoryEntry' module: 'FilePlugin'> ^ #primFailed "to distinguish from nil" !

1 0

The Trunk: Tools-mt.1232.mcz
by commits＠source.squeak.org 31 Aug '23

31 Aug '23

Marcel Taeumel uploaded a new version of Tools to project The Trunk: http://source.squeak.org/trunk/Tools-mt.1232.mcz ==================== Summary ==================== Name: Tools-mt.1232 Author: mt Time: 31 August 2023, 10:57:48.647282 am UUID: a15547f2-e8b3-8b49-baa9-209cd1837d93 Ancestors: Tools-eem.1231 Use #px for magic (pixel-based) numbers. Complements Graphics-mt.544 =============== Diff against Tools-eem.1231 =============== Item was changed: ----- Method: Browser>>buildSwitchesWith: (in category 'toolbuilder') ----- buildSwitchesWith: builder "Build the instance/comment/class switch" | panelSpec i q c | panelSpec := builder pluggablePanelSpec new name: #switches; layout: #horizontal; + spacing: -1 px; - spacing: (-1 * RealEstateAgent scaleFactor) truncated; children: OrderedCollection new; yourself. i := builder pluggableButtonSpec new. i model: self; label: 'instance'; help: 'Show instance-side methods' translated; state: #instanceMessagesIndicated; action: #indicateInstanceMessages. q := builder pluggableButtonSpec new. q model: self; horizontalResizing: #shrinkWrap; label: '?'; help: 'Cycle between definition, comment, and hierarchy view' translated; state: #classCommentIndicated; action: #plusButtonHit. c := builder pluggableButtonSpec new. c model: self; label: 'class'; help: 'Show class-side methods' translated; state: #classMessagesIndicated; action: #indicateClassMessages. panelSpec children addAll: { i. c. builder pluggableSpacerSpec new. q }. ^panelSpec!

1 0

The Trunk: ToolBuilder-Morphic-mt.347.mcz
by commits＠source.squeak.org 31 Aug '23

31 Aug '23

Marcel Taeumel uploaded a new version of ToolBuilder-Morphic to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Morphic-mt.347.mcz ==================== Summary ==================== Name: ToolBuilder-Morphic-mt.347 Author: mt Time: 31 August 2023, 10:57:02.932282 am UUID: d3fcbb4b-d3e0-2740-bdc9-f8b1b81b08a1 Ancestors: ToolBuilder-Morphic-mt.346 Use #px for magic (pixel-based) numbers. Complements Graphics-mt.544 =============== Diff against ToolBuilder-Morphic-mt.346 =============== Item was changed: ----- Method: MorphicToolBuilder>>buttonRowHeight (in category 'layout hints') ----- buttonRowHeight | multiplier | ButtonMargins ifNil: [ ButtonMargins := (PluggableButtonMorph labelMargins ifNil: [0] ifNotNil: [:margins | margins isRectangle ifTrue: [margins top + margins bottom] ifFalse: [margins isPoint ifTrue: [margins y + margins y] ifFalse: [margins + margins]]]) ]. multiplier := MorphicProject useCompactButtons ifTrue: [1.0] ifFalse: [1.6]. + ButtonBorderWidth ifNil: [ButtonBorderWidth := ((UserInterfaceTheme current get: #borderWidth for: PluggableTextMorph) ifNil: [1]) px * 2]. - ButtonBorderWidth ifNil: [ButtonBorderWidth := (((UserInterfaceTheme current get: #borderWidth for: PluggableTextMorph) ifNil: [1]) * RealEstateAgent scaleFactor) truncated * 2]. ^ (Preferences standardButtonFont lineGrid asFloat * multiplier) truncated "already includes the system's current #scaleFactor" + ButtonMargins "already includes the system's current #scaleFactor" + ButtonBorderWidth! Item was changed: ----- Method: MorphicToolBuilder>>listHeightFor: (in category 'layout hints') ----- listHeightFor: numLines ListMargins ifNil: [ ListMargins := PluggableListMorph listMargins ifNil: [0] ifNotNil: [:margins | margins isRectangle ifTrue: [margins top + margins bottom] ifFalse: [margins isPoint ifTrue: [margins y + margins y] ifFalse: [margins + margins]]] ]. + ListBorderWidth ifNil: [ListBorderWidth := ((UserInterfaceTheme current get: #borderWidth for: PluggableTextMorph) ifNil: [1]) px * 2]. - ListBorderWidth ifNil: [ListBorderWidth := (((UserInterfaceTheme current get: #borderWidth for: PluggableTextMorph) ifNil: [1]) * RealEstateAgent scaleFactor) truncated * 2]. ^ (Preferences standardListFont lineGridForMorphs * numLines) "already includes the system's current #scaleFactor" + ListMargins "already includes the system's current #scaleFactor" + ListBorderWidth! Item was changed: ----- Method: MorphicToolBuilder>>textFieldHeightFor:font: (in category 'layout hints') ----- textFieldHeightFor: numLines font: font TextMargins ifNil: [ TextMargins := PluggableTextMorph textMargins ifNil: [0] ifNotNil: [:margins | margins isRectangle ifTrue: [margins top + margins bottom] ifFalse: [margins isPoint ifTrue: [margins y + margins y] ifFalse: [margins + margins]]] ]. + TextBorderWidth ifNil: [TextBorderWidth := ((UserInterfaceTheme current get: #borderWidth for: PluggableTextMorph) ifNil: [1]) px * 2]. - TextBorderWidth ifNil: [TextBorderWidth := (((UserInterfaceTheme current get: #borderWidth for: PluggableTextMorph) ifNil: [1]) * RealEstateAgent scaleFactor) truncated * 2]. ^ (font lineGrid * numLines) "already includes the system's current #scaleFactor" + TextMargins "already includes the system's current #scaleFactor" + TextBorderWidth!

1 0

The Trunk: ToolBuilder-Kernel-mt.167.mcz
by commits＠source.squeak.org 31 Aug '23

31 Aug '23

Marcel Taeumel uploaded a new version of ToolBuilder-Kernel to project The Trunk: http://source.squeak.org/trunk/ToolBuilder-Kernel-mt.167.mcz ==================== Summary ==================== Name: ToolBuilder-Kernel-mt.167 Author: mt Time: 31 August 2023, 10:56:31.795282 am UUID: b25d6c6f-f3bc-304b-ac54-154104953d02 Ancestors: ToolBuilder-Kernel-ct.166 Use #px for magic (pixel-based) numbers. Complements Graphics-mt.544 =============== Diff against ToolBuilder-Kernel-ct.166 =============== Item was changed: ----- Method: ToolBuilder>>dialogPadding (in category 'layout hints') ----- dialogPadding + ^ 4px! - ^ (4 "px" * RealEstateAgent scaleFactor) truncated! Item was changed: ----- Method: ToolBuilder>>dialogSpacing (in category 'layout hints') ----- dialogSpacing + ^ 4px! - ^ (4 "px" * RealEstateAgent scaleFactor) truncated! Item was changed: ----- Method: ToolBuilder>>panelSpacing (in category 'layout hints') ----- panelSpacing + ^ 2px! - ^ (2 "px" * RealEstateAgent scaleFactor) truncated! Item was changed: ----- Method: ToolBuilder>>windowPadding (in category 'layout hints') ----- windowPadding + ^ 4px! - ^ (4 "px" * RealEstateAgent scaleFactor) truncated! Item was changed: ----- Method: ToolBuilder>>windowSpacing (in category 'layout hints') ----- windowSpacing + ^ 4px! - ^ (4 "px" * RealEstateAgent scaleFactor) truncated!

1 0

The Trunk: PreferenceBrowser-mt.157.mcz
by commits＠source.squeak.org 31 Aug '23

31 Aug '23

Marcel Taeumel uploaded a new version of PreferenceBrowser to project The Trunk: http://source.squeak.org/trunk/PreferenceBrowser-mt.157.mcz ==================== Summary ==================== Name: PreferenceBrowser-mt.157 Author: mt Time: 31 August 2023, 10:56:04.456282 am UUID: 00d3c3db-cc9a-c14f-93ae-c97a4d555614 Ancestors: PreferenceBrowser-mt.156 Use #px for magic (pixel-based) numbers. Complements Graphics-mt.544 =============== Diff against PreferenceBrowser-mt.156 =============== Item was changed: ----- Method: PreferenceBrowser>>initialExtent (in category 'user interface') ----- initialExtent "Scale here because the receiver is not built through a tool builder. See #buildPluggableWindow:." self flag: #workaround. "Avoid overflowing items for the current set of preferences (ct 6/16/2022 14:33). In the future, we want to improve the layouting of the PreferenceBrowser instead. See: https://lists.squeakfoundation.org/pipermail/squeak-dev/2022-June/221107.ht…" + ^ 705px @ 440px! - ^ (705 @ 440 * RealEstateAgent scaleFactor) rounded! Item was changed: ----- Method: PreferenceBrowserMorph>>newSeparator (in category 'submorphs - buttons') ----- newSeparator ^ Morph new color: Color transparent; + width: 5px; - width: (5 * RealEstateAgent scaleFactor) truncated; vResizing: #spaceFill; yourself! Item was changed: ----- Method: PreferenceWizardMorph>>createButton (in category 'initialization - building') ----- createButton ^ PluggableButtonMorphPlus new setProperty: #noUserInterfaceTheme toValue: true; offColor: (self defaultColor adjustBrightness: 0.2); feedbackColor: (self defaultColor adjustBrightness: 0.4); model: self; font: (UserInterfaceTheme current get: #wizardButtonFont); textColor: self defaultTextColor; borderColor: self defaultTextColor; instVarNamed: #borderColor put: self defaultTextColor; "HACK!!" + borderWidth: 2px; - borderWidth: (2 * RealEstateAgent scaleFactor) truncated; cornerStyle: (self hasLowPerformance ifTrue: [#square] ifFalse: [#rounded]); vResizing: #shrinkWrap; hResizing: #shrinkWrap; layoutInset: self defaultButtonMargins; yourself! Item was changed: ----- Method: PreferenceWizardMorph>>createScrollPane (in category 'initialization - building') ----- createScrollPane | pane | pane := ScrollPane new setProperty: #noUserInterfaceTheme toValue: true; hScrollBarPolicy: #never; vScrollBarPolicy: #whenNeeded; borderWidth: 0; color: Color transparent; scrollBarThickness: self layoutInset; yourself. pane hResizing: #spaceFill; vResizing: #spaceFill. pane scroller changeTableLayout. pane scroller addMorph: (Morph new changeTableLayout; color: Color transparent; hResizing: #spaceFill; vResizing: #shrinkWrap; cellGap: self cellGap; layoutInset: (0@0 corner: self cellGap@0); yourself). pane vScrollBar setProperty: #noUserInterfaceTheme toValue: true; sliderColor: Color white. (pane vScrollBar instVarNamed: #slider) cornerStyle: (self hasLowPerformance ifTrue: [#square] ifFalse: [#rounded]); + borderWidth: 2px. - borderWidth: (2 * RealEstateAgent scaleFactor) truncated. (pane vScrollBar instVarNamed: #pagingArea) cornerStyle: (self hasLowPerformance ifTrue: [#square] ifFalse: [#rounded]). ^ pane! Item was changed: ----- Method: PreferenceWizardMorph>>displayScaleChangedBy: (in category 'display scale') ----- displayScaleChangedBy: factor isFullScreen == true ifTrue: [ self changedRadio. previewWorld submorphsDo: [:ea | ea isSystemWindow ifTrue: [ea displayScaleChangedBy: factor]]. self updateFromChangedScaleFactor. ^ self]. self layoutInset: (self defaultFont widthOf: $x) * 2; cellGap: (self defaultFont widthOf: $x). titleMorph font: (UserInterfaceTheme current get: #wizardTitleFont); margins: (self cellGap @ 0 corner: self cellGap @ self cellGap). self height: titleMorph height * 4. self updateLowPerformanceLabel: lowPerformanceMorph contents. { startButton . skipButton } do: [:button | button layoutInset: self defaultButtonMargins; + borderWidth: 2px; - borderWidth: (2 * RealEstateAgent scaleFactor) truncated; font: (UserInterfaceTheme current get: #wizardButtonFont); updateMinimumExtent "Font might not change but PPI did."]. (startButton minimumWidth max: skipButton minimumWidth) in: [:w | startButton hResizing: #rigid; width: w. skipButton hResizing: #rigid; width: w. startButton layoutFrame leftOffset: 2*w negated. skipButton layoutFrame rightOffset: 2*w]. self width: self world width. self center: self world center.! Item was changed: ----- Method: PreferenceWizardMorph>>initializePreviewWorld (in category 'initialization - playfield') ----- initializePreviewWorld Preferences enable: #systemWindowEmbedOK. previewWorld := PasteUpMorph new hResizing: #spaceFill; vResizing: #spaceFill; viewBox: (0@0 corner: 500@500); layoutFrame: (LayoutFrame fractions: (0.35 @ 0 corner: 1.0 @ 1.0) offsets: (0@ titleMorph height corner: 0 @ buttonRowMorph height negated)); fillStyle: Project current world fillStyle; + borderWidth: 2px; - borderWidth: (2 * RealEstateAgent scaleFactor) truncated; borderColor: Color white; cornerStyle: (self hasLowPerformance ifTrue: [#square] ifFalse: [#rounded]); yourself. self addOrReplaceBrowser; addOrReplaceSenders; addOrReplaceWorkspace; updateWindowBounds.! Item was changed: ----- Method: PreferenceWizardMorph>>updateFromChangedScaleFactor (in category 'display scale') ----- updateFromChangedScaleFactor checkmark := nil. radiomark := nil. self layoutInset: (self defaultFont widthOf: $x) * 2; cellGap: (self defaultFont widthOf: $x). titleMorph font: (UserInterfaceTheme current get: #wizardTitleFont); margins: (self cellGap @ 0 corner: self cellGap @ self cellGap). titleMorph layoutFrame bottomOffset: titleMorph height. self updateLowPerformanceLabel: lowPerformanceMorph contents. "buttons" {startButton. skipButton. previousButton. nextButton. doneButton}, (pages gather: [:page | page allMorphs select: [:ea | ea isButton]]) do: [:button | ((button owner hasProperty: #isRadioButton) or: [button owner hasProperty: #isCheckbox]) ifTrue: [ button "layoutInset: 0;" extent: (TextStyle defaultFont height * 1.75) asPoint; update: button getLabelSelector. button owner cellGap: (TextStyle defaultFont widthOf: $x). button owner balloonText ifNotNil: [:text | text addAttribute: (TextFontReference toFont: (UserInterfaceTheme current get: #wizardHelpFont))]] ifFalse: [ button layoutInset: self defaultButtonMargins]. button + borderWidth: 2px; - borderWidth: (2 * RealEstateAgent scaleFactor) truncated; font: (UserInterfaceTheme current get: #wizardButtonFont); updateMinimumExtent "Font might not change but PPI did."]. self fullBounds. (startButton minimumWidth max: skipButton minimumWidth) in: [:w | startButton hResizing: #rigid; width: w. skipButton hResizing: #rigid; width: w. startButton layoutFrame leftOffset: 2*w negated. skipButton layoutFrame rightOffset: 2*w]. (previousButton minimumWidth max: nextButton minimumWidth) in: [:w | previousButton hResizing: #rigid; width: w. nextButton hResizing: #rigid; width: w]. pagesLabel margins: (self layoutInset@0 corner: self layoutInset@0); font: (UserInterfaceTheme current get: #wizardStandardFont). buttonRowMorph cellGap: self cellGap; layoutInset: (0@self layoutInset corner: 0@0). buttonRowMorph layoutFrame topOffset: buttonRowMorph fullBounds height negated. "labels" {controlMorph firstSubmorph}, (pages gather: [:page | page allMorphs select: [:ea | ea isTextMorph]]) do: [:label | label font: (UserInterfaceTheme current get: #wizardStandardFont); margins: self defaultTextMargins "No need for #releaseParagraph because window resizing will happen anyway."]. "controlMorph" controlMorph layoutInset: (0@0 corner: self cellGap@0). controlMorph layoutFrame topOffset: titleMorph height; bottomOffset: buttonRowMorph height negated. "scroll panes in pages" pages do: [:page | | scrollPane | page layoutInset: (self layoutInset asPoint corner: self cellGap@0); cellGap: self cellGap. scrollPane := page submorphs second. scrollPane scrollBarThickness: self layoutInset. scrollPane scroller firstSubmorph cellGap: self cellGap; layoutInset: (0@0 corner: self cellGap@0). (scrollPane vScrollBar instVarNamed: #slider) + borderWidth: 2px]. - borderWidth: (2 * RealEstateAgent scaleFactor) truncated]. "previewWorld" previewWorld layoutFrame topOffset: titleMorph height; bottomOffset: buttonRowMorph height negated. + previewWorld borderWidth: 2px. - previewWorld borderWidth: (2 * RealEstateAgent scaleFactor) truncated. self bounds: self world bounds. self updateWindowBounds. self updatePageVisibility.! Item was changed: ----- Method: PreferenceWizardProgressMorph>>createProgressBar (in category 'as yet unclassified') ----- createProgressBar ^ SystemProgressBarMorph new extent: ((self defaultFont widthOf: $x) * 35) @ ((self defaultFont widthOf: $x) * 2); color: Color transparent; barColor: Color white; borderColor: Color white; + borderWidth: 2px; - borderWidth: (2 * RealEstateAgent scaleFactor) truncated; yourself !

1 0

← Newer
1
2
3
4
5
6
7
...
17
Older →

Jump to page: