Update 5569variableDefinitions, recently added to Squeak 3.7a, turns out to have broken Class>>addInstVarName:, which had relied on the presence of the extra trailing space in the variables-definition-string that Lukas's update had removed.
The attached fileout fixes this bug.
Cheers,
-- Scott
Scott Wallace scott.wallace@squeakland.org wrote:
Update 5569variableDefinitions, recently added to Squeak 3.7a, turns out to have broken Class>>addInstVarName:, which had relied on the presence of the extra trailing space in the variables-definition-string
Gulp. A trailing space is/was crucial? I _really_ don't like the sound of that.
tim -- Tim Rowledge, tim@sumeru.stanford.edu, http://sumeru.stanford.edu/tim When all else fails, let a = 7. If that doesn't help, then read the manual.
Update 5569variableDefinitions, recently added to Squeak 3.7a, turns out to have broken Class>>addInstVarName:, which had relied on the presence of the extra trailing space in the variables-definition-string
Gulp. A trailing space is/was crucial? I _really_ don't like the sound of that.
Why do you think the space is crucial? What I did with this fix was basically simplifying and unifying the code creating all those variable- declaration-strings and at the same time I removed that ugly space at the end, that I'm disliking since a long time.
While reading the Smalltalk-80 report I noticed that the space comes from that time and what is worse, it isn't even consistently used there, e.g. the template to create a new class hasn't got it. I think Squeak should go forward and not stay with old Smalltalk-80 style forever: I would actually even prefer to replace the strings with an array, I've never understood why there is a string used to declare variables:
Object subclass: #NameOfSubclass instanceVariableNames: #(ivar1 ivar2) classVariableNames: #(CVar1 CVar2) poolDictionaries: #() category: 'Category'
Cheers, Lukas
Hi lukas
I think that tim agreed with you. relying on a trailing space is clearly a not so robust idea :). Could you review the fix proposed by scott so that we smash this trailing space. Stef
On 27 déc. 03, at 22:59, Lukas Renggli wrote:
Update 5569variableDefinitions, recently added to Squeak 3.7a, turns out to have broken Class>>addInstVarName:, which had relied on the presence of the extra trailing space in the variables-definition-string
Gulp. A trailing space is/was crucial? I _really_ don't like the sound of that.
Why do you think the space is crucial? What I did with this fix was basically simplifying and unifying the code creating all those variable- declaration-strings and at the same time I removed that ugly space at the end, that I'm disliking since a long time.
While reading the Smalltalk-80 report I noticed that the space comes from that time and what is worse, it isn't even consistently used there, e.g. the template to create a new class hasn't got it. I think Squeak should go forward and not stay with old Smalltalk-80 style forever: I would actually even prefer to replace the strings with an array, I've never understood why there is a string used to declare variables:
Object subclass: #NameOfSubclass instanceVariableNames: #(ivar1 ivar2) classVariableNames: #(CVar1 CVar2) poolDictionaries: #() category: 'Category' Cheers, Lukas
-- Lukas Renggli http://renggli.freezope.org
squeak-dev@lists.squeakfoundation.org
-
ducasse -
Lukas Renggli -
ned＠squeakland.org -
Scott Wallace -
Tim Rowledge