A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1957.mcz
==================== Summary ====================
Name: Morphic-ct.1957 Author: ct Time: 1 April 2022, 3:58:43.713617 pm UUID: 73b0c9b3-ca79-9945-b668-d92a3548ae44 Ancestors: Morphic-ul.1956
While running step methods, have the world become active. Before, any step methods/deferred UI message would have triggered the #default case in ActiveEventVariable only.
=============== Diff against Morphic-ul.1956 ===============
Item was changed: ----- Method: PasteUpMorph>>runStepMethods (in category 'stepping') ----- runStepMethods
+ self becomeActiveDuring: [ + worldState runStepMethodsIn: self].! - worldState runStepMethodsIn: self - !
Hi Christoph --
+1 on the fix itself -1 on the implementation
This fits better in WorldState >> #doOneCycleNowFor:. Please ignore the few cases where clients invoke "displayWorldSafely; runStepMethods" manually.
Best, Marcel Am 01.04.2022 15:59:03 schrieb commits@source.squeak.org commits@source.squeak.org: A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1957.mcz
==================== Summary ====================
Name: Morphic-ct.1957 Author: ct Time: 1 April 2022, 3:58:43.713617 pm UUID: 73b0c9b3-ca79-9945-b668-d92a3548ae44 Ancestors: Morphic-ul.1956
While running step methods, have the world become active. Before, any step methods/deferred UI message would have triggered the #default case in ActiveEventVariable only.
=============== Diff against Morphic-ul.1956 ===============
Item was changed: ----- Method: PasteUpMorph>>runStepMethods (in category 'stepping') ----- runStepMethods
+ self becomeActiveDuring: [ + worldState runStepMethodsIn: self].! - worldState runStepMethodsIn: self - !
Hi Marcel,
thanks, merged via Morphic-ct.1988.
Please ignore the few cases where clients invoke "displayWorldSafely; runStepMethods" manually.
Hm, but it would be nice to fix them ... How could a nice solution for this look like?
For the new color picker morph that I'm "currently" (stuck a few months ago ...) reworking, I used event filters. But we still seem to lack a general, proper and simple concept for "modal queries in the interactive world".
It would be nice if these senders (ColorPickerMorph and PolygonMorph) could just use #doOneCycleNow, but this would also handle events, which is not okay. Qt has QEventLoop::ExcludeUserInputEvents [1] for this - should our #doOneCycleNow offer a similar parameter? Then we could also resize the host window etc. while picking a color. What do you think (except from the fact that we should fix this after 6.0)? :D
Best,
Christoph
[1] https://doc.qt.io/qt-5/qeventloop.html#:~:text=QEventLoop%3A%3A-,excludeuser...
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Taeumel, Marcel Gesendet: Freitag, 8. April 2022 10:36:26 An: squeak-dev Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1957.mcz
Hi Christoph --
+1 on the fix itself -1 on the implementation
This fits better in WorldState >> #doOneCycleNowFor:. Please ignore the few cases where clients invoke "displayWorldSafely; runStepMethods" manually.
Best, Marcel
Am 01.04.2022 15:59:03 schrieb commits@source.squeak.org commits@source.squeak.org:
A new version of Morphic was added to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1957.mcz
==================== Summary ====================
Name: Morphic-ct.1957 Author: ct Time: 1 April 2022, 3:58:43.713617 pm UUID: 73b0c9b3-ca79-9945-b668-d92a3548ae44 Ancestors: Morphic-ul.1956
While running step methods, have the world become active. Before, any step methods/deferred UI message would have triggered the #default case in ActiveEventVariable only.
=============== Diff against Morphic-ul.1956 ===============
Item was changed: ----- Method: PasteUpMorph>>runStepMethods (in category 'stepping') ----- runStepMethods
+ self becomeActiveDuring: [ + worldState runStepMethodsIn: self].! - worldState runStepMethodsIn: self - !
squeak-dev@lists.squeakfoundation.org