Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate. + ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ', and '] - ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ' and '] !
Isn't method comment wrong now?
Best, Karl
On Tue, Jun 13, 2023 at 11:07 PM commits@source.squeak.org wrote:
Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate.
^String streamContents: [:s | self asStringOn: s delimiter: ', 'last: ', and ']
^String streamContents: [:s | self asStringOn: s delimiter: ', 'last: ' and '] !
Oops, thanks, fixed.
________________________________ Von: karl ramberg karlramberg@gmail.com Gesendet: Dienstag, 13. Juni 2023 23:17:17 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] Re: The Trunk: Collections-ct.1044.mcz
Isn't method comment wrong now?
Best, Karl
On Tue, Jun 13, 2023 at 11:07 PM <commits@source.squeak.orgmailto:commits@source.squeak.org> wrote: Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate. + ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ', and '] - ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ' and '] !
Hi Christoph,
Is it a good idea to change that? If yes, then is it okay that #('Tom' 'Jerry') asCommaStringAnd returns 'Tom, and Jerry'? Also, what's with that flag in the method?
Levente
On 2023. 06. 13. 21:07, commits@source.squeak.org wrote:
Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate.
- ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ', and ']
- ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ' and '] !
The Oxford comma only works for collections with more than 2 elements, right?
Best, Marcel Am 15.06.2023 14:12:12 schrieb leves leves@caesar.elte.hu: Hi Christoph,
Is it a good idea to change that? If yes, then is it okay that #('Tom' 'Jerry') asCommaStringAnd returns 'Tom, and Jerry'? Also, what's with that flag in the method?
Levente
On 2023. 06. 13. 21:07, commits@source.squeak.org wrote:
Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate.
- ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ', and ']
- ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ' and ']
!
Yes, and no.
:-)
On 2023-06-15, at 7:51 AM, Marcel Taeumel via Squeak-dev squeak-dev@lists.squeakfoundation.org wrote:
The Oxford comma only works for collections with more than 2 elements, right?
Best, Marcel
Am 15.06.2023 14:12:12 schrieb leves leves@caesar.elte.hu:
Hi Christoph,
Is it a good idea to change that? If yes, then is it okay that #('Tom' 'Jerry') asCommaStringAnd returns 'Tom, and Jerry'? Also, what's with that flag in the method?
Levente
On 2023. 06. 13. 21:07, commits@source.squeak.org wrote:
Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate.
- ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ', and ']
- ^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ' and ']
!
tim -- tim Rowledge; tim@rowledge.org; http://www.rowledge.org/tim Useful random insult:- Only playing with 51 cards.
Thank you and fixed the two-items case. :-) The #deprecate flag was there before already. Maybe it relates to this selector being on Collection instead of SequenceableCollection ...
Best,
Christoph
________________________________ Von: leves leves@caesar.elte.hu Gesendet: Donnerstag, 15. Juni 2023 14:11:48 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] Re: The Trunk: Collections-ct.1044.mcz
Hi Christoph,
Is it a good idea to change that? If yes, then is it okay that #('Tom' 'Jerry') asCommaStringAnd returns 'Tom, and Jerry'? Also, what's with that flag in the method?
Levente
On 2023. 06. 13. 21:07, commits@source.squeak.org wrote:
Christoph Thiede uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-ct.1044.mcz
==================== Summary ====================
Name: Collections-ct.1044 Author: ct Time: 13 June 2023, 11:07:20.689003 pm UUID: 4944371b-f79b-5540-b1af-b1bb641f6a6f Ancestors: Collections-mt.1043, Collections-ct.930
Merges Collections-ct.930: Uses oxford comma in #asCommaStringAnd.
=============== Diff against Collections-mt.1043 ===============
Item was changed: ----- Method: Collection>>asCommaStringAnd (in category 'printing - obsolete') ----- asCommaStringAnd "Return collection printed as 'a, b and c' "
self flag: #deprecate.
^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ', and ']
^String streamContents: [:s | self asStringOn: s delimiter: ', ' last: ' and '] !
squeak-dev@lists.squeakfoundation.org
-
commits＠source.squeak.org -
karl ramberg -
leves -
Marcel Taeumel -
Thiede, Christoph -
Tim Rowledge