On Sun, 2 Jun 2013, commits@source.squeak.org wrote:
Frank Shearar uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-fbs.211.mcz
==================== Summary ====================
Name: Graphics-fbs.211 Author: fbs Time: 2 June 2013, 7:05:25.648 pm UUID: 65a2ecea-af2e-42cd-b61e-aece057c0e7b Ancestors: Graphics-fbs.210
Form >> #stencil and Pen >> #putDotOfDiameter:at: are only called from EToys code, so they belong in EToys.
I don't see what Form >> #stencil has to do with EToys. It's a general purpose method to create a stencil from a form. :)
Levente
=============== Diff against Graphics-fbs.210 ===============
Item was removed:
- ----- Method: Form>>stencil (in category 'image manipulation') -----
- stencil
- "return a 1-bit deep, black-and-white stencil of myself"
- | canvas |
- canvas := FormCanvas extent: self extent depth: 1.
- canvas fillColor: (Color white).
- canvas stencil: self at: 0@0
sourceRect: (Rectangle origin: 0@0 corner: self extent) color: Color black.
- ^ canvas form
- !
Item was removed:
- ----- Method: Pen>>putDotOfDiameter:at: (in category 'operations') -----
- putDotOfDiameter: aDiameter at: aPoint
- "Put a dot of the given size at the given point, using my colot"
- (FormCanvas on: destForm)
fillOval: (Rectangle center: aPoint extent: (aDiameter @ aDiameter))
color: self color!
On 3 June 2013 18:18, Levente Uzonyi leves@elte.hu wrote:
On Sun, 2 Jun 2013, commits@source.squeak.org wrote:
Frank Shearar uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-fbs.211.mcz
==================== Summary ====================
Name: Graphics-fbs.211 Author: fbs Time: 2 June 2013, 7:05:25.648 pm UUID: 65a2ecea-af2e-42cd-b61e-aece057c0e7b Ancestors: Graphics-fbs.210
Form >> #stencil and Pen >> #putDotOfDiameter:at: are only called from EToys code, so they belong in EToys.
I don't see what Form >> #stencil has to do with EToys. It's a general purpose method to create a stencil from a form. :)
They might be general purpose, but they're only used in EToys. But FormCanvas doesn't belong in Graphics, it belongs in Morphic.
frank
Levente
On Mon, 3 Jun 2013, Frank Shearar wrote:
On 3 June 2013 18:18, Levente Uzonyi leves@elte.hu wrote:
On Sun, 2 Jun 2013, commits@source.squeak.org wrote:
Frank Shearar uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-fbs.211.mcz
==================== Summary ====================
Name: Graphics-fbs.211 Author: fbs Time: 2 June 2013, 7:05:25.648 pm UUID: 65a2ecea-af2e-42cd-b61e-aece057c0e7b Ancestors: Graphics-fbs.210
Form >> #stencil and Pen >> #putDotOfDiameter:at: are only called from EToys code, so they belong in EToys.
I don't see what Form >> #stencil has to do with EToys. It's a general purpose method to create a stencil from a form. :)
They might be general purpose, but they're only used in EToys. But
This is the reason why it was a bad idea to remove random classes/methods/packages during 3.9. Many methods have no senders in the base image, and the removed code is not maintained.
FormCanvas doesn't belong in Graphics, it belongs in Morphic.
FormCanvas is in Morphic-Support (which is AFAIK stuff being used by Morphic). It's just a higher level tool which helps working with Forms.
From the packaging POV, I think #stencil should be a in Morphic-Support
rather than in EToys.
Levente
frank
Levente
On 3 June 2013 18:48, Levente Uzonyi leves@elte.hu wrote:
On Mon, 3 Jun 2013, Frank Shearar wrote:
On 3 June 2013 18:18, Levente Uzonyi leves@elte.hu wrote:
On Sun, 2 Jun 2013, commits@source.squeak.org wrote:
Frank Shearar uploaded a new version of Graphics to project The Trunk: http://source.squeak.org/trunk/Graphics-fbs.211.mcz
==================== Summary ====================
Name: Graphics-fbs.211 Author: fbs Time: 2 June 2013, 7:05:25.648 pm UUID: 65a2ecea-af2e-42cd-b61e-aece057c0e7b Ancestors: Graphics-fbs.210
Form >> #stencil and Pen >> #putDotOfDiameter:at: are only called from EToys code, so they belong in EToys.
I don't see what Form >> #stencil has to do with EToys. It's a general purpose method to create a stencil from a form. :)
They might be general purpose, but they're only used in EToys. But
This is the reason why it was a bad idea to remove random classes/methods/packages during 3.9. Many methods have no senders in the base image, and the removed code is not maintained.
Bear in mind of course that these methods are still in the base image. I'm moving them where (I think) they should go.
FormCanvas doesn't belong in Graphics, it belongs in Morphic.
FormCanvas is in Morphic-Support (which is AFAIK stuff being used by Morphic). It's just a higher level tool which helps working with Forms.
From the packaging POV, I think #stencil should be a in Morphic-Support
rather than in EToys.
I'm happy to move #stencil to Morphic-Support. I just don't want Graphics depending on Morphic.
frank
Levente
frank
Levente
squeak-dev@lists.squeakfoundation.org