hi all
3.4b-5156 can't load a project correctly that has JPEG SketchMorph.
1) create a new project and enter. 2) drop the jpeg file on the world. (*1; published.jpg) 3) publish it. 4) load that project. (*2; afterLoading.jpg)
It is never occurred at Squeak3.4b-5138, Squeak3.2-4956, Squeak3.2-4917 images. *** Squeak3.4b-5156 image only ***
It seems to be exchanged a form stub and the right bits.
Any suggestion?
Hi,
verified that on my windoze machine. Could it be that the zip archive fixes cause this bug? Although I can't immediately see why, need to do some more debugging...
Michael
NISHIHARA Satoshi wrote:
hi all
3.4b-5156 can't load a project correctly that has JPEG SketchMorph.
- create a new project and enter.
- drop the jpeg file on the world. (*1; published.jpg)
- publish it.
- load that project. (*2; afterLoading.jpg)
It is never occurred at Squeak3.4b-5138, Squeak3.2-4956, Squeak3.2-4917 images. *** Squeak3.4b-5156 image only ***
It seems to be exchanged a form stub and the right bits.
Any suggestion?
hi Michael-san
On Thu, 19 Dec 2002 23:54:15 -0800 Michael Rueger m.rueger@acm.org wrote:
verified that on my windoze machine. Could it be that the zip archive fixes cause this bug?
Here are the methods changed after December 1, 2002. I reverted the 2 method of ZipArchive>>readFrom: and ZipArchiveMember>>extractToFileNamed:inDirectory:, but it doesn't work.
FileList>>itemsForFile: FileList>>suffixOfSelectedFile Browser>>findMethod ChangeList>>changeListMenu: ChangeList>>selectNewMethods PreferencesPanel>>addHelpItemsTo: FileList class>>itemsForFile: FileList class>>suffixOf: MacFileDirectory class>>isAbsolute: Preferences class>>initializePreferencePanel:in: FileDirectory>>relativeNameFor: AcornFileDirectory>>directoryExists: DosFileDirectory>>relativeNameFor: Form>>replaceByResource: ArchiveViewer>>extractAllPossibleInDirectory: ArchiveViewer>>windowIsClosing WaveEditor>>graph ZipArchive>>readFrom: ZipArchiveMember>>extractToFileNamed:inDirectory: WeakMessageSendTestCase>>testReceiverWithGC WeakMessageSendTestCase>>testOneArgumentWithGC WeakMessageSend>>ensureReceiver WeakMessageSend>>ensureReceiverAndArguments WeakMessageSend>>ensureArguments WeakMessageSend>>valueWithEnoughArguments: WeakMessageSend>>value WeakMessageSend>>valueWithArguments:
On Friday 20 December 2002 01:56 am, NISHIHARA Satoshi wrote:
On Thu, 19 Dec 2002 23:54:15 -0800
Michael Rueger m.rueger@acm.org wrote:
verified that on my windoze machine. Could it be that the zip archive fixes cause this bug?
Here are the methods changed after December 1, 2002. I reverted the 2 method of ZipArchive>>readFrom: and ZipArchiveMember>>extractToFileNamed:inDirectory:, but it doesn't work.
Sounds like this might be the problem:
Form>>replaceByResource:
Though I just tried this on Linux and it looked fine:
* saved your picture to a file * opened a new Morphic project * new morph/from file/picture.jpg * publish to different server/publish to local disk only/unnamed1 * quit Squeak * load Squeaklets/unnamed1.pr
My display depth is the stock 16 bits, if it matters.
Ned Konz wrote:
Though I just tried this on Linux and it looked fine:
- saved your picture to a file
- opened a new Morphic project
- new morph/from file/picture.jpg
- publish to different server/publish to local disk only/unnamed1
- quit Squeak
- load Squeaklets/unnamed1.pr
The culprit is the change to the filename method which now replace the "/" with the platform slash. Which doesn't do anything on *ix, but breaks code using archive member file names on the other platforms.
Ned, what was your intention in that change? Should we have two different methods, one returning the unmodified name and the other the plaform specific one?
Michael
On Friday 20 December 2002 01:20 pm, Michael Rueger wrote:
The culprit is the change to the filename method which now replace the "/" with the platform slash. Which doesn't do anything on *ix, but breaks code using archive member file names on the other platforms.
I see the following methods where the use of fileName is probably causing a problem:
ResourceManager>>loadResource: urlString fromCacheFileNamed: fileName in: dir ResourceManager>>preLoadFromArchive: aZipArchive cacheName: aFileName
Ned, what was your intention in that change?
To make the interface between zips and local directories better; to make the API handle local filenames without having to do explicit translations (i.e. memberNamed: now looks at rawFileName and then fileName).
In retrospect, though, I should have left fileName alone and added localFileName and localFileName: in the places that needed it.
Should we have two different methods, one returning the unmodified name and the other the plaform specific one?
We do. #rawFileName is the '/' separated one, and #fileName is the local filename version.
However, I'd like to change it to #fileName and #localFileName so as not to break the ResourceManager and ServerDirectory code.
Let me work on this. I'll test on Mac and Windows.
Hello, All.
I Played SqueakToys with my niece, last night. She saved her project on local disk. Today , I load her project... The background of the picture which she draws had changed black. I doing, it became the same result. I think that it is bug.
Kouichi Kimura email: kimurako@mac.com
The background of the picture which she draws had changed black. I doing, it became the same result. I think that it is bug.
Yes, it is a bug. Somehow a fix we did for the squeakland.org version did not make it into the developers squeak. You may actually want to explore the squeakland.org version for your niece to use.
Kind Regards
Michael
Hello,
On Wed, 05 Mar 2003 23:46:24 -0800 Michael Rueger m.rueger@acm.org wrote:
The background of the picture which she draws had changed black. I doing, it became the same result. I think that it is bug.
Yes, it is a bug. Somehow a fix we did for the squeakland.org version did not make it into the developers squeak. You may actually want to explore the squeakland.org version for your niece to use.
Why Nishihara-san's patch does not merge into developer's version? It works fine.
http://groups.yahoo.com/group/squeak/message/54616
Best regards, Kazuhiro ABE __________________________________________________ Do You Yahoo!? Yahoo! BB is Broadband by Yahoo! http://bb.yahoo.co.jp/
The background of the picture which she draws had changed black. I doing, it became the same result. I think that it is bug.
Yes, it is a bug. Somehow a fix we did for the squeakland.org version did not make it into the developers squeak. You may actually want to explore the squeakland.org version for your niece to use.
Why Nishihara-san's patch does not merge into developer's version? It works fine.
According to Andreas Raab the fix is not fine. A better fix is in the squeakland image and was just posted to the sqf list (perhaps it should have been posted here, too). http://lists.squeakfoundation.org/pipermail/squeakfoundation/2003- March/001027.html
-- Bert
On Thu, 6 Mar 2003 14:41:00 +0100 Bert Freudenberg bert@isg.cs.uni-magdeburg.de wrote:
Why Nishihara-san's patch does not merge into developer's version? It works fine.
According to Andreas Raab the fix is not fine. A better fix is in the squeakland image and was just posted to the sqf list (perhaps it should have been posted here, too). http://lists.squeakfoundation.org/pipermail/squeakfoundation/2003- March/001027.html
I see. I don't subscribe this mailing list... Thank you.
Kazuhiro ABE __________________________________________________ Do You Yahoo!? Yahoo! BB is Broadband by Yahoo! http://bb.yahoo.co.jp/
squeak-dev@lists.squeakfoundation.org
-
Bert Freudenberg -
Kazuhiro ABE -
kimurako＠mac.com -
Michael Rueger -
Ned Konz -
NISHIHARA Satoshi