Christoph Thiede uploaded a new version of Tools to project The Inbox: http://source.squeak.org/inbox/Tools-ct.1212.mcz
==================== Summary ====================
Name: Tools-ct.1212 Author: ct Time: 1 June 2023, 8:36:02.460263 pm UUID: 6565c5ce-dfe0-c847-bc8d-3a30e720ab6c Ancestors: Tools-ct.1210
Fixes an issue with updating the UI theme after closing a debugger. The issue is sporadic and leaks the GC behavior.
=============== Diff against Tools-ct.1210 ===============
Item was changed: ----- Method: Debugger>>aboutToStyle: (in category 'code pane') ----- aboutToStyle: aStyler "This is a notification that aStyler is about to re-style its text. Set the classOrMetaClass in aStyler, so that identifiers will be resolved correctly. Answer true to allow styling to proceed, or false to veto the styling" + contextStack ifNil: [ + "already released and then updated via global UserInterfaceTheme update." + ^ false]. self isModeStyleable ifFalse: [^false]. aStyler classOrMetaClass: self selectedClassOrMetaClass; sourceMap: self debuggerMap. ^true!
Is this the right way to fix this? As we are using #allObjectsDo: from UserInterfaceTheme>>#basicApply, this means in theory that any object which implements #applyUserInterfaceTheme is required to maintain itself in a valid state even when no longer in the world nor contained anywhere else in the object graph. It is surprising that are not facing more issues like this one ...
squeak-dev@lists.squeakfoundation.org