On Tue, 21 Jun 2011, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-spd.469.mcz
==================== Summary ====================
Name: Morphic-spd.469 Author: spd Time: 1 October 2010, 2:20:39.508 pm UUID: a68c21fa-d7d3-46da-82ea-53077512621a Ancestors: Morphic-laza.468
LineMorph class>>from:to:color:width: changed to return a LineMorph
This change should be reverted IMHO. According to the class comment of LineMorph, it shouldn't have instances in the image.
Levente
=============== Diff against Morphic-laza.468 ===============
Item was changed: ----- Method: LineMorph class>>from:to:color:width: (in category 'instance creation') ----- from: startPoint to: endPoint color: lineColor width: lineWidth
- ^ self vertices: {startPoint. endPoint}
- ^ PolygonMorph vertices: {startPoint. endPoint} color: Color black borderWidth: lineWidth borderColor: lineColor!
It doesn't quite say that.. It describes what it "only" (currently) is.
Are we saying LineMorph should not be first-class?
On Tue, Jun 21, 2011 at 5:49 PM, Levente Uzonyi leves@elte.hu wrote:
On Tue, 21 Jun 2011, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-spd.469.mcz
==================== Summary ====================
Name: Morphic-spd.469 Author: spd Time: 1 October 2010, 2:20:39.508 pm UUID: a68c21fa-d7d3-46da-82ea-53077512621a Ancestors: Morphic-laza.468
LineMorph class>>from:to:color:width: changed to return a LineMorph
This change should be reverted IMHO. According to the class comment of LineMorph, it shouldn't have instances in the image.
Levente
=============== Diff against Morphic-laza.468 ===============
Item was changed: ----- Method: LineMorph class>>from:to:color:width: (in category 'instance creation') ----- from: startPoint to: endPoint color: lineColor width: lineWidth
- ^ self vertices: {startPoint. endPoint}
- ^ PolygonMorph vertices: {startPoint. endPoint}
color: Color black borderWidth: lineWidth borderColor: lineColor!
On Tue, 21 Jun 2011, Chris Muller wrote:
It doesn't quite say that.. It describes what it "only" (currently) is.
Are we saying LineMorph should not be first-class?
Do we want curvy LineMorphs?
Levente
On Tue, Jun 21, 2011 at 5:49 PM, Levente Uzonyi leves@elte.hu wrote:
On Tue, 21 Jun 2011, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-spd.469.mcz
==================== Summary ====================
Name: Morphic-spd.469 Author: spd Time: 1 October 2010, 2:20:39.508 pm UUID: a68c21fa-d7d3-46da-82ea-53077512621a Ancestors: Morphic-laza.468
LineMorph class>>from:to:color:width: changed to return a LineMorph
This change should be reverted IMHO. According to the class comment of LineMorph, it shouldn't have instances in the image.
Levente
=============== Diff against Morphic-laza.468 ===============
Item was changed: ----- Method: LineMorph class>>from:to:color:width: (in category 'instance creation') ----- from: startPoint to: endPoint color: lineColor width: lineWidth
- ^ self vertices: {startPoint. endPoint}
- ^ PolygonMorph vertices: {startPoint. endPoint}
color: Color black borderWidth: lineWidth borderColor: lineColor!
Do we want curvy LineMorphs?
It took me a minute, but I think I understand your point. I think you're saying, a LineMorph is a PolygonMorph that isOpen. But the power of PolygonMorphs allows them to be curvy too, and they (the Morphic artisans) made "Curve" and "Curvier" subclasses for parts-bin examples. And so, you ask, if we are going to make these all first-class, do we want to have class-explosion for every combination? I agree, the answer to that is no.
However, we do have a first-class StarMorph (no doubt to support implementation details). I think a Line and a Star are things that normal people think of as an everyday type of object. A "Curve" however, seems really to be just an _attribute_ of a polygon - whether that is a Line or a Star or a polygon.
OTOH, I don't think we should have a TriangleMorph or a SquareMorph and those are everyday objects too. I guess I was thinking about how it would make sense for the Line example to have API to control its ends (arrows, etc.).
Anyhow, I think I've argued myself into agreement with you..
- Chris
2011/6/21 Levente Uzonyi leves@elte.hu:
On Tue, 21 Jun 2011, Chris Muller wrote:
It doesn't quite say that.. It describes what it "only" (currently) is.
Are we saying LineMorph should not be first-class?
Do we want curvy LineMorphs?
Levente
On Tue, Jun 21, 2011 at 5:49 PM, Levente Uzonyi leves@elte.hu wrote:
On Tue, 21 Jun 2011, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of Morphic to project The Trunk: http://source.squeak.org/trunk/Morphic-spd.469.mcz
==================== Summary ====================
Name: Morphic-spd.469 Author: spd Time: 1 October 2010, 2:20:39.508 pm UUID: a68c21fa-d7d3-46da-82ea-53077512621a Ancestors: Morphic-laza.468
LineMorph class>>from:to:color:width: changed to return a LineMorph
This change should be reverted IMHO. According to the class comment of LineMorph, it shouldn't have instances in the image.
Levente
=============== Diff against Morphic-laza.468 ===============
Item was changed: ----- Method: LineMorph class>>from:to:color:width: (in category 'instance creation') ----- from: startPoint to: endPoint color: lineColor width: lineWidth
- ^ self vertices: {startPoint. endPoint}
- ^ PolygonMorph vertices: {startPoint. endPoint}
color: Color black borderWidth: lineWidth borderColor: lineColor!
squeak-dev@lists.squeakfoundation.org