Squeakers, I recently did some cleanup and enhancements for the MPEGPlayerMorph. --converted the code to use the new layout system. This allows for a resizable morph. --Moved the class under StretchyImageMorph to quickly allow for stretchy bitmap backgrounds --Added a "Look" button that lets you interactively load a graphic file as a background for the player --Added a path memory for the last directory a media file or graphic look is loaded from
I started with the updated 2.9a-2915 image and added: MPEGPlayerMorph.10.cs MPEGPlayerJMM.10.cs MPEGPlayerMorphicFixJMM.1.cs MPEGPlayerFixBadParmsJMM.2.cs
Then I made my changes. I looked at Karl's version with the iconic buttons today and noticed that MPEGPlayer2 was included and seemed quite different than the MPEGPlayer class in the version I started with. Am I behind the curve here?
This changeset includes some mods to StandardFileMenu as well to support file searches with multiple patterns... just a quick hack, but very useful. BTW, I can play MP3 audio just fine in Windows but have yet to succeed with MPEG2 Video. Any thoughts?
(See attached file: MPEGPlayerSSA.2.cs) Regards, Sam
Sam S. Adams, IBM Distinguished Engineer, IBM Research tie line 444-0736, outside 919-254-0736, email: ssadams@us.ibm.com <<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>
Sam S. Adams, IBM Distinguished Engineer, IBM Research wrote Then I made my changes. I looked at Karl's version with the iconic buttons today and noticed that MPEGPlayer2 was included and seemed quite different than the MPEGPlayer class in the version I started with. Am I behind the curve here?
Karl and I've have been talking about this very issue over the last week or so.
So what I'm going to do with Karl's participation of course is have him take over ownership of the MPEGPlayer along with his contribution of the MPEGPlayerMorph part of the Smalltalk code and have him merge his work on MPEGPlayer2 with the original MPEGPlayer since he has more time and interest in doing further work on the visual side of the mpeg solution.
I'll still look after the C code part and the basic interface to the external library, since I'm more interested in addressing performance concerns at a lower level. This transition will take a few days I suspect but should reduce the competing players so to speak...
John M McIntosh wrote:
Karl and I've have been talking about this very issue over the last week or so.
So what I'm going to do with Karl's participation of course is have him take over ownership of the MPEGPlayer along with his contribution of the MPEGPlayerMorph part of the Smalltalk code and have him merge his work on MPEGPlayer2 with the original MPEGPlayer since he has more time and interest in doing further work on the visual side of the mpeg solution.
I'll start this process this weekend. My startingpoint will be the MPEGPlayer2 because that essensialy is a refactoring of the MPEGPlayer. Just a few questions. Should the player support MVC ?
Johns MPEGPlayer implements all the MPEGFile accessors. Several of these are obscure, incompatible with eachother etc. I'll start off by not implementing all of them but add if time and experience shows it's usefullness.
I'll still look after the C code part and the basic interface to the external library, since I'm more interested in addressing performance concerns at a lower level. This transition will take a few days I suspect but should reduce the competing players so to speak...
Sounds good. Karl
--
=========================================================================== John M. McIntosh johnmci@smalltalkconsulting.com 1-800-477-2659 Corporate Smalltalk Consulting Ltd. http://www.smalltalkconsulting.com =========================================================================== Custom Macintosh programming & various Smalltalk dialects PGP Key: DSS/Diff/46FC3BE6 Fingerprint=B22F 7D67 92B7 5D52 72D7 E94A EE69 2D21 46FC 3BE6 ===========================================================================
squeak-dev@lists.squeakfoundation.org
-
John M McIntosh -
Karl Ramberg -
ssadams＠us.ibm.com