Patrick Rein uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-pre.211.mcz
==================== Summary ====================
Name: MorphicExtras-pre.211 Author: pre Time: 2 October 2017, 2:23:27.336394 pm UUID: 453b45d7-fcb6-d041-aa89-1322b3adbb3b Ancestors: MorphicExtras-hjh.210
tiny refactoring of a bookmorph method
=============== Diff against MorphicExtras-hjh.210 ===============
Item was changed: ----- Method: BookMorph>>insertPageColored: (in category 'insert and delete') ----- insertPageColored: aColor "Insert a new page for the receiver, using the given color as its background color"
+ | pageExtent newPage borderWidth backgroundColor | + backgroundColor := currentPage isNil - | sz newPage bw bc | - bc := currentPage isNil ifTrue: + [pageExtent := pageSize. + borderWidth := 0. - [sz := pageSize. - bw := 0. Color blue muchLighter] ifFalse: + [pageExtent := currentPage extent. + borderWidth := currentPage borderWidth. - [sz := currentPage extent. - bw := currentPage borderWidth. currentPage borderColor]. newPagePrototype ifNil: [newPage := (PasteUpMorph new) + extent: pageExtent; - extent: sz; color: aColor. newPage + borderWidth: borderWidth; + borderColor: backgroundColor] - borderWidth: bw; - borderColor: bc] ifNotNil: [newPage := Cursor wait showWhile: [newPagePrototype veryDeepCopy]]. newPage setNameTo: self defaultNameStemForNewPages. newPage vResizeToFit: false. pages isEmpty ifTrue: [pages add: (currentPage := newPage)] ifFalse: [pages add: newPage after: currentPage]. self nextPage!
Thank you, Patrick, for making the important method
BookMorph>>insertPageColored: aColor "Insert a new page for the receiver, using the given color as its background color"
easier to read.
A suggestion for another small, but important fix. The bookmorph navigation shows an upper script three instead of the lozenge symbol as it used to be [1].
Yoshiki Ohshima answered a question by John-Reed Maffeo [2]. <citation>From 3.8 and later versions, the code was carried over but now the default font uses Latin-1 encoding, and code point 179 is shown ad upper script three. </citation>
So either this lozenge (diamond) symbol needs to be added to the font used in the navigation bar or another bitmap font needs to be used. [3],[4]
--Hannes
[1] http://forum.world.st/attachment/4966832/0/lozenge.png https://en.wikipedia.org/wiki/Lozenge [2] http://forum.world.st/Book-morph-UI-question-tt4959925.html#a4966832 [3] How to display a character map of a bitmap font - http://wiki.squeak.org/squeak/2137 [4] How to edit existing bitmap fonts -- needs to be done in an MVC project http://wiki.squeak.org/squeak/1989
On Mon, 2 Oct 2017 12:23:44 0000, commits@source.squeak.org commits@source.squeak.org wrote:
Patrick Rein uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-pre.211.mcz
==================== Summary ====================
Name: MorphicExtras-pre.211 Author: pre Time: 2 October 2017, 2:23:27.336394 pm UUID: 453b45d7-fcb6-d041-aa89-1322b3adbb3b Ancestors: MorphicExtras-hjh.210
tiny refactoring of a bookmorph method
=============== Diff against MorphicExtras-hjh.210 ===============
Item was changed: ----- Method: BookMorph>>insertPageColored: (in category 'insert and delete') ----- insertPageColored: aColor "Insert a new page for the receiver, using the given color as its background color"
- | pageExtent newPage borderWidth backgroundColor |
- backgroundColor := currentPage isNil
- | sz newPage bw bc |
- bc := currentPage isNil ifTrue:
[pageExtent := pageSize.
borderWidth := 0.
[sz := pageSize.
bw := 0. Color blue muchLighter] ifFalse:
[pageExtent := currentPage extent.
borderWidth := currentPage borderWidth.
[sz := currentPage extent.
newPagePrototype ifNil: [newPage := (PasteUpMorph new)bw := currentPage borderWidth. currentPage borderColor].
extent: pageExtent;
extent: sz; color: aColor. newPage
borderWidth: borderWidth;
borderColor: backgroundColor]
borderWidth: bw;
ifNotNil: [newPage := Cursor wait showWhile: [newPagePrototypeborderColor: bc]
veryDeepCopy]]. newPage setNameTo: self defaultNameStemForNewPages. newPage vResizeToFit: false. pages isEmpty ifTrue: [pages add: (currentPage := newPage)] ifFalse: [pages add: newPage after: currentPage]. self nextPage!
And here is the link to the info how the Bookmorph navigation is implemented
http://wiki.squeak.org/squeak/6390
On 10/2/17, H. Hirzel hannes.hirzel@gmail.com wrote:
Thank you, Patrick, for making the important method
BookMorph>>insertPageColored: aColor
"Insert a new page for the receiver, using the given color as its background color"
easier to read.
A suggestion for another small, but important fix. The bookmorph navigation shows an upper script three instead of the lozenge symbol as it used to be [1].
Yoshiki Ohshima answered a question by John-Reed Maffeo [2]. <citation>From 3.8 and later versions, the code was carried over but now the default font uses Latin-1 encoding, and code point 179 is shown ad upper script three.
</citation>
So either this lozenge (diamond) symbol needs to be added to the font used in the navigation bar or another bitmap font needs to be used. [3],[4]
--Hannes
[1] http://forum.world.st/attachment/4966832/0/lozenge.png https://en.wikipedia.org/wiki/Lozenge [2] http://forum.world.st/Book-morph-UI-question-tt4959925.html#a4966832 [3] How to display a character map of a bitmap font - http://wiki.squeak.org/squeak/2137 [4] How to edit existing bitmap fonts -- needs to be done in an MVC project http://wiki.squeak.org/squeak/1989
On Mon, 2 Oct 2017 12:23:44 0000, commits@source.squeak.org commits@source.squeak.org wrote:
Patrick Rein uploaded a new version of MorphicExtras to project The Trunk: http://source.squeak.org/trunk/MorphicExtras-pre.211.mcz
==================== Summary ====================
Name: MorphicExtras-pre.211 Author: pre Time: 2 October 2017, 2:23:27.336394 pm UUID: 453b45d7-fcb6-d041-aa89-1322b3adbb3b Ancestors: MorphicExtras-hjh.210
tiny refactoring of a bookmorph method
=============== Diff against MorphicExtras-hjh.210 ===============
Item was changed: ----- Method: BookMorph>>insertPageColored: (in category 'insert and delete') ----- insertPageColored: aColor "Insert a new page for the receiver, using the given color as its background color"
- | pageExtent newPage borderWidth backgroundColor |
- backgroundColor := currentPage isNil
- | sz newPage bw bc |
- bc := currentPage isNil ifTrue:
[pageExtent := pageSize.
borderWidth := 0.
[sz := pageSize.
bw := 0. Color blue muchLighter] ifFalse:
[pageExtent := currentPage extent.
borderWidth := currentPage borderWidth.
[sz := currentPage extent.
newPagePrototype ifNil: [newPage := (PasteUpMorph new)bw := currentPage borderWidth. currentPage borderColor].
extent: pageExtent;
extent: sz; color: aColor. newPage
borderWidth: borderWidth;
borderColor: backgroundColor]
borderWidth: bw;
ifNotNil: [newPage := Cursor wait showWhile: [newPagePrototypeborderColor: bc]
veryDeepCopy]]. newPage setNameTo: self defaultNameStemForNewPages. newPage vResizeToFit: false. pages isEmpty ifTrue: [pages add: (currentPage := newPage)] ifFalse: [pages add: newPage after: currentPage]. self nextPage!
squeak-dev@lists.squeakfoundation.org