Following http://lists.squeakfoundation.org/pipermail/squeak-dev/2007-November/122283....
Just a warning at those using patches from - http://bugs.squeak.org/view.php?id=3574 (WideCharacterSet) - http://bugs.squeak.org/view.php?id=3574 (CharacterSetComplements)
These patches solved some bug but introduced new ones: - incorrect #remove: (a period lacking end of sentence) - incorrect #hash (bitXOr: with capital o) - incorrect #hash again (self map unimplemented)
So please find corresponding patches recently uploaded on Mantis.
-------------------------------------------
Patches going into production images should: - be reviewed (these were, but bugs were not obvious) - be tested in ad-hoc images (these were but only for bugs they solved) - be fully covered by tests
Obviously, third item is not met! Not enough tests written!
Anyone has a TestCoverage tool usable (production-ready) in Squeak?
Nicolas
Damn copy/paste bugs!
Mantis issues are http://bugs.squeak.org/view.php?id=3574
AND http://bugs.squeak.org/view.php?id=6366
nicolas cellier a écrit :
Following http://lists.squeakfoundation.org/pipermail/squeak-dev/2007-November/122283....
Just a warning at those using patches from
- http://bugs.squeak.org/view.php?id=3574 (WideCharacterSet)
- http://bugs.squeak.org/view.php?id=3574 (CharacterSetComplements)
These patches solved some bug but introduced new ones:
- incorrect #remove: (a period lacking end of sentence)
- incorrect #hash (bitXOr: with capital o)
- incorrect #hash again (self map unimplemented)
So please find corresponding patches recently uploaded on Mantis.
Patches going into production images should:
- be reviewed (these were, but bugs were not obvious)
- be tested in ad-hoc images (these were but only for bugs they solved)
- be fully covered by tests
Obviously, third item is not met! Not enough tests written!
Anyone has a TestCoverage tool usable (production-ready) in Squeak?
Nicolas
nicolas cellier a écrit :
Damn copy/paste bugs!
Mantis issues are http://bugs.squeak.org/view.php?id=3574
Oh no! It's http://bugs.squeak.org/view.php?id=6367
Sorry
nicolas cellier a écrit :
Following http://lists.squeakfoundation.org/pipermail/squeak-dev/2007-November/122283....
Just a warning at those using patches from
- http://bugs.squeak.org/view.php?id=3574 (WideCharacterSet)
- http://bugs.squeak.org/view.php?id=3574 (CharacterSetComplements)
These patches solved some bug but introduced new ones:
- incorrect #remove: (a period lacking end of sentence)
- incorrect #hash (bitXOr: with capital o)
- incorrect #hash again (self map unimplemented)
So please find corresponding patches recently uploaded on Mantis.
Patches going into production images should:
- be reviewed (these were, but bugs were not obvious)
- be tested in ad-hoc images (these were but only for bugs they solved)
- be fully covered by tests
Obviously, third item is not met! Not enough tests written!
Anyone has a TestCoverage tool usable (production-ready) in Squeak?
Nicolas
Unfortunately, guess what... more related bugs.
Copying a CharacterSet is not safe way to protect it, see http://bugs.squeak.org/view.php?id=6777. So are WideCharacterSet and CharacterSetComplement... http://bugs.squeak.org/view.php?id=3574 http://bugs.squeak.org/view.php?id=6367
Sure nobody does copy a CharacterSet, until...
Just one thing to add: coverage tests just don't cover this one, because it is kind of missing method.
Nicolas
Michael Rueger a écrit :
nicolas cellier wrote:
So please find corresponding patches recently uploaded on Mantis.
OK, attached an additional set of updates. Hope I got everything that was mentioned.
Thanks for the help!!
Michael
On 15 nov. 07, at 22:19, nicolas cellier wrote:
Following http://lists.squeakfoundation.org/pipermail/squeak-dev/ 2007-November/122283.html
Just a warning at those using patches from
- http://bugs.squeak.org/view.php?id=3574 (WideCharacterSet)
- http://bugs.squeak.org/view.php?id=3574 (CharacterSetComplements)
These patches solved some bug but introduced new ones:
- incorrect #remove: (a period lacking end of sentence)
- incorrect #hash (bitXOr: with capital o)
- incorrect #hash again (self map unimplemented)
So please find corresponding patches recently uploaded on Mantis.
Patches going into production images should:
- be reviewed (these were, but bugs were not obvious)
- be tested in ad-hoc images (these were but only for bugs they
solved)
- be fully covered by tests
Obviously, third item is not met! Not enough tests written!
Anyone has a TestCoverage tool usable (production-ready) in Squeak?
Christo Stefan did a really good job at having it running and be robust
Stef
Nicolas
squeak-dev@lists.squeakfoundation.org
-
Michael Rueger -
nicolas cellier -
stephane ducasse