from preamble:
"Change Set: ActionSequenceFix-nk Date: 30 July 2003 Author: Ned Konz
5 August: re-posted without Roel's fix.
Fixes a bug that makes it impossible to say:
someObject when: #something evaluate: (MessageSend ...)
"!
hi Ned
I do not understand why you remove the method WeakActionSequence removeSelector: #isReceiverOrAnyArgumentGarbage
while you need it WeakActionSequence>>isValid ^self isReceiverOrAnyArgumentGarbage not
the changes seems simple even if I do not understand how there are related to the impossibility to do
"Fixes a bug that makes it impossible to say:
someObject when: #something evaluate: (MessageSend ...)"
stef
< I'm a bug-fixing machine! >
This post brought to you by the BugFixArchiveViewer, a handy tool that makes it easy to comment on proposed fixes and enhancements for Squeak. For more information, check out the Web page for the BugFixArchiveViewer project: http://minnow.cc.gatech.edu/squeak/3214
< I'm a bug-fixing machine! >
The attached CS does the following: - Makes it possible to do: someObject when: #something evaluate: (MessageSend ...) - Removes a couple of unused methods from WeakActionSqeuence - Adds Object>>removeActionsSatisfying:
Stef said on 5 October:
I do not understand why you remove the method WeakActionSequence removeSelector: #isReceiverOrAnyArgumentGarbage while you need it WeakActionSequence>>isValid ^self isReceiverOrAnyArgumentGarbage not
Because WeakActionSequence>>isValid is never called. The attached CS removes it too.
the changes seems simple even if I do not understand how there are related to the impossibility to do "Fixes a bug that makes it impossible to say: someObject when: #something evaluate: (MessageSend ...)"
This was because MessageSend didn't understand #isValid.
< I'm a bug-fixing machine! >
This post brought to you by the BugFixArchiveViewer, a handy tool that makes it easy to comment on proposed fixes and enhancements for Squeak. For more information, check out the Web page for the BugFixArchiveViewer project: http://minnow.cc.gatech.edu/squeak/3214
< I'm a bug-fixing machine! >
Ned did another pass on it taking into account my questions
< I'm a bug-fixing machine! >
This post brought to you by the BugFixArchiveViewer, a handy tool that makes it easy to comment on proposed fixes and enhancements for Squeak. For more information, check out the Web page for the BugFixArchiveViewer project: http://minnow.cc.gatech.edu/squeak/3214
< I'm a bug-fixing machine! >
squeak-dev@lists.squeakfoundation.org