Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.822.mcz
==================== Summary ====================
Name: Collections-pre.822 Author: pre Time: 20 March 2019, 8:05:20.383677 pm UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc Ancestors: Collections-dtl.821
Adds #isMutator to Symbol which is analogous to asMutator.
=============== Diff against Collections-dtl.821 ===============
Item was added: + ----- Method: Symbol>>isMutator (in category 'testing') ----- + isMutator + + ^ self isKeyword and: [self numArgs = 1]!
Assuming a single-keyword is a mutator? Object>>#at: is not a mutator. #indexOf: is not. #first: is not. Obviously many more..
If API balance is the goal of this, perhaps #asMutator should be removed instead. This feels application-specific...
On Wed, Mar 20, 2019 at 2:05 PM commits@source.squeak.org wrote:
Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.822.mcz
==================== Summary ====================
Name: Collections-pre.822 Author: pre Time: 20 March 2019, 8:05:20.383677 pm UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc Ancestors: Collections-dtl.821
Adds #isMutator to Symbol which is analogous to asMutator.
=============== Diff against Collections-dtl.821 ===============
Item was added:
- ----- Method: Symbol>>isMutator (in category 'testing') -----
- isMutator
^ self isKeyword and: [self numArgs = 1]!
#asMutator: is for "generate instVar accessors" code-generation, and that's why it's in the Tools package.
IMHO, if #isMutator belongs anywhere, it isn't in Collections.
Regards, Chris
On Wed, Mar 20, 2019 at 3:08 PM Chris Muller asqueaker@gmail.com wrote:
Assuming a single-keyword is a mutator? Object>>#at: is not a mutator. #indexOf: is not. #first: is not. Obviously many more..
If API balance is the goal of this, perhaps #asMutator should be removed instead. This feels application-specific...
On Wed, Mar 20, 2019 at 2:05 PM commits@source.squeak.org wrote:
Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.822.mcz
==================== Summary ====================
Name: Collections-pre.822 Author: pre Time: 20 March 2019, 8:05:20.383677 pm UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc Ancestors: Collections-dtl.821
Adds #isMutator to Symbol which is analogous to asMutator.
=============== Diff against Collections-dtl.821 ===============
Item was added:
- ----- Method: Symbol>>isMutator (in category 'testing') -----
- isMutator
^ self isKeyword and: [self numArgs = 1]!
Which one are you refering to? I only see Symbol>>#asMutator in Collections in the method category converting. It is also used in a few other places beyond generating instance variable accessors.
Bests, Patrick
#asMutator: is for "generate instVar accessors" code-generation, and that's why it's in the Tools package.
IMHO, if #isMutator belongs anywhere, it isn't in Collections.
Regards, Chris
On Wed, Mar 20, 2019 at 3:08 PM Chris Muller asqueaker@gmail.com wrote:
Assuming a single-keyword is a mutator? Object>>#at: is not a mutator. #indexOf: is not. #first: is not. Obviously many more..
If API balance is the goal of this, perhaps #asMutator should be removed instead. This feels application-specific...
On Wed, Mar 20, 2019 at 2:05 PM commits@source.squeak.org wrote:
Patrick Rein uploaded a new version of Collections to project The Trunk: http://source.squeak.org/trunk/Collections-pre.822.mcz
==================== Summary ====================
Name: Collections-pre.822 Author: pre Time: 20 March 2019, 8:05:20.383677 pm UUID: 483c4461-cee4-4a4f-82d3-fbc03e7201cc Ancestors: Collections-dtl.821
Adds #isMutator to Symbol which is analogous to asMutator.
=============== Diff against Collections-dtl.821 ===============
Item was added:
- ----- Method: Symbol>>isMutator (in category 'testing') -----
- isMutator
^ self isKeyword and: [self numArgs = 1]!
squeak-dev@lists.squeakfoundation.org
-
Chris Muller -
commits＠source.squeak.org -
patrick.rein＠hpi.uni-potsdam.de