David T. Lewis uploaded a new version of Compression to project The Trunk: http://source.squeak.org/trunk/Compression-dtl.55.mcz
==================== Summary ====================
Name: Compression-dtl.55 Author: dtl Time: 28 September 2017, 8:43:03.046216 pm UUID: 3a42cda4-740b-4ac0-9fe3-2033f5a3177b Ancestors: Compression-dtl.54
Instead of "Error: can't find EOCD position", say "Error: ZipArchive cannot find EOCD position in <name of the file or stream>"
=============== Diff against Compression-dtl.54 ===============
Item was changed: ----- Method: ZipArchive>>readFrom: (in category 'reading') ----- readFrom: aStreamOrFileName | stream name eocdPosition | stream := aStreamOrFileName isStream ifTrue: [name := aStreamOrFileName name. aStreamOrFileName] ifFalse: [StandardFileStream readOnlyFileNamed: (name := aStreamOrFileName)]. stream binary. eocdPosition := self class findEndOfCentralDirectoryFrom: stream. + eocdPosition <= 0 ifTrue: [self error: self class name, ' cannot find EOCD position in ', aStreamOrFileName name]. - eocdPosition <= 0 ifTrue: [self error: 'can''t find EOCD position']. self readEndOfCentralDirectoryFrom: stream. stream position: eocdPosition - centralDirectorySize. self readMembersFrom: stream named: name!
Wow. Thank you.
On Sep 28, 2017 5:43 PM, commits@source.squeak.org wrote:
David T. Lewis uploaded a new version of Compression to project The Trunk: http://source.squeak.org/trunk/Compression-dtl.55.mcz
==================== Summary ====================
Name: Compression-dtl.55 Author: dtl Time: 28 September 2017, 8:43:03.046216 pm UUID: 3a42cda4-740b-4ac0-9fe3-2033f5a3177b Ancestors: Compression-dtl.54
Instead of "Error: can't find EOCD position", say "Error: ZipArchive cannot find EOCD position in <name of the file or stream>"
=============== Diff against Compression-dtl.54 ===============
Item was changed: ----- Method: ZipArchive>>readFrom: (in category 'reading') ----- readFrom: aStreamOrFileName | stream name eocdPosition | stream := aStreamOrFileName isStream ifTrue: [name := aStreamOrFileName name. aStreamOrFileName] ifFalse: [StandardFileStream readOnlyFileNamed: (name := aStreamOrFileName)]. stream binary. eocdPosition := self class findEndOfCentralDirectoryFrom: stream.
eocdPosition <= 0 ifTrue: [self error: self class name, ' cannot
find EOCD position in ', aStreamOrFileName name].
eocdPosition <= 0 ifTrue: [self error: 'can''t find EOCD
position']. self readEndOfCentralDirectoryFrom: stream. stream position: eocdPosition - centralDirectorySize. self readMembersFrom: stream named: name!
Ditto, what he said.
On Sat, Sep 30, 2017 at 11:17 AM, Chris Cunningham cunningham.cb@gmail.com wrote:
Wow. Thank you.
On Sep 28, 2017 5:43 PM, commits@source.squeak.org wrote:
David T. Lewis uploaded a new version of Compression to project The Trunk: http://source.squeak.org/trunk/Compression-dtl.55.mcz
==================== Summary ====================
Name: Compression-dtl.55 Author: dtl Time: 28 September 2017, 8:43:03.046216 pm UUID: 3a42cda4-740b-4ac0-9fe3-2033f5a3177b Ancestors: Compression-dtl.54
Instead of "Error: can't find EOCD position", say "Error: ZipArchive cannot find EOCD position in <name of the file or stream>"
=============== Diff against Compression-dtl.54 ===============
Item was changed: ----- Method: ZipArchive>>readFrom: (in category 'reading') ----- readFrom: aStreamOrFileName | stream name eocdPosition | stream := aStreamOrFileName isStream ifTrue: [name := aStreamOrFileName name. aStreamOrFileName] ifFalse: [StandardFileStream readOnlyFileNamed: (name := aStreamOrFileName)]. stream binary. eocdPosition := self class findEndOfCentralDirectoryFrom: stream.
eocdPosition <= 0 ifTrue: [self error: self class name, ' cannot
find EOCD position in ', aStreamOrFileName name].
eocdPosition <= 0 ifTrue: [self error: 'can''t find EOCD
position']. self readEndOfCentralDirectoryFrom: stream. stream position: eocdPosition - centralDirectorySize. self readMembersFrom: stream named: name!
squeak-dev@lists.squeakfoundation.org