Patrick Rein uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-pre.232.mcz
==================== Summary ====================
Name: Multilingual-pre.232 Author: pre Time: 7 December 2017, 12:21:07.824608 pm UUID: 8a517ab7-5c79-b84f-976c-6bfb7b07f0d8 Ancestors: Multilingual-pre.231
Adds the signaling of the NoConverterFound exception (was missing from previous commit due to porting from another image).
=============== Diff against Multilingual-pre.231 ===============
Item was changed: ----- Method: TextConverter class>>newForEncoding: (in category 'instance creation') ----- newForEncoding: aString | class encoding | aString ifNil: [^ ISO88591TextConverter new]. encoding := aString asLowercase. class := self allSubclasses detect: [:each | each encodingNames includes: encoding] ifNone: []. class isNil + ifTrue: [NoConverterFound signalFor: aString. ^ nil]. - ifTrue: [^ nil]. ^ class new!
Since you continue with '^ nil' anyways, probably it should be a (resumable) Warning instead of an Error?
Best regards -Tobias
On 07.12.2017, at 12:21, commits@source.squeak.org wrote:
Patrick Rein uploaded a new version of Multilingual to project The Trunk: http://source.squeak.org/trunk/Multilingual-pre.232.mcz
==================== Summary ====================
Name: Multilingual-pre.232 Author: pre Time: 7 December 2017, 12:21:07.824608 pm UUID: 8a517ab7-5c79-b84f-976c-6bfb7b07f0d8 Ancestors: Multilingual-pre.231
Adds the signaling of the NoConverterFound exception (was missing from previous commit due to porting from another image).
=============== Diff against Multilingual-pre.231 ===============
Item was changed: ----- Method: TextConverter class>>newForEncoding: (in category 'instance creation') ----- newForEncoding: aString | class encoding | aString ifNil: [^ ISO88591TextConverter new]. encoding := aString asLowercase. class := self allSubclasses detect: [:each | each encodingNames includes: encoding] ifNone: []. class isNil
ifTrue: [NoConverterFound signalFor: aString. ^ nil].
^ class new!ifTrue: [^ nil].
squeak-dev@lists.squeakfoundation.org