Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz
==================== Summary ====================
Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631
Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object?
=============== Diff against Morphic-mt.1631 ===============
Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.!
Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!
Ah yes, maybe I should add a section about the motivation of this commit:
#errorOnStep is still existing in the system; if the property is set, you can resume stepping over the debug menu of the failing morph. It would be nice if this worked again.
http://www.hpi.de/ ________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Samstag, 29. Februar 2020 12:39:20 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: Morphic-ct.1635.mcz
Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz
==================== Summary ====================
Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631
Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object?
=============== Diff against Morphic-mt.1631 ===============
Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.!
Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!
Hm, should we maybe define #setErrorOnStep as a method stub on Object?
As an alternative to further dependencies from Kernel to Morphic, we could also define a trait TMorphicStepper. Opinions about this? :-)
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Thiede, Christoph Gesendet: Samstag, 29. Februar 2020 12:41:25 An: squeak-dev@lists.squeakfoundation.org Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1635.mcz
Ah yes, maybe I should add a section about the motivation of this commit:
#errorOnStep is still existing in the system; if the property is set, you can resume stepping over the debug menu of the failing morph. It would be nice if this worked again.
http://www.hpi.de/ ________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Samstag, 29. Februar 2020 12:39:20 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: Morphic-ct.1635.mcz
Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz
==================== Summary ====================
Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631
Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object?
=============== Diff against Morphic-mt.1631 ===============
Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.!
Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!
Hi Christoph,
what's the difference to the current situation? Errors in steps result in Morphs not being added back into the step list automatically. You will see only one debugger.
Best, Marcel Am 29.02.2020 12:52:47 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de:
Hm, should we maybe define #setErrorOnStep as a method stub on Object?
As an alternative to further dependencies from Kernel to Morphic, we could also define a trait TMorphicStepper. Opinions about this? :-) Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Thiede, Christoph Gesendet: Samstag, 29. Februar 2020 12:41:25 An: squeak-dev@lists.squeakfoundation.org Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1635.mcz Ah yes, maybe I should add a section about the motivation of this commit:
#errorOnStep is still existing in the system; if the property is set, you can resume stepping over the debug menu of the failing morph. It would be nice if this worked again. [http://www.hpi.de/] Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Samstag, 29. Februar 2020 12:39:20 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: Morphic-ct.1635.mcz Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz [http://source.squeak.org/inbox/Morphic-ct.1635.mcz]
==================== Summary ====================
Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631
Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object?
=============== Diff against Morphic-mt.1631 ===============
Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.!
Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!
Hi Marcel,
at the moment, the value of #errorOnStep is only requested but never updated. Concretely, this commit makes it possible to start stepping again via the debug menu. The responsible menu item is never shown at the moment because of a regression :-)
[cid:7438cafe-3aaf-4f25-9e5c-9a9e54640b61]
Best,
Christoph
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Taeumel, Marcel Gesendet: Montag, 2. März 2020 10:33:36 An: John Pfersich via Squeak-dev Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1635.mcz
Hi Christoph,
what's the difference to the current situation? Errors in steps result in Morphs not being added back into the step list automatically. You will see only one debugger.
Best, Marcel
Am 29.02.2020 12:52:47 schrieb Thiede, Christoph christoph.thiede@student.hpi.uni-potsdam.de:
Hm, should we maybe define #setErrorOnStep as a method stub on Object?
As an alternative to further dependencies from Kernel to Morphic, we could also define a trait TMorphicStepper. Opinions about this? :-)
________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von Thiede, Christoph Gesendet: Samstag, 29. Februar 2020 12:41:25 An: squeak-dev@lists.squeakfoundation.org Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1635.mcz
Ah yes, maybe I should add a section about the motivation of this commit:
#errorOnStep is still existing in the system; if the property is set, you can resume stepping over the debug menu of the failing morph. It would be nice if this worked again.
http://www.hpi.de/ ________________________________ Von: Squeak-dev squeak-dev-bounces@lists.squeakfoundation.org im Auftrag von commits@source.squeak.org commits@source.squeak.org Gesendet: Samstag, 29. Februar 2020 12:39:20 An: squeak-dev@lists.squeakfoundation.org Betreff: [squeak-dev] The Inbox: Morphic-ct.1635.mcz
Christoph Thiede uploaded a new version of Morphic to project The Inbox: http://source.squeak.org/inbox/Morphic-ct.1635.mcz
==================== Summary ====================
Name: Morphic-ct.1635 Author: ct Time: 29 February 2020, 12:39:08.00383 pm UUID: 1d028c27-ec3c-fd4f-924c-5c0372d0323e Ancestors: Morphic-mt.1631
Proposal: Revive #errorOnStep detection. Introduce #setErrorOnStep to keep it (quite) easy to add non-morphic receivers into the steplist (such as ObjectExplorer). Hm, should we maybe define #setErrorOnStep as a method stub on Object?
=============== Diff against Morphic-mt.1631 ===============
Item was added: + ----- Method: Morph>>setErrorOnStep (in category 'WiW support') ----- + setErrorOnStep + + self setProperty: #errorOnStep toValue: true.!
Item was added: + ----- Method: StepMessage>>value: (in category 'evaluating') ----- + value: anArgument + + ^ [super value: anArgument] + ifCurtailed: [ + (self receiver respondsTo: #setErrorOnStep) + ifTrue: [self receiver setErrorOnStep]]!
squeak-dev@lists.squeakfoundation.org