On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
Indeed. OTOH, stdout and stderr ARE kinds of StandardFileStreams so I question whether the location of _those_ accessors is appropriate, or whether they should be on StandardFileStream..?
On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
Well, I just mean that as a user of stdout I don't particularly care whether stdout is a StandardFileStream or a SpecialSnowflakeFileStream, so FileStream seems like the more appropriate receiver. (Also, it's a lot shorter. I'm sad enough about how long "FileStream" is.)
frank
On 30 October 2013 22:44, Chris Muller asqueaker@gmail.com wrote:
Indeed. OTOH, stdout and stderr ARE kinds of StandardFileStreams so I question whether the location of _those_ accessors is appropriate, or whether they should be on StandardFileStream..?
On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
On Wed, 30 Oct 2013, Chris Muller wrote:
Indeed. OTOH, stdout and stderr ARE kinds of StandardFileStreams so I question whether the location of _those_ accessors is appropriate, or whether they should be on StandardFileStream..?
You should use FileStream. The class of the actual streams depends on the value of the #encodeAndDecodeStdioFiles preference. Its value is true by default, which means that streams should be instances of MultiByteFileStream. If they are StandardFileStreams in your image, then you have changed the value of the preference.
Levente
On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
But MultiByteFileStream is-a StandardFileStream.
On Wed, Oct 30, 2013 at 10:46 PM, Levente Uzonyi leves@elte.hu wrote:
On Wed, 30 Oct 2013, Chris Muller wrote:
Indeed. OTOH, stdout and stderr ARE kinds of StandardFileStreams so I question whether the location of _those_ accessors is appropriate, or whether they should be on StandardFileStream..?
You should use FileStream. The class of the actual streams depends on the value of the #encodeAndDecodeStdioFiles preference. Its value is true by default, which means that streams should be instances of MultiByteFileStream. If they are StandardFileStreams in your image, then you have changed the value of the preference.
Levente
On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
On Thu, 31 Oct 2013, Chris Muller wrote:
But MultiByteFileStream is-a StandardFileStream.
Right, but this case is just an example of misuse of inheritance instead of encapsulation.
Levente
On Wed, Oct 30, 2013 at 10:46 PM, Levente Uzonyi leves@elte.hu wrote:
On Wed, 30 Oct 2013, Chris Muller wrote:
Indeed. OTOH, stdout and stderr ARE kinds of StandardFileStreams so I question whether the location of _those_ accessors is appropriate, or whether they should be on StandardFileStream..?
You should use FileStream. The class of the actual streams depends on the value of the #encodeAndDecodeStdioFiles preference. Its value is true by default, which means that streams should be instances of MultiByteFileStream. If they are StandardFileStreams in your image, then you have changed the value of the preference.
Levente
On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
FYI I sent Frank a private note that I've changed it to simply FileStream.
So I'm not trying to resist you, just making conversation.. :)
On Wed, Oct 30, 2013 at 10:46 PM, Levente Uzonyi leves@elte.hu wrote:
On Wed, 30 Oct 2013, Chris Muller wrote:
Indeed. OTOH, stdout and stderr ARE kinds of StandardFileStreams so I question whether the location of _those_ accessors is appropriate, or whether they should be on StandardFileStream..?
You should use FileStream. The class of the actual streams depends on the value of the #encodeAndDecodeStdioFiles preference. Its value is true by default, which means that streams should be instances of MultiByteFileStream. If they are StandardFileStreams in your image, then you have changed the value of the preference.
Levente
On Wed, Oct 30, 2013 at 5:09 PM, Frank Shearar frank.shearar@gmail.com wrote:
On 26 October 2013 20:17, commits@source.squeak.org wrote:
Chris Muller uploaded a new version of System to project The Trunk: http://source.squeak.org/trunk/System-cmm.610.mcz
==================== Summary ====================
Name: System-cmm.610 Author: cmm Time: 26 October 2013, 2:17:09.114 pm UUID: a27149c5-0fd6-4bef-a34a-57db707aec83 Ancestors: System-dtl.609
Consider valueWithAllPossibleArguments: special enough to inline, for now.
=============== Diff against System-dtl.609 ===============
Why "StandardFileStream stdout" and not "FileStream stdout"? The latter is shorter and more abstract.
frank
squeak-dev@lists.squeakfoundation.org
-
Chris Muller -
Chris Muller -
Frank Shearar -
Levente Uzonyi