Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
On Oct 25, 2010, at 5:58 PM, Lawson English wrote:
On 10/25/10 8:38 AM, Tim Felgentreff wrote:
We're currently compiling a set of changes that will allow OB and Refactory to work again in their latest respective versions. I'll test them and put them up on the ML/Inbox later today.
I talked with Lukas today about a possible OB-SqueakCompat package, what would the community think about that?
Regards Tim
I don't know if you saw my recent comment about the browser behavior. In Squeak 4.1 the version of OmniBrowser loaded by this script:
Installer squeaksource
project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'.(Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
works differently when PRDistribution or subclasses of PRDistribtion are highlighted.
Like as not, its part of other issues you are already working on, but just in case it's not...
Lawson
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff:
Kernel-topa.508, Compiler-tfel.175
Has anybody objections to these two packages moving to trunk? If not, please, can a trunk developer integrate them?
Thanks and So Long, -Tobias
Hi Tobias,
On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff:
Kernel-topa.508, Compiler-tfel.175
regarding Compiler-tfel.175 I don't dee the point of this change. The preference is already called Preferences>allowUnderscoreAssignment so if the idea is to move to a pragma-based preference more needs to be done, and I would call the method Scanner class>>allowUnderscoreAssignment, not add two extra selectors #allowUnderscoreAsAssignment and #prefAllowUnderscoreAssignments. What do these add except confusion?
best Eliot
Has anybody objections to these two packages moving to trunk? If not, please, can a trunk developer integrate them?
Thanks and So Long, -Tobias
On Wed, 27 Oct 2010, Eliot Miranda wrote:
Hi Tobias,
On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff:
Kernel-topa.508, Compiler-tfel.175
regarding Compiler-tfel.175 I don't dee the point of this change. The preference is already called Preferences>allowUnderscoreAssignment so if the idea is to move to a pragma-based preference more needs to be done, and I would call the method Scanner class>>allowUnderscoreAssignment, not add two extra selectors #allowUnderscoreAsAssignment and #prefAllowUnderscoreAssignments. What do these add except confusion?
In Pharo the preference accessor is called #allowUnderscoreAsAssignment in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices: - add Compiler-tfel.175 to the Trunk - rename the preference accessor in Squeak to #allowUnderscoreAsAssignment - add a Squeak compatibility package for OB which implements this method as in Compiler-tfel.175
Levente
best Eliot
Has anybody objections to these two packages moving to trunk? If not, please, can a trunk developer integrate them?
Thanks and So Long, -Tobias
Am 2010-10-27 um 22:52 schrieb Levente Uzonyi:
On Wed, 27 Oct 2010, Eliot Miranda wrote:
Hi Tobias,
On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff:
Kernel-topa.508, Compiler-tfel.175
regarding Compiler-tfel.175 I don't dee the point of this change. The preference is already called Preferences>allowUnderscoreAssignment so if the idea is to move to a pragma-based preference more needs to be done, and I would call the method Scanner class>>allowUnderscoreAssignment, not add two extra selectors #allowUnderscoreAsAssignment and #prefAllowUnderscoreAssignments. What do these add except confusion?
In Pharo the preference accessor is called #allowUnderscoreAsAssignment in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices:
- add Compiler-tfel.175 to the Trunk
- rename the preference accessor in Squeak to #allowUnderscoreAsAssignment
- add a Squeak compatibility package for OB which implements this method as in Compiler-tfel.175
Personally, I'm fine with either version, where the last one requires someone to be in charge of this Compat package. note that this message is required for AST, not OB directly, which does not make the whole thing easier.
So Long, -Tobias
On Wed, Oct 27, 2010 at 1:52 PM, Levente Uzonyi leves@elte.hu wrote:
On Wed, 27 Oct 2010, Eliot Miranda wrote:
Hi Tobias,
On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff:
Kernel-topa.508, Compiler-tfel.175
regarding Compiler-tfel.175 I don't dee the point of this change. The preference is already called Preferences>allowUnderscoreAssignment so if the idea is to move to a pragma-based preference more needs to be done, and I would call the method Scanner class>>allowUnderscoreAssignment, not add two extra selectors #allowUnderscoreAsAssignment and #prefAllowUnderscoreAssignments. What do these add except confusion?
In Pharo the preference accessor is called #allowUnderscoreAsAssignment in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices:
- add Compiler-tfel.175 to the Trunk
- rename the preference accessor in Squeak to #allowUnderscoreAsAssignment
- add a Squeak compatibility package for OB which implements this method as
in Compiler-tfel.175
Off the top of my head, only the latter makes sense. There are no senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Levente
best Eliot
Has anybody objections to these two packages moving to trunk?
If not, please, can a trunk developer integrate them?
Thanks and So Long, -Tobias
Am 2010-10-27 um 23:09 schrieb Eliot Miranda:
On Wed, Oct 27, 2010 at 1:52 PM, Levente Uzonyi leves@elte.hu wrote: On Wed, 27 Oct 2010, Eliot Miranda wrote:
Hi Tobias,
On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff: Kernel-topa.508, Compiler-tfel.175
regarding Compiler-tfel.175 I don't dee the point of this change. The preference is already called Preferences>allowUnderscoreAssignment so if the idea is to move to a pragma-based preference more needs to be done, and I would call the method Scanner class>>allowUnderscoreAssignment, not add two extra selectors #allowUnderscoreAsAssignment and #prefAllowUnderscoreAssignments. What do these add except confusion?
In Pharo the preference accessor is called #allowUnderscoreAsAssignment in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices:
- add Compiler-tfel.175 to the Trunk
- rename the preference accessor in Squeak to #allowUnderscoreAsAssignment
- add a Squeak compatibility package for OB which implements this method as in Compiler-tfel.175
Off the top of my head, only the latter makes sense. There are no senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Because its about AST ;)
SCNR -Tobias
On Wed, Oct 27, 2010 at 2:21 PM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-27 um 23:09 schrieb Eliot Miranda:
On Wed, Oct 27, 2010 at 1:52 PM, Levente Uzonyi leves@elte.hu wrote: On Wed, 27 Oct 2010, Eliot Miranda wrote:
Hi Tobias,
On Wed, Oct 27, 2010 at 7:36 AM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-25 um 18:08 schrieb Tim Felgentreff: Kernel-topa.508, Compiler-tfel.175
regarding Compiler-tfel.175 I don't dee the point of this change. The preference is already called Preferences>allowUnderscoreAssignment so if
the
idea is to move to a pragma-based preference more needs to be done, and I would call the method Scanner class>>allowUnderscoreAssignment, not add
two
extra selectors #allowUnderscoreAsAssignment and #prefAllowUnderscoreAssignments. What do these add except confusion?
In Pharo the preference accessor is called #allowUnderscoreAsAssignment
in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices:
- add Compiler-tfel.175 to the Trunk
- rename the preference accessor in Squeak to
#allowUnderscoreAsAssignment
- add a Squeak compatibility package for OB which implements this method
as in Compiler-tfel.175
Off the top of my head, only the latter makes sense. There are no
senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Because its about AST ;)
So why not an extension in AST? :)
SCNR -Tobias
Am 2010-10-27 um 23:25 schrieb Eliot Miranda:
Off the top of my head, only the latter makes sense. There are no senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Because its about AST ;)
So why not an extension in AST? :)
Where would you put that, better, where would you put AST-Core-Squeak…? or how one should name it…
So Long, -Tobias
On Wed, Oct 27, 2010 at 2:39 PM, Tobias Pape Das.Linux@gmx.de wrote:
Am 2010-10-27 um 23:25 schrieb Eliot Miranda:
Off the top of my head, only the latter makes sense. There are no
senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Because its about AST ;)
So why not an extension in AST? :)
Where would you put that, better, where would you put AST-Core-Squeak…? or how one should name it…
That's not my question to answer. But why add a method with no senders in Compiler, that is needed by AST (and transitively by OB) to Compiler rather than somewhere appropriate in AST?
best, Eliot
So Long, -Tobias
On 10/27/2010 2:09 PM, Eliot Miranda wrote:
In Pharo the preference accessor is called #allowUnderscoreAsAssignment in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices: - add Compiler-tfel.175 to the Trunk - rename the preference accessor in Squeak to #allowUnderscoreAsAssignment - add a Squeak compatibility package for OB which implements this method as in Compiler-tfel.175Off the top of my head, only the latter makes sense. There are no senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Why not rename it? There is little reason to insist that the preference accessor must be called exactly this or that.
Cheers, - Andreas
On 27.10.2010, at 23:43, Andreas Raab wrote:
On 10/27/2010 2:09 PM, Eliot Miranda wrote:
In Pharo the preference accessor is called #allowUnderscoreAsAssignment in Squeak it's #prefAllowUnderscoreAssignments. The OB code uses the Pharo version, since OB is developed for Pharo. So there are three choices:
- add Compiler-tfel.175 to the Trunk
- rename the preference accessor in Squeak to
#allowUnderscoreAsAssignment
- add a Squeak compatibility package for OB which implements this
method as in Compiler-tfel.175
Off the top of my head, only the latter makes sense. There are no senders of allowUnderscoreAsAssignment in the base Compiler package so one would be tempted to delete it. Why can't it be an extension in OB?
Why not rename it? There is little reason to insist that the preference accessor must be called exactly this or that.
Cheers,
- Andreas
+1
Just use the Pharo selector. No need to differ unless there is a good reason.
- Bert -
On Mon, 25 Oct 2010, Tim Felgentreff wrote:
Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
The changes are in the Trunk, but if I evaluate this script:
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
Levente
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
Yes, but we cannot use Lukas' versions - they are dependent on polymorph.
On Oct 28, 2010, at 4:18 PM, Levente Uzonyi wrote:
On Mon, 25 Oct 2010, Tim Felgentreff wrote:
Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
The changes are in the Trunk, but if I evaluate this script:
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
Levente
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
Also: Hmmm. Works here... Any errors?
On Oct 28, 2010, at 5:01 PM, Tim Felgentreff wrote:
Yes, but we cannot use Lukas' versions - they are dependent on polymorph.
On Oct 28, 2010, at 4:18 PM, Levente Uzonyi wrote:
On Mon, 25 Oct 2010, Tim Felgentreff wrote:
Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
The changes are in the Trunk, but if I evaluate this script:
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
Levente
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
On Thu, 28 Oct 2010, Tim Felgentreff wrote:
Also: Hmmm. Works here... Any errors?
It's a DNU. The relevant part of the stack trace is here:
ORPackageBrowser(Object)>>doesNotUnderstand: #definitionPanel Receiver: an ORPackageBrowser Arguments and temporary variables: aMessage: definitionPanel exception: MessageNotUnderstood: ORPackageBrowser>>definitionPanel resumeValue: nil Receiver's instance variables: panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc... announcer: an OBAnnouncer cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc... hasChanges: nil
ORPackageBrowser(OREnvironmentBrowser)>>selectionChanged: Receiver: an ORPackageBrowser Arguments and temporary variables: anAnnouncement: an OBSelectionChanged interval: nil Receiver's instance variables: panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc... announcer: an OBAnnouncer cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc... hasChanges: nil
It I change the implementation to:
OREnvironmentBrowser >> selectionChanged: anAnnouncement | interval | interval := self environment selectionIntervalFor: self class definitionPanel text. interval isNil ifFalse: [ self definitionPanel selection: interval ]
then it works.
Levente
On Oct 28, 2010, at 5:01 PM, Tim Felgentreff wrote:
Yes, but we cannot use Lukas' versions - they are dependent on polymorph.
On Oct 28, 2010, at 4:18 PM, Levente Uzonyi wrote:
On Mon, 25 Oct 2010, Tim Felgentreff wrote:
Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
The changes are in the Trunk, but if I evaluate this script:
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
Levente
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
I have updated the Metacello configurations for OmniBrowser and RefactoringBrowser. Together with the OCompletion update we can now load OmniBrowser dev with OCompletion and Refactoring tools enabled.
This loads the (currently) latest refactoring tools, the new OCompletion and the newest OB packages we have in the wiresong repo.
Let me know if it works!
-Tim
On Oct 28, 2010, at 5:13 PM, Levente Uzonyi wrote:
On Thu, 28 Oct 2010, Tim Felgentreff wrote:
Also: Hmmm. Works here... Any errors?
It's a DNU. The relevant part of the stack trace is here:
ORPackageBrowser(Object)>>doesNotUnderstand: #definitionPanel Receiver: an ORPackageBrowser Arguments and temporary variables: aMessage: definitionPanel exception: MessageNotUnderstood: ORPackageBrowser>>definitionPanel resumeValue: nil Receiver's instance variables: panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc... announcer: an OBAnnouncer cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc... hasChanges: nil
ORPackageBrowser(OREnvironmentBrowser)>>selectionChanged: Receiver: an ORPackageBrowser Arguments and temporary variables: anAnnouncement: an OBSelectionChanged interval: nil Receiver's instance variables: panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc... announcer: an OBAnnouncer cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc... hasChanges: nil
It I change the implementation to:
OREnvironmentBrowser >> selectionChanged: anAnnouncement | interval | interval := self environment selectionIntervalFor: self class definitionPanel text. interval isNil ifFalse: [ self definitionPanel selection: interval ]
then it works.
Levente
On Oct 28, 2010, at 5:01 PM, Tim Felgentreff wrote:
Yes, but we cannot use Lukas' versions - they are dependent on polymorph.
On Oct 28, 2010, at 4:18 PM, Levente Uzonyi wrote:
On Mon, 25 Oct 2010, Tim Felgentreff wrote:
Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
The changes are in the Trunk, but if I evaluate this script:
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
Levente
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
On Thu, 28 Oct 2010, Tim Felgentreff wrote:
I have updated the Metacello configurations for OmniBrowser and RefactoringBrowser. Together with the OCompletion update we can now load OmniBrowser dev with OCompletion and Refactoring tools enabled.
This loads the (currently) latest refactoring tools, the new OCompletion and the newest OB packages we have in the wiresong repo.
Let me know if it works!
It works, thanks.
Levente
-Tim
On Oct 28, 2010, at 5:13 PM, Levente Uzonyi wrote:
On Thu, 28 Oct 2010, Tim Felgentreff wrote:
Also: Hmmm. Works here... Any errors?
It's a DNU. The relevant part of the stack trace is here:
ORPackageBrowser(Object)>>doesNotUnderstand: #definitionPanel Receiver: an ORPackageBrowser Arguments and temporary variables: aMessage: definitionPanel exception: MessageNotUnderstood: ORPackageBrowser>>definitionPanel resumeValue: nil Receiver's instance variables: panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc... announcer: an OBAnnouncer cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc... hasChanges: nil
ORPackageBrowser(OREnvironmentBrowser)>>selectionChanged: Receiver: an ORPackageBrowser Arguments and temporary variables: anAnnouncement: an OBSelectionChanged interval: nil Receiver's instance variables: panels: an OrderedCollection(an OBMercuryPanel an OBColumnPanel an OBFixedButto...etc... announcer: an OBAnnouncer cmdFactories: {OBCmdNewClassTemplate . ORCmdRefactoringRedo . ORCmdRefactoringU...etc... hasChanges: nil
It I change the implementation to:
OREnvironmentBrowser >> selectionChanged: anAnnouncement | interval | interval := self environment selectionIntervalFor: self class definitionPanel text. interval isNil ifFalse: [ self definitionPanel selection: interval ]
then it works.
Levente
On Oct 28, 2010, at 5:01 PM, Tim Felgentreff wrote:
Yes, but we cannot use Lukas' versions - they are dependent on polymorph.
On Oct 28, 2010, at 4:18 PM, Levente Uzonyi wrote:
On Mon, 25 Oct 2010, Tim Felgentreff wrote:
Hello
There are currently two packages in the inbox (Kernel-topa.508, Compiler-tfel.175) which enable AST, Refactoring-*, VB-Regex and the useful OB packages (Standard, Core, Morphic, Regex, Refactory, Shout) to load in trunk.
The changes are in the Trunk, but if I evaluate this script:
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
and file in your changeset, I still can't use the "browse package" feature. I think this is because the latest RB on squeaksource is not compatibile with the OB in the wiresong repository. Lukas uses his own OB repository for developement.
Levente
Attached you will find a ChangeSet that, if applied after loading all of the packages, fixes all but 12 failures and 1 error in the aforementioned packages' tests.
Regards Tim
Tim Felgentreff wrote:
Let me know if it works!
Thanks, I can't live without RB!!!
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
In both 4.1 and 4.2.10628 gave me a browser that opens, but: * doesn't seem to do anything refectory - push up gives "MessageNotUnderstood: AnObsoletePushUpMethodRefactoring class>>model:pushUp:from:" - extract method opens confirmation window, but "accept" does nothing * buttons, e.g. Hierarchy, do nothing.
Down for everyone, or just me?
Sean
On Fri, 29 Oct 2010, Sean P. DeNigris wrote:
Tim Felgentreff wrote:
Let me know if it works!
Thanks, I can't live without RB!!!
Installer squeaksource project: 'MetacelloRepository'; install: 'ConfigurationOfOmniBrowser'. (Smalltalk at: #ConfigurationOfOmniBrowser) project lastVersion load: #( Dev ).
In both 4.1 and 4.2.10628 gave me a browser that opens, but:
- doesn't seem to do anything refectory
- push up gives "MessageNotUnderstood: AnObsoletePushUpMethodRefactoring
class>>model:pushUp:from:"
- extract method opens confirmation window, but "accept" does nothing
- buttons, e.g. Hierarchy, do nothing.
Down for everyone, or just me?
You didn't file in Tim's changeset. Here's a link: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20101025/...
Levente
Sean
View this message in context: http://forum.world.st/refactoring-browser-in-Squeak-tp3010490p3019893.html Sent from the Squeak - Dev mailing list archive at Nabble.com.
Levente Uzonyi-2 wrote:
You didn't file in Tim's changeset. Here's a link: http://lists.squeakfoundation.org/pipermail/squeak-dev/attachments/20101025/...
Okay, changeset filed it - errors have disappeared.
The buttons on the OB System Browser still don't work (4.2.10628) + ConfigOfOB + changeset. The buttons have "yourself" as the actionSelector instead of "execute". I found that it was set in OBButtonBar>>buttonFor: aCommand ... action: (aCommand isActive ifTrue: [ #execute ] ifFalse: [ #yourself ]) ...
I changed this to "action: #execute" for the moment, so they work. But now they work all the time, even when not appropriate e.g. Browse when no class selected. The browser seems to not be updating the action selector of the buttons when appropriate, but I'm not sure where that should be happening.
That's as far as I got.
Sean
This is the changeset to get the buttons to work. http://forum.world.st/file/n3071977/OBButtonBar-buttonFor.st OBButtonBar-buttonFor.st
n.b. It is just a hack to hold us over until it's properly fixed.
Sean
On Oct 30, 2010, at 2:08 AM, Sean P. DeNigris wrote:
- extract method opens confirmation window, but "accept" does nothing
- buttons, e.g. Hierarchy, do nothing.
Hi
The buttons currently don't work properly (looking into that), but hitting the 'accept' key combination will accept the refactoring.
-Tim
squeak-dev@lists.squeakfoundation.org
-
Andreas Raab -
Bert Freudenberg -
Eliot Miranda -
Levente Uzonyi -
Sean P. DeNigris -
Tim Felgentreff -
Tobias Pape